[koha-commits] main Koha release repository branch master updated. v3.22.00-833-g361ee8b
Git repo owner
gitmaster at git.koha-community.org
Wed Mar 9 16:09:40 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 361ee8beabc6fbb1ffd37c12e05b5394e527a442 (commit)
via 0c403490963a2f57b563c0bd11845cd0cf198181 (commit)
from d25c7f9232c79cc1d52c76da6c17d23fb801fb87 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 361ee8beabc6fbb1ffd37c12e05b5394e527a442
Author: Brendan A Gallagher <brendan at bywatersolutions.com>
Date: Wed Mar 9 15:14:48 2016 +0000
DBRev Bug 15084 - Move the currency related code to
Koha::Acquisition::Currenc[y|ies]
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
commit 0c403490963a2f57b563c0bd11845cd0cf198181
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 9 13:29:08 2016 +0100
Bug 15084: [QA Follow-up] Correct field length of currency
Bug 15084 added a FK constraint while the fields in the database are not
in sync as to length. This will produce errors when using currency codes
longer than three characters. Probably you won't, but nobody stopped
users from entering EURO or DOLLAR etc. Not to speak about TestBuilder
too.
This patch corrects the database revision for aqorders in updatedatabase,
because we need to change the field length before adding the FK constraint.
It also updates other currency fields < 10 chars (via atomicupdate).
RM: So please add that dbrev too in updatedatabase.
Note that another report should deal with adding missing constraints on
the currency code in suggestions and aqbooksellers.
Also note that the aqorder fields listprice and invoiceprice refer to
currency. Imo these are very poor names for currency codes; you should
never call something a price when you mean a currency code!
Similar changes are applied to kohastructure.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested the db revisions.
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
installer/data/mysql/kohastructure.sql | 6 +++---
installer/data/mysql/updatedatabase.pl | 21 +++++++++++++++++++--
3 files changed, 23 insertions(+), 6 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list