[koha-commits] main Koha release repository branch master updated. v3.22.00-858-g987874f
Git repo owner
gitmaster at git.koha-community.org
Sun Mar 13 00:25:20 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 987874f4d866aa89e1cc34062f4bd2b001c52b46 (commit)
from 7742d8911b08516bc3fae9ea01aa3d5ad576b06a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 987874f4d866aa89e1cc34062f4bd2b001c52b46
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 4 08:27:43 2016 -0500
Bug 15978: Use Font Awesome icons for guided reports error dialog
If you try to save an SQL report with an invalid authorized value
placeholder you will be presented with a confirmation dialog. This patch
updates it to use Font Awesome icons.
Also fixed: Validation error found in testing: Duplicated <form> tag and
series of redundant inputs. Each input cut had an exact duplicate in the
same form.
To test, apply the patch and go to Reports -> Create from SQL.
- Create a new SQL report and fill in as many fields as possible to
verify correct operation.
- Try to save your report with an invalid authorized value
placeholder, for example: SELECT * FROM items WHERE items.itype =
<<foo|bar>>
- Confirm that the confirmation dialog is styled correctly.
- Test the operation of the "Edit SQL" button. You should be sent back a
page.
- Test the operation of the "Save anyway" button and confirm that your
report was saved.
- Repeat these steps when editing an existing report.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
-----------------------------------------------------------------------
Summary of changes:
.../en/modules/reports/guided_reports_start.tt | 80 ++++++++------------
1 file changed, 33 insertions(+), 47 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list