[koha-commits] main Koha release repository branch master updated. v3.22.00-882-g55b78f1
Git repo owner
gitmaster at git.koha-community.org
Tue Mar 15 08:02:16 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 55b78f1a5dbbff5a790971e2f5a99ebdd6a3f18a (commit)
via 47fbbb7cf5e7ef2f9ef422e2fd9232066100a64b (commit)
via 2eaf2cd71b9620c0d5782c7c78f86a5e323c89a4 (commit)
via d4039ce09347c342f8ac048814ee10b47819df48 (commit)
via f25e3ed90b55b657c71e117a1e9a8bc2c3a1809f (commit)
via 3907401a6d293872ca1fb46c90da029b91d37e31 (commit)
via a691e88a4ebf57e9ebda8afb5f8e6bac33bc6ad6 (commit)
via 56a782c666d1d05215e49101e33fce0a3cd30377 (commit)
via 9820f9dfbd63ecc812b6b2a4ec71af91f303f933 (commit)
from fc640d2a86f395ad392f84314bce22e8b4dab1fe (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 55b78f1a5dbbff5a790971e2f5a99ebdd6a3f18a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 10 09:12:52 2016 +0000
Bug 11998: Clear L1 cache from psgi files
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 47fbbb7cf5e7ef2f9ef422e2fd9232066100a64b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 10 08:55:27 2016 +0000
Bug 11998: Add a L1 cache for sysprefs
Accessing to the cache for each call to C4::Context->preference might
have an impact on performances.
To avoid that this patch introduces a L1 cache (simple hashref). It will
be populated by accessing the L2 cache (Koha::Cache).
If a pref is retrieved 10x, the first one will get the value from the L2
cache, then the L1 cache will be check.
To do so we will need to clear the L1 cache every time a page is loaded.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 2eaf2cd71b9620c0d5782c7c78f86a5e323c89a4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:52:51 2016 +0000
Bug 11998: follow-up for the debian package psgi file
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit d4039ce09347c342f8ac048814ee10b47819df48
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:45:07 2016 +0000
Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache"
This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58.
Bug 13805 fixes an installer bug by disabling the syspref cache.
It was not a good idea, it introduced performance issues (see bug 13805
comment 14).
Test plan:
Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
You should not get the login form again.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Test plan not followed by me for this patch, due to lack of working
plack setup, but I don't expect it to cause any problems, and performace
gain for plack will be tremendous
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit f25e3ed90b55b657c71e117a1e9a8bc2c3a1809f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 17:17:40 2016 +0000
Bug 11998: Do not clear syspref cache in psgi file
This in only in koha.psgi, it has been introduced by bug 13815 but
should not have been added by this patch.
Removing it should not introduce any changes.
Not that it won't impact debian packages.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 3907401a6d293872ca1fb46c90da029b91d37e31
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 7 09:24:14 2016 +0000
Bug 11998: Make HoldsQueue.t tests pass [TO REVERT]
This patch should not be the way to make these tests pass.
The prefs should not be updated using set_preference, it will modify the
values in the cache.
I have no idea how to make them pass using the correct way, please help
:)
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit a691e88a4ebf57e9ebda8afb5f8e6bac33bc6ad6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 4 13:21:39 2016 +0000
Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm
Otherwise some tests won't pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 56a782c666d1d05215e49101e33fce0a3cd30377
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 4 13:14:59 2016 +0000
Bug 11998: Use t::lib::Mocks::mock_preference in tests
Unless in t/db_dependent/Context.t where we want to test the cache
behaviors.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
commit 9820f9dfbd63ecc812b6b2a4ec71af91f303f933
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:54:30 2016 +0000
Bug 11998: Use Koha::Cache to cache sysprefs
At the moment, the sysprefs are only cache in the thread memory
executing the processus
When using Plack, that means we need to clear the syspref cache on each
page.
To avoid that, we can use Koha::Cache to cache the sysprefs correctly.
A big part of the authorship of this patch goes to Robin Sheat.
Test plan:
1/ Add/Update/Delete local use prefs
2/ Update pref values and confirm that the changes are correctly taken
into account
Signed-off-by: Chris <chrisc at catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it?
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Tested with CGI and CGI + memcache; some small issues still remain,
but it would be better to deal with them in separate bug reports
if necessary
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
-----------------------------------------------------------------------
Summary of changes:
C4/Context.pm | 106 +++++++++++++++++-----
Koha/Config/SysPref.pm | 32 +++++++
Koha/Schema/Result/Item.pm | 7 +-
admin/preferences.pl | 1 -
admin/systempreferences.pl | 61 +++----------
debian/templates/plack.psgi | 3 +-
misc/admin/koha-preferences | 2 +-
misc/plack/koha.psgi | 4 +-
svc/config/systempreferences | 2 -
t/db_dependent/Amazon.t | 19 ++--
t/db_dependent/Auth.t | 7 +-
t/db_dependent/Auth_with_cas.t | 5 +-
t/db_dependent/Bookseller.t | 5 +-
t/db_dependent/Circulation.t | 45 ++++-----
t/db_dependent/Circulation/GetTopIssues.t | 3 +-
t/db_dependent/Circulation/Returns.t | 5 +-
t/db_dependent/Circulation_Branch.t | 3 +-
t/db_dependent/Circulation_issue.t | 5 +-
t/db_dependent/Context.t | 11 ++-
t/db_dependent/Hold.t | 5 +-
t/db_dependent/Holds.t | 12 +--
t/db_dependent/Items.t | 26 +++---
t/db_dependent/Koha/Patron/Messages.t | 9 +-
t/db_dependent/Koha_template_plugin_KohaDates.t | 7 +-
t/db_dependent/Languages.t | 5 +-
t/db_dependent/Letters.t | 2 +-
t/db_dependent/Members.t | 19 ++--
t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t | 5 +-
t/db_dependent/QueryParser.t | 3 +-
t/db_dependent/Record.t | 7 +-
t/db_dependent/Reserves.t | 32 +++----
t/db_dependent/Suggestions.t | 5 +-
t/db_dependent/XISBN.t | 9 +-
t/db_dependent/default_search_class.pl | 3 +-
t/db_dependent/sysprefs.t | 15 ++-
35 files changed, 291 insertions(+), 199 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list