[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.09-40-g7c486bc
Git repo owner
gitmaster at git.koha-community.org
Tue Mar 15 09:59:59 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.20.x has been updated
via 7c486bc899b46e605a3080ab27e47202d4b7ee14 (commit)
via a756d74f03cb718f03678b9566d6dec861314d2d (commit)
via 9eec358ec6eb007c570b11982ef5cb979dbc37c6 (commit)
via 4671a6cfe69fa2d473620c539dac977240adab3a (commit)
via 4874e158414de8fd657e42a8084032b3309d9909 (commit)
via da75cdb0ff1c5d6fee8689461dac65b8710ef32b (commit)
via e7af53a4dbfcbe02c76dc9ff66281a7aa4ecb5d6 (commit)
via bab470c7805ccfc6296be1005279add8aa20623a (commit)
via e0b2ffd187540e43240477ed7280c84335e5a269 (commit)
via 69f9570ecd0d6f03957588c4749f3b0c14cd2efd (commit)
via f23d74c2be65deb3762f5cf51d2a29b8f732d1b2 (commit)
via 73dad0648429b0ce0724092ffa67dc7d72a61953 (commit)
via d3c1dfcc49c879a7457519dc0144691ef097ecec (commit)
via 3f0313253da712920fb08935e7272237b5adde6b (commit)
via 9fe4546dc15918ba20e96686886d94c416fb1cc7 (commit)
via 3e756ef8080541d0a604e8781c1f8f6deb38b54d (commit)
via 8d8dd2ebaece647663da5b8aeb8ebd3706f9ef1e (commit)
via a084fee0a66aa0d863740a99a3b018d71d426f8d (commit)
via af4e2c60419ea007b75f2246d032b6de213cd2c8 (commit)
via 03e133ba26fe7d457080979c1f874aa8262829a0 (commit)
via 74b1b26691a0c8d88f530f36075a1fa2c934d116 (commit)
via 7f787efafa1916da648d459ed6f6f2765264322e (commit)
via 74b4011eb8954d27d9c7dedf17d2f822f6c86cf1 (commit)
via 80a750e6af3786eaa676487302a5feb426e6d1fb (commit)
via a8e33e33e79fd160677e1718e94173e690a87a76 (commit)
via cf9ab256560dee8a7fb63c449561b1fdf9c699af (commit)
via 6e2e6389499d57fb1c0469cd713e13e13d7c12a6 (commit)
via 390e106781f80f6c265be1448be27a464c08efd1 (commit)
via e6fad0c7861d6853e4fa47dce555a9a32c9a6225 (commit)
via e7604dd4b8f6769cadb3b749a28722307e7845af (commit)
via 9fc70f8a0cf6fa6fda369837726e73b91b6cdf40 (commit)
via bfd565089ec4845b1390b760a30b922a6445116b (commit)
via d2111ff7cf6107639ba332fae18b32609b6c1d53 (commit)
via cef47596049765dd595517dc7d637b0bbe87cef6 (commit)
via ce80123c2fdf0470420f70d936ac2377ccd75140 (commit)
via fd51df2ccfc3a52676dd1a1922cbd05fc546a61e (commit)
via f0198977186b722e43f9489d6a44856b9603f1ed (commit)
via 56f83da3939dcaaf0ee8a5a672045ac4e9cde714 (commit)
via 7827be93a74c9f828e99001cffb6964683f45913 (commit)
from 7edf8ec28b9d5d15932fd054495f0252535a04b5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7c486bc899b46e605a3080ab27e47202d4b7ee14
Author: Zeno Tajoli <z.tajoli at cineca.it>
Date: Wed Mar 2 13:01:22 2016 +0100
Bug 15955: Tuning function 'New child record' for Unimarc 205$a -> 461$e
Now the sYstem tries to insert value of 205$a into 461$a when a child is
created from the father record. In UNIMARC 46x tags there is not
present a subfield for ediction value (205$a in UNIMARC).
To Test:
1) Check to have EasyAnalyticalRecords on 'off'
2) Check to use UNIMARC
3) Create a record with data in 200$a (title), 205$a (ediction), 700
(author) 215$a(Place), 215$d(date)
4) From those record create a child using 'New'->'New child record'
5) See the values in 461 tag: You can see that in 461$a there is the
value of 205$a from father This is wrong, you need to have the value
of 700 $a and $b from father record, and 205$a in 461$e.
6) Appy the patch
7) Redo 4-5
8) Now 461 is good
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
I have not checked the doc but trusting author and signoffer.
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 69cf2d9451ce3839bbbf16d91da0cc02a479e1f5)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 78e5a99b7462d4b873423c682f8aaca9c61e93ef)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a756d74f03cb718f03678b9566d6dec861314d2d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 29 14:39:30 2016 -0500
Bug 15941 - The template for cloning circulation and fine rules says "issuing rules"
The template for cloning circulation and fine rules should use the
phrase "circulation and fine rules" instead of "issuing rules."
Also changed: Added "Cancel" link to return the user to the circulation
and fine rules page.
To test, navigate directly to /cgi-bin/koha/admin/clone-rules.pl.
The page title, breadcrumbs, and heading should all use the phrase
"circulation and fine rules."
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 92544ea10d76c1a9f604c9c60ee33dc50e39d7fc)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit bcaf129e2e2a6fa26055788c746f99eef19b9634)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9eec358ec6eb007c570b11982ef5cb979dbc37c6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Mar 9 14:49:40 2016 -0500
Bug 16033 - Quotes upload preview broken for 973 days
A missing snippet of DataTable configuration means that when you upload
a CSV of quotes to the Quotes of the Day feature the table previewing
your import is not visible. This patch corrects it.
To test, apply the patch and go to Tools -> Quote editor -> Import
quotes.
- Upload a CSV file containing data in two columns, "source","text"
- When your upload completes you should see a DataTable previewing the
data from your CSV.
- Check that deletion of individual quotes works from the preview.
- Check that quotes are correctly imported.
- Ponder the long 2.66 years during which this page was broken.
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Quote of the day: Serenity of mind comes with patience.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 54214c4016d3d20da44047df41034fd752c50591)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 618bb26c212511dd8e94822aaabc80729d788527)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4671a6cfe69fa2d473620c539dac977240adab3a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Mar 9 11:57:47 2016 +0000
Bug 16014: Display a warning on deleting OAI sets
A JavaScript alert should ask the user to confirm deletion of a OAI set.
Test plan:
Define a OAI set
Delete it
=> With this patch you should get a warning
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 5dc392f6638b7723a95007afadb23d2872c3f19f)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 7db11e9565fb94b0fe4c4c27b029c8dc71103f61)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4874e158414de8fd657e42a8084032b3309d9909
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 4 12:07:44 2016 -0500
Bug 15982 - Serials numbering patterns can be deleted without warning
A JavaScript alert should ask the user to confirm deletion of a serial
numbering pattern. This patch adds this to the template.
To test, apply the patch and go to Serials -> Manage numbering patterns.
- In the list of patterns, click any "Delete" link.
- Verify that a JavaScript alert is triggered.
- Test that cancelling the alert cancels the deletion operation.
- Test that confirming the alert allows the deletion to complete.
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 6179f04c8afcbc965756cf7daea039be986727d7)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit ee5780d4b7e3c83ad81610da259029cbe8c4ebde)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit da75cdb0ff1c5d6fee8689461dac65b8710ef32b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 4 11:52:25 2016 -0500
Bug 15981 - Serials frequencies can be deleted without warning
A JavaScript alert should ask the user to confirm deletion of a serial
frequency. This patch adds this to the template.
To test, apply the patch and go to Serials -> Manage frequencies
- In the list of frequencies, click any "Delete" link.
- Verify that a JavaScript alert is triggered.
- Test that cancelling the alert cancels the deletion operation.
- Test that confirming the alert allows the deletion to complete.
Signed-off-by: Nicole C Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 4e82b8db94ee24ebd49541c25a6dac55cb8d543c)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 5d429ae9a797bb80ddf7482ef03b108456c9318a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e7af53a4dbfcbe02c76dc9ff66281a7aa4ecb5d6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 11:35:14 2016 +0000
Bug 15968: Unnecessary loop in C4::Templates
From C4::Templates::output
# add variables set via param to $vars for processing
for my $k ( keys %{ $self->{VARS} } ) {
$vars->{$k} = $self->{VARS}->{$k};
}
This loop is not necessary, we could do the same with
$vars = { %$vars, %{ $self->{VARS} } };
After a quick benchmark, it gains 100 microseconds when we pass 170 vars
to the template.
Test plan:
Do some clicks on the interface, everything should be ok.
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Perl idiosyncratic way of merging hash, clearer, if not quicker (not
verified)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 9be221b14eee137f4143e4a2243eadfb03fcfbbc)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 1543db81c7e6ba0c8501cf19452ba3d08f842680)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit bab470c7805ccfc6296be1005279add8aa20623a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Feb 2 14:31:34 2016 +0000
Bug 15697 - [QA Followup] Apply change to NORMARC
This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes
apply to MARC21 and NORMARC and UNIMARC remains unaffected
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 566daf8c24ad577da1b07c190979ada67877bed7)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 70efd64b4727adb58a5b6f54334cb622fb9d0b8f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e0b2ffd187540e43240477ed7280c84335e5a269
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 28 20:33:58 2016 +0000
Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl
To test:
1 - Go to Administration->Keyword to MARC mapping
2 - Add a mapping (or ensure it exists)
Field name: subtitle
MARC field: 245
MARC subfield: b
3 - View a record with a subtitle in the opac
4 - Note in MARC 21 you have "Title of record:, subtitle of record"
5 - Apply patch
6 - View the record again and note the comma is no longer present.
Note: this patch removes the comma only for MARC21 where subtitle is not
repeatable. UNIMARC seems to be repeatable and does not include
punctuation so I believe this may be needed there.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described. Comma removed from title of the window and breadcrumb
section
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit e19db8ca32dd776263b73474ece4e17d88ab17b4)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 889a2f7a6c96e8b4d597b60464b6110098da7518)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 69f9570ecd0d6f03957588c4749f3b0c14cd2efd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 29 13:39:16 2016 -0500
Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure
The authorities MARC subfield structure template contains some unused
JavaScript, "function displayMoreConstraint()" This patch removes it.
To test, apply the patch and go to Administration -> Authority types ->
MARC structure -> Subfields -> Edit subfields and confirm that there are
no JavaScript errors and tab switching works correctly.
A search of the source code should show no instances of
"displayMoreConstraint."
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
No regression, no JS warning.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 3f70b4660bf57e854e6ef13b04fb29de57c53bec)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 3c9ed309ba2e308800e9c596c3c28d4a911813d2)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f23d74c2be65deb3762f5cf51d2a29b8f732d1b2
Author: Nicole C Engard <nengard at bywatersolutions.com>
Date: Fri Feb 26 16:03:26 2016 +0000
Bug 15926: Add help for item search fields admin
This patch will add the missing help file to the item
search fields admin page.
To test:
* Go to administration > Item search fields
* Click Help
* Confirm help is there and correct.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit ac3e13248abd9687bbce764d1f1b6be39921b552)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit e9b25fb1a182d4fc58fa1104b7cd896f7c7cc97d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 73dad0648429b0ce0724092ffa67dc7d72a61953
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 23 09:16:13 2016 -0500
Bug 15884 - Vendor contract deletion warning is incorrectly styled
When deleting a contract in Acquisitions -> Vendor -> Contracts, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.
To test, apply the patch and go to Acquisitions -> [ a vendor] ->
Contracts
- Try deleting a contract. The confirmation box should have the standard
"dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
correctly.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit a4f1103e416357dc0635f4d5347d50ff68457459)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit d3c1dfcc49c879a7457519dc0144691ef097ecec
Author: Marc Véron <veron at veron.ch>
Date: Fri Feb 12 10:19:00 2016 +0100
Bug 15808 - Remove "Return to where you were before" from sysprefs
This patch removes the link 'return to where you were before' from
syspref search result page after failing search.
To test:
- Apply patch
- Go to System preferences in staff client, do a search
with something that does not exist
- Verify that a message pops up that does not contain the link.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 34b79932f79f83fbca528083cacbb61f157c05cb)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 4cbc77e639f3b3dde46067711a1c8d59d6384213)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 3f0313253da712920fb08935e7272237b5adde6b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Feb 11 12:23:49 2016 -0500
Bug 15804: Use standard dialog style for confirmation of MARC subfield deletion
When deleting a MARC framework subfield, the confirmation message is not
styled. This patch modifies the template to style the confirmation
message like similar ones.
To test, apply the patch and go to Administration -> MARC framworks.
- Click 'MARC structure' for a framework you can edit.
- Click 'subfields' for a tag you can edit.
- Click 'Delete' for a subfield you can delete. You should see a
confirmation dialog styled like other "alert" type dialogs.
- Test both canceling and confirming deletion to confirm that both
function correctly.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 8323259d8401907975446af35f2a018748d35e40)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9fe4546dc15918ba20e96686886d94c416fb1cc7
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 3 08:40:20 2016 -0500
Bug 15784: Library deletion warning is incorrectly styled
When deleting a library in Administration -> Libraries and groups, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.
To test, apply the patch and go to Administration -> Libraries and
groups.
- Try deleting a library. The confirmation box should have the standard
"dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
correctly.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit cfb46e45cb74fdc4a42bb48df78fe820d31fdc86)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 3e756ef8080541d0a604e8781c1f8f6deb38b54d
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Tue Mar 1 10:12:29 2016 -0300
Bug 15721: (QA followup) pick the most probable first
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 16548d39840c92d43a64ca08f63231156935c41c)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 5edc50888d7e1328919c0e60b6baeb0eb5dd02ba)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8d8dd2ebaece647663da5b8aeb8ebd3706f9ef1e
Author: Marc Véron <veron at veron.ch>
Date: Fri Feb 19 16:52:48 2016 +0100
Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions
See comment #6
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 019634fc5b010324de8adde38f49239a816a519c)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit f4272b467cfe098d8031cb18353ff06f915c5172)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a084fee0a66aa0d863740a99a3b018d71d426f8d
Author: Marc Véron <veron at veron.ch>
Date: Tue Feb 2 11:34:16 2016 +0100
Bug 15721: About page does not display Apache version
This patch changes about.pl to get version information from
C4::Context where applicable and fixes missing display of
the Apache version e.g. for Apache/2.2.22
To test:
- Without patch, open about page in staff client
- Remember contents of tab 'Server information'
(e.g. make a screenshot)
- Apply patch
- Verify, that the About page displays the same information
as before rsp. additionally displays Apache version if
it was missing without patch.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit c2fe13c13ad286e6fc67240624eee6d95c5e7334)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 62bf20ad39377a61e7a500155ef5d4c51717c028)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit af4e2c60419ea007b75f2246d032b6de213cd2c8
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Feb 1 18:12:44 2016 -0500
Bug 15719: Silence warning in C4/Language.pm during web install
This problem was discovered the hard way:
- Drop DB
- Create DB
- Webinstaller run until the screen is:
We are ready to do some basic configuration.
Please install basic configuration settings to continue the installation.
-- The error log file will end with an error about splitting
an uninitialized value.
TEST PLAN
---------
0) First patch already applied
1) prove -v t/Languages.t
-- success, but warn prints
2) Apply this patch
3) prove -v t/Languages.t
-- success without warning messages
4) run koha qa test tools
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described. QA test tools run OK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit a84264c92f4c34607fba09f109610e40611078a9)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 9449b27198a1f8f24dde0675fe6230cb977c4cf0)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 03e133ba26fe7d457080979c1f874aa8262829a0
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Feb 1 18:26:41 2016 -0500
Bug 15719: Silence warning in C4/Language.pm during web install - tests
Test empty database case.
TEST PLAN
---------
1) prove -v t/Languages.t
-- success (because test case is missing)
2) Apply this patch
3) prove -v t/Languages.t
-- success, but warning printed.
4) run koha qa test tools
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised. QA test tools rus OK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 701f427587daa4530041014fae8bf3674351283c)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 9719f0280141f0770f2eb8cdb96c4a8ccffcf253)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 74b1b26691a0c8d88f530f36075a1fa2c934d116
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 1 15:57:56 2016 +0000
Bug 15699 [QA followup] - Only display firstname if present
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit ad63a6b8da1cd91f2e03ec4093d76b00cd3045d2)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit fa632a7a205fa89eb45388265b5bce42125caf1e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7f787efafa1916da648d459ed6f6f2765264322e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 28 21:58:37 2016 +0000
Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes
This patch changes the order of the name fields and adds a span class around
each in case of library wanting to customize further
To test:
1 - Enable course reserves
2 - Add some courses with instrcutors
3 - Note they are of form "Firstname Surname"
4 - Apply patch
5 - Note the change
6 - Note span tags
7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide();
Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting
the names would need some more actions but seems not to be intended by this patch.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 4dba088549d1add43cfd575ebdd3d21689c4a700)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit f232ce8bdc54f9b2e244da2290888ac2454cee8b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 74b4011eb8954d27d9c7dedf17d2f822f6c86cf1
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Tue Mar 15 09:36:46 2016 +0100
Bug 15667 RMaint followup
commit 80a750e6af3786eaa676487302a5feb426e6d1fb
Author: Marc Véron <veron at veron.ch>
Date: Tue Jan 26 16:33:49 2016 +0100
Bug 15667: Fix date and branch formatting of messages in patron account display
This patch fixes the date and branch formatting of messages in patron
account display.
To verify:
Add a new message to a patron account from the 'checkouts' tab in staff,
the displayed date is not correctly formatted and the branch displays as code
instead as branch name
To test:
Apply patch, verify that the messages and branch names are properly formatted.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described. The message dates in checkouts tab follow dateformat sypref
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 015e20138a7a400d0da30b0a771a94eede673c05)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 1f5305d264eb8df62c93f16f4462ebe63640c568)
commit a8e33e33e79fd160677e1718e94173e690a87a76
Author: Marc Véron <veron at veron.ch>
Date: Mon Jan 25 18:58:54 2016 +0100
Bug 15658: Browse system logs: Add more actions to action filter list
The following actions were missing in the action filter list on
cgi-bin/koha/tools/viewlog.pl:
'ADDCIRCMESSAGE'
'CHANGE PASS'
'DELCIRCMESSAGE'
'RENEW'
'Run'
To test:
- Apply patch
- Go to Tools > Logs (viewlog.pl)
- Verify that the actions appear in the list 'Actions'
- Verify that the new entries filter the list as appropriate (in
combination with Modules: All or with a meaningful selection in
list 'Modules')
Note for testing: You have to set a date in 'Display from' to get results
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Logs work as advertised, translated in bug 13474
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
"Run" could be more explicit.
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 7ce721ebefc13d99ff527fad26b39b7064bd2e11)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 7ee61481663ed83f11055b52cc40b0b55bf7a40f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit cf9ab256560dee8a7fb63c449561b1fdf9c699af
Author: Aleisha <aleishaamohia at hotmail.com>
Date: Tue Jan 19 20:29:24 2016 +0000
Bug 13474: Adding untranslatable log actions to viewlog.tt
Added 'Run'
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
(Amended to remove tab chars to make qa tools happy)
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 4c87b50ac32a00fd1056ab3923ecb11bde5c2b51)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 955c2456846588fec32644930be3aa84c5bb9fad)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6e2e6389499d57fb1c0469cd713e13e13d7c12a6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 22 13:21:28 2016 -0500
Bug 15881 - Serials new numbering pattern link should be a toolbar button
This patch converts the "new numbering pattern" link to a
Bootstrap-styled toolbar button for consistency with other pages in
Koha. This patch also includes minor markup corrections:
- Standardizing on the phrase "Numbering patterns" by eliminating the
occasional use of "number patterns."
- Removing mistaking closing slash on <select>
- Using standard "Cancel" link instead of a button.
- Adding a colon and space after labels.
- Fixing of "no existing patterns" message.
To test, apply the patch and go to Serials -> Numbering patterns
- Confirm that the "New numbering pattern" button looks correct and
works correctly.
- Confirm that the entry form looks correct and that the cancel link
works as expected.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 0058a977c6b76e0602708ca48fabdbc679b9e0ab)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 54d3ee5758b2fc646aa4c403afa8754772cf9c2e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 390e106781f80f6c265be1448be27a464c08efd1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 22 13:09:00 2016 -0500
Bug 15880 - Serials new frequency link should be a toolbar button
This patch converts the "new frequency" link to a Bootstrap-style
toolbar button in order to maintain consistency. Also included in this
patch are some other minor markup corrections:
- A colon and space after labels
- A 'Cancel' link instead of a button.
- "Required" classes for a required field.
To test, apply the patch and go to Serials -> Manage frequencies.
- Test the "New frequency" button
- Confirm that the changes to the entry form look correct.
Followed test plan, displays as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 3b838ac251a145be2cfa46a076f1e786a86c2f16)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 3b15abed9bf6a6bb528b4f9580fbaaf14638156e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e6fad0c7861d6853e4fa47dce555a9a32c9a6225
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 15:58:44 2016 +0000
Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object
2 links are wrong on the renew page, because item.biblioitemnumber does
not return the biblioitemnumber as expect the template.
Test plan:
Renew an item and check the item link.
It should contain a valid biblioitemnumber for the 'bi' parameter.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Link repaired. At first glance, I am wondering if biblioitemnumber is
of actual use here; is it only passed back and forth between script and
template?
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 1302f91755012d9d31e87b037cb882bc025b357f)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit e3394929749f5e8ae2c764a3f23920ec347b871f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e7604dd4b8f6769cadb3b749a28722307e7845af
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Feb 11 12:06:39 2016 -0500
Bug 15790 - Don't delete a MARC framework if existing records use that framework
If a MARC framework is in use by any records it should not be possible
to delete it. Deleting a framework which is in use will leave the
deleted framework code in those records.
This patch modifies the deletion confirmation dialog so that it will not
let the user confirm the deletion if there are records using it.
To test, apply the patch and go to Administration -> MARC frameworks
1. Try to delete a framework which is in use by 1 or more records. The
resulting confirmation dialog should prevent you from proceeding.
2. Try to delete a framework which is not in use. Test both canceling
and confirming that deletion to make both function correctly.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 18820b6c8fc30fb25c99e0e0710d08eda2bc745c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9fc70f8a0cf6fa6fda369837726e73b91b6cdf40
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jan 28 08:54:56 2016 -0500
Bug 15691: Show card number minimum and maximum in visible hint when adding a patron
The CardnumberLength system preference defines card number minimum and
maximum allowed values when adding a patron. This information is
currently hidden in a title attribute on the card number input field.
This patch moves the information into a <div class="hint">, matching
other fields in the entry form which offer details about entry
guidelines.
To test, apply the patch and open the new patron entry form. Test for
various values of CardnumberLength, and with 'cardnumber' mandatory or
not mandatory as defined in BorrowerMandatoryField.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 9f172a3c1bc8c7cd1664eabac81c5b66877b3952)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 276b59e5bcce0f68dfbce32f2c94e8d5178500a7)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit bfd565089ec4845b1390b760a30b922a6445116b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Feb 29 07:32:14 2016 +0000
Bug 15674: Make "Column visibility" translatable
The "Column visibility" text button was not translatable, now it is.
Test plan:
1/ Update the template for a given language and translate the "Column
visibility" string
2/ Go on admin/currency.pl
=> The string should be translated.
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 2c186dd5a00cf8cb18fb596957a5ddfa9559bc42)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit d2111ff7cf6107639ba332fae18b32609b6c1d53
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 27 10:33:24 2016 +0000
Bug 15605: Remove the cursor:pointer style.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit effe1e27819a3b7d156e4abf5c96dd34d529246f)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 8d58579d6b5a4a287c3283284a2c4b8618ec763b)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit cef47596049765dd595517dc7d637b0bbe87cef6
Author: Natasha <tasham_8 at hotmail.com>
Date: Wed Jan 20 02:11:37 2016 +0000
Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup
To Test -
1. Go to Serials and search for a title and then click on it.
2. Click routing list and then Add recipients.
3. Search for a patron.
4. Using the tab key try to navigate onto the Add link.
5. Notice it skips Add.
6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard.
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit c76549dd7b4a090844a5a51664409417f9838923)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit da966cef92701e9d2469be784cc773d815769ffe)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit ce80123c2fdf0470420f70d936ac2377ccd75140
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 25 10:31:34 2016 +0000
Bug 14244: Does not display patron's info in the checkout history if not authorised
The librarian needs CAN_user_circulate_circulate_remaining_permissions
to see the checkouts patron's information.
Test plan:
The "Patron" column of the checkout history page should only be
displayed of you have the circulate > circulate_remaining_permissions
permission.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 818b1871519f0348cc54a60c76e2c8192f36bb3c)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit fd65d2264e830c1a41e2cbfbe94049ca7d1eddda)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit fd51df2ccfc3a52676dd1a1922cbd05fc546a61e
Author: Thomas Misilo <misilot at fit.edu>
Date: Wed Sep 16 13:43:28 2015 -0400
Bug 14244: viewing a bib item's circ history requires circulation permissions
On issuehistory.pl you have:
flagsrequired => { circulate => "circulate_remaining_permissions" },
But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves
This patch changes the required permissions from circulate to catalogue.
Test Plan:
1. Login as user without the circulate_remaining_permissions
2. Attempt to view Circulation History of an Item
3. Does not work
4. Apply Patch
5. Attempt to view circulation history with a user that has access to the staff side.
6. Can view circulation history now
Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit e8c5fb11fbebc86742325aea745bc7253d9110d8)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit a835060b9c10272fccf5262f5c77cc9d0031de7f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f0198977186b722e43f9489d6a44856b9603f1ed
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Tue Mar 15 07:53:59 2016 +0100
Bug 15736 DB rev 3.20.09.001
commit 56f83da3939dcaaf0ee8a5a672045ac4e9cde714
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Sun Feb 14 14:12:50 2016 +0000
Bug 15736 [QA Followup] - Make add more details to the syspref description
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit f92ef6207bc7346825f097f61e696b4b3685a737)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 59d2298865fee7abb91b24833b4bff2f627bbcd6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7827be93a74c9f828e99001cffb6964683f45913
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 12 09:07:09 2016 +0000
Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking
Bug 14821 removed the items which were not checked out, but some
libraries considered it as a bug.
So let's add a new pref to control this behavior.
Test plan:
0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show"
(default)
1/ Check an item in.
If the item was not checked out, it won't be listed
2/ Turn the pref to "Show"
3/ Check an item in
If the item was not checked out, it should be listed
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit ce6c3bb88b426b0d0b945b9e71c695017dcb0fed)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
(cherry picked from commit 21ebaf949e0d3822e313ff76a32c23a97be0a78e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 2 +-
C4/Context.pm | 3 +-
C4/Languages.pm | 6 ++-
C4/Templates.pm | 4 +-
Koha.pm | 2 +-
about.pl | 21 ++++------
catalogue/issuehistory.pl | 2 +-
circ/returns.pl | 5 +++
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 9 +++++
.../prog/en/includes/columns_settings.inc | 5 ++-
.../prog/en/modules/admin/aqcontract.tt | 20 +++++-----
.../en/modules/admin/auth_subfields_structure.tt | 13 ------
.../prog/en/modules/admin/biblio_framework.tt | 21 +++++++---
.../prog/en/modules/admin/branches.tt | 15 +++++--
.../prog/en/modules/admin/clone-rules.tt | 13 +++---
.../en/modules/admin/marc_subfields_structure.tt | 42 +++++++++++---------
.../prog/en/modules/admin/oai_sets.tt | 12 +++++-
.../prog/en/modules/admin/preferences.tt | 2 +-
.../en/modules/admin/preferences/circulation.pref | 6 +++
.../prog/en/modules/catalogue/issuehistory.tt | 6 ++-
.../prog/en/modules/circ/circulation.tt | 6 +--
.../intranet-tmpl/prog/en/modules/circ/renew.tt | 4 +-
.../en/modules/help/admin/items_search_fields.tt | 25 ++++++++++++
.../prog/en/modules/members/memberentrygen.tt | 17 +++++---
.../en/modules/serials/subscription-frequencies.tt | 25 +++++++-----
.../modules/serials/subscription-numberpatterns.tt | 36 ++++++++++++-----
.../en/modules/serials/tables/members_results.tt | 2 +-
.../prog/en/modules/tools/quotes-upload.tt | 1 +
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 7 +++-
.../bootstrap/en/modules/opac-course-reserves.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +-
t/Languages.t | 10 ++++-
33 files changed, 230 insertions(+), 119 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/items_search_fields.tt
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list