[koha-commits] main Koha release repository branch master updated. v3.22.00-944-g39597b8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  39597b86ae299a9b4c0c1e8221f51f9e8dd300ed (commit)
      from  6a078fb1b34ad9585ccd4c717723dfca2a91df80 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 39597b86ae299a9b4c0c1e8221f51f9e8dd300ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 9 17:02:05 2016 +0000

    Bug 15773: Fix and standardise checkboxes code in framework
    
    When creating a new subfield for an authority framework, the checkboxes
    don't behave as they should.
    If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
    label, the checkbox from the second tab will be checked/unchecked.
    This is caused by a non-unique id of the input element.
    
    I have found this bug when working on the removal of CGI::checkbox in
    both admin/auth_subfields_structure.pl and
    admin/marc_subfields_structure.pl scripts.
    
    This patch remove the use of CGI::checkbox as well as the generation of
    html code from these 2 pl scripts (which should be avoided).
    The code these scripts are now pretty similar.
    
    Test plan:
    Add/modify/remove subfield for a MARC framework and an Authority
    framework.
    Use as many field as possible and confirm that the values are correctly
    inserted/displayed.
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as advertised
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com

-----------------------------------------------------------------------

Summary of changes:
 admin/auth_subfields_structure.pl                  |  179 ++++++-------------
 admin/marc_subfields_structure.pl                  |  183 ++++++--------------
 .../en/modules/admin/auth_subfields_structure.tt   |  100 +++++++----
 .../en/modules/admin/marc_subfields_structure.tt   |   74 +++++---
 4 files changed, 209 insertions(+), 327 deletions(-)


hooks/post-receive
-- 
main Koha release repository