[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.04-89-g25fdc18
Git repo owner
gitmaster at git.koha-community.org
Wed Mar 23 07:54:08 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.22.x has been updated
via 25fdc18f77edf29a94527ad812481c91c80c701c (commit)
via d786b63fb595ca681834d801741738ea6688f8bc (commit)
via 8c2186b402e2b00f6ca110589a0774046be51211 (commit)
via 748b3d5522aab2e7fe76d6fc309a199cada79625 (commit)
via 38820140fc17cbc6926aa6d369c8be415a54b640 (commit)
via dcf02d0a1a497bdaf473bf11e2c72b3af7e4076d (commit)
via 65b1618e9c4197718c59950767692e0502fee689 (commit)
via e6b03cf3a0fe369a41a2d3f3b7460c84d299d4f0 (commit)
via c65c69a4cb3a3aae2097bcaff5f406349d0415a8 (commit)
from 0d904b655e65f70476c5d7daf355cc7c3cf0976b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 25fdc18f77edf29a94527ad812481c91c80c701c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 10 09:12:52 2016 +0000
Bug 11998: Clear L1 cache from psgi files
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 55b78f1a5dbbff5a790971e2f5a99ebdd6a3f18a)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit d786b63fb595ca681834d801741738ea6688f8bc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 10 08:55:27 2016 +0000
Bug 11998: Add a L1 cache for sysprefs
Accessing to the cache for each call to C4::Context->preference might
have an impact on performances.
To avoid that this patch introduces a L1 cache (simple hashref). It will
be populated by accessing the L2 cache (Koha::Cache).
If a pref is retrieved 10x, the first one will get the value from the L2
cache, then the L1 cache will be check.
To do so we will need to clear the L1 cache every time a page is loaded.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 47fbbb7cf5e7ef2f9ef422e2fd9232066100a64b)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 8c2186b402e2b00f6ca110589a0774046be51211
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:52:51 2016 +0000
Bug 11998: follow-up for the debian package psgi file
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 2eaf2cd71b9620c0d5782c7c78f86a5e323c89a4)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 748b3d5522aab2e7fe76d6fc309a199cada79625
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:45:07 2016 +0000
Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache"
This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58.
Bug 13805 fixes an installer bug by disabling the syspref cache.
It was not a good idea, it introduced performance issues (see bug 13805
comment 14).
Test plan:
Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
You should not get the login form again.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Test plan not followed by me for this patch, due to lack of working
plack setup, but I don't expect it to cause any problems, and performace
gain for plack will be tremendous
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit d4039ce09347c342f8ac048814ee10b47819df48)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 38820140fc17cbc6926aa6d369c8be415a54b640
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 17:17:40 2016 +0000
Bug 11998: Do not clear syspref cache in psgi file
This in only in koha.psgi, it has been introduced by bug 13815 but
should not have been added by this patch.
Removing it should not introduce any changes.
Not that it won't impact debian packages.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit f25e3ed90b55b657c71e117a1e9a8bc2c3a1809f)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit dcf02d0a1a497bdaf473bf11e2c72b3af7e4076d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 7 09:24:14 2016 +0000
Bug 11998: Make HoldsQueue.t tests pass [TO REVERT]
This patch should not be the way to make these tests pass.
The prefs should not be updated using set_preference, it will modify the
values in the cache.
I have no idea how to make them pass using the correct way, please help
:)
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 3907401a6d293872ca1fb46c90da029b91d37e31)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 65b1618e9c4197718c59950767692e0502fee689
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 4 13:21:39 2016 +0000
Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm
Otherwise some tests won't pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit a691e88a4ebf57e9ebda8afb5f8e6bac33bc6ad6)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit e6b03cf3a0fe369a41a2d3f3b7460c84d299d4f0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 4 13:14:59 2016 +0000
Bug 11998: Use t::lib::Mocks::mock_preference in tests
Unless in t/db_dependent/Context.t where we want to test the cache
behaviors.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 56a782c666d1d05215e49101e33fce0a3cd30377)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit c65c69a4cb3a3aae2097bcaff5f406349d0415a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 3 16:54:30 2016 +0000
Bug 11998: Use Koha::Cache to cache sysprefs
At the moment, the sysprefs are only cache in the thread memory
executing the processus
When using Plack, that means we need to clear the syspref cache on each
page.
To avoid that, we can use Koha::Cache to cache the sysprefs correctly.
A big part of the authorship of this patch goes to Robin Sheat.
Test plan:
1/ Add/Update/Delete local use prefs
2/ Update pref values and confirm that the changes are correctly taken
into account
Signed-off-by: Chris <chrisc at catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it?
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Signed-off-by: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Tested with CGI and CGI + memcache; some small issues still remain,
but it would be better to deal with them in separate bug reports
if necessary
Signed-off-by: Brendan Gallagher brendan at bywatersolutions.com
(cherry picked from commit 9820f9dfbd63ecc812b6b2a4ec71af91f303f933)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Context.pm | 106 +++++++++++++++++-----
Koha/Config/SysPref.pm | 32 +++++++
Koha/Schema/Result/Item.pm | 8 +-
admin/preferences.pl | 1 -
admin/systempreferences.pl | 61 +++----------
debian/templates/plack.psgi | 3 +-
misc/admin/koha-preferences | 2 +-
misc/plack/koha.psgi | 4 +-
svc/config/systempreferences | 2 -
t/db_dependent/Amazon.t | 19 ++--
t/db_dependent/Auth.t | 7 +-
t/db_dependent/Auth_with_cas.t | 5 +-
t/db_dependent/Bookseller.t | 5 +-
t/db_dependent/Circulation.t | 41 +++++----
t/db_dependent/Circulation/GetTopIssues.t | 3 +-
t/db_dependent/Circulation/Returns.t | 5 +-
t/db_dependent/Circulation_Branch.t | 3 +-
t/db_dependent/Circulation_issue.t | 5 +-
t/db_dependent/Context.t | 11 ++-
t/db_dependent/Hold.t | 7 +-
t/db_dependent/Holds.t | 12 +--
t/db_dependent/Items.t | 26 +++---
t/db_dependent/Koha_template_plugin_KohaDates.t | 7 +-
t/db_dependent/Languages.t | 5 +-
t/db_dependent/Letters.t | 2 +-
t/db_dependent/Members.t | 19 ++--
t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t | 5 +-
t/db_dependent/QueryParser.t | 3 +-
t/db_dependent/Record.t | 7 +-
t/db_dependent/Reserves.t | 32 +++----
t/db_dependent/Suggestions.t | 5 +-
t/db_dependent/XISBN.t | 9 +-
t/db_dependent/default_search_class.pl | 3 +-
t/db_dependent/sysprefs.t | 15 ++-
34 files changed, 286 insertions(+), 194 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list