[koha-commits] main Koha release repository branch master updated. v3.22.00-1014-g5fa1257

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  5fa1257a2e6bf09ece1be64edaaa16b7303f0a55 (commit)
       via  4e1289a55d7eee0987216a306278cba8c2d66036 (commit)
       via  c9170233c976b3ac05f8712fdc2c9aa25973f34f (commit)
       via  590f174560029db99a5123597418675959936a07 (commit)
       via  25ffd8b215972add6f8ea0e6e38c3ac530745f23 (commit)
      from  902ea66d247f08eb717f7e696781a3ec956c91f6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5fa1257a2e6bf09ece1be64edaaa16b7303f0a55
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Mar 11 08:34:22 2016 -0500

     Bug 15870: Follow up to address comment #20
    
    - $OUTPUT_AUTOFLUSH wasn't used to it was removed
    - Use English was removed since $OUTPUT_AUTOFLUSH wasn't not needed
    - transaction start and end were moved to subtests
    - prepare was moved outside loop
    - partial MARC agnosticism was added
    
    TEST PLAN
    ---------
    1) apply patch
    2) prove t/db_dependent/Filter_MARC_ViewPolicy.t
    3) run koha qa test tools
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 4e1289a55d7eee0987216a306278cba8c2d66036
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Mar 7 21:34:45 2016 -0500

     Bug 15870: potential follow up to comment #8
    
    This patch:
    - makes the Koha::RecordProcessor code more clear
      by removing the unnecessary newrecord variable.
    - revises the filter to be more clear about the
      expectation that operations are done directly on
      the record parameter.
    
    TEST PLAN
    ---------
    prove t/RecordProcessor.t
    prove t/db_dependent/Filter_MARC_ViewPolicy.t
    run koha qa test tools
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as advertised. NO koha-qa errors
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit c9170233c976b3ac05f8712fdc2c9aa25973f34f
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Mar 4 17:04:37 2016 -0500

     Bug 15870: Follow-up of filter and tests
    
    This patch:
    - improves perlcritic messages in the filter and tests.
    - changes should display logic to should hide logic
      to simplify filter.
    - perltidies the scripts
    - debugs the issues outstanding on the comprehensive tests
      provided in the second commit.
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 590f174560029db99a5123597418675959936a07
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date:   Tue Mar 1 10:47:32 2016 -0300

     Bug 15870: (QA followup) Add tests
    
    This patch introduces functionality tests for the new Koha::Filter.
    It iterates over all the possible 'hidden' values defined in the docs
    for hiding/showing fields and subfields, and checks the filter does the job.
    
    It tests the functionality for both opac and intranet interfaces and tries
    to catch all scenarios. It adds control fields to the sample record (they
    traverse a different branch in the code).
    
    TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is still
    shown.
    
    The original tests file has been renamed conveniently.
    
    To test:
    - Run
      $ prove t/db_dependent/Filter_MARC_ViewPolicy.t
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 25ffd8b215972add6f8ea0e6e38c3ac530745f23
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri Feb 19 17:13:16 2016 -0500

     Bug 15870: MARC Filter to exclude fields/subfields lacking visibility
    
    TEST PLAN
    ---------
    0) Apply 15777 and 15871 as required.
    1) Apply patch
    2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t
       -- all should pass.
    3) koha qa test tools.
    BONUS
    4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t
       -- using the koha qa test tools perlcriticrc, it should pass
          though I am excluding checking print return values.
          (see bug 15646)
    
    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Filter/MARC/ViewPolicy.pm          |  267 +++++++++++++++++++++++++++++++
 Koha/RecordProcessor.pm                 |    6 +-
 t/db_dependent/Filter_MARC_ViewPolicy.t |  183 +++++++++++++++++++++
 3 files changed, 452 insertions(+), 4 deletions(-)
 create mode 100644 Koha/Filter/MARC/ViewPolicy.pm
 create mode 100644 t/db_dependent/Filter_MARC_ViewPolicy.t


hooks/post-receive
-- 
main Koha release repository