[koha-commits] main Koha release repository branch master updated. v3.22.00-1491-ge7eac39
Git repo owner
gitmaster at git.koha-community.org
Tue May 3 16:55:17 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e7eac39e96a239d9f678931c6c12b80742454120 (commit)
via 6e0b6ecf1347a91c2d324abc08e76f1cd8d9ffd0 (commit)
via 1608b89b7ff90ae1cc307d9f096ddaab29ba2192 (commit)
via 503cc30d9ae03f12b3c412d2d280ea76393b97da (commit)
via 33694a8faac22e760e0559d99a9d013f7c90275b (commit)
from 614fe34d863014aef9bb65a23b8c3118759fcced (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e7eac39e96a239d9f678931c6c12b80742454120
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 3 15:04:20 2016 +0000
Bug 16170 - DBRev 3.23.00.061
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 6e0b6ecf1347a91c2d324abc08e76f1cd8d9ffd0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Apr 1 09:34:50 2016 +0200
Bug 16170: [QA Follow-up] Fix embeded typos
Just noticed this typo three times here.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 1608b89b7ff90ae1cc307d9f096ddaab29ba2192
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Apr 1 09:24:04 2016 +0200
Bug 16170: [QA Follow-up] Adjust Items.t
Items.t inserts an item via biblioitem not correctly linked to biblio.
The new foreign key constraint does not allow that.
Actually, we should be choosing to either remove biblioitems from Koha or
remove biblionumber from items.
Note: This seems to be the only case where an item is added this way.
Test plan:
Run Items.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 503cc30d9ae03f12b3c412d2d280ea76393b97da
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Mar 30 20:11:45 2016 -0400
Bug 16170 - Corrected to make work more smoothly
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 33694a8faac22e760e0559d99a9d013f7c90275b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 23 16:59:26 2016 +0100
Bug 16170: Pseudo foreign key in Items
While many of us would like to get rid of biblioitems one day, the current
scheme includes a biblioitemnumber and a biblionumber in Items.
(Which is not so great..)
But also note that biblionumber is NOT defined as a foreign key in Items,
although a belongs_to relation has been added to the DBIx scheme!
This inconsistency should be resolved. The "remove biblioitem table"
operation is a large one, but in the meantime we better make biblionumber
a regular FK not a 'pseudo' one.
Note: If in an (very) exceptional case biblionumbers are found in items,
that do not exist in biblio, this patch prints a warning at upgrade
time and does not add the constraint.
@RM: Please update the DBIx scheme accordingly.
Test plan:
[1] Run the upgrade. Check if the FK constraint has been added.
[2] Remove the FK constraint. Change the biblionumber of one item to an
unexisting record. Run the upgrade again. Notice the warning.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested both cases: constraint added as well as warning printed.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
installer/data/mysql/kohastructure.sql | 3 ++-
installer/data/mysql/updatedatabase.pl | 20 ++++++++++++++++++++
t/db_dependent/Items.t | 31 +++++++++++++------------------
4 files changed, 36 insertions(+), 20 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list