[koha-commits] main Koha release repository branch master updated. v3.22.00-1560-g6722771
Git repo owner
gitmaster at git.koha-community.org
Fri May 6 06:13:13 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 672277197dbb910a1bd3f1239467242253869066 (commit)
from a07db3537d70aa642f1f2e2731eb8e0cf200e1f4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 672277197dbb910a1bd3f1239467242253869066
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 28 20:52:40 2016 -0400
Bug 16386 - Replace the use of "onclick" from patron card creator templates
This patch removes the use of "onclick" from several patron card creator
templates. Events are defined instead in JavaScript.
Also changed:
- Patron search pop-up window is now slightly larger because I found it
never quite large enough to prevent horizontal scrolling.
- Replaced "Borrower" with "Patron" in a couple of places.
- "Add" link in patron search pop-up is now styled as a Bootstrap
button.
- Removed Bootstrap styles from some submit buttons.
- Some Font Awesome icons were made using the invalid element
<icon></icon> instead of <i></i>. These are corrected.
- Fixed some other HTML validation errors.
To test, apply the patch and go to Tools -> Patron card creator.
- Choose New -> Card batch.
- Click "Add patrons" and perform a search for patrons in the pop-up
window.
- Click the "Add" button. The corresponding borrowernumber should be
added to the textarea in the parent window, and a message should
appear at the top of the pop-up window confirming that the patron
has been added. (Note: This patch fixes a version of Bug 13041 which
prevented the "add" button from working on patrons whose name
include an apostrophe).
- In the parent page, in the list of patrons you added to the batch,
confirm that clicking the "Delete" link triggers a confirmation
dialog. Test both confirming and canceling.
- Confirm that clicking the "Export" button next to an individual
patron triggers a modal window.
- In the export window, confirm that the "Cancel" link works to
close the modal.
- Click the "Export" button again and then the "Export" button in
the modal.
- Test that the "Done" button works to close the modal.
- Choose Manage -> Card batches.
- Test the "Delete" and "Export" buttons as described above.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All works, no errors.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
.../prog/en/modules/common/patron_search.tt | 13 ++++++---
.../prog/en/modules/patroncards/edit-batch.tt | 28 +++++++++++++-------
.../prog/en/modules/patroncards/image-manage.tt | 2 +-
.../prog/en/modules/patroncards/manage.tt | 19 ++++++++-----
.../prog/en/modules/patroncards/print.tt | 12 ++++++---
.../modules/patroncards/tables/members_results.tt | 2 +-
6 files changed, 52 insertions(+), 24 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list