[koha-commits] main Koha release repository branch master updated. v16.05.00-21-ge0143f3

Git repo owner gitmaster at git.koha-community.org
Tue May 31 16:04:08 CEST 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e0143f3205ebbf07aa479b89d8ba8aab426496b2 (commit)
       via  22b18ba988c72b6802421ae2e96237a716ae436e (commit)
      from  fdf4101fb17d8f45487a9ba6ba248e8edf245cf6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e0143f3205ebbf07aa479b89d8ba8aab426496b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 20 15:40:24 2016 +0100

    Bug 16437 - (follow-up) Automatic item modifications by age needs prettying
    
    Do not move the scrollbar to the top when removing a 'block' to a new
    rule.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

commit 22b18ba988c72b6802421ae2e96237a716ae436e
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Mar 25 13:06:03 2016 -0400

    Bug 16437 - Automatic item modifications by age needs prettying
    
    This patch makes layout and behavior changes to the automatic item
    modifications by age interface, bringing some aspects of it closer into
    conformance with established interface patterns.
    
    - The intial view is now a standard table of information about existing
      rules, or a message dialog saying there are no rules.
    - If there are no rules, a toolbar button reads "Add rules."
    - If there are existing rules, the toolbar button reads "Edit rules."
      - Clicking the button leads to the rules edit interface, which now has
        a floating toolbar with "Add rule," "Save," and "Cancel" buttons.
      - Clicking the "Add rule" button displays a blank rule block.
        - If you are adding a rule to existing rules, the new block is
          appended at the bottom, and the page scrolls to the new rule.
        - As you add or remove rule blocks, the legend containing the rule
          count updates so that the numbers are sequential.
        - In each rule block, "age" and "substitutions" are now required.
          The age field is now validated to require a number.
        - The add/remove condition/substitution links now have more
          descriptive text labels.
        - The control to remove a rule is now a link in the <legend> element
          associated with each rule.
    - Most JavaScript for this page is now in a separate file.
    - Breadcrumbs are updated to be a little more specific.
    
    To test, apply the patch and clear your browser cache if necessary.
    
    - Go to Tools -> Automatic item modifications by age.
    - Test adding and removing rules.
    - Test removing all rules.
    - Test adding and removing conditions and substitutions within rules.
    - Test submitting the form without filling in required fields.
    
    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |   25 +-
 .../tools/automatic_item_modification_by_age.tt    |  321 ++++++++------------
 .../prog/js/automatic_item_modification_by_age.js  |  125 ++++++++
 3 files changed, 270 insertions(+), 201 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/js/automatic_item_modification_by_age.js


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list