[koha-commits] main Koha release repository branch master updated. v16.05.00-1320-g4fd1f3e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4fd1f3e48ea103d1656adebe70d9c9672f7217f7 (commit)
       via  91774fcf15cf8e3c2c6142d5ee646c1e8a06a7a2 (commit)
       via  246bca4a67b2ca177d4defb39284a3ede2a0703a (commit)
       via  c414e7608956ca04648aed1a15b79c5cd281fb3c (commit)
       via  e0e88806fae409e6ec6e360f5e82f55a45ca0e96 (commit)
      from  27596ca2e4de7ad57c095c45f1ef6c9ad35f4848 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4fd1f3e48ea103d1656adebe70d9c9672f7217f7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 4 08:58:20 2016 +0100

    Bug 17539: [QA Follow-up] Move handle after schema
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 91774fcf15cf8e3c2c6142d5ee646c1e8a06a7a2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Nov 3 12:04:31 2016 -0300

    Bug 17539: (QA followup) Silence warnings
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 246bca4a67b2ca177d4defb39284a3ede2a0703a
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Wed Nov 2 15:28:30 2016 +0200

    Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0
    
    To test:
    1. Set patron category "S" with enrolmentfee 1
    2. perl t/db_dependent/Reserves.t
    3. Observe following errors:
    
    not ok 59 - Bug 14464 - No fines at beginning
    ok 60 - Bug 14464 - 1st reserve correctly created
    ok 61 - Bug 14968 - Keep found column from reserve
    not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured
    ok 63 - Bug 14464 - 2nd reserve correctly created
    not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired
    ok 65 - Bug 14464 - 1st reserve correctly created
    not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured
    
    4. Apply patch
    5. perl t/db_dependent/Reserves.t
    6. Observe test pass
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit c414e7608956ca04648aed1a15b79c5cd281fb3c
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Wed Nov 2 15:05:28 2016 +0200

    Bug 17539: Fix Already in a transaction error
    
    perl t/db_dependent/Reserves.t
    
    1..72
    ok 1 - use C4::Reserves;
    ok 2 - CheckReserves Test 1
    ...
    ok 52 - Reserve in waiting status cant be canceled
    ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds
    DBD::mysql::db begin_work failed: Already in a transaction at
    /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
    DBD::mysql::db begin_work failed: Already in a transaction at
    /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
    at /usr/share/perl5/DBIx/Class/Schema.pm line 1080.
    ...
    Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at
    /home/ubuntu/kohaclone/C4/Members.pm line 542
    C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02')
    called at t/db_dependent/Reserves.t line 516
    
    This patch fixes this issue by replacing dbh autocommit=0 with
    txn_begin.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit e0e88806fae409e6ec6e360f5e82f55a45ca0e96
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Wed Nov 2 14:51:23 2016 +0200

    Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error
    
    perl t/db_dependent/Reserves.t
    
    1..72
    ok 1 - use C4::Reserves;
    ok 2 - CheckReserves Test 1
    ok 3 - CheckReserves() include reserve_id in its response
    ok 4 - CheckReserves Test 2
    ok 5 - CheckReserves Test 3
    ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary
    ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary
    ok 8 - Item is correctly waiting
    ok 9 - Item is correctly priority 1
    ok 10 - Item is correctly priority 2
    ok 11 - GetWaiting got only the waiting reserve
    ok 12 - GetWaiting got the reserve for the correct borrower
    Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853.
    
    This patch fixes this error. The solution was to use C4::Reserves before C4::Items.
    Also due to this edit, change use_ok to require_ok
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/Reserves.t |  215 ++++++++++++++++++++++++---------------------
 1 file changed, 117 insertions(+), 98 deletions(-)


hooks/post-receive
-- 
main Koha release repository