[koha-commits] main Koha release repository branch master updated. v16.05.00-1335-g2b54196

Git repo owner gitmaster at git.koha-community.org
Mon Nov 7 17:45:09 CET 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2b54196b72757a6483dc99a1fa8d2e76538a5102 (commit)
      from  d711d62a4801f77c553e51c31bcc1cea6e8d13fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2b54196b72757a6483dc99a1fa8d2e76538a5102
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Oct 4 12:36:11 2016 +0200

    Bug 17394 - exporting checkouts with items selects without items in combo-box
    
    In checkouts table, the is an export form (when some exports syspref are enabled).
    When selecting some checkouts and selecting "ISO2709 with items" in export format combo-box, clicking on "Export" will select "ISO2709 without items" in the export format combo-box.
    This is quite strange.
    Its because the form as 2 inputs with same name and id "output_format" : an hidden input (the wanted arg for tools/export.pl) and a select (the export format combo-box).
    So an action meant on the hidden input impacts the select.
    
    This patch corrects by changing id and name of the export format combo-box : issues-table-output-format
    
    TEST plan :
    - Enable checkouts exports by setting syspref ExportWithCsvProfile with a profile
    - Go to circ page of a patron with checkouts : /cgi-bin/koha/circ/circulation.pl?borrowernumber=xxx
    - Show checkouts table
    - Select some checkboxes in "Export" column
    - Select "ISO2709 with items" in export format combo-box
    - Click on "Export"
    => Without patch, the export format combo-box changes to "ISO2709 without items"
    => With patch, the export format combo-box does not changes
    - Check the export file contains the items
    - Check exports "ISO2709 without items" and "CSV" are OK
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer  <katrin.fischer at bsz-bw.de>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc |    4 ++--
 koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js         |    3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list