[koha-commits] main Koha release repository branch master updated. v16.05.00-1343-g8630e83

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8630e83ed1b0261bcffd7d4966460daca8c9a3af (commit)
       via  37256b4d2d040822ef3690fdd4946b193b3e0c11 (commit)
      from  61f3c5b880fa4da59959db116bf0cd3145a8b45a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8630e83ed1b0261bcffd7d4966460daca8c9a3af
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Nov 7 16:07:01 2016 +0100

    Bug 17420 - record export fails when itemtype on biblio - followup
    
    Same as previous patch for misc/export_records.pl.
    
    Test plan :
    - Use syspref item-level_itypes = biblio record
    - Run misc/export_records.pl
    => Without patch you get an error : DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'where clause' ...
    => With patch you get a correct export file
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Export Ok, no errors.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 37256b4d2d040822ef3690fdd4946b193b3e0c11
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Oct 10 16:46:04 2016 +0200

    Bug 17420 - record export fails when itemtype on biblio
    
    In Tools, Export data, you can export with a filter on item type.
    When item type is on biblio record, you get the error :
    export.pl: DBIx::Class::ResultSet::next(): Unknown column 'biblioitems.itemtype' in 'where clause' at /home/koha/src/Koha/Objects.pm line 150
    
    Looks like its because this code use to be a SQL Select and is now a DBIx call :
                              C4::Context->preference('item-level_itypes')
                                ? ( 'items.itype' => $itemtype )
                                : ( 'me.itemtype' => $itemtype )
    
    This patch corrects by using "me.itemtype"
    
    Test plan :
    - Use syspref item-level_itypes = biblio record
    - Go to Tools > Export data : /cgi-bin/koha/tools/export.pl
    - Select an item type
    - Click on "Export biblio records"
    => Without patch you get an error 500
    => With patch you get a correct export file
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Fix the issue, no errors.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/export_records.pl |    2 +-
 tools/export.pl        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository