[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.00-8-g53528e1
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 30 00:10:10 CET 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.11.x has been updated
via 53528e15802859ec49e9a908c2a6cf164da278b4 (commit)
via 479e5157f38d9d583467d1e44ec9f13a3dae0d81 (commit)
via 05360ebb41cc2029b0445a9995f9887a90b1a591 (commit)
via 0e2c857dbb4e4a512548c2838b2e6a10bbfb5211 (commit)
via 45d791658d82de51dce7c9e98b94750297dfc2d8 (commit)
from 961a2f530a6bfc4d1a9c2b4bf3ff24c13b58fde8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 53528e15802859ec49e9a908c2a6cf164da278b4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 19 12:01:32 2016 +0100
Bug 16873: Improve renewal error messages on self check
When a patron is not allowed to renew from the self check module, the
only message displayed is "No renewals allowed".
It would be nicer to let him/her know that the renewal is not allowed
because it's a on-site checkout or automatic renewal.
To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get
the renewal error.
Test plan:
0/ Switch off AllowSelfCheckReturns
1/ check out an item and tick "auto renewal"
2/ Go on the self check module
=> auto renewal message is displayed
3/ check out an item and tick "on-site checkout"
4/ Go on the self check module
=> on-site checkout message is displayed
5/ check out an item without ticking any checkboxes (regular checkout)
Renew it to reach the max renew allowed
6/ Go on the self check module
=> regular checkout message is displayed
7/ Switch on AllowSelfCheckReturns and repeat previous steps
=> "Return this item" button is displayed in addition of the renewal
error message
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 479e5157f38d9d583467d1e44ec9f13a3dae0d81
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Oct 13 11:05:00 2016 +0200
Bug 14699: Reword "Select all/Clear all" and change their behaviour
"Select all" -> "Select all visible rows"
"Clear all" -> "Clear selection on visible rows"
+ fix the bug where the Delete link was visually enabled only if you
checked a box in the first page (now every checkbox enable the link)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 05360ebb41cc2029b0445a9995f9887a90b1a591
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Tue Sep 8 08:49:44 2015 +0200
Bug 14699: Show number of selected searches in search history
With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 0e2c857dbb4e4a512548c2838b2e6a10bbfb5211
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Aug 20 15:38:59 2015 +0200
Bug 14699: Fix intranet search history issues due to pagination
DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).
This patch fixes just that.
Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.
Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 45d791658d82de51dce7c9e98b94750297dfc2d8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Nov 24 13:37:52 2016 +0000
Bug 17676: Update default COLLATE of marc_subfield_structure
(This issue has been raised on bug 17216 comments 93-103)
On bug 11944 (3.19.00.006) we updated the default COLLATE for all our tables to
utf8_unicode_ci but not the marc_subfield_structure table.
Indeed we want to keep tagsubfield a utf8_bin (to allow lowercase and uppercase
of the same letter for subfields).
We should have set the default collate to utf8_unicode_ci for further changes.
This patch updates the DB entry 3.19.00.006 to set the default COLLATE to this
table (for people upgrading from prior to 3.19.00.006) and set this
default COLLATE on 16.06.00.033 (for people upgrading from after 3.19.00.006).
The error is:
DBD::mysql::db do failed: Can't create table `koha_kohadev`.`#sql-306_9f9` (errno: 150 "Foreign key constraint is incorrectly formed") [for Statement "
ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET NULL;
"] at installer/data/mysql/updatedatabase.pl line 13175.
Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized value categories)
Test plan:
1/ git checkout v3.18.00
2/ Do an install
3/ git checkout master;
4/ perl installer/data/mysql/updatedatabase.pl
=> Without this patch, you get the error
=> With this patch applied you will not get it and the default COLLATE for
marc_subfield_structure will be correctly set. Make sure tagsubfield is
still utf8_bin
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Will put some notes on the Bugzilla report.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
-----------------------------------------------------------------------
Summary of changes:
installer/data/mysql/updatedatabase.pl | 8 ++
.../prog/en/modules/catalogue/search-history.tt | 94 ++++++++++++++------
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 23 +++--
opac/sco/sco-main.pl | 12 ++-
4 files changed, 96 insertions(+), 41 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list