[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.12-16-gd89346d

Git repo owner gitmaster at git.koha-community.org
Wed Nov 30 13:23:07 CET 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.22.x has been updated
       via  d89346dc47f3338c91a10962266cc98777924598 (commit)
       via  4c943184db60f2eefac4e77cab20d88cd19aaabf (commit)
      from  9d0c7986f957b601605130df0ab9fdbc842e970a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d89346dc47f3338c91a10962266cc98777924598
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Nov 7 16:07:01 2016 +0100

    Bug 17420 - record export fails when itemtype on biblio - followup
    
    Same as previous patch for misc/export_records.pl.
    
    Test plan :
    - Use syspref item-level_itypes = biblio record
    - Run misc/export_records.pl
    => Without patch you get an error : DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'where clause' ...
    => With patch you get a correct export file
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Export Ok, no errors.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

commit 4c943184db60f2eefac4e77cab20d88cd19aaabf
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Oct 10 16:46:04 2016 +0200

    Bug 17420 - record export fails when itemtype on biblio
    
    In Tools, Export data, you can export with a filter on item type.
    When item type is on biblio record, you get the error :
    export.pl: DBIx::Class::ResultSet::next(): Unknown column 'biblioitems.itemtype' in 'where clause' at /home/koha/src/Koha/Objects.pm line 150
    
    Looks like its because this code use to be a SQL Select and is now a DBIx call :
                              C4::Context->preference('item-level_itypes')
                                ? ( 'items.itype' => $itemtype )
                                : ( 'me.itemtype' => $itemtype )
    
    This patch corrects by using "me.itemtype"
    
    Test plan :
    - Use syspref item-level_itypes = biblio record
    - Go to Tools > Export data : /cgi-bin/koha/tools/export.pl
    - Select an item type
    - Click on "Export biblio records"
    => Without patch you get an error 500
    => With patch you get a correct export file
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Fix the issue, no errors.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 misc/export_records.pl |    2 +-
 tools/export.pl        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list