From gitmaster at git.koha-community.org Wed Oct 5 09:20:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Oct 2016 07:20:45 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.04-29-g0fc92ab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via 0fc92ab72d1bab7e84df9fc78e3cbd3f2abb3d97 (commit) via 29ce6e481da7209ae9dae9dd8c73031bacd38883 (commit) via 602b92795644ec9eab002542df5ee59b733d86e7 (commit) via 5cd5b755cd846b0f4076472321920edc0a93f86e (commit) via 3f235844498dab1719572e25a73d0c5fb7ffcd7b (commit) via c73b60d7168f7f00226d01b09c604f253f35c36c (commit) via e09f10a882d15118bd22789462b2d66f4b1a4dfb (commit) via 20db7d6ee679f519a2076614635af831f3164c26 (commit) via 4e8209d595137168667d81875d024e6954fea102 (commit) via 3d0012e8fe98b910aace7da628c576fc1ba303ab (commit) via b0949e921427decf879e8e20d26bf42fefce992d (commit) via c81350b6200ce62c180f6fd301ed3406db893835 (commit) via 8ec4b5b7d4c39a5db05fc13d384412d510206b44 (commit) via 68c21aabe99fb12ef3987a142f5cc0389422a7bd (commit) via fefd457550597e2bbcfda1317760c99852829ed2 (commit) via 28eafe0b07fc8ec387ba6d7bd37dfadd5cdf01b6 (commit) via 92d648f579fb03e1e5bed45e28c8604a2ea7aab0 (commit) via 1ade46e5a4928ffd8ae4080b0f0f09c0b564ed13 (commit) via 656a25e39cac5ecca5c95dd9b2ae65648d474528 (commit) via 3b038239a56abc645eaa4787268b71a7b6603a5a (commit) via 4e06090d8b0594d99da04824d239bcfa343f5e9c (commit) via d46322c7cd30f6be6c6589de79577b720a408d3b (commit) via 1dbc8e550e45a475ccbbc9d375c739307a6630bb (commit) via 5a4a65cdbbf2f6cabd5b0979e4c5e969eb66e0fb (commit) via 13705e51084f605a0e9fc686e7ee30350fb556e2 (commit) via 4ab091d3bfd2c6659320cbe80d35b805cff3aa4e (commit) via c27216cce84fe07c962a8878be51025c9fe0aace (commit) via 06937c45855a18bafae74648c6a938c153c59bd9 (commit) via 3f193fb63a3b8561088ee38a90ae32b9a1b276a5 (commit) from ec82b4000e07ccf73eb174bd637707ae73ef3ef2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0fc92ab72d1bab7e84df9fc78e3cbd3f2abb3d97 Author: Andreas Jonsson Date: Mon Oct 3 09:08:03 2016 +0100 Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache The problem is that the memcached configuration variables are extracted from the apache configuration file incorrectly so you get '"127.0.0.1:11211"' including double quotes as the servers parameter to memcached. Signed-off-by: Chris Cormack Note this only applies on 3.22.x but it does fix the problem Definitely needed for 3.22.12 Signed-off-by: Jonathan Druart Signed-off-by: Fr?d?ric Demians commit 29ce6e481da7209ae9dae9dd8c73031bacd38883 Author: Owen Leonard Date: Thu Aug 4 14:36:41 2016 -0400 Bug 17056 - Remove event attributes from various templates This patch removes event attributes from several templates, moving event definitions into the JavaScript instead. To test, apply the patch and: - View the MARC detail page for any bibliographic record. Changing the framework selection should reload the display using the selected framework. - Perform the same test on the labeled MARC view. (Set the viewLabeledMARC system preference to "Allow" if necessary). - To test the changes to Reports you should have at least one report group and at least one report subgroup. - Create a new saved SQL report. - Select a report group. Doing so should trigger the display of report subgroups. Deselecting the report group should hide the subgroups. - In Acquisitions -> Suggestions, create a new suggestion. - In the 'Acquisition information' section, changing values for copies, currency, and price should change the value in the total field. - In Circulation -> Upload offline circulation file: - My patch for Bug 16602 added the required code but forgot to remove the corresponding onclick attributes. - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 3d84252c0457708191adc23790d13dbf87e18a81) Signed-off-by: Fr?d?ric Demians commit 602b92795644ec9eab002542df5ee59b733d86e7 Author: Andreas Roussos Date: Tue Sep 13 17:41:16 2016 +0300 Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit f57df28f96898f47a3c4c6e6a5520bcaaf7afe2e) Signed-off-by: Fr?d?ric Demians commit 5cd5b755cd846b0f4076472321920edc0a93f86e Author: Nick Clemens Date: Wed Sep 21 23:09:55 2016 +0000 Bug 17331 - Show holding branch in holds awaiting pickup report This patch adds a holdingbranch column to waitingreseves.tt and separates 'Location' into Home branch and callnumber columns To test: 1 - Have some holds waiting and holds over 2 - View the report before the patch 3 - Note that location contains homebranch and call number 4 - View the report after the patch 5 - Note the new columns 6 - Ensure data is correct and no info has been lost Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Fixed 2 capitalization issues. Signed-off-by: Kyle M Hall (cherry picked from commit 98bca8f34b5fb739167d49868b317cbf16922bb1) Signed-off-by: Fr?d?ric Demians commit 3f235844498dab1719572e25a73d0c5fb7ffcd7b Author: Tomas Cohen Arazi Date: Wed Sep 14 16:00:19 2016 -0300 Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. This patch introduces unit tests for it, in the t/Matcher.t file. To test: - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 5135b1a0a14ca958fe73505ed019bafe944dabc7) Signed-off-by: Fr?d?ric Demians commit c73b60d7168f7f00226d01b09c604f253f35c36c Author: Fr?d?ric Demians Date: Sun Sep 25 14:02:13 2016 +0000 Bug 14707 - DBRev 16.05.04.001 commit e09f10a882d15118bd22789462b2d66f4b1a4dfb Author: Jonathan Druart Date: Wed Sep 14 11:07:58 2016 +0100 Bug 14707: Update existing installations and correct wrong values See http://hea.koha-community.org/, the countries are filled is wrong values. If we decide to update the free text with a dropdown list, we need to handle these wrong data. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 66d669d0735f244cb30e9cfdf53f91c77953b30f) Signed-off-by: Fr?d?ric Demians commit 20db7d6ee679f519a2076614635af831f3164c26 Author: Julian FIOL Date: Tue Aug 18 17:16:53 2015 +0200 Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel Not a complete list but is a start Lots of new strings to translate :) No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 233dfb8c74ce85bdb70bd1eb17231a234387d3c9) Signed-off-by: Fr?d?ric Demians commit 4e8209d595137168667d81875d024e6954fea102 Author: Zeno Tajoli Date: Mon Sep 19 17:03:20 2016 +0200 Bug 13405 - System information has misleading information about indexing mode With this patch when or are set to 'grs1' it appears a link to https://wiki.koha-community.org/wiki/Switching_to_dom_indexing instead of a misleading information. To test: a)Insert 'grs1' in or (file koha-conf.xml) b)It appers a misleading warning c)Apply the patch d)It appears a link to https://wiki.koha-community.org/wiki/Switching_to_dom_indexing. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit cdac530034a6b478b95e2d99ddc171529ee1a6c7) Signed-off-by: Fr?d?ric Demians commit 3d0012e8fe98b910aace7da628c576fc1ba303ab Author: Andreas Roussos Date: Fri Sep 16 18:49:19 2016 +0300 Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt The following three templates are using [% guarantorborrowernumber %] while they should be using [% guarantor.borrowernumber %]: members/members-toolbar.inc members/moremember-brief.tt members/moremember.tt This doesn't result in any breakage; just a couple of 'Edit' links that do not pass the guarantorid in the URL, and one case where guarantor information is not shown in the staff client. This patch fixes that. Test plan: 0) [PREREQUISITE] Create a patron with a guarantor if you don't have one. 1) Go to Home > Patrons and search for a patron that has a guarantor. In the Details page for that patron, the 'Edit' link in the toolbar does not pass the guarantor's id in the URL (...&guarantorid=&...). 2) In the same page, the 'Edit' link under the patrons name (immediately under 'Guarantor') again does not include the guarantor id in the URL. 3) Go to Home > Patrons and click on 'New patron'. Pick any category from the drop down menu. Enter the Surname, First name, and Date of birth of the patron you used in step 1). This triggers the 'Duplicate patron record?' warning -- click on 'View existing record' and notice how the guarantor information is missing. 4) Apply the patch. 5) Repeat steps 1), 2), and 3) above. The URLs are fixed and patron info is showing. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 0f4644a5bf7a43b117fbf6642b6db0479fdc58ed) Signed-off-by: Fr?d?ric Demians commit b0949e921427decf879e8e20d26bf42fefce992d Author: Andreas Roussos Date: Sat Sep 10 11:54:06 2016 +0300 Bug 17289: Holds awaiting pickup shows date unformatted In the Staff client, under Circulation -> Circulation reports, the date shown in the heading of the 'Holds awaiting pickup' report is not formatted according to the 'dateformat' system preference. This (trivial) patch fixes that. Test plan: 1) In the Staff client, go to Circulation and under 'Circulation reports' click on 'Holds awaiting pickup' (cgi-bin/koha/circ/waitingreserves.pl). 2) Observe that the date shown in the heading is always formatted as yyyy-mm-dd regardless of the value of the 'dateformat' syspref. 3) Apply the patch. 4) Re-visit the 'Holds awaiting pickup' report. Confirm that the patch worked, i.e. the date shown in the heading is formatted according to the 'dateformat' system preference. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit f9e3639da7ef02a6ca08014179d216e1d938a401) Signed-off-by: Fr?d?ric Demians commit c81350b6200ce62c180f6fd301ed3406db893835 Author: Rafal Kopaczka Date: Sat Sep 3 18:06:47 2016 +0200 Bug 17245: Untranslatable abbreviated names of seasons. Because seasons strings are not available through DateTime module, names of them where added in code, and templates. Bug 16289 adds new abbreviated form to the code, but not to the templates. This patch should fix the problem. To test: 1. Apply patch. 2. Run "misc/translator/translate update" for you language. 3. Check if names are in po/ file for language. 4. Check if generating next issue for serial and prediction patterns works correct. NOTE: or "create {language code}" instead of update. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 4da3bf5e48fa3462d2f3eca0f3c45f64dc9bb5b2) Signed-off-by: Fr?d?ric Demians commit 8ec4b5b7d4c39a5db05fc13d384412d510206b44 Author: Marc V?ron Date: Tue Sep 20 16:11:22 2016 +0200 Bug 17322 - Translation breaks opac-ics.tt This patch adds newlines to opac-ics.tt that are preserved by the translating process. To test: - Apply patch - Create a translation (perl translate xy-XY) - With a text editor or poedit, translate misc/translator/po/xy-XY-opac-bootstrap.po (it is enough to translate "%s %s %s %s is overdue %sYour copy of........") - Install language xx-XY and select it for OPAC (perl translate install xy-XY) - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. Compare it to the english version. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 756c0f93187174f22d95825f51c4dfa21b11803a) Signed-off-by: Fr?d?ric Demians commit 68c21aabe99fb12ef3987a142f5cc0389422a7bd Author: Andreas Roussos Date: Thu Sep 15 11:37:19 2016 +0300 Bug 10768 - Improve the interface related to itemBarcodeFallbackSearch When the itemBarcodeFallbackSearch syspref is on, the wording in the interface should reflect that you can enter a barcode OR a keyword. Additionally, in the results of a keyword search the "Fast cataloging" link should be more descriptive. This patch fixes these issues. Test plan: 0) [PREREQUISITES] Ensure you have a Fast Add ('FA') framework defined, and that your itemBarcodeFallbackSearch syspref is set to 'Enable'. 1) Go to Circulation -> Check out, search for a patron, then select a patron to Check out. Notice how the text above the textbox reads "Enter item barcode:". 2) Type something generic (not a barcode) in the textbox so that you'll get at least one item as a result. Notice how the text in the yellow warning box reads "The barcode was not found: Fast cataloging". 3) Apply the patch. 4) Repeat step 1), now the text above the textbox should read "Enter item barcode or keyword:". 5) Repeat step 2), now the text in the yellow warning box should read "The barcode was not found: Add record using fast cataloging". Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 6fc03f1968f9e405d745b854577c953106fdbdfe) Signed-off-by: Fr?d?ric Demians commit fefd457550597e2bbcfda1317760c99852829ed2 Author: Jonathan Druart Date: Tue Sep 13 14:41:51 2016 +0100 Bug 16816: Do not copy parameters used when duplicating a report If a report is duplicated from the report list, the new report will contain the tag (<> for instance), but from the reports results page it copies the values used for the results. Test plan: Create a new sql report with tags Duplicate it from the report list: no expected changes Run it and duplicate it: the tags must not have been replaced Signed-off-by: Andreas Roussos Ran and duplicated a report, the tags remained intact. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 50a37fbf5bc22bed843447be6a6603e7705fd28d) Signed-off-by: Fr?d?ric Demians commit 28eafe0b07fc8ec387ba6d7bd37dfadd5cdf01b6 Author: Jonathan Druart Date: Wed Sep 14 14:41:20 2016 +0100 Bug 17300: Fix serials search Since bug 16157, the location value is always "All" and the serial search won't return anything. Test plan: Search for some serials. Without this patch, it won't return any results With this patch applied, the result search should be consistent Reproduced with serial's "Advanced search" and search filter in left hand column. Fixed by this patch. Signed-off-by: Marc Advanced search works fine again. Signed-off-by: Andreas Roussos Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 613c83f4e3e92d9f5a51fd2d5eccefd0dd6d00de) Signed-off-by: Fr?d?ric Demians commit 92d648f579fb03e1e5bed45e28c8604a2ea7aab0 Author: Jonathan Druart Date: Wed Sep 14 13:39:34 2016 +0100 Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 1a2d804a8094ea05199803593698b4294f029913) Signed-off-by: Fr?d?ric Demians commit 1ade46e5a4928ffd8ae4080b0f0f09c0b564ed13 Author: Jonathan Druart Date: Tue Sep 13 09:44:41 2016 +0100 Bug 17294: Make reserves_stats.pl plack safe Lot of errors are raised by this script under plack because of var scope issues: Variable "$ccodes" is not available at /home/koha/src/reports/reserves_stats.pl line 337. Variable "$locations" is not available at /home/koha/src/reports/reserves_stats.pl line 338. Variable "$itemtypes" is not available at /home/koha/src/reports/reserves_stats.pl line 339. Variable "$Bsort1" is not available at /home/koha/src/reports/reserves_stats.pl line 344. Variable "$Bsort2" is not available at /home/koha/src/reports/reserves_stats.pl line 350. Variable "@patron_categories" is not available at /home/koha/src/reports/reserves_stats.pl line 356. The lazy way to fix that is that reinit them from the subroutines they are used. Test plan: Execute the report, after this patch applied you won't see the error in the log. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit f66cc4dfcca243e6210c3323586efbfbd6cfe0cd) Signed-off-by: Fr?d?ric Demians commit 656a25e39cac5ecca5c95dd9b2ae65648d474528 Author: Marc V?ron Date: Thu Aug 18 14:14:47 2016 +0200 Bug 17144: Fix variable scope issues in edi_account.pl To reproduce: - In Staff client, go to Administration > EDI accounts - Click "+ New account" Result: Internal Server Error Plack error log says: Can't call method "param" on an undefined value at /home/marc/koha/admin/edi_accounts.pl line 157 To test: -Apply patch - Add an EDI account - Edit an EDI account - Delete an EDI account Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit a055abe7c06e2efc9f0cdae89c2cbef28b7f3cb3) Signed-off-by: Fr?d?ric Demians commit 3b038239a56abc645eaa4787268b71a7b6603a5a Author: Mirko Tietgen Date: Tue Aug 9 12:58:47 2016 +0200 Bug 17085 - Specify libmojolicious-perl min version Set min version for libmojolicious-perl to 6.0 and regenerate debian/control Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 53f8916fe70f9401923872b7fcd05f63a1e5fdf1) Signed-off-by: Fr?d?ric Demians commit 4e06090d8b0594d99da04824d239bcfa343f5e9c Author: Jonathan Druart Date: Tue Sep 20 10:03:42 2016 +0100 Bug 17316: Do not display the list's name if the user does not have permission - Staff Same as previous patch but for the staff interface Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit d26cda6f9e7e52bb899717ffe5f84c31b46feefc) Signed-off-by: Fr?d?ric Demians commit d46322c7cd30f6be6c6589de79577b720a408d3b Author: Jonathan Druart Date: Tue Sep 20 09:55:25 2016 +0100 Bug 17316: Do not display the list's name if the user does not have permission - OPAC At the OPAC, if a user manipulate the URL to show a list (s)he is not allowed to view, the list's name will be displayed anyway. Test plan: - Create a private list with user A - Copy the op=view URL and access it with user B logged in => Without this patch, you will see the rss icon, the list's name and the "add list" button => Without this patch, only the "unauthorized" box will be displayed Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 31ca4849efd5539c6b287047ce2da560be7e1c53) Signed-off-by: Fr?d?ric Demians commit 1dbc8e550e45a475ccbbc9d375c739307a6630bb Author: Jonathan Druart Date: Tue Sep 20 11:06:23 2016 +0100 Bug 17315: (Bug 17210 follow-up) Fix "Save to lists" links from the result page On bug 17210, the selector .addtoshelf should not have caught the .addtoshelf nodes from the result list. To fix this, we just need to make the selector more specific (and cannot reuse it without more changes, the biblionumber variable is not the same - vs SEARCH_RESULT.biblionumber). Test plan: Make sure the 2 links (from detail and search result) "Save to lists" and "Save to your lists" work as expected. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit e422de7b62322b2637ac5623d102563dd3e82b36) Signed-off-by: Fr?d?ric Demians commit 5a4a65cdbbf2f6cabd5b0979e4c5e969eb66e0fb Author: Jonathan Druart Date: Wed Sep 14 09:20:01 2016 +0100 Bug 16800: Fix XSS in additem.pl Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 9734726846f6fa652d88c8bc39c7b43595422465) Signed-off-by: Fr?d?ric Demians commit 13705e51084f605a0e9fc686e7ee30350fb556e2 Author: Jonathan Druart Date: Tue Aug 2 16:05:09 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - isbn Test plan: catalogue a bibliographic record with a isbn= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Fr?d?ric Demians commit 4ab091d3bfd2c6659320cbe80d35b805cff3aa4e Author: Jonathan Druart Date: Tue Aug 2 16:03:37 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - author Test plan: catalogue a bibliographic record with a author= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 3169434cfa7295025e4ff5fea58f7e9730a96650) Signed-off-by: Fr?d?ric Demians commit c27216cce84fe07c962a8878be51025c9fe0aace Author: Jonathan Druart Date: Tue Aug 2 16:02:07 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - title Test plan: catalogue a bibliographic record with a title= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack This of course means that any html in the title will no longer be evaluated. : Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 515208d5ec308ade967efe04388bbedbf5f2b057) Signed-off-by: Fr?d?ric Demians commit 06937c45855a18bafae74648c6a938c153c59bd9 Author: Tomas Cohen Arazi Date: Tue Sep 13 14:42:32 2016 -0300 Bug 2389: (followup) Add documentation and fix use case Signed-off-by: Tomas Cohen Arazi Signed-off-by: Barton Chittenden Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 9e22a9ced3db2ba0f27d45a551b455095cb910e5) Signed-off-by: Fr?d?ric Demians commit 3f193fb63a3b8561088ee38a90ae32b9a1b276a5 Author: Tomas Cohen Arazi Date: Fri Jul 15 10:18:13 2016 -0300 Bug 2389: Add --test switch to overdue_notices.pl This patch adds the --test option switch to the overdue_notices.pl script so it can be ran without doing any actual action. To test: - Have a patron with overdue items (simulate a checkout for a past date. Note it implies that the circ rules are defined so the patron is overdue) - Run: $ sudo koha-shell kohadev koha-dev$ misc/cronjobs/overdue_notices.pl --test => SUCCESS: The script is ran but the patron isn't debarred and no notice messages are queued. Signed-off-by: Chris Cormack Signed-off-by: Barton Chittenden Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 71454b4263f6e883f7e6246de06291531a7d5757) Signed-off-by: Fr?d?ric Demians ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 1 + Koha.pm | 2 +- admin/edi_accounts.pl | 6 +- debian/control | 4 +- debian/list-deps | 1 + debian/scripts/koha-functions.sh | 4 +- installer/data/mysql/sysprefs.sql | 4 +- installer/data/mysql/updatedatabase.pl | 50 +++++ .../prog/en/includes/av-build-dropbox.inc | 2 +- .../prog/en/includes/members-toolbar.inc | 2 +- .../prog/en/includes/reports-toolbar.inc | 2 +- .../prog/en/includes/virtualshelves-toolbar.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 12 +- .../prog/en/modules/acqui/newordersubscription.tt | 4 + .../prog/en/modules/admin/preferences/admin.pref | 215 +++++++++++++++++++- .../prog/en/modules/catalogue/ISBDdetail.tt | 2 +- .../prog/en/modules/catalogue/MARCdetail.tt | 7 +- .../prog/en/modules/catalogue/detail.tt | 12 +- .../prog/en/modules/catalogue/labeledMARCdetail.tt | 11 +- .../prog/en/modules/catalogue/moredetail.tt | 6 +- .../prog/en/modules/cataloguing/additem.tt | 6 +- .../prog/en/modules/circ/circulation.tt | 8 +- .../prog/en/modules/circ/waitingreserves.tt | 18 +- .../prog/en/modules/members/moremember-brief.tt | 4 +- .../prog/en/modules/members/moremember.tt | 4 +- .../prog/en/modules/offline_circ/process_koc.tt | 4 +- .../en/modules/reports/guided_reports_start.tt | 5 +- .../prog/en/modules/serials/serials-collection.tt | 8 + .../en/modules/serials/showpredictionpattern.tt | 8 + .../prog/en/modules/suggestion/suggestion.tt | 13 +- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../bootstrap/en/includes/opac-bottom.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-ics.tt | 7 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- misc/cronjobs/overdue_notices.pl | 18 +- opac/opac-shelves.pl | 1 + reports/guided_reports.pl | 5 +- reports/reserves_stats.pl | 6 + t/Matcher.t | 163 ++++++++++++++- virtualshelves/shelves.pl | 1 + 40 files changed, 557 insertions(+), 77 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 10:01:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 08:01:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-971-g6f4f32f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6f4f32f4bc1f2176c60fe34cf37b3822f08481aa (commit) from fe0fc226c524d6f63c8d64af7a0c8b2c5ac7198f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f4f32f4bc1f2176c60fe34cf37b3822f08481aa Author: Marc V?ron Date: Fri Sep 30 17:48:44 2016 +0200 Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 12:06:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 10:06:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-972-g130534c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 130534c4241397992521d6da49ebdc761203b3e3 (commit) from 6f4f32f4bc1f2176c60fe34cf37b3822f08481aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 130534c4241397992521d6da49ebdc761203b3e3 Author: Katrin Fischer Date: Sun Sep 25 14:50:09 2016 +0200 Bug 17345: Fix typo in sysprefs.sql This fixes a tiny typo in sysprefs.sql that kept all systempreferences from being installed. To test: - Create a new koha database, run the web installer - Verify that all systempreferences have been loaded select count(*) from systempreferences should be no less than 553 or - Truncate your systempreferences table - Verify that the repaired sysprefs.sql file loads without error Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 12:16:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 10:16:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-973-g0599ab0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e (commit) from 130534c4241397992521d6da49ebdc761203b3e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e Author: Mark Tompsett Date: Tue Sep 20 19:29:28 2016 -0400 Bug 17324: Deal with branchcode NULL issue In a database update we alter the letter table, making a column (branchcode) not be able to contain NULL values. However if it already does, this SQL fails. So before changing the column we change the NULL values [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Did not follow the test plan, but the changes make sense Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 12:33:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 10:33:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-975-g6ff836a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6ff836ab3154a886e0aeedb1152f6caf2e546444 (commit) via f11f07a703eca7da2d32c105f8c9f4f46f940b6f (commit) from 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6ff836ab3154a886e0aeedb1152f6caf2e546444 Author: Mark Tompsett Date: Sun Sep 18 20:47:33 2016 -0400 Bug 17292: Follow up - tweak to make it pass cleaner remove a 'my' next if not defined subscriptions. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit f11f07a703eca7da2d32c105f8c9f4f46f940b6f Author: Kyle M Hall Date: Mon Sep 12 14:20:19 2016 +0000 Bug 17292 - Use of DBIx in updatedatabase.pl broke upgrade A recent change in the 'subscription' table structure highlighted a problem in a DBRev upgrade (3.23.00.006). As it adds a new column, when upgrading from (say) 3.20.00.000 the code/schema (correctly) expects the subscription.itemtype column to exist. But it is not created until DBRev 16.06.00.025. To reproduce: - Have a clean 3.20.00 DB loaded into kohadevbox - Checkout current master - Run: $ perl installer/data/mysql/updatedatabase.pl => FAIL: The upgrade procedure fails due to missing colum. The solution: rewrite the updatedatabase.pl entry using plain DBI Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 37 ++++++++++++++++++++------------ 1 file changed, 23 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 14:04:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 12:04:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-976-g421bc45 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 421bc4523f150d02e7b1c9ded3ca619bef135d92 (commit) from 6ff836ab3154a886e0aeedb1152f6caf2e546444 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 421bc4523f150d02e7b1c9ded3ca619bef135d92 Author: Marcel de Rooy Date: Mon Sep 12 11:30:43 2016 +0200 Bug 7143: Release team for 16.11 Also adding Marc Veron as bug wrangler (see his mail on the general ml dated Oct 5). Test plan: Verify changes by comparing with Roles for 16.11 page on the wiki. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 49 +++++++++++----------- 1 file changed, 24 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 14:20:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 12:20:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-977-gf2196a2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb (commit) from 421bc4523f150d02e7b1c9ded3ca619bef135d92 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb Author: Mason James Date: Wed Aug 3 16:32:00 2016 +1200 Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default to test bug... 1/ make a random user 2/ change to random user 3/ access any zebra database with random user and no authentication 4/ read zebra database here is a transcript of the bug... --------------------------- root at xen1:~# adduser bob root at xen1:~# su -l bob bob at xen1:~$ cd /var/lib/koha bob at xen1:/var/lib/koha$ ls topsecret bob at xen1:/var/lib/koha$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.001002 Z> base biblios; Z> find the Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1130, setno 2 SearchResult-1: term=the cnt=1130 records returned: 0 Elapsed: 0.005518 Z> show Sent presentRequest (1+1). Records: 1 [biblios]Record type: USmarc 01824cam a2200397 a 4500 001 000045782309 003 AuCNLKIN 005 20111013213222.0 008 100707s2011 maua 001 0 e ... --------------------------- 5/ apply changes to a Koha instance's config files, that you plan to test 6/ restart zebra for instance # sudo koha-restart-zebra topsecret 7/ repeat steps 2 and 3, but receive a 'bad user/passwd ' error from zebra bob at xen1:~$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection rejected by v3 target. 1: code=1011 (Init/AC: Bad Userid and/or Password), NOTE: this patch currently will only fixes newly created instances, it wont fix existing instances Signed-off-by: Chris Cormack Good catch Mason Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: etc/zebradb/zebra-authorities-dom.cfg | 2 +- etc/zebradb/zebra-authorities.cfg | 2 +- etc/zebradb/zebra-biblios-dom.cfg | 2 +- etc/zebradb/zebra-biblios.cfg | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 14:27:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 12:27:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-981-gbc1e23e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bc1e23e1f11e146e282d0e2efa7fd77e2c26d631 (commit) via 0eec191ed3ab1ae1bd24972a559d12627b70f681 (commit) via 44b51ed80224d0361796c1a70cb66bb5096a427c (commit) via e72a8ab260abed11b02266d77bc17d831884ed40 (commit) from f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc1e23e1f11e146e282d0e2efa7fd77e2c26d631 Author: Jonathan Druart Date: Tue Oct 4 14:49:19 2016 +0100 Bug 17088: Add tests to cover the changes Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit 0eec191ed3ab1ae1bd24972a559d12627b70f681 Author: Marcel de Rooy Date: Fri Sep 16 11:27:05 2016 +0200 Bug 17088: [Follow-up] Use Logger for failed exports Fixes a TODO for logging unsupported record_type in _get_record_for_export. Also logs a warning when the record_type parameter is not supplied at all in sub export. Replaces a warn by a log message about an invalid record for format iso2709. Also adds a log message about an invalid record for format xml. Adds a trivial unit test for passing no record_type to export. Test plan: See also first patch. Run t/db_dependent/Exporter/Record.t. Signed-off-by: Marcel de Rooy Also tested the log messages for iso2709 and xml by manipulating the record_type parameter with: $params->{record_type}='xx'; before calling _get_record_for_export in Record.pm. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit 44b51ed80224d0361796c1a70cb66bb5096a427c Author: Marcel de Rooy Date: Fri Sep 16 10:44:47 2016 +0200 Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit e72a8ab260abed11b02266d77bc17d831884ed40 Author: Kyle M Hall Date: Tue Aug 9 13:08:17 2016 +0000 Bug 17088 - Bad MARC XML can halt export_records.pl If export_records.pl encounters a record that fails to load correctly as a MARC::Record the export process will fail and only the records encountered up to that point will be exported. Test Plan: 1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters 2) Export your records using the command: misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml 3) Note you get an error and the script ends prematurely 4) Apply this patch 5) Repeat step 2 6) Note the full record set is exported ( except for your bad record ) 7) Note an error is still generated for your bad record ( useful for tracking down bad records ). Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Exporter/Record.pm | 21 ++++++--- Koha/Logger.pm | 8 +++- t/db_dependent/Exporter/Record.t | 89 +++++++++++++++++++++++++------------- 3 files changed, 81 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 14:32:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 12:32:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-982-g613b212 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 613b2126f042311805d1ef7eb822231c8f0a4dee (commit) from bc1e23e1f11e146e282d0e2efa7fd77e2c26d631 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 613b2126f042311805d1ef7eb822231c8f0a4dee Author: Jonathan Druart Date: Tue Oct 4 12:02:03 2016 +0100 Bug 17396: Remove unnecessary t/DataTables/Members.t is unnecessary tests The subroutine C4::Utils::DataTables::Members::search is covered by tests from t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: t/DataTables/Members.t | 14 -------------- 1 file changed, 14 deletions(-) delete mode 100644 t/DataTables/Members.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 14:35:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 12:35:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-983-g884e28f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 884e28fab5e4db86dd9f50f2908519a0cd6650d5 (commit) from 613b2126f042311805d1ef7eb822231c8f0a4dee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 884e28fab5e4db86dd9f50f2908519a0cd6650d5 Author: Andreas Roussos Date: Sat Sep 17 13:44:47 2016 +0300 Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 10 16:09:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Oct 2016 14:09:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-985-g649956b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 649956b216aa21fee70a75d2f9f9f0ac213415d0 (commit) via d63f02a8c46439d76507bb1b07c40e6a86f4130a (commit) from 884e28fab5e4db86dd9f50f2908519a0cd6650d5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 649956b216aa21fee70a75d2f9f9f0ac213415d0 Author: Jonathan Druart Date: Tue Oct 4 13:58:13 2016 +0100 Bug 17386: Simplify code Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher commit d63f02a8c46439d76507bb1b07c40e6a86f4130a Author: Marc V?ron Date: Fri Sep 30 21:30:00 2016 +0200 Bug 17386: Add opac notes for patron to self checkout screen Display patron messages from OPAC summary page on SCO screen as well. To test: - Make sure you have patrons with and without OPAC note and OPAC messages - Log in to OPAC and go to patrons 'your summary' page to display note and messages - Apply patch - Refresh patrons detail page. Verify that it looks the same as before - Go to SCO - Log in as such patron - Verify that note and messages appear the same as on OPAC summary page Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc | 15 +++++++++++++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 15 +-------------- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 1 + opac/opac-user.pl | 11 +---------- opac/sco/sco-main.pl | 13 +++++++++++++ 5 files changed, 31 insertions(+), 24 deletions(-) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 11 10:58:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Oct 2016 08:58:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-988-g118bff6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 118bff64be868df02b3a2363b3ad72cfcca0d8a6 (commit) via 75a217e672647dd26c14540a7ed0ee1df35532e8 (commit) via 7aacc32db8e760f25965f29206ce14f8488c57bd (commit) from 649956b216aa21fee70a75d2f9f9f0ac213415d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 118bff64be868df02b3a2363b3ad72cfcca0d8a6 Author: Marcel de Rooy Date: Wed Jul 27 16:00:43 2016 +0200 Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher commit 75a217e672647dd26c14540a7ed0ee1df35532e8 Author: Marcel de Rooy Date: Wed Jul 27 16:04:51 2016 +0200 Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher commit 7aacc32db8e760f25965f29206ce14f8488c57bd Author: Jonathan Druart Date: Sat Jun 18 15:01:51 2016 +0100 Bug 16769: Uniformise calls to Koha::Cache->set_in_cache From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 2 +- Koha/Cache.pm | 11 +++-------- Koha/Calendar.pm | 2 +- Koha/MetaSearcher.pm | 2 +- svc/report | 2 +- t/Cache.t | 6 +++--- 6 files changed, 10 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 09:24:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 07:24:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-989-gb588bab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b588babdb23bfdc1163864a26c36a61bf8a39ae5 (commit) from 118bff64be868df02b3a2363b3ad72cfcca0d8a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b588babdb23bfdc1163864a26c36a61bf8a39ae5 Author: Marc Date: Wed Oct 5 15:43:29 2016 +0200 Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted Additional tests: Try to delete yourself, to delete a staff member without having superlibrarian permission etc. To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons Amended to include all occurences of 'exit 1' Signed-off-by: Chris Cormack Good catch Marc Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: members/deletemem.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 09:48:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 07:48:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-990-ga36b643 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a36b6430195310b5198077dd50cdb436ef07ce37 (commit) from b588babdb23bfdc1163864a26c36a61bf8a39ae5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a36b6430195310b5198077dd50cdb436ef07ce37 Author: Jonathan Druart Date: Thu Sep 29 10:18:27 2016 +0100 Bug 16838: ES - install mappings for new installs The yaml file is not used to populate ES mapping tables (search_field, search_marc_map and search_marc_to_field) when doing a fresh install. We need to insert them, otherwise ES will be unusable. Test plan: Create a new install and confirm that the ES tables (search_field, search_marc_map and search_marc_to_field) are correctly populated. Bonus points: Use an older DB (prior to 3.23.00.050), execute the updatedatabase.pl script and confirm that the ES table are correctly populated Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/ElasticSearch.pm | 21 +++++++++++++++++++++ installer/data/mysql/updatedatabase.pl | 19 +++---------------- installer/install.pl | 2 ++ 3 files changed, 26 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 09:51:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 07:51:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-991-gdf3df9c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via df3df9cf7199c464565742af59bd48006d93cfdf (commit) from a36b6430195310b5198077dd50cdb436ef07ce37 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df3df9cf7199c464565742af59bd48006d93cfdf Author: Jonathan Druart Date: Thu Sep 29 10:31:11 2016 +0100 Bug 17372: Standardize Elasticsearch paths What we currently have: Koha/ElasticSearch.pm Koha/ElasticSearch/Indexer.pm Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Koha/SearchEngine/Elasticsearch/Search.pm What we want: Koha/SearchEngine/Elasticsearch.pm Koha/SearchEngine/Elasticsearch/Indexer.pm Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Koha/SearchEngine/Elasticsearch/Search.pm Test plan: % git grep -i Koha::ElasticSearch % git grep ElasticSearch|grep -v Catmandu::Store::ElasticSearch should not return any result Do a full reindex and search for records Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 4 ++-- Koha/{ElasticSearch.pm => SearchEngine/Elasticsearch.pm} | 6 ++++-- .../{ElasticSearch => SearchEngine/Elasticsearch}/Indexer.pm | 10 +++++----- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 ++-- Koha/SearchEngine/Elasticsearch/Search.pm | 6 +++--- installer/data/mysql/updatedatabase.pl | 4 ++-- installer/install.pl | 4 ++-- misc/search_tools/rebuild_elastic_search.pl | 8 ++++---- t/00-load.t | 2 +- t/db_dependent/{Koha_ElasticSearch.t => Koha_Elasticsearch.} | 2 +- ..._ElasticSearch_Indexer.t => Koha_Elasticsearch_Indexer.t} | 4 ++-- t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t | 2 +- 12 files changed, 29 insertions(+), 27 deletions(-) rename Koha/{ElasticSearch.pm => SearchEngine/Elasticsearch.pm} (98%) rename Koha/{ElasticSearch => SearchEngine/Elasticsearch}/Indexer.pm (94%) rename t/db_dependent/{Koha_ElasticSearch.t => Koha_Elasticsearch.} (94%) rename t/db_dependent/{Koha_ElasticSearch_Indexer.t => Koha_Elasticsearch_Indexer.t} (90%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 12:27:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 10:27:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-998-g981ad35 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 981ad35ce3390d473fcb63ca9cd58996b456ddc0 (commit) via 38eee216aef7160d3e60662770a24c10ec9752f6 (commit) via c253af2e519570c4024891dc4d1e81743a2c5fc2 (commit) via 4383ec732ef5dd202352ee4ed30c3cb1da24393e (commit) via 228a9ac882e2c716c95a341df298058af5fc7cba (commit) via 1a77758989619086512829a7f7904c9370c6715d (commit) via 6a2a15aae803997cb9f090a59e893a7242d56923 (commit) from df3df9cf7199c464565742af59bd48006d93cfdf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 981ad35ce3390d473fcb63ca9cd58996b456ddc0 Author: Jonathan Druart Date: Tue Aug 9 16:53:27 2016 +0100 Bug 17091: Add delete to the Koha::Objects AUTOLOAD method Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 38eee216aef7160d3e60662770a24c10ec9752f6 Author: Jonathan Druart Date: Tue Aug 9 16:34:15 2016 +0100 Bug 17091: In a first phase, restrict the usage of AUTOLOAD in Koha::Objects To make sure the methods will be covered by tests and devs won't overused this method, I think it may be a good idea to restrict its usage. Signed-off-by: Hector Castro AUTOLOAD added. No Koha QA errors. Test passed successfully Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit c253af2e519570c4024891dc4d1e81743a2c5fc2 Author: Jonathan Druart Date: Tue Aug 9 15:58:31 2016 +0100 Bug 17091: Remove explicit declaration of Koha::Objects->reset Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 4383ec732ef5dd202352ee4ed30c3cb1da24393e Author: Jonathan Druart Date: Tue Aug 9 15:54:58 2016 +0100 Bug 17091: Remove explicit declaration of Koha::Objects->pager Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 228a9ac882e2c716c95a341df298058af5fc7cba Author: Jonathan Druart Date: Tue Aug 9 15:48:05 2016 +0100 Bug 17091: Remove explicit declaration of Koha::Objects->count Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 1a77758989619086512829a7f7904c9370c6715d Author: Jonathan Druart Date: Tue Aug 9 15:46:48 2016 +0100 Bug 17091: Remove explicit declaration of Koha::Objects->update Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 6a2a15aae803997cb9f090a59e893a7242d56923 Author: Jonathan Druart Date: Tue Aug 9 15:46:11 2016 +0100 Bug 17091: Add AUTOLOAD to Koha::Objects Up to now if a Koha::Objects based object needs to call DBIx::Class methods, we have to create a new method for Koha::Objects, something like: sub method { my $self = shift; return $self->_resultset->method } To simplify and ease the call to DBIx::Class method, this patch defines an AUTOLOAD to call the DBIx::Class method on the resultset we are encapsulating. Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 77 +++++++++++++---------------------------- t/db_dependent/Koha/Objects.t | 32 ++++++++++++++++- 2 files changed, 55 insertions(+), 54 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 13:03:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 11:03:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-999-g75a900d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 75a900d55365dc6a8d1396b68329a0679d9dc430 (commit) from 981ad35ce3390d473fcb63ca9cd58996b456ddc0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75a900d55365dc6a8d1396b68329a0679d9dc430 Author: Jonathan Druart Date: Tue Sep 27 13:38:34 2016 +0100 Bug 17358: Rename COU with COUNTRY and LAN with LANG Some installer files use COU and LAN instead of COUNTRY and LANG. To uniformise these AVs, it would be good to use the same code. Note that I do not think we should update existing installations Carefully compared code. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 6 +++--- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 13:38:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 11:38:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1001-g442734b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 442734b4380dc7326bbd242d021a457acff0e18e (commit) via ce076e0e757ff812eba21ee6102e6c44076e5595 (commit) from 75a900d55365dc6a8d1396b68329a0679d9dc430 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 442734b4380dc7326bbd242d021a457acff0e18e Author: Brendan Gallagher Date: Tue Oct 11 04:52:13 2016 +0000 Uping DBRev. Bug 17357 - WTHDRAWN is still used in installer files Signed-off-by: Brendan Gallagher Signed-off-by: Brendan Gallagher commit ce076e0e757ff812eba21ee6102e6c44076e5595 Author: Jonathan Druart Date: Tue Sep 27 10:52:17 2016 +0100 Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files Some installer files still use WTHDRAWN instead of WITHDRAWN as an AV category. Test plan: git grep WTHDRAWN installer should not return any results Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../unimarc/mandatory/unimarc_framework_DEFAULT.sql | 2 +- .../unimarc/mandatory/unimarc_framework_DEFAULT.sql | 2 +- .../unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- .../mandatory/unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- .../unimarc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../mandatory/unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_AN_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_AUD_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_BOOK_local.sql | 2 +- .../unimarc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_EL_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_MIN_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_NOTE_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_PER_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_TECH_local.sql | 2 +- installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 17 files changed, 27 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 14:01:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 12:01:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1004-ga1a0bdd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a1a0bdd7983d9baf74dcb4b38ee2cdfea25fb0b2 (commit) via b7d25c83e6a39c75804c18c07ac76231d43b57b9 (commit) via d2510f3e76b1b24ad473944d96141cc0f7a643d4 (commit) from 442734b4380dc7326bbd242d021a457acff0e18e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a1a0bdd7983d9baf74dcb4b38ee2cdfea25fb0b2 Author: Kyle M Hall Date: Mon Oct 10 17:30:43 2016 +0000 Bug 17226 - Fix unit tests Signed-off-by: Brendan Gallagher commit b7d25c83e6a39c75804c18c07ac76231d43b57b9 Author: Jonathan Druart Date: Tue Aug 30 16:22:53 2016 +0100 Bug 17226: Make Koha::Object->get_column available Signed-off-by: Claire Gravely Signed-off-by: Brendan Gallagher commit d2510f3e76b1b24ad473944d96141cc0f7a643d4 Author: Jonathan Druart Date: Tue Aug 30 16:13:21 2016 +0100 Bug 17226: Improve Koha::Object's AUTOLOAD method Following the path of bug 17091, Koha::Object needs to AUTOLOAD the methods provided by DBIX::Class. We already use in_storage, id and is_changed, but others are coming! Test plan: prove t/db_dependent/Koha/Object.t should return green Signed-off-by: Claire Gravely Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Object.pm | 54 ++++++------------------- t/Patron.t | 8 ++-- t/db_dependent/Koha/Object.t | 92 ++++++++++++++++++++++++++++++++++++++++++ t/db_dependent/Patron.t | 72 --------------------------------- 4 files changed, 109 insertions(+), 117 deletions(-) create mode 100755 t/db_dependent/Koha/Object.t delete mode 100755 t/db_dependent/Patron.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 14:08:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 12:08:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1009-ga66b0e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a66b0e20d7d1b2602cced006712ce5fc308aeb10 (commit) via bc41b29b6437445c35b71fe4fc623506e3cf6fbf (commit) via d8809285ad792d0a2dbab8695a07131fecb27ef1 (commit) via 39bdb865fcf8a9147a891496459e1a7ecd57e30e (commit) via 57ffd456ded327b85db1da710345037dc21b5897 (commit) from a1a0bdd7983d9baf74dcb4b38ee2cdfea25fb0b2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a66b0e20d7d1b2602cced006712ce5fc308aeb10 Author: Kyle M Hall Date: Mon Oct 10 20:57:26 2016 +0000 Bug 14899 - Convert links to buttons, add icons Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit bc41b29b6437445c35b71fe4fc623506e3cf6fbf Author: Jonathan Druart Date: Thu Sep 29 12:03:22 2016 +0100 Bug 14899: Add a reset option For developpers only at the moment, if you want to reset your mappings, you can hit: admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit d8809285ad792d0a2dbab8695a07131fecb27ef1 Author: Jonathan Druart Date: Fri Sep 25 16:16:28 2015 +0100 Bug 14899: Add a link to the new page in the admin Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 39bdb865fcf8a9147a891496459e1a7ecd57e30e Author: Jonathan Druart Date: Fri Sep 25 16:06:55 2015 +0100 Bug 14899: Add the mapping configuration page in the admin module This new page (admin/searchengine/elasticsearch/mappings.pl) will permit to manage the ES mappings. For the biblios and authorities indexes, the different mappings can be managed from this single page. The interface let you add, remove and update mappings and search fields. It's also possible to reorder the mappings, as the order can be important in the indexation process. Note that the table can be displayed in a different order that the one it was before saving, but the mappings are grouped by search field and the order inside the search field is preserved. Limitations: - If something went wrong during the insertion/deletion/modification, the users will loose all these changes. TODO: - Add a specific permission (?) - Add some data checks client side (JS) - Use checkboxes for facet and suggestible (lazy today...) - Understand the difference between the 3 values that sortable can have and improve the value for the options in the select box. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher commit 57ffd456ded327b85db1da710345037dc21b5897 Author: Jonathan Druart Date: Fri Sep 25 15:49:16 2015 +0100 Bug 14899: Add tableDND JS lib Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: admin/searchengine/elasticsearch/mappings.pl | 144 +++++ .../lib/jquery/plugins/jquery.tablednd.js | 672 ++++++++++++++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 + .../prog/en/modules/admin/admin-home.tt | 4 + .../admin/searchengine/elasticsearch/mappings.tt | 298 +++++++++ 5 files changed, 1121 insertions(+) create mode 100755 admin/searchengine/elasticsearch/mappings.pl create mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.tablednd.js create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 12 15:41:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Oct 2016 13:41:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1010-ga8376f9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a8376f99d9c8afea1c68f44e170100c2d703fcb7 (commit) from a66b0e20d7d1b2602cced006712ce5fc308aeb10 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a8376f99d9c8afea1c68f44e170100c2d703fcb7 Author: Martin Renvoize Date: Wed Oct 12 11:56:44 2016 +0000 Bug 17432: Remove minification The swagger specification file is currently being minified adding manual steps to release management and restful api route development. The minification is not required; The deferenced version of the specification is now internally validated at runtime and relavant errors output and the dereferenced schema has been made publically available at /api/v1/spec, so it can be copy&pasted into validation tools Test Plan 1) Apply patch 2) Ensure api routes still function (applying the /cities patch might be helpful) 3) Ensure /api/v1/spec page exists (it should be the de-referenced swagger.json file) Signed-off-by: Claire Gravely Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1.pm | 4 +- api/v1/swagger/swagger.min.json | 1 - misc/devel/minifySwagger.pl | 98 --------------------------------------- 3 files changed, 3 insertions(+), 100 deletions(-) delete mode 100644 api/v1/swagger/swagger.min.json delete mode 100644 misc/devel/minifySwagger.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 15:32:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 13:32:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1027-g3fe925e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3fe925ee1900d607eca6eb8952430e02a85c4d24 (commit) via 493d7c30a194e78d0474f9db4824004fa410c879 (commit) via 8d40fd2c6ebad16d7f9154bf6d6821d3b7e059de (commit) via 5d0dbcaabe833dd0980bffbfd583e071773f8d79 (commit) via 610dbfb5dd97fc4f20c6a52696f8f94e03a36312 (commit) via dc23d944adb9d3fefcd129cde11fb88a18933649 (commit) via 4454c85b92790e905b22f07d701bd6b996b81575 (commit) via 3f72fa15f23fb94eadbd5d3c450b9cc7851df6e5 (commit) via 1e75506f80a913eae9a903c0bc7eb6b425664da1 (commit) via 38d4bffa73ed11ab43b2dcf5bbbb94f5d1ba90c3 (commit) via 62aa3f4292d83bc9304e296de5f0830e28510492 (commit) via d0f543bd6cf2fb5209ea622415249fa46a59a09f (commit) via f97249f56e7c32745f2d31dd6aa36f724f4cba33 (commit) via d7badeaafa8a7d5643a21478c13911e8c1c9e90b (commit) via ef19f6705a5fcee0f0027b3a9d09fa2d027907a6 (commit) via a79eb3f30a68b1a6b41387e1d47ef65857853112 (commit) via 9d5e2aee41dd4a5343f4b16ba7ea8d9736eb4a28 (commit) from a8376f99d9c8afea1c68f44e170100c2d703fcb7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fe925ee1900d607eca6eb8952430e02a85c4d24 Author: Brendan Gallagher Date: Tue Oct 11 11:18:50 2016 +0000 UPdating the DBREv for Bug 17216 - Add a new table to store authorized value categories commit 493d7c30a194e78d0474f9db4824004fa410c879 Author: Jonathan Druart Date: Tue Sep 27 13:44:13 2016 +0100 Bug 17216: Move the AV cat list file to the top level This way it will get used for any languages. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 8d40fd2c6ebad16d7f9154bf6d6821d3b7e059de Author: Jonathan Druart Date: Tue Sep 27 09:24:57 2016 +0100 Bug 17216: Internal AV should be correctly handled when creating a new category Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 5d0dbcaabe833dd0980bffbfd583e071773f8d79 Author: Jonathan Druart Date: Mon Sep 19 12:35:40 2016 +0100 Bug 17216: Do no display the empty string category name Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 610dbfb5dd97fc4f20c6a52696f8f94e03a36312 Author: Jonathan Druart Date: Mon Sep 19 10:55:12 2016 +0100 Bug 17216: Do not display branches, itemtypes and cn_source Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit dc23d944adb9d3fefcd129cde11fb88a18933649 Author: Jonathan Druart Date: Tue Aug 30 17:03:59 2016 +0100 Bug 17216: Fix other tests Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 4454c85b92790e905b22f07d701bd6b996b81575 Author: Jonathan Druart Date: Tue Aug 30 12:09:03 2016 +0100 Bug 17216: Fix tests Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 3f72fa15f23fb94eadbd5d3c450b9cc7851df6e5 Author: Jonathan Druart Date: Tue Aug 30 12:02:15 2016 +0100 Bug 17216: Update DBIC schema for MSS Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 1e75506f80a913eae9a903c0bc7eb6b425664da1 Author: Jonathan Druart Date: Tue Aug 30 11:56:14 2016 +0100 Bug 17216: Update DBIC Schema Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 38d4bffa73ed11ab43b2dcf5bbbb94f5d1ba90c3 Author: Jonathan Druart Date: Tue Aug 30 11:55:52 2016 +0100 Bug 17216: Add FK on authorised_values.category Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 62aa3f4292d83bc9304e296de5f0830e28510492 Author: Jonathan Druart Date: Mon Aug 29 14:07:45 2016 +0100 Bug 17216: Use Koha::AVC from mss.pl Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit d0f543bd6cf2fb5209ea622415249fa46a59a09f Author: Jonathan Druart Date: Mon Aug 29 14:07:27 2016 +0100 Bug 17216: Add FK on mss.authorised_value Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit f97249f56e7c32745f2d31dd6aa36f724f4cba33 Author: Jonathan Druart Date: Mon Aug 29 14:06:46 2016 +0100 Bug 17216: Update the admin interface Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit d7badeaafa8a7d5643a21478c13911e8c1c9e90b Author: Jonathan Druart Date: Mon Aug 29 14:05:51 2016 +0100 Bug 17216: DBIC Schema changes Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit ef19f6705a5fcee0f0027b3a9d09fa2d027907a6 Author: Jonathan Druart Date: Mon Aug 29 15:15:10 2016 +0100 Bug 17216: Add some other AV categories Found in installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit a79eb3f30a68b1a6b41387e1d47ef65857853112 Author: Jonathan Druart Date: Mon Aug 29 14:04:53 2016 +0100 Bug 17216: Add new table authorised_value_categories and populate it This patch set adds a new table authorised_value_categories to store authori(s|z)ed value categories into a separate table. The problematic is explained on bug 15799 comment 4: We need FK to the AV categories but some may not have authorized values yet. What does this patch set: - Add a new authorised_value_categories table - Populate it with known categories - Update FK items_search_fields.authorised_values_category - Create a new FK marc_subfield_structure.authorised_value (FIXME should be authorised_value_categories instead) They are some problems this patch set do not take into account: - The .sql installer files won't insert correctly (will have to be updated when this patch set will be ready to be pushed) - All the categories (even the ones without authorized values defined) are listed when you edit frameworks (marc_subfield_structure.pl) - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". Test plan: 0/ Execute the DB entry to create and populate the new table and set the FK 1/ Create a new AV category from the admin module (admin/authorised_values.pl) 2/ Add/edit subfield linked to a AV category (admin/marc_subfield_structure.pl) 3/ You won't be allowed to add AV for branches, itemtypes or cn_source. They are used internally. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit 9d5e2aee41dd4a5343f4b16ba7ea8d9736eb4a28 Author: Jonathan Druart Date: Mon Aug 29 13:56:02 2016 +0100 Bug 17216: Add Koha::AuthorisedValueCategory|ies classes Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 3 + Koha.pm | 2 +- ...oFrameworks.pm => AuthorisedValueCategories.pm} | 10 +- Koha/{City.pm => AuthorisedValueCategory.pm} | 6 +- Koha/Schema/Result/AuthorisedValue.pm | 29 ++++-- Koha/Schema/Result/AuthorisedValueCategory.pm | 105 ++++++++++++++++++++ Koha/Schema/Result/ItemsSearchField.pm | 14 +-- Koha/Schema/Result/MarcSubfieldStructure.pm | 31 +++++- admin/authorised_values.pl | 52 +++++++--- admin/marc_subfields_structure.pl | 11 +- .../Obligatoire/framework_DEFAULT.sql | 6 ++ installer/data/mysql/kohastructure.sql | 21 +++- installer/data/mysql/mandatory/auth_val_cat.sql | 51 ++++++++++ installer/data/mysql/updatedatabase.pl | 88 ++++++++++++++++ .../prog/en/modules/admin/authorised_values.tt | 38 ++++--- .../en/modules/admin/marc_subfields_structure.tt | 1 + t/db_dependent/AuthorisedValues.t | 4 + t/db_dependent/Koha.t | 7 +- 18 files changed, 408 insertions(+), 71 deletions(-) copy Koha/{BiblioFrameworks.pm => AuthorisedValueCategories.pm} (79%) copy Koha/{City.pm => AuthorisedValueCategory.pm} (85%) create mode 100644 Koha/Schema/Result/AuthorisedValueCategory.pm create mode 100644 installer/data/mysql/mandatory/auth_val_cat.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 16:59:23 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 14:59:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1028-g8cb65b3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8cb65b367b47ffd9a1a362e7261199fefc3628bb (commit) from 3fe925ee1900d607eca6eb8952430e02a85c4d24 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8cb65b367b47ffd9a1a362e7261199fefc3628bb Author: Jesse Maseto Date: Wed Oct 12 17:44:42 2016 +0000 Bug 7143 NEW added Kyle Hall as release manager. Signed-off-by: Dani Elder Signed-off-by: Marcel de Rooy ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:01:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:01:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1029-g1e6df24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1e6df24d6cbf44c865805712e6a15ecc601273aa (commit) from 8cb65b367b47ffd9a1a362e7261199fefc3628bb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e6df24d6cbf44c865805712e6a15ecc601273aa Author: Jesse Weaver Date: Fri May 13 16:27:22 2016 -0600 Bug 16520: Allow per-VirtualHost environment variables with Plack This allows OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Middleware/SetEnv.pm | 122 +++++++++++++++++++++++++++++++++++++++++++ debian/templates/plack.psgi | 5 +- misc/plack/koha.psgi | 3 ++ 3 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 Koha/Middleware/SetEnv.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:10:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:10:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1032-g174769e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 174769e382dfd5205595a5b9ae7b58c8ebf5d850 (commit) via e40f61bc3087727db75d07b02c34545300d153b1 (commit) via 27b756eb91e0ce93f46233dabe3957a66e978d4d (commit) from 1e6df24d6cbf44c865805712e6a15ecc601273aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 174769e382dfd5205595a5b9ae7b58c8ebf5d850 Author: Nick Clemens Date: Thu Oct 13 08:35:24 2016 +0000 Bug 16520 (Follow up) Rebase fixes Signed-off-by: Kyle M Hall commit e40f61bc3087727db75d07b02c34545300d153b1 Author: Jesse Weaver Date: Fri May 13 16:40:11 2016 -0600 Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files This was not added to the old etc/koha-httpd.conf because that file has no infrastructure for Plack anyway. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 27b756eb91e0ce93f46233dabe3957a66e978d4d Author: Jesse Weaver Date: Fri May 13 16:39:08 2016 -0600 Bug 16520: Initialize the sysprefs Koha::Caches on demand Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 15 ++++++++------- Koha/Middleware/SetEnv.pm | 10 ---------- debian/templates/apache-shared.conf | 5 +++++ 3 files changed, 13 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:23:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:23:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1033-gbb1e9c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bb1e9c500c810402c64436c53bcc00ffb9a0b857 (commit) from 174769e382dfd5205595a5b9ae7b58c8ebf5d850 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Author: Jonathan Druart Date: Wed Aug 10 13:04:48 2016 +0100 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description (lib) for a given authorised value. We can easily replace it using: Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib or Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description Test plan: - On the detail page of a bibliographic record, the description for notforloan, restricted and stack (?) should be correctly displayed - View a shelf, the location (LOC) description should be displayed - On the search result page, the location description should be displayed in the facets - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - When creating item in the acquisition module, the dropdown list for field linked to AV should display the AV' descriptions - On the transfers page, the description of the location should be displayed. - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed - Fill some OPAC_SUG AV and create a suggestion, the reason dropdown list should display the description of OPAC_SUG Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 1 - C4/Items.pm | 23 ++++++++++++++++------- C4/Koha.pm | 22 ---------------------- C4/Search.pm | 8 +++++--- acqui/orderreceive.pl | 15 ++++++++++----- catalogue/getitem-ajax.pl | 17 ++++++++++++----- circ/branchtransfers.pl | 8 ++++++-- circ/circulation.pl | 4 +++- circ/returns.pl | 4 +++- opac/opac-suggestions.pl | 5 ++++- serials/subscription-detail.pl | 6 ++++-- 11 files changed, 63 insertions(+), 50 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:25:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:25:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1034-gef0b0f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ef0b0f13fcba4605f99386d4c2bdd87e82234493 (commit) from bb1e9c500c810402c64436c53bcc00ffb9a0b857 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef0b0f13fcba4605f99386d4c2bdd87e82234493 Author: Jonathan Druart Date: Tue Aug 9 16:26:07 2016 +0100 Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects Instead of DBIx::Class objects. Test plan: 1/ Add content to a list and share it with another patron 2/ Try to view the list with the other patron 3/ download and send a shelf and check if the biblio list is correct 4/ prove t/db_dependent/Virtualshelves.t should return green Signed-off-by: Aleisha Amohia Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Virtualshelf.pm | 7 +++++-- opac/opac-downloadshelf.pl | 4 ++-- opac/opac-sendshelf.pl | 2 +- opac/opac-shelves.pl | 7 +++++-- virtualshelves/downloadshelf.pl | 4 ++-- virtualshelves/sendshelf.pl | 2 +- virtualshelves/shelves.pl | 12 ++++++++---- 7 files changed, 24 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:32:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:32:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1036-gee719cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ee719cf10cf2f1c81de485228a98fc33e0f0c81b (commit) via 807ee1daa02f4bafe8da5689e74d76e997e7b5b8 (commit) from ef0b0f13fcba4605f99386d4c2bdd87e82234493 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ee719cf10cf2f1c81de485228a98fc33e0f0c81b Author: Jonathan Druart Date: Mon Jul 4 12:21:19 2016 +0100 Bug 16850: Remove C4::Members::IsMemberBlocked This subroutine is only called once and can be replaced with a call to is_debarred and has_overdues. Note that prior to this patch, IsMemberBlocked copy/paste code from HasOverdues, which did not make sense. Test plan: Debar a patron and make sure he is not able to checkout (the librarian is asked to overwrite if OverduesBlockCirc is set to 'confirmation') Remove the debarment and add overdues to this patron, same as previously, the checkout should be blocked Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher commit 807ee1daa02f4bafe8da5689e74d76e997e7b5b8 Author: Jonathan Druart Date: Mon Jul 4 12:19:46 2016 +0100 Bug 16850: Add test coverage for CanBookBeIssued Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 31 +++++++++++---------- C4/Members.pm | 44 ------------------------------ t/db_dependent/Circulation.t | 61 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 76 insertions(+), 60 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 13 17:38:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Oct 2016 15:38:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1037-gdbf2f7d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dbf2f7d6d97686179a1e794e0c74ad8be441a177 (commit) from ee719cf10cf2f1c81de485228a98fc33e0f0c81b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dbf2f7d6d97686179a1e794e0c74ad8be441a177 Author: Nick Clemens Date: Fri Aug 26 19:20:34 2016 +0000 Bug 15388 - Show Syndetics covers by UPC in search results Syndetics code accepts UPC and OCLC numbers, however, we were only passing this if there was an ISBN. This patch alters the code to search if either an ISBN or UPC is present To test: Enable syndetics (will need an account) Search for items with UPCs or OCLC numbers and no ISBN (DVDs) Note there are no images in search results but there are in details Apply patch Note that items with images in details now also have images in results Signed-off-by: Barbara.Johnson at bedfordtx.gov Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 09:32:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 07:32:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1038-ged63510 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ed63510fdc0e5a8f8681f0c25b442762315c141d (commit) from dbf2f7d6d97686179a1e794e0c74ad8be441a177 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed63510fdc0e5a8f8681f0c25b442762315c141d Author: Colin Campbell Date: Fri Oct 7 15:57:50 2016 +0100 BUG 17414 Add new GIR codes in Edifact Add the 4 GIR codes which were added by Editeur since 1.2 So that the list of recognized GIR codes is now complete And thse codes can be used in future development Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Edifact/Line.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:01:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:01:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1039-g43418ae Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 43418ae9f088f023b1d398ab30faaebb9c00cbf5 (commit) from ed63510fdc0e5a8f8681f0c25b442762315c141d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 43418ae9f088f023b1d398ab30faaebb9c00cbf5 Author: Kyle M Hall Date: Thu Feb 4 19:41:57 2016 +0000 Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass Signed-off-by: Barton Chittenden barton at bywatersolutions.com Signed-off-by: Dani Elder Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/HoldsQueue.pm | 54 ++++++++++++++++++++++++++++ t/db_dependent/HoldsQueue.t | 82 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 135 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:32:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:32:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1040-gf28460b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3 (commit) from 43418ae9f088f023b1d398ab30faaebb9c00cbf5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3 Author: Nick Clemens Date: Wed Oct 5 13:26:09 2016 +0000 Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actual overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified by reading code - couldn't verify using Overdrive. Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: opac/svc/overdrive_proxy | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:34:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:34:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1042-ga1dcd2f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874 (commit) via a1eeffd8385e5b95ca1d06a8300e5bd42403486a (commit) from f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874 Author: Jonathan Druart Date: Mon Oct 3 15:23:39 2016 +0100 Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro Warnings avoided Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher commit a1eeffd8385e5b95ca1d06a8300e5bd42403486a Author: Jonathan Druart Date: Mon Oct 3 15:15:40 2016 +0100 Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/ImportExportFramework.pm | 7 ++++--- admin/import_export_framework.pl | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:36:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:36:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1043-g1d0d5f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d (commit) from a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d Author: Jonathan Druart Date: Thu Sep 29 08:46:49 2016 +0100 Bug 17365: Fix XSS in moremember.pl and memberentry.pl There are certainly hundred of places where they are not escaped... Test plan: Create a patron with "Arun " in some of the fields. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/circ-menu.inc | 14 +++--- .../prog/en/includes/members-toolbar.inc | 2 +- .../prog/en/includes/patron-title.inc | 16 +++--- .../prog/en/modules/members/memberentrygen.tt | 46 ++++++++--------- .../prog/en/modules/members/moremember.tt | 52 ++++++++++---------- 5 files changed, 65 insertions(+), 65 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:39:58 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:39:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1044-g692014c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 692014c817b58876042ab03d71bde0c2cce7e571 (commit) from 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 692014c817b58876042ab03d71bde0c2cce7e571 Author: Marc Date: Fri Oct 7 11:03:45 2016 +0200 Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: members/pay.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 11:45:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 09:45:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1046-g17e2e6c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 17e2e6c994655aaa927b2579524022a4f24a8d1d (commit) via ff495c5fa8c58a7762b3494e97d90618d649f7a8 (commit) from 692014c817b58876042ab03d71bde0c2cce7e571 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17e2e6c994655aaa927b2579524022a4f24a8d1d Author: Marcel de Rooy Date: Fri Oct 14 11:07:49 2016 +0200 Bug 17441: [QA Follow-up] Return value of SendAlerts This patch makes the return value of SendAlerts more consistent. It returns 1 on success, or undef || { error => 'msg' } on failure. Needed to adjust one test in Letters.t too. Adjusted one typo along the way (seleted). Signed-off-by: Marcel de Rooy Tested by running Letters.t. Also tested SendAlerts from the interface with AutoEmailOpacUser and memberentry (adding new patron). Signed-off-by: Brendan Gallagher commit ff495c5fa8c58a7762b3494e97d90618d649f7a8 Author: Katrin Fischer Date: Thu Oct 13 19:05:48 2016 +0200 Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy To improve consistency, adding a follow-up. Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 18 +++++++++++++++--- t/db_dependent/Letters.t | 2 +- 2 files changed, 16 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 12:11:05 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 10:11:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1047-gf75afef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f75afef59175933f7e93b04bdcbdcf5180b0b024 (commit) from 17e2e6c994655aaa927b2579524022a4f24a8d1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f75afef59175933f7e93b04bdcbdcf5180b0b024 Author: Marcel de Rooy Date: Fri Oct 14 11:29:44 2016 +0200 Bug 17446: Typo seleted Built on top of bug 17441 Test plan: Just have a look at the changes. Trivial. Git grep seleted. No results. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 2 +- acqui/lateorders.pl | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 12:15:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 10:15:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-4-gd4c2f83 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via d4c2f83f8f6a12a9e635fbb50c8e85aea7e240af (commit) via b54b8ffac75b29844fd1117fc088f9817d76e3e7 (commit) via fd6594246e28b99d74abce87f0c515787805ea4d (commit) via c55f33030fa31842f04fda06b22d5a7bb9831134 (commit) from cd11a1209360be4f444a070709f902fb3334eabb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4c2f83f8f6a12a9e635fbb50c8e85aea7e240af Author: Jonathan Druart Date: Wed Sep 14 09:20:01 2016 +0100 Bug 16800: Fix XSS in additem.pl Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 9734726846f6fa652d88c8bc39c7b43595422465) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5a4a65cdbbf2f6cabd5b0979e4c5e969eb66e0fb) Signed-off-by: Julian Maurice commit b54b8ffac75b29844fd1117fc088f9817d76e3e7 Author: Jonathan Druart Date: Tue Aug 2 16:05:09 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - isbn Test plan: catalogue a bibliographic record with a isbn= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Fr?d?ric Demians (cherry picked from commit 13705e51084f605a0e9fc686e7ee30350fb556e2) Signed-off-by: Julian Maurice commit fd6594246e28b99d74abce87f0c515787805ea4d Author: Jonathan Druart Date: Tue Aug 2 16:03:37 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - author Test plan: catalogue a bibliographic record with a author= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 3169434cfa7295025e4ff5fea58f7e9730a96650) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4ab091d3bfd2c6659320cbe80d35b805cff3aa4e) Signed-off-by: Julian Maurice commit c55f33030fa31842f04fda06b22d5a7bb9831134 Author: Jonathan Druart Date: Tue Aug 2 16:02:07 2016 +0100 Bug 16800: Fix XSS in catalogue/*detail.tt - title Test plan: catalogue a bibliographic record with a title= Go on the detail pages. => Without this patch you will see the alert => With this patch, no more alert Signed-off-by: Chris Cormack This of course means that any html in the title will no longer be evaluated. : Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 515208d5ec308ade967efe04388bbedbf5f2b057) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c27216cce84fe07c962a8878be51025c9fe0aace) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 12 ++++++------ .../prog/en/modules/catalogue/labeledMARCdetail.tt | 6 +++--- .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 6 +++--- .../intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 6 +++--- 6 files changed, 17 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 12:30:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 10:30:57 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-6-g18bd60a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 18bd60a8548229ca252863b60f0e9d27da46350b (commit) via db049cda6f01266a967b559f1ee506fb3800d024 (commit) from d4c2f83f8f6a12a9e635fbb50c8e85aea7e240af (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 18bd60a8548229ca252863b60f0e9d27da46350b Author: Jonathan Druart Date: Tue Sep 20 10:03:42 2016 +0100 Bug 17316: Do not display the list's name if the user does not have permission - Staff Same as previous patch but for the staff interface Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit d26cda6f9e7e52bb899717ffe5f84c31b46feefc) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4e06090d8b0594d99da04824d239bcfa343f5e9c) Signed-off-by: Julian Maurice commit db049cda6f01266a967b559f1ee506fb3800d024 Author: Jonathan Druart Date: Tue Sep 20 09:55:25 2016 +0100 Bug 17316: Do not display the list's name if the user does not have permission - OPAC At the OPAC, if a user manipulate the URL to show a list (s)he is not allowed to view, the list's name will be displayed anyway. Test plan: - Create a private list with user A - Copy the op=view URL and access it with user B logged in => Without this patch, you will see the rss icon, the list's name and the "add list" button => Without this patch, only the "unauthorized" box will be displayed Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 31ca4849efd5539c6b287047ce2da560be7e1c53) Signed-off-by: Fr?d?ric Demians (cherry picked from commit d46322c7cd30f6be6c6589de79577b720a408d3b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- opac/opac-shelves.pl | 1 + virtualshelves/shelves.pl | 1 + 5 files changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 13:52:21 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 11:52:21 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-7-g8536442 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 853644230c2e792abbced63971eedf3903b4712a (commit) from 18bd60a8548229ca252863b60f0e9d27da46350b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 853644230c2e792abbced63971eedf3903b4712a Author: Mirko Tietgen Date: Tue Aug 9 12:58:47 2016 +0200 Bug 17085 - Specify libmojolicious-perl min version Set min version for libmojolicious-perl to 6.0 and regenerate debian/control Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 53f8916fe70f9401923872b7fcd05f63a1e5fdf1) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 3b038239a56abc645eaa4787268b71a7b6603a5a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: debian/control | 4 ++-- debian/list-deps | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 13:54:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 11:54:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-8-g70ca305 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 70ca305311cfdc7c56da5ce6cae8706d2bcacf80 (commit) from 853644230c2e792abbced63971eedf3903b4712a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70ca305311cfdc7c56da5ce6cae8706d2bcacf80 Author: Jonathan Druart Date: Tue Sep 13 09:44:41 2016 +0100 Bug 17294: Make reserves_stats.pl plack safe Lot of errors are raised by this script under plack because of var scope issues: Variable "$ccodes" is not available at /home/koha/src/reports/reserves_stats.pl line 337. Variable "$locations" is not available at /home/koha/src/reports/reserves_stats.pl line 338. Variable "$itemtypes" is not available at /home/koha/src/reports/reserves_stats.pl line 339. Variable "$Bsort1" is not available at /home/koha/src/reports/reserves_stats.pl line 344. Variable "$Bsort2" is not available at /home/koha/src/reports/reserves_stats.pl line 350. Variable "@patron_categories" is not available at /home/koha/src/reports/reserves_stats.pl line 356. The lazy way to fix that is that reinit them from the subroutines they are used. Test plan: Execute the report, after this patch applied you won't see the error in the log. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit f66cc4dfcca243e6210c3323586efbfbd6cfe0cd) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 1ade46e5a4928ffd8ae4080b0f0f09c0b564ed13) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: reports/reserves_stats.pl | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 13:56:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 11:56:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-9-g1c1b236 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 1c1b2363273d891049e234138d15095f015dc7f3 (commit) from 70ca305311cfdc7c56da5ce6cae8706d2bcacf80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1c1b2363273d891049e234138d15095f015dc7f3 Author: Jonathan Druart Date: Wed Sep 14 13:39:34 2016 +0100 Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 1a2d804a8094ea05199803593698b4294f029913) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 92d648f579fb03e1e5bed45e28c8604a2ea7aab0) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 13:58:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 11:58:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-10-gc36a8e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c36a8e832159fc7e1ef0ec24e4cde9cb793c6c4c (commit) from 1c1b2363273d891049e234138d15095f015dc7f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c36a8e832159fc7e1ef0ec24e4cde9cb793c6c4c Author: Jonathan Druart Date: Tue Sep 13 14:41:51 2016 +0100 Bug 16816: Do not copy parameters used when duplicating a report If a report is duplicated from the report list, the new report will contain the tag (<> for instance), but from the reports results page it copies the values used for the results. Test plan: Create a new sql report with tags Duplicate it from the report list: no expected changes Run it and duplicate it: the tags must not have been replaced Signed-off-by: Andreas Roussos Ran and duplicated a report, the tags remained intact. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 50a37fbf5bc22bed843447be6a6603e7705fd28d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit fefd457550597e2bbcfda1317760c99852829ed2) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +- reports/guided_reports.pl | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:00:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:00:40 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-11-g8ba984a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8ba984afc04bc90bbb61cba2ef26c5038c360526 (commit) from c36a8e832159fc7e1ef0ec24e4cde9cb793c6c4c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ba984afc04bc90bbb61cba2ef26c5038c360526 Author: Andreas Roussos Date: Thu Sep 15 11:37:19 2016 +0300 Bug 10768 - Improve the interface related to itemBarcodeFallbackSearch When the itemBarcodeFallbackSearch syspref is on, the wording in the interface should reflect that you can enter a barcode OR a keyword. Additionally, in the results of a keyword search the "Fast cataloging" link should be more descriptive. This patch fixes these issues. Test plan: 0) [PREREQUISITES] Ensure you have a Fast Add ('FA') framework defined, and that your itemBarcodeFallbackSearch syspref is set to 'Enable'. 1) Go to Circulation -> Check out, search for a patron, then select a patron to Check out. Notice how the text above the textbox reads "Enter item barcode:". 2) Type something generic (not a barcode) in the textbox so that you'll get at least one item as a result. Notice how the text in the yellow warning box reads "The barcode was not found: Fast cataloging". 3) Apply the patch. 4) Repeat step 1), now the text above the textbox should read "Enter item barcode or keyword:". 5) Repeat step 2), now the text in the yellow warning box should read "The barcode was not found: Add record using fast cataloging". Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 6fc03f1968f9e405d745b854577c953106fdbdfe) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 68c21aabe99fb12ef3987a142f5cc0389422a7bd) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:04:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:04:08 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-12-g75899ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 75899cab1f81c29df28253e04898c34eda6c24bc (commit) from 8ba984afc04bc90bbb61cba2ef26c5038c360526 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75899cab1f81c29df28253e04898c34eda6c24bc Author: Rafal Kopaczka Date: Sat Sep 3 18:06:47 2016 +0200 Bug 17245: Untranslatable abbreviated names of seasons. Because seasons strings are not available through DateTime module, names of them where added in code, and templates. Bug 16289 adds new abbreviated form to the code, but not to the templates. This patch should fix the problem. To test: 1. Apply patch. 2. Run "misc/translator/translate update" for you language. 3. Check if names are in po/ file for language. 4. Check if generating next issue for serial and prediction patterns works correct. NOTE: or "create {language code}" instead of update. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 4da3bf5e48fa3462d2f3eca0f3c45f64dc9bb5b2) Signed-off-by: Fr?d?ric Demians (cherry picked from commit c81350b6200ce62c180f6fd301ed3406db893835) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/serials/serials-collection.tt | 8 ++++++++ .../prog/en/modules/serials/showpredictionpattern.tt | 8 ++++++++ 2 files changed, 16 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:05:37 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:05:37 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-13-gd835cd1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via d835cd19af6125d93e18b684f0177a8667ecc1d0 (commit) from 75899cab1f81c29df28253e04898c34eda6c24bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d835cd19af6125d93e18b684f0177a8667ecc1d0 Author: Andreas Roussos Date: Sat Sep 10 11:54:06 2016 +0300 Bug 17289: Holds awaiting pickup shows date unformatted In the Staff client, under Circulation -> Circulation reports, the date shown in the heading of the 'Holds awaiting pickup' report is not formatted according to the 'dateformat' system preference. This (trivial) patch fixes that. Test plan: 1) In the Staff client, go to Circulation and under 'Circulation reports' click on 'Holds awaiting pickup' (cgi-bin/koha/circ/waitingreserves.pl). 2) Observe that the date shown in the heading is always formatted as yyyy-mm-dd regardless of the value of the 'dateformat' syspref. 3) Apply the patch. 4) Re-visit the 'Holds awaiting pickup' report. Confirm that the patch worked, i.e. the date shown in the heading is formatted according to the 'dateformat' system preference. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit f9e3639da7ef02a6ca08014179d216e1d938a401) Signed-off-by: Fr?d?ric Demians (cherry picked from commit b0949e921427decf879e8e20d26bf42fefce992d) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:22:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:22:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-14-gbbaba54 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via bbaba5492f53d43c786eedaefac9a712f3a6624b (commit) from d835cd19af6125d93e18b684f0177a8667ecc1d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bbaba5492f53d43c786eedaefac9a712f3a6624b Author: Zeno Tajoli Date: Mon Sep 19 17:03:20 2016 +0200 Bug 13405 - System information has misleading information about indexing mode With this patch when or are set to 'grs1' it appears a link to https://wiki.koha-community.org/wiki/Switching_to_dom_indexing instead of a misleading information. To test: a)Insert 'grs1' in or (file koha-conf.xml) b)It appers a misleading warning c)Apply the patch d)It appears a link to https://wiki.koha-community.org/wiki/Switching_to_dom_indexing. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit cdac530034a6b478b95e2d99ddc171529ee1a6c7) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4e8209d595137168667d81875d024e6954fea102) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:34:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:34:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-17-gd2abcdb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via d2abcdb9438fd6e1298fcc288b07901a11b57be2 (commit) via 2da7a46881bd4fa72ff08e57795332f71b5e05f6 (commit) via ebfe59ccf3bb325d11c3be7aacf2e1193a57a597 (commit) from bbaba5492f53d43c786eedaefac9a712f3a6624b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d2abcdb9438fd6e1298fcc288b07901a11b57be2 Author: Fr?d?ric Demians Date: Sun Sep 25 14:02:13 2016 +0000 Bug 14707: Update DB rev (3.22.11.001) (cherry picked from commit c73b60d7168f7f00226d01b09c604f253f35c36c) Signed-off-by: Julian Maurice commit 2da7a46881bd4fa72ff08e57795332f71b5e05f6 Author: Jonathan Druart Date: Wed Sep 14 11:07:58 2016 +0100 Bug 14707: Update existing installations and correct wrong values See http://hea.koha-community.org/, the countries are filled is wrong values. If we decide to update the free text with a dropdown list, we need to handle these wrong data. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 66d669d0735f244cb30e9cfdf53f91c77953b30f) Signed-off-by: Fr?d?ric Demians (cherry picked from commit e09f10a882d15118bd22789462b2d66f4b1a4dfb) Signed-off-by: Julian Maurice commit ebfe59ccf3bb325d11c3be7aacf2e1193a57a597 Author: Julian FIOL Date: Tue Aug 18 17:16:53 2015 +0200 Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. Signed-off-by: Bernardo Gonzalez Kriegel Not a complete list but is a start Lots of new strings to translate :) No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 233dfb8c74ce85bdb70bd1eb17231a234387d3c9) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 20db7d6ee679f519a2076614635af831f3164c26) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 4 +- installer/data/mysql/updatedatabase.pl | 50 +++++ .../prog/en/modules/admin/preferences/admin.pref | 215 +++++++++++++++++++- 4 files changed, 260 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 14 14:36:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Oct 2016 12:36:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-18-ga5d7488 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via a5d748883490f0ca1fce7e062057cbd86e640f4b (commit) from d2abcdb9438fd6e1298fcc288b07901a11b57be2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5d748883490f0ca1fce7e062057cbd86e640f4b Author: Andreas Jonsson Date: Mon Oct 3 09:08:03 2016 +0100 Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache The problem is that the memcached configuration variables are extracted from the apache configuration file incorrectly so you get '"127.0.0.1:11211"' including double quotes as the servers parameter to memcached. Signed-off-by: Chris Cormack Note this only applies on 3.22.x but it does fix the problem Definitely needed for 3.22.12 Signed-off-by: Jonathan Druart Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0fc92ab72d1bab7e84df9fc78e3cbd3f2abb3d97) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 18 00:56:27 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Oct 2016 22:56:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1048-gd5ca2d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d5ca2d0433b75317c5a2b855ee77372ca93d2223 (commit) from f75afef59175933f7e93b04bdcbdcf5180b0b024 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d5ca2d0433b75317c5a2b855ee77372ca93d2223 Author: Tomas Cohen Arazi Date: Wed Oct 12 11:01:54 2016 +0200 Bug 17430: Make MarkIssueReturned.t create its own data This patch makes MarkIssueReturned.t use t::lib::TestBuilder to create the data it needs. To test: - On master, have a category with categorycode = C - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => FAIL: primary key problems make the tests fail - Apply the patch - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests are green! - Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation/MarkIssueReturned.t | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 18 01:03:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Oct 2016 23:03:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1049-gba8ee98 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8 (commit) from d5ca2d0433b75317c5a2b855ee77372ca93d2223 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8 Author: Jonathan Druart Date: Tue Sep 13 15:03:55 2016 +0100 Bug 16358: Do not redirect to the editor when deleting records The "Delete record" button goes to addbiblio.pl?op=delete, which incorrectly redirects to Rancor when selected. Test plan: 0/ Enable EnableAdvancedCatalogingEditor 1/ Edit a record 2/ Switch to the Advanced editor 3/ click on "View the record" 4/ Delete the record => Without this patch you are redirected to the editor => With this patch you are redirected to the advanced search Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 18 01:44:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Oct 2016 23:44:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1050-ge78f81d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e78f81d615a79ad293d599c7395efcabd267662d (commit) from ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e78f81d615a79ad293d599c7395efcabd267662d Author: Fridolin Somers Date: Tue Oct 11 10:00:56 2016 +0200 Bug 17423 - patronimage.pl permission is too restrictive Bug 14566 added the permission "borrowers" on patronimage.pl. This perm is too restrictive because circulation pages also uses this page. I propose to simply use "catalogue" perm. Test plan - Set an image to borrower xx - Create a user with only catalogue permission - Log with this user - Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx => Without patch you get the page saying you do not have the permission => With patch you get the image - Log out and retest the page patronimage.pl => You get 403 error Signed-off-by: remy Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: members/patronimage.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 18 01:47:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Oct 2016 23:47:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1051-gf1298dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f1298dc7828757fe9277a5128910335d2d6c0f2c (commit) from e78f81d615a79ad293d599c7395efcabd267662d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f1298dc7828757fe9277a5128910335d2d6c0f2c Author: Fridolin Somers Date: Wed Sep 28 14:49:32 2016 +0200 Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: opac/opac-detail.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 18 17:58:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 18 Oct 2016 15:58:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1052-g3b34d10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3b34d108e7360d0bfe74dde3d87b2398c9649c83 (commit) from f1298dc7828757fe9277a5128910335d2d6c0f2c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b34d108e7360d0bfe74dde3d87b2398c9649c83 Author: Jonathan Druart Date: Tue Oct 18 09:52:50 2016 +0100 Bug 17216: Revert changes to ItemsSearchField schema file Signed-off-by: Brendan Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/ItemsSearchField.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:11:24 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:11:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1055-g31cb200 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 31cb200e0d97106f6e2a009b4cbbd0a295bbaaf5 (commit) via fab0bc976470ca99646b06b7810954b4e2fd18f1 (commit) via 3635e8f82660ced571af592088a369db698101a3 (commit) from 3b34d108e7360d0bfe74dde3d87b2398c9649c83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31cb200e0d97106f6e2a009b4cbbd0a295bbaaf5 Author: Tomas Cohen Arazi Date: Tue Oct 18 12:02:25 2016 -0300 Bug 10337: (followup) Upper case MARC flavour This patch makes the populate_db.pl script upper case what gets passed with the --marcflavour option switch. This is needed in order for this to fit ``kohadevbox`` configuration files, and it is harmless for other uses. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit fab0bc976470ca99646b06b7810954b4e2fd18f1 Author: Tomas Cohen Arazi Date: Tue Oct 18 09:47:26 2016 -0300 Bug 10337: (QA followup) Allow choosing MARC flavour This patch enables the --marcflavour option switch so the user can specify the desired marc flavour. The code for handling it was already in place, just not used. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 3635e8f82660ced571af592088a369db698101a3 Author: Jonathan Druart Date: Mon Oct 17 17:50:50 2016 +0100 Bug 10337: Add a script to populate devs' DBs with sample data Executing the installer process and inserting all the sample data take a lot of clics and time. The idea of this script is to provide a quick way to insert all the sample data easily to get a working Koha install asap. Test plan: - Set your database config to a non-existent DB - Execute perl misc/devel/populate_db.pl You will get an error - Create an empty DB - Execute perl misc/devel/populate_db.pl It will insert all the MARC21 sample data - Execute perl misc/devel/populate_db.pl You will get an error because the DB is not empty (systempreferences and borrowers tables) Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 4 + misc/devel/populate_db.pl | 193 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 197 insertions(+) create mode 100755 misc/devel/populate_db.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:12:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:12:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1056-gfbe75e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6 (commit) from 31cb200e0d97106f6e2a009b4cbbd0a295bbaaf5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6 Author: Hector Castro Date: Thu Oct 20 08:57:46 2016 -0600 Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:22:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:22:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1057-g35de8aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35de8aa1ef07b04cfc7c977f7168cd36b40d7941 (commit) from fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35de8aa1ef07b04cfc7c977f7168cd36b40d7941 Author: Jonathan Druart Date: Tue Oct 4 08:29:30 2016 +0100 Bug 17393: Fix non-Latin chars handling in self reg If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x Test plan: 0/ Do not apply the patch 1/ Set up the Self reg feature 2/ fill surname, fistname with something like "Micha? pou???" 3/ Save 4/ See the bad encoding/replacement on the screen and look at the data The accentued chars are replaced with their html representation and the non-Latin chars with a 'x' in the DB 5/ Apply this patch 6/ Repeat steps 2, 3 7/ Everything should be ok 8/ Try to make sure this HTML::Entities escape was not useful: fill surname with "surname " Save and look at the data Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:30:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:30:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1058-gf060709 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f060709df0ed07c0ff3dbc20404fa5b3b2aa8651 (commit) from 35de8aa1ef07b04cfc7c977f7168cd36b40d7941 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f060709df0ed07c0ff3dbc20404fa5b3b2aa8651 Author: Rodrigo Santellan Date: Mon Oct 10 04:20:12 2016 -0400 Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Fr?d?ric Demians Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel Fix the issue, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:34:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:34:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1059-gede157e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6 (commit) from f060709df0ed07c0ff3dbc20404fa5b3b2aa8651 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6 Author: Jonathan Druart Date: Tue Oct 11 13:15:27 2016 +0100 Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Signed-off-by: Marc Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/BackgroundJob.t | 2 +- t/db_dependent/Patron/Borrower_Discharge.t | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:48:00 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:48:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1070-g35101c9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35101c91279849ee2df0c4d5bc1c6529feaddf0c (commit) via 47b6f454abb45b13a6f405d0517d8f26512a1c71 (commit) via 5de488038d29964f6bd5a29b24e934a3af7c73de (commit) via 706f472642d988da2c0a93b5530208d7cc34374b (commit) via 25801b44bb8d0c81b05230488842c05906b9d412 (commit) via 6a31228172855d08e1cb08d3a3e3a8c7d91ae5a3 (commit) via d27cb605ec96f205e141f6bb485e2b6d52913dde (commit) via bee79b014b1e9feb8fdada0772165089dcca6a71 (commit) via 236a8c3ebbcb290c93305364306538c859ef41c7 (commit) via c7493439c7fce4cfbba68b4e0b57c0fa47952433 (commit) via 3e1923070c679d0014fecf093cde6f1f5d50ccce (commit) from ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35101c91279849ee2df0c4d5bc1c6529feaddf0c Author: Kyle M Hall Date: Fri Oct 21 14:37:46 2016 +0000 Bug 10455 - DBRev 16.06.00.034 Signed-off-by: Kyle M Hall commit 47b6f454abb45b13a6f405d0517d8f26512a1c71 Author: Nick Clemens Date: Tue Sep 27 17:37:45 2016 +0000 Bug 10455 (QA Followup) Fix record matching in misc/cronjobs/delete_records_via_leader.pl Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 5de488038d29964f6bd5a29b24e934a3af7c73de Author: Jonathan Druart Date: Thu Aug 25 16:18:02 2016 +0100 Bug 10455: Fix tests Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 706f472642d988da2c0a93b5530208d7cc34374b Author: Jonathan Druart Date: Thu Aug 25 14:54:09 2016 +0100 Bug 10455: Remove MARC21_utf8_flag_fix.pl Is this script still in use? It uses the biblioitems.marc field so if it's still useful it will need to be rewritten. Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 25801b44bb8d0c81b05230488842c05906b9d412 Author: Jonathan Druart Date: Thu Aug 25 13:43:44 2016 +0100 Bug 10455: (follow-up 3) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 6a31228172855d08e1cb08d3a3e3a8c7d91ae5a3 Author: Jonathan Druart Date: Thu Aug 25 13:31:38 2016 +0100 Bug 10455: (follow-up 2) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit d27cb605ec96f205e141f6bb485e2b6d52913dde Author: Jonathan Druart Date: Thu Aug 25 11:26:45 2016 +0100 Bug 10455: (follow-up) Remove biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit bee79b014b1e9feb8fdada0772165089dcca6a71 Author: Jonathan Druart Date: Thu Aug 25 10:21:37 2016 +0100 Bug 10455: Remove biblioitems.marc - update delete_records_via_leader.pl Recently added, delete_records_via_leader.pl reads biblioitems.marc as a text field and search for record to delete regarding the leader 5. This can be acchieve doing the same thing on biblioitems.marcxml (will certainly be slower) waiting for a patch on bug 15537. Test plan: Confirm that this script works as before, to do so the easiest way would be to dump your DB before executing the update DB entry, execute the script to delete records, reinsert the DB, execute the udpate DB entry (remove biblioitems.marc), execute the script to delete records. You should get the same number of records deleted. Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 236a8c3ebbcb290c93305364306538c859ef41c7 Author: Jonathan Druart Date: Thu Aug 25 10:02:50 2016 +0100 Bug 10455: Remove biblioitems.marc - rm MARC21_parse_test.pl This script seems to be unused and it won't be of any usefulness after the removal of biblioitems.marc Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit c7493439c7fce4cfbba68b4e0b57c0fa47952433 Author: Jonathan Druart Date: Thu Aug 25 10:01:59 2016 +0100 Bug 10455: Remove biblioitems.marc Any discussions about biblioitems.marc bring to the same conclusion: This field is useless and should be removed. We are storing MARC data into 2 different fields, that does not make sense. Test plan: Add / update / export / import /delete records should work as before Signed-off-by: Mason James Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 3e1923070c679d0014fecf093cde6f1f5d50ccce Author: Jonathan Druart Date: Thu Aug 25 10:01:47 2016 +0100 Bug 10455: Remove biblioitems.marc - DB changes Signed-off-by: Mason James Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 21 +- C4/ILSDI/Services.pm | 4 - C4/Items.pm | 4 +- C4/Overdues.pm | 3 +- Koha.pm | 2 +- Koha/BiblioUtils/Iterator.pm | 9 +- Koha/Schema/Result/Biblioitem.pm | 11 +- Koha/Schema/Result/Deletedbiblioitem.pm | 11 +- installer/data/mysql/kohastructure.sql | 2 - installer/data/mysql/updatedatabase.pl | 14 ++ misc/cronjobs/MARC21_parse_test.pl | 327 ---------------------------- misc/cronjobs/delete_records_via_leader.pl | 5 +- misc/maintenance/MARC21_utf8_flag_fix.pl | 219 ------------------- t/db_dependent/Acquisition.t | 1 - 14 files changed, 38 insertions(+), 595 deletions(-) delete mode 100755 misc/cronjobs/MARC21_parse_test.pl delete mode 100755 misc/maintenance/MARC21_utf8_flag_fix.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:49:10 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:49:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1071-g6f5ea70 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6f5ea70f9a20ee0f30057d91a4a23e7f3c04b77e (commit) from 35101c91279849ee2df0c4d5bc1c6529feaddf0c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f5ea70f9a20ee0f30057d91a4a23e7f3c04b77e Author: Jonathan Druart Date: Wed Sep 28 14:45:21 2016 +0100 Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/KitchenSinkPlugin.kpz | Bin 74771 -> 75857 bytes 1 file changed, 0 insertions(+), 0 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 16:52:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 14:52:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1073-g556a487 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 556a4870d6beced7df52dbbc2ad472769e79e148 (commit) via a74329af022eeb857e1f936c13274c0e41497472 (commit) from 6f5ea70f9a20ee0f30057d91a4a23e7f3c04b77e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 556a4870d6beced7df52dbbc2ad472769e79e148 Author: Marcel de Rooy Date: Fri Oct 14 10:01:12 2016 +0200 Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Position 7 of the leader is better referred to as biblevel. (Pos 6 is record type.) At the same time replacing some regex's by simple eq's. Signed-off-by: Marcel de Rooy It seems that bib level in the UNIMARC leader only allows a subset of the possible combinations for MARC21. This does not have bad side-effects however in the new code that tests bib level to determine the type tag. Signed-off-by: Kyle M Hall commit a74329af022eeb857e1f936c13274c0e41497472 Author: Hector Castro Date: Wed Sep 28 15:29:37 2016 -0600 Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 89 ++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 52 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:07:54 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:07:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1074-ga5b6470 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a5b64708601f58fddf89d328d7f0ed94cfc214f9 (commit) from 556a4870d6beced7df52dbbc2ad472769e79e148 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a5b64708601f58fddf89d328d7f0ed94cfc214f9 Author: Marc V?ron Date: Tue Jun 7 17:29:22 2016 +0200 Bug 16687 - Translatability: Fix issues in Administration preferences This patch fixes sentence splitting and other translation issues in file koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref to avoid odd translations. To test: - Without patch, open Home > Administration > System preferences and go to tab 'Administration" - Apply patch - Open the same page in a new window and compare the text: - Verify that no sentences are splitted - Verify that the text changes do not introduce misunderstandings and have the same meaning as without patch Amended for comment #7 2016-07-12/mv Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Rebased to apply on master and re-inserted test (see comment #14) -2016-09-28/mv Signed-off-by: Michael Kuhn Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/admin.pref | 169 ++++++++++---------- 1 file changed, 81 insertions(+), 88 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:09:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:09:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1076-gf1a8ca1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f1a8ca13028411384847615fbdeeaaedd9703382 (commit) via 01636dca2f1bd132fcc8d16f7a91fa4a45a90668 (commit) from a5b64708601f58fddf89d328d7f0ed94cfc214f9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f1a8ca13028411384847615fbdeeaaedd9703382 Author: Jonathan Druart Date: Tue Oct 18 17:14:58 2016 +0100 Bug 17411: Remove 3 other occurrences of exit 1 Signed-off-by: Kyle M Hall commit 01636dca2f1bd132fcc8d16f7a91fa4a45a90668 Author: Marc Date: Thu Oct 6 14:37:14 2016 +0200 Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 Signed-off-by: David Cook Signed-off-by: Jonathan Druart Amended patch: Remove unecessary comment Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 -- acqui/basket.pl | 2 +- tools/quotes/quotes_ajax.pl | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:11:25 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:11:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1077-g5939fd7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5939fd72fd6769bb83fa6a993f12d3214082b7b5 (commit) from f1a8ca13028411384847615fbdeeaaedd9703382 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5939fd72fd6769bb83fa6a993f12d3214082b7b5 Author: Mirko Tietgen Date: Wed Oct 12 15:15:27 2016 +0200 Bug 17084 debian/control updates (master) Dependencies for Bug 16885 and 17425 Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/control | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:11:55 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:11:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1078-g9a81a13 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a81a138d45b245b69754f3e61115d5d997510c0 (commit) from 5939fd72fd6769bb83fa6a993f12d3214082b7b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a81a138d45b245b69754f3e61115d5d997510c0 Author: Marc Date: Wed Oct 5 16:08:52 2016 +0200 Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:12:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:12:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1080-g1e17c92 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1e17c92905143f6bc8cac38f00256541c7146fa3 (commit) via 734d08c2af16909f96b19003c4cc1d758b74f11d (commit) from 9a81a138d45b245b69754f3e61115d5d997510c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e17c92905143f6bc8cac38f00256541c7146fa3 Author: Nick Clemens Date: Fri Oct 14 08:52:54 2016 +0000 Bug 17154 (QA followup) replace tabs with spaces Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 734d08c2af16909f96b19003c4cc1d758b74f11d Author: Sophie Meynieux Date: Mon Aug 22 12:02:11 2016 +0200 Bug 17154 : Note column is missing on account lines receipt When displaying Fines > Account tab for a patron, you can see on screen a Note column that is missing if you click on Print Test plan : * Find a patron with accountlines or add them manually (Create manual invoice/credit). * Be sure some of them got a Note * Clik on Print fior those lines Without patch, the printed receipt does not show the Note column with the patch, the printed receipt shows a Note column and Note content is correctly printed for accountline with a note. Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/printfeercpt.tt | 12 +++++++----- .../intranet-tmpl/prog/en/modules/members/printinvoice.tt | 12 +++++++----- members/printfeercpt.pl | 1 + members/printinvoice.pl | 1 + 4 files changed, 16 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:13:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:13:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1081-g430a641 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 430a64148207e7c390746060eb9ee31916185738 (commit) from 1e17c92905143f6bc8cac38f00256541c7146fa3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 430a64148207e7c390746060eb9ee31916185738 Author: Jonathan Druart Date: Tue Aug 23 18:50:20 2016 +0100 Bug 17173: Quick jump to subfield edition form There are too many clicks to jump to the edit form of a specific subfield. This patch adds a hidden feature (i.e. will not be polished or documented). When searching for a tag field from a marc framework structure, it's not possible to search for a tag subfield to jump directly to the subfield edition form. Test plan: On /admin/marctagstructure.pl?frameworkcode=FRAMEWORKCODE Search for a subfield (952$d) you will be redirected to the subfield edition form There is no check if the subfield does not exist. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: admin/marctagstructure.pl | 6 ++++++ 1 file changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:14:18 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:14:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1088-g15506a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15506a7569145cf566aab28e1b7639be56058a26 (commit) via c913a3482bcca547d371931261a8831f2cd4ecaf (commit) via af224055de23a25a4cae7f4a7e0e047d3e8780f1 (commit) via 7ea9b72c67ea2bb8f7ec11388a3a0c62e8384473 (commit) via 1626087562a98b66d24aa190bdf5b3f26b098b09 (commit) via 54410ca823e2c9a7f24f63422612ec0af5c4a163 (commit) via b8c824909ebde8a0d4b39d7340dbb32e7c9856b3 (commit) from 430a64148207e7c390746060eb9ee31916185738 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15506a7569145cf566aab28e1b7639be56058a26 Author: Jonathan Druart Date: Wed Aug 10 09:10:52 2016 +0100 Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField The subroutine GetAuthValCodeFromField was only used from GetKohaAuthorisedValuesFromField. Test plan: git grep GetAuthValCodeFromField should not return any occurrences. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit c913a3482bcca547d371931261a8831f2cd4ecaf Author: Jonathan Druart Date: Wed Aug 10 12:10:46 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField Remove the subroutine, it's no longer in used. Test plan: git grep GetKohaAuthorisedValuesFromField should not return any occurrences. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit af224055de23a25a4cae7f4a7e0e047d3e8780f1 Author: Jonathan Druart Date: Mon Sep 5 16:12:56 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory Before this patch set, the tests in t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But with the previous patch, it was in 45sec(!) To make sure decrease this execution time to what it was before, this patch introduces a local to avoid the same query to be executed several times. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 7ea9b72c67ea2bb8f7ec11388a3a0c62e8384473 Author: Jonathan Druart Date: Wed Aug 10 12:10:09 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory This patch deals with the inventory files calling GetKohaAuthorisedValuesFromField. Test plan: prove t/db_dependent/Items/GetItemsForInventory.t should still return green Use the inventory tool, on the result page the AV descriptions should correctly replace the codes Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 1626087562a98b66d24aa190bdf5b3f26b098b09 Author: Jonathan Druart Date: Wed Aug 10 11:36:40 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field This patch adds a new Koha::AuthorisedValues->search_by_marc_field method. It will permit to replace several subroutine from C4::Koha dealing with authorised values. It also uses this new methods to replace an occurrence of GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv Test plan: prove t/db_dependent/AuthorisedValues.t should return green Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 54410ca823e2c9a7f24f63422612ec0af5c4a163 Author: Jonathan Druart Date: Wed Aug 10 11:28:40 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests This patch adds a few tests to C4::Record::marcrecord2csv The subroutine was not covered enough to validate that this patch set won't add regressions. Note that the patch set will fix an issue: If 2 subfields of a field are linked to AVs and you want to display them in a CSV, they won't be replaced with their descriptions. Test plan: Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t Checkout master and prove marcrecord2csv.t Tests should fail Checkout the branch with the whole patch set applied The tests should pass Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit b8c824909ebde8a0d4b39d7340dbb32e7c9856b3 Author: Jonathan Druart Date: Wed Aug 10 09:07:26 2016 +0100 Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] This patch adds the 2 Koha::Object based classes for the marc_subfield_structure table Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 57 +------------------- C4/Record.pm | 11 ++-- Koha/AuthorisedValues.pm | 18 +++++++ Koha/{City.pm => MarcSubfieldStructure.pm} | 6 +-- Koha/{Authorities.pm => MarcSubfieldStructures.pm} | 16 ++---- t/db_dependent/AuthorisedValues.t | 34 +++++++++++- t/db_dependent/Items/GetItemsForInventory.t | 12 ++++- t/db_dependent/Koha/MarcSubfieldStructures.t | 57 ++++++++++++++++++++ t/db_dependent/Record/marcrecord2csv.t | 42 ++++++++++++++- tools/inventory.pl | 5 +- 10 files changed, 180 insertions(+), 78 deletions(-) copy Koha/{City.pm => MarcSubfieldStructure.pm} (86%) copy Koha/{Authorities.pm => MarcSubfieldStructures.pm} (80%) create mode 100644 t/db_dependent/Koha/MarcSubfieldStructures.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 17:32:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 15:32:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1091-g8323db3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8323db303dd6d1c486574e7750ad58df2c25c744 (commit) via 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757 (commit) via d019f86f671771a36006f8847712317e0337c02f (commit) from 15506a7569145cf566aab28e1b7639be56058a26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8323db303dd6d1c486574e7750ad58df2c25c744 Author: Jonathan Druart Date: Wed Aug 10 12:29:57 2016 +0100 Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping This subroutine was only used once in GetItemsForInventory. It can be replaced with a quite simple search on AV join on authorised_value_categories and marc_subfield_structures tables. Note that the "interface" parameter was always set to "staff" and was useless. Test plan: Play with the inventory and confirm that the AV descriptions are correctly displayed. The tests in t/db_dependent/Items/GetItemsForInventory.t cover this change and should still pass. Signed-off-by: Claire Gravely Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757 Author: Jonathan Druart Date: Wed Oct 12 13:48:09 2016 +0100 Bug 17250: Do not retrieve marc subfield structure when the authorised value is not defined GetAuthValCode did not return anything if the authorised_value column was not defined. Our new calls to Koha::MarcSubfieldStructures->search should behave the same Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit d019f86f671771a36006f8847712317e0337c02f Author: Jonathan Druart Date: Wed Aug 10 13:35:13 2016 +0100 Bug 17250 - Koha::AuthorisedValues - Remove GetAuthValCode The subroutine C4::Koha::GetAuthValCode returned the authorised value category for a given kohafield. This can be acchieve easily using a new Koha::AuthorisedValues->search_by_koha_field method which will mimic search_by_marc_field. Test plan: Confirm that the description is correctly displayed on the following pages: - detail and moredetail of a bibliographic page (itemlost, damaged, materials) - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - Items search form - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed Note that GetKohaAuthorisedValuesMapping is going to be removed on bug 17251. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 1 - C4/Items.pm | 45 +++++----- C4/Koha.pm | 86 +++----------------- C4/Search.pm | 3 +- Koha/AuthorisedValues.pm | 28 ++++++- acqui/orderreceive.pl | 36 ++++---- catalogue/detail.pl | 17 ++-- catalogue/getitem-ajax.pl | 31 +++---- catalogue/itemsearch.pl | 13 +-- catalogue/moredetail.pl | 16 ++-- circ/circulation.pl | 12 ++- circ/returns.pl | 7 +- t/db_dependent/AuthorisedValues.t | 11 ++- t/db_dependent/Items/GetItemsForInventory.t | 3 +- .../Koha/GetKohaAuthorisedValuesMapping.t | 54 ------------ tools/inventory.pl | 8 +- 16 files changed, 140 insertions(+), 231 deletions(-) delete mode 100755 t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 18:14:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 16:14:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1094-ge155029 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e155029eea393931b56370b57ade8a7f07613ef5 (commit) via baf78b2a332aa5416f7cbf2020609aa753debda2 (commit) via cd7b84f6754ca264070afcac6fc8cb65ea0f930e (commit) from 8323db303dd6d1c486574e7750ad58df2c25c744 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e155029eea393931b56370b57ade8a7f07613ef5 Author: Jonathan Druart Date: Thu Oct 13 11:09:54 2016 +0100 Bug 17253: Fetch all the columns instead of only authorised_value Signed-off-by: Claire Gravely Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit baf78b2a332aa5416f7cbf2020609aa753debda2 Author: Jonathan Druart Date: Wed Aug 31 10:55:25 2016 +0100 Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with Koha::AuthorisedValues->search_by_koha_field Test plan: AV descriptions should be displayed on the following pages: - XSLT view - location and ccode - Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber - returns - location - opac-basket - ccode, location - The 3 reports: catalogue_stats.pl, issues_stats.pl and reserves_stats.pl - location, ccode Signed-off-by: Claire Gravely Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit cd7b84f6754ca264070afcac6fc8cb65ea0f930e Author: Jonathan Druart Date: Tue Aug 30 17:04:28 2016 +0100 Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED Signed-off-by: Claire Gravely Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 7 ++--- C4/Koha.pm | 50 ------------------------------ C4/Letters.pm | 6 ++-- C4/Search.pm | 3 +- C4/XSLT.pm | 7 +++-- Koha/AuthorisedValues.pm | 1 - Koha/Template/Plugin/AuthorisedValues.pm | 14 ++++----- acqui/orderreceive.pl | 2 +- admin/patron-attr-types.pl | 4 ++- basket/basket.pl | 5 +-- catalogue/detail.pl | 9 ++++-- catalogue/moredetail.pl | 6 ++-- circ/circulation.pl | 3 +- circ/returns.pl | 3 +- members/memberentry.pl | 4 ++- members/moremember.pl | 5 ++- opac/opac-basket.pl | 8 +++-- opac/opac-detail.pl | 11 +++++-- reports/borrowers_stats.pl | 6 ++-- reports/catalogue_stats.pl | 18 +++-------- reports/issues_stats.pl | 6 ++-- reports/reserves_stats.pl | 11 +++---- suggestion/suggestion.pl | 9 ++++-- svc/checkouts | 23 +++++++++++--- t/db_dependent/Koha.t | 9 +----- 25 files changed, 107 insertions(+), 123 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 18:16:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 16:16:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1097-g6fb9942 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6fb994257ecf74f65b0951564341561dd40df3a5 (commit) via 4579f1ad906b28a78c0ef7a1669b0a08138745d1 (commit) via a0af2d7d5ceb28848488c4f66e486f646341eedf (commit) from e155029eea393931b56370b57ade8a7f07613ef5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6fb994257ecf74f65b0951564341561dd40df3a5 Author: Tomas Cohen Arazi Date: Wed Sep 21 11:40:09 2016 -0300 Bug 17318: Allow chosing fixed normalization routines This patch changes the matching-rules.pl page, so it allows the user to choose from the different hardcoded normalization routines. It is done using TT blocks and the routine descriptions are translatable. To test: - Create some matching rule - Have free text values on the 'Normalization rule' field - Apply the patches - Create a new routine => SUCCESS: You can now only choose between fixed option - Save the rule - Open it for editing => SUCCESS: Chosen rules are preserved - Edit the original free-text including rule => SUCCESS: Rules fall back to 'None' - Sign off :-D TODO: A followup will add a warning about the current value and the fact that saving the matching rule will overwrite those, with 'none'. Sponsored-by: FIT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4579f1ad906b28a78c0ef7a1669b0a08138745d1 Author: Tomas Cohen Arazi Date: Mon Sep 19 12:25:31 2016 -0300 Bug 17318: Make C4::Matcher::_get_match_keys handle 'norms' param The current implementation doesn't care about that parameter, and applies a default normalization rule that seems counter-productive (in general) for its aleged purpose. This patch makes it handle the following values for 'norms': - upper_case - lower_case - remove_spaces - legacy_default - none They make it call the relevant Koha::Utils::Normalize routines. 'legacy_default' is used only for backwards compatibility, but could be removed if there's consensus. To test: - Run: $ prove t/Matcher.t => FAIL: most _get_match_keys tests fail - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: FIT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a0af2d7d5ceb28848488c4f66e486f646341eedf Author: Tomas Cohen Arazi Date: Mon Sep 19 12:17:41 2016 -0300 Bug 17318: Unit tests The current C4::Matcher::_get_match_keys implementation doesn't take normalization rules params into account. This patch makes Matcher.t test the proposed behaviour for new hardcoded values, that match string normalization routines introduced by Bu 17302. Possible values are: - upper_case - lower_case - remove_spaces - legacy_default - none * 'legacy_default' is left (for now) to catch the current behaviour. So tests which did not get a 'norm' param, now are passed 'legacy_default' and they still pass. * 'none' means no normalization, of course Note: on introducing 'none', a bug got highlighted, because the subfields traversal loop was introducing an unneeded space. The tests from 17304 get adjusted to reflect this. To test: - Run: $ sudo koha-shell kohadev ; cd kohaclone $ prove t/Matcher.t => FAIL: The routine doesn't care about the norms param. Sponsored-by: FIT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Matcher.pm | 75 +++++++++------ admin/matching-rules.pl | 10 +- .../prog/en/modules/admin/matching-rules.tt | 96 +++++++++++++++---- t/Matcher.t | 99 +++++++++++++++++--- 4 files changed, 218 insertions(+), 62 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 18:57:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 16:57:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1101-gb9af2e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b9af2e9731ef17af3d35090e5bae3af65a8d08c4 (commit) via c4a923bdf7eacce4de1efd4c5bdd2fe4010ad4b1 (commit) via 26c034d1f50762f0548ce3ee61767d64139cd311 (commit) via 20c44f005138d2f585eeb1336a93920629b52d3c (commit) from 6fb994257ecf74f65b0951564341561dd40df3a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b9af2e9731ef17af3d35090e5bae3af65a8d08c4 Author: Jonathan Druart Date: Tue Aug 9 10:17:18 2016 +0100 Bug 16907: Make sure the log will be written only if the patron has been deleted Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit c4a923bdf7eacce4de1efd4c5bdd2fe4010ad4b1 Author: Jonathan Druart Date: Mon Jul 11 21:35:15 2016 +0100 Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 26c034d1f50762f0548ce3ee61767d64139cd311 Author: Jonathan Druart Date: Mon Jul 11 21:18:56 2016 +0100 Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 20c44f005138d2f585eeb1336a93920629b52d3c Author: Jonathan Druart Date: Sat Jul 9 16:03:11 2016 +0100 Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. Signed-off-by: Tomas Cohen Arazi Tested the delete_patrons.pl script and cleanborrowers.pl too. Tests (are relevant and) pass and the qa scripts are happy too :-D Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 94 +------------------- Koha/Patron.pm | 62 +++++++++++++ members/deletemem.pl | 7 +- misc/cronjobs/delete_expired_opac_registrations.pl | 1 - misc/cronjobs/delete_patrons.pl | 43 +++------ .../delete_unverified_opac_registrations.pl | 1 - t/db_dependent/Auth_with_ldap.t | 4 +- t/db_dependent/Koha/Patrons.t | 48 +++++++++- t/db_dependent/Members.t | 33 +------ tools/cleanborrowers.pl | 7 +- 10 files changed, 136 insertions(+), 164 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:13:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:13:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1102-g947ab63 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 947ab63bb761cf2948d80ba590566114a2e48c32 (commit) from b9af2e9731ef17af3d35090e5bae3af65a8d08c4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 947ab63bb761cf2948d80ba590566114a2e48c32 Author: Josef Moravec Date: Tue Dec 15 12:07:38 2015 +0100 Bug 17444: Enable exporting by time, not only date Test plan: 1) Apply the patch 2) Edit a biblio 3) run export_records.pl with date time few minutes in the past for example: --format=xml --record-type=bibs --date="2016-10-14 10:00:05" --filename="koha.xml" 4) look in the file and cofirm that the right record was exported 5) Try the same but with time after the biblio was edited, it shouldn't be exported Signed-off-by: radiuscz Bug 17444: Follow-up, don't change the name of parameter "date" Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/export_records.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:15:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:15:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1105-g8ebffcd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8ebffcdb106d46c9f8b1877a086407ecfb1cbae1 (commit) via 038ad70fb31b787509c30c6499f3fab77356005a (commit) via 4cbbe58ad04f515a39e2cd5e5ed5d92e4388da49 (commit) from 947ab63bb761cf2948d80ba590566114a2e48c32 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ebffcdb106d46c9f8b1877a086407ecfb1cbae1 Author: Jonathan Druart Date: Fri Oct 14 14:26:58 2016 +0100 Bug 17445: Move the params check after the authentication check If the user is not authorised to call this route, we would prefer to raise a 403 instead of 400 Note that we wanted to submit tests for this change but the city code does not let use do that (we are allowed to list/show cities even without any permissions). The patrons.t is not complete enought and the holds.t tests do not pass... Tomas plans to submit tests but we reach the end of the hackfest ;) Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 038ad70fb31b787509c30c6499f3fab77356005a Author: Jonathan Druart Date: Fri Oct 14 14:23:20 2016 +0100 Bug 17445: Just some refactoring The idea is to make the code more readable moving the code to its own subroutine Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 4cbbe58ad04f515a39e2cd5e5ed5d92e4388da49 Author: Martin Renvoize Date: Fri Oct 14 08:57:30 2016 +0000 Bug 17445: Add 'malformed query' error response This patch adds to the x-mojo-around action code to give a meaningful error given a bad query parameter in the query string for a request. Test Plan 1) Submit an api request to an existing restful endpoint with no query parameters 2) Confirm the correct response is being given 3) Submit an api request to an existing restful endpoint with an allowed query parameter 4) Confimr the correct response is being given 5) Submit an api request to an existing restful endpoint with a malformed query paramter 6) Note the 400 response code and helpful json api body https://bugs.koha-community.org/show_bug.cgi?id=17445 Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1.pm | 42 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:29:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:29:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1109-g8b570a8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8b570a880803241a2a87a4f99b5098da681e5c7e (commit) via 42cd23ceb908fa23dc49dc228d1b54e5b50c3d15 (commit) via ed2c2213a72f56236a189deba48ca8fa96acb333 (commit) via 3a73010d094019a389165fecfdf511428302d765 (commit) from 8ebffcdb106d46c9f8b1877a086407ecfb1cbae1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8b570a880803241a2a87a4f99b5098da681e5c7e Author: Kyle M Hall Date: Fri Oct 21 17:28:42 2016 +0000 Bug 15131 - DBRev 16.06.00.035 Signed-off-by: Kyle M Hall commit 42cd23ceb908fa23dc49dc228d1b54e5b50c3d15 Author: Jonathan Druart Date: Wed Sep 28 13:37:05 2016 +0100 Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit ed2c2213a72f56236a189deba48ca8fa96acb333 Author: Tomas Cohen Arazi Date: Mon Jul 11 12:57:29 2016 -0300 Bug 15131: Make SCO use the new syspref. This patch just makes SCO use the new syspref (AllowItemsOnHoldCheckoutSCO) instead of the old one, thus making it configurable, separate from the non-SCO syspref. Sponsored-by: NEKLS Signed-off-by: George Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3a73010d094019a389165fecfdf511428302d765 Author: Tomas Cohen Arazi Date: Mon Jul 11 12:47:49 2016 -0300 Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref This patch introduces a new syspref AllowItemsOnHoldCheckoutSCO, so the current AllowItemsOnHoldCheckout syspref can be decoupled for the SCO module, giving the library more flexibility. During upgrade, it gets its value from the original AllowItemsOnHoldCheckout syspref. Sponsored-by: NEKLS Signed-off-by: George Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/UsageStats.pm | 1 + Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 +++++++++++ .../prog/en/modules/admin/preferences/circulation.pref | 6 ++++++ opac/sco/sco-main.pl | 7 +++---- t/db_dependent/UsageStats.t | 15 +++++++++++++-- 7 files changed, 36 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:32:53 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:32:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1113-g0c9a2ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0c9a2ee9da5618764067c3e896a3af5553bf7875 (commit) via b8df96082ec84097aac24e2128e6b8d1a34c463e (commit) via 3d110a3c72432249613bc38333d4c0260a4356c4 (commit) via c84f41624bb8eefa44872e15746cef5393466fb8 (commit) from 8b570a880803241a2a87a4f99b5098da681e5c7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c9a2ee9da5618764067c3e896a3af5553bf7875 Author: Jonathan Druart Date: Thu Oct 13 13:39:09 2016 +0100 Bug 16965: Allow Koha::Objects->result_class Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit b8df96082ec84097aac24e2128e6b8d1a34c463e Author: Marcel de Rooy Date: Thu Jul 28 14:28:43 2016 +0200 Bug 16965: [Follow-up] Adjust get_object_class In many cases it should be possible to derive the Koha::Objects class name from the DBIx result class name in a trivial manner. If not, the DBIx result class should have a class method called koha_objects_class providing that non-trivial name, such as Libraries for Branch. Note: We are only interested in the plural form here (Koha::Objects). Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 3d110a3c72432249613bc38333d4c0260a4356c4 Author: Jonathan Druart Date: Mon Jul 25 11:16:59 2016 +0100 Bug 16965: search_related returns an instanciated Koha::Objects-based object Koha::Objects->search_related should return a Koha::Objects-based object. This search_related method should follow the same rules as the search method, i.e. take into account what the caller want (scalar or list). The problem here is that we do not know (in Koha::Objects) what is the kind of objects we want to instanciate. To know it, this patch adds a get_object_class, it will return the class of the object and the resultset Koha::Object-based object. The drawback of this method is that we will have to keep it up-to-date every time we add a new Koha::Object class. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit c84f41624bb8eefa44872e15746cef5393466fb8 Author: Jonathan Druart Date: Fri Jul 22 17:20:08 2016 +0100 Bug 16965: Add Koha::Objects->search_related In order to search on relations, we need this new method. Test plan: Confirm that the changes in Objects.t make sense and that the tests pass. Tested all 3 patches together, followed test plan, result OK Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 46 ++++++++++++++++++++++++++++++++++++++-- Koha/Schema/Result/Borrower.pm | 4 ++++ Koha/Schema/Result/Branch.pm | 5 +++++ t/db_dependent/Koha/Objects.t | 20 ++++++++++++++++- 4 files changed, 72 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:35:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:35:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1119-gbb99c34 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bb99c34cb75ae7c2a90c0a7b4676058fcf681e6b (commit) via a8907872d13c30b405883ae15aeff896ca0049c4 (commit) via a09f1d75460b85abbf94a151a40cc1643bd4bcec (commit) via cbe96a3b70d88c9c2fd43c8b14dd7b6de1283a08 (commit) via 41a19f420d94427d6d69235732021e6f9ba78611 (commit) via 0d364dacf6db4b6c4442a264fff4d9de925ab6b2 (commit) from 0c9a2ee9da5618764067c3e896a3af5553bf7875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bb99c34cb75ae7c2a90c0a7b4676058fcf681e6b Author: Kyle M Hall Date: Fri Oct 21 17:34:16 2016 +0000 Bug 17080 [QA Followup] - Fix number of tests Signed-off-by: Kyle M Hall commit a8907872d13c30b405883ae15aeff896ca0049c4 Author: Jonathan Druart Date: Mon Aug 8 14:14:36 2016 +0100 Bug 17080: categories.checkprevcheckout - use the default value defined in the DBIx::Class schema This patch reverts bug 17069 Test plan: Create a new patron category prove t/db_dependent/Koha/Patron/Categories.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit a09f1d75460b85abbf94a151a40cc1643bd4bcec Author: Jonathan Druart Date: Mon Aug 8 14:13:10 2016 +0100 Bug 17080: borrowers.checkprevcheckout - use the default value defined in the DBIx::Class schema This line has been added by bug 16917 to define the default value of borrowers.checkprevcheckout. As this value is defined in the DBIx::Class schema, we should not have to handle it here. Test plan: Confirm that this patch does not reintroduced the bug fixed by bug 16917. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit cbe96a3b70d88c9c2fd43c8b14dd7b6de1283a08 Author: Jonathan Druart Date: Mon Aug 8 14:14:03 2016 +0100 Bug 17080: borrowers table - use default values defined in the DBIx::Class schema This patch basically just revert bug 16960 - Fix error on validating the registration This job is now done by the Koha::Object constructor, no need to clean the hash before sending it to AddMember. Test plan: Make sure there is no regression on bug 16960 (validate a self registration). Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 41a19f420d94427d6d69235732021e6f9ba78611 Author: Jonathan Druart Date: Mon Aug 8 14:12:09 2016 +0100 Bug 17080: Make C4::Members::AddMember uses Koha::Patron->store These calls have been added from commit e196f19 (Bug 12633: Remove SQLHelper in C4::Members) which added a TODO: "This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower." This is now done by this patch: instead of calling DBIx::Class directly we use Koha::Patron Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 0d364dacf6db4b6c4442a264fff4d9de925ab6b2 Author: Jonathan Druart Date: Mon Aug 8 14:13:40 2016 +0100 Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new Recently we face the same issue on different modules after we moved them to the Koha namespace using Koha::Object of using DBIx::Class directly. 1/ Koha::Patron::Modification on bug 16960 comment 14 and 15 2/ Koha::Patron::Category from bug 17069 3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917 If a DB column is defined as NOT NULL and has a default value, the DBIx::Class $rs->update_or_insert method won't use the default value if the column name has been passed to the constructor. We do that almost everywhere as we retrieve the data from the HTML forms without checking/cleaning them. There are several ways to fix that: 1/ Continue to fix them case by case (what we did for the recent issues) 2/ Try to fix them globally (existing ones and the next ones) This patch propose a global solution to avoid future issues of this kind. The idea is not to pass the undefined values which cannot be nullable to the DBIx::Class constructor. Tested all patches together. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 7 ++++--- Koha/Object.pm | 13 +++++++++++-- Koha/Patron/Category.pm | 7 ------- opac/opac-registration-verify.pl | 5 ----- t/db_dependent/Koha/Objects.t | 14 +++++++++++++- 5 files changed, 28 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:36:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:36:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1120-gff9937a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ff9937a137518feaa7bd7dfcb32d01965da58f91 (commit) from bb99c34cb75ae7c2a90c0a7b4676058fcf681e6b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff9937a137518feaa7bd7dfcb32d01965da58f91 Author: Josef Moravec Date: Mon Sep 26 12:37:29 2016 +0200 Bug 17341: Enhance the report action button on guided_reports.pl Test plan: 1) Apply the patch 2) Go to saved reports page 3) In the most right column of table you should see "Run" button with caret button, the first one should run the report, the second one should work asi menu trigger 4) Ensure that all report actions works as before Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../en/modules/reports/guided_reports_start.tt | 30 ++++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 19:38:52 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 17:38:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1123-g23c86c3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 23c86c3769407a2387011ac82ee97685f1841d48 (commit) via 60fc63ef4dd14fc6068ae5cfc202e5c200f0575b (commit) via 71e7804d2c5b7576a86cfe2234cff34020742d77 (commit) from ff9937a137518feaa7bd7dfcb32d01965da58f91 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 23c86c3769407a2387011ac82ee97685f1841d48 Author: Jonathan Druart Date: Thu Oct 13 14:17:13 2016 +0100 Bug 17425: Add the Object::MethodNotCoveredByTests exception Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 60fc63ef4dd14fc6068ae5cfc202e5c200f0575b Author: Tomas Cohen Arazi Date: Tue Oct 11 13:33:24 2016 +0200 Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 71e7804d2c5b7576a86cfe2234cff34020742d77 Author: Tomas Cohen Arazi Date: Tue Oct 11 11:52:12 2016 +0200 Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 +++++ Koha/Exceptions/Object.pm | 24 ++++++++++++++++++++++++ Koha/Object.pm | 9 ++++----- t/db_dependent/Koha/Objects.t | 32 ++++++++++++++++++++++++++++---- 4 files changed, 61 insertions(+), 9 deletions(-) create mode 100644 Koha/Exceptions/Object.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 20:16:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 18:16:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1124-ge99e05e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e99e05e8d75ba26ebb556746ea8dd4e38b85aa96 (commit) from 23c86c3769407a2387011ac82ee97685f1841d48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e99e05e8d75ba26ebb556746ea8dd4e38b85aa96 Author: Kyle M Hall Date: Fri Oct 21 18:15:50 2016 +0000 Bug 17425 [QA Followup] - Remove superfluous tests Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/Patron.t | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 21 20:33:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Oct 2016 18:33:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1152-g2578d8c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2578d8cd968fe00d5e413ce7911f7e14e77cf951 (commit) via d5dc05c0d0f3500ff385767e1242b8c1d96b5384 (commit) via d05c8e92f895919f8f7182b54f7c9b6b8d5d03df (commit) via c517689bb69a7356f71d9dc46ead313dec5bbce8 (commit) via 56fbbe237fe275c77a38112538bb9baf99d6bacf (commit) via 3130827fa6d9bc814c04209656fcf5aa910712de (commit) via 20c2ea7d3a6e24dd13cf3e6dd47108984852607d (commit) via 44524f6a9618baeabf8d1c2785230d1c87ec5484 (commit) via 2541ce4555f9c754343a767fff4b16258c13f5d3 (commit) via 8ef116a9221ff1365fab54e1eeeef8f31dd25f79 (commit) via 88f4b828f57b7ff1defe5017f62af71075994c74 (commit) via 89db872b41f3a73f643a3a06ae30faba5fae2e35 (commit) via 950ae065e0c0f3fd32c8d1767afbf09501e1b370 (commit) via 561812597e1b62bb0d78434907a7c396e6769ee8 (commit) via 424cb6ac8014cd17d876c988fec6e35c107ad601 (commit) via b44b160dc45028d8160768f964b7ae758431ac7a (commit) via 47fb829694a0d409552da2e0bef448ca427bf22d (commit) via 01ebef46e72a5760afb4a8cf939e61d63059bcac (commit) via 3376c54f332d37fff187c405f69773342500bdc5 (commit) via 01873ebd51a1b7920760a03a5fbe05b0808c5511 (commit) via 9929583a844ff611c9ce13c8c1d4ef4d0c470ed3 (commit) via bacb6b7a9fc8d94144610cd8d17d4e17bd047292 (commit) via 867444c15e897450ccd97287a6ae20d64b18577f (commit) via 01b9e646f518c4e4db29ae9e8a6eb1b51c29b8e0 (commit) via 656efcb5364ae09cfffb02a8ad4f13ff8f5d7db7 (commit) via cd8e6082c1ef195b94479f39d959601a4edfbf9c (commit) via afb81e6c0f1e3a81ed54f8b979553cb8c5068f26 (commit) via 7887cb0d9359df3570d10a4018371682f2214bb6 (commit) from e99e05e8d75ba26ebb556746ea8dd4e38b85aa96 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2578d8cd968fe00d5e413ce7911f7e14e77cf951 Author: Kyle M Hall Date: Fri Oct 21 17:44:59 2016 +0000 Bug 5670 - DBRev 16.06.00.036 Signed-off-by: Kyle M Hall commit d5dc05c0d0f3500ff385767e1242b8c1d96b5384 Author: Jonathan Druart Date: Mon Oct 17 15:14:39 2016 +0100 Bug 5670: Add a confirmation message on delete Signed-off-by: Kyle M Hall commit d05c8e92f895919f8f7182b54f7c9b6b8d5d03df Author: Jonathan Druart Date: Mon Oct 17 14:58:09 2016 +0100 Bug 5670: Use the fa icon for the save button Signed-off-by: Kyle M Hall commit c517689bb69a7356f71d9dc46ead313dec5bbce8 Author: Jonathan Druart Date: Mon Oct 17 14:49:48 2016 +0100 Bug 5670: Use Koha.Preference to retrieve syspref from templates Signed-off-by: Kyle M Hall commit 56fbbe237fe275c77a38112538bb9baf99d6bacf Author: Jonathan Druart Date: Mon Oct 17 14:47:30 2016 +0100 Bug 5670: Does not return 0 in Koha::Patron->housebound_* methods Signed-off-by: Kyle M Hall commit 3130827fa6d9bc814c04209656fcf5aa910712de Author: Jonathan Druart Date: Mon Oct 17 14:47:02 2016 +0100 Bug 5670: Update constraint name to match with the one in updatedatabase Signed-off-by: Kyle M Hall commit 20c2ea7d3a6e24dd13cf3e6dd47108984852607d Author: Alex Sassmannshausen Date: Thu Oct 13 12:37:50 2016 +0200 Bug 5670: [Followup] Add 'step 4' edit button. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Place housebound role form inside the 'step 4' section. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add 'step 4' edit button for housebound role. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 44524f6a9618baeabf8d1c2785230d1c87ec5484 Author: Alex Sassmannshausen Date: Thu Oct 13 11:57:06 2016 +0200 Bug 5670: Add auth_val_cat to auth_val_cat.sql. * installer/data/mysql/atomicupdate/housebound_tables.sql: Insert HSBND_FREQ in authorised value categories. * installer/data/mysql/mandatory/auth_val_cat.sql: Add HSBND_FREQ. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 2541ce4555f9c754343a767fff4b16258c13f5d3 Author: Alex Sassmannshausen Date: Thu Oct 13 10:05:46 2016 +0200 DO NOT PUSH: Moar Housebound Schema files. * Koha/Schema/Result/Borrower.pm: New method. * Koha/Schema/Result/HouseboundRole.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=5670 Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 8ef116a9221ff1365fab54e1eeeef8f31dd25f79 Author: Alex Sassmannshausen Date: Wed Oct 12 17:26:02 2016 +0200 Bug 5670: [QA Followup] HouseboundRole CRUD from UI. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Add HouseboundRole form. * members/memberentry.pl: Handle HouseboundRole CRUD. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 88f4b828f57b7ff1defe5017f62af71075994c74 Author: Alex Sassmannshausen Date: Wed Oct 12 14:30:36 2016 +0200 Bug 5670: [QA Followup] Display HouseboundRole info. * Koha/Patron.pm (housebound_role): New method. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add section for HouseboundRole information * members/moremember.pl: Pass HouseboundRole info to template. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 89db872b41f3a73f643a3a06ae30faba5fae2e35 Author: Alex Sassmannshausen Date: Mon Oct 10 15:38:04 2016 +0200 Bug 5670: [QA Followup] Correct housebound role search. * Koha/Patrons.pm (search_housebound_choosers) (search_housebound_deliverers): Use new table. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 950ae065e0c0f3fd32c8d1767afbf09501e1b370 Author: Alex Sassmannshausen Date: Mon Oct 10 15:31:19 2016 +0200 Bug 5670: [QA Followup] Create HouseboundRole objects. * Koha/Patron/HouseboundRole.pm: New file. * Koha/Patron/HouseboundRoles.pm: New file. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 561812597e1b62bb0d78434907a7c396e6769ee8 Author: Alex Sassmannshausen Date: Mon Oct 10 12:37:50 2016 +0200 Bug 5670: [QA Followup] Create housebound roles table. * installer/data/mysql/atomicupdate/housebound_tables.sql (housebound_role): New table. * installer/data/mysql/kohastructure.sql (housebound_role): New table. * installer/data/mysql/en/mandatory/auth_values.sql: Remove HSBND_ROLE entries. * installer/data/mysql/en/mandatory/patron_attributes.sql: Remove HSBND_ROLE entry. * installer/data/mysql/en/mandatory/patron_attributes.txt: Remove explanatory text. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 424cb6ac8014cd17d876c988fec6e35c107ad601 Author: Alex Sassmannshausen Date: Wed Sep 28 16:54:53 2016 +0200 Bug 5670: [QA Followup] More "required" messages. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Mark houseboundvisit fields as required. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit b44b160dc45028d8160768f964b7ae758431ac7a Author: Alex Sassmannshausen Date: Wed Sep 28 16:33:47 2016 +0200 Bug 5670: [QA Followup] Improve template style. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove toggler class from form, improve look and layout of action buttons. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 47fb829694a0d409552da2e0bef448ca427bf22d Author: Jonathan Druart Date: Wed Sep 28 10:21:44 2016 +0100 Bug 5670: remove useless call to ->new when ->search is enought Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 01ebef46e72a5760afb4a8cf939e61d63059bcac Author: Jonathan Druart Date: Wed Sep 28 10:17:46 2016 +0100 Bug 5670: mv housebound_* to search_housebound_* I think it's better to prefix the subroutine names used to search with 'search_'. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 3376c54f332d37fff187c405f69773342500bdc5 Author: Jonathan Druart Date: Wed Sep 28 10:17:24 2016 +0100 Bug 5670: Add the 'required' class to required fields Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 01873ebd51a1b7920760a03a5fbe05b0808c5511 Author: Alex Sassmannshausen Date: Wed Sep 21 17:17:25 2016 +0200 Bug 5670: [QA Followup] Fix `div.patroninfo`. * members/housebound.pl: Provide full patron hash keys, extended patron attributes & picture to template. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Refactor to use new information. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 9929583a844ff611c9ce13c8c1d4ef4d0c470ed3 Author: Alex Sassmannshausen Date: Mon Sep 19 15:21:19 2016 +0200 Bug 5670: [QA Followup] Small QA fixes. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove `console.log` invocations. * members/housebound.pl ($houseboundvisits, $chooser, $deliverer): Remove unused variables. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit bacb6b7a9fc8d94144610cd8d17d4e17bd047292 Author: Alex Sassmannshausen Date: Mon Sep 19 14:18:27 2016 +0200 Bug 5670: [QA Followup] Housebound link from patron edit. * koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link to the housebound module view if it is switched on. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 867444c15e897450ccd97287a6ae20d64b18577f Author: Alex Sassmannshausen Date: Mon Sep 19 13:40:46 2016 +0200 Bug 5670: [QA Followup] Avoid CGI::param in list context. * members/housebound.pl: Force `borrowernumber` to scalar context. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 01b9e646f518c4e4db29ae9e8a6eb1b51c29b8e0 Author: Alex Sassmannshausen Date: Mon Sep 19 13:12:21 2016 +0200 Bug 5670: [QA Followup] Don't force ISO dates. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use ".datepicker" class for date input, use `$KohaDates` to filter our iso dates. * members/housebound.pl: Use DateTime and Koha::DateUtils to parse incoming date to ISO format. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 656efcb5364ae09cfffb02a8ad4f13ff8f5d7db7 Author: Alex Sassmannshausen Date: Thu Sep 8 12:39:24 2016 +0200 Bug 5670: [Followup] Refactor .pl; error messages. * members/housebound.pl: Refactor & store messages for encountered errors. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show messages. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit cd8e6082c1ef195b94479f39d959601a4edfbf9c Author: Alex Sassmannshausen Date: Thu Sep 8 12:10:45 2016 +0200 Bug 5670: [Followup] Return Koha::Patron objects. * Koha/Patron/HouseboundVisit.pm (chooser, deliverer): Use `_new_from_dbic` to return Koha::Patron objects. * t/db_dependent/Patron/HouseboundVisits.t: Remove TODO section for this. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit afb81e6c0f1e3a81ed54f8b979553cb8c5068f26 Author: A. Sassmannshausen Date: Fri Apr 4 09:55:07 2014 +0000 Bug 5670: Housebound Readers Module New module to handle management of circulation to Housebound readers. - Ability to create housebound profiles & scheduled visits for patrons. - Ability to record users as Deliverers or Choosers (or both), using extended patron attributes. - Ability to link choosers and deliverers to individual delivery runs. - 'Delivery Frequencies' are customizable through authorised values ('HSBND_FREQ'). * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add Housebound menu if appropriate. * Koha/Patron.pm (housebound_profile): New method. * Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New methods. * Koha/Patron/HouseboundProfile.pm: New File. * Koha/Patron/HouseboundProfiles.pm: New File. * Koha/Patron/HouseboundVisits.pm: New File. * Koha/Patron/HouseboundVisit.pm: New File. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file. * members/housebound.pl: New file. * installer/data/mysql/kohastructure.sql: Add housebound_* tables. * installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add HouseboundModule syspref. * installer/data/mysql/atomicupdate/housebound_tables.sql: New file. * t/db_dependent/Patron/Borrower_Housebound.t: New file. * t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file. * t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file. Test plan: - Apply patch. - Run atomic update script. - Run Unit Tests (t/db_dependent/Patron/Housebound*) - Optionally, add additional authorised values to 'HSBND_FREQ'. - Switch on 'HouseboundModule' syspref. - Ensure 'ExtendedPatronAttributes syspref is on. - On patron pages, when editing, add some to the Housebound deliverer and chooser groups. - On a patron page, the Housebound menu should now be present. - create housebound profile + ensure Frequency values seem pulled from 'HSBND_FREQ'. - create 'housebound visits' (deliveries) + ensure chooser/deliverer lists are populated with patrons that have the Chooser or Deliverer Attribute type. - edit visits. - delete visits. - Switch off 'HouseboundModule' - the Housebound menu should disappear Signed-off-by: Chris Cormack Signed-off-by: Claire Gravely Bug 5670: [Followup] Rename test files. * t/db_dependent/Patron/Borrower_Housebound.t: Rename to t/db_dependent/Patron/Housebound.t. * t/db_dependent/Patron/Borrower_HouseboundProfiles.t: Rename to t/db_dependent/Patron/HouseboundProfiles.t. * t/db_dependent/Patron/Borrower_HouseboundVisits.t: Rename to t/db_dependent/Patron/HouseboundVisits.t. Signed-off-by: Claire Gravely Bug 5670: [QA Followup] Fix category_type ref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace references to `category_type` with `categorycode`. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall commit 7887cb0d9359df3570d10a4018371682f2214bb6 Author: Alex Sassmannshausen Date: Fri May 27 12:08:23 2016 +0000 DO NOT PUSH: Add Housebound Schema files. * Koha/Schema/Result/HouseboundProfile.pm: New file. * Koha/Schema/Result/HouseboundVisit.pm: New file. https://bugs.koha-community.org/show_bug.cgi?id=5670 Signed-off-by: Claire Gravely ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Patron.pm | 30 ++ .../Provider.pm => Patron/HouseboundProfile.pm} | 41 +- Koha/{Biblios.pm => Patron/HouseboundProfiles.pm} | 35 +- Koha/{NewsItem.pm => Patron/HouseboundRole.pm} | 26 +- .../Histories.pm => Patron/HouseboundRoles.pm} | 33 +- Koha/{Review.pm => Patron/HouseboundVisit.pm} | 48 ++- Koha/Patron/HouseboundVisits.pm | 102 +++++ Koha/Patrons.pm | 30 ++ Koha/Schema/Result/Borrower.pm | 64 ++- Koha/Schema/Result/HouseboundProfile.pm | 138 ++++++ Koha/Schema/Result/HouseboundRole.pm | 90 ++++ Koha/Schema/Result/HouseboundVisit.pm | 154 +++++++ installer/data/mysql/en/mandatory/auth_values.sql | 1 + .../data/mysql/en/mandatory/patron_attributes.sql | 0 .../data/mysql/en/mandatory/patron_attributes.txt | 0 installer/data/mysql/kohastructure.sql | 64 +++ installer/data/mysql/mandatory/auth_val_cat.sql | 5 + installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 73 ++++ .../intranet-tmpl/prog/en/includes/circ-menu.inc | 3 + .../prog/en/includes/members-menu.inc | 3 + .../en/modules/admin/preferences/circulation.pref | 7 + .../prog/en/modules/members/housebound.tt | 438 ++++++++++++++++++++ .../prog/en/modules/members/memberentrygen.tt | 52 ++- .../prog/en/modules/members/moremember.tt | 28 ++ members/housebound.pl | 193 +++++++++ members/memberentry.pl | 59 ++- members/moremember.pl | 1 + t/db_dependent/Patron/Housebound.t | 39 ++ t/db_dependent/Patron/HouseboundProfiles.t | 75 ++++ t/db_dependent/Patron/HouseboundRoles.t | 88 ++++ t/db_dependent/Patron/HouseboundVisits.t | 89 ++++ 33 files changed, 1922 insertions(+), 90 deletions(-) copy Koha/{SMS/Provider.pm => Patron/HouseboundProfile.pm} (54%) copy Koha/{Biblios.pm => Patron/HouseboundProfiles.pm} (65%) copy Koha/{NewsItem.pm => Patron/HouseboundRole.pm} (70%) copy Koha/{Subscription/Histories.pm => Patron/HouseboundRoles.pm} (68%) copy Koha/{Review.pm => Patron/HouseboundVisit.pm} (51%) create mode 100644 Koha/Patron/HouseboundVisits.pm create mode 100644 Koha/Schema/Result/HouseboundProfile.pm create mode 100644 Koha/Schema/Result/HouseboundRole.pm create mode 100644 Koha/Schema/Result/HouseboundVisit.pm copy koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc => installer/data/mysql/en/mandatory/patron_attributes.sql (100%) copy koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc => installer/data/mysql/en/mandatory/patron_attributes.txt (100%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt create mode 100755 members/housebound.pl create mode 100755 t/db_dependent/Patron/Housebound.t create mode 100644 t/db_dependent/Patron/HouseboundProfiles.t create mode 100644 t/db_dependent/Patron/HouseboundRoles.t create mode 100644 t/db_dependent/Patron/HouseboundVisits.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Oct 22 02:46:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Oct 2016 00:46:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1153-g99de777 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 99de777c5090bdf5e4d9b91cb774e9baf8ab20cd (commit) from 2578d8cd968fe00d5e413ce7911f7e14e77cf951 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 99de777c5090bdf5e4d9b91cb774e9baf8ab20cd Author: Nick Clemens Date: Wed Oct 19 10:09:56 2016 +0000 Bug 14752 - Followup to fix error if barcode fields undefined Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/addorder.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Oct 22 15:22:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Oct 2016 13:22:44 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.04-94-gff043fb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via ff043fb6675d48506db8d50dd65f4d98cbdff91a (commit) via f4b6b70f70b65bdcd948f6880f779b66c02a1ded (commit) via a8dbb0cae8c5ca7e36ef9a2a3f2dc6b4474e64bd (commit) via 14d5f19b9ee100c81b33414ffd58eac668c08823 (commit) via 5c324d8201fff6e3a727c95e182ad32b78ccf715 (commit) via f3889059133d5e9933325c98e172d4d0b1e69c11 (commit) via 41e12f0af2149c2b858dc63fd6242854f2da444d (commit) via 6b02b7404dbaf4a9c266cdc6a23ddba829ffdf81 (commit) via 14b662558019a4b3c1ff3923a8455f43fc878233 (commit) via c65810e9e24ac0d2d6b7a66a5de6ff849efcbbe8 (commit) via 106c66eee67be65246ee50ea59a4c0f27acf7e7e (commit) via 8659bad629fcdfb5bb612ad21ce0bcb0f70a74bd (commit) via e25934f6cdb1eaae0fbc9be15afe55a3ee2ad51a (commit) via 90e9ab941eb47b0be4f859c45d394575324b5fc7 (commit) via afd505b5e9ab8f6ffe82e7edecab6924dbd2e511 (commit) via a0c7f81f0ce58d5c532c0b7b2fc575f19e711535 (commit) via 6490df198c18fc99ee289f0b9abe1e05936d80d2 (commit) via 2a62a9a18cc3a36288e6abf3586a7e606e6e07db (commit) via f620fbe0d9ec8c4df258dd3a35b839b466479d52 (commit) via 537d7d9fa4650aa35b8e20cbaf0cad7f7a4d2ba4 (commit) via 87d7fafaef82408ee296c5b7f5ca880048807b07 (commit) via 28eb0a880e2bf249da464f7da75ad409f9ffc919 (commit) via 18a472e627e8f8b7cec45ffe90f896374d90fb9d (commit) via 4ee9399028fda3f5b8cfbfd9c43eb50349569e91 (commit) via ff2b5116e9edb5ce62212a8f25518bc1647b19b9 (commit) via a61c072f1acb77906843a5be319412f959374bda (commit) via 4592382e388d7f0ee0467180b50b5630a19c674a (commit) via 5cf95dc6db4356dd5fbb1d9c46c50652d508a19b (commit) via 80de7080ef5f3694378c4a909b96ee62866d0b41 (commit) via 7e6365b5323d60adc949f18fe2efa7ac3d67937e (commit) via a7741759aa501c8545b6acd97c0a2d851a148c12 (commit) via 5dced305bbaa54a831bd830f900fc9d29bf3e13d (commit) via 30e66a5eadbdda679bc71d11415ca31958256b24 (commit) via 78ce2bcb9f2217d5142a3257ff02ca647dd0ecac (commit) via aa231539854fe9aa0ef75daca342c8cced0b8150 (commit) via 3a53760cd1ab7d85b3bfcdfa742cab032a7e545d (commit) via 78a58175a5f60c3293e0bdbffe3364a6c06844a9 (commit) via 0e953489908f8fb44bd6173620050054e0a66e71 (commit) via 2f70fde91a53b5a8e05c99fa51c77ba263e9d38c (commit) via fc0d4ca25d967ce443b4aa13039d4154b47125ef (commit) via 8ff0d2fe586a774af234f4f65670fb3dd720bd8f (commit) via 1c35b86c2e7b7dd00bf677f51d8a141e3c281072 (commit) via 40a2b8c12150d6fe193ba10c808b47069494157a (commit) via 051661024ca92a343ad74e2664627c070bb5c66e (commit) via cb1ee8e3ccbc8bbce47b9db502a90c09e2a6ec3f (commit) via f3917fc8cb8c49bc85e7d371043cae8bd276063d (commit) via 11074092311b11b1553eb1fe7cfe169b4a8b6f57 (commit) via fc42eeba6a66c02459332e257fdb1364fb257270 (commit) via 3c2bd4ef3b1cc45d955940c1323c2b2c9b05cc4a (commit) via 26efec07d7344ecf3c29981e735246dec6416bd1 (commit) via d62b515ef7ead3c77f6776438df11980f6b2028d (commit) via 6c28248d8f1b8f8413ba2a29fafb0f7f825b8358 (commit) via 517e4eb553e31dad4d7d49a6c2b2222884423d75 (commit) via 60ab0769530c190dcd849f15909eed4961aa8a83 (commit) via 1de610bb63f70b9f4a1e3a8a5683de5d3bb7bb12 (commit) via 4f5d1faef59d57d33a1e6ce1c7ed28792e00ee43 (commit) via ee073f00860c90d4a96abc8bc4677aa020a53669 (commit) via 4b80a676df11ddfd475caac75e1fa674e6c0b203 (commit) via a121ecbfa1ede24329556eaf51ecce6d4523d753 (commit) via 20bcc8770ad31629b4ef060b6e6a687932579f43 (commit) via 6f75e5cc5b87c6a7ba42cea7752adec9bb3952ce (commit) via 6087cfde3fb98901bf6d3f7d6d98d48eee25149a (commit) via a133becbfc738dcd327a6422b50e39d95ce1028c (commit) via 9cfee957dbdba479c96dfdce80095b91a628757b (commit) via b089121aeb06a722657842a433832330a32098ae (commit) from 0fc92ab72d1bab7e84df9fc78e3cbd3f2abb3d97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff043fb6675d48506db8d50dd65f4d98cbdff91a Author: Josef Moravec Date: Tue Dec 15 12:07:38 2015 +0100 Bug 17444: Enable exporting by time, not only date Test plan: 1) Apply the patch 2) Edit a biblio 3) run export_records.pl with date time few minutes in the past for example: --format=xml --record-type=bibs --date="2016-10-14 10:00:05" --filename="koha.xml" 4) look in the file and cofirm that the right record was exported 5) Try the same but with time after the biblio was edited, it shouldn't be exported Signed-off-by: radiuscz Bug 17444: Follow-up, don't change the name of parameter "date" Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 947ab63bb761cf2948d80ba590566114a2e48c32) Signed-off-by: Fr?d?ric Demians commit f4b6b70f70b65bdcd948f6880f779b66c02a1ded Author: Nick Clemens Date: Fri Oct 14 08:52:54 2016 +0000 Bug 17154 (QA followup) replace tabs with spaces Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 1e17c92905143f6bc8cac38f00256541c7146fa3) Signed-off-by: Fr?d?ric Demians commit a8dbb0cae8c5ca7e36ef9a2a3f2dc6b4474e64bd Author: Sophie Meynieux Date: Mon Aug 22 12:02:11 2016 +0200 Bug 17154 : Note column is missing on account lines receipt When displaying Fines > Account tab for a patron, you can see on screen a Note column that is missing if you click on Print Test plan : * Find a patron with accountlines or add them manually (Create manual invoice/credit). * Be sure some of them got a Note * Clik on Print fior those lines Without patch, the printed receipt does not show the Note column with the patch, the printed receipt shows a Note column and Note content is correctly printed for accountline with a note. Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 734d08c2af16909f96b19003c4cc1d758b74f11d) Signed-off-by: Fr?d?ric Demians commit 14d5f19b9ee100c81b33414ffd58eac668c08823 Author: Marc Date: Wed Oct 5 16:08:52 2016 +0200 Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 9a81a138d45b245b69754f3e61115d5d997510c0) Signed-off-by: Fr?d?ric Demians commit 5c324d8201fff6e3a727c95e182ad32b78ccf715 Author: Jonathan Druart Date: Tue Oct 18 17:14:58 2016 +0100 Bug 17411: Remove 3 other occurrences of exit 1 Signed-off-by: Kyle M Hall (cherry picked from commit f1a8ca13028411384847615fbdeeaaedd9703382) Signed-off-by: Fr?d?ric Demians commit f3889059133d5e9933325c98e172d4d0b1e69c11 Author: Marc Date: Thu Oct 6 14:37:14 2016 +0200 Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 Signed-off-by: David Cook Signed-off-by: Jonathan Druart Amended patch: Remove unecessary comment Signed-off-by: Kyle M Hall (cherry picked from commit 01636dca2f1bd132fcc8d16f7a91fa4a45a90668) Signed-off-by: Fr?d?ric Demians commit 41e12f0af2149c2b858dc63fd6242854f2da444d Author: Marc V?ron Date: Tue Jun 7 17:29:22 2016 +0200 Bug 16687 - Translatability: Fix issues in Administration preferences This patch fixes sentence splitting and other translation issues in file koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref to avoid odd translations. To test: - Without patch, open Home > Administration > System preferences and go to tab 'Administration" - Apply patch - Open the same page in a new window and compare the text: - Verify that no sentences are splitted - Verify that the text changes do not introduce misunderstandings and have the same meaning as without patch Amended for comment #7 2016-07-12/mv Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Rebased to apply on master and re-inserted test (see comment #14) -2016-09-28/mv Signed-off-by: Michael Kuhn Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit a5b64708601f58fddf89d328d7f0ed94cfc214f9) Signed-off-by: Fr?d?ric Demians commit 6b02b7404dbaf4a9c266cdc6a23ddba829ffdf81 Author: Marcel de Rooy Date: Fri Oct 14 10:01:12 2016 +0200 Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Position 7 of the leader is better referred to as biblevel. (Pos 6 is record type.) At the same time replacing some regex's by simple eq's. Signed-off-by: Marcel de Rooy It seems that bib level in the UNIMARC leader only allows a subset of the possible combinations for MARC21. This does not have bad side-effects however in the new code that tests bib level to determine the type tag. Signed-off-by: Kyle M Hall (cherry picked from commit 556a4870d6beced7df52dbbc2ad472769e79e148) Signed-off-by: Fr?d?ric Demians commit 14b662558019a4b3c1ff3923a8455f43fc878233 Author: Hector Castro Date: Wed Sep 28 15:29:37 2016 -0600 Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit a74329af022eeb857e1f936c13274c0e41497472) Signed-off-by: Fr?d?ric Demians commit c65810e9e24ac0d2d6b7a66a5de6ff849efcbbe8 Author: Jonathan Druart Date: Wed Sep 28 14:45:21 2016 +0100 Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 6f5ea70f9a20ee0f30057d91a4a23e7f3c04b77e) commit 106c66eee67be65246ee50ea59a4c0f27acf7e7e Author: Jonathan Druart Date: Tue Oct 11 13:15:27 2016 +0100 Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Signed-off-by: Marc Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6) Signed-off-by: Fr?d?ric Demians commit 8659bad629fcdfb5bb612ad21ce0bcb0f70a74bd Author: Rodrigo Santellan Date: Mon Oct 10 04:20:12 2016 -0400 Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Fr?d?ric Demians Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel Fix the issue, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f060709df0ed07c0ff3dbc20404fa5b3b2aa8651) Signed-off-by: Fr?d?ric Demians commit e25934f6cdb1eaae0fbc9be15afe55a3ee2ad51a Author: Jonathan Druart Date: Tue Oct 4 08:29:30 2016 +0100 Bug 17393: Fix non-Latin chars handling in self reg If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x Test plan: 0/ Do not apply the patch 1/ Set up the Self reg feature 2/ fill surname, fistname with something like "Micha? pou???" 3/ Save 4/ See the bad encoding/replacement on the screen and look at the data The accentued chars are replaced with their html representation and the non-Latin chars with a 'x' in the DB 5/ Apply this patch 6/ Repeat steps 2, 3 7/ Everything should be ok 8/ Try to make sure this HTML::Entities escape was not useful: fill surname with "surname " Save and look at the data Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 35de8aa1ef07b04cfc7c977f7168cd36b40d7941) Signed-off-by: Fr?d?ric Demians commit 90e9ab941eb47b0be4f859c45d394575324b5fc7 Author: Hector Castro Date: Thu Oct 20 08:57:46 2016 -0600 Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall (cherry picked from commit fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6) Signed-off-by: Fr?d?ric Demians commit afd505b5e9ab8f6ffe82e7edecab6924dbd2e511 Author: Tomas Cohen Arazi Date: Tue Oct 18 12:02:25 2016 -0300 Bug 10337: (followup) Upper case MARC flavour This patch makes the populate_db.pl script upper case what gets passed with the --marcflavour option switch. This is needed in order for this to fit ``kohadevbox`` configuration files, and it is harmless for other uses. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall (cherry picked from commit 31cb200e0d97106f6e2a009b4cbbd0a295bbaaf5) Signed-off-by: Fr?d?ric Demians commit a0c7f81f0ce58d5c532c0b7b2fc575f19e711535 Author: Tomas Cohen Arazi Date: Tue Oct 18 09:47:26 2016 -0300 Bug 10337: (QA followup) Allow choosing MARC flavour This patch enables the --marcflavour option switch so the user can specify the desired marc flavour. The code for handling it was already in place, just not used. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall (cherry picked from commit fab0bc976470ca99646b06b7810954b4e2fd18f1) Signed-off-by: Fr?d?ric Demians commit 6490df198c18fc99ee289f0b9abe1e05936d80d2 Author: Jonathan Druart Date: Mon Oct 17 17:50:50 2016 +0100 Bug 10337: Add a script to populate devs' DBs with sample data Executing the installer process and inserting all the sample data take a lot of clics and time. The idea of this script is to provide a quick way to insert all the sample data easily to get a working Koha install asap. Test plan: - Set your database config to a non-existent DB - Execute perl misc/devel/populate_db.pl You will get an error - Create an empty DB - Execute perl misc/devel/populate_db.pl It will insert all the MARC21 sample data - Execute perl misc/devel/populate_db.pl You will get an error because the DB is not empty (systempreferences and borrowers tables) Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall (cherry picked from commit 3635e8f82660ced571af592088a369db698101a3) commit 2a62a9a18cc3a36288e6abf3586a7e606e6e07db Author: Fridolin Somers Date: Wed Sep 28 14:49:32 2016 +0200 Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit f1298dc7828757fe9277a5128910335d2d6c0f2c) Signed-off-by: Fr?d?ric Demians commit f620fbe0d9ec8c4df258dd3a35b839b466479d52 Author: Fridolin Somers Date: Tue Oct 11 10:00:56 2016 +0200 Bug 17423 - patronimage.pl permission is too restrictive Bug 14566 added the permission "borrowers" on patronimage.pl. This perm is too restrictive because circulation pages also uses this page. I propose to simply use "catalogue" perm. Test plan - Set an image to borrower xx - Create a user with only catalogue permission - Log with this user - Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx => Without patch you get the page saying you do not have the permission => With patch you get the image - Log out and retest the page patronimage.pl => You get 403 error Signed-off-by: remy Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e78f81d615a79ad293d599c7395efcabd267662d) Signed-off-by: Fr?d?ric Demians commit 537d7d9fa4650aa35b8e20cbaf0cad7f7a4d2ba4 Author: Jonathan Druart Date: Tue Sep 13 15:03:55 2016 +0100 Bug 16358: Do not redirect to the editor when deleting records The "Delete record" button goes to addbiblio.pl?op=delete, which incorrectly redirects to Rancor when selected. Test plan: 0/ Enable EnableAdvancedCatalogingEditor 1/ Edit a record 2/ Switch to the Advanced editor 3/ click on "View the record" 4/ Delete the record => Without this patch you are redirected to the editor => With this patch you are redirected to the advanced search Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher (cherry picked from commit ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8) Signed-off-by: Fr?d?ric Demians commit 87d7fafaef82408ee296c5b7f5ca880048807b07 Author: Tomas Cohen Arazi Date: Wed Oct 12 11:01:54 2016 +0200 Bug 17430: Make MarkIssueReturned.t create its own data This patch makes MarkIssueReturned.t use t::lib::TestBuilder to create the data it needs. To test: - On master, have a category with categorycode = C - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => FAIL: primary key problems make the tests fail - Apply the patch - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests are green! - Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit d5ca2d0433b75317c5a2b855ee77372ca93d2223) Signed-off-by: Fr?d?ric Demians commit 28eb0a880e2bf249da464f7da75ad409f9ffc919 Author: Marcel de Rooy Date: Fri Oct 14 11:29:44 2016 +0200 Bug 17446: Typo seleted Built on top of bug 17441 Test plan: Just have a look at the changes. Trivial. Git grep seleted. No results. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit f75afef59175933f7e93b04bdcbdcf5180b0b024) Signed-off-by: Fr?d?ric Demians commit 18a472e627e8f8b7cec45ffe90f896374d90fb9d Author: Marcel de Rooy Date: Fri Oct 14 11:07:49 2016 +0200 Bug 17441: [QA Follow-up] Return value of SendAlerts This patch makes the return value of SendAlerts more consistent. It returns 1 on success, or undef || { error => 'msg' } on failure. Needed to adjust one test in Letters.t too. Adjusted one typo along the way (seleted). Signed-off-by: Marcel de Rooy Tested by running Letters.t. Also tested SendAlerts from the interface with AutoEmailOpacUser and memberentry (adding new patron). Signed-off-by: Brendan Gallagher (cherry picked from commit 17e2e6c994655aaa927b2579524022a4f24a8d1d) Signed-off-by: Fr?d?ric Demians commit 4ee9399028fda3f5b8cfbfd9c43eb50349569e91 Author: Katrin Fischer Date: Thu Oct 13 19:05:48 2016 +0200 Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy To improve consistency, adding a follow-up. Signed-off-by: Brendan Gallagher (cherry picked from commit ff495c5fa8c58a7762b3494e97d90618d649f7a8) commit ff2b5116e9edb5ce62212a8f25518bc1647b19b9 Author: Marc Date: Fri Oct 7 11:03:45 2016 +0200 Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit 692014c817b58876042ab03d71bde0c2cce7e571) Signed-off-by: Fr?d?ric Demians commit a61c072f1acb77906843a5be319412f959374bda Author: Jonathan Druart Date: Thu Sep 29 08:46:49 2016 +0100 Bug 17365: Fix XSS in moremember.pl and memberentry.pl There are certainly hundred of places where they are not escaped... Test plan: Create a patron with "Arun " in some of the fields. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d) Signed-off-by: Fr?d?ric Demians commit 4592382e388d7f0ee0467180b50b5630a19c674a Author: Jonathan Druart Date: Mon Oct 3 15:23:39 2016 +0100 Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro Warnings avoided Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874) Signed-off-by: Fr?d?ric Demians commit 5cf95dc6db4356dd5fbb1d9c46c50652d508a19b Author: Jonathan Druart Date: Mon Oct 3 15:15:40 2016 +0100 Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a1eeffd8385e5b95ca1d06a8300e5bd42403486a) Signed-off-by: Fr?d?ric Demians commit 80de7080ef5f3694378c4a909b96ee62866d0b41 Author: Nick Clemens Date: Wed Oct 5 13:26:09 2016 +0000 Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actual overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified by reading code - couldn't verify using Overdrive. Signed-off-by: Brendan Gallagher (cherry picked from commit f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3) Signed-off-by: Fr?d?ric Demians commit 7e6365b5323d60adc949f18fe2efa7ac3d67937e Author: Kyle M Hall Date: Thu Feb 4 19:41:57 2016 +0000 Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass Signed-off-by: Barton Chittenden barton at bywatersolutions.com Signed-off-by: Dani Elder Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher (cherry picked from commit 43418ae9f088f023b1d398ab30faaebb9c00cbf5) Signed-off-by: Fr?d?ric Demians commit a7741759aa501c8545b6acd97c0a2d851a148c12 Author: Nick Clemens Date: Fri Aug 26 19:20:34 2016 +0000 Bug 15388 - Show Syndetics covers by UPC in search results Syndetics code accepts UPC and OCLC numbers, however, we were only passing this if there was an ISBN. This patch alters the code to search if either an ISBN or UPC is present To test: Enable syndetics (will need an account) Search for items with UPCs or OCLC numbers and no ISBN (DVDs) Note there are no images in search results but there are in details Apply patch Note that items with images in details now also have images in results Signed-off-by: Barbara.Johnson at bedfordtx.gov Signed-off-by: Martin Renvoize Signed-off-by: Brendan Gallagher (cherry picked from commit dbf2f7d6d97686179a1e794e0c74ad8be441a177) Signed-off-by: Fr?d?ric Demians commit 5dced305bbaa54a831bd830f900fc9d29bf3e13d Author: Jesse Maseto Date: Wed Oct 12 17:44:42 2016 +0000 Bug 7143 NEW added Kyle Hall as release manager. Signed-off-by: Dani Elder Signed-off-by: Marcel de Rooy (cherry picked from commit 8cb65b367b47ffd9a1a362e7261199fefc3628bb) Signed-off-by: Fr?d?ric Demians commit 30e66a5eadbdda679bc71d11415ca31958256b24 Author: Fr?d?ric Demians Date: Tue Oct 11 04:52:13 2016 +0000 Uping DBRev. Bug 17357 - WTHDRAWN is still used in installer files Signed-off-by: Brendan Gallagher commit 78ce2bcb9f2217d5142a3257ff02ca647dd0ecac Author: Jonathan Druart Date: Tue Sep 27 10:52:17 2016 +0100 Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files Some installer files still use WTHDRAWN instead of WITHDRAWN as an AV category. Test plan: git grep WTHDRAWN installer should not return any results Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit ce076e0e757ff812eba21ee6102e6c44076e5595) Signed-off-by: Fr?d?ric Demians commit aa231539854fe9aa0ef75daca342c8cced0b8150 Author: Jonathan Druart Date: Tue Sep 27 13:38:34 2016 +0100 Bug 17358: Rename COU with COUNTRY and LAN with LANG Some installer files use COU and LAN instead of COUNTRY and LANG. To uniformise these AVs, it would be good to use the same code. Note that I do not think we should update existing installations Carefully compared code. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 75a900d55365dc6a8d1396b68329a0679d9dc430) Signed-off-by: Fr?d?ric Demians commit 3a53760cd1ab7d85b3bfcdfa742cab032a7e545d Author: Jonathan Druart Date: Thu Sep 29 10:31:11 2016 +0100 Bug 17372: Standardize Elasticsearch paths What we currently have: Koha/ElasticSearch.pm Koha/ElasticSearch/Indexer.pm Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Koha/SearchEngine/Elasticsearch/Search.pm What we want: Koha/SearchEngine/Elasticsearch.pm Koha/SearchEngine/Elasticsearch/Indexer.pm Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Koha/SearchEngine/Elasticsearch/Search.pm Test plan: % git grep -i Koha::ElasticSearch % git grep ElasticSearch|grep -v Catmandu::Store::ElasticSearch should not return any result Do a full reindex and search for records Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher (cherry picked from commit df3df9cf7199c464565742af59bd48006d93cfdf) Signed-off-by: Fr?d?ric Demians commit 78a58175a5f60c3293e0bdbffe3364a6c06844a9 Author: Jonathan Druart Date: Thu Sep 29 10:18:27 2016 +0100 Bug 16838: ES - install mappings for new installs The yaml file is not used to populate ES mapping tables (search_field, search_marc_map and search_marc_to_field) when doing a fresh install. We need to insert them, otherwise ES will be unusable. Test plan: Create a new install and confirm that the ES tables (search_field, search_marc_map and search_marc_to_field) are correctly populated. Bonus points: Use an older DB (prior to 3.23.00.050), execute the updatedatabase.pl script and confirm that the ES table are correctly populated Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher (cherry picked from commit a36b6430195310b5198077dd50cdb436ef07ce37) Signed-off-by: Fr?d?ric Demians commit 0e953489908f8fb44bd6173620050054e0a66e71 Author: Marc Date: Wed Oct 5 15:43:29 2016 +0200 Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted Additional tests: Try to delete yourself, to delete a staff member without having superlibrarian permission etc. To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons Amended to include all occurences of 'exit 1' Signed-off-by: Chris Cormack Good catch Marc Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit b588babdb23bfdc1163864a26c36a61bf8a39ae5) Signed-off-by: Fr?d?ric Demians commit 2f70fde91a53b5a8e05c99fa51c77ba263e9d38c Author: Andreas Roussos Date: Sat Sep 17 13:44:47 2016 +0300 Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 884e28fab5e4db86dd9f50f2908519a0cd6650d5) Signed-off-by: Fr?d?ric Demians commit fc0d4ca25d967ce443b4aa13039d4154b47125ef Author: Fr?d?ric Demians Date: Sat Oct 22 12:45:52 2016 +0200 Bug 17088 Quick fix on test Signed-off-by: Fr?d?ric Demians commit 8ff0d2fe586a774af234f4f65670fb3dd720bd8f Author: Fr?d?ric Demians Date: Sat Oct 22 12:41:21 2016 +0200 Bug 17292 Follow-up, fix typos - wrong assignation - reference to 'serials' table rather than 'serial' Signed-off-by: Fr?d?ric Demians commit 1c35b86c2e7b7dd00bf677f51d8a141e3c281072 Author: Jonathan Druart Date: Tue Oct 4 14:49:19 2016 +0100 Bug 17088: Add tests to cover the changes Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit bc1e23e1f11e146e282d0e2efa7fd77e2c26d631) commit 40a2b8c12150d6fe193ba10c808b47069494157a Author: Marcel de Rooy Date: Fri Sep 16 11:27:05 2016 +0200 Bug 17088: [Follow-up] Use Logger for failed exports Fixes a TODO for logging unsupported record_type in _get_record_for_export. Also logs a warning when the record_type parameter is not supplied at all in sub export. Replaces a warn by a log message about an invalid record for format iso2709. Also adds a log message about an invalid record for format xml. Adds a trivial unit test for passing no record_type to export. Test plan: See also first patch. Run t/db_dependent/Exporter/Record.t. Signed-off-by: Marcel de Rooy Also tested the log messages for iso2709 and xml by manipulating the record_type parameter with: $params->{record_type}='xx'; before calling _get_record_for_export in Record.pm. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 0eec191ed3ab1ae1bd24972a559d12627b70f681) commit 051661024ca92a343ad74e2664627c070bb5c66e Author: Marcel de Rooy Date: Fri Sep 16 10:44:47 2016 +0200 Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 44b51ed80224d0361796c1a70cb66bb5096a427c) Signed-off-by: Fr?d?ric Demians commit cb1ee8e3ccbc8bbce47b9db502a90c09e2a6ec3f Author: Kyle M Hall Date: Tue Aug 9 13:08:17 2016 +0000 Bug 17088 - Bad MARC XML can halt export_records.pl If export_records.pl encounters a record that fails to load correctly as a MARC::Record the export process will fail and only the records encountered up to that point will be exported. Test Plan: 1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters 2) Export your records using the command: misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml 3) Note you get an error and the script ends prematurely 4) Apply this patch 5) Repeat step 2 6) Note the full record set is exported ( except for your bad record ) 7) Note an error is still generated for your bad record ( useful for tracking down bad records ). Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e72a8ab260abed11b02266d77bc17d831884ed40) Signed-off-by: Fr?d?ric Demians commit f3917fc8cb8c49bc85e7d371043cae8bd276063d Author: Mason James Date: Wed Aug 3 16:32:00 2016 +1200 Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default to test bug... 1/ make a random user 2/ change to random user 3/ access any zebra database with random user and no authentication 4/ read zebra database here is a transcript of the bug... --------------------------- root at xen1:~# adduser bob root at xen1:~# su -l bob bob at xen1:~$ cd /var/lib/koha bob at xen1:/var/lib/koha$ ls topsecret bob at xen1:/var/lib/koha$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.001002 Z> base biblios; Z> find the Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1130, setno 2 SearchResult-1: term=the cnt=1130 records returned: 0 Elapsed: 0.005518 Z> show Sent presentRequest (1+1). Records: 1 [biblios]Record type: USmarc 01824cam a2200397 a 4500 001 000045782309 003 AuCNLKIN 005 20111013213222.0 008 100707s2011 maua 001 0 e ... --------------------------- 5/ apply changes to a Koha instance's config files, that you plan to test 6/ restart zebra for instance # sudo koha-restart-zebra topsecret 7/ repeat steps 2 and 3, but receive a 'bad user/passwd ' error from zebra bob at xen1:~$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection rejected by v3 target. 1: code=1011 (Init/AC: Bad Userid and/or Password), NOTE: this patch currently will only fixes newly created instances, it wont fix existing instances Signed-off-by: Chris Cormack Good catch Mason Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb) Signed-off-by: Fr?d?ric Demians commit 11074092311b11b1553eb1fe7cfe169b4a8b6f57 Author: Mark Tompsett Date: Sun Sep 18 20:47:33 2016 -0400 Bug 17292: Follow up - tweak to make it pass cleaner remove a 'my' next if not defined subscriptions. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 6ff836ab3154a886e0aeedb1152f6caf2e546444) Signed-off-by: Fr?d?ric Demians commit fc42eeba6a66c02459332e257fdb1364fb257270 Author: Kyle M Hall Date: Mon Sep 12 14:20:19 2016 +0000 Bug 17292 - Use of DBIx in updatedatabase.pl broke upgrade A recent change in the 'subscription' table structure highlighted a problem in a DBRev upgrade (3.23.00.006). As it adds a new column, when upgrading from (say) 3.20.00.000 the code/schema (correctly) expects the subscription.itemtype column to exist. But it is not created until DBRev 16.06.00.025. To reproduce: - Have a clean 3.20.00 DB loaded into kohadevbox - Checkout current master - Run: $ perl installer/data/mysql/updatedatabase.pl => FAIL: The upgrade procedure fails due to missing colum. The solution: rewrite the updatedatabase.pl entry using plain DBI Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit f11f07a703eca7da2d32c105f8c9f4f46f940b6f) Signed-off-by: Fr?d?ric Demians commit 3c2bd4ef3b1cc45d955940c1323c2b2c9b05cc4a Author: Mark Tompsett Date: Tue Sep 20 19:29:28 2016 -0400 Bug 17324: Deal with branchcode NULL issue In a database update we alter the letter table, making a column (branchcode) not be able to contain NULL values. However if it already does, this SQL fails. So before changing the column we change the NULL values [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Did not follow the test plan, but the changes make sense Signed-off-by: Brendan Gallagher (cherry picked from commit 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e) Signed-off-by: Fr?d?ric Demians commit 26efec07d7344ecf3c29981e735246dec6416bd1 Author: Kyle M Hall Date: Sat Sep 24 19:25:33 2016 +0000 Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 56da7be50ada38bab6ec866f5915d55507c7d821) Signed-off-by: Fr?d?ric Demians commit d62b515ef7ead3c77f6776438df11980f6b2028d Author: Kyle M Hall Date: Tue Sep 6 09:37:14 2016 +0000 Bug 16573 - Update Schema Signed-off-by: Kyle M Hall (cherry picked from commit 514282d04c4494ca5eee02b18c775db74a6bbb91) Signed-off-by: Fr?d?ric Demians commit 6c28248d8f1b8f8413ba2a29fafb0f7f825b8358 Author: Fr?d?ric Demians Date: Sat Oct 22 09:16:44 2016 +0200 DBRev 16.05.04.02 commit 517e4eb553e31dad4d7d49a6c2b2222884423d75 Author: Jonathan Druart Date: Tue Aug 16 09:18:19 2016 +0100 Bug 7045: Update default value placeholders for existing installs Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 547b5f95f62a00e360c5cac4e416d30365429fcb) Signed-off-by: Fr?d?ric Demians commit 60ab0769530c190dcd849f15909eed4961aa8a83 Author: Jonathan Druart Date: Tue Aug 16 09:09:53 2016 +0100 Bug 7045: Use <> for default value placeholders When adding a biblio, the default value of a MARC subfield defined in the frameworks can be used as placeholders to set the current date or the surname of the logged in user (use cases?). The different placeholders are 'YYYY', 'MM', 'DD', 'user'. When adding an item, same behavior except that 'user' is not replaced. This patch makes behaviors consistent between the 2 editors and surrounds placeholders with << >> We will now have: <>, <>, <
> and <> Test plan: Define default values for biblio and item subfields. Create a bibliographic record and attach it an item. The default values should be used and replaced if you used placeholders. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 50abf24ff04aae0c9010411fa6e98561c2ccc66f) Signed-off-by: Fr?d?ric Demians commit 1de610bb63f70b9f4a1e3a8a5683de5d3bb7bb12 Author: Aleisha Amohia Date: Wed Aug 24 21:24:45 2016 +0000 Bug 16035: MARC default bibliographic framework Export fix This patch makes sure that, if there is no framework code, $frameworkcode is set to 'default'. This fixes the format issue. Then, if $frameworkcode = default, an empty string (rather than null) is passed to the ExportFramework method, as the framework code in the DB for default codes is "". To test: 1) Go to Admin -> MARC Bibliographic framework 2) Try to export default framework in all formats, notice the file is only exported as .ods and is an empty file. Notice warns in intranet error log. 3) Apply patch and refresh page 4) Confirm exporting default framework works in all formats and spreadsheet has data 5) Notice warns in error log are gone 6) Confirm export still works for other frameworks Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 705097f938ba9334c21b3e6f006bd7c9ba38763c) Signed-off-by: Fr?d?ric Demians commit 4f5d1faef59d57d33a1e6ce1c7ed28792e00ee43 Author: Jonathan Druart Date: Tue Sep 6 12:58:31 2016 +0100 Bug 14060: Improve regex to limit year to 4 integers 01/01/01984 should not be considered as a valid date. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit eab75d0aa48759e8f2ec017b643e0ca6f985c937) Signed-off-by: Fr?d?ric Demians commit ee073f00860c90d4a96abc8bc4677aa020a53669 Author: Jonathan Druart Date: Mon Sep 5 09:16:02 2016 +0100 Bug 14060: Consider an empty string as a valid date Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 61d819caef44700b2b1a85c9c27e47913a165a4f) Signed-off-by: Fr?d?ric Demians commit 4b80a676df11ddfd475caac75e1fa674e6c0b203 Author: Jonathan Druart Date: Tue Aug 30 09:56:46 2016 +0100 Bug 14060: Add the datepicker class to dateofbirth Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 08653cca9bd9d5185293c56326ec35a6e875550c) Signed-off-by: Fr?d?ric Demians commit a121ecbfa1ede24329556eaf51ecce6d4523d753 Author: Jonathan Druart Date: Tue Aug 30 09:54:55 2016 +0100 Bug 14060: Force leading zeros on date If a date does not contain leading zeros for day and month, the date will be refused. parseDate function considers 1/1/1990 as a valid date, but our perl code does not. We must refuse it. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit db3df548b6a6385ea17d2db49f49f8d4c9f2969f) Signed-off-by: Fr?d?ric Demians commit 20bcc8770ad31629b4ef060b6e6a687932579f43 Author: Jonathan Druart Date: Fri Aug 26 08:44:06 2016 +0100 Bug 14060: Display date format pattern instead of date format name Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 26fdc96c5ea824b5529da846b63a8e4e62d486e8) Signed-off-by: Fr?d?ric Demians commit 6f75e5cc5b87c6a7ba42cea7752adec9bb3952ce Author: Jonathan Druart Date: Mon Jan 4 11:03:43 2016 +0000 Bug 14060: Add support for dmydot Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit edd555df4dc40f9ee3f8625240564fcc65c2935f) Signed-off-by: Fr?d?ric Demians commit 6087cfde3fb98901bf6d3f7d6d98d48eee25149a Author: Jonathan Druart Date: Tue Dec 1 17:33:15 2015 +0000 Bug 14060: Force the input to contain a valid date Before this patch, the user was still allowed to enter a valid date. Now, if the date is not valid, the input is emptied. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 363e45a5eb89b25e47165bb815d6dc901744f977) Signed-off-by: Fr?d?ric Demians commit a133becbfc738dcd327a6422b50e39d95ce1028c Author: Jonathan Druart Date: Mon Apr 27 10:42:51 2015 +0200 Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 2a3966946131992ceeb125be3a852b9893bfd708) Signed-off-by: Fr?d?ric Demians commit 9cfee957dbdba479c96dfdce80095b91a628757b Author: Jonathan Druart Date: Mon Apr 27 10:39:14 2015 +0200 Bug 14060: Add OnClose event on missing datepicker The "suspend until" inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit d53fb6db6a0cb0d239e7849c902a3dce4966c709) Signed-off-by: Fr?d?ric Demians commit b089121aeb06a722657842a433832330a32098ae Author: Jonathan Druart Date: Fri Apr 24 15:36:34 2015 +0200 Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit f91ed3d8bf19533a4a92e67c0b1fe394e84e67bf) Signed-off-by: Fr?d?ric Demians ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 4 +- C4/HoldsQueue.pm | 54 ++++++ C4/ImportExportFramework.pm | 7 +- C4/Items.pm | 2 - C4/Letters.pm | 20 +- C4/Ris.pm | 89 +++++---- Koha.pm | 2 +- Koha/Database.pm | 4 + Koha/Exporter/Record.pm | 21 ++- Koha/Logger.pm | 8 +- Koha/Schema/Result/Issuingrule.pm | 6 +- Koha/Schema/Result/Virtualshelve.pm | 10 +- .../Elasticsearch.pm} | 27 ++- .../Elasticsearch}/Indexer.pm | 10 +- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +- Koha/SearchEngine/Elasticsearch/Search.pm | 6 +- acqui/basket.pl | 2 +- acqui/lateorders.pl | 4 +- admin/import_export_framework.pl | 8 +- cataloguing/addbiblio.pl | 24 ++- cataloguing/additem.pl | 17 +- circ/circulation.pl | 6 +- etc/zebradb/zebra-authorities-dom.cfg | 2 +- etc/zebradb/zebra-authorities.cfg | 2 +- etc/zebradb/zebra-biblios-dom.cfg | 2 +- etc/zebradb/zebra-biblios.cfg | 2 +- .../mandatory/unimarc_framework_DEFAULT.sql | 6 +- .../mandatory/unimarc_framework_DEFAULT.sql | 8 +- .../mandatory/unimarc_framework_DEFAULT.sql | 8 +- .../unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- ...rc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- .../optional/unimarc_bibliographic_AN_local.sql | 2 +- .../optional/unimarc_bibliographic_AUD_local.sql | 2 +- .../optional/unimarc_bibliographic_BOOK_local.sql | 2 +- ...rc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../optional/unimarc_bibliographic_EL_local.sql | 2 +- .../optional/unimarc_bibliographic_MIN_local.sql | 2 +- .../optional/unimarc_bibliographic_NOTE_local.sql | 2 +- .../optional/unimarc_bibliographic_PER_local.sql | 2 +- .../optional/unimarc_bibliographic_TECH_local.sql | 2 +- installer/data/mysql/updatedatabase.pl | 88 +++++---- installer/install.pl | 2 + .../prog/en/includes/borrower_debarments.inc | 2 +- .../intranet-tmpl/prog/en/includes/calendar.inc | 64 ++++++- .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 +- .../prog/en/includes/checkouts-table-footer.inc | 2 +- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 14 +- .../prog/en/includes/patron-title.inc | 16 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 4 +- .../prog/en/modules/acqui/invoices.tt | 4 +- .../prog/en/modules/acqui/lateorders.tt | 2 +- .../prog/en/modules/admin/preferences/admin.pref | 168 ++++++++--------- .../prog/en/modules/circ/circulation.tt | 26 ++- .../intranet-tmpl/prog/en/modules/circ/offline.tt | 10 +- .../intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 8 +- .../prog/en/modules/members/deletemem.tt | 4 +- .../prog/en/modules/members/memberentrygen.tt | 50 ++--- .../prog/en/modules/members/moremember.tt | 67 +++---- .../prog/en/modules/members/printfeercpt.tt | 12 +- .../prog/en/modules/members/printinvoice.tt | 12 +- .../prog/en/modules/reserve/request.tt | 6 +- .../prog/en/modules/tools/modborrowers.tt | 5 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 + .../intranet-tmpl/prog/js/pages/circulation.js | 13 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- members/deletemem.pl | 9 +- members/patronimage.pl | 2 +- members/pay.pl | 4 +- members/printfeercpt.pl | 1 + members/printinvoice.pl | 1 + misc/devel/populate_db.pl | 193 ++++++++++++++++++++ misc/export_records.pl | 12 +- misc/search_tools/rebuild_elastic_search.pl | 8 +- opac/opac-detail.pl | 2 + opac/opac-memberentry.pl | 3 +- opac/svc/overdrive_proxy | 4 +- t/00-load.t | 2 +- t/db_dependent/BackgroundJob.t | 2 +- t/db_dependent/Circulation/MarkIssueReturned.t | 22 ++- t/db_dependent/Exporter/Record.t | 90 ++++++--- t/db_dependent/HoldsQueue.t | 82 ++++++++- t/db_dependent/KitchenSinkPlugin.kpz | Bin 74771 -> 75857 bytes .../{Koha_ElasticSearch.t => Koha_Elasticsearch.} | 2 +- ...arch_Indexer.t => Koha_Elasticsearch_Indexer.t} | 4 +- .../Koha_SearchEngine_Elasticsearch_Search.t | 2 +- t/db_dependent/Letters.t | 2 +- t/db_dependent/Patron/Borrower_Discharge.t | 13 +- tools/quotes/quotes_ajax.pl | 2 +- 91 files changed, 1007 insertions(+), 438 deletions(-) rename Koha/{ElasticSearch.pm => SearchEngine/Elasticsearch.pm} (91%) rename Koha/{ElasticSearch => SearchEngine/Elasticsearch}/Indexer.pm (94%) create mode 100755 misc/devel/populate_db.pl rename t/db_dependent/{Koha_ElasticSearch.t => Koha_Elasticsearch.} (94%) rename t/db_dependent/{Koha_ElasticSearch_Indexer.t => Koha_Elasticsearch_Indexer.t} (90%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Oct 22 15:38:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Oct 2016 13:38:42 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.04-96-g7395b53 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via 7395b536de74725a62c7aa7212f5226d9070b0c2 (commit) via 17fc4485243f96867df89f6bac2f0ac3f2e3dd35 (commit) from ff043fb6675d48506db8d50dd65f4d98cbdff91a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7395b536de74725a62c7aa7212f5226d9070b0c2 Author: Fr?d?ric Demians Date: Sat Oct 22 15:45:25 2016 +0200 Translation for 16.05.05 commit 17fc4485243f96867df89f6bac2f0ac3f2e3dd35 Author: Fr?d?ric Demians Date: Sat Oct 22 15:39:38 2016 +0200 Version 16.05.05 ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/release_notes/release_notes_16_5_5.md | 422 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 39 +- misc/translator/po/am-Ethi-pref.po | 784 + misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 1143 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 39 +- misc/translator/po/ar-Arab-pref.po | 784 + misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 1151 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 39 +- misc/translator/po/az-AZ-pref.po | 784 + misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 1143 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 39 +- misc/translator/po/be-BY-pref.po | 784 + misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 1143 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 39 +- misc/translator/po/bg-Cyrl-pref.po | 784 + misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 1143 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 39 +- misc/translator/po/bn-IN-pref.po | 784 + misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 1143 +- misc/translator/po/cs-CZ-marc-MARC21.po | 6 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 72 +- misc/translator/po/cs-CZ-pref.po | 806 +- misc/translator/po/cs-CZ-staff-help.po | 119 +- misc/translator/po/cs-CZ-staff-prog.po | 1443 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 39 +- misc/translator/po/cy-GB-pref.po | 784 + misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 1143 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 39 +- misc/translator/po/da-DK-pref.po | 784 + misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 1143 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 61 +- misc/translator/po/de-DE-pref.po | 785 + misc/translator/po/de-DE-staff-help.po | 9 +- misc/translator/po/de-DE-staff-prog.po | 1179 +- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 39 +- misc/translator/po/el-GR-pref.po | 784 + misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 1143 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 423 +- misc/translator/po/eo-pref.po | 784 + misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 1143 +- misc/translator/po/es-ES-marc-MARC21.po | 6 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 63 +- misc/translator/po/es-ES-pref.po | 792 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 1165 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 39 +- misc/translator/po/eu-pref.po | 784 + misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 1143 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 39 +- misc/translator/po/fa-Arab-pref.po | 784 + misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 1143 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 39 +- misc/translator/po/fi-FI-pref.po | 784 + misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 1143 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 39 +- misc/translator/po/fo-FO-pref.po | 784 + misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 1143 +- misc/translator/po/fr-FR-marc-MARC21.po | 34 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 64 +- misc/translator/po/fr-FR-pref.po | 800 +- misc/translator/po/fr-FR-staff-help.po | 521 +- misc/translator/po/fr-FR-staff-prog.po | 1221 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 39 +- misc/translator/po/gl-pref.po | 784 + misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 1143 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 39 +- misc/translator/po/he-Hebr-pref.po | 784 + misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 1143 +- misc/translator/po/hi-marc-MARC21.po | 93 +- misc/translator/po/hi-marc-NORMARC.po | 30 +- misc/translator/po/hi-marc-UNIMARC.po | 284 +- misc/translator/po/hi-opac-bootstrap.po | 221 +- misc/translator/po/hi-pref.po | 881 +- misc/translator/po/hi-staff-help.po | 303 +- misc/translator/po/hi-staff-prog.po | 1560 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 39 +- misc/translator/po/hr-HR-pref.po | 784 + misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 1143 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 39 +- misc/translator/po/hu-HU-pref.po | 784 + misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 1143 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 39 +- misc/translator/po/hy-Armn-pref.po | 784 + misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 1143 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 39 +- misc/translator/po/ia-pref.po | 784 + misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 1143 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 39 +- misc/translator/po/id-ID-pref.po | 784 + misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 1143 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 39 +- misc/translator/po/iq-CA-pref.po | 784 + misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 1143 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 39 +- misc/translator/po/is-IS-pref.po | 784 + misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 1143 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 2530 +- misc/translator/po/it-IT-pref.po | 791 +- misc/translator/po/it-IT-staff-help.po | 32 +- misc/translator/po/it-IT-staff-prog.po |10358 +++--- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 39 +- misc/translator/po/iu-CA-pref.po | 784 + misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 1143 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 39 +- misc/translator/po/ja-Jpan-JP-pref.po | 784 + misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 1143 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 39 +- misc/translator/po/ka-pref.po | 784 + misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 1143 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 39 +- misc/translator/po/km-KH-pref.po | 784 + misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 1143 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 39 +- misc/translator/po/kn-Knda-pref.po | 784 + misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 1143 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 39 +- misc/translator/po/ko-Kore-KP-pref.po | 784 + misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 1143 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 39 +- misc/translator/po/ku-Arab-pref.po | 784 + misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 1143 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 39 +- misc/translator/po/lo-Laoo-pref.po | 784 + misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 1143 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 39 +- misc/translator/po/mi-NZ-pref.po | 784 + misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 1143 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 39 +- misc/translator/po/ml-pref.po | 784 + misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 1143 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 39 +- misc/translator/po/mon-pref.po | 784 + misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 1143 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 39 +- misc/translator/po/mr-pref.po | 784 + misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 1143 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 39 +- misc/translator/po/ms-MY-pref.po | 784 + misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 1143 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 39 +- misc/translator/po/my-pref.po | 784 + misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 1143 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 39 +- misc/translator/po/ne-NE-pref.po | 784 + misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 1143 +- misc/translator/po/oc-marc-MARC21.po |10794 +++--- misc/translator/po/oc-marc-NORMARC.po | 411 +- misc/translator/po/oc-marc-UNIMARC.po | 3912 ++- misc/translator/po/oc-opac-bootstrap.po | 7616 ++--- misc/translator/po/oc-pref.po | 3544 +- misc/translator/po/oc-staff-help.po | 8362 +++-- misc/translator/po/oc-staff-prog.po |41420 +++++++++++------------ misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 39 +- misc/translator/po/pbr-pref.po | 784 + misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 1143 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 39 +- misc/translator/po/ro-RO-pref.po | 784 + misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 1143 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 39 +- misc/translator/po/ru-RU-pref.po | 784 + misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 1143 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 39 +- misc/translator/po/sd-PK-pref.po | 784 + misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 1143 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 39 +- misc/translator/po/sk-SK-pref.po | 784 + misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 1143 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 39 +- misc/translator/po/sl-SI-pref.po | 784 + misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 1143 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 39 +- misc/translator/po/sq-AL-pref.po | 784 + misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 1143 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 39 +- misc/translator/po/sr-Cyrl-pref.po | 784 + misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 1143 +- misc/translator/po/sv-SE-marc-MARC21.po | 152 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 39 +- misc/translator/po/sv-SE-pref.po | 784 + misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 1143 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 39 +- misc/translator/po/sw-KE-pref.po | 784 + misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 1143 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 39 +- misc/translator/po/ta-pref.po | 784 + misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 1143 +- misc/translator/po/tet-marc-MARC21.po | 52 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 300 +- misc/translator/po/tet-pref.po | 784 + misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 1151 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 39 +- misc/translator/po/th-TH-pref.po | 784 + misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 1143 +- misc/translator/po/tl-PH-marc-MARC21.po | 22 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 51 +- misc/translator/po/tl-PH-pref.po | 784 + misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 1143 +- misc/translator/po/tr-TR-marc-MARC21.po | 32 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 50 +- misc/translator/po/tr-TR-opac-bootstrap.po | 205 +- misc/translator/po/tr-TR-pref.po | 818 +- misc/translator/po/tr-TR-staff-help.po | 157 +- misc/translator/po/tr-TR-staff-prog.po | 1699 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 39 +- misc/translator/po/uk-UA-pref.po | 784 + misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 1149 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 39 +- misc/translator/po/ur-Arab-pref.po | 784 + misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 1143 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 39 +- misc/translator/po/vi-VN-pref.po | 784 + misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 1143 +- 444 files changed, 134116 insertions(+), 81064 deletions(-) create mode 100644 misc/release_notes/release_notes_16_5_5.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Oct 22 15:39:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Oct 2016 13:39:42 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.05.05 created. v16.05.05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.05.05 has been created at adb2bf744ef39ea90d240722d76a4288f17b53a8 (tag) tagging 7395b536de74725a62c7aa7212f5226d9070b0c2 (commit) replaces v16.05.04 tagged by Fr?d?ric Demians on Sat Oct 22 15:47:02 2016 +0200 - Log ----------------------------------------------------------------- Koha release 16.05.05 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJYC23WAAoJEGOGo5WRV8bu8yMH/RGkRrAJJvIiNJoRRuTaJurZ pgqK5Q9WM8860BXEW2CY9Hd2Fi7PtXVTKLoYZaaRkhSe3NTvpfymYZIwfCS8YPoS j1k43jC8ySIk6oucCYChW5kvIMbtrLqHy9EAxW1wiPYwwJrA/vVfckAIZztBM6uP Ac2rjgpW36qvreoexL2oSqM6NMcNVG52vz5KHFZfzHUo80piO3YUtVJpA5B5Ltg2 Bz70fkvBbEO5vA8oKe2HYNfvnjbaW2HmuNJNiFkGL7Ae/FezwtFLEjTAWTRJ2KQb HRD1KO420coksEm4ZQnVNnMPi4c6Rd+wzjMPzDYzq6eYewjE7ejbZIdbJVSMB6Q= =LxmH -----END PGP SIGNATURE----- Aleisha Amohia (1): Bug 16035: MARC default bibliographic framework Export fix Andreas Jonsson (1): Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache Andreas Roussos (5): Bug 10768 - Improve the interface related to itemBarcodeFallbackSearch Bug 17289: Holds awaiting pickup shows date unformatted Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt Bug 9896 - Show vendor in subscription search when creating an order for a subscription Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages Fridolin Somers (2): Bug 17423 - patronimage.pl permission is too restrictive Bug 17367 - Showing all items must keep show holdings tab in OPAC details Fr?d?ric Demians (7): Bug 14707 - DBRev 16.05.04.001 DBRev 16.05.04.02 Bug 17292 Follow-up, fix typos Bug 17088 Quick fix on test Uping DBRev. Bug 17357 - WTHDRAWN is still used in installer files Version 16.05.05 Translation for 16.05.05 Hector Castro (2): Bug 17477: Duplicating a subfield yields an empty subfield tag Bug 16245: RIS export file type incorrect Jesse Maseto (1): Bug 7143 NEW added Kyle Hall as release manager. Jonathan Druart (38): Bug 16800: Fix XSS in catalogue/*detail.tt - title Bug 16800: Fix XSS in catalogue/*detail.tt - author Bug 16800: Fix XSS in catalogue/*detail.tt - isbn Bug 16800: Fix XSS in additem.pl Bug 17315: (Bug 17210 follow-up) Fix "Save to lists" links from the result page Bug 17316: Do not display the list's name if the user does not have permission - OPAC Bug 17316: Do not display the list's name if the user does not have permission - Staff Bug 17294: Make reserves_stats.pl plack safe Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 17300: Fix serials search Bug 16816: Do not copy parameters used when duplicating a report Bug 14707: Update existing installations and correct wrong values Bug 14060: Remove readonly attributes on date inputs Bug 14060: Add OnClose event on missing datepicker Bug 14060: Display the date format on the warning popup Bug 14060: Force the input to contain a valid date Bug 14060: Add support for dmydot Bug 14060: Display date format pattern instead of date format name Bug 14060: Force leading zeros on date Bug 14060: Add the datepicker class to dateofbirth Bug 14060: Consider an empty string as a valid date Bug 14060: Improve regex to limit year to 4 integers Bug 7045: Use <> for default value placeholders Bug 7045: Update default value placeholders for existing installs Bug 17088: Add tests to cover the changes Bug 16838: ES - install mappings for new installs Bug 17372: Standardize Elasticsearch paths Bug 17358: Rename COU with COUNTRY and LAN with LANG Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Bug 17389: Clear logs Bug 17365: Fix XSS in moremember.pl and memberentry.pl Bug 16358: Do not redirect to the editor when deleting records Bug 10337: Add a script to populate devs' DBs with sample data Bug 17393: Fix non-Latin chars handling in self reg Bug 17426: Do not set AutoCommit in tests Bug 17368: Update KitchenSinkPlugin.kpz Bug 17411: Remove 3 other occurrences of exit 1 Josef Moravec (1): Bug 17444: Enable exporting by time, not only date Julian FIOL (1): Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. Katrin Fischer (1): Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Kyle M Hall (5): Bug 16573 - Update Schema Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl Bug 17292 - Use of DBIx in updatedatabase.pl broke upgrade Bug 17088 - Bad MARC XML can halt export_records.pl Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other Marc (4): Bug 17403: Internal Server Error while deleting patron Bug 11217: The # in accountlines descriptions makes them un-writeoffable Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Bug 17404: Patron deletion page: Fix title and breadcrumb Marc V?ron (3): Bug 17144: Fix variable scope issues in edi_account.pl Bug 17322 - Translation breaks opac-ics.tt Bug 16687 - Translatability: Fix issues in Administration preferences Marcel de Rooy (5): Bug 17088: [Follow-up] Adjust POD in Logger.pm Bug 17088: [Follow-up] Use Logger for failed exports Bug 17441: [QA Follow-up] Return value of SendAlerts Bug 17446: Typo seleted Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Mark Tompsett (2): Bug 17324: Deal with branchcode NULL issue Bug 17292: Follow up - tweak to make it pass cleaner Mason James (1): Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default Mirko Tietgen (1): Bug 17085 - Specify libmojolicious-perl min version Nick Clemens (4): Bug 17331 - Show holding branch in holds awaiting pickup report Bug 15388 - Show Syndetics covers by UPC in search results Bug 17392 - opac/svc/overdrive_proxy is not plack safe Bug 17154 (QA followup) replace tabs with spaces Owen Leonard (1): Bug 17056 - Remove event attributes from various templates Rafal Kopaczka (1): Bug 17245: Untranslatable abbreviated names of seasons. Rodrigo Santellan (1): Bug 17405 Edit record uses Default framework Sophie Meynieux (1): Bug 17154 : Note column is missing on account lines receipt Tomas Cohen Arazi (6): Bug 2389: Add --test switch to overdue_notices.pl Bug 2389: (followup) Add documentation and fix use case Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests Bug 17430: Make MarkIssueReturned.t create its own data Bug 10337: (QA followup) Allow choosing MARC flavour Bug 10337: (followup) Upper case MARC flavour Zeno Tajoli (1): Bug 13405 - System information has misleading information about indexing mode ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Oct 23 12:29:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 23 Oct 2016 10:29:33 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.05.05-01 created. v16.05.05-01 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.05.05-01 has been created at f32f6bd291b11b57eb1ba5999e9aed0e050c8b83 (tag) tagging d879b8106c0ce999d612c60a5e1c72612807215d (commit) replaces v16.05.05 tagged by Fr?d?ric Demians on Sun Oct 23 12:36:44 2016 +0200 - Log ----------------------------------------------------------------- Koha release 16.05.05-01 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAABAgAGBQJYDJK8AAoJEGOGo5WRV8buE1wH/2Nqf1xBzl94nvD5jqwQhm3E cNWePssmU8PLmJc4Ef+nJrdCfn3B7I0o/v+sS4zr53zDEH/E7GGs9NTtQndLRy8d WDNvLpQBsAMdSTaTyI+WUiAtL78nMz2rqKXLNXeOvuiTnCjX/rahwF9bIEvoGUQO PC7MGDPR5+Cbl3Ljks2wQUCXyGE3EjKQ9EzRg/ITrT4nA8wXJaarEFIKjoSmf97D iOJuTkC2aqRmGuR4R4SnkAYgk1ZfLl0CHDlkKuDmtFpv1bFn+I/WsRTmwHrJ5MuP gSAMhdbLA068sUbbcDIld4U87esQ3FXT0c9JyIwJnBXKEunqjR5HnJNDaJJVpX0= =e7O3 -----END PGP SIGNATURE----- Fr?d?ric Demians (1): Revert "Bug 16687 - Translatability: Fix issues in Administration preferences" ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:05:46 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:05:46 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-19-g9af21da Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 9af21daf526ac4454811db9aade06eb3c6f61457 (commit) from a5d748883490f0ca1fce7e062057cbd86e640f4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9af21daf526ac4454811db9aade06eb3c6f61457 Author: Julian Maurice Date: Mon Oct 24 11:04:39 2016 +0200 Bug 16035: MARC default bibliographic framework Export fix This patch makes sure that, if there is no framework code, $frameworkcode is set to 'default'. This fixes the format issue. Then, if $frameworkcode = default, an empty string (rather than null) is passed to the ExportFramework method, as the framework code in the DB for default codes is "". To test: 1) Go to Admin -> MARC Bibliographic framework 2) Try to export default framework in all formats, notice the file is only exported as .ods and is an empty file. Notice warns in intranet error log. 3) Apply patch and refresh page 4) Confirm exporting default framework works in all formats and spreadsheet has data 5) Notice warns in error log are gone 6) Confirm export still works for other frameworks Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 705097f938ba9334c21b3e6f006bd7c9ba38763c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 1de610bb63f70b9f4a1e3a8a5683de5d3bb7bb12) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: admin/import_export_framework.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:32:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:32:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-22-gff4d812 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via ff4d8128f77c3a9ec4b8537bda92fb9e53b98be7 (commit) via f53fefb03ac6ed8def57333b9fd78614b1840518 (commit) via 81399156f8aaeea0d3fff7877731cd8d89e615d3 (commit) from 9af21daf526ac4454811db9aade06eb3c6f61457 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff4d8128f77c3a9ec4b8537bda92fb9e53b98be7 Author: Fr?d?ric Demians Date: Sat Oct 22 09:16:44 2016 +0200 Bug 7045: Update DB rev (3.22.11.02) Signed-off-by: Julian Maurice commit f53fefb03ac6ed8def57333b9fd78614b1840518 Author: Jonathan Druart Date: Tue Aug 16 09:18:19 2016 +0100 Bug 7045: Update default value placeholders for existing installs Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 547b5f95f62a00e360c5cac4e416d30365429fcb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 517e4eb553e31dad4d7d49a6c2b2222884423d75) Signed-off-by: Julian Maurice commit 81399156f8aaeea0d3fff7877731cd8d89e615d3 Author: Jonathan Druart Date: Tue Aug 16 09:09:53 2016 +0100 Bug 7045: Use <> for default value placeholders When adding a biblio, the default value of a MARC subfield defined in the frameworks can be used as placeholders to set the current date or the surname of the logged in user (use cases?). The different placeholders are 'YYYY', 'MM', 'DD', 'user'. When adding an item, same behavior except that 'user' is not replaced. This patch makes behaviors consistent between the 2 editors and surrounds placeholders with << >> We will now have: <>, <>, <
> and <> Test plan: Define default values for biblio and item subfields. Create a bibliographic record and attach it an item. The default values should be used and replaced if you used placeholders. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 50abf24ff04aae0c9010411fa6e98561c2ccc66f) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 60ab0769530c190dcd849f15909eed4961aa8a83) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- cataloguing/addbiblio.pl | 21 ++++++++++++--------- cataloguing/additem.pl | 17 +++++++++++------ installer/data/mysql/updatedatabase.pl | 18 ++++++++++++++++++ 4 files changed, 42 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:36:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:36:38 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-23-g50f2701 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 50f270140adbb3792e8a9ff92b5c9cfd8ac527d2 (commit) from ff4d8128f77c3a9ec4b8537bda92fb9e53b98be7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50f270140adbb3792e8a9ff92b5c9cfd8ac527d2 Author: Kyle M Hall Date: Sat Sep 24 19:25:33 2016 +0000 Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 56da7be50ada38bab6ec866f5915d55507c7d821) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 26efec07d7344ecf3c29981e735246dec6416bd1) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:38:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:38:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-24-gdb695c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via db695c4aedbc6b9cb121dd7cacf9aa9e59180842 (commit) from 50f270140adbb3792e8a9ff92b5c9cfd8ac527d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit db695c4aedbc6b9cb121dd7cacf9aa9e59180842 Author: Mark Tompsett Date: Tue Sep 20 19:29:28 2016 -0400 Bug 17324: Deal with branchcode NULL issue In a database update we alter the letter table, making a column (branchcode) not be able to contain NULL values. However if it already does, this SQL fails. So before changing the column we change the NULL values [Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed: Invalid use of NULL value [for Statement " [Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY COLUMN branchcode varchar(10) NOT NULL DEFAULT '' [Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at /home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line 12638. Reproduce: on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha development environment. ... git checkout -b my_3.18.x origin/3.18.x drop database koha_library; create database koha_library; quit; web install all sample data (ignore some issues with sample data, and one with mandatory) git checkout -b bug_17234 origin/master git bz apply 17292 git bz apply 17320 git bz apply 17260 git bz apply 17234 web install Two warning messages are expected output from upgrade process, but the above message is not. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Did not follow the test plan, but the changes make sense Signed-off-by: Brendan Gallagher (cherry picked from commit 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 3c2bd4ef3b1cc45d955940c1323c2b2c9b05cc4a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:43:57 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:43:57 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-25-g42e01bf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 42e01bf600f04fb0aa1de7e88794b355897740a3 (commit) from db695c4aedbc6b9cb121dd7cacf9aa9e59180842 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42e01bf600f04fb0aa1de7e88794b355897740a3 Author: Mason James Date: Wed Aug 3 16:32:00 2016 +1200 Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default to test bug... 1/ make a random user 2/ change to random user 3/ access any zebra database with random user and no authentication 4/ read zebra database here is a transcript of the bug... --------------------------- root at xen1:~# adduser bob root at xen1:~# su -l bob bob at xen1:~$ cd /var/lib/koha bob at xen1:/var/lib/koha$ ls topsecret bob at xen1:/var/lib/koha$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.001002 Z> base biblios; Z> find the Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1130, setno 2 SearchResult-1: term=the cnt=1130 records returned: 0 Elapsed: 0.005518 Z> show Sent presentRequest (1+1). Records: 1 [biblios]Record type: USmarc 01824cam a2200397 a 4500 001 000045782309 003 AuCNLKIN 005 20111013213222.0 008 100707s2011 maua 001 0 e ... --------------------------- 5/ apply changes to a Koha instance's config files, that you plan to test 6/ restart zebra for instance # sudo koha-restart-zebra topsecret 7/ repeat steps 2 and 3, but receive a 'bad user/passwd ' error from zebra bob at xen1:~$ yaz-client unix:/var/run/koha/topsecret/bibliosocket Connecting...OK. Sent initrequest. Connection rejected by v3 target. 1: code=1011 (Init/AC: Bad Userid and/or Password), NOTE: this patch currently will only fixes newly created instances, it wont fix existing instances Signed-off-by: Chris Cormack Good catch Mason Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb) Signed-off-by: Fr?d?ric Demians (cherry picked from commit f3917fc8cb8c49bc85e7d371043cae8bd276063d) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: etc/zebradb/zebra-authorities-dom.cfg | 2 +- etc/zebradb/zebra-authorities.cfg | 2 +- etc/zebradb/zebra-biblios-dom.cfg | 2 +- etc/zebradb/zebra-biblios.cfg | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:45:03 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:45:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-29-ge8b533b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via e8b533b27ae6f89254c7f74b6e47c2e2452f53aa (commit) via 05f67857a177dc887933fc7beee7588ae71a31a5 (commit) via a38f9ea7c48e7c316bf046450f2c018945b07b30 (commit) via 1e6cc05d855f37b8915570d6b6eb415c668b6cac (commit) from 42e01bf600f04fb0aa1de7e88794b355897740a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e8b533b27ae6f89254c7f74b6e47c2e2452f53aa Author: Jonathan Druart Date: Tue Oct 4 14:49:19 2016 +0100 Bug 17088: Add tests to cover the changes Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit bc1e23e1f11e146e282d0e2efa7fd77e2c26d631) (cherry picked from commit 1c35b86c2e7b7dd00bf677f51d8a141e3c281072) Signed-off-by: Julian Maurice commit 05f67857a177dc887933fc7beee7588ae71a31a5 Author: Marcel de Rooy Date: Fri Sep 16 11:27:05 2016 +0200 Bug 17088: [Follow-up] Use Logger for failed exports Fixes a TODO for logging unsupported record_type in _get_record_for_export. Also logs a warning when the record_type parameter is not supplied at all in sub export. Replaces a warn by a log message about an invalid record for format iso2709. Also adds a log message about an invalid record for format xml. Adds a trivial unit test for passing no record_type to export. Test plan: See also first patch. Run t/db_dependent/Exporter/Record.t. Signed-off-by: Marcel de Rooy Also tested the log messages for iso2709 and xml by manipulating the record_type parameter with: $params->{record_type}='xx'; before calling _get_record_for_export in Record.pm. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 0eec191ed3ab1ae1bd24972a559d12627b70f681) (cherry picked from commit 40a2b8c12150d6fe193ba10c808b47069494157a) Signed-off-by: Julian Maurice commit a38f9ea7c48e7c316bf046450f2c018945b07b30 Author: Marcel de Rooy Date: Fri Sep 16 10:44:47 2016 +0200 Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit 44b51ed80224d0361796c1a70cb66bb5096a427c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 051661024ca92a343ad74e2664627c070bb5c66e) Signed-off-by: Julian Maurice commit 1e6cc05d855f37b8915570d6b6eb415c668b6cac Author: Kyle M Hall Date: Tue Aug 9 13:08:17 2016 +0000 Bug 17088 - Bad MARC XML can halt export_records.pl If export_records.pl encounters a record that fails to load correctly as a MARC::Record the export process will fail and only the records encountered up to that point will be exported. Test Plan: 1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters 2) Export your records using the command: misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml 3) Note you get an error and the script ends prematurely 4) Apply this patch 5) Repeat step 2 6) Note the full record set is exported ( except for your bad record ) 7) Note an error is still generated for your bad record ( useful for tracking down bad records ). Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e72a8ab260abed11b02266d77bc17d831884ed40) Signed-off-by: Fr?d?ric Demians (cherry picked from commit cb1ee8e3ccbc8bbce47b9db502a90c09e2a6ec3f) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha/Exporter/Record.pm | 21 ++++++--- Koha/Logger.pm | 8 +++- t/db_dependent/Exporter/Record.t | 89 +++++++++++++++++++++++++------------- 3 files changed, 81 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:47:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:47:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-30-g33f3f1c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 33f3f1c16306211682a5a367d54fba8add3854e5 (commit) from e8b533b27ae6f89254c7f74b6e47c2e2452f53aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33f3f1c16306211682a5a367d54fba8add3854e5 Author: Andreas Roussos Date: Sat Sep 17 13:44:47 2016 +0300 Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 884e28fab5e4db86dd9f50f2908519a0cd6650d5) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2f70fde91a53b5a8e05c99fa51c77ba263e9d38c) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:47:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:47:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-31-gb2125dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b2125dcc2f55f902d78e7eec4fc455ece8eaf43a (commit) from 33f3f1c16306211682a5a367d54fba8add3854e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2125dcc2f55f902d78e7eec4fc455ece8eaf43a Author: Marc Date: Wed Oct 5 15:43:29 2016 +0200 Bug 17403: Internal Server Error while deleting patron This patch fixes a Internal Server Error while deleting patrons. To reproduce: - Go to a patron's detail page - Toolbar : More : Delete - Confirm "Are you sure you want to delete..." Result: Internal Server Error Plack error log: exited nonzero: 1 at /home/marc/koha/members/deletemem.pl Note: Patron is deleted Additional tests: Try to delete yourself, to delete a staff member without having superlibrarian permission etc. To test: - Apply patch - Re-start plack - Try to reproduce steps above (with other patron) Expected result: No Internal Server Error, Redirect to Home > Patrons Amended to include all occurences of 'exit 1' Signed-off-by: Chris Cormack Good catch Marc Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit b588babdb23bfdc1163864a26c36a61bf8a39ae5) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 0e953489908f8fb44bd6173620050054e0a66e71) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: members/deletemem.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:49:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:49:09 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-32-g1b59dc9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 1b59dc9e58f84bb7710979880a986d66df7c0abb (commit) from b2125dcc2f55f902d78e7eec4fc455ece8eaf43a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1b59dc9e58f84bb7710979880a986d66df7c0abb Author: Jonathan Druart Date: Tue Sep 27 13:38:34 2016 +0100 Bug 17358: Rename COU with COUNTRY and LAN with LANG Some installer files use COU and LAN instead of COUNTRY and LANG. To uniformise these AVs, it would be good to use the same code. Note that I do not think we should update existing installations Carefully compared code. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 75a900d55365dc6a8d1396b68329a0679d9dc430) Signed-off-by: Fr?d?ric Demians (cherry picked from commit aa231539854fe9aa0ef75daca342c8cced0b8150) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 6 +++--- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:51:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:51:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-33-g3fd0cf3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3fd0cf36b2417e686bddbc95965cc4c9d2f46540 (commit) from 1b59dc9e58f84bb7710979880a986d66df7c0abb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fd0cf36b2417e686bddbc95965cc4c9d2f46540 Author: Jonathan Druart Date: Tue Sep 27 10:52:17 2016 +0100 Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files Some installer files still use WTHDRAWN instead of WITHDRAWN as an AV category. Test plan: git grep WTHDRAWN installer should not return any results Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit ce076e0e757ff812eba21ee6102e6c44076e5595) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 78ce2bcb9f2217d5142a3257ff02ca647dd0ecac) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/atomicupdate/bug_17357.sql | 1 + .../en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 2 +- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 2 +- .../marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql | 4 ++-- .../unimarc/mandatory/unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- .../optional/unimarc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../unimarc/mandatory/unimarc_bibliographic_DEFAULT_local_995.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_AN_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_AUD_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_BOOK_local.sql | 2 +- .../optional/unimarc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_EL_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_MIN_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_NOTE_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_PER_local.sql | 2 +- .../unimarc/optional/unimarc_bibliographic_TECH_local.sql | 2 +- 16 files changed, 17 insertions(+), 16 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_17357.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 11:53:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 09:53:41 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-34-gef74f4c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via ef74f4c803da7f139995ab0d16ec3b3f70473e31 (commit) from 3fd0cf36b2417e686bddbc95965cc4c9d2f46540 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef74f4c803da7f139995ab0d16ec3b3f70473e31 Author: Julian Maurice Date: Mon Oct 24 11:52:46 2016 +0200 Bug 17357: Update DB rev (3.22.11.003) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug_17357.sql | 1 - installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_17357.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:01:06 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:01:06 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-35-gfe77946 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via fe779466cc6244ddea9c789066dd4f9a311e4093 (commit) from ef74f4c803da7f139995ab0d16ec3b3f70473e31 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe779466cc6244ddea9c789066dd4f9a311e4093 Author: Nick Clemens Date: Wed Oct 5 13:26:09 2016 +0000 Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actual overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified by reading code - couldn't verify using Overdrive. Signed-off-by: Brendan Gallagher (cherry picked from commit f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 80de7080ef5f3694378c4a909b96ee62866d0b41) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: opac/svc/overdrive_proxy | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:02:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:02:47 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-37-g9931ced Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 9931cedb03a3c4ae8121b52f7a11d80f6c0954a8 (commit) via c2ad3f3ff5c9934f3fafd4aa9ea4bd6157d1fe36 (commit) from fe779466cc6244ddea9c789066dd4f9a311e4093 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9931cedb03a3c4ae8121b52f7a11d80f6c0954a8 Author: Jonathan Druart Date: Mon Oct 3 15:23:39 2016 +0100 Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro Warnings avoided Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 4592382e388d7f0ee0467180b50b5630a19c674a) Signed-off-by: Julian Maurice commit c2ad3f3ff5c9934f3fafd4aa9ea4bd6157d1fe36 Author: Jonathan Druart Date: Mon Oct 3 15:15:40 2016 +0100 Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit a1eeffd8385e5b95ca1d06a8300e5bd42403486a) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5cf95dc6db4356dd5fbb1d9c46c50652d508a19b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/ImportExportFramework.pm | 7 ++++--- admin/import_export_framework.pl | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:25:04 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:25:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-38-g3b407e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3b407e3ecdcfe9ac79ffdc3f160735240d8eb427 (commit) from 9931cedb03a3c4ae8121b52f7a11d80f6c0954a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b407e3ecdcfe9ac79ffdc3f160735240d8eb427 Author: Jonathan Druart Date: Thu Sep 29 08:46:49 2016 +0100 Bug 17365: Fix XSS in moremember.pl and memberentry.pl There are certainly hundred of places where they are not escaped... Test plan: Create a patron with "Arun " in some of the fields. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a61c072f1acb77906843a5be319412f959374bda) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/circ-menu.inc | 14 ++--- .../prog/en/includes/patron-title.inc | 16 +++--- .../prog/en/modules/members/memberentrygen.tt | 46 ++++++++--------- .../prog/en/modules/members/moremember.tt | 54 ++++++++++---------- 4 files changed, 65 insertions(+), 65 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:27:26 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:27:26 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-39-g8049ea6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8049ea6ccd2363c7de616dee15507aeb131e2339 (commit) from 3b407e3ecdcfe9ac79ffdc3f160735240d8eb427 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8049ea6ccd2363c7de616dee15507aeb131e2339 Author: Marc Date: Fri Oct 7 11:03:45 2016 +0200 Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit 692014c817b58876042ab03d71bde0c2cce7e571) Signed-off-by: Fr?d?ric Demians (cherry picked from commit ff2b5116e9edb5ce62212a8f25518bc1647b19b9) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: members/pay.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:29:11 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:29:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-41-ga8931b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via a8931b472b859b44ccb9df410aedd1eb1627350b (commit) via eee41b0ae8e1fb893808b190c09d646db0b2e48b (commit) from 8049ea6ccd2363c7de616dee15507aeb131e2339 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a8931b472b859b44ccb9df410aedd1eb1627350b Author: Marcel de Rooy Date: Fri Oct 14 11:07:49 2016 +0200 Bug 17441: [QA Follow-up] Return value of SendAlerts This patch makes the return value of SendAlerts more consistent. It returns 1 on success, or undef || { error => 'msg' } on failure. Needed to adjust one test in Letters.t too. Adjusted one typo along the way (seleted). Signed-off-by: Marcel de Rooy Tested by running Letters.t. Also tested SendAlerts from the interface with AutoEmailOpacUser and memberentry (adding new patron). Signed-off-by: Brendan Gallagher (cherry picked from commit 17e2e6c994655aaa927b2579524022a4f24a8d1d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 18a472e627e8f8b7cec45ffe90f896374d90fb9d) Signed-off-by: Julian Maurice commit eee41b0ae8e1fb893808b190c09d646db0b2e48b Author: Katrin Fischer Date: Thu Oct 13 19:05:48 2016 +0200 Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Run prove t/db_dependent/Letters.t Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy To improve consistency, adding a follow-up. Signed-off-by: Brendan Gallagher (cherry picked from commit ff495c5fa8c58a7762b3494e97d90618d649f7a8) (cherry picked from commit 4ee9399028fda3f5b8cfbfd9c43eb50349569e91) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 18 +++++++++++++++--- t/db_dependent/Letters.t | 2 +- 2 files changed, 16 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:29:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:29:48 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-42-g8e5440b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8e5440b01baa402ea826e7a107586c2f94a5e0d2 (commit) from a8931b472b859b44ccb9df410aedd1eb1627350b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e5440b01baa402ea826e7a107586c2f94a5e0d2 Author: Marcel de Rooy Date: Fri Oct 14 11:29:44 2016 +0200 Bug 17446: Typo seleted Built on top of bug 17441 Test plan: Just have a look at the changes. Trivial. Git grep seleted. No results. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit f75afef59175933f7e93b04bdcbdcf5180b0b024) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 28eb0a880e2bf249da464f7da75ad409f9ffc919) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 2 +- acqui/lateorders.pl | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:32:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:32:44 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-43-g5bb0978 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 5bb0978f1bff9fc1b04e072ea3bd190a32db731b (commit) from 8e5440b01baa402ea826e7a107586c2f94a5e0d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bb0978f1bff9fc1b04e072ea3bd190a32db731b Author: Jonathan Druart Date: Tue Sep 13 15:03:55 2016 +0100 Bug 16358: Do not redirect to the editor when deleting records The "Delete record" button goes to addbiblio.pl?op=delete, which incorrectly redirects to Rancor when selected. Test plan: 0/ Enable EnableAdvancedCatalogingEditor 1/ Edit a record 2/ Switch to the Advanced editor 3/ click on "View the record" 4/ Delete the record => Without this patch you are redirected to the editor => With this patch you are redirected to the advanced search Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher (cherry picked from commit ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 537d7d9fa4650aa35b8e20cbaf0cad7f7a4d2ba4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:34:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:34:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-44-g96c2ee1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 96c2ee18ec079f76ac28e581a0b1194743a81542 (commit) from 5bb0978f1bff9fc1b04e072ea3bd190a32db731b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96c2ee18ec079f76ac28e581a0b1194743a81542 Author: Fridolin Somers Date: Tue Oct 11 10:00:56 2016 +0200 Bug 17423 - patronimage.pl permission is too restrictive Bug 14566 added the permission "borrowers" on patronimage.pl. This perm is too restrictive because circulation pages also uses this page. I propose to simply use "catalogue" perm. Test plan - Set an image to borrower xx - Create a user with only catalogue permission - Log with this user - Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx => Without patch you get the page saying you do not have the permission => With patch you get the image - Log out and retest the page patronimage.pl => You get 403 error Signed-off-by: remy Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher (cherry picked from commit e78f81d615a79ad293d599c7395efcabd267662d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit f620fbe0d9ec8c4df258dd3a35b839b466479d52) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: members/patronimage.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:35:09 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:35:09 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-45-g19d0de6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 19d0de6597c32c0ec495ca64a654c9576256feff (commit) from 96c2ee18ec079f76ac28e581a0b1194743a81542 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19d0de6597c32c0ec495ca64a654c9576256feff Author: Fridolin Somers Date: Wed Sep 28 14:49:32 2016 +0200 Bug 17367 - Showing all items must keep show holdings tab in OPAC details In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit f1298dc7828757fe9277a5128910335d2d6c0f2c) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 2a62a9a18cc3a36288e6abf3586a7e606e6e07db) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: opac/opac-detail.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:37:32 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:37:32 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-46-g6efb683 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6efb6830a24555809be7b1cff1faf156f7cb67a2 (commit) from 19d0de6597c32c0ec495ca64a654c9576256feff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6efb6830a24555809be7b1cff1faf156f7cb67a2 Author: Hector Castro Date: Thu Oct 20 08:57:46 2016 -0600 Bug 17477: Duplicating a subfield yields an empty subfield tag The problem only when clone a textareas in 5XX Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to the 5xx fields - Put something on the 521$a subfield or other textareas (e.g. 520$u or 583$x) - Clone the subfield => FAIL: The subfield correctly doesn't include the original data, BUT it doesn't have the subtield tag either. - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall (cherry picked from commit fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 90e9ab941eb47b0be4f859c45d394575324b5fc7) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:40:36 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:40:36 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-47-gde1c569 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via de1c5696e0f8828990c95dbdc0520abb12bf476c (commit) from 6efb6830a24555809be7b1cff1faf156f7cb67a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de1c5696e0f8828990c95dbdc0520abb12bf476c Author: Jonathan Druart Date: Tue Oct 4 08:29:30 2016 +0100 Bug 17393: Fix non-Latin chars handling in self reg If you fill the patron self reg with non-latin characters, they will be encoded with HTML entities (é) This bug leads to generate a userid with weird behaviors: ? => eacute ? => x Test plan: 0/ Do not apply the patch 1/ Set up the Self reg feature 2/ fill surname, fistname with something like "Micha? pou???" 3/ Save 4/ See the bad encoding/replacement on the screen and look at the data The accentued chars are replaced with their html representation and the non-Latin chars with a 'x' in the DB 5/ Apply this patch 6/ Repeat steps 2, 3 7/ Everything should be ok 8/ Try to make sure this HTML::Entities escape was not useful: fill surname with "surname " Save and look at the data Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit 35de8aa1ef07b04cfc7c977f7168cd36b40d7941) Signed-off-by: Fr?d?ric Demians (cherry picked from commit e25934f6cdb1eaae0fbc9be15afe55a3ee2ad51a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:42:12 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:42:12 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-48-g63059b0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 63059b0fe4f19265bf51453d001080b85e7cb49a (commit) from de1c5696e0f8828990c95dbdc0520abb12bf476c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63059b0fe4f19265bf51453d001080b85e7cb49a Author: Rodrigo Santellan Date: Mon Oct 10 04:20:12 2016 -0400 Bug 17405 Edit record uses Default framework In detail view (catalogue/detail.pl), when clicking on Edit > Edit record button, the record editor should be opened with the biblio record framework. It isn't the case. The Default framework is used. Same issue with Edit > Edit as new (duplicate). TO TEST: 1. Find a biblio record using a framework which is not the Default one. 2. See the biblio record in detail view (catalogue/detail.pl). 3. Click on Edit > Edit record. 4. Click on Settings => you can see 'Default' as selected framework. 5. Apply the patch. 6. Repeat step 3-4. => the biblio record framework is selected. 7. Repeat 3-4 using Edit > Edit as new (duplicate). Signed-off-by: Fr?d?ric Demians Added a test plan Signed-off-by: Bernardo Gonzalez Kriegel Fix the issue, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f060709df0ed07c0ff3dbc20404fa5b3b2aa8651) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 8659bad629fcdfb5bb612ad21ce0bcb0f70a74bd) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:47:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:47:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-49-gc94fc36 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c94fc36febe31b5d1ba2c781d7f640cb8ed872df (commit) from 63059b0fe4f19265bf51453d001080b85e7cb49a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c94fc36febe31b5d1ba2c781d7f640cb8ed872df Author: Jonathan Druart Date: Tue Oct 11 13:15:27 2016 +0100 Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Signed-off-by: Marc Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 106c66eee67be65246ee50ea59a4c0f27acf7e7e) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: t/db_dependent/BackgroundJob.t | 2 +- t/db_dependent/Borrower_Discharge.t | 13 +++---------- 2 files changed, 4 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:49:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:49:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-51-g2a468ac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2a468ac1fa2661ccd9e302b574167d42402e6dfc (commit) via e13ea6519b923a92f1e31042ad92b2f97f96b86f (commit) from c94fc36febe31b5d1ba2c781d7f640cb8ed872df (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a468ac1fa2661ccd9e302b574167d42402e6dfc Author: Marcel de Rooy Date: Fri Oct 14 10:01:12 2016 +0200 Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Position 7 of the leader is better referred to as biblevel. (Pos 6 is record type.) At the same time replacing some regex's by simple eq's. Signed-off-by: Marcel de Rooy It seems that bib level in the UNIMARC leader only allows a subset of the possible combinations for MARC21. This does not have bad side-effects however in the new code that tests bib level to determine the type tag. Signed-off-by: Kyle M Hall (cherry picked from commit 556a4870d6beced7df52dbbc2ad472769e79e148) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 6b02b7404dbaf4a9c266cdc6a23ddba829ffdf81) Signed-off-by: Julian Maurice commit e13ea6519b923a92f1e31042ad92b2f97f96b86f Author: Hector Castro Date: Wed Sep 28 15:29:37 2016 -0600 Bug 16245: RIS export file type incorrect When exporting lists to a RIS file, the TY field of the RIS file is always 'book' even if the item being exported is a journal or serial. Since unimarc and marc21 is coded in Koha, just a few references types are included. This needs a much better code. This bug changes only TY BOOK result. Other resources needs a case by case basis. To test: -In advanced search limit by itemtype (books, music, continue resources, etc). -Search and save result in Cart -Export to RIS Format and notice about the new TY change with all materials -Export record in bib record details page in OPAC and Intranet. -Confirm that works as expected. -Bonus test: -Try to import the RIS file in http://www.myendnoteweb.com if you have account or create one. NOTE: According with previous comment, some values has changed. Sponsored-by: Universidad de El Salvador Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit a74329af022eeb857e1f936c13274c0e41497472) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 14b662558019a4b3c1ff3923a8455f43fc878233) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Ris.pm | 89 ++++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 52 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:51:16 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:51:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-53-g43eb2ec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 43eb2ec07a7772629cf0902b7aa410558d8b14ca (commit) via e03608f2c5fdbe82662f557eac05faa7a9fbdaa0 (commit) from 2a468ac1fa2661ccd9e302b574167d42402e6dfc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 43eb2ec07a7772629cf0902b7aa410558d8b14ca Author: Jonathan Druart Date: Tue Oct 18 17:14:58 2016 +0100 Bug 17411: Remove 3 other occurrences of exit 1 Signed-off-by: Kyle M Hall (cherry picked from commit f1a8ca13028411384847615fbdeeaaedd9703382) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 5c324d8201fff6e3a727c95e182ad32b78ccf715) Signed-off-by: Julian Maurice commit e03608f2c5fdbe82662f557eac05faa7a9fbdaa0 Author: Marc Date: Thu Oct 6 14:37:14 2016 +0200 Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Note: Same situation as in Bug 17403 To test: - Verifiy that code change makes sense. Note: Same situation as in Bug 17403 Signed-off-by: David Cook Signed-off-by: Jonathan Druart Amended patch: Remove unecessary comment Signed-off-by: Kyle M Hall (cherry picked from commit 01636dca2f1bd132fcc8d16f7a91fa4a45a90668) Signed-off-by: Fr?d?ric Demians (cherry picked from commit f3889059133d5e9933325c98e172d4d0b1e69c11) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 -- acqui/basket.pl | 2 +- tools/quotes/quotes_ajax.pl | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:53:02 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:53:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-54-g0fe9687 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0fe968754813302782b859bf19de2f26b440162c (commit) from 43eb2ec07a7772629cf0902b7aa410558d8b14ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0fe968754813302782b859bf19de2f26b440162c Author: Marc Date: Wed Oct 5 16:08:52 2016 +0200 Bug 17404: Patron deletion page: Fix title and breadcrumb Title and breadcrumb of patron deletion page (deletemember.pl) say: "Can't Delete Patron". This should be changed to "Delete patron". To verify: - Go to a patron's detail page - Toolbar : More : Delete Result: You get a question: "Are you sure...", but title and breadcrumb say: "Can't Delete Patron" rsp "Cant delete patron" To test: - Apply patch - Repeat steps above. - Verify that title and breadcrumb display properly, including patron's name Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 9a81a138d45b245b69754f3e61115d5d997510c0) Signed-off-by: Fr?d?ric Demians (cherry picked from commit 14d5f19b9ee100c81b33414ffd58eac668c08823) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 12:54:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 10:54:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.11-56-g2532a0c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2532a0cc045467c7867bde16a7ae6c1f03de3f59 (commit) via d90e1c008602ca14bb2ac81fdd70ffaa0fd30908 (commit) from 0fe968754813302782b859bf19de2f26b440162c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2532a0cc045467c7867bde16a7ae6c1f03de3f59 Author: Nick Clemens Date: Fri Oct 14 08:52:54 2016 +0000 Bug 17154 (QA followup) replace tabs with spaces Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 1e17c92905143f6bc8cac38f00256541c7146fa3) Signed-off-by: Fr?d?ric Demians (cherry picked from commit f4b6b70f70b65bdcd948f6880f779b66c02a1ded) Signed-off-by: Julian Maurice commit d90e1c008602ca14bb2ac81fdd70ffaa0fd30908 Author: Sophie Meynieux Date: Mon Aug 22 12:02:11 2016 +0200 Bug 17154 : Note column is missing on account lines receipt When displaying Fines > Account tab for a patron, you can see on screen a Note column that is missing if you click on Print Test plan : * Find a patron with accountlines or add them manually (Create manual invoice/credit). * Be sure some of them got a Note * Clik on Print fior those lines Without patch, the printed receipt does not show the Note column with the patch, the printed receipt shows a Note column and Note content is correctly printed for accountline with a note. Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 734d08c2af16909f96b19003c4cc1d758b74f11d) Signed-off-by: Fr?d?ric Demians (cherry picked from commit a8dbb0cae8c5ca7e36ef9a2a3f2dc6b4474e64bd) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/printfeercpt.tt | 12 +++++++----- .../intranet-tmpl/prog/en/modules/members/printinvoice.tt | 12 +++++++----- members/printfeercpt.pl | 1 + members/printinvoice.pl | 1 + 4 files changed, 16 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 15:43:48 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 13:43:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1154-gc962285 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c962285e40a9735e6559900fab0d3d619bca0fff (commit) from 99de777c5090bdf5e4d9b91cb774e9baf8ab20cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c962285e40a9735e6559900fab0d3d619bca0fff Author: Jonathan Druart Date: Mon Oct 24 11:46:31 2016 +0000 Bug 16850: Adjust number of tests Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 16:26:34 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 14:26:34 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.22.12 created. v3.22.12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.22.12 has been created at a004a65e1e7f4f771380dcaec0539e39ee76c7d3 (tag) tagging 3e8a30baaf69d7d98229a9ad739d49aa2dbf7b8c (commit) replaces v3.22.11 tagged by Julian Maurice on Mon Oct 24 16:21:58 2016 +0200 - Log ----------------------------------------------------------------- Koha release 3.22.12 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJYDhkGAAoJELCH1RJUPDmpY7sP/26qDwBe0oHyaLq0A6x/VVfR +YUwQ9M27+4GjBOQALq+IcYfHTAFF/q1LE3eeuag6pNGIngsoO2oNW8UBU85QsXI Lo1XFqrhKDI7AYQoICcReAkDHBIbrIcx83vOyRJ8fpH2GAg+POxkKEVJC2ZXRF4C IDOUmsbVRC6JvlTb3WHUYQjjca/wKGYoC4CW2uC4nI7IglkIGIzWr1uHO4Uk4e6o uVOpqzZoT5/vyGDILhBO4nQeUom2GyLy2fyj4ABDrwOYtVOAPalrnZmK+SIS4nfL +XtRcccgL64My3Xs/i5A+9yIvvKH7F2tYNTiskSZNedS6cLWX7XOXAbxrG9GrKai CwGmEEYWax4gHALf9LD1WPC36R3+CkRaB+xNWgFogcrxAzu6GB6TmqeE7s3VGUdX i2XJvtWF+3lgOAoLUHGOtSMc1RVg6W0BKNE3N54wx354PjnHFFpfGyocFoelh+it P5450GEn66xEL4vyNvKZSTX2mJslO0jmE3V9kGsemVMJX/P0ODZuNCwLJu0Ba48d 3HXJQdNu/Eyjwz908/KhGnYYnfs7Gkl76EuCOFxwiNSM3jjM7p0lDP+f8TSxKjPj Zt1ZisI2wPo92GE/+h82AOVP7dNXk9faU+JY/gDbGaE1WfeH6iurCe3gtJXHCI7u FAuhioHh/JWNPFtCf1Zu =OiA/ -----END PGP SIGNATURE----- Andreas Jonsson (1): Bug 17342: (bug 17262 follow-up) fix the way to retrieve memcached config from apache Andreas Roussos (3): Bug 10768 - Improve the interface related to itemBarcodeFallbackSearch Bug 17289: Holds awaiting pickup shows date unformatted Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages Fridolin Somers (2): Bug 17423 - patronimage.pl permission is too restrictive Bug 17367 - Showing all items must keep show holdings tab in OPAC details Fr?d?ric Demians (2): Bug 14707: Update DB rev (3.22.11.001) Bug 7045: Update DB rev (3.22.11.02) Hector Castro (2): Bug 17477: Duplicating a subfield yields an empty subfield tag Bug 16245: RIS export file type incorrect Jonathan Druart (22): Bug 16800: Fix XSS in catalogue/*detail.tt - title Bug 16800: Fix XSS in catalogue/*detail.tt - author Bug 16800: Fix XSS in catalogue/*detail.tt - isbn Bug 16800: Fix XSS in additem.pl Bug 17316: Do not display the list's name if the user does not have permission - OPAC Bug 17316: Do not display the list's name if the user does not have permission - Staff Bug 17294: Make reserves_stats.pl plack safe Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 16816: Do not copy parameters used when duplicating a report Bug 14707: Update existing installations and correct wrong values Bug 7045: Use <> for default value placeholders Bug 7045: Update default value placeholders for existing installs Bug 17088: Add tests to cover the changes Bug 17358: Rename COU with COUNTRY and LAN with LANG Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Bug 17389: Clear logs Bug 17365: Fix XSS in moremember.pl and memberentry.pl Bug 16358: Do not redirect to the editor when deleting records Bug 17393: Fix non-Latin chars handling in self reg Bug 17426: Do not set AutoCommit in tests Bug 17411: Remove 3 other occurrences of exit 1 Julian FIOL (1): Bug 14707 : Replace UsageStatsCountry syspref from free text to a dropdown list. Julian Maurice (5): Bug 16035: MARC default bibliographic framework Export fix Bug 17357: Update DB rev (3.22.11.003) Translation updates for Koha 3.22.12 Update release notes for 3.22.12 release Increment version for 3.22.12 release Katrin Fischer (1): Bug 17441 - t/db_dependent/Letters.t fails on Jenkins Kyle M Hall (2): Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl Bug 17088 - Bad MARC XML can halt export_records.pl Marc (4): Bug 17403: Internal Server Error while deleting patron Bug 11217: The # in accountlines descriptions makes them un-writeoffable Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error Bug 17404: Patron deletion page: Fix title and breadcrumb Marcel de Rooy (5): Bug 17088: [Follow-up] Adjust POD in Logger.pm Bug 17088: [Follow-up] Use Logger for failed exports Bug 17441: [QA Follow-up] Return value of SendAlerts Bug 17446: Typo seleted Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel Mark Tompsett (1): Bug 17324: Deal with branchcode NULL issue Mason James (1): Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default Mirko Tietgen (1): Bug 17085 - Specify libmojolicious-perl min version Nick Clemens (2): Bug 17392 - opac/svc/overdrive_proxy is not plack safe Bug 17154 (QA followup) replace tabs with spaces Rafal Kopaczka (1): Bug 17245: Untranslatable abbreviated names of seasons. Rodrigo Santellan (1): Bug 17405 Edit record uses Default framework Sophie Meynieux (1): Bug 17154 : Note column is missing on account lines receipt Zeno Tajoli (1): Bug 13405 - System information has misleading information about indexing mode ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 24 16:26:13 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Oct 2016 14:26:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 3e8a30baaf69d7d98229a9ad739d49aa2dbf7b8c (commit) via 78821f7033c5b4d59ddc453f99da4813e027a0e0 (commit) via 1d90c8ad6cb6be6a1c41fc7944e8b34e46894f15 (commit) from 2532a0cc045467c7867bde16a7ae6c1f03de3f59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e8a30baaf69d7d98229a9ad739d49aa2dbf7b8c Author: Julian Maurice Date: Mon Oct 24 14:11:11 2016 +0200 Increment version for 3.22.12 release Signed-off-by: Julian Maurice commit 78821f7033c5b4d59ddc453f99da4813e027a0e0 Author: Julian Maurice Date: Mon Oct 24 14:09:57 2016 +0200 Update release notes for 3.22.12 release Signed-off-by: Julian Maurice commit 1d90c8ad6cb6be6a1c41fc7944e8b34e46894f15 Author: Julian Maurice Date: Mon Oct 24 13:53:45 2016 +0200 Translation updates for Koha 3.22.12 Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/release_notes/release_notes_3_22_12.md | 347 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-pref.po | 784 + misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 286 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-pref.po | 784 + misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 290 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-pref.po | 784 + misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 286 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-pref.po | 784 + misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 286 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 642 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2778 +- misc/translator/po/bg-Cyrl-pref.po | 784 + misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 286 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-pref.po | 784 + misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 286 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 8 +- misc/translator/po/ca-ES-pref.po | 784 + misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 286 +- misc/translator/po/cs-CZ-marc-MARC21.po | 6 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 12 +- misc/translator/po/cs-CZ-pref.po | 788 +- misc/translator/po/cs-CZ-staff-help.po | 11 +- misc/translator/po/cs-CZ-staff-prog.po | 332 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-pref.po | 784 + misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 286 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-pref.po | 784 + misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 286 +- misc/translator/po/de-CH-marc-MARC21.po | 807 +- misc/translator/po/de-CH-marc-NORMARC.po | 17 +- misc/translator/po/de-CH-marc-UNIMARC.po | 90 +- misc/translator/po/de-CH-opac-bootstrap.po | 2109 +- misc/translator/po/de-CH-pref.po | 784 + misc/translator/po/de-CH-staff-help.po |14340 +++++++--- misc/translator/po/de-CH-staff-prog.po | 6213 ++++- misc/translator/po/de-DE-marc-MARC21.po | 807 +- misc/translator/po/de-DE-marc-NORMARC.po | 17 +- misc/translator/po/de-DE-marc-UNIMARC.po | 90 +- misc/translator/po/de-DE-opac-bootstrap.po | 2114 +- misc/translator/po/de-DE-pref.po | 784 + misc/translator/po/de-DE-staff-help.po |14339 +++++++--- misc/translator/po/de-DE-staff-prog.po | 6222 ++++- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 2 +- misc/translator/po/el-GR-pref.po | 784 + misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 286 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-pref.po | 784 + misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 286 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-pref.po | 784 + misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 292 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2 +- misc/translator/po/eo-pref.po | 784 + misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 286 +- misc/translator/po/es-ES-marc-MARC21.po | 6 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 20 +- misc/translator/po/es-ES-pref.po | 792 +- misc/translator/po/es-ES-staff-help.po | 2 +- misc/translator/po/es-ES-staff-prog.po | 330 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-pref.po | 784 + misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 286 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-pref.po | 784 + misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 286 +- misc/translator/po/fi-FI-marc-MARC21.po | 130 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 510 +- misc/translator/po/fi-FI-pref.po | 784 + misc/translator/po/fi-FI-staff-help.po | 2788 +- misc/translator/po/fi-FI-staff-prog.po | 3045 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-pref.po | 784 + misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 286 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 2 +- misc/translator/po/fr-CA-pref.po | 784 + misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 292 +- misc/translator/po/fr-FR-marc-MARC21.po | 158 +- misc/translator/po/fr-FR-marc-NORMARC.po | 10 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 10 +- misc/translator/po/fr-FR-opac-bootstrap.po | 81 +- misc/translator/po/fr-FR-pref.po | 814 +- misc/translator/po/fr-FR-staff-help.po | 1293 +- misc/translator/po/fr-FR-staff-prog.po | 1780 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-pref.po | 784 + misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 286 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-pref.po | 784 + misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 286 +- misc/translator/po/hi-marc-MARC21.po | 800 +- misc/translator/po/hi-marc-NORMARC.po | 44 +- misc/translator/po/hi-marc-UNIMARC.po | 336 +- misc/translator/po/hi-opac-bootstrap.po | 1855 +- misc/translator/po/hi-pref.po | 876 +- misc/translator/po/hi-staff-help.po |12415 +++++++-- misc/translator/po/hi-staff-prog.po | 5266 +++- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-pref.po | 784 + misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 286 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-pref.po | 784 + misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 286 +- misc/translator/po/hy-Armn-marc-MARC21.po | 50 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 65 +- misc/translator/po/hy-Armn-pref.po | 806 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 431 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-pref.po | 784 + misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 286 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-pref.po | 784 + misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 286 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-pref.po | 784 + misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 286 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-pref.po | 784 + misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 286 +- misc/translator/po/it-IT-marc-MARC21.po | 768 +- misc/translator/po/it-IT-marc-NORMARC.po | 17 +- misc/translator/po/it-IT-marc-UNIMARC.po | 99 +- misc/translator/po/it-IT-opac-bootstrap.po | 4462 +-- misc/translator/po/it-IT-pref.po | 788 +- misc/translator/po/it-IT-staff-help.po |13792 +++++++-- misc/translator/po/it-IT-staff-prog.po |15137 ++++++---- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-pref.po | 784 + misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 286 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-pref.po | 784 + misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 286 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-pref.po | 784 + misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 286 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-pref.po | 784 + misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 286 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-pref.po | 784 + misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 286 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-pref.po | 784 + misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 286 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-pref.po | 784 + misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 286 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-pref.po | 784 + misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 286 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-pref.po | 784 + misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 286 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-pref.po | 784 + misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 286 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-pref.po | 784 + misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 286 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-pref.po | 784 + misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 286 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-pref.po | 784 + misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 286 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-pref.po | 784 + misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 286 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-pref.po | 784 + misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 286 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-pref.po | 784 + misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 286 +- misc/translator/po/nl-BE-marc-MARC21.po | 1270 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-pref.po | 784 + misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 286 +- misc/translator/po/nl-NL-marc-MARC21.po | 54 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 668 +- misc/translator/po/nl-NL-pref.po | 784 + misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 286 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-pref.po | 784 + misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 286 +- misc/translator/po/oc-marc-MARC21.po |10654 +++---- misc/translator/po/oc-marc-NORMARC.po | 411 +- misc/translator/po/oc-marc-UNIMARC.po | 3453 +-- misc/translator/po/oc-opac-bootstrap.po | 6117 ++-- misc/translator/po/oc-pref.po | 3608 ++- misc/translator/po/oc-staff-help.po | 7991 ++++-- misc/translator/po/oc-staff-prog.po |34092 +++++++++++------------ misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-pref.po | 784 + misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 286 +- misc/translator/po/pl-PL-marc-MARC21.po | 653 +- misc/translator/po/pl-PL-marc-NORMARC.po | 20 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 66 +- misc/translator/po/pl-PL-opac-bootstrap.po | 1908 +- misc/translator/po/pl-PL-pref.po | 784 + misc/translator/po/pl-PL-staff-help.po |13157 +++++++-- misc/translator/po/pl-PL-staff-prog.po | 5812 +++- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-pref.po | 784 + misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 286 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-pref.po | 784 + misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 286 +- misc/translator/po/pt-PT-marc-MARC21.po | 782 +- misc/translator/po/pt-PT-marc-NORMARC.po | 17 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 86 +- misc/translator/po/pt-PT-opac-bootstrap.po | 2011 +- misc/translator/po/pt-PT-pref.po | 789 +- misc/translator/po/pt-PT-staff-help.po |13772 +++++++-- misc/translator/po/pt-PT-staff-prog.po | 5772 +++- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-pref.po | 784 + misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 286 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-pref.po | 784 + misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 286 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-pref.po | 784 + misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 286 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-pref.po | 784 + misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 286 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-pref.po | 784 + misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 292 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-pref.po | 784 + misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 286 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-pref.po | 784 + misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 286 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-pref.po | 784 + misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 286 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-pref.po | 784 + misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 286 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-pref.po | 784 + misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 286 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-pref.po | 784 + misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 286 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-pref.po | 784 + misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 286 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 20 +- misc/translator/po/tet-pref.po | 785 + misc/translator/po/tet-staff-help.po | 6 +- misc/translator/po/tet-staff-prog.po | 306 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-pref.po | 784 + misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 286 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-pref.po | 784 + misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 286 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 2 +- misc/translator/po/tr-TR-pref.po | 784 + misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 292 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 2 +- misc/translator/po/uk-UA-pref.po | 784 + misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 286 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-pref.po | 784 + misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 286 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-pref.po | 784 + misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 286 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-pref.po | 784 + misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 286 +- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-TW-pref.po | 784 + misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 292 +- 563 files changed, 226657 insertions(+), 85038 deletions(-) create mode 100644 misc/release_notes/release_notes_3_22_12.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 26 14:23:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Oct 2016 12:23:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1167-g33ff591 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 33ff59173151dae282a3c787742128991a656290 (commit) via d64de2bd0d4807700993727f3164fac1656c95b8 (commit) via 2ae9f783534e7b0410869aafcb25f0c9dd6b2fa6 (commit) via c541a967d6de9ebac94afa77e23bb99bf523de55 (commit) via 9f91b2c1f18bf3165d6874774819d69541be4d58 (commit) via ae893b792af98961b799d64407922afaef50fa96 (commit) via 0db3058b02a6776452b6a6db11dae40f87276060 (commit) via bbcb2fbeaf0e463dcb7960336f86dee61f1fb4d8 (commit) via 628b78eda61e89499488396b683011a9c97d8309 (commit) via 56e42bba232242ea9cb0fa23928c4d02647cdd97 (commit) via 81a04af27804621609004dc370284413baa5caa2 (commit) via bf1563e60b31244f4ea977eb84954fb8501ed59a (commit) via d2a4c327466f448d2018b1dbf537d9f588d96604 (commit) from c962285e40a9735e6559900fab0d3d619bca0fff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33ff59173151dae282a3c787742128991a656290 Author: Kyle M Hall Date: Wed Oct 26 12:21:58 2016 +0000 Bug 14610 - DBRev 16.06.00.037 Signed-off-by: Kyle M Hall commit d64de2bd0d4807700993727f3164fac1656c95b8 Author: Katrin Fischer Date: Wed Oct 26 13:32:40 2016 +0200 Bug 14610: Follow-up 2 - Fixes typo "Recieve" in the sample notices - Adds new notices to it-IT installer - Turns off feature for existing installations, leaves it on for new installations - Fixes typo "cancelation" - Fixes ids in of new pages - Adds/fixes classes in th elements of tables Signed-off-by: Kyle M Hall commit 2ae9f783534e7b0410869aafcb25f0c9dd6b2fa6 Author: Katrin Fischer Date: Fri Oct 21 02:17:58 2016 +0000 Bug 14610 - Follow-up Patch fixes some smaller problems: - Adds new notices to the it-IT installer (xt/sample_notices.t) - Renames one of the classes used in the table to avoid double up - Fixes POD of Bilbio.pm by removing a doubled up line Signed-off-by: Kyle M Hall commit c541a967d6de9ebac94afa77e23bb99bf523de55 Author: Kyle M Hall Date: Mon Oct 24 13:57:10 2016 +0000 Bug 14610 - Update Schema files Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 9f91b2c1f18bf3165d6874774819d69541be4d58 Author: Kyle M Hall Date: Tue Oct 11 08:46:14 2016 +0000 Bug 14610 [QA Followup] - Fix publishercode issue Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit ae893b792af98961b799d64407922afaef50fa96 Author: Kyle M Hall Date: Tue Oct 11 08:15:37 2016 +0000 Bug 14610 [QA Followup] - Add classes to table headers Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 0db3058b02a6776452b6a6db11dae40f87276060 Author: Kyle M Hall Date: Tue Oct 11 08:12:27 2016 +0000 Bug 14610 [QA Followup] - Add notices to all language files Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit bbcb2fbeaf0e463dcb7960336f86dee61f1fb4d8 Author: Kyle M Hall Date: Wed Sep 14 13:39:19 2016 +0000 Bug 14610 [QA Followup] - Implement staff patron tab Also fixes a few other minor issues Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 628b78eda61e89499488396b683011a9c97d8309 Author: Kyle M Hall Date: Mon May 16 11:21:28 2016 +0000 Bug 14610 - Update opac.css via less Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 56e42bba232242ea9cb0fa23928c4d02647cdd97 Author: Kyle M Hall Date: Wed Oct 7 12:26:37 2015 -0400 Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 81a04af27804621609004dc370284413baa5caa2 Author: Kyle M Hall Date: Wed Oct 7 12:26:14 2015 -0400 Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit bf1563e60b31244f4ea977eb84954fb8501ed59a Author: Kyle M Hall Date: Wed Oct 7 12:23:24 2015 -0400 Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit d2a4c327466f448d2018b1dbf537d9f588d96604 Author: Kyle M Hall Date: Wed Oct 7 12:22:12 2015 -0400 Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 25 +- Koha.pm | 2 +- Koha/ArticleRequest.pm | 223 ++ Koha/{Serial.pm => ArticleRequest/Status.pm} | 32 +- Koha/ArticleRequests.pm | 103 + Koha/Biblio.pm | 196 ++ Koha/Biblios.pm | 2 +- Koha/Item.pm | 46 + Koha/Patron.pm | 67 + Koha/Patrons.pm | 81 + Koha/Schema/Result/ArticleRequest.pm | 265 ++ Koha/Schema/Result/Biblio.pm | 19 +- Koha/Schema/Result/Borrower.pm | 19 +- Koha/Schema/Result/Branch.pm | 19 +- Koha/Schema/Result/Issuingrule.pm | 18 +- Koha/Schema/Result/Item.pm | 19 +- Koha/Template/Plugin/Biblio.pm | 31 + admin/smart-rules.pl | 2 + .../article-request-slip.pl | 52 +- .../article-requests.pl | 22 +- circ/circulation.pl | 6 +- circ/request-article.pl | 111 + .../data/mysql/de-DE/mandatory/sample_notices.sql | 7 + .../data/mysql/en/mandatory/sample_notices.sql | 7 + .../data/mysql/es-ES/mandatory/sample_notices.sql | 7 + .../mysql/fr-CA/obligatoire/sample_notices.sql | 7 + .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 7 + installer/data/mysql/it-IT/necessari/notices.sql | 7 + installer/data/mysql/kohastructure.sql | 34 + .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 13 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 7 + .../data/mysql/ru-RU/mandatory/sample_notices.sql | 7 + installer/data/mysql/sysprefs.sql | 4 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 17 +- installer/data/mysql/updatedatabase.pl | 54 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 6 +- .../prog/en/includes/biblio-view-menu.inc | 7 + .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 + .../prog/en/includes/patron-article-requests.inc | 91 + .../en/modules/admin/preferences/circulation.pref | 43 + .../prog/en/modules/admin/smart-rules.tt | 21 + .../prog/en/modules/catalogue/detail.tt | 19 + .../prog/en/modules/catalogue/results.tt | 4 + .../prog/en/modules/circ/article-requests.tt | 409 +++ .../prog/en/modules/circ/circulation-home.tt | 5 + .../prog/en/modules/circ/circulation.tt | 11 + .../prog/en/modules/circ/request-article.tt | 380 +++ .../intranet-tmpl/prog/en/modules/intranet-main.tt | 9 + .../prog/en/modules/members/moremember.tt | 10 + koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2846 +++++++++++++++++++- .../bootstrap/en/includes/opac-detail-sidebar.inc | 11 + .../bootstrap/en/modules/opac-request-article.tt | 225 ++ .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 + .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 99 + koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 18 + mainpage.pl | 8 + members/moremember.pl | 5 +- ...c-blocked.pl => opac-article-request-cancel.pl} | 25 +- opac/opac-request-article.pl | 87 + opac/opac-user.pl | 3 +- svc/article_request | 63 + t/db_dependent/ArticleRequests.t | 176 ++ tools/letter.pl | 4 + 63 files changed, 6027 insertions(+), 106 deletions(-) create mode 100644 Koha/ArticleRequest.pm copy Koha/{Serial.pm => ArticleRequest/Status.pm} (78%) create mode 100644 Koha/ArticleRequests.pm create mode 100644 Koha/Schema/Result/ArticleRequest.pm copy course_reserves/course-details.pl => circ/article-request-slip.pl (52%) copy rotating_collections/rotatingCollections.pl => circ/article-requests.pl (65%) create mode 100755 circ/request-article.pl create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt copy opac/{opac-blocked.pl => opac-article-request-cancel.pl} (70%) create mode 100755 opac/opac-request-article.pl create mode 100755 svc/article_request create mode 100755 t/db_dependent/ArticleRequests.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 27 15:19:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 27 Oct 2016 13:19:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1169-g9b34b07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9b34b07d62588713405f31481cb363661b1a5d0c (commit) via 12167c57d0608637504a011627a0256e28e515cd (commit) from 33ff59173151dae282a3c787742128991a656290 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9b34b07d62588713405f31481cb363661b1a5d0c Author: Jonathan Druart Date: Tue Oct 4 11:55:25 2016 +0100 Bug 17375: Search by dateofbirth - handle invalid dates Prevent internal software error when searching patron with invalid birth date To reproduce: - Go to Home > Patron - Expand patron search (click on + at the left of the search button) - In drop down 'Search fields', select 'Date of birth' - Enter a valid date (e.g. 11.02.1995 if syspref 'dateformat' is set to dmydot) Result: Search works OK - Enter an invalid date, e.g. 11.02 or abcd... Result: Internal server error - Do a patron search with many results - Use filter on results screen, select 'Date of birth' as search field and enter an invalid date to search (e.g. 'a') Result: Endless message 'Processing' To test: - Apply patch - Repeat steps above - In both cases, you should get "No results" Signed-off-by: Marc V?ron Signed-off-by: Lucio Moraes Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 12167c57d0608637504a011627a0256e28e515cd Author: Jonathan Druart Date: Tue Oct 4 11:55:02 2016 +0100 Bug 17375: Search by dateofbirth - Add tests Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 31 +++++++++++++++++++---------- members/member.pl | 4 ---- svc/members/search | 4 ---- t/db_dependent/Utils/Datatables_Members.t | 23 ++++++++++++++++++--- 4 files changed, 41 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 27 16:04:45 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 27 Oct 2016 14:04:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1172-g239b81c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 239b81c1dd0cfa2e5e1f720ba9b8554536a9bc44 (commit) via 87f21ae2452b4fbeddcc26f8ff2a7427add3710c (commit) via 65ed212fae5fca9d4ce4efe32e373fe5bea10d3c (commit) from 9b34b07d62588713405f31481cb363661b1a5d0c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 239b81c1dd0cfa2e5e1f720ba9b8554536a9bc44 Author: Kyle M Hall Date: Thu Oct 27 14:02:19 2016 +0000 Bug 14874 - DBRev 16.06.00.038 Signed-off-by: Kyle M Hall commit 87f21ae2452b4fbeddcc26f8ff2a7427add3710c Author: Jonathan Druart Date: Tue Oct 4 12:57:13 2016 +0100 Bug 14874: Set default DefaultPatronSearchFields just in case... Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 65ed212fae5fca9d4ce4efe32e373fe5bea10d3c Author: Nick Clemens Date: Sun May 15 10:44:48 2016 -0400 Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches This patch adds a new syspef 'DefaultPatronSearchFields' which defines the fields that should be used when searching for a patron if none are defined. To test: 1 - Aply patch, updatedatabase 2 - Ensure patron search has not changed 3 - Add dateofbirth to new pref 4 - Ensure things work wll 5 - Experiment with adding and removing other fields from borrowers table 6 - prove t/db_dependent/Utils/Datatables_Members.t Tested together with followup. Works as described. Signed-off-by: Marc V?ron Bug 14874 (QA Followup) Fix atomicupdate file name Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 16 +- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 + .../en/includes/circ-patron-search-results.inc | 2 + .../prog/en/modules/admin/preferences/patrons.pref | 4 + t/db_dependent/Utils/Datatables_Members.t | 251 ++++++++++++-------- 7 files changed, 179 insertions(+), 107 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:28:14 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:28:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1173-g2d42269 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2d4226902d20bc0d3bcd696f34d56ac60ee2c5b6 (commit) from 239b81c1dd0cfa2e5e1f720ba9b8554536a9bc44 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d4226902d20bc0d3bcd696f34d56ac60ee2c5b6 Author: Jonathan Druart Date: Tue Oct 25 09:16:56 2016 +0200 Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl If you access reports/issues_stats.pl, you will get Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121 http://localhost:8081/cgi-bin/koha/reports/reports-home.pl Bug 15407 sent objects to the template and the selected method is not defined. The bug had been highlighted by bug 17425 which dies instead of hides the error. Not that the "selected" code was not needed, the different elements of the page never select a specific value. Test plan: Apply this patch and confirm that the error is no longuer displayed. Reproduced. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/reports/issues_stats.tt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:29:19 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:29:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1174-gbfcc7ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bfcc7cad70bfc23163865b2ff39eb592d6d9d152 (commit) from 2d4226902d20bc0d3bcd696f34d56ac60ee2c5b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfcc7cad70bfc23163865b2ff39eb592d6d9d152 Author: Fridolin Somers Date: Thu Sep 29 16:19:48 2016 +0200 Bug 17376 - rebuild_zebra.pl in daemon mode no database access kills the process When running rebuild_zebra.pl in daemon mode, a while loop runs the script for ever. But if something crashes inside the rebuild process, the all daemon crashes. For example when it can not access database. This problem may be temporary so daemon should keep running. This patch add eval around the rebuild process to allow a run to fail without killing the daemon. Also moves the DB handler get inside daemon loop because it is broken is DB stoppes. This is a big issue for indexer running in a systemd service. Test plan : - run rebuild_zebra.pl in daemon mode : /home/koha/src/misc/migration_tools/rebuild_zebra.pl -daemon -z -a -b -x --sleep 30 - stop the database - wait a minute => you see an error on database connexion => the daemon is still running - restart the database - test the indexer by creating a new record (wait for a minute) Signed-off-by: Jacek Ablewicz Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/rebuild_zebra.pl | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:31:42 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:31:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1188-g5d5a150 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5d5a1509d113ed1ca9ff7e4132fa638dc622ae77 (commit) via 3660c451a36db128c143b6388d0d1f34babff4ac (commit) via ec96a0cb3f25f53fbe14f6c93a8d28b48d3b7286 (commit) via 3fa514133b33aca3727111d2ddfdd0bdb3d5d639 (commit) via e31eb08e29f637f90d095df31388bf64f2b685a9 (commit) via c042307db35f59fe2dca8d8fa214be7b39b0277e (commit) via ad800ce36e07915628602c4f6ba2ccf83bacdd16 (commit) via 73b85e98755e075044db72b973cb3ebd6c0f4891 (commit) via 4384e081968c7dd9c95c34d78bda2eba199a3243 (commit) via 096b6c3938d060ab973e76f6840bd26ec8ef26cd (commit) via 2cdec7ff9178fd8f70b5885b7c2936ddf09e69f7 (commit) via 34eb4c1fa95ea14047413436b8df42299d029ca4 (commit) via 285ac7a31eb50262af9c6a51502630ba150b14fa (commit) via 357a69b0e174c813ef52d1ee7f47cd810c76938d (commit) from bfcc7cad70bfc23163865b2ff39eb592d6d9d152 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d5a1509d113ed1ca9ff7e4132fa638dc622ae77 Author: Kyle M Hall Date: Fri Oct 28 11:30:38 2016 +0000 Bug 14598 - DBRev 16.06.00.039 Signed-off-by: Kyle M Hall commit 3660c451a36db128c143b6388d0d1f34babff4ac Author: Marcel de Rooy Date: Fri Oct 28 09:54:20 2016 +0200 Bug 14598: [QA Follow-up] Small changes [1] Renames the dbrev version to XXX; adding a my for $sth, although not strictly necessary it feels better. [2] Circulation.t stumbles over: Undefined subroutine &C4::Circulation::GetItem called at ... line 1283. Somehow this is related to use_ok instead of a regular use. Worked around this by require_ok and adding a regular use. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ec96a0cb3f25f53fbe14f6c93a8d28b48d3b7286 Author: Jonathan Druart Date: Thu Apr 7 12:03:49 2016 +0100 Bug 14598: Fix warning from effective_itemtype Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 3fa514133b33aca3727111d2ddfdd0bdb3d5d639 Author: Tomas Cohen Arazi Date: Wed Apr 6 11:34:26 2016 -0300 Bug 14598: (QA followup) use deleted{items|biblioitems} during upgrade If the 'statistics' table contains circulation information about items that are no longer on the DB it will raise a warning. This patch makes the updatedatabase.pl script use the deleteditems and deletedbiblioitems tables to get information for those items on the statistics table. To reproduce: - Have your sample DB contain some circulation data on the statistics table - Make sure some of them have NULL itemtype: > UPDATE statistics SET itemtype = NULL WHERE type='return'; - Check the upgrade query catches them: > SELECT s.itemnumber, i.itype, b.itemtype FROM ( SELECT DISTINCT itemnumber FROM statistics WHERE ( type = "return" OR type = "localuse" ) AND itemtype IS NULL ) s LEFT JOIN ( SELECT itemnumber,biblionumber, itype FROM items UNION SELECT itemnumber,biblionumber, itype FROM deleteditems ) i ON (s.itemnumber=i.itemnumber) LEFT JOIN ( SELECT biblionumber, itemtype FROM biblioitems UNION SELECT biblionumber, itemtype FROM deletedbiblioitems ) b ON (i.biblionumber=b.biblionumber); +------------+-------+----------+ | itemnumber | itype | itemtype | +------------+-------+----------+ | 732 | BK | BK | | 731 | BK | BK | +------------+-------+----------+ 2 rows in set (0.00 sec) - Delete the items, and some biblio too. - Re-run the query => SUCCESS: Same results - Go reset to NULL the itemtypes > UPDATE statistics SET itemtype = NULL WHERE type='return'; - Run the updatedatabase.pl script: $ sudo koha-shell koahdev ; cd kohaclone $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: No warnings Note: It is possible that on production sites, if the sysadmin is cleaning the deleted{items|biblioitems|biblio} tables, there will be warnings. This is expected as they need to know some data lacks information. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit e31eb08e29f637f90d095df31388bf64f2b685a9 Author: Tomas Cohen Arazi Date: Fri Apr 1 12:25:39 2016 -0300 Bug 14598: (followup) Remove unused and non-existent C4::ItemType include Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit c042307db35f59fe2dca8d8fa214be7b39b0277e Author: Kyle M Hall Date: Tue Jan 19 14:34:20 2016 +0000 Bug 14598 [QA Followup] - Update localuse statistics also Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ad800ce36e07915628602c4f6ba2ccf83bacdd16 Author: Kyle M Hall Date: Tue Jan 12 16:04:55 2016 +0000 Bug 14598 [QA Followup] - Make unit test pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 73b85e98755e075044db72b973cb3ebd6c0f4891 Author: Kyle M Hall Date: Fri Dec 18 14:59:02 2015 +0000 Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4384e081968c7dd9c95c34d78bda2eba199a3243 Author: Kyle M Hall Date: Fri Nov 20 14:23:22 2015 +0000 Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 096b6c3938d060ab973e76f6840bd26ec8ef26cd Author: Brendan A Gallagher Date: Thu Nov 19 21:13:05 2015 +0000 Bug 14598 - QA Followup touching CanBookBeIssued subroutine Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 2cdec7ff9178fd8f70b5885b7c2936ddf09e69f7 Author: Tomas Cohen Arazi Date: Tue Sep 1 11:52:17 2015 -0300 Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 34eb4c1fa95ea14047413436b8df42299d029ca4 Author: Kyle M Hall Date: Mon Jul 27 11:16:56 2015 -0400 Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 285ac7a31eb50262af9c6a51502630ba150b14fa Author: Tomas Cohen Arazi Date: Mon Jul 27 11:40:38 2015 -0300 Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 357a69b0e174c813ef52d1ee7f47cd810c76938d Author: Tomas Cohen Arazi Date: Sun Jul 26 02:05:16 2015 -0300 Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 33 ++-- C4/Items.pm | 45 ++--- Koha.pm | 2 +- Koha/Schema/Result/Item.pm | 2 +- installer/data/mysql/updatedatabase.pl | 51 ++++++ t/db_dependent/Circulation.t | 17 +- t/db_dependent/Circulation/Returns.t | 284 +++++++++++++++++++++++++++----- t/db_dependent/Items.t | 86 +++++++--- 8 files changed, 405 insertions(+), 115 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:45:40 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:45:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1189-gdbab260 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dbab260afccc04fac8d088839d6017242c818917 (commit) from 5d5a1509d113ed1ca9ff7e4132fa638dc622ae77 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dbab260afccc04fac8d088839d6017242c818917 Author: Fridolin Somers Date: Wed Aug 24 11:44:55 2016 +0200 Bug 16935 - launch export_records.pl with deleted_barcodes param fails When launching misc/export_records.pl with this command line : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/koha.mrc You get this error message : DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 4 [for Statement " ( SELECT DISTINCT barcode FROM deleteditems WHERE deleteditems.biblionumber = ? "] at misc/export_records.pl line 189. This is because of a '(' after 'q|', looks like a typo. Also, this patch removes useless var $q. Test plan : - Delete an item with barcode - Without patch, run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/koha.mrc => You get dirty MySQL - Without patch, run the same command => No error and the file is generated Signed-off-by: Nicolas Legrand Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/export_records.pl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:46:30 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:46:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1190-gd08076e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d08076e7e55a7c78a7ab3d79c33151dd4c469101 (commit) from dbab260afccc04fac8d088839d6017242c818917 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d08076e7e55a7c78a7ab3d79c33151dd4c469101 Author: Owen Leonard Date: Mon Oct 10 08:10:29 2016 -0400 Bug 17417 [Revised] Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from

to

(because news items might contain

and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc Revision for QA removes an extra

from elsewhere in the template to make the validator return no errors. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:47:06 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:47:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1191-ge17209d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e17209de48f3c9d3184dfd430d882a4e8f8d5d4f (commit) from d08076e7e55a7c78a7ab3d79c33151dd4c469101 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e17209de48f3c9d3184dfd430d882a4e8f8d5d4f Author: Josef Moravec Date: Tue Oct 18 00:03:08 2016 +0000 Bug 17434: Moremember displaying primary and secondary phone number twice Test plan: 1) Create patron category with category code "P" and create a patron with this category 2) Fill in either the primary or other phone number 3) Go to patron details page (moremember.pl) => without patch you see primary/other phone duplicated => with patch you should see the number only once as expected Signed-off-by: Lucio Moraes Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ---- 1 file changed, 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:50:01 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:50:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1192-gf74e467 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f74e467550c4d6f6e8e9becdc61b7df572de5f09 (commit) from e17209de48f3c9d3184dfd430d882a4e8f8d5d4f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f74e467550c4d6f6e8e9becdc61b7df572de5f09 Author: kohamaster Date: Wed Oct 12 16:17:04 2016 +0200 Bug 17435: Gives ability to display stocknumber in search results Adds stocknumber to data provided for xslt transformation Test plan : 1) go to Administration module, MARC default frameworks and add, if not already done, a stocknumber subfield (a priori under the 995 tag). It will be linked to items.stocknumber in the koha.link zone of Advanced constraints section. 2) edit an item in staff interface and add a number in the stocknumber field. 3) Edit the xslt opac Results file that you are using and customize it. For a basic test, you can just replace "itemcallnumber" occurrences by "stocknumber". 4) make a search in a way to get several results including the title from which you modified an item. 5) You will see the added stocknumber displayed (between square brackets in the default xslt). Same can be done through staff interface and staff xslt files. Olivier Crouzet Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/XSLT.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:51:38 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:51:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1207-g0bc8f1f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0bc8f1fd462c4bf9fc37af883c9fb776ab9a0f85 (commit) via 00ea6fb5d147ac2407e4f0cc4e3b42dcf8f6b5c7 (commit) via a27b57c32715739a25c69c3ea7b33ea7356a68d4 (commit) via 337be9f10e07020fd1673ab70836a41f974c8aeb (commit) via eb000bbcdc87cb1898da1e0e0960a72cb93c1bed (commit) via 085a2c4834d01d4f223a62482005e3e60250e259 (commit) via 385563ca48dbab787a8a9921a162df79909ab05a (commit) via f4ef34c13603e8f373451b2739dd4528f8aba6df (commit) via 311f6b400b1783dba49950c427832aa46857bef1 (commit) via 9346aabd1317c7ca546e3c30a4215adf576022ec (commit) via 03e654ee2e5763f556372747a50996acb2bdaa87 (commit) via 4ed68d1e71f6ab84aa49e59411dfe7bf247b3be8 (commit) via 7b10c7ccb613ec969782b801d946b049756e992d (commit) via 0c1413d0ff4b26aeddbcdd760ac5ed941af1b72c (commit) via caf0a0200566091d4294eb552efcbe3c1a59775e (commit) from f74e467550c4d6f6e8e9becdc61b7df572de5f09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0bc8f1fd462c4bf9fc37af883c9fb776ab9a0f85 Author: Katrin Fischer Date: Mon Oct 24 14:45:18 2016 +0200 Bug 6934: Fix tiny capitalization issue missed before Account Management Fee Signed-off-by: Kyle M Hall commit 00ea6fb5d147ac2407e4f0cc4e3b42dcf8f6b5c7 Author: Bouzid Fergani Date: Thu Sep 29 12:43:39 2016 -0400 Bug 6934 - Fix problem C4::Branch::GetBranchesLoop not exist Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit a27b57c32715739a25c69c3ea7b33ea7356a68d4 Author: Bouzid Fergani Date: Thu Aug 4 14:56:33 2016 -0400 Bug 6934: rename active transaction with All payments to the library and grouping in it the relevant account types 'Pay' 'C' rename Patron carnumber on Patron card number fix src databales.js Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 337be9f10e07020fd1673ab70836a41f974c8aeb Author: Bouzid Fergani Date: Thu Jul 28 09:38:01 2016 -0400 Bug 6934: fix errors pointed out by the QA script Also fix forbidden patterns in koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit eb000bbcdc87cb1898da1e0e0960a72cb93c1bed Author: Hector Castro Date: Fri Jul 22 09:12:47 2016 -0600 Bug 6934: Fix the href for datables in link rel stylesheet Fix the new path for 'datatables.css' Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 085a2c4834d01d4f223a62482005e3e60250e259 Author: Bouzid Fergani Date: Tue Jul 19 14:56:41 2016 -0400 Bug 6934: Make CSV header column translatable and add total amounts in csv file Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 385563ca48dbab787a8a9921a162df79909ab05a Author: Bouzid Fergani Date: Tue Jul 19 12:05:14 2016 -0400 Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit f4ef34c13603e8f373451b2739dd4528f8aba6df Author: Katrin Fischer Date: Thu Apr 28 19:58:32 2016 +0200 Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 311f6b400b1783dba49950c427832aa46857bef1 Author: remi Date: Tue Apr 19 12:11:50 2016 -0400 Bug 6934: fixed encoding issue Signed-off-by: Hector Castro Encoding issue fixed Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 9346aabd1317c7ca546e3c30a4215adf576022ec Author: remi Date: Fri Mar 4 16:13:14 2016 -0500 Bug 6934: second fix to calendars Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 03e654ee2e5763f556372747a50996acb2bdaa87 Author: remi Date: Fri Mar 4 15:10:57 2016 -0500 Bug 6934: Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 4ed68d1e71f6ab84aa49e59411dfe7bf247b3be8 Author: remi Date: Thu Mar 3 11:14:12 2016 -0500 Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 7b10c7ccb613ec969782b801d946b049756e992d Author: genevieve Date: Fri Nov 13 11:50:01 2015 -0500 Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 0c1413d0ff4b26aeddbcdd760ac5ed941af1b72c Author: genevieve Date: Tue Sep 15 11:18:49 2015 -0400 Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit caf0a0200566091d4294eb552efcbe3c1a59775e Author: simith Date: Wed Aug 27 14:36:13 2014 -0400 Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home ? Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../csv_headers/reports/cash_register_stats.tt | 1 + .../prog/en/includes/reports-menu.inc | 1 + .../prog/en/modules/reports/cash_register_stats.tt | 303 ++++++++++++++++++++ .../en/modules/reports/csv/cash_register_stats.tt | 14 + .../prog/en/modules/reports/reports-home.tt | 9 +- reports/cash_register_stats.pl | 188 ++++++++++++ 6 files changed, 512 insertions(+), 4 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/reports/csv/cash_register_stats.tt create mode 100755 reports/cash_register_stats.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:56:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:56:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1218-g2354e41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2354e41b6191d44be1d1e9e8830359335b3b87d6 (commit) via cf9efd7312630ce318ab1457654a56ad06e8e931 (commit) via 1aa88636a6af0d10ac1df01ca41ce3a6eb8bbc81 (commit) via 28ef209c81c5ba21ffd7800e0b94ced051c8c8d2 (commit) via f6bdc2f9378c0f2f932150f75c43fe28b96eb37e (commit) via f8472e1686c9822768a38202f62eb98bfc11da31 (commit) via 1e120924c2bfd11c4e0bf4a8479897d6cc2cf921 (commit) via 0ca7ac9dd5726bf8f39d3e28eda9a466ac12ff4c (commit) via fd97c08ee327d8a4d35a06708e16d1344af8af3a (commit) via 0f72535232d9d5165c0e3dd9e158652cf3504be0 (commit) via 9af64aa7d5739c0160fe484958921f1294955fb5 (commit) from 0bc8f1fd462c4bf9fc37af883c9fb776ab9a0f85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2354e41b6191d44be1d1e9e8830359335b3b87d6 Author: Kyle M Hall Date: Fri Oct 28 11:54:58 2016 +0000 Bug 5260 - DBRev 16.06.00.040 Signed-off-by: Kyle M Hall commit cf9efd7312630ce318ab1457654a56ad06e8e931 Author: Jonathan Druart Date: Thu Oct 20 09:07:34 2016 +0100 Bug 5260: Use post params instead of get to avoid putting op=email in the browser history Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1aa88636a6af0d10ac1df01ca41ce3a6eb8bbc81 Author: Jonathan Druart Date: Thu Oct 20 08:58:05 2016 +0100 Bug 5260: simplify script and error handling No need to redirect, just sent the params to the template directly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 28ef209c81c5ba21ffd7800e0b94ced051c8c8d2 Author: Jonathan Druart Date: Thu Oct 20 08:54:50 2016 +0100 Bug 5260: Insert the new letter for existing installs Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f6bdc2f9378c0f2f932150f75c43fe28b96eb37e Author: Jonathan Druart Date: Thu Oct 20 08:54:21 2016 +0100 Bug 5260: make tests pass even without patron cat 'PT' Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f8472e1686c9822768a38202f62eb98bfc11da31 Author: Katrin Fischer Date: Wed Oct 19 23:52:21 2016 +0200 Bug 5260: QA follow-up - Add sample ACQORDER notice to sample notices Adds the new notice ACQORDER to all web installers. Verify by testing the SQL contains no errors and by running: perl xt/sample_notices.t NOTE: - de-DE is already translated, others are in English. - xt/sample_notices.t doesn't check fr-CA yet. I didn't fix this here as the file is missing other notices as well which should be fixed separately. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1e120924c2bfd11c4e0bf4a8479897d6cc2cf921 Author: Katrin Fischer Date: Wed Oct 19 23:26:22 2016 +0200 Bug 5260: QA follow-up: Fix error when no notice template is defined When no notice template ACQORDER was defined, you'r receive a false positive "email sent" message. Now it will display a specific error message instead. Also includes 2 unit tests to test for the warn and new error code. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0ca7ac9dd5726bf8f39d3e28eda9a466ac12ff4c Author: Katrin Fischer Date: Sun Oct 16 12:56:48 2016 +0200 Bug 5260: Follow-up - Reindenting POD of SendAlerts Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit fd97c08ee327d8a4d35a06708e16d1344af8af3a Author: Katrin Fischer Date: Fri Oct 14 07:19:40 2016 +0000 Bug 5260 - Schema changes Schema changes for new column in the aqcontacts table. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0f72535232d9d5165c0e3dd9e158652cf3504be0 Author: Katrin Fischer Date: Fri Oct 14 12:02:33 2016 +0200 Bug 5260: Unit tests for new functionality in SendAlert Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 9af64aa7d5739c0160fe484958921f1294955fb5 Author: Katrin Fischer Date: Tue Jun 16 00:44:44 2015 +0200 Bug 5260 - Add option to send an order by e-mail to the acquisition module With this patch it will be possible to send order information to the vendor by e-mail. For now this feature can be triggered manually with a button before closing the basket. The order e-mail is based on the acquisition claim feature, but uses a new notice template. Test plan: 1) Vendors A new checkbox "Contact when ordering?" was added to the vendor page. - Add a vendor and/or edit an existing vendor - Verify the new option is saved correctly - Verify the new option displays on the vendor summary page after saving 2) Notices The feature works with a new notice template: ACQORDER It works with the same formatting/fields etc. as the acq claim notice. - Add a new notice template ACQORDER in module 'Claim/order aquisition' - Make sure to use fields from the various offered tables in your notice - Verify it is saved correctly 3) Basket - Turn on LetterLog system preference - Create multiple order lines - Click the 'Send order' button in the toolbar - Verify error or success message - Verify you received the e-mail - Verify there is a new entry with about the sent notice in your action_logs table 4) Regression testing... - Verify order claims still work - Verify serial claims still work - Verify new serial issue notices still work ... (I can provide additional test plans if needed) Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Bookseller/Contact.pm | 13 ++- C4/Letters.pm | 107 +++++++++++++++----- Koha.pm | 2 +- Koha/Schema/Result/Aqcontact.pm | 12 ++- acqui/basket.pl | 34 +++++-- acqui/lateorders.pl | 4 +- acqui/updatesupplier.pl | 4 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 1 + .../data/mysql/en/mandatory/sample_notices.sql | 1 + .../data/mysql/es-ES/mandatory/sample_notices.sql | 1 + .../mysql/fr-CA/obligatoire/sample_notices.sql | 1 + .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 1 + installer/data/mysql/it-IT/necessari/notices.sql | 1 + installer/data/mysql/kohastructure.sql | 1 + .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 1 + .../data/mysql/pl-PL/mandatory/sample_notices.sql | 1 + .../data/mysql/ru-RU/mandatory/sample_notices.sql | 1 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 1 + installer/data/mysql/updatedatabase.pl | 14 +++ .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 28 ++++- .../prog/en/modules/acqui/supplier.tt | 15 ++- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 5 + t/db_dependent/Letters.t | 28 ++++- tools/letter.pl | 4 +- 24 files changed, 224 insertions(+), 57 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 13:57:50 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 11:57:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1228-g6b8f703 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b8f703364c8dcd9a263e9f77596ca0fba1a1bc4 (commit) via 7e619055e697d7d4da2f1082094b8d3ca8a9cb33 (commit) via bab92d51e56ade24c89087ded6163ffa43f53915 (commit) via 13a528f2f3a3630239cc804cd3dcf214cc3412f1 (commit) via 916e9f4619229da80d7d8c45cecb77fc7db61816 (commit) via 9934dae30d19f48e254c8eb1751d051c32f17b4a (commit) via d620bbc8872e9d1737d3d045839c1b1f793802fc (commit) via a3d5b6cd666a8418938ace6507174a054dd7c3f5 (commit) via babc6fbfe9e3ea8ac960609538dfb45da2e79ed9 (commit) via 3b6692bd9500c52ca98a5e007fc20e98806a6255 (commit) from 2354e41b6191d44be1d1e9e8830359335b3b87d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b8f703364c8dcd9a263e9f77596ca0fba1a1bc4 Author: Katrin Fischer Date: Wed Oct 26 18:31:06 2016 +0200 Bug 7679: Follow-up to fix group by hour Grouping by hour does not work with the collates. This patch removes them after talking to Julian on IRC. This partially reverts one of the earlier patches: Bug 7679: Display all table headers (case and accent sensitive) One could argue that this is more of a data problem, than something we should fix/'hide' with code. Signed-off-by: Kyle M Hall commit 7e619055e697d7d4da2f1082094b8d3ca8a9cb33 Author: Katrin Fischer Date: Wed Oct 26 17:41:49 2016 +0200 Bug 7679 - Follow-up for terminology Patch changes "Library" to "Issuing library" and "Patron branch" to "Patron library". It also changes the text of the filters to match the terms and spelling on the form itself. Signed-off-by: Kyle M Hall commit bab92d51e56ade24c89087ded6163ffa43f53915 Author: Julian Maurice Date: Mon Sep 1 17:22:00 2014 +0200 Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "?tudiant" (french) will be in two separate rows/columns too Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 13a528f2f3a3630239cc804cd3dcf214cc3412f1 Author: Julian Maurice Date: Mon Mar 24 11:56:58 2014 +0100 Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 916e9f4619229da80d7d8c45cecb77fc7db61816 Author: Julian Maurice Date: Wed Feb 19 12:44:29 2014 +0100 Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 9934dae30d19f48e254c8eb1751d051c32f17b4a Author: Julian Maurice Date: Wed Feb 5 15:40:34 2014 +0100 Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit d620bbc8872e9d1737d3d045839c1b1f793802fc Author: Julian Maurice Date: Wed Nov 6 08:47:13 2013 +0100 Bug 7679: Group different case values in the same row/column Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit a3d5b6cd666a8418938ace6507174a054dd7c3f5 Author: Julian Maurice Date: Mon Apr 29 15:07:49 2013 +0000 Bug 7679: Fix criteria display Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit babc6fbfe9e3ea8ac960609538dfb45da2e79ed9 Author: Jonathan Druart Date: Mon Oct 29 16:20:36 2012 +0100 Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 3b6692bd9500c52ca98a5e007fc20e98806a6255 Author: Julian Maurice Date: Wed Aug 8 17:02:19 2012 +0200 Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. Found some comments C4::Date that I missed. line prepatch 194/ postpatch 233 seems to be where the major conflict is. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/reports/issues_stats.tt | 104 ++- reports/issues_stats.pl | 824 ++++++++++++-------- 2 files changed, 579 insertions(+), 349 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 14:01:18 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 12:01:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1233-gc7bc14c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c7bc14cead116d7a8737be8da19b688e53049864 (commit) via bad06abf77bdb78fa3089b7a9b37eb69dd68245c (commit) via 0790de1321ef23c3cd5c94560af7e78e91932791 (commit) via 0963dc4da6b77d02ba798a6605685531ddccfcf4 (commit) via 68ced964fd254e7cba67a9b1b867907c557888c4 (commit) from 6b8f703364c8dcd9a263e9f77596ca0fba1a1bc4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c7bc14cead116d7a8737be8da19b688e53049864 Author: Kyle M Hall Date: Fri Oct 28 11:59:55 2016 +0000 Bug 14629 - DBRev 16.06.00.041 Signed-off-by: Kyle M Hall commit bad06abf77bdb78fa3089b7a9b37eb69dd68245c Author: Marcel de Rooy Date: Fri Oct 28 12:30:23 2016 +0200 Bug 14629: [QA Follow-up] Small tidy up Some cosmetic changes as to whitespace and one call less to Normalize. Test plan: Run t/Koha.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 0790de1321ef23c3cd5c94560af7e78e91932791 Author: Nick Clemens Date: Wed Aug 10 18:53:48 2016 +0000 Bug 14629 - (QA Followup) sysprefs.sql changes Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 0963dc4da6b77d02ba798a6605685531ddccfcf4 Author: Nick Clemens Date: Thu Dec 31 16:00:10 2015 +0000 Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. Signed-off-by: Chad Roseburg Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 68ced964fd254e7cba67a9b1b867907c557888c4 Author: Nick Clemens Date: Wed Dec 30 23:14:37 2015 +0000 Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org Signed-off-by: Chad Roseburg Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 ++ C4/Koha.pm | 93 ++++++++++++++++++++ C4/Matcher.pm | 7 +- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 +++ .../en/modules/admin/preferences/cataloguing.pref | 8 ++ t/Koha.t | 19 +++- 8 files changed, 142 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 14:06:59 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 12:06:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1237-gb6e51b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b6e51b685ee8c04d4dfaaf4b4f48f76049bff1c9 (commit) via c8f6794bb104d4f1f597ec6b7f77a8e20372d41f (commit) via 8f436a50759ae4ca64f85ac5035a933a6d094e3f (commit) via ddb1ecb9d8b4a29a3c0360a07aa539d378193747 (commit) from c7bc14cead116d7a8737be8da19b688e53049864 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6e51b685ee8c04d4dfaaf4b4f48f76049bff1c9 Author: Jonathan Druart Date: Wed May 11 14:31:26 2016 +0100 Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel With all patches applied no errors. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit c8f6794bb104d4f1f597ec6b7f77a8e20372d41f Author: Jonathan Druart Date: Wed Feb 10 17:26:35 2016 +0000 Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel Link pops Ok No errors Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 8f436a50759ae4ca64f85ac5035a933a6d094e3f Author: Jonathan Druart Date: Wed Feb 10 16:56:01 2016 +0000 Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel Works Ok. No errors Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ddb1ecb9d8b4a29a3c0360a07aa539d378193747 Author: Jonathan Druart Date: Wed Feb 10 16:06:14 2016 +0000 Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel Both dropdowns Ok No errors Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 134 +------------------- acqui/z3950_search.pl | 18 +-- admin/fieldmapping.pl | 42 ++---- admin/marctagstructure.pl | 24 +--- catalogue/MARCdetail.pl | 21 +-- catalogue/labeledMARCdetail.pl | 10 +- cataloguing/addbiblio.pl | 10 +- cataloguing/addbooks.pl | 15 +-- cataloguing/merge.pl | 16 +-- circ/circulation-home.pl | 8 +- circ/circulation.pl | 3 +- .../prog/en/modules/acqui/z3950_search.tt | 8 +- .../prog/en/modules/admin/fieldmapping.tt | 26 ++-- .../prog/en/modules/admin/marctagstructure.tt | 36 +++--- .../prog/en/modules/catalogue/MARCdetail.tt | 8 +- .../prog/en/modules/catalogue/labeledMARCdetail.tt | 8 +- .../prog/en/modules/cataloguing/addbiblio.tt | 8 +- .../prog/en/modules/cataloguing/addbooks.tt | 8 +- .../prog/en/modules/cataloguing/merge.tt | 12 +- .../prog/en/modules/tools/manage-marc-import.tt | 2 +- reports/guided_reports.pl | 10 +- t/db_dependent/Koha.t | 43 ------- tools/inventory.pl | 9 +- tools/manage-marc-import.pl | 12 +- 24 files changed, 127 insertions(+), 364 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 14:12:20 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 12:12:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1238-g9a77e06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a77e0600e0c87f95c098e67f7fcc53c6491f500 (commit) from b6e51b685ee8c04d4dfaaf4b4f48f76049bff1c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a77e0600e0c87f95c098e67f7fcc53c6491f500 Author: Kyle M Hall Date: Fri Oct 28 12:11:17 2016 +0000 Bug 14629 - Fix # of unit tests Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 16:30:08 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 14:30:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1257-g25adf52 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 25adf52334917ceb6e67109a4041984dc2837e14 (commit) via 9beffec5aac0e42247633f5f4f793f40f11b4216 (commit) via 0fe43b3ad1f797fa502bbeb967c5c76e57774d51 (commit) via ff45a15256a66352b1ab2d32b0cf0e9dc2a9a8ed (commit) via 19398f2777c47acb84dc8c33f9dc4f766e42330e (commit) via 1204a7269f967486a140d1ed611f77a4768a9e3c (commit) via d653e02d32974cda16f7b83a4d7b2f112e526812 (commit) via d8da77bd8b57c1957bffe81df5679c096236e104 (commit) via 36fb4a34a67abea080045fab30ac1aa81cd8f786 (commit) via 2a1b68295256852b080ff699283e6cf29e34b9a6 (commit) via 1a05ec58cd42093dbb4706375069b12ec420be1a (commit) via b8872515ccb15a4519d9533da75383e3a234f2b3 (commit) via 6eaf0c0d201f973722d705b766fb18d217549f3e (commit) via 8f5ee4c91dba7f2c05a574e2e3639a5eeb86ddc6 (commit) via 1c1e6b11f7d09efb18b5f26a5bf45b64bbbfbe18 (commit) via 43f93f2ee822194a215473ddd10d01489cccc7cb (commit) via 7e89301ab2eca57aa13256f9ed4c8351834476e3 (commit) via 42c8019b4dc29211a76f82b6c95855e5601a6345 (commit) via 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 (commit) from 9a77e0600e0c87f95c098e67f7fcc53c6491f500 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25adf52334917ceb6e67109a4041984dc2837e14 Author: Kyle M Hall Date: Fri Oct 28 14:28:40 2016 +0000 Bug 13323 - DBRev 16.06.00.043 Signed-off-by: Kyle M Hall commit 9beffec5aac0e42247633f5f4f793f40f11b4216 Author: Kyle M Hall Date: Fri Oct 28 14:23:24 2016 +0000 Bug 13321 - DBRev 16.06.00.042 Signed-off-by: Kyle M Hall commit 0fe43b3ad1f797fa502bbeb967c5c76e57774d51 Author: Julian Maurice Date: Thu Oct 13 14:48:38 2016 +0200 Bug 13323: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit ff45a15256a66352b1ab2d32b0cf0e9dc2a9a8ed Author: Julian Maurice Date: Mon Feb 1 11:47:17 2016 +0100 Bug 13323: QA fix (trailing whitespace) Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 19398f2777c47acb84dc8c33f9dc4f766e42330e Author: Jonathan Druart Date: Wed Nov 19 17:01:17 2014 +0100 Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 1204a7269f967486a140d1ed611f77a4768a9e3c Author: Jonathan Druart Date: Wed Nov 19 16:59:39 2014 +0100 Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit d653e02d32974cda16f7b83a4d7b2f112e526812 Author: Jonathan Druart Date: Tue Nov 18 17:07:45 2014 +0100 Bug 13324: The fund values should be based on tax included values Now we have a column in DB to easily retrieve the tax included values. So the sum must be done this the _tax_included DB field and not on the "old" field. The old field can be tax excluded or tax included depending the supplier configuration. Test plan: Verify that the values in the acqui home and budgets page are the tax included values. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit d8da77bd8b57c1957bffe81df5679c096236e104 Author: Nick Clemens Date: Thu Oct 27 00:51:42 2016 +0000 Bug 13321 - (QA Followup) Restore standing order functionality Some lines deleted during rebase, restored and updated, tests repaired Signed-off-by: Kyle M Hall commit 36fb4a34a67abea080045fab30ac1aa81cd8f786 Author: Julian Maurice Date: Thu Oct 13 16:05:16 2016 +0200 Bug 13321: Fix table display in invoice page Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 2a1b68295256852b080ff699283e6cf29e34b9a6 Author: Julian Maurice Date: Fri Sep 9 13:45:36 2016 +0200 Bug 13321: Update DBIx::Class schema files Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 1a05ec58cd42093dbb4706375069b12ec420be1a Author: Julian Maurice Date: Mon Sep 5 11:11:44 2016 +0200 Bug 13321: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit b8872515ccb15a4519d9533da75383e3a234f2b3 Author: Alex Arnaud Date: Sat Jun 4 13:46:44 2016 +0200 Bug 13321: Add missing Price TT plugin in orderreceive.tt Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 6eaf0c0d201f973722d705b766fb18d217549f3e Author: Alex Arnaud Date: Fri May 20 14:25:44 2016 +0200 Bug 13321: Adds renaming of gstrate column in kohastructure.sql Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 8f5ee4c91dba7f2c05a574e2e3639a5eeb86ddc6 Author: Jonathan Druart Date: Tue Jan 13 17:03:04 2015 +0100 Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 1c1e6b11f7d09efb18b5f26a5bf45b64bbbfbe18 Author: Jonathan Druart Date: Mon Dec 15 16:32:15 2014 +0100 Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 43f93f2ee822194a215473ddd10d01489cccc7cb Author: Jonathan Druart Date: Wed Nov 19 16:52:01 2014 +0100 Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 7e89301ab2eca57aa13256f9ed4c8351834476e3 Author: Jonathan Druart Date: Mon Nov 17 12:06:09 2014 +0100 Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC). The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 42c8019b4dc29211a76f82b6c95855e5601a6345 Author: Jonathan Druart Date: Fri Nov 14 16:44:27 2014 +0100 Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Author: Jonathan Druart Date: Fri Nov 14 16:10:52 2014 +0100 Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 294 ++++++++++-------- C4/Bookseller.pm | 8 +- C4/Budgets.pm | 20 +- Koha.pm | 2 +- Koha/Schema/Result/Aqbookseller.pm | 8 +- Koha/Schema/Result/Aqorder.pm | 64 +++- acqui/addorder.pl | 8 + acqui/addorderiso2709.pl | 18 +- acqui/basket.pl | 40 +-- acqui/basketgroup.pl | 19 +- acqui/finishreceive.pl | 56 ++-- acqui/invoice.pl | 46 ++- acqui/neworderempty.pl | 4 +- acqui/orderreceive.pl | 64 ++-- acqui/parcel.pl | 39 +-- acqui/pdfformat/layout2pages.pm | 8 +- acqui/pdfformat/layout2pagesde.pm | 8 +- acqui/pdfformat/layout3pages.pm | 60 ++-- acqui/pdfformat/layout3pagesfr.pm | 60 ++-- acqui/supplier.pl | 4 +- acqui/updatesupplier.pl | 4 +- installer/data/mysql/kohastructure.sql | 25 +- installer/data/mysql/updatedatabase.pl | 158 ++++++++++ .../en/includes/csv_headers/acqui/basketgroup.tt | 2 +- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 92 +++--- .../prog/en/modules/acqui/csv/basketgroup.tt | 3 +- .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 54 ++-- .../prog/en/modules/acqui/neworderempty.tt | 10 +- .../prog/en/modules/acqui/orderreceive.tt | 32 +- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 8 +- .../prog/en/modules/acqui/supplier.tt | 12 +- .../prog/en/modules/help/acqui/basket.tt | 2 +- .../prog/en/modules/serials/subscription-detail.tt | 8 +- serials/subscription-detail.pl | 30 +- t/Prices.t | 316 ++++++-------------- t/db_dependent/Acquisition.t | 84 +++--- t/db_dependent/Acquisition/CancelReceipt.t | 9 +- t/db_dependent/Acquisition/Invoices.t | 27 +- t/db_dependent/Acquisition/OrderFromSubscription.t | 12 +- t/db_dependent/Acquisition/StandingOrders.t | 33 +- t/db_dependent/Acquisition/TransferOrder.t | 5 +- t/db_dependent/Bookseller.t | 18 +- t/db_dependent/Budgets.t | 12 +- t/db_dependent/Serials/Claims.t | 4 +- 44 files changed, 988 insertions(+), 802 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 16:44:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 14:44:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1263-g96a112e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 96a112e96103c8392042da90b2104de070a3cf05 (commit) via c15db78d3c26903c557b00a35bba329a4022b569 (commit) via e08639129aec34d2228e08e65a0ef8ba008c6efc (commit) via 29ba2720043b493fc96ed4238a4f2a3a76b9192c (commit) via 217d0df5175b4fbd907b747d3f29bf0a1d6d2c2b (commit) via ef5b32f942506c487834db4fb6db0493be7f0ea2 (commit) from 25adf52334917ceb6e67109a4041984dc2837e14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96a112e96103c8392042da90b2104de070a3cf05 Author: Tomas Cohen Arazi Date: Mon Oct 24 13:03:16 2016 -0300 Bug 17428: (QA followup) Fix community site in swagger file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit c15db78d3c26903c557b00a35bba329a4022b569 Author: Jonathan Druart Date: Mon Oct 24 17:04:11 2016 +0200 Bug 17428: (QA followup) Remove warning Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit e08639129aec34d2228e08e65a0ef8ba008c6efc Author: Martin Renvoize Date: Wed Oct 12 21:31:30 2016 +0000 Bug 17428: [REST] best practice followup This followup alters a few area's to be aligned more closely with RESTfull best practices: * PUT should always be full objects, and not partial updates (use PATCH for partials) * Validate query parameters instead of blindly passing them to the model * Functional Change: Convert filter params from 'equality' to 'starts with' matching * Update tests to check for swagger validation errors instead of koha exceptions * Mark 'id' as readOnly so swagger may prevent, via validation, id changes. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 29ba2720043b493fc96ed4238a4f2a3a76b9192c Author: Tomas Cohen Arazi Date: Tue Oct 11 13:26:39 2016 +0200 Bug 17428: [REST] Koha::REST::V1::Cities introduced This patch introduces full CRUD for Koha::Cit(ies|y) classes through the REST api. To test, point your browser to /api/v1/cities to use HTTPRequester/Postman (or the like). And of course, run the unit tests: - Apply the patches - Update your minified swagger file: $ cd kohaclone/ $ misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json \ -d api/v1/swagger/swagger.min.json - Run: $ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests should return green, and no warnings. - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 217d0df5175b4fbd907b747d3f29bf0a1d6d2c2b Author: Tomas Cohen Arazi Date: Tue Oct 11 13:25:14 2016 +0200 Bug 17428: [REST] Cities swagger specification This patch adds the swagger definitions for the /cities endpoint Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit ef5b32f942506c487834db4fb6db0493be7f0ea2 Author: Tomas Cohen Arazi Date: Tue Oct 11 13:24:14 2016 +0200 Bug 17428: [REST] Cities endpoint unit tests This patch introduces unit tests for the cities endpoint. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Cities.pm | 136 ++++++++++++ api/v1/swagger/definitions.json | 3 + api/v1/swagger/definitions/city.json | 26 +++ api/v1/swagger/parameters.json | 3 + api/v1/swagger/parameters/city.json | 9 + api/v1/swagger/paths.json | 6 + api/v1/swagger/paths/cities.json | 233 +++++++++++++++++++++ api/v1/swagger/swagger.json | 4 +- api/v1/swagger/x-primitives.json | 5 + t/db_dependent/api/v1/cities.t | 379 ++++++++++++++++++++++++++++++++++ 10 files changed, 802 insertions(+), 2 deletions(-) create mode 100644 Koha/REST/V1/Cities.pm create mode 100644 api/v1/swagger/definitions/city.json create mode 100644 api/v1/swagger/parameters/city.json create mode 100644 api/v1/swagger/paths/cities.json create mode 100644 t/db_dependent/api/v1/cities.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 16:57:33 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 14:57:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1266-g8767434 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 876743402161fe4e5d08116ed8bd2c8b38678181 (commit) via 4be8768a6ed9d134cca7168f9645dcdb57833582 (commit) via 3f7098a02ff8c37a19063420f24fdaca6ba141d8 (commit) from 96a112e96103c8392042da90b2104de070a3cf05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 876743402161fe4e5d08116ed8bd2c8b38678181 Author: Marcel de Rooy Date: Fri Oct 14 08:38:10 2016 +0200 Bug 17356: [QA Follow-up] Minor changes to skeleton.perl Due to the way the snippet is run, there is no need to add a use for C4::Installer or define $dbh (just like $DBVersion). The suggested code is commented (column_exists is not defined). Just as in updatedatabase, CheckVersion is called. The version number does not need to contain 16.06; if we do so, we should update this number each release. The XXX's work just fine. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4be8768a6ed9d134cca7168f9645dcdb57833582 Author: Liz Rea Date: Fri Sep 30 09:57:54 2016 +1300 Bug 17356 - update README Test plan: Look at the README and make sure it makes sense. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 3f7098a02ff8c37a19063420f24fdaca6ba141d8 Author: Jonathan Druart Date: Tue Sep 27 08:30:12 2016 +0100 Bug 17356: Add atomic update .perl skeleton file To show devs how it should be written. Test plan: % cp installer/data/mysql/atomicupdate/skeleton.perl installer/data/mysql/atomicupdate/bug_XXXXX.perl % perl installer/data/mysql/updatedatabase.pl You should see: DEV atomic update: bug_xxxxx.perl Upgrade to 16.06.00.XXX done (Bug XXXXX - description) Signed-off-by: Liz Rea Very good. I'll submit a patch for the readme to make the instructions better. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/atomicupdate/README | 7 +++++++ installer/data/mysql/atomicupdate/skeleton.perl | 14 ++++++++++++++ installer/data/mysql/updatedatabase.pl | 1 + 3 files changed, 22 insertions(+) create mode 100644 installer/data/mysql/atomicupdate/skeleton.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:07:44 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:07:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1267-gb5f9263 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5f9263345b39ef9496f23f11ce119de31db3c6a (commit) from 876743402161fe4e5d08116ed8bd2c8b38678181 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5f9263345b39ef9496f23f11ce119de31db3c6a Author: Kyle M Hall Date: Fri Oct 28 15:06:47 2016 +0000 Bug 13321 / 13323 - Update Schema Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Aqorder.pm | 44 +++++++++++++++++++++++++++++++++++------ 1 file changed, 38 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:26:17 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:26:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1268-ge54186a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e54186a4ddc1e4980fdabf9db5bf410c84dbcad4 (commit) from b5f9263345b39ef9496f23f11ce119de31db3c6a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e54186a4ddc1e4980fdabf9db5bf410c84dbcad4 Author: Jonathan Druart Date: Fri Oct 28 15:22:20 2016 +0000 Bug 13321: Fix tests in Budgets.t Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Budgets.t | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:26:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:26:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1271-g917bdb5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 917bdb5dce7a8f4856858f772bfaa5bdf8303fe9 (commit) via bb3623815022bb841ed96127ad27e6942b079f3d (commit) via 73d9557b13bcd7354436db6980fb23b6c9a124dc (commit) from e54186a4ddc1e4980fdabf9db5bf410c84dbcad4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 917bdb5dce7a8f4856858f772bfaa5bdf8303fe9 Author: Katrin Fischer Date: Thu Oct 27 01:19:06 2016 +0200 Bug 16123: Remove bold formatting from first level fund Signed-off-by: Kyle M Hall commit bb3623815022bb841ed96127ad27e6942b079f3d Author: Bouzid Fergani Date: Wed Oct 12 15:52:25 2016 -0400 Bug 16123 - Add unit tests Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall commit 73d9557b13bcd7354436db6980fb23b6c9a124dc Author: Blou Date: Thu Aug 20 11:52:03 2015 -0400 Bug 16123 - Display budget hierarchy in the budget dropdown menu used when placing a new order When placing a new order, the budget dropdown will display the budget hierarchy. TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2016) 3. Add a fund to this budget (ie : Book) 4. Add a child fund (ie : Adult fiction) You will have this hierarchy : Budget 2016 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction AFTER PATCH Book Adult fiction Dropbown menu is hierarchical as expected. Signed-off-by: Marc V?ron Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 5 +++-- acqui/neworderempty.pl | 4 +--- .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 12 +++++++++--- t/db_dependent/Budgets.t | 8 ++++++-- 4 files changed, 19 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:28:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:28:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1272-geff7d11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eff7d113a0c31e1e1a0d32626d5834b01a902fda (commit) from 917bdb5dce7a8f4856858f772bfaa5bdf8303fe9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eff7d113a0c31e1e1a0d32626d5834b01a902fda Author: Nick Clemens Date: Thu Jun 2 21:24:06 2016 -0400 Bug 16641: Update Novelist in OPAC to use updated call to fetch content To test: 1 - Enable novelistselect content in the opac 2 - Find a record with novelist content, confirm it displays in tabs ro above or below accoring to pref 3 - Find a record without novelist content, note you get an empty tab 4 - Apply patch 5 - Ensure results have not changed for items with content 6 - Ensure tab does not display for item with no content Sponsored by: Walla Walla Public Library (http://www.wallawallapubliclibrary.org/) Los Gatos Library (http://www.losgatosca.gov/42/Los-Gatos-Library) Signed-off-by: Jesse Weaver Internal signoff. Signed-off-by: Dwayne Nance Signed-off-by: Alexis Rodegerdts Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 34 +++++++++++++------- 1 file changed, 23 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:32:41 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:32:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1275-g98596e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 98596e91113ee6a8e95e00cde03408e9c6599f59 (commit) via f9654783e2154bfd95cac92ae9b23615d88538e2 (commit) via 9c6f634469de4364d71bc0eb7520d04ead61fd00 (commit) from eff7d113a0c31e1e1a0d32626d5834b01a902fda (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98596e91113ee6a8e95e00cde03408e9c6599f59 Author: Jonathan Druart Date: Wed Aug 24 09:13:07 2016 +0100 Bug 16912: Update patron category enrolment fees Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit f9654783e2154bfd95cac92ae9b23615d88538e2 Author: Jonathan Druart Date: Tue Jul 12 08:31:01 2016 +0100 Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 9c6f634469de4364d71bc0eb7520d04ead61fd00 Author: Jonathan Druart Date: Tue Jul 12 08:30:13 2016 +0100 Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 44 ++----------- Koha/Patron.pm | 21 +++++- t/db_dependent/Koha/Patrons.t | 55 +++++++++++++++- t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t | 74 ---------------------- 4 files changed, 81 insertions(+), 113 deletions(-) delete mode 100644 t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:33:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:33:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1276-gbd13efd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd13efd8ac1121286dd565c40111b491b61d54cf (commit) from 98596e91113ee6a8e95e00cde03408e9c6599f59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd13efd8ac1121286dd565c40111b491b61d54cf Author: Josef Moravec Date: Thu Jul 21 07:46:23 2016 +0200 Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "?" - should be sorted after "c", "?" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok Signed-off-by: radiuscz Signed-off-by: Jonathan Druart I did not test this patch, but trust in the author and signoffer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 2 +- debian/scripts/koha-create | 2 +- debian/templates/koha-sites.conf | 2 +- etc/zebradb/lang_defs/cs/sort-string-utf.chr | 42 ++++++++++++++++++++++++++ 4 files changed, 45 insertions(+), 3 deletions(-) create mode 100644 etc/zebradb/lang_defs/cs/sort-string-utf.chr hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 17:45:43 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 15:45:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1280-gade5362 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ade53625863175ffdbc3201de847754fdebf838d (commit) via 2c5a05b8be84491250fc1c966b5251076fb9533c (commit) via 5833673157d75ba6fbf2caedf7931283b4eabf7d (commit) via 3d63c64915c02c44a5e1a45e9db66be939fd4dae (commit) from bd13efd8ac1121286dd565c40111b491b61d54cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ade53625863175ffdbc3201de847754fdebf838d Author: Kyle M Hall Date: Fri Oct 28 15:43:20 2016 +0000 Bug 17397 - DBRev 16.06.00.044 Signed-off-by: Kyle M Hall commit 2c5a05b8be84491250fc1c966b5251076fb9533c Author: Jonathan Druart Date: Thu Oct 27 09:37:55 2016 +0200 Bug 17397: Do not display parenthesis if the manager has been deleted Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5833673157d75ba6fbf2caedf7931283b4eabf7d Author: Jonathan Druart Date: Thu Oct 27 09:33:10 2016 +0200 Bug 17397: Simplify code passing the Koha::Object to the template Instead of creating a new array Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3d63c64915c02c44a5e1a45e9db66be939fd4dae Author: Josef Moravec Date: Tue Oct 4 13:57:03 2016 +0200 Bug 17397: Show name of librarian who created circulation message Test plan: 1) Apply the patch 2) Update DB structure 3) Run update_dbix_class_files.pl 4) Select patron for checking out 5) Try to add some circulation and opac messages 6) Note that now there is creator (you ;) ) shown by every message added (with link to creator profile) 7) Try to delete messages to confirm that everything works as expected Signed-off-by: Sonia Bouis Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Patron/Message.pm | 3 +++ circ/circulation.pl | 18 +++++++----------- installer/data/mysql/kohastructure.sql | 4 +++- installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ .../prog/en/modules/circ/circulation.tt | 17 +++++++++-------- 6 files changed, 35 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:36:28 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:36:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1281-gd25840f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d25840fc68bcacd8a8509713549b10753bdcd128 (commit) from ade53625863175ffdbc3201de847754fdebf838d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d25840fc68bcacd8a8509713549b10753bdcd128 Author: Andreas Roussos Date: Sat Sep 10 14:41:54 2016 +0300 Bug 7039 - Link to existing record from result list in acquisition search In the Staff client -> Acquisitions, when creating orders from existing records the result list should link to the existing records so that it's possible to check for existing items. This patch adds that functionality. Test plan: 1) In the Staff client, go to Acquisitions and try to add an order from existing records. 2) Observe that the titles in the Summary column are not hyperlinks. 3) Apply the patch. 4) Repeat step 1), and confirm that the titles are now links pointing to each biblio's details page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:39:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:39:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1282-ge6e09c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e6e09c540fa42c4c3bc3a380494f6ea5637417f3 (commit) from d25840fc68bcacd8a8509713549b10753bdcd128 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e6e09c540fa42c4c3bc3a380494f6ea5637417f3 Author: Jonathan Druart Date: Thu Feb 11 11:26:35 2016 +0000 Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all the authorised value categories. We already have a method in the Koha::AuthorisedValues module to do this job, let's use it! Technical explanations: The new subroutine of the AuthorisedValues TT plugin will allow to get the authorised value categories from the templates. The new html_helpers include file will get rid of the if selected else end statements. Bug 15758 already uses this file, see the commit description for more informations. Test plan: 1/ Create or edit a new fund (aqbudgets.pl), the fields "statistic 1" and "statistic 2" should be correctly filled with the list of authorised value categories 2/ Edit subfields for a biblio and authority framework. The "Authorized value" dropdown list should be correctly filled on both pages 3/ Create new items search fields (from the administration area), same as previously, the authorised value category dropdown list should be correctly filled 4/ Add and edit patron attribute types, check the authorised value category list. Signed-off-by: Aleisha Amohia Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 21 ---------------- Koha/Template/Plugin/AuthorisedValues.pm | 15 ++++++++++++ admin/aqbudgets.pl | 23 ++++-------------- admin/auth_subfields_structure.pl | 19 ++++++++------- admin/auth_tag_structure.pl | 9 +------ admin/items_search_field.pl | 3 --- admin/items_search_fields.pl | 3 --- admin/marctagstructure.pl | 10 ++------ admin/patron-attr-types.pl | 20 ++-------------- .../en/includes/admin-items-search-field-form.inc | 8 +------ .../prog/en/includes/html_helpers.inc | 10 ++++++++ .../prog/en/modules/admin/aqbudgets.tt | 25 +++----------------- .../prog/en/modules/admin/auth_tag_structure.tt | 10 +++----- .../prog/en/modules/admin/items_search_field.tt | 1 + .../prog/en/modules/admin/items_search_fields.tt | 1 + .../prog/en/modules/admin/marctagstructure.tt | 10 +++----- .../prog/en/modules/admin/patron-attr-types.tt | 13 ++-------- .../prog/en/modules/serials/add_fields.tt | 9 ++----- serials/add_fields.pl | 2 -- 19 files changed, 61 insertions(+), 151 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:44:47 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:44:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1283-g607dac6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 607dac69a95e7bcb454661bfde71a45ee20d0155 (commit) from e6e09c540fa42c4c3bc3a380494f6ea5637417f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 607dac69a95e7bcb454661bfde71a45ee20d0155 Author: Tomas Cohen Arazi Date: Thu Oct 20 11:58:32 2016 -0300 Bug 4880: Make koha-remove stop all instance's services This patch makes koha-remove stop all instance's services before attempting to remove the system user, Before this patch, only zebra was stopped. To test: - Run: $ sudo koha-create --created-db favourite_name - Run: $ sudo koha-remove favourite_name => FAIL: koha-indexer is still running for user favourite_name-koha - Run: $ sudo koha-create --created-db another_name $ sudo koha-plack --enable another_name $ sudo koha-plack --start another_name $ sudo koha-indexer --stop another_name $ sudo koha-remove another_name => FAIL: koha-plack is still running for user another_name-koha - Apply the patch - Repeat the previous tests, with new names => SUCCESS: Everything works as expected :-D - Sign off :-D Signed-off-by: Lucio Moraes Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-remove | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:55:22 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:55:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1286-g10b3bb8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 10b3bb8f46098d8e07a3ba03756d581773a5c495 (commit) via 80b4af4d590c2b296f172142c1bec2090338d8d1 (commit) via 0a85759d3335c002233d7c7b07a8f8fcaeb22cae (commit) from 607dac69a95e7bcb454661bfde71a45ee20d0155 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 10b3bb8f46098d8e07a3ba03756d581773a5c495 Author: Kyle M Hall Date: Fri Oct 28 16:49:24 2016 +0000 Bug 17443 - DBRev 16.06.00.045 Signed-off-by: Kyle M Hall commit 80b4af4d590c2b296f172142c1bec2090338d8d1 Author: Josef Moravec Date: Tue Oct 25 18:27:53 2016 +0000 Bug 17443: Added tests Test plan: prove t/db_dependent/Koha/Patrons.t Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0a85759d3335c002233d7c7b07a8f8fcaeb22cae Author: Josef Moravec Date: Thu Oct 13 14:21:48 2016 +0200 Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future Signed-off-by: radiuscz Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Patron.pm | 14 +++++--- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 10 ++++++ .../prog/en/modules/admin/preferences/patrons.pref | 1 + t/db_dependent/Koha/Patrons.t | 35 +++++++++++++++++++- 6 files changed, 56 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:57:56 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:57:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1288-gf9da6f9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f9da6f9739b334a1e14b75a1aa49b2f5569b032e (commit) via a462d46b02c01a25ebffb85d3b1e462813c77de1 (commit) from 10b3bb8f46098d8e07a3ba03756d581773a5c495 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9da6f9739b334a1e14b75a1aa49b2f5569b032e Author: Chris Cormack Date: Wed Oct 19 08:53:26 2016 +1300 Bug 17459: Follow up Adding POD and --userid and --password options 1/ To test, use the same routine as before, with no options. 2/ You should have a user with koha/koha as userid and passwords 3/ Delete that user 4/ Run the script with --userid --password 5/ You should have a user in koha with userid/password set Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit a462d46b02c01a25ebffb85d3b1e462813c77de1 Author: Jonathan Druart Date: Mon Oct 17 18:01:07 2016 +0100 Bug 17459: Add a script to create a superlibrarian user This is for developers: it's quite long (many clics) to create a new superlibrarian user. This new script creates a new user with superlibrarian permissions with the easy to remember credential koha/koha Test plan: perl misc/devel/create_superlibrarian.pl Log in to Koha using koha/koha Signed-off-by: Chris Cormack Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/devel/create_superlibrarian.pl | 103 +++++++++++++++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100755 misc/devel/create_superlibrarian.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 28 18:59:49 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Oct 2016 16:59:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1289-gbbcb19a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bbcb19a7f6403b53b89e08272f811e533d8c9c14 (commit) from f9da6f9739b334a1e14b75a1aa49b2f5569b032e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bbcb19a7f6403b53b89e08272f811e533d8c9c14 Author: Josef Moravec Date: Wed Oct 5 12:42:41 2016 +0200 Bug 17402 Enhance the actions button on serials-search.pl Test plan: 1) Apply the patch 2) Go to serials home page 3) Search for a subscription 4) Ensure you have permission to receive serials 5) In the most right column of table you should see "Receive serial" button with caret button, that should work as trigger form dropdown menu with other options 6) Ensure that all actions work as expected 7) Login with user without permission to receive serials 8) repeat 2-3 9) In the most right column of table you should see normal dropdown mane with label "Actions" and all applicable options 10) Ensure that all actions work as expected Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/serials/serials-search.tt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 31 11:44:39 2016 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 31 Oct 2016 10:44:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.05.00-1290-g6001765 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6001765ba16c5d2f36847254fc8a278023d52022 (commit) from bbcb19a7f6403b53b89e08272f811e533d8c9c14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6001765ba16c5d2f36847254fc8a278023d52022 Author: Kyle M Hall Date: Mon Oct 31 10:41:40 2016 +0000 Bug 17397 - Update Schema Files Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm | 19 +++++++++++++++++-- Koha/Schema/Result/Message.pm | 34 ++++++++++++++++++++++++++++++++-- 2 files changed, 49 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository