[koha-commits] main Koha release repository branch master updated. v16.05.00-1088-g15506a7

Fri Oct 21 17:14:18 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  15506a7569145cf566aab28e1b7639be56058a26 (commit)
       via  c913a3482bcca547d371931261a8831f2cd4ecaf (commit)
       via  af224055de23a25a4cae7f4a7e0e047d3e8780f1 (commit)
       via  7ea9b72c67ea2bb8f7ec11388a3a0c62e8384473 (commit)
       via  1626087562a98b66d24aa190bdf5b3f26b098b09 (commit)
       via  54410ca823e2c9a7f24f63422612ec0af5c4a163 (commit)
       via  b8c824909ebde8a0d4b39d7340dbb32e7c9856b3 (commit)
      from  430a64148207e7c390746060eb9ee31916185738 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 15506a7569145cf566aab28e1b7639be56058a26
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 09:10:52 2016 +0100

    Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField

    The subroutine GetAuthValCodeFromField was only used from
    GetKohaAuthorisedValuesFromField.

    Test plan:
      git grep GetAuthValCodeFromField
    should not return any occurrences.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit c913a3482bcca547d371931261a8831f2cd4ecaf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 12:10:46 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField

    Remove the subroutine, it's no longer in used.

    Test plan:
      git grep GetKohaAuthorisedValuesFromField
    should not return any occurrences.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit af224055de23a25a4cae7f4a7e0e047d3e8780f1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Sep 5 16:12:56 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory

    Before this patch set, the tests in
    t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But
    with the previous patch, it was in 45sec(!)
    To make sure decrease this execution time to what it was before, this
    patch introduces a local to avoid the same query to be executed several
    times.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 7ea9b72c67ea2bb8f7ec11388a3a0c62e8384473
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 12:10:09 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory

    This patch deals with the inventory files calling
    GetKohaAuthorisedValuesFromField.

    Test plan:
      prove t/db_dependent/Items/GetItemsForInventory.t
    should still return green

    Use the inventory tool, on the result page the AV descriptions should
    correctly replace the codes

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 1626087562a98b66d24aa190bdf5b3f26b098b09
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 11:36:40 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field

    This patch adds a new Koha::AuthorisedValues->search_by_marc_field
    method.
    It will permit to replace several subroutine from C4::Koha dealing with
    authorised values.
    It also uses this new methods to replace an occurrence of
    GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv

    Test plan:
      prove t/db_dependent/AuthorisedValues.t
    should return green

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 54410ca823e2c9a7f24f63422612ec0af5c4a163
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 11:28:40 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests

    This patch adds a few tests to C4::Record::marcrecord2csv
    The subroutine was not covered enough to validate that this patch set
    won't add regressions.

    Note that the patch set will fix an issue: If 2 subfields of a field are
    linked to AVs and you want to display them in a CSV, they won't be
    replaced with their descriptions.

    Test plan:
    Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t
    Checkout master and prove marcrecord2csv.t
    Tests should fail
    Checkout the branch with the whole patch set applied
    The tests should pass

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit b8c824909ebde8a0d4b39d7340dbb32e7c9856b3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 10 09:07:26 2016 +0100

    Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s]

    This patch adds the 2 Koha::Object based classes for the
    marc_subfield_structure table

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                                         |   57 +-------------------
 C4/Record.pm                                       |   11 ++--
 Koha/AuthorisedValues.pm                           |   18 +++++++
 Koha/{City.pm => MarcSubfieldStructure.pm}         |    6 +--
 Koha/{Authorities.pm => MarcSubfieldStructures.pm} |   16 ++----
 t/db_dependent/AuthorisedValues.t                  |   34 +++++++++++-
 t/db_dependent/Items/GetItemsForInventory.t        |   12 ++++-
 t/db_dependent/Koha/MarcSubfieldStructures.t       |   57 ++++++++++++++++++++
 t/db_dependent/Record/marcrecord2csv.t             |   42 ++++++++++++++-
 tools/inventory.pl                                 |    5 +-
 10 files changed, 180 insertions(+), 78 deletions(-)
 copy Koha/{City.pm => MarcSubfieldStructure.pm} (86%)
 copy Koha/{Authorities.pm => MarcSubfieldStructures.pm} (80%)
 create mode 100644 t/db_dependent/Koha/MarcSubfieldStructures.t

hooks/post-receive
-- 
main Koha release repository