[koha-commits] main Koha release repository branch master updated. v16.05.00-1105-g8ebffcd

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  8ebffcdb106d46c9f8b1877a086407ecfb1cbae1 (commit)
       via  038ad70fb31b787509c30c6499f3fab77356005a (commit)
       via  4cbbe58ad04f515a39e2cd5e5ed5d92e4388da49 (commit)
      from  947ab63bb761cf2948d80ba590566114a2e48c32 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8ebffcdb106d46c9f8b1877a086407ecfb1cbae1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 14 14:26:58 2016 +0100

    Bug 17445: Move the params check after the authentication check
    
    If the user is not authorised to call this route, we would prefer to
    raise a 403 instead of 400
    
    Note that we wanted to submit tests for this change but the city code
    does not let use do that (we are allowed to list/show cities even
    without any permissions). The patrons.t is not complete enought and the
    holds.t tests do not pass...
    
    Tomas plans to submit tests but we reach the end of the hackfest ;)
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 038ad70fb31b787509c30c6499f3fab77356005a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 14 14:23:20 2016 +0100

    Bug 17445: Just some refactoring
    
    The idea is to make the code more readable moving the code to its own
    subroutine
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 4cbbe58ad04f515a39e2cd5e5ed5d92e4388da49
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Oct 14 08:57:30 2016 +0000

    Bug 17445: Add 'malformed query' error response
    
    This patch adds to the x-mojo-around action code to give a meaningful
    error given a bad query parameter in the query string for a request.
    
    Test Plan
    1) Submit an api request to an existing restful endpoint with no query
    parameters
    2) Confirm the correct response is being given
    3) Submit an api request to an existing restful endpoint with an allowed
    query parameter
    4) Confimr the correct response is being given
    5) Submit an api request to an existing restful endpoint with a
    malformed query paramter
    6) Note the 400 response code and helpful json api body
    
    https://bugs.koha-community.org/show_bug.cgi?id=17445
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/REST/V1.pm |   42 ++++++++++++++++++++++++++++++++++++++----
 1 file changed, 38 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository