[koha-commits] main Koha release repository branch master updated. v16.05.00-1119-gbb99c34

Fri Oct 21 19:35:11 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bb99c34cb75ae7c2a90c0a7b4676058fcf681e6b (commit)
       via  a8907872d13c30b405883ae15aeff896ca0049c4 (commit)
       via  a09f1d75460b85abbf94a151a40cc1643bd4bcec (commit)
       via  cbe96a3b70d88c9c2fd43c8b14dd7b6de1283a08 (commit)
       via  41a19f420d94427d6d69235732021e6f9ba78611 (commit)
       via  0d364dacf6db4b6c4442a264fff4d9de925ab6b2 (commit)
      from  0c9a2ee9da5618764067c3e896a3af5553bf7875 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bb99c34cb75ae7c2a90c0a7b4676058fcf681e6b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Oct 21 17:34:16 2016 +0000

    Bug 17080 [QA Followup] - Fix number of tests

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a8907872d13c30b405883ae15aeff896ca0049c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 14:14:36 2016 +0100

    Bug 17080: categories.checkprevcheckout - use the default value defined in the DBIx::Class schema

    This patch reverts bug 17069

    Test plan:
    Create a new patron category

      prove t/db_dependent/Koha/Patron/Categories.t
    should return green

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a09f1d75460b85abbf94a151a40cc1643bd4bcec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 14:13:10 2016 +0100

    Bug 17080: borrowers.checkprevcheckout - use the default value defined in the DBIx::Class schema

    This line has been added by bug 16917 to define the default value of
    borrowers.checkprevcheckout.
    As this value is defined in the DBIx::Class schema, we should not have
    to handle it here.

    Test plan:
    Confirm that this patch does not reintroduced the bug fixed by bug
    16917.

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit cbe96a3b70d88c9c2fd43c8b14dd7b6de1283a08
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 14:14:03 2016 +0100

    Bug 17080: borrowers table - use default values defined in the DBIx::Class schema

    This patch basically just revert bug 16960 - Fix error on validating the
    registration

    This job is now done by the Koha::Object constructor, no need to clean
    the hash before sending it to AddMember.

    Test plan:
    Make sure there is no regression on bug 16960 (validate a self registration).

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 41a19f420d94427d6d69235732021e6f9ba78611
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 14:12:09 2016 +0100

    Bug 17080: Make C4::Members::AddMember uses Koha::Patron->store

    These calls have been added from commit e196f19 (Bug 12633: Remove SQLHelper
    in C4::Members) which added a TODO:
    "This patch replaced the calls to SQLHelper to use DBIX::Class.
    TODO: Move them to Koha::Borrower."

    This is now done by this patch: instead of calling DBIx::Class directly
    we use Koha::Patron

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 0d364dacf6db4b6c4442a264fff4d9de925ab6b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 8 14:13:40 2016 +0100

    Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new

    Recently we face the same issue on different modules after we moved them to the
    Koha namespace using Koha::Object of using DBIx::Class directly.

    1/ Koha::Patron::Modification on bug 16960 comment 14 and 15
    2/ Koha::Patron::Category from bug 17069
    3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917

    If a DB column is defined as NOT NULL and has a default value, the DBIx::Class
    $rs->update_or_insert method won't use the default value if the column name
    has been passed to the constructor.

    We do that almost everywhere as we retrieve the data from the HTML forms without
    checking/cleaning them.

    There are several ways to fix that:
    1/ Continue to fix them case by case (what we did for the recent issues)
    2/ Try to fix them globally (existing ones and the next ones)

    This patch propose a global solution to avoid future issues of this kind.

    The idea is not to pass the undefined values which cannot be nullable to the
    DBIx::Class constructor.

    Tested all patches together. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                    |    7 ++++---
 Koha/Object.pm                   |   13 +++++++++++--
 Koha/Patron/Category.pm          |    7 -------
 opac/opac-registration-verify.pl |    5 -----
 t/db_dependent/Koha/Objects.t    |   14 +++++++++++++-
 5 files changed, 28 insertions(+), 18 deletions(-)

hooks/post-receive
-- 
main Koha release repository