[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.04-94-gff043fb
Git repo owner
gitmaster at git.koha-community.org
Sat Oct 22 15:22:44 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via ff043fb6675d48506db8d50dd65f4d98cbdff91a (commit)
via f4b6b70f70b65bdcd948f6880f779b66c02a1ded (commit)
via a8dbb0cae8c5ca7e36ef9a2a3f2dc6b4474e64bd (commit)
via 14d5f19b9ee100c81b33414ffd58eac668c08823 (commit)
via 5c324d8201fff6e3a727c95e182ad32b78ccf715 (commit)
via f3889059133d5e9933325c98e172d4d0b1e69c11 (commit)
via 41e12f0af2149c2b858dc63fd6242854f2da444d (commit)
via 6b02b7404dbaf4a9c266cdc6a23ddba829ffdf81 (commit)
via 14b662558019a4b3c1ff3923a8455f43fc878233 (commit)
via c65810e9e24ac0d2d6b7a66a5de6ff849efcbbe8 (commit)
via 106c66eee67be65246ee50ea59a4c0f27acf7e7e (commit)
via 8659bad629fcdfb5bb612ad21ce0bcb0f70a74bd (commit)
via e25934f6cdb1eaae0fbc9be15afe55a3ee2ad51a (commit)
via 90e9ab941eb47b0be4f859c45d394575324b5fc7 (commit)
via afd505b5e9ab8f6ffe82e7edecab6924dbd2e511 (commit)
via a0c7f81f0ce58d5c532c0b7b2fc575f19e711535 (commit)
via 6490df198c18fc99ee289f0b9abe1e05936d80d2 (commit)
via 2a62a9a18cc3a36288e6abf3586a7e606e6e07db (commit)
via f620fbe0d9ec8c4df258dd3a35b839b466479d52 (commit)
via 537d7d9fa4650aa35b8e20cbaf0cad7f7a4d2ba4 (commit)
via 87d7fafaef82408ee296c5b7f5ca880048807b07 (commit)
via 28eb0a880e2bf249da464f7da75ad409f9ffc919 (commit)
via 18a472e627e8f8b7cec45ffe90f896374d90fb9d (commit)
via 4ee9399028fda3f5b8cfbfd9c43eb50349569e91 (commit)
via ff2b5116e9edb5ce62212a8f25518bc1647b19b9 (commit)
via a61c072f1acb77906843a5be319412f959374bda (commit)
via 4592382e388d7f0ee0467180b50b5630a19c674a (commit)
via 5cf95dc6db4356dd5fbb1d9c46c50652d508a19b (commit)
via 80de7080ef5f3694378c4a909b96ee62866d0b41 (commit)
via 7e6365b5323d60adc949f18fe2efa7ac3d67937e (commit)
via a7741759aa501c8545b6acd97c0a2d851a148c12 (commit)
via 5dced305bbaa54a831bd830f900fc9d29bf3e13d (commit)
via 30e66a5eadbdda679bc71d11415ca31958256b24 (commit)
via 78ce2bcb9f2217d5142a3257ff02ca647dd0ecac (commit)
via aa231539854fe9aa0ef75daca342c8cced0b8150 (commit)
via 3a53760cd1ab7d85b3bfcdfa742cab032a7e545d (commit)
via 78a58175a5f60c3293e0bdbffe3364a6c06844a9 (commit)
via 0e953489908f8fb44bd6173620050054e0a66e71 (commit)
via 2f70fde91a53b5a8e05c99fa51c77ba263e9d38c (commit)
via fc0d4ca25d967ce443b4aa13039d4154b47125ef (commit)
via 8ff0d2fe586a774af234f4f65670fb3dd720bd8f (commit)
via 1c35b86c2e7b7dd00bf677f51d8a141e3c281072 (commit)
via 40a2b8c12150d6fe193ba10c808b47069494157a (commit)
via 051661024ca92a343ad74e2664627c070bb5c66e (commit)
via cb1ee8e3ccbc8bbce47b9db502a90c09e2a6ec3f (commit)
via f3917fc8cb8c49bc85e7d371043cae8bd276063d (commit)
via 11074092311b11b1553eb1fe7cfe169b4a8b6f57 (commit)
via fc42eeba6a66c02459332e257fdb1364fb257270 (commit)
via 3c2bd4ef3b1cc45d955940c1323c2b2c9b05cc4a (commit)
via 26efec07d7344ecf3c29981e735246dec6416bd1 (commit)
via d62b515ef7ead3c77f6776438df11980f6b2028d (commit)
via 6c28248d8f1b8f8413ba2a29fafb0f7f825b8358 (commit)
via 517e4eb553e31dad4d7d49a6c2b2222884423d75 (commit)
via 60ab0769530c190dcd849f15909eed4961aa8a83 (commit)
via 1de610bb63f70b9f4a1e3a8a5683de5d3bb7bb12 (commit)
via 4f5d1faef59d57d33a1e6ce1c7ed28792e00ee43 (commit)
via ee073f00860c90d4a96abc8bc4677aa020a53669 (commit)
via 4b80a676df11ddfd475caac75e1fa674e6c0b203 (commit)
via a121ecbfa1ede24329556eaf51ecce6d4523d753 (commit)
via 20bcc8770ad31629b4ef060b6e6a687932579f43 (commit)
via 6f75e5cc5b87c6a7ba42cea7752adec9bb3952ce (commit)
via 6087cfde3fb98901bf6d3f7d6d98d48eee25149a (commit)
via a133becbfc738dcd327a6422b50e39d95ce1028c (commit)
via 9cfee957dbdba479c96dfdce80095b91a628757b (commit)
via b089121aeb06a722657842a433832330a32098ae (commit)
from 0fc92ab72d1bab7e84df9fc78e3cbd3f2abb3d97 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ff043fb6675d48506db8d50dd65f4d98cbdff91a
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Dec 15 12:07:38 2015 +0100
Bug 17444: Enable exporting by time, not only date
Test plan:
1) Apply the patch
2) Edit a biblio
3) run export_records.pl with date time few minutes in the past
for example: --format=xml --record-type=bibs --date="2016-10-14 10:00:05" --filename="koha.xml"
4) look in the file and cofirm that the right record was exported
5) Try the same but with time after the biblio was edited, it shouldn't be exported
Signed-off-by: radiuscz <radek.siman at centrum.cz>
Bug 17444: Follow-up, don't change the name of parameter "date"
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 947ab63bb761cf2948d80ba590566114a2e48c32)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f4b6b70f70b65bdcd948f6880f779b66c02a1ded
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Oct 14 08:52:54 2016 +0000
Bug 17154 (QA followup) replace tabs with spaces
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 1e17c92905143f6bc8cac38f00256541c7146fa3)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a8dbb0cae8c5ca7e36ef9a2a3f2dc6b4474e64bd
Author: Sophie Meynieux <sophie.meynieux at biblibre.com>
Date: Mon Aug 22 12:02:11 2016 +0200
Bug 17154 : Note column is missing on account lines receipt
When displaying Fines > Account tab for a patron, you can see on screen a Note column that is missing if you click on Print
Test plan :
* Find a patron with accountlines or add them manually (Create manual invoice/credit).
* Be sure some of them got a Note
* Clik on Print fior those lines
Without patch, the printed receipt does not show the Note column
with the patch, the printed receipt shows a Note column and Note content is correctly printed for accountline with a note.
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 734d08c2af16909f96b19003c4cc1d758b74f11d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 14d5f19b9ee100c81b33414ffd58eac668c08823
Author: Marc <veron at veron.ch>
Date: Wed Oct 5 16:08:52 2016 +0200
Bug 17404: Patron deletion page: Fix title and breadcrumb
Title and breadcrumb of patron deletion page (deletemember.pl) say:
"Can't Delete Patron". This should be changed to "Delete patron".
To verify:
- Go to a patron's detail page
- Toolbar : More : Delete
Result: You get a question: "Are you sure...", but title and breadcrumb say:
"Can't Delete Patron" rsp "Cant delete patron"
To test:
- Apply patch
- Repeat steps above.
- Verify that title and breadcrumb display properly, including patron's name
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 9a81a138d45b245b69754f3e61115d5d997510c0)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5c324d8201fff6e3a727c95e182ad32b78ccf715
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 18 17:14:58 2016 +0100
Bug 17411: Remove 3 other occurrences of exit 1
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f1a8ca13028411384847615fbdeeaaedd9703382)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f3889059133d5e9933325c98e172d4d0b1e69c11
Author: Marc <veron at veron.ch>
Date: Thu Oct 6 14:37:14 2016 +0200
Bug 17411 - Change exit 1 to exit 0 in acqui/basket.pl to prevent Internal Server Error
Note: Same situation as in Bug 17403
To test:
- Verifiy that code change makes sense.
Note: Same situation as in Bug 17403
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Remove unecessary comment
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 01636dca2f1bd132fcc8d16f7a91fa4a45a90668)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 41e12f0af2149c2b858dc63fd6242854f2da444d
Author: Marc Véron <veron at veron.ch>
Date: Tue Jun 7 17:29:22 2016 +0200
Bug 16687 - Translatability: Fix issues in Administration preferences
This patch fixes sentence splitting and other translation issues in
file koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
to avoid odd translations.
To test:
- Without patch, open Home > Administration > System preferences
and go to tab 'Administration"
- Apply patch
- Open the same page in a new window and compare the text:
- Verify that no sentences are splitted
- Verify that the text changes do not introduce misunderstandings
and have the same meaning as without patch
Amended for comment #7 2016-07-12/mv
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Rebased to apply on master and re-inserted test (see comment #14) -2016-09-28/mv
Signed-off-by: Michael Kuhn <mik at adminkuhn.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit a5b64708601f58fddf89d328d7f0ed94cfc214f9)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6b02b7404dbaf4a9c266cdc6a23ddba829ffdf81
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 14 10:01:12 2016 +0200
Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel
Position 7 of the leader is better referred to as biblevel.
(Pos 6 is record type.)
At the same time replacing some regex's by simple eq's.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
It seems that bib level in the UNIMARC leader only allows a subset of
the possible combinations for MARC21. This does not have bad side-effects
however in the new code that tests bib level to determine the type tag.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 556a4870d6beced7df52dbbc2ad472769e79e148)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 14b662558019a4b3c1ff3923a8455f43fc878233
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Wed Sep 28 15:29:37 2016 -0600
Bug 16245: RIS export file type incorrect
When exporting lists to a RIS file, the TY field of the RIS file is always
'book' even if the item being exported is a journal or serial.
Since unimarc and marc21 is coded in Koha, just a few references types are
included. This needs a much better code.
This bug changes only TY BOOK result. Other resources needs a case by case
basis.
To test:
-In advanced search limit by itemtype (books, music, continue resources, etc).
-Search and save result in Cart
-Export to RIS Format and notice about the new TY change with all materials
-Export record in bib record details page in OPAC and Intranet.
-Confirm that works as expected.
-Bonus test:
-Try to import the RIS file in http://www.myendnoteweb.com if you
have account or create one.
NOTE: According with previous comment, some values has changed.
Sponsored-by: Universidad de El Salvador
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit a74329af022eeb857e1f936c13274c0e41497472)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit c65810e9e24ac0d2d6b7a66a5de6ff849efcbbe8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 28 14:45:21 2016 +0100
Bug 17368: Update KitchenSinkPlugin.kpz
The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test
if our system plugin is ok.
Currently this plugin is broken because it uses subroutines which have
been removed: GetBranchesLoop and GetBorrowercategoryList
A PR has just been made
(https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2)
This kpz has been generated on top of the following commit:
commit 5d109c9e1a5d3d314b346a529f2059176778d05a
Adapt code for versions > 16.06.00.018
2 subroutines has been removed and the plugin does not work
anymore.
with:
% zip -r KitchenSinkPlugin.kpz Koha
Test plan:
prove t/db_dependent/plugins.t
should now be happy
Signed-off-by: Magnus Enger <magnus at libriotech.no>
prove t/db_dependent/Plugins.t fails before the patch
and passes nicely after applying the patch.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6f5ea70f9a20ee0f30057d91a4a23e7f3c04b77e)
commit 106c66eee67be65246ee50ea59a4c0f27acf7e7e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 11 13:15:27 2016 +0100
Bug 17426: Do not set AutoCommit in tests
git grep AutoCommit t | grep 1
highlights that 1 test use AutoCommit set, it should not
The other change removes the FIXME should has been fixed.
Test plan:
prove t/db_dependent/BackgroundJob.t
t/db_dependent/Patron/Borrower_Discharge.t
should still return green
Signed-off-by: Marc <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ede157e9c09e08b772aaaaacd1a7eb64a2ecc9f6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8659bad629fcdfb5bb612ad21ce0bcb0f70a74bd
Author: Rodrigo Santellan <rsantellan at gmail.com>
Date: Mon Oct 10 04:20:12 2016 -0400
Bug 17405 Edit record uses Default framework
In detail view (catalogue/detail.pl), when clicking on Edit > Edit
record button, the record editor should be opened with the biblio record
framework. It isn't the case. The Default framework is used. Same issue
with Edit > Edit as new (duplicate).
TO TEST:
1. Find a biblio record using a framework which is not the Default one.
2. See the biblio record in detail view (catalogue/detail.pl).
3. Click on Edit > Edit record.
4. Click on Settings => you can see 'Default' as selected framework.
5. Apply the patch.
6. Repeat step 3-4. => the biblio record framework is selected.
7. Repeat 3-4 using Edit > Edit as new (duplicate).
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Added a test plan
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fix the issue, no errors.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f060709df0ed07c0ff3dbc20404fa5b3b2aa8651)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit e25934f6cdb1eaae0fbc9be15afe55a3ee2ad51a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 4 08:29:30 2016 +0100
Bug 17393: Fix non-Latin chars handling in self reg
If you fill the patron self reg with non-latin characters, they will be
encoded with HTML entities (é)
This bug leads to generate a userid with weird behaviors:
é => eacute
ł => x
Test plan:
0/ Do not apply the patch
1/ Set up the Self reg feature
2/ fill surname, fistname with something like "Michał pouéàç"
3/ Save
4/ See the bad encoding/replacement on the screen and look at the data
The accentued chars are replaced with their html representation and the
non-Latin chars with a 'x'
in the DB
5/ Apply this patch
6/ Repeat steps 2, 3
7/ Everything should be ok
8/ Try to make sure this HTML::Entities escape was not useful:
fill surname with "surname <script>alert("xss?")</script>"
Save and look at the data
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 35de8aa1ef07b04cfc7c977f7168cd36b40d7941)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 90e9ab941eb47b0be4f859c45d394575324b5fc7
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Thu Oct 20 08:57:46 2016 -0600
Bug 17477: Duplicating a subfield yields an empty subfield tag
The problem only when clone a textareas in 5XX
Steps to reproduce error:
- On the cataloging screen (basic screen), create a new record
- Go to the 5xx fields
- Put something on the 521$a subfield or other textareas (e.g. 520$u or
583$x)
- Clone the subfield
=> FAIL: The subfield correctly doesn't include the original data,
BUT it doesn't have the subtield tag either.
- Apply patch
- Clean cache browser and reload page
- Repeat steps above
- Verify that works as expected
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit fbe75e66ccb93a6a4d973e3066ca1ebad169a5b6)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit afd505b5e9ab8f6ffe82e7edecab6924dbd2e511
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 18 12:02:25 2016 -0300
Bug 10337: (followup) Upper case MARC flavour
This patch makes the populate_db.pl script upper case what gets passed
with the --marcflavour option switch. This is needed in order for this
to fit ``kohadevbox`` configuration files, and it is harmless for other
uses.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 31cb200e0d97106f6e2a009b4cbbd0a295bbaaf5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a0c7f81f0ce58d5c532c0b7b2fc575f19e711535
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 18 09:47:26 2016 -0300
Bug 10337: (QA followup) Allow choosing MARC flavour
This patch enables the --marcflavour option switch so the user
can specify the desired marc flavour. The code for handling it
was already in place, just not used.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit fab0bc976470ca99646b06b7810954b4e2fd18f1)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6490df198c18fc99ee289f0b9abe1e05936d80d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 17 17:50:50 2016 +0100
Bug 10337: Add a script to populate devs' DBs with sample data
Executing the installer process and inserting all the sample data take a
lot of clics and time.
The idea of this script is to provide a quick way to insert all the
sample data easily to get a working Koha install asap.
Test plan:
- Set your database config to a non-existent DB
- Execute perl misc/devel/populate_db.pl
You will get an error
- Create an empty DB
- Execute perl misc/devel/populate_db.pl
It will insert all the MARC21 sample data
- Execute perl misc/devel/populate_db.pl
You will get an error because the DB is not empty (systempreferences and
borrowers tables)
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 3635e8f82660ced571af592088a369db698101a3)
commit 2a62a9a18cc3a36288e6abf3586a7e606e6e07db
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Sep 28 14:49:32 2016 +0200
Bug 17367 - Showing all items must keep show holdings tab in OPAC details
In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab.
You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1.
Also you can choose which tab is shown by default using syspref opacSerialDefaultTab.
The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items.
This patch corrects by forcing holdings tab when arg viewallitems is defined.
Test plan :
- Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref)
- Select "Subscriptions tab" for syspref opacSerialDefaultTab
- Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx
=> You see Subscriptions tab selected
- Click on Holdings tab
=> You see no items but a link "Click here to view them all"
- Click on this link
=> Without patch you see Subscriptions tab selected
=> Wih patch you see Holdings tab selected and the items
Signed-off-by: Juliette <juliette.levast at iepg.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f1298dc7828757fe9277a5128910335d2d6c0f2c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f620fbe0d9ec8c4df258dd3a35b839b466479d52
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Oct 11 10:00:56 2016 +0200
Bug 17423 - patronimage.pl permission is too restrictive
Bug 14566 added the permission "borrowers" on patronimage.pl.
This perm is too restrictive because circulation pages also uses this page.
I propose to simply use "catalogue" perm.
Test plan
- Set an image to borrower xx
- Create a user with only catalogue permission
- Log with this user
- Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx
=> Without patch you get the page saying you do not have the permission
=> With patch you get the image
- Log out and retest the page patronimage.pl
=> You get 403 error
Signed-off-by: remy <remy.gonzalves at iepg.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e78f81d615a79ad293d599c7395efcabd267662d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 537d7d9fa4650aa35b8e20cbaf0cad7f7a4d2ba4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 13 15:03:55 2016 +0100
Bug 16358: Do not redirect to the editor when deleting records
The "Delete record" button goes to addbiblio.pl?op=delete, which
incorrectly redirects to Rancor when selected.
Test plan:
0/ Enable EnableAdvancedCatalogingEditor
1/ Edit a record
2/ Switch to the Advanced editor
3/ click on "View the record"
4/ Delete the record
=> Without this patch you are redirected to the editor
=> With this patch you are redirected to the advanced search
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ba8ee98e1bb3b18f579c0b122b14d43e88cda2c8)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 87d7fafaef82408ee296c5b7f5ca880048807b07
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Oct 12 11:01:54 2016 +0200
Bug 17430: Make MarkIssueReturned.t create its own data
This patch makes MarkIssueReturned.t use t::lib::TestBuilder to create
the data it needs.
To test:
- On master, have a category with categorycode = C
- Run:
$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> FAIL: primary key problems make the tests fail
- Apply the patch
- Run:
$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests are green!
- Sign off :-D
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit d5ca2d0433b75317c5a2b855ee77372ca93d2223)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 28eb0a880e2bf249da464f7da75ad409f9ffc919
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 14 11:29:44 2016 +0200
Bug 17446: Typo seleted
Built on top of bug 17441
Test plan:
Just have a look at the changes. Trivial.
Git grep seleted. No results.
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f75afef59175933f7e93b04bdcbdcf5180b0b024)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 18a472e627e8f8b7cec45ffe90f896374d90fb9d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 14 11:07:49 2016 +0200
Bug 17441: [QA Follow-up] Return value of SendAlerts
This patch makes the return value of SendAlerts more consistent.
It returns 1 on success, or undef || { error => 'msg' } on failure.
Needed to adjust one test in Letters.t too.
Adjusted one typo along the way (seleted).
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested by running Letters.t.
Also tested SendAlerts from the interface with AutoEmailOpacUser and
memberentry (adding new patron).
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 17e2e6c994655aaa927b2579524022a4f24a8d1d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4ee9399028fda3f5b8cfbfd9c43eb50349569e91
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Oct 13 19:05:48 2016 +0200
Bug 17441 - t/db_dependent/Letters.t fails on Jenkins
Run prove t/db_dependent/Letters.t
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
To improve consistency, adding a follow-up.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ff495c5fa8c58a7762b3494e97d90618d649f7a8)
commit ff2b5116e9edb5ce62212a8f25518bc1647b19b9
Author: Marc <veron at veron.ch>
Date: Fri Oct 7 11:03:45 2016 +0200
Bug 11217: The # in accountlines descriptions makes them un-writeoffable
This patch adds escaping to url params in mambers/pay.pl
To test:
- Apply patch
- Go to Home > Patrons > Manual invoice and create an invoice with a
description containing a #
- Go to tab "Pay fines"
- Write off the fine
Expected result: Fine is written off and does no longer display in pay tab.
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 692014c817b58876042ab03d71bde0c2cce7e571)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a61c072f1acb77906843a5be319412f959374bda
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 29 08:46:49 2016 +0100
Bug 17365: Fix XSS in moremember.pl and memberentry.pl
There are certainly hundred of places where they are not escaped...
Test plan:
Create a patron with "Arun <script>alert('code injection');</script>" in
some of the fields.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 1d0d5f1398687ead3a17cd40f74f879e8ddf9a9d)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4592382e388d7f0ee0467180b50b5630a19c674a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 3 15:23:39 2016 +0100
Bug 17389: Clear logs
Logs are full of:
Use of uninitialized value in substitution (s///) at
C4/ImportExportFramework.pm line 282.
Use of uninitialized value in concatenation (.) or string at
C4/ImportExportFramework.pm line 283.
Some field are NULL in DB, we need to init the value to an empty string
to avoid these warnings.
Note: This fix is not related to the original bug
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Warnings avoided
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit a1dcd2f2e67f2dc998d2eae0fc6097eb9edbb874)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5cf95dc6db4356dd5fbb1d9c46c50652d508a19b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 3 15:15:40 2016 +0100
Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks
Trivial patch, no need to explain anything :)
Test plan:
Export default framework
Export other frameworks
=> The frameworkcode column should contain the framework code
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit a1eeffd8385e5b95ca1d06a8300e5bd42403486a)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 80de7080ef5f3694378c4a909b96ee62866d0b41
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 5 13:26:09 2016 +0000
Bug 17392 - opac/svc/overdrive_proxy is not plack safe
This patch simply replaces the ';' in the param passed to OverDrive
with '&'
To test:
1 - Enable overdrive (requires an account)
2 - Perform an opac search
3 - Note the number of overdrive results reported
4 - Click the link to view the actual overdrive results
5 - Note the result numbers don't match
6 - Apply patch
7 - Repeat 1-4 and note results numbers match and results are relevant
8 - Test a search with a ';' to ensure this patch isn't breaking
searches
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Verified by reading code - couldn't verify using Overdrive.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f28460bdb7cbb6a1261d8c50af6b10ffacf54ef3)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 7e6365b5323d60adc949f18fe2efa7ac3d67937e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 4 19:41:57 2016 +0000
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other
It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.
The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!
Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass
Signed-off-by: Barton Chittenden barton at bywatersolutions.com
Signed-off-by: Dani Elder <dani at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 43418ae9f088f023b1d398ab30faaebb9c00cbf5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a7741759aa501c8545b6acd97c0a2d851a148c12
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 26 19:20:34 2016 +0000
Bug 15388 - Show Syndetics covers by UPC in search results
Syndetics code accepts UPC and OCLC numbers, however, we were only passing this if there
was an ISBN. This patch alters the code to search if either an ISBN or
UPC is present
To test:
Enable syndetics (will need an account)
Search for items with UPCs or OCLC numbers and no ISBN (DVDs)
Note there are no images in search results but there are in details
Apply patch
Note that items with images in details now also have images in results
Signed-off-by: Barbara.Johnson at bedfordtx.gov
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit dbf2f7d6d97686179a1e794e0c74ad8be441a177)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 5dced305bbaa54a831bd830f900fc9d29bf3e13d
Author: Jesse Maseto <jesse at bywatersolutions.com>
Date: Wed Oct 12 17:44:42 2016 +0000
Bug 7143 NEW added Kyle Hall as release manager.
Signed-off-by: Dani Elder <dani at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
(cherry picked from commit 8cb65b367b47ffd9a1a362e7261199fefc3628bb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 30e66a5eadbdda679bc71d11415ca31958256b24
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Tue Oct 11 04:52:13 2016 +0000
Uping DBRev. Bug 17357 - WTHDRAWN is still used in installer files
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
commit 78ce2bcb9f2217d5142a3257ff02ca647dd0ecac
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 27 10:52:17 2016 +0100
Bug 17357: Replace WTHDRAWN with WITHDRAWN in installer files
Some installer files still use WTHDRAWN instead of WITHDRAWN as an AV
category.
Test plan:
git grep WTHDRAWN installer
should not return any results
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit ce076e0e757ff812eba21ee6102e6c44076e5595)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit aa231539854fe9aa0ef75daca342c8cced0b8150
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 27 13:38:34 2016 +0100
Bug 17358: Rename COU with COUNTRY and LAN with LANG
Some installer files use COU and LAN instead of COUNTRY and LANG.
To uniformise these AVs, it would be good to use the same code.
Note that I do not think we should update existing installations
Carefully compared code.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 75a900d55365dc6a8d1396b68329a0679d9dc430)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 3a53760cd1ab7d85b3bfcdfa742cab032a7e545d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 29 10:31:11 2016 +0100
Bug 17372: Standardize Elasticsearch paths
What we currently have:
Koha/ElasticSearch.pm
Koha/ElasticSearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
Koha/SearchEngine/Elasticsearch/Search.pm
What we want:
Koha/SearchEngine/Elasticsearch.pm
Koha/SearchEngine/Elasticsearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
Koha/SearchEngine/Elasticsearch/Search.pm
Test plan:
% git grep -i Koha::ElasticSearch
% git grep ElasticSearch|grep -v Catmandu::Store::ElasticSearch
should not return any result
Do a full reindex and search for records
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit df3df9cf7199c464565742af59bd48006d93cfdf)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 78a58175a5f60c3293e0bdbffe3364a6c06844a9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 29 10:18:27 2016 +0100
Bug 16838: ES - install mappings for new installs
The yaml file is not used to populate ES mapping tables (search_field,
search_marc_map and search_marc_to_field) when doing a fresh install.
We need to insert them, otherwise ES will be unusable.
Test plan:
Create a new install and confirm that the ES tables (search_field,
search_marc_map and search_marc_to_field) are correctly populated.
Bonus points: Use an older DB (prior to 3.23.00.050), execute the
updatedatabase.pl script and confirm that the ES table are correctly
populated
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit a36b6430195310b5198077dd50cdb436ef07ce37)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 0e953489908f8fb44bd6173620050054e0a66e71
Author: Marc <veron at veron.ch>
Date: Wed Oct 5 15:43:29 2016 +0200
Bug 17403: Internal Server Error while deleting patron
This patch fixes a Internal Server Error while deleting patrons.
To reproduce:
- Go to a patron's detail page
- Toolbar : More : Delete
- Confirm "Are you sure you want to delete..."
Result: Internal Server Error
Plack error log:
exited nonzero: 1 at /home/marc/koha/members/deletemem.pl
Note: Patron is deleted
Additional tests: Try to delete yourself, to delete a staff member
without having superlibrarian permission etc.
To test:
- Apply patch
- Re-start plack
- Try to reproduce steps above (with other patron)
Expected result:
No Internal Server Error, Redirect to Home > Patrons
Amended to include all occurences of 'exit 1'
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Good catch Marc
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit b588babdb23bfdc1163864a26c36a61bf8a39ae5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 2f70fde91a53b5a8e05c99fa51c77ba263e9d38c
Author: Andreas Roussos <arouss1980 at gmail.com>
Date: Sat Sep 17 13:44:47 2016 +0300
Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages
In the Staff client, under Circulation > Renew, the message shown after
successful renewal of an item contains broken URLs. This is also true for
the message shown when you try to renew an item that is not checked out.
This patch fixes that.
Test plan:
1) Go to Circulation > Renew, and search for the barcode of a checked-out
item. In the 'Item renewed:' confirmation message, notice how the URLs
for the title and the barcode are broken.
2) Now search for the barcode of an item that is not checked out. In the
'Cannot renew:' message, notice how the URLs are broken here too.
3) Apply the patch.
4) Repeat steps 1) and 2). This time the URLs work fine.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 884e28fab5e4db86dd9f50f2908519a0cd6650d5)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit fc0d4ca25d967ce443b4aa13039d4154b47125ef
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sat Oct 22 12:45:52 2016 +0200
Bug 17088 Quick fix on test
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 8ff0d2fe586a774af234f4f65670fb3dd720bd8f
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sat Oct 22 12:41:21 2016 +0200
Bug 17292 Follow-up, fix typos
- wrong assignation
- reference to 'serials' table rather than 'serial'
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 1c35b86c2e7b7dd00bf677f51d8a141e3c281072
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 4 14:49:19 2016 +0100
Bug 17088: Add tests to cover the changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit bc1e23e1f11e146e282d0e2efa7fd77e2c26d631)
commit 40a2b8c12150d6fe193ba10c808b47069494157a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 16 11:27:05 2016 +0200
Bug 17088: [Follow-up] Use Logger for failed exports
Fixes a TODO for logging unsupported record_type in _get_record_for_export.
Also logs a warning when the record_type parameter is not supplied at all in sub export.
Replaces a warn by a log message about an invalid record for format iso2709.
Also adds a log message about an invalid record for format xml.
Adds a trivial unit test for passing no record_type to export.
Test plan:
See also first patch.
Run t/db_dependent/Exporter/Record.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Also tested the log messages for iso2709 and xml by manipulating
the record_type parameter with:
$params->{record_type}='xx';
before calling _get_record_for_export in Record.pm.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 0eec191ed3ab1ae1bd24972a559d12627b70f681)
commit 051661024ca92a343ad74e2664627c070bb5c66e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 16 10:44:47 2016 +0200
Bug 17088: [Follow-up] Adjust POD in Logger.pm
Not important enough to go on its own.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 44b51ed80224d0361796c1a70cb66bb5096a427c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit cb1ee8e3ccbc8bbce47b9db502a90c09e2a6ec3f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Aug 9 13:08:17 2016 +0000
Bug 17088 - Bad MARC XML can halt export_records.pl
If export_records.pl encounters a record that fails to load correctly as
a MARC::Record the export process will fail and only the records
encountered up to that point will be exported.
Test Plan:
1) Pick a record in your database, and replace the biblioitems.marcxml field with some random characters
2) Export your records using the command:
misc/export_records.pl --format xml --record-type bibs --filename /tmp/biblios.xml
3) Note you get an error and the script ends prematurely
4) Apply this patch
5) Repeat step 2
6) Note the full record set is exported ( except for your bad record )
7) Note an error is still generated for your bad record ( useful for
tracking down bad records ).
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit e72a8ab260abed11b02266d77bc17d831884ed40)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit f3917fc8cb8c49bc85e7d371043cae8bd276063d
Author: Mason James <mtj at kohaaloha.com>
Date: Wed Aug 3 16:32:00 2016 +1200
Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default
to test bug...
1/ make a random user
2/ change to random user
3/ access any zebra database with random user and no authentication
4/ read zebra database
here is a transcript of the bug...
---------------------------
root at xen1:~# adduser bob
root at xen1:~# su -l bob
bob at xen1:~$ cd /var/lib/koha
bob at xen1:/var/lib/koha$ ls
topsecret
bob at xen1:/var/lib/koha$ yaz-client unix:/var/run/koha/topsecret/bibliosocket
Connecting...OK.
Sent initrequest.
Connection accepted by v3 target.
ID : 81
Name : Zebra Information Server/GFS/YAZ
Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031
Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets
Elapsed: 0.001002
Z> base biblios;
Z> find the
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 1130, setno 2
SearchResult-1: term=the cnt=1130
records returned: 0
Elapsed: 0.005518
Z> show
Sent presentRequest (1+1).
Records: 1
[biblios]Record type: USmarc
01824cam a2200397 a 4500
001 000045782309
003 AuCNLKIN
005 20111013213222.0
008 100707s2011 maua 001 0 e
...
---------------------------
5/ apply changes to a Koha instance's config files, that you plan to test
6/ restart zebra for instance
# sudo koha-restart-zebra topsecret
7/ repeat steps 2 and 3, but receive a 'bad user/passwd ' error from zebra
bob at xen1:~$ yaz-client unix:/var/run/koha/topsecret/bibliosocket
Connecting...OK.
Sent initrequest.
Connection rejected by v3 target.
1: code=1011 (Init/AC: Bad Userid and/or Password),
NOTE: this patch currently will only fixes newly created instances, it wont fix existing instances
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Good catch Mason
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f2196a2e4f21a9a294c970a1ad067f5c3d1cb4eb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 11074092311b11b1553eb1fe7cfe169b4a8b6f57
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Sep 18 20:47:33 2016 -0400
Bug 17292: Follow up - tweak to make it pass cleaner
remove a 'my'
next if not defined subscriptions.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 6ff836ab3154a886e0aeedb1152f6caf2e546444)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit fc42eeba6a66c02459332e257fdb1364fb257270
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Sep 12 14:20:19 2016 +0000
Bug 17292 - Use of DBIx in updatedatabase.pl broke upgrade
A recent change in the 'subscription' table structure highlighted a
problem in a DBRev upgrade (3.23.00.006). As it adds a new column, when
upgrading from (say) 3.20.00.000 the code/schema (correctly) expects the
subscription.itemtype column to exist. But it is not created until DBRev
16.06.00.025.
To reproduce:
- Have a clean 3.20.00 DB loaded into kohadevbox
- Checkout current master
- Run:
$ perl installer/data/mysql/updatedatabase.pl
=> FAIL: The upgrade procedure fails due to missing colum.
The solution: rewrite the updatedatabase.pl entry using plain DBI
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit f11f07a703eca7da2d32c105f8c9f4f46f940b6f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 3c2bd4ef3b1cc45d955940c1323c2b2c9b05cc4a
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Sep 20 19:29:28 2016 -0400
Bug 17324: Deal with branchcode NULL issue
In a database update we alter the letter table, making a column
(branchcode) not be able to contain NULL values.
However if it already does, this SQL fails. So before changing the
column we change the NULL values
[Tue Sep 20 19:08:10 2016] updatedatabase.pl: DBD::mysql::db do failed:
Invalid use of NULL value [for Statement "
[Tue Sep 20 19:08:10 2016] updatedatabase.pl: ALTER TABLE letter MODIFY
COLUMN branchcode varchar(10) NOT NULL DEFAULT ''
[Tue Sep 20 19:08:10 2016] updatedatabase.pl: "] at
/home/mtompset/kohaclone/installer/data/mysql/updatedatabase.pl line
12638.
Reproduce:
on an ubuntu 16.04 LTS machine with MySQL 5.7 install git koha
development environment.
...
git checkout -b my_3.18.x origin/3.18.x
drop database koha_library;
create database koha_library;
quit;
web install all sample data
(ignore some issues with sample data, and one with mandatory)
git checkout -b bug_17234 origin/master
git bz apply 17292
git bz apply 17320
git bz apply 17260
git bz apply 17234
web install
Two warning messages are expected output from upgrade process, but
the above message is not.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Did not follow the test plan, but the changes make sense
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 0599ab00768e7d2ee487c6d02a0230d4a2a96d9e)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 26efec07d7344ecf3c29981e735246dec6416bd1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Sat Sep 24 19:25:33 2016 +0000
Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl
The patron search type is hard coded to 'contain' in
circ/circulation.pl.
This causes problems because a mis-scanned cardnumber can bring up the
wrong patron.
The example that our partner gave us involved scanning '1733', which
doesn't match any borrowers when we do a 'start_with' search, but
matches the cardnumber 'p291733'.
If we follow the usage in members/member.pl, we can set searchtype in
HTTP params, which is amenable to fixes in intranetuserjs
Test Plan:
1) Apply this patch
2) Use the checkout search, not changes should be noted
Extra credit:
1) Add javascript to intranetuserjs to add a hidden input named
'searchtype' with the value 'start_with'
2) Checkout searches should now give only results where a searched
field starts with the given string(s)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 56da7be50ada38bab6ec866f5915d55507c7d821)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit d62b515ef7ead3c77f6776438df11980f6b2028d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Sep 6 09:37:14 2016 +0000
Bug 16573 - Update Schema
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 514282d04c4494ca5eee02b18c775db74a6bbb91)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6c28248d8f1b8f8413ba2a29fafb0f7f825b8358
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Sat Oct 22 09:16:44 2016 +0200
DBRev 16.05.04.02
commit 517e4eb553e31dad4d7d49a6c2b2222884423d75
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 16 09:18:19 2016 +0100
Bug 7045: Update default value placeholders for existing installs
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 547b5f95f62a00e360c5cac4e416d30365429fcb)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 60ab0769530c190dcd849f15909eed4961aa8a83
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 16 09:09:53 2016 +0100
Bug 7045: Use <<tag>> for default value placeholders
When adding a biblio, the default value of a MARC subfield defined in
the frameworks can be used as placeholders to set the current date or
the surname of the logged in user (use cases?).
The different placeholders are 'YYYY', 'MM', 'DD', 'user'.
When adding an item, same behavior except that 'user' is not replaced.
This patch makes behaviors consistent between the 2 editors and
surrounds placeholders with << >>
We will now have: <<YYYY>>, <<MM>>, <<DD>> and <<USER>>
Test plan:
Define default values for biblio and item subfields.
Create a bibliographic record and attach it an item.
The default values should be used and replaced if you used placeholders.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 50abf24ff04aae0c9010411fa6e98561c2ccc66f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 1de610bb63f70b9f4a1e3a8a5683de5d3bb7bb12
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Aug 24 21:24:45 2016 +0000
Bug 16035: MARC default bibliographic framework Export fix
This patch makes sure that, if there is no framework code,
$frameworkcode is set to 'default'. This fixes the format issue.
Then, if $frameworkcode = default, an empty string (rather than
null) is passed to the ExportFramework method, as the framework
code in the DB for default codes is "".
To test:
1) Go to Admin -> MARC Bibliographic framework
2) Try to export default framework in all formats, notice the file is
only exported as .ods and is an empty file. Notice warns in intranet
error log.
3) Apply patch and refresh page
4) Confirm exporting default framework works in all formats and
spreadsheet has data
5) Notice warns in error log are gone
6) Confirm export still works for other frameworks
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 705097f938ba9334c21b3e6f006bd7c9ba38763c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4f5d1faef59d57d33a1e6ce1c7ed28792e00ee43
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 6 12:58:31 2016 +0100
Bug 14060: Improve regex to limit year to 4 integers
01/01/01984 should not be considered as a valid date.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit eab75d0aa48759e8f2ec017b643e0ca6f985c937)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit ee073f00860c90d4a96abc8bc4677aa020a53669
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 5 09:16:02 2016 +0100
Bug 14060: Consider an empty string as a valid date
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 61d819caef44700b2b1a85c9c27e47913a165a4f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 4b80a676df11ddfd475caac75e1fa674e6c0b203
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 30 09:56:46 2016 +0100
Bug 14060: Add the datepicker class to dateofbirth
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 08653cca9bd9d5185293c56326ec35a6e875550c)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a121ecbfa1ede24329556eaf51ecce6d4523d753
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 30 09:54:55 2016 +0100
Bug 14060: Force leading zeros on date
If a date does not contain leading zeros for day and month, the date
will be refused.
parseDate function considers 1/1/1990 as a valid date, but our perl code
does not. We must refuse it.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit db3df548b6a6385ea17d2db49f49f8d4c9f2969f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 20bcc8770ad31629b4ef060b6e6a687932579f43
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 26 08:44:06 2016 +0100
Bug 14060: Display date format pattern instead of date format name
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 26fdc96c5ea824b5529da846b63a8e4e62d486e8)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6f75e5cc5b87c6a7ba42cea7752adec9bb3952ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 4 11:03:43 2016 +0000
Bug 14060: Add support for dmydot
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit edd555df4dc40f9ee3f8625240564fcc65c2935f)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 6087cfde3fb98901bf6d3f7d6d98d48eee25149a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 1 17:33:15 2015 +0000
Bug 14060: Force the input to contain a valid date
Before this patch, the user was still allowed to enter a valid date.
Now, if the date is not valid, the input is emptied.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 363e45a5eb89b25e47165bb815d6dc901744f977)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit a133becbfc738dcd327a6422b50e39d95ce1028c
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 27 10:42:51 2015 +0200
Bug 14060: Display the date format on the warning popup
The date format is now displayed on the warning popup.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 2a3966946131992ceeb125be3a852b9893bfd708)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit 9cfee957dbdba479c96dfdce80095b91a628757b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 27 10:39:14 2015 +0200
Bug 14060: Add OnClose event on missing datepicker
The "suspend until" inputs (hold list on circ/circulation.pl and
members/moremember.pl) were not set in the same way.
The minDate option should be set for both (bug 10703 removed it for
circ/circulation.pl).
This patch reintroduces the option and add the OnClose event on both.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit d53fb6db6a0cb0d239e7849c902a3dce4966c709)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
commit b089121aeb06a722657842a433832330a32098ae
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Apr 24 15:36:34 2015 +0200
Bug 14060: Remove readonly attributes on date inputs
In order to remove accessibility issues due to the readonly attributes
on date inputs, this patch will remove them and introduce a javascript
validation on them.
This patch is not perfect for some reason:
I didn't manage to force the user to select a valid date. One solution
would be to reopen the datepicker plugin until a valid date is inserted.
But it could be annoying for users (and for me: I did not manage to
implement this solution).
You will note that input is emptied if the date is not valid. This is a
quick and efficient solution to prevent submitting invalid date and make
Koha explodes. A proper solution would be to implement the check server
side send a friendly message to the user.
Test plan:
For all inputs, try an invalid and a valid date.
1/ Debar a patron
2/ On the checkout tables (circulation and moremember), add a renewal
due date (at the bottom of the tables)
3/ On the checkout page, specify a due date
4/ On the return page, specify a return date
5/ On the invoice page (acquisition module), enter a shipment and
billing date
6/ On the invoice search page (invoices.pl) use filters shipment and
billing dates
7/ On the offline circ page, specify a due date
8/ On the edit patron page (memberentry), add a debarment
9/ On the reserve page (reserve/request.pl), use the date inputs to
suspend until a defined date
10/ Edit patrons in a batch (tools/modborrowers.pl) and use the
registration and expiry date inputs
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit f91ed3d8bf19533a4a92e67c0b1fe394e84e67bf)
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 4 +-
C4/HoldsQueue.pm | 54 ++++++
C4/ImportExportFramework.pm | 7 +-
C4/Items.pm | 2 -
C4/Letters.pm | 20 +-
C4/Ris.pm | 89 +++++----
Koha.pm | 2 +-
Koha/Database.pm | 4 +
Koha/Exporter/Record.pm | 21 ++-
Koha/Logger.pm | 8 +-
Koha/Schema/Result/Issuingrule.pm | 6 +-
Koha/Schema/Result/Virtualshelve.pm | 10 +-
.../Elasticsearch.pm} | 27 ++-
.../Elasticsearch}/Indexer.pm | 10 +-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +-
Koha/SearchEngine/Elasticsearch/Search.pm | 6 +-
acqui/basket.pl | 2 +-
acqui/lateorders.pl | 4 +-
admin/import_export_framework.pl | 8 +-
cataloguing/addbiblio.pl | 24 ++-
cataloguing/additem.pl | 17 +-
circ/circulation.pl | 6 +-
etc/zebradb/zebra-authorities-dom.cfg | 2 +-
etc/zebradb/zebra-authorities.cfg | 2 +-
etc/zebradb/zebra-biblios-dom.cfg | 2 +-
etc/zebradb/zebra-biblios.cfg | 2 +-
.../mandatory/unimarc_framework_DEFAULT.sql | 6 +-
.../mandatory/unimarc_framework_DEFAULT.sql | 8 +-
.../mandatory/unimarc_framework_DEFAULT.sql | 8 +-
.../unimarc_bibliographic_DEFAULT_local_995.sql | 2 +-
...rc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +-
.../unimarc_bibliographic_DEFAULT_local_995.sql | 2 +-
.../optional/unimarc_bibliographic_AN_local.sql | 2 +-
.../optional/unimarc_bibliographic_AUD_local.sql | 2 +-
.../optional/unimarc_bibliographic_BOOK_local.sql | 2 +-
...rc_bibliographic_DEFAULT_local_952_obsolete.sql | 2 +-
.../optional/unimarc_bibliographic_EL_local.sql | 2 +-
.../optional/unimarc_bibliographic_MIN_local.sql | 2 +-
.../optional/unimarc_bibliographic_NOTE_local.sql | 2 +-
.../optional/unimarc_bibliographic_PER_local.sql | 2 +-
.../optional/unimarc_bibliographic_TECH_local.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 88 +++++----
installer/install.pl | 2 +
.../prog/en/includes/borrower_debarments.inc | 2 +-
.../intranet-tmpl/prog/en/includes/calendar.inc | 64 ++++++-
.../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 +-
.../prog/en/includes/checkouts-table-footer.inc | 2 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 14 +-
.../prog/en/includes/patron-title.inc | 16 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 4 +-
.../prog/en/modules/acqui/invoices.tt | 4 +-
.../prog/en/modules/acqui/lateorders.tt | 2 +-
.../prog/en/modules/admin/preferences/admin.pref | 168 ++++++++---------
.../prog/en/modules/circ/circulation.tt | 26 ++-
.../intranet-tmpl/prog/en/modules/circ/offline.tt | 10 +-
.../intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 8 +-
.../prog/en/modules/members/deletemem.tt | 4 +-
.../prog/en/modules/members/memberentrygen.tt | 50 ++---
.../prog/en/modules/members/moremember.tt | 67 +++----
.../prog/en/modules/members/printfeercpt.tt | 12 +-
.../prog/en/modules/members/printinvoice.tt | 12 +-
.../prog/en/modules/reserve/request.tt | 6 +-
.../prog/en/modules/tools/modborrowers.tt | 5 +-
koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 +
.../intranet-tmpl/prog/js/pages/circulation.js | 13 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
members/deletemem.pl | 9 +-
members/patronimage.pl | 2 +-
members/pay.pl | 4 +-
members/printfeercpt.pl | 1 +
members/printinvoice.pl | 1 +
misc/devel/populate_db.pl | 193 ++++++++++++++++++++
misc/export_records.pl | 12 +-
misc/search_tools/rebuild_elastic_search.pl | 8 +-
opac/opac-detail.pl | 2 +
opac/opac-memberentry.pl | 3 +-
opac/svc/overdrive_proxy | 4 +-
t/00-load.t | 2 +-
t/db_dependent/BackgroundJob.t | 2 +-
t/db_dependent/Circulation/MarkIssueReturned.t | 22 ++-
t/db_dependent/Exporter/Record.t | 90 ++++++---
t/db_dependent/HoldsQueue.t | 82 ++++++++-
t/db_dependent/KitchenSinkPlugin.kpz | Bin 74771 -> 75857 bytes
.../{Koha_ElasticSearch.t => Koha_Elasticsearch.} | 2 +-
...arch_Indexer.t => Koha_Elasticsearch_Indexer.t} | 4 +-
.../Koha_SearchEngine_Elasticsearch_Search.t | 2 +-
t/db_dependent/Letters.t | 2 +-
t/db_dependent/Patron/Borrower_Discharge.t | 13 +-
tools/quotes/quotes_ajax.pl | 2 +-
91 files changed, 1007 insertions(+), 438 deletions(-)
rename Koha/{ElasticSearch.pm => SearchEngine/Elasticsearch.pm} (91%)
rename Koha/{ElasticSearch => SearchEngine/Elasticsearch}/Indexer.pm (94%)
create mode 100755 misc/devel/populate_db.pl
rename t/db_dependent/{Koha_ElasticSearch.t => Koha_Elasticsearch.} (94%)
rename t/db_dependent/{Koha_ElasticSearch_Indexer.t => Koha_Elasticsearch_Indexer.t} (90%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list