[koha-commits] main Koha release repository branch master updated. v16.05.00-1233-gc7bc14c
Git repo owner
gitmaster at git.koha-community.org
Fri Oct 28 14:01:18 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c7bc14cead116d7a8737be8da19b688e53049864 (commit)
via bad06abf77bdb78fa3089b7a9b37eb69dd68245c (commit)
via 0790de1321ef23c3cd5c94560af7e78e91932791 (commit)
via 0963dc4da6b77d02ba798a6605685531ddccfcf4 (commit)
via 68ced964fd254e7cba67a9b1b867907c557888c4 (commit)
from 6b8f703364c8dcd9a263e9f77596ca0fba1a1bc4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c7bc14cead116d7a8737be8da19b688e53049864
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Oct 28 11:59:55 2016 +0000
Bug 14629 - DBRev 16.06.00.041
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bad06abf77bdb78fa3089b7a9b37eb69dd68245c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 28 12:30:23 2016 +0200
Bug 14629: [QA Follow-up] Small tidy up
Some cosmetic changes as to whitespace and one call less to Normalize.
Test plan:
Run t/Koha.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0790de1321ef23c3cd5c94560af7e78e91932791
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Aug 10 18:53:48 2016 +0000
Bug 14629 - (QA Followup) sysprefs.sql changes
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0963dc4da6b77d02ba798a6605685531ddccfcf4
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 31 16:00:10 2015 +0000
Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN
This is an optional follow up depending on community opinion.
While copying over the code form the ISBN portion I noticed that with
aggressive matching enabled invalid ISBNs (and hence ISSNs) were being
stripped from the record.
I think in the case of a library exporting records, making changes, and
reimporting they would expect to get a match on ISSN or ISBN whether or
not the number is valid.
This patch changes the subroutine to return the original ISSN in the
case of it being invalid.
To test:
With first patch only export a record with an invalid ISSN and reimport
with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match
Apply this patch
reimport the file and you should find a match.
Signed-off-by: Chad Roseburg <croseburg at ncrl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 68ced964fd254e7cba67a9b1b867907c557888c4
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Dec 30 23:14:37 2015 +0000
Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match
of ISSNs with or without hyphens. It uses Business::ISSN in order to
follow the use of Business::ISBN and allow for validation of ISSNs
To test:
1 - Find a record in your system with an ISSN (or add one)
2 - Stage a record containing the same ISSN but lacking a hyphen
3 - Matching on ISSN should find 0 matches
4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import
5 - Matching should find 0
6 - Apply patch
7 - Update datbase and install Business::ISSN
8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no
change
9 - Set AggressiveMatchOnISSN as do and repeat original test
10 - You should find a match
11 - prove t/Koha.t - all tests pass
Sponsored by North Central Regional Library System (NCRL) www.ncrl.org
Signed-off-by: Chad Roseburg <croseburg at ncrl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 5 ++
C4/Koha.pm | 93 ++++++++++++++++++++
C4/Matcher.pm | 7 +-
Koha.pm | 2 +-
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 10 +++
.../en/modules/admin/preferences/cataloguing.pref | 8 ++
t/Koha.t | 19 +++-
8 files changed, 142 insertions(+), 3 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list