[koha-commits] main Koha release repository branch master updated. v16.05.00-665-g39487d6
Git repo owner
gitmaster at git.koha-community.org
Thu Sep 8 14:54:44 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 39487d634ecb2fbfe5819852ef295cdd3d214737 (commit)
via ea275693348b7d7e7a230de1cdbd3cf3a0ecb826 (commit)
via cadf5aea814636ccccd85fcc38aa30f751d779c0 (commit)
via b1c703ac5c10b40b4dd275904dc44bbafadebd5e (commit)
via 6cbae9c3cb0cb3675dc2620e149eace979a78e01 (commit)
via dd8352bb8b4718393f25038086d0128c9671e970 (commit)
via 16f74b546e2eafa3e887aa33000954052156a5d2 (commit)
from 1ebb3c386631359c5265a2bd31503c97bf2c4982 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 39487d634ecb2fbfe5819852ef295cdd3d214737
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 30 12:44:14 2016 -0300
Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls
This patch adds the frameworkcode option param, using each record's frameworkcode
as expected by the filter. Otherwise the ViewPolicy filter falls back to the
default framework.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ea275693348b7d7e7a230de1cdbd3cf3a0ecb826
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 22 11:00:41 2016 -0300
Bug 11592: (QA followup) Simplify code
Koha::RecordProcessor and the defined filters are supposed to bring us
joy and happiness. Let's keep the code compact, simple and clean.
This patch removes record cloning all over the place.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit cadf5aea814636ccccd85fcc38aa30f751d779c0
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Apr 20 21:49:41 2016 -0400
Bug 11592: MARCView and ISBD followup
There are still some leaks, but it is not as a result
of the filter, but rather a result of poorly written
template files.
Bug fixing template files is beyond the scope of this
set of patches.
TEST PLAN
---------
1) Backup your DB
2) run the following SQL on your DB.
> UPDATE marc_subfield_structure set hidden=-8;
-- this should set EVERYTHING to hidden across the board.
3) In staff client, set OPACXSLTDetailsDisplay to blank
4) In OPAC, view any detail.
-- Normal view may mostly leak values still.
-- MARC view may leak values.
-- ISBD view may leak values.
5) In staff client, set OPACXSLTDetailsDisplay to default
6) In OPAC, view any detail.
-- same issues as step 4
-- 'View Plain' may leak too.
7) 'Save record' -> 'Dublin Core'
8) Apply this patch
9) run koha qa test tools
-- should be fine
10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t
-- should pass
-- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too
11) In OPAC, view any detail.
-- Normal view:
-- Material type comes from the LEADER field.
-- Lists this is on will still display
-- 'Tags from this library' will still display
-- Item information in table will still display
(THIS IS BEYOND SCOPE)
-- MARC view:
-- Record number is leaked
(THIS IS BEYOND SCOPE)
-- 'View plain' leaks LEADER field.
-- ISBD view may leak field headings, but not values.
(THIS IS BEYOND SCOPE)
12) In staff client, set OPACXSLTDetailsDisplay to blank
13) In OPAC, view any detail.
-- same kind of output as step 10
14) 'Save record' -> BIBTEXT
-- Should be next to nothing leaked.
15) 'Save record' -> Dublin Core
-- Should be the same or less leaked between the two versions.
-- (XML FILTERING IS BEYOND SCOPE)
16) In the staff client, go view the same record.
-- it should be mostly hidden in ISBD View.
17) run the following SQL on your DB.
> UPDATE marc_subfield_structure set hidden=1;
-- this should set EVERYTHING to hidden in OPAC, but not
the STAFF across the board.
18) Refresh the staff ISBD page
-- values should reappear.
19) View the ISBD details in the OPAC
-- values should still be hidden.
20) Check out the OPAC Cart and List
-- while the intermediate pages may still leak
the download links should leak very minimally.
-- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH
THE INTRANET ISBD AND SOME CART/LIST STUFF
WERE FIXED BECAUSE OF THE GetISBDView REFACTOR)
Expectations:
Before Patch - all the OPAC Detail pages will display things
After Patch - all the OPAC Detail pages will display much less,
and hopefully nothing (though there are known limits).
the ISBD detail page in the Staff client will be
filtered as well based on STAFF settings.
The saving/exporting should generate nearly empty
files.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b1c703ac5c10b40b4dd275904dc44bbafadebd5e
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Mar 9 14:39:08 2016 -0500
Bug 11592: Biblio tweak for MARCSUBJECT
https://bugs.koha-community.org/show_bug.cgi?id=11592
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 6cbae9c3cb0cb3675dc2620e149eace979a78e01
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Feb 19 11:02:59 2016 -0500
Bug 11592: Applying filtering to opac interface.
Applying the filtering and then...
Debugging opac/opac-detail.pl filtering
Debugging opac/opac-ISBDdetail.pl more
Debugging opac/opac-export.pl
Tweak opac/opac-export.pl fix variable declarations, conditional assignments
Debugging opac/opac-showmarc.pl
https://bugs.koha-community.org/show_bug.cgi?id=11592
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit dd8352bb8b4718393f25038086d0128c9671e970
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Mar 16 17:10:02 2016 -0400
Bug 11592: Add should_hide_marc method to filter
Add should_hide_marc to ViewPolicy filter
Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 16f74b546e2eafa3e887aa33000954052156a5d2
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Jan 23 22:31:08 2014 -0500
Bug 11592: Updated License Text and use Modern::Perl
Why not clean up the License Agreement stuff while the files
are being changed? Used the current one found at:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
Changed the strict and warning lines into just a Modern::Perl.
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 25 ++++++++-----
C4/XSLT.pm | 23 ++++++------
Koha/Filter/MARC/ViewPolicy.pm | 59 +++++++++++++++++++++++++++++++
catalogue/ISBDdetail.pl | 40 ++++++++++++++++-----
opac/opac-ISBDdetail.pl | 24 ++++++++++---
opac/opac-MARCdetail.pl | 36 ++++++++++++-------
opac/opac-basket.pl | 15 +++++---
opac/opac-detail.pl | 20 +++++++++--
opac/opac-downloadcart.pl | 19 ++++++++--
opac/opac-downloadshelf.pl | 20 ++++++++---
opac/opac-export.pl | 35 ++++++++++++++----
opac/opac-shelves.pl | 11 +++++-
opac/opac-showmarc.pl | 40 +++++++++++++--------
t/db_dependent/Filter_MARC_ViewPolicy.t | 52 ++++++++++++++++++++-------
14 files changed, 324 insertions(+), 95 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list