[koha-commits] main Koha release repository branch master updated. v16.05.00-722-gf6bf8c5

Fri Sep 9 12:41:44 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f6bf8c55a40bb60998b3d696b25eaeb6a75fe4e9 (commit)
       via  09d00bf04002988169fa43b84ea52fa5e7d30415 (commit)
       via  e4136c2b3ad4730255f8c39409756c82948f0cfd (commit)
       via  b9d5cbedc4b61579ae3a245ad2f7ae779d12d36b (commit)
       via  70a31874a73fdfaf83371ecd0c80359301dbd45c (commit)
       via  6f67992ffa893de3f17641f739064f748c200cf8 (commit)
       via  a7f831404eba0e38c10cc60dde337e7470e09572 (commit)
       via  d9af985de6dc21ad1bed99c4fed536f377c255d9 (commit)
       via  172b4b54a131cafc7996290347edbcda531e05f8 (commit)
       via  01631b6e3146906984aa497a2937365dd3b3ab9e (commit)
      from  eaa11da5624f308768c4eb2c7016b5cd32c35fb1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f6bf8c55a40bb60998b3d696b25eaeb6a75fe4e9
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Aug 12 10:12:18 2016 +0200

    Bug 17089: [QA Follow-up] Add some test descriptions to Ratings.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 09d00bf04002988169fa43b84ea52fa5e7d30415
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 9 17:06:56 2016 +0100

    Bug 17089: Improve errors handling

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit e4136c2b3ad4730255f8c39409756c82948f0cfd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 9 15:08:55 2016 +0100

    Bug 17089: Mark out the boundaries of ratings

    In the doc of C4::Ratings, it was written that the rate values should be
    >=0 and <=5, but it was not taken into account.
    This bug should be fixed on stable releases as well.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit b9d5cbedc4b61579ae3a245ad2f7ae779d12d36b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 9 15:01:05 2016 +0100

    Bug 17089: Koha::Ratings - Remove C4::Ratings

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 70a31874a73fdfaf83371ecd0c80359301dbd45c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 9 15:01:21 2016 +0100

    Bug 17089: Koha::Ratings - Remove GetRating

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 6f67992ffa893de3f17641f739064f748c200cf8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 12 11:28:57 2016 +0100

    Bug 17089: Koha::Ratings - Remove DelRating

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a7f831404eba0e38c10cc60dde337e7470e09572
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 12 11:06:07 2016 +0100

    Bug 17089: Koha::Ratings - Remove ModRating

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit d9af985de6dc21ad1bed99c4fed536f377c255d9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 12 11:04:41 2016 +0100

    Bug 17089: Koha::Ratings - Remove AddRating

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 172b4b54a131cafc7996290347edbcda531e05f8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 12 11:28:42 2016 +0100

    Bug 17089: Koha::Ratings - move tests

    Rewrite and move the tests.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 01631b6e3146906984aa497a2937365dd3b3ab9e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 12 11:28:25 2016 +0100

    Bug 17089: Koha::Ratings - Add Koha::Rating[s] classes

    The subroutines in C4::Ratings are only CRUD operations.
    This patch set moves the entire module to Koha::Rating[s] based on
    Koha::Object[s]

    Test plan for the whole patch set:
    0/ Set OpacStarRatings to "results and details"
    1/ Log in at the OPAC
    2/ Launch a search, you should see the star ratings
    3/ Go on a detail page, you should see the star ratings
    4/ Rate the record
    5/ Log in with another patron
    6/ Go on the same detail page, you should see the previous rating
    7/ Rate the racord, you should see "2 votes" and the average rating
    value.
    8/ Cancel your rate
    9/ Disable JavaScript and repeat 7

    Note: You cannot cancel your rate if JavaScript is disabled (not a
    regression).

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Ratings.pm                                      |  268 --------------------
 Koha/{Checkout.pm => Rating.pm}                    |   27 +-
 Koha/{Acquisition/Currencies.pm => Ratings.pm}     |   28 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |   19 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |   13 +-
 opac/opac-detail.pl                                |   11 +-
 opac/opac-ratings-ajax.pl                          |   27 +-
 opac/opac-ratings.pl                               |   10 +-
 opac/opac-search.pl                                |   10 +-
 t/db_dependent/Koha/Ratings.t                      |   60 +++++
 t/db_dependent/Ratings.t                           |  121 ---------
 11 files changed, 143 insertions(+), 451 deletions(-)
 delete mode 100644 C4/Ratings.pm
 copy Koha/{Checkout.pm => Rating.pm} (73%)
 copy Koha/{Acquisition/Currencies.pm => Ratings.pm} (67%)
 create mode 100755 t/db_dependent/Koha/Ratings.t
 delete mode 100755 t/db_dependent/Ratings.t

hooks/post-receive
-- 
main Koha release repository