[koha-commits] main Koha release repository branch master updated. v16.05.00-747-gd6fba2e
Git repo owner
gitmaster at git.koha-community.org
Fri Sep 9 13:38:25 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d6fba2e2f35a840c9cff8b0c05869e0a21ca09e2 (commit)
via 177542bf5208e5e053ac9b1500d2536e1eff5ae2 (commit)
via b5c3b1c9747693c284c3c0e8fdb2df94d256088e (commit)
via ac59bed98ac980efaa789fa46fad1225c12bc7ce (commit)
via 54044e05c56580d34473887f46385aca008200c5 (commit)
via 092ae340cef375cc66c8511fd34c1a4eec9c7ba6 (commit)
via 41fa333ec98a492f9a509d3a05f747ac38ac7c79 (commit)
via 3cf4d92a5f2b7cd4a15913e96108f79323978000 (commit)
via 48fe93e945a3fcb55adaa17a44bd5963c5a9f3f4 (commit)
via f3b57dfb023f81c57719ed31f91ada40a40fb165 (commit)
via 7a10e15dae3e4ae7733e466976e6b393069615ab (commit)
via eb950f4cc4d0ea759673deb8f272e0e043248b8f (commit)
via f1e4e83008d2a4be992352242f75e7fa663e34a0 (commit)
via ba8f552ab605739ca9a9ea3a2c4c9d0a93871c96 (commit)
via 86395f2282f526ff51965e6a129c24b811dbbabd (commit)
from ac13b03ff21e169b492a260a3eced21500c43fd2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d6fba2e2f35a840c9cff8b0c05869e0a21ca09e2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 9 10:38:43 2016 +0000
Bug 15839 - DBRev 16.06.00.019
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 177542bf5208e5e053ac9b1500d2536e1eff5ae2
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 29 10:24:44 2016 +0200
Bug 15839: [QA Follow-up] Error checking in opac-review.pl
[1] Adds a check on biblionumber. (Prevents a DBIx error.)
[2] If you have a reviewid, search on that and check results.
Add an unauthorized error in template.
[3] If you add a new review, check that there is no review yet.
If so, edit the existing one.
This supports the added FIXME on a unique constraint.
Note: This script could receive further attention.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested all crud ops with opac-review.pl (incl URL manipulation).
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b5c3b1c9747693c284c3c0e8fdb2df94d256088e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 29 09:27:58 2016 +0200
Bug 15839: [QA Follow-up] Paging on opac-showreviews
Paging is kind of messy here. This patch at least improves somewhat.
The page number should be rounded.
The results per page should be passed to the template too.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested a number of reviews and played with count parameter in URL.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ac59bed98ac980efaa789fa46fad1225c12bc7ce
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 29 08:16:47 2016 +0200
Bug 15839: [QA Follow-up] Update existing rows in dbrev
Adding the default is fine for new records; we also should take care
of the pending existing ones.
Trivial addition to atomic update file.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested the dbrev again with existing unapproved reviews.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 54044e05c56580d34473887f46385aca008200c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:32:15 2016 +0000
Bug 15839: Koha::Reviews - Remove C4::Review residue
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:30:07 2016 +0000
Bug 15839: Koha::Reviews - Remove savereview
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 41fa333ec98a492f9a509d3a05f747ac38ac7c79
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:28:33 2016 +0000
Bug 15839: Koha::Reviews - Remove updatereview
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 3cf4d92a5f2b7cd4a15913e96108f79323978000
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:28:09 2016 +0000
Bug 15839: Koha::Reviews - Remove getnumberofreviews
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 48fe93e945a3fcb55adaa17a44bd5963c5a9f3f4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:15:55 2016 +0000
Bug 15839: Koha::Reviews - Remove getreview
Note that this (biblionumber, borrowernumber) pair should be defined as
a unique key at the DB level (FIXME added)
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit f3b57dfb023f81c57719ed31f91ada40a40fb165
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:06:46 2016 +0000
Bug 15839: Koha::Reviews - Remove deletereview
Note that a future enhancement should take into account the possible
error returned by ->approve, ->unapprove and ->delete
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 7a10e15dae3e4ae7733e466976e6b393069615ab
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:53:41 2016 +0000
Bug 15839: Koha::Reviews - Change default value for approved to 0
The reviews.approved column had a default value set to NULL.
It does not make sense, the default value should be 0, this will avoid
to have to specify the approved value when creating a new review.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit eb950f4cc4d0ea759673deb8f272e0e043248b8f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:06:27 2016 +0000
Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview
This patch adds 2 new methods to Koha::Review: approve and unapprove.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit f1e4e83008d2a4be992352242f75e7fa663e34a0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 15:56:03 2016 +0000
Bug 15839: Koha::Reviews - Remove getallreviews
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ba8f552ab605739ca9a9ea3a2c4c9d0a93871c96
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 15:09:01 2016 +0000
Bug 15839: Koha::Reviews - Remove getreviews
The C4::Reviews::getreviews subroutine retrieved the reviews for a given
record, depending on their status.
This can be achieve with a call to Koha::Reviews->search.
There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl
does not look in used: the reviews are not display on this page. It
certainly comes from an old copy/paste from opac-detail.pl.
The one from opac-detail only asked for the approved reviews. So the
logged in user does not see its own review if it is pending approval.
Actually this pending approval review is only displayed when the user
submits it (because of a unecessary complex text replacement done in
JS).
With this patch, the approved reviews AND the unaproved review from the
logged in user will be displayed.
It will allow a future enhancement to add a way to delete our own
reviews.
Moreover, the reviews were retrieved even if they were not displayed (if
reviewson is off), it's now fixed.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 86395f2282f526ff51965e6a129c24b811dbbabd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Feb 16 16:41:22 2016 +0000
Bug 15839: Koha::Reviews - Add Koha::Review[s] classes
The subroutines in C4::Reviews are only doing CRUD operations.
This patch set moves them to 2 new Koha::Review[s] classes.
Test plan for the whole patch set:
0/ Set the reviewson syspref
1/ At the OPAC, create a couple of reviews for a record
Try and create a review without html tags different that br b i em big
small strong: You should get a warning.
2/ Edit a review
3/ On the Staff interface, you should see a "Comments pending approval"
link on the mainpage
4/ Approve 1 review and delete the other
5/ At the OPAC you should only see 1 review (the approved one) in the
"Comments" tab
6/ Modify the review
7/ The review should appear again in the "comments awaiting moderation"
tab.
Note that even the comment has not been changed, it will have to be
reapproved (FIXME later). This behavior already existed prior to this
patch.
Tested all patches together (with database updated)
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Review.pm | 243 ------------
Koha.pm | 2 +-
Koha/{Authority/Type.pm => Review.pm} | 31 +-
Koha/{Cities.pm => Reviews.pm} | 10 +-
Koha/Schema/Result/Review.pm | 7 +-
installer/data/mysql/kohastructure.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 13 +
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +-
.../opac-tmpl/bootstrap/en/modules/opac-review.tt | 44 +--
.../bootstrap/en/modules/opac-showreviews.tt | 8 +-
mainpage.pl | 4 +-
opac/opac-ISBDdetail.pl | 14 +-
opac/opac-detail.pl | 68 ++--
opac/opac-review.pl | 53 ++-
opac/opac-showreviews.pl | 19 +-
reviews/reviewswaiting.pl | 26 +-
t/Review.t | 15 -
t/db_dependent/Koha/Reviews.t | 73 ++++
t/db_dependent/Review.t | 395 --------------------
tools/tools-home.pl | 7 +-
20 files changed, 256 insertions(+), 790 deletions(-)
delete mode 100644 C4/Review.pm
copy Koha/{Authority/Type.pm => Review.pm} (73%)
copy Koha/{Cities.pm => Reviews.pm} (87%)
delete mode 100755 t/Review.t
create mode 100644 t/db_dependent/Koha/Reviews.t
delete mode 100644 t/db_dependent/Review.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list