[koha-commits] main Koha release repository branch master updated. v16.05.00-792-g1b43b3d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1b43b3d7acaf04e1822cdb199946aa04215b84fb (commit)
       via  b2ba2fa5ef2994f06cb583d6a82ee4fcb72fcc0e (commit)
       via  f56d6530bc7ea00db0d2b158a8b2667d5ba16a41 (commit)
      from  c585c9cf9d1bb1792741bbb0f36e3bc6bcde68b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1b43b3d7acaf04e1822cdb199946aa04215b84fb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Sep 9 13:26:20 2016 +0000

    Bug 16978 - DBRev 16.06.00.022
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit b2ba2fa5ef2994f06cb583d6a82ee4fcb72fcc0e
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Aug 1 19:38:10 2016 -0400

    Bug 16978: Followup - Copy create_report permissions for delete_report
    
    This patch should deal with comment #6's point of where a user who
    has create, but not execute permissions, would lose delete ability.
    Users with create and execute permissions would already have delete
    as well.
    
    TEST PLAN
    ---------
     1) Back up db
     2) drop database koha_library;
     3) create database koha_library;
     4) web install with all sample data with system user
     6) log into staff client as system user
     7) make sample koha admin user a superlibrarian
     8) set username and password for sample koha admin user
     9) log out and log in as koha admin
    10) Create a user (USER_A) with permissions:
            create_reports   and execute_reports.
    11) Create a user (USER_B) with permissions:
            create_reports,  but not execute_reports.
    12) Create a user (USER_C) with permissions:
            execute_reports, but not create_reports.
    13) Create a user (USER_D) with no report permissions.
    14) Run the atomic update.
    15) Check USER_A permissions
        -- should have delete_reports
    16) Check USER_B
        -- should have delete_reports
    17) Check USER_C
        -- should NOT have delete_reports
    18) Check USER_D
        -- should NOT have delete_reports
    19) run koha qa test tools
    20) restore db
    
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit f56d6530bc7ea00db0d2b158a8b2667d5ba16a41
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Tue Jul 26 09:50:52 2016 -0400

    Bug 16978: Add delete reports user permission
    
    This splits off the delete capability from the create reports permission.
    From a UI perspective there were CSS issues, that this patch set hackily
    bypasses. Perhaps someone else can amend this enhancement with the required
    changes so that the extra column at the beginning of the table can be
    removed when the user does not have delete capability.
    
    TEST PLAN
    ---------
    1) back up db
    2) apply patch
    3) ./installer/data/mysql/updatedatabase.pl
       -- should run without issue.
    4) in mysql:
       > drop database ...
       > create database ...
       -- totally blanks it for fresh web install
    5) run web install
       -- installing should have no issues
    6) go to a patron
    7) set permissions
    8) expand the reports permission
       -- should have delete reports now
    9) click help and scroll down to
       'Granular Reports Permissions' right at the bottom.
       -- there should be a new delete_reports section
    10) Head over to guided reports and build a few reports.
        -- as system account user, delete stuff should all be visible.
    11) Find a patron, set all permissions, except delete reports.
    12) log out and then log in as the modified patron
    13) Head over the save reports
        -- none of the delete options should be available to the user.
    14) run koha qa test tools
    15) restore db
    
    Followed test plan. Additionally tried to delete using params in URL
    (not possible, OK)
    Signed-off-by: Marc <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                             |    2 +-
 installer/data/mysql/updatedatabase.pl              |   19 +++++++++++++++++++
 installer/data/mysql/userpermissions.sql            |    1 +
 .../intranet-tmpl/prog/en/includes/permissions.inc  |    1 +
 .../prog/en/includes/reports-toolbar.inc            |    2 +-
 .../prog/en/modules/help/members/member-flags.tt    |    6 ++++++
 .../prog/en/modules/reports/guided_reports_start.tt |   10 ++++++++--
 reports/guided_reports.pl                           |    8 ++++++--
 8 files changed, 43 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository