[koha-commits] main Koha release repository branch master updated. v16.05.00-862-g57f66d5

Git repo owner gitmaster at git.koha-community.org
Tue Sep 13 20:23:39 CEST 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  57f66d5132fe059c76740b5e2e743d3082d25303 (commit)
       via  645b1f52379966e489f417e0173d5950e4ebc8f9 (commit)
      from  99f6116f3595f4d58307fc3249f3be98550d99a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 57f66d5132fe059c76740b5e2e743d3082d25303
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Sep 13 09:06:12 2016 +0100

    Bug 16949: Simplify the checkbox checked condition
    It's easier to use jQuery selector to know if checkboxes are checked.
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 645b1f52379966e489f417e0173d5950e4ebc8f9
Author: Aleisha <aleishaamohia at hotmail.com>
Date:   Wed Jul 20 22:14:05 2016 +0000

    Bug 16949: Batch record deletion says success when no records have been passed in
    The reason this happens is because the page will say success when the
    total number of records given equals the total number of successful
    deletions. If you pass in no records, there are no successful deletions
    --> 0 = 0 --> it thinks it has been successful. This patch adds a check
    that validates if any checkboxes were selected before submitting the
    final form.
    I have removed the check for if any records were selected AFTER the form
    has been submitted because it seemed unnecessary if the form can't be
    submitted without selection of records anyway.
    To test:
    1) Go to Tools -> Batch record deletion
    2) Put in a record number and click Continue
    3) Deselect the record so that it doesn't actually delete and click
       Delete selected records
    4) Page says 'All records have been deleted successfully!'
    5) Apply patch. Go back and repeat step 3
    6) Form should not submit and you should receive an alert saying that no
       records have been selected.
    7) If you try selecting and deleting a record after this alert, it
       should still work
    Note: Have also changed the wording of error in Step 1 when you are
    entering record numbers to delete.
    Sponsored-by: Catalyst IT
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>


Summary of changes:
 .../prog/en/modules/tools/batch_delete_records.tt            |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

main Koha release repository

More information about the koha-commits mailing list