[koha-commits] main Koha release repository branch master updated. v16.05.00-906-g0901758
Git repo owner
gitmaster at git.koha-community.org
Mon Sep 26 20:19:11 CEST 2016
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 0901758f498aaa2f1711380916255db23709aa8d (commit)
via 91b23e09bbb57284e65578491ea226a407420a0b (commit)
via aa62448897f769f31604796494644e3171ef902b (commit)
from 9e22a9ced3db2ba0f27d45a551b455095cb910e5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0901758f498aaa2f1711380916255db23709aa8d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Sep 26 14:55:16 2016 -0300
Bug 17327: (QA followup) Remove Carp::Always which is not used
This patch removes the need for Carp::Always in .../Reserves/MultiplePerRecord.t
which is not actually used.
It also removes 'undef' from Koha::Holds::forced_hold_level's last return, to comply with
our QA rules.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 91b23e09bbb57284e65578491ea226a407420a0b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Sep 21 02:15:02 2016 +0000
Bug 17327: Item level holds no longer enforced
Reported by Katrin:
Example:
- on shelf holds allowed
- holds allowed 5
- holds on same record allowed 5
- FORCE item level holds
On a record with only one item, you can only place a record level hold
in OPAC now - which is against your circulation conditions.
Another example:
- record with 2 items
- circulation rules as above, 1 hold allowed on the record
- Item level holds: forced
I can only place record level holds in OPAC and staff. At the moment, I
am not able to place item level holds in any circumstances in my
installation.
Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Reserves/MultiplePerRecord.t
should fail
3) Apply the second patch
4) prove t/db_dependent/Reserves/MultiplePerRecord.t
should pass
5) Attempt to replicate one of the examples above, you should be unable to
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit aa62448897f769f31604796494644e3171ef902b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Sep 21 02:13:47 2016 +0000
Bug 17327: Add unit test for regression
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Holds.pm | 12 ++++++++----
t/db_dependent/Reserves/MultiplePerRecord.t | 8 +++++---
2 files changed, 13 insertions(+), 7 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list