From gitmaster at git.koha-community.org Sun Apr 2 18:31:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 02 Apr 2017 16:31:36 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-5-ge2f8603 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via e2f860386dd811b2be3b2988b690c2d28d748336 (commit) via c69868de49c21d567e0f5824b8ea8526a0e81d74 (commit) via bead88a8bce3dab2bbf6809a47a008167be016b0 (commit) via 7da5ac1bbb955e88dbaeab37332e2196c8b81c6d (commit) via 07e2f4fedc68c38d6498c61015484d9a36b85f56 (commit) from e94bf3f00f5b3e17dd01b6581093dfe1faa87aee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e2f860386dd811b2be3b2988b690c2d28d748336 Author: Jonathan Druart Date: Tue Feb 14 14:39:48 2017 +0000 Bug 18058: Allow borrower_message_preferences to be truncated borrower_message_preferences cannot be truncated because of the foreign. DBMS fails with "Cannot truncate a table referenced in a foreign key constraint" To avoid that we should remove the FK check and truncate the other table as well. I am wondering if we really need a truncate here DELETE FROM borrower_message_preferences; should do the job, but leave it as it because of the param name. Test plan perl misc/maintenance/borrowers-force-messaging-defaults --doit --truncate Should no longer raise the error message Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit dd88c8f710e4915dac6437355c356f0632b776fb) Signed-off-by: Katrin Fischer commit c69868de49c21d567e0f5824b8ea8526a0e81d74 Author: Jonathan Druart Date: Wed Feb 15 17:14:13 2017 +0100 Bug 18124: Change the calls to generate and check CSRF tokens The parameter change in Koha::Token should be applied to the calling scripts. Test plan: Confirm that the different forms of the scripts modified by this patch still work correctly. Test the problematic behavior: Open 2 tabs with in same user's session, go on the edit patron page (memberentry.pl). Log out and log in from the other tab. Submit the form => Wrong CSRF token should be raised Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall (cherry picked from commit 574d48362d32c14920712ae35bdd28101785315c) Signed-off-by: Katrin Fischer commit bead88a8bce3dab2bbf6809a47a008167be016b0 Author: Marcel de Rooy Date: Thu Feb 16 11:59:12 2017 +0100 Bug 18124: [Follow-up] Handle default parameters in a sub Adds a internal routine to handle default values for the parameters id and secret. Also adds a parameter session_id for generate_csrf and check_csrf. This session parameter is combined with the id parameter when generating or checking a token. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall (cherry picked from commit 7190593d9dd38001c2d101bcad5cddc222a45ebe) Signed-off-by: Katrin Fischer commit 7da5ac1bbb955e88dbaeab37332e2196c8b81c6d Author: Jonathan Druart Date: Wed Feb 15 17:14:13 2017 +0100 Bug 18124: Restrict CSRF token to user's session Currently the CSRF token generated is based on the borrowernumber, and is valid across user's session. We need to restrict the CSRF token to the current session. With this patch the CSRF token is generated concatenating the id (borrowernumber) and the CGISESSID cookie. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall (cherry picked from commit 3562816dd1b8855c7973ce5650ff834407c1a548) Signed-off-by: Katrin Fischer commit 07e2f4fedc68c38d6498c61015484d9a36b85f56 Author: Jonathan Druart Date: Tue Mar 21 10:52:42 2017 -0300 Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 8dad1582c100017f8ad3e331c9a9b9cc9ed4e4d6) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: Koha/Token.pm | 35 ++++++++++++--- basket/sendbasket.pl | 10 +---- members/deletemem.pl | 13 ++---- members/member-flags.pl | 11 +---- members/member-password.pl | 11 +---- members/memberentry.pl | 13 ++---- members/moremember.pl | 7 +-- .../maintenance/borrowers-force-messaging-defaults | 6 ++- opac/opac-memberentry.pl | 15 +++---- opac/opac-sendbasket.pl | 11 ++--- t/Token.t | 47 +++++++++++++++++--- tools/export.pl | 12 ++--- tools/import_borrowers.pl | 9 +--- tools/picture-upload.pl | 11 ++--- 14 files changed, 108 insertions(+), 103 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Apr 2 19:55:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 02 Apr 2017 17:55:05 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-26-g9668331 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 9668331d4260928dbe91ec9710031e5ac63f5346 (commit) via 3db9848f1acb904f67312c55a35fd262c46829aa (commit) via d24293bab480ec2b7128427b5bf3cef1860b1292 (commit) via df19ffde652f0438c9e516506a3de6cb0cfbd18f (commit) via 168a10de25ad64830ed0c448571e0607b64d4bd9 (commit) via 0a3b7777bbeb88e39903ceee35464d5eaec231e3 (commit) via b8c232dd37f6cb9d8833c39bff46a41668b78a6f (commit) via 3090a89b83fe630ea2c9bd002909791d528479f7 (commit) via 29526afcef6143ddafac8ffd00820ef9086ccaa0 (commit) via b4ef4f4e3b1b6c2176d7faaa906d92b195dc4c55 (commit) via a07565870d77fd990a12bced6444c2f80e5ec383 (commit) via 85da774d4384be0ae03fbb51caddd335f7e85fd7 (commit) via 30cfdb9096282175f4bf92b65021a8ef6e3fd052 (commit) via da9371a1d6a257d6d598c9299a33aedff183fc4c (commit) via 92ddd4bbc7f3f40241202ae19750e93d5ee2d30b (commit) via f305629f14ae925cf58dc62e39f871fd6ec1c8f5 (commit) via dbb0b4a4b09233a7b68fc29deef8220f61fb5950 (commit) via f75915336c072765a330ca7e39646326ef11212b (commit) via a36ee908dcb42121494e48aa05105e276d1be607 (commit) via 75ac2341774368975be08ee635851605f06a7b7d (commit) via 34565e7f7d38298d37f449520dd5bc20cec833f8 (commit) from e2f860386dd811b2be3b2988b690c2d28d748336 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9668331d4260928dbe91ec9710031e5ac63f5346 Author: Luke Honiss Date: Thu Jan 19 22:52:49 2017 +0000 Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl ==TEST PLAN== 1) Make a subscription with a record 2) Search and view the record in OPAC 3) Click on the subscription tab and click more details 4) The breadcrumb will say 'Detals for' without the record name 5) Apply patch 6) Refresh the page 7) The breadcrumb will display the name of the record (fixed small error) Signed-off-by: Sonia BOUIS Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 39bcba540a6c00fc374284dc025297a568befed6) Signed-off-by: Katrin Fischer commit 3db9848f1acb904f67312c55a35fd262c46829aa Author: Marc V?ron Date: Tue Mar 14 14:29:08 2017 +0100 Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat' To test: - Apply patch - Give a patron a high fine or credit (e.g. 12345.67) - Got to pages Home > Patrons > Accounts for... and Home > Patrons > Pay fines - Verify that amounts display following syspref 'CurrencyFormat' (e.g. 12'345.67 for syspref set to 360'000.00 (CH) Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit db467287d174827e52c322cb86d75b8628df52fe) Signed-off-by: Katrin Fischer commit d24293bab480ec2b7128427b5bf3cef1860b1292 Author: Grace McKenzie Date: Tue Jan 17 22:45:28 2017 +0000 Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: C?dric Vita Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 9a4fd7b27074d7ce923f7b47061d1e6636ecbc56) Signed-off-by: Katrin Fischer commit df19ffde652f0438c9e516506a3de6cb0cfbd18f Author: Marc V?ron Date: Tue Mar 21 14:52:51 2017 +0100 Bug 18307 - Branchname is no longer displayed in subscription tab view This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit c6463c258f644ea5a1983680814eb765f1801283) Signed-off-by: Katrin Fischer commit 168a10de25ad64830ed0c448571e0607b64d4bd9 Author: Jonathan Druart Date: Thu Mar 9 11:25:28 2017 -0300 Bug 18209: Add default, 'Actions' and fix case Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f14de0007c47ae66d0276186df073c0375d37610) Signed-off-by: Katrin Fischer commit 0a3b7777bbeb88e39903ceee35464d5eaec231e3 Author: Blou Date: Fri Mar 3 16:13:40 2017 -0500 Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit bb1492e9f67439753bf428bd06fa710791e70c74) Signed-off-by: Katrin Fischer commit b8c232dd37f6cb9d8833c39bff46a41668b78a6f Author: Marcel de Rooy Date: Thu Mar 30 10:20:30 2017 +0200 Bug 18019: [QA Follow-up] Also catch the delete from authorities detail Good catch from Jonathan. See comment11. Authorities detail should pass a CSRF token to authorities-home when deleting a record without linked biblios. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Passing the token with GET is not a good way to do, but nothing quick to replace that. Signed-off-by: Kyle M Hall (cherry picked from commit d2ee53fb5f90277d47fc56667e71018f5d9b88a9) Signed-off-by: Katrin Fischer commit 3090a89b83fe630ea2c9bd002909791d528479f7 Author: Marcel de Rooy Date: Tue Feb 7 09:09:33 2017 +0100 Bug 18019: Add CSRF protection to authorities-home.pl (op==delete) Without this patch, it is possible to delete authority records with URL manipulation. Like: /cgi-bin/koha/authorities/authorities-home.pl?op=delete&authid=[XXX] Test plan: [1] Go to Authorities. Search for some authorities (without links). [2] Delete an authority. Should work. [3] Apply patch. [4] Construct an URL like above to delete another authority. Should fail. Under Plack this results in an internal server error, the log tells you: Wrong CSRF token. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Amended the test plan. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 5a7dc0749f581e4c4bc6ec68d3f3ab6bac12afd5) Signed-off-by: Katrin Fischer commit 29526afcef6143ddafac8ffd00820ef9086ccaa0 Author: Nick Clemens Date: Fri Mar 3 14:56:31 2017 +0000 Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f454013ec9beb8f6e4c382253b76bfac5ca65244) Signed-off-by: Katrin Fischer commit b4ef4f4e3b1b6c2176d7faaa906d92b195dc4c55 Author: Marcel de Rooy Date: Fri Mar 17 13:24:41 2017 +0100 Bug 7728: [QA Follow-up] Fix POD whitespace Resolves complaints from qa tools. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 53f2b56fa15fac2f0d2ef0777e95f436d6914ec7) Signed-off-by: Katrin Fischer commit a07565870d77fd990a12bced6444c2f80e5ec383 Author: Julian Maurice Date: Wed Jan 11 14:51:43 2017 +0100 Bug 7728: QA fixes - Remove useless comments - Use Koha::Objects::find instead of Koha::Objects::search Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit c26afc2568311a2b7a99f33705cbc35b715563a8) Signed-off-by: Katrin Fischer commit 85da774d4384be0ae03fbb51caddd335f7e85fd7 Author: Paul Poulain Date: Tue Jan 26 14:03:21 2016 +0000 Bug 7728: Adding unit test ReNewSubscription.t Test plan: * run without the patch, the test will fail * run with the patch, the test will pass Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit d79a264b6991d48bda026fc0ccde0607b519423f) Signed-off-by: Katrin Fischer commit 30cfdb9096282175f4bf92b65021a8ef6e3fd052 Author: Paul Poulain Date: Wed Dec 9 10:25:43 2015 +0000 Bug 7728: Fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 1843ee148b25a904d8baffbbe8f0ea504b539a64) Signed-off-by: Katrin Fischer commit da9371a1d6a257d6d598c9299a33aedff183fc4c Author: Marc V?ron Date: Fri Mar 10 11:22:24 2017 +0100 Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit a723de2ae0c393743fc111955ee81b5e6c5b7f4a) Signed-off-by: Katrin Fischer commit 92ddd4bbc7f3f40241202ae19750e93d5ee2d30b Author: Marcel de Rooy Date: Mon Feb 6 10:29:44 2017 +0100 Bug 14535: Update the supplier filter too The combobox on the left side of late orders is filled by sub GetBooksellersWithLateOrders. The same change as in the first patch must be made here to include suppliers with late orders without a price. Bonus: Sort the list. Test plan: [1] Run t/db_dependent/Bookseller.t. [2] Go to late orders. Use the filter on suppliers. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5) Signed-off-by: Katrin Fischer commit f305629f14ae925cf58dc62e39f871fd6ec1c8f5 Author: Marcel de Rooy Date: Mon Feb 6 10:04:57 2017 +0100 Bug 14535: Late orders does not show orders with price = 0 This patch removes the filter of unitpricesupplier <> 0 and unitpricelib <> 0 from GetLateOrders as used in lateorders.pl. This allows you to claim late orders without a price entered. Test plan: [1] Run t/db_dependent/Acquisition.t [2] Check if you see an order with no price in lateorders.pl. (If needed, remove prices from a few orders.) Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 71f267fd3f3750510e3df5f2819d57ed45dcf919) Signed-off-by: Katrin Fischer commit dbb0b4a4b09233a7b68fc29deef8220f61fb5950 Author: Marcel de Rooy Date: Tue Mar 28 16:39:25 2017 +0200 Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status The zero status should be added in @notforloans. It is a legitimate status for available books. The zero status description can be translated in the template. The 'Change item status' is confusing. We mean that we saw a notforloan status that we do not expect (read: does not exist in the table). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 664d6534171677455f3cf1467e8726146714133a) Signed-off-by: Katrin Fischer commit f75915336c072765a330ca7e39646326ef11212b Author: Fridolin Somers Date: Fri Sep 12 15:21:18 2014 +0200 Bug 12913 - wrong inventory results when notforloan filter is not used In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status". The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem. Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Check the authorized value category has at least value '0' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9 - Delete new value created above, for example '9' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZZ' - Check 'Compare barcodes list to results' - Submit => without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0 => with patch, you get 1 result with 'Change item status' on item with notforloan=9 Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 358fb744c74cc63b7d2ae7d7e406ada205502ea8) Signed-off-by: Katrin Fischer commit a36ee908dcb42121494e48aa05105e276d1be607 Author: Benjamin Rokseth Date: Tue Dec 13 13:38:19 2016 +0100 Bug 17758 - SIP checkin does not handle holds correctly This patch updates SIP checkin to use reserve_id as param, to fix regression introduced by Bug 14695. To test: Given 1 patron and 1 biblio with two items attached: 1) create two record level holds on one biblio on same user Using SIP client or telnet: 2) checkin item x on pickup branch, observe item is waiting and hold 1 is filled 3) checkin item y on pickup branch, observe item y now is waiting and x is available 4) apply this patch and repeat 1-3, now expected behaviour should be that both holds are filled and both items waiting Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 72de37e24bd02ffccad3cd1a76e0d74202cf7794) Signed-off-by: Katrin Fischer commit 75ac2341774368975be08ee635851605f06a7b7d Author: Nick Clemens Date: Wed Jan 25 17:00:34 2017 +0000 Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit 3b794b1312d0cfac81b302d0e823e2c5683a1f0e) Signed-off-by: Katrin Fischer commit 34565e7f7d38298d37f449520dd5bc20cec833f8 Author: Jonathan Druart Date: Fri Feb 24 11:44:23 2017 +0100 Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable is reset but $borrower. In 16.11.x and before that causes the app to crash, because $borrower->{flags} is set to a hashref by GetMemberDetails, if $borrowernumber is set. This case is better handled in master (17.05) but side-effects could happen: if $borrowernumber is reset, $borrower should be reset too. The way to drive this behaviour is terrible and lot of things should be done to clean this area. This patch is a quick and easy fix to make it backportable easily. Test plan: On master, no change expected On 16.11 and before: 0. Set CircAutoPrintQuickSlip=clear screen 1. Create a new patron 2. Set permission for this patron to 'reservesforothers' (or something else). 3. Go on the circulation tab 4. Do not fill the barcode input and submit => Without this patch you will get an error Can't use string ("64") as a HASH ref while "strict refs".... => With this patch apply you will get a blank screen (expected behaviour). I would recommend to test this patch with the other value of CircAutoPrintQuickSlip as well ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 6 +- C4/Bookseller.pm | 2 - C4/Patroncards/Patroncard.pm | 6 +- C4/Reserves.pm | 2 + C4/SIP/ILS/Transaction/Checkin.pm | 4 +- C4/Serials.pm | 16 ++-- acqui/lateorders.pl | 2 +- authorities/authorities-home.pl | 13 +++ authorities/detail.pl | 2 + circ/circulation.pl | 3 +- .../prog/en/modules/admin/smart-rules.tt | 18 ++-- .../prog/en/modules/authorities/detail.tt | 2 +- .../en/modules/authorities/searchresultlist.tt | 3 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- .../prog/en/modules/help/admin/categorie.tt | 6 +- .../modules/help/admin/item_circulation_alerts.tt | 6 +- .../prog/en/modules/help/admin/smart-rules.tt | 22 ++--- .../prog/en/modules/help/members/boraccount.tt | 4 +- .../prog/en/modules/members/boraccount.tt | 10 +- .../intranet-tmpl/prog/en/modules/members/pay.tt | 11 ++- .../prog/en/modules/patroncards/manage.tt | 20 +++- .../prog/en/modules/tools/inventory.tt | 14 ++- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- opac/opac-serial-issues.pl | 5 +- t/db_dependent/Serials/ReNewSubscription.t | 96 ++++++++++++++++++++ tools/inventory.pl | 23 ++--- 26 files changed, 209 insertions(+), 91 deletions(-) create mode 100644 t/db_dependent/Serials/ReNewSubscription.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 11:54:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 09:54:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-781-ge410967 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e410967acfc6538abcef74948743df3e4f575148 (commit) from 360949f37927ce87dc4326437c2414fc73bae845 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e410967acfc6538abcef74948743df3e4f575148 Author: Marc V?ron Date: Sun Apr 2 18:59:52 2017 +0200 Bug 18368 - DBversion 16.12.00.022 not set by updatedatabase.pl Updating to 16.12.00.22 puts the upgrade process in an endless loop because DBversione is not set by updatedatabase.pl Missing line: SetVersion( $DBversion ) This patch inserts the line as appropriate. To test: - Apply patch - Verify code change makes sense - Verify that upgrade smoothly runs through Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 12:31:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 10:31:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-782-ga7f2c45 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a7f2c450de1142a16df67d04a30d5bd5e2813c52 (commit) from e410967acfc6538abcef74948743df3e4f575148 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a7f2c450de1142a16df67d04a30d5bd5e2813c52 Author: Marcel de Rooy Date: Mon Apr 3 09:21:37 2017 +0200 Bug 17866: [QA Follow-up] Change wording of db revision As Katrin noted on the report, we should not limit the db rev message to the serial claims only. Applies to acquisision claims too. Note: Strictly speaking, we could also mention the new ACQORDER notice, but this will not yet be widely used. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 12:37:41 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 10:37:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-784-g2d32617 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2d326177ae9faa6007ea835b1b793c7ec49168df (commit) via 1eab22f71e27675a66e4f91522a0f422a3455e34 (commit) from a7f2c450de1142a16df67d04a30d5bd5e2813c52 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2d326177ae9faa6007ea835b1b793c7ec49168df Author: Jonathan Druart Date: Wed Mar 15 18:58:55 2017 -0300 Bug 18093: Koha::Objects->get_column should not return a DBIC object Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 1eab22f71e27675a66e4f91522a0f422a3455e34 Author: Jonathan Druart Date: Fri Feb 10 09:45:26 2017 +0100 Bug 18093: Add Koha::Objects->get_column Test plan: prove t/db_dependent/Koha/Objects.t Should return green Followed test plan, result as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 11 +++++++++++ t/db_dependent/Koha/Objects.t | 9 ++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 12:39:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 10:39:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-785-g7d35bdf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7d35bdf58a0bcebab20df47b50b249cafe12ddb6 (commit) from 2d326177ae9faa6007ea835b1b793c7ec49168df (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d35bdf58a0bcebab20df47b50b249cafe12ddb6 Author: David Kuhn Date: Wed Dec 14 16:02:26 2016 -0800 Bug 17309 - Renewing and HomeOrHoldingBranch syspref The AddRenewal subroutine currently uses the circulation rules for the branch stored in the Issues table (which is the holding branch) when calculating the new due date. This patch replaces using the branch from the Issues table with the branch specified by the HomeOrHoldingBranch syspref. To test: 1. Set up 2 branches, Branch1 and Branch2 2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a 21 day renewal period. 3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a 14 day renewal period. 4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will receive the correct 21 day loan period. 5. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 14 day due date, rather than 21 days. 6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will receive the correct 14 day loan period. 7. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 21 day due date, rather than 14 days. 8. Apply the patch and repeat steps 4-7. The correct due date should be given when the item is renewed, regardless of where it is checked out or renewed. This update removes reassignment of $branch variable. Signed-off-by: C?dric Vita Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 16:48:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 14:48:19 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.05.11 created. v16.05.11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.05.11 has been created at e4e19181c0e5f9b26eae487f08f256c7274a6275 (tag) tagging d451096fa4e9aff62838f8faf3101b3e67217227 (commit) replaces v16.05.10 tagged by Mason James on Sat Mar 18 02:29:21 2017 +1300 - Log ----------------------------------------------------------------- Koha release 16.05.11 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJYy+SxAAoJEGPsprNybXB3t1wIAM68+WQR5nyR2N0+RAhelWg8 L+71kR5Ge+j6S32LKtbng9FC2CfcdC8oZz+b8uGr1sHmd9ov5WiOuzBlVuP1T2vq YwPHgd2Q8FrEdfT+VoSIdAGUH0WOWJ9vJME+VtgOcFGCayQRTHPDzZyf0Bck6c24 O/Ms+q6yXnVnF3Vgzm+moniVKkSQysRnqvvhqmwN0vDqI9ebkdSDnDMeVBBWc1ds H0fF4am/JlU5ZQUaIwoiazF+cvZBJ4Q6c6z3oD3kwxTspKHiz8WT7HxXOSdPlCZj bE6f2axknCkteUzB/fgs7dv/us/ClC5r9/W+aWdZdKm9Rlpg79jxdblqVLPAaCs= =mOYI -----END PGP SIGNATURE----- Aleisha Amohia (2): Bug 17895: 'Re-set' typo fix Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Blou (1): Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns Colin Campbell (1): Bug 16202: GetIssuingCharges should return a collectable amount Emma Smith (1): Bug 17840: adding classes to notes in checkouts Jonathan Druart (1): Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required Katrin Fischer (1): Bug 17260: DBRev 16.05.10.001 Marc V?ron (2): Bug 13968 - Branch email hints are misleading Bug 18122 - Audio alerts: Add hint on where to enable sounds Marcel de Rooy (1): Bug 7143: Replace Santallan by Santellan Mark Tompsett (1): Bug 13968: Follow up - Clean HTML tags for hints Mason James (3): Increment version for 16.05.11 release Translation updates for Koha 16.05.11 Add release notes for the 16.05.11 release Tomas Cohen Arazi (1): Bug 18275: Regression test ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 16:50:49 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 14:50:49 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via d451096fa4e9aff62838f8faf3101b3e67217227 (commit) via f22bf95489dfbd6fb155b16d296407ba5385ba85 (commit) via 532eac921789190f8b917caa48f77475061c6d74 (commit) via a35b28943a590c07e0f796163618ab238c82a98f (commit) via c8fc80862496e0b779ff38c90632e7266b9c25bc (commit) via ea70d6dfdff378dfad5570d32b33ea2b163ee569 (commit) via 1a565cf3c82c6ac410495d0da718bdbc6dd2f057 (commit) via d06d5ac65b15d2873b3e04f889814947aff45bd9 (commit) via c58c89018ebbef09dc23144a7f2e6ec8a78309c1 (commit) via e9295c48f8625028778e96d3d2b161f87965fc62 (commit) via 51f608423f0097c90cf61d14e6a045624aec3df7 (commit) via f56aa64aa1735d4a6c8cbb98023dcfee2adfeafb (commit) via 2e6a37708ad937d960138547302f237cc224c9d8 (commit) via d872afba4b1d4e157bd3cd729af4b420cb61b1ad (commit) via 8679e5e6552f9c166c62e2513263a1f72bf3a3f3 (commit) from 5dcae133c18285d15fd5311c3b81d3dca280b127 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d451096fa4e9aff62838f8faf3101b3e67217227 Author: Mason James Date: Sat Mar 18 02:27:40 2017 +1300 Add release notes for the 16.05.11 release commit f22bf95489dfbd6fb155b16d296407ba5385ba85 Author: Mason James Date: Sat Mar 18 02:17:58 2017 +1300 Translation updates for Koha 16.05.11 commit 532eac921789190f8b917caa48f77475061c6d74 Author: Mason James Date: Sat Mar 18 02:07:00 2017 +1300 Increment version for 16.05.11 release commit a35b28943a590c07e0f796163618ab238c82a98f Author: Jonathan Druart Date: Wed Mar 15 14:52:49 2017 -0300 Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required From opac/opac-memberentry.pl, authnotrequired is set. That means a patron can access the page without being logged in. It is used on this page for the self registration feature. From C4::Auth::get_template_and_user, we have $userid = $q_userid; $q_userid is previously set to the 'userid' CGI param. We end up here if authonotrequired is set AND CGISESSID does not exist. Test plan: - Run: $ prove t/db_dependent/Auth.t => FAIL: Regression test for checkauth fails - Apply this patch - Run: $ prove t/db_dependent/Auth.t => SUCCESS: Tests pass. - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mason James commit c8fc80862496e0b779ff38c90632e7266b9c25bc Author: Tomas Cohen Arazi Date: Thu Mar 16 09:23:24 2017 -0300 Bug 18275: Regression test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mason James commit ea70d6dfdff378dfad5570d32b33ea2b163ee569 Author: Colin Campbell Date: Tue Apr 5 12:56:24 2016 +0100 Bug 16202: GetIssuingCharges should return a collectable amount Charges should not include elements less than a penny/cent they are not displayed but can be saved to the database causing "odd" behaviour down the line Make the routine round the resultant charge to nearest cent, so consistent values are returned. Removed the one case where it was rounded post call. Although the main danger is values generated by the discount calculation apply the rounding to all returned charges in case the item charge is defined using the 3rd or 4th decimal places. NOTE: prove -v t/db_dependent/Circulation.t triggers the change. Though, all the returned amounts are 0.00 only. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit d84ed89557e2c921f261b1c620434d432dcbd3f7) Signed-off-by: Katrin Fischer commit 1a565cf3c82c6ac410495d0da718bdbc6dd2f057 Author: Marcel de Rooy Date: Thu Jan 19 15:43:38 2017 +0100 Bug 7143: Replace Santallan by Santellan Missed one typo in about.tt. Can go along with the next patch here. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 13de29ad4465b964e37d4f460f5c9145e23939a1) Signed-off-by: Katrin Fischer Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt commit d06d5ac65b15d2873b3e04f889814947aff45bd9 Author: Marc V?ron Date: Wed Feb 15 10:24:56 2017 +0100 Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b6cb18c4a8292cabe5fd611b349b51d5c79b5fe4) Signed-off-by: Katrin Fischer commit c58c89018ebbef09dc23144a7f2e6ec8a78309c1 Author: Emma Smith Date: Tue Jan 17 03:23:18 2017 +0000 Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 257c1793420108f1cb5efdec7bf03649d41940a0) Signed-off-by: Katrin Fischer commit e9295c48f8625028778e96d3d2b161f87965fc62 Author: Mark Tompsett Date: Tue Feb 21 13:13:02 2017 -0500 Bug 13968: Follow up - Clean HTML tags for hints Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e9d5615e70056cd887b9471827611a78275016ab) Signed-off-by: Katrin Fischer commit 51f608423f0097c90cf61d14e6a045624aec3df7 Author: Marc V?ron Date: Sat Feb 18 17:15:06 2017 +0100 Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra - 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b2eb6109ff308de7d2bc9338d708ac7fe9b6e3d7) Signed-off-by: Katrin Fischer commit f56aa64aa1735d4a6c8cbb98023dcfee2adfeafb Author: Katrin Fischer Date: Sun Mar 12 23:09:39 2017 +0100 Bug 17260: DBRev 16.05.10.001 commit 2e6a37708ad937d960138547302f237cc224c9d8 Author: Blou Date: Fri Jan 27 16:51:26 2017 +0000 Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies 'type' as empty, which fails with Mysql 5.7+ which is more stringent. Also, forcing an empty value into a boolean also fails. Both issues arise when updatedatabase.pl hit 3.23.00.050. NOTE: both issues could also be resolved by actually setting values in the load file. This doesn't make this solution incorrect, though. To Test/reproduce: -1) Happens with Mysql 5.7.4. Maybe earlier, but certainly at that point. Use a Xenial kohadevbox to more easily test. 0) Find a database on 3.22 or earlier, save it. a) place sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf b) restart you mysql server c) drop the db and recreate it d) checkout the 3.22.x branch e) do a web install f) remove the added sql_mode g) restart the mysql server 1) Set your code base to master 2) run updatedatabase.pl 3) See the errors on 3.23.00.050 4) Apply the patch 5) Reload the 3.22 db. a) repeat steps 0(a)-0(g) b) don't forget the caching issues 6) succeed with updatedatabase.pl 7) drop the db and recreate it 8) run the web installer 9) notice no issues either. 10) run koha qa test tools NOTE: This bug only solved the upgrade portion. I added the kohastructure.sql change as well. I confirmed that all the code changes were triggered with this test plan. Signed-off-by: Mark Tompsett Signed-off-by: Mehdi Hamidi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 77337a2ab537843eab70cc06b8bc2531ad2014dc) Signed-off-by: Katrin Fischer commit d872afba4b1d4e157bd3cd729af4b420cb61b1ad Author: Aleisha Amohia Date: Mon Jan 23 22:32:39 2017 +0000 Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e8420b5d80558a8a74f7f6a1421352dcad2c9c88) Signed-off-by: Katrin Fischer commit 8679e5e6552f9c166c62e2513263a1f72bf3a3f3 Author: Aleisha Amohia Date: Fri Jan 13 00:19:48 2017 +0000 Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 86ec263b2d0994ecb53ff283ef246b529d4570e2) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 +- C4/Circulation.pm | 4 +- Koha.pm | 2 +- Koha/SearchEngine/Elasticsearch.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 21 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 1 + .../prog/en/modules/admin/audio_alerts.tt | 7 + .../prog/en/modules/admin/branches.tt | 4 +- .../prog/en/modules/help/admin/audio_alerts.tt | 2 + koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- ...otes_16_5_9.html => release_notes_16_5_11.html} | 122 +- ...se_notes_16_5_9.md => release_notes_16_5_11.md} | 119 +- misc/translator/po/am-Ethi-marc-MARC21.po | 289 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 4 +- misc/translator/po/am-Ethi-pref.po | 16 + misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 2150 +-- misc/translator/po/ar-Arab-marc-MARC21.po | 289 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 4 +- misc/translator/po/ar-Arab-pref.po | 16 + misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 2158 +-- misc/translator/po/as-IN-marc-MARC21.po | 289 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 4 +- misc/translator/po/as-IN-pref.po | 16 + misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 2146 +-- misc/translator/po/az-AZ-marc-MARC21.po | 289 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 4 +- misc/translator/po/az-AZ-pref.po | 16 + misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 2148 +-- misc/translator/po/be-BY-marc-MARC21.po | 289 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 4 +- misc/translator/po/be-BY-pref.po | 16 + misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 2148 +-- misc/translator/po/bg-Cyrl-marc-MARC21.po | 289 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 4 +- misc/translator/po/bg-Cyrl-pref.po | 16 + misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 2150 +-- misc/translator/po/bn-IN-marc-MARC21.po | 289 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 4 +- misc/translator/po/bn-IN-pref.po | 16 + misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 2150 +-- misc/translator/po/cs-CZ-marc-MARC21.po | 289 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 4 +- misc/translator/po/cs-CZ-pref.po | 16 + misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 2163 +-- misc/translator/po/cy-GB-marc-MARC21.po | 289 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 4 +- misc/translator/po/cy-GB-pref.po | 16 + misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 2146 +-- misc/translator/po/da-DK-marc-MARC21.po | 289 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 4 +- misc/translator/po/da-DK-pref.po | 16 + misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 2149 +-- misc/translator/po/de-DE-marc-MARC21.po | 293 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 4 +- misc/translator/po/de-DE-pref.po | 51 +- misc/translator/po/de-DE-staff-help.po | 10 +- misc/translator/po/de-DE-staff-prog.po | 2176 +-- misc/translator/po/el-GR-marc-MARC21.po | 289 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 68 +- misc/translator/po/el-GR-opac-bootstrap.po | 16 +- misc/translator/po/el-GR-pref.po | 78 +- misc/translator/po/el-GR-staff-help.po | 76 +- misc/translator/po/el-GR-staff-prog.po | 2247 +-- misc/translator/po/eo-marc-MARC21.po | 289 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 4 +- misc/translator/po/eo-pref.po | 16 + misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 2146 +-- misc/translator/po/es-ES-marc-MARC21.po | 293 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 4 +- misc/translator/po/es-ES-pref.po | 54 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 2180 +-- misc/translator/po/eu-marc-MARC21.po | 289 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 4 +- misc/translator/po/eu-pref.po | 16 + misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 2150 +-- misc/translator/po/fa-Arab-marc-MARC21.po | 289 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 4 +- misc/translator/po/fa-Arab-pref.po | 16 + misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 2148 +-- misc/translator/po/fi-FI-marc-MARC21.po | 289 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 4 +- misc/translator/po/fi-FI-pref.po | 16 + misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 2160 +-- misc/translator/po/fo-FO-marc-MARC21.po | 289 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 4 +- misc/translator/po/fo-FO-pref.po | 16 + misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 2146 +-- misc/translator/po/fr-FR-marc-MARC21.po | 289 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 4 +- misc/translator/po/fr-FR-pref.po | 16 + misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 2160 +-- misc/translator/po/gl-marc-MARC21.po | 289 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 4 +- misc/translator/po/gl-pref.po | 16 + misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 2146 +-- misc/translator/po/he-Hebr-marc-MARC21.po | 289 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 4 +- misc/translator/po/he-Hebr-pref.po | 16 + misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 2146 +-- misc/translator/po/hi-marc-MARC21.po | 289 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 4 +- misc/translator/po/hi-pref.po | 51 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 2177 +-- misc/translator/po/hr-HR-marc-MARC21.po | 289 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 4 +- misc/translator/po/hr-HR-pref.po | 16 + misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 2148 +-- misc/translator/po/hu-HU-marc-MARC21.po | 289 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 4 +- misc/translator/po/hu-HU-pref.po | 16 + misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 2146 +-- misc/translator/po/hy-Armn-marc-MARC21.po | 289 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 4 +- misc/translator/po/hy-Armn-pref.po | 16 + misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 2156 +-- misc/translator/po/ia-marc-MARC21.po | 289 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 4 +- misc/translator/po/ia-pref.po | 16 + misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 2146 +-- misc/translator/po/id-ID-marc-MARC21.po | 289 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 4 +- misc/translator/po/id-ID-pref.po | 16 + misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 2150 +-- misc/translator/po/iq-CA-marc-MARC21.po | 289 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 4 +- misc/translator/po/iq-CA-pref.po | 16 + misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 2146 +-- misc/translator/po/is-IS-marc-MARC21.po | 289 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 4 +- misc/translator/po/is-IS-pref.po | 16 + misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 2146 +-- misc/translator/po/it-IT-marc-MARC21.po | 289 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 14 +- misc/translator/po/it-IT-pref.po | 52 +- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 2174 +-- misc/translator/po/iu-CA-marc-MARC21.po | 289 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 4 +- misc/translator/po/iu-CA-pref.po | 16 + misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 2146 +-- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 289 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 4 +- misc/translator/po/ja-Jpan-JP-pref.po | 16 + misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 2146 +-- misc/translator/po/ka-marc-MARC21.po | 289 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 4 +- misc/translator/po/ka-pref.po | 16 + misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 2146 +-- misc/translator/po/km-KH-marc-MARC21.po | 289 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 4 +- misc/translator/po/km-KH-pref.po | 16 + misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 2146 +-- misc/translator/po/kn-Knda-marc-MARC21.po | 289 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 4 +- misc/translator/po/kn-Knda-pref.po | 16 + misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 2150 +-- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 289 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 4 +- misc/translator/po/ko-Kore-KP-pref.po | 22 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 2152 +-- misc/translator/po/ku-Arab-marc-MARC21.po | 289 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 4 +- misc/translator/po/ku-Arab-pref.po | 16 + misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 2148 +-- misc/translator/po/lo-Laoo-marc-MARC21.po | 289 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 4 +- misc/translator/po/lo-Laoo-pref.po | 16 + misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 2150 +-- misc/translator/po/mi-NZ-marc-MARC21.po | 289 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 4 +- misc/translator/po/mi-NZ-pref.po | 16 + misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 2146 +-- misc/translator/po/ml-marc-MARC21.po | 289 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 4 +- misc/translator/po/ml-pref.po | 16 + misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 2146 +-- misc/translator/po/mon-marc-MARC21.po | 289 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 4 +- misc/translator/po/mon-pref.po | 16 + misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 2146 +-- misc/translator/po/mr-marc-MARC21.po | 289 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 4 +- misc/translator/po/mr-pref.po | 16 + misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 2150 +-- misc/translator/po/ms-MY-marc-MARC21.po | 289 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 4 +- misc/translator/po/ms-MY-pref.po | 16 + misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 2150 +-- misc/translator/po/my-marc-MARC21.po | 289 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 4 +- misc/translator/po/my-pref.po | 16 + misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 2146 +-- misc/translator/po/ne-NE-marc-MARC21.po | 289 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 4 +- misc/translator/po/ne-NE-pref.po | 16 + misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 2150 +-- misc/translator/po/oc-marc-MARC21.po | 289 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 4 +- misc/translator/po/oc-pref.po | 16 + misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 2152 +-- misc/translator/po/pbr-marc-MARC21.po | 289 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 4 +- misc/translator/po/pbr-pref.po | 16 + misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 2146 +-- misc/translator/po/ro-RO-marc-MARC21.po | 289 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 4 +- misc/translator/po/ro-RO-pref.po | 16 + misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 2146 +-- misc/translator/po/ru-RU-marc-MARC21.po | 289 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 4 +- misc/translator/po/ru-RU-pref.po | 16 + misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 2148 +-- misc/translator/po/sd-PK-marc-MARC21.po | 289 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 4 +- misc/translator/po/sd-PK-pref.po | 16 + misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 2150 +-- misc/translator/po/sk-SK-marc-MARC21.po | 289 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 4 +- misc/translator/po/sk-SK-pref.po | 16 + misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 2157 +-- misc/translator/po/sl-SI-marc-MARC21.po | 289 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 4 +- misc/translator/po/sl-SI-pref.po | 16 + misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 2146 +-- misc/translator/po/sq-AL-marc-MARC21.po | 289 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 4 +- misc/translator/po/sq-AL-pref.po | 16 + misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 2150 +-- misc/translator/po/sr-Cyrl-marc-MARC21.po | 289 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 4 +- misc/translator/po/sr-Cyrl-pref.po | 16 + misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 2150 +-- misc/translator/po/sv-SE-marc-MARC21.po | 289 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 4 +- misc/translator/po/sv-SE-pref.po | 16 + misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 2167 +-- misc/translator/po/sw-KE-marc-MARC21.po | 289 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 4 +- misc/translator/po/sw-KE-pref.po | 16 + misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po |14533 +------------------- misc/translator/po/ta-marc-MARC21.po | 289 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 4 +- misc/translator/po/ta-pref.po | 16 + misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 2146 +-- misc/translator/po/tet-marc-MARC21.po | 289 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 4 +- misc/translator/po/tet-pref.po | 16 + misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 2152 +-- misc/translator/po/th-TH-marc-MARC21.po | 289 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 4 +- misc/translator/po/th-TH-pref.po | 16 + misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 2150 +-- misc/translator/po/tl-PH-marc-MARC21.po | 289 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 4 +- misc/translator/po/tl-PH-pref.po | 16 + misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 2146 +-- misc/translator/po/tr-TR-marc-MARC21.po | 293 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 4 +- misc/translator/po/tr-TR-pref.po | 55 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 2175 +-- misc/translator/po/uk-UA-marc-MARC21.po | 289 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 4 +- misc/translator/po/uk-UA-pref.po | 16 + misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 2152 +-- misc/translator/po/ur-Arab-marc-MARC21.po | 289 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 4 +- misc/translator/po/ur-Arab-pref.po | 16 + misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 2146 +-- misc/translator/po/vi-VN-marc-MARC21.po | 289 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 4 +- misc/translator/po/vi-VN-pref.po | 16 + misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 2149 +-- t/db_dependent/Auth.t | 29 +- 464 files changed, 80428 insertions(+), 90688 deletions(-) copy misc/release_notes/{release_notes_16_5_9.html => release_notes_16_5_11.html} (72%) copy misc/release_notes/{release_notes_16_5_9.md => release_notes_16_5_11.md} (66%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 3 18:22:24 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Apr 2017 16:22:24 +0000 Subject: [koha-commits] main Koha release repository branch 16.05.x updated. v16.05.11-14-g9de99ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.05.x has been updated via 9de99ca2d5494177bf4e0c805cc46cb3124fdd5c (commit) via 79551256839370ec7c711fe7ed91d08055d8d312 (commit) via 1d2313ec3401c2cbbf81e70f4baf86ddfc0d4280 (commit) via 99d35fdc71ed1690dc9c46aa8992088064e0250b (commit) via 3440d402e86247baa27bd051b379cda6539c528a (commit) via 32e7f2be6731bf1e39920e2aa39da26ada6831ea (commit) via bb51b7447fcd7592e683648f4854c15f26a57eb5 (commit) via 198f89bf1d2f072e1a0aaea032237d470272adf3 (commit) via 2560b7fa72ab3801257f4cd3d65506eb3405952f (commit) via b696300c3a2ddbd670775fe22a0cb95b61751abf (commit) via dde4036df4fba9b8d3652a78c320c42f9e71c660 (commit) via 9ae18c69dbbb34d7bacac27b1066f85af8a3a30c (commit) via faef4f5d866edbb30ed6cf62823cc969e8f9f8c6 (commit) via 94387428d5de8f2867653831a401a62f34a75040 (commit) from d451096fa4e9aff62838f8faf3101b3e67217227 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9de99ca2d5494177bf4e0c805cc46cb3124fdd5c Author: Mason James Date: Tue Apr 4 04:20:43 2017 +1200 Increment version for 16.05.12 release commit 79551256839370ec7c711fe7ed91d08055d8d312 Author: Mason James Date: Tue Apr 4 04:15:43 2017 +1200 Translation updates for Koha 16.05.12 commit 1d2313ec3401c2cbbf81e70f4baf86ddfc0d4280 Author: Jonathan Druart Date: Thu Feb 9 12:44:38 2017 +0100 Bug 15854: Use a READ and WRITE LOCK on message_queue To make sure we will not never get a race conditions for these kinds of notices, we need to add a LOCK on the message_queue table. This does not smell the best way to do that, but I faced deadlock issues when I tried to use "UPDATE FOR" https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html https://dev.mysql.com/doc/refman/5.7/en/commit.html To test this patch, or another solution, you need to apply manually this change: my $message = C4::Message->find_last_message($borrower, $type, $mtt); unless ( $message ) { + sleep(1); C4::Message->enqueue($letter, $borrower, $mtt); } else { And repeat the test plan from first patch. Do not forget to truncate the message_queue table. Followed test plans, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad) Signed-off-by: Katrin Fischer commit 99d35fdc71ed1690dc9c46aa8992088064e0250b Author: Jonathan Druart Date: Thu Feb 9 12:13:07 2017 +0100 Bug 15854: Simplify the code to limit race conditions There is an obvious race condition when CHECKIN and RENEWAL are generated from circulation.pl calling svc/renew or svc/checkin in AJAX. The 2 first queries will try to get the id of the last message (find_last_message) and if it does not exist, they will insert it. Theorically that could be lead to have several "digest" messages for a given patron. I did not recreate more than 2 messages, from the third one at least one of the two firsts existed in the DB already. This patch just simplifies the code to make the SELECT and INSERT or UPDATE closer and limit the race condition possibilities. Test plan: 0. Set RenewalSendNotice and circ rules to have a lot of renewals available 1. Use batch checkouts (or one by one) to check out several items to a patron 2. Empty message_queue (at least of this patron) 3. Renew them all at once ("select all" link, "renew or check in" button) 4. Check the message_queue Without this patch you have lot of chances to faced a race condition and get at least 2 messages for the same patron. This is not expected, we expect 1 digest with all the messages. With this patch apply you have lot of chances not to face it, but it's not 100% safe as we do not use a mechanism to lock the table at the DBMS level. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit 607b14516a955c9989e4764c69527edbc1f36ba0) Signed-off-by: Katrin Fischer commit 3440d402e86247baa27bd051b379cda6539c528a Author: Colin Campbell Date: Wed Nov 9 14:37:33 2016 +0000 Bug 17605: [STABLE] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy commit 32e7f2be6731bf1e39920e2aa39da26ada6831ea Author: Marcel de Rooy Date: Sun Jan 29 15:40:14 2017 +0100 Bug 18010: Remove potential exposure from gettemplate A similar bad template check from C4::Auth::get_template_and_user should be applied in C4::Templates::gettemplate. Before this patch it would be possible to expose files like: my $template = C4::Templates::gettemplate( '/etc/passwd', 'intranet', CGI::new, 1 ); print $template->output; Note that the is_plugin flag in the above call is the culprit. This patch provides a quick security fix without touching get_template_and_user, and can be backported to stable branches. I will provide an enhanced and centralized check on report 17989, also removing the is_plugin flag. Note: We allow .pref here too for use in admin/preferences.pl. Test plan: [1] Run t/db_dependent/Auth.t (triggering get_template_and_user and gettemplate). [2] Run t/db_dependent/Templates.t again (see first test plan). The tests should no longer fail. [3] Open a page on opac or intranet. [4] Open a systempreferences tab. [5] Add a book to the cart and send it ([opac-]sendbasket uses gettemplate). Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit fbbd4b40f0d71b79194fc186e66f985488be26c6) Signed-off-by: Katrin Fischer commit bb51b7447fcd7592e683648f4854c15f26a57eb5 Author: Marcel de Rooy Date: Sun Jan 29 15:52:22 2017 +0100 Bug 18010: Unit test for gettemplate A trivial test, similar to the ones in Auth.t. Without the check in gettemplate (added in the second patch), the passwd file will be exposed and the test fails. Test plan: Run t/db_dependent/Templates.t without second patch. The two tests in the last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit 5508897d5a2b73c30d50fed26a6bfed62bf49398) Signed-off-by: Katrin Fischer Conflicts: t/db_dependent/Templates.t commit 198f89bf1d2f072e1a0aaea032237d470272adf3 Author: Jonathan Druart Date: Wed Feb 1 12:42:43 2017 +0100 Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). NOTE: last tweak was mid 2016, but before that 2015. So I agree with the deletion. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit a6f50cbcb92c2575eb31e906ea54bf0386654906) Signed-off-by: Katrin Fischer commit 2560b7fa72ab3801257f4cd3d65506eb3405952f Author: Jonathan Druart Date: Tue Feb 7 09:10:42 2017 +0100 Bug 18069: Remove residue of rebuild_zebra -x Bug 17731 removed the -x option of rebuild_zebra but koha-rebuild-zebra still cals the script with this option. "Warning: You passed -x which is already the default and is now deprecated" Test plan: sudo koha-rebuild-zebra -f should no longer raise the warning Signed-off-by: Mason James Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit fe898bc641b6d76d7b869654dce4ec21e219daf8) Signed-off-by: Katrin Fischer commit b696300c3a2ddbd670775fe22a0cb95b61751abf Author: Jonathan Druart Date: Tue Feb 14 15:22:40 2017 +0000 Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22) Signed-off-by: Katrin Fischer commit dde4036df4fba9b8d3652a78c320c42f9e71c660 Author: Jonathan Druart Date: Tue Feb 14 16:19:25 2017 +0100 Bug 18094: Add tests to highlight the problem Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit f86500351af0a1a4d1593eb2aa689b8ec52bc401) Signed-off-by: Katrin Fischer Conflicts: t/db_dependent/Utils/Datatables_Members.t commit 9ae18c69dbbb34d7bacac27b1066f85af8a3a30c Author: Marc V?ron Date: Sat Mar 11 19:17:37 2017 +0100 Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 37da40b323d8bc012724510fe4839dcb908c2b3b) Signed-off-by: Katrin Fischer commit faef4f5d866edbb30ed6cf62823cc969e8f9f8c6 Author: Marc V?ron Date: Sat Mar 11 17:18:10 2017 +0100 Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 20ad341eefc555e0cf2b0f2862347e8a48b28935) Signed-off-by: Katrin Fischer commit 94387428d5de8f2867653831a401a62f34a75040 Author: David Gustafsson Date: Mon Mar 20 15:13:13 2017 +0100 Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit a649958315c98500ebe0ea3f91c05a8067d54e58) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 64 +++---- C4/Templates.pm | 1 + C4/Utils/DataTables/Members.pm | 2 +- Koha.pm | 2 +- Koha/EDI.pm | 2 + debian/scripts/koha-rebuild-zebra | 8 +- install_misc/UpgradeBackup.pm | 94 ---------- install_misc/debian.packages | 148 --------------- install_misc/environment_Makefile.PL | 80 -------- install_misc/ubuntu-packages.sh | 194 -------------------- install_misc/ubuntu.10.04.packages | 163 ---------------- install_misc/ubuntu.12.04.packages | 168 ----------------- install_misc/ubuntu.packages | 168 ----------------- installer/data/mysql/updatedatabase.pl | 6 + .../lib/jquery/plugins/jquery.fixFloat.js | 3 +- misc/translator/po/cs-CZ-marc-MARC21.po | 22 +-- misc/translator/po/cs-CZ-staff-prog.po | 53 +++--- misc/translator/po/de-DE-opac-bootstrap.po | 8 +- misc/translator/po/de-DE-staff-help.po | 8 +- misc/translator/po/de-DE-staff-prog.po | 13 +- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 2 +- misc/translator/po/el-GR-pref.po | 19 +- misc/translator/po/el-GR-staff-help.po | 36 ++-- misc/translator/po/el-GR-staff-prog.po | 41 ++--- misc/translator/po/fi-FI-marc-MARC21.po | 8 +- misc/translator/po/fr-FR-marc-MARC21.po | 10 +- misc/translator/po/fr-FR-opac-bootstrap.po | 10 +- misc/translator/po/fr-FR-pref.po | 60 +++++- misc/translator/po/fr-FR-staff-prog.po | 33 ++-- misc/translator/po/hi-marc-MARC21.po | 8 +- misc/translator/po/hi-pref.po | 15 +- misc/translator/po/hi-staff-prog.po | 49 ++--- misc/translator/po/it-IT-marc-MARC21.po | 10 +- misc/translator/po/it-IT-pref.po | 18 +- misc/translator/po/it-IT-staff-help.po | 12 +- misc/translator/po/ko-Kore-KP-pref.po | 6 +- patroncards/edit-layout.pl | 6 +- t/db_dependent/Templates.t | 14 +- t/db_dependent/Utils/Datatables_Members.t | 31 +++- 42 files changed, 354 insertions(+), 1247 deletions(-) delete mode 100644 install_misc/UpgradeBackup.pm delete mode 100644 install_misc/debian.packages delete mode 100644 install_misc/environment_Makefile.PL delete mode 100755 install_misc/ubuntu-packages.sh delete mode 100644 install_misc/ubuntu.10.04.packages delete mode 100644 install_misc/ubuntu.12.04.packages delete mode 100644 install_misc/ubuntu.packages hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 10 23:56:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Apr 2017 21:56:35 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-32-gdbd6ec6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via dbd6ec62a40d4cb52da8911174f158288b498886 (commit) via a59f056631e882ce166eed7eb6e366481449b148 (commit) via ad24c194bd0e44688805e394512a0fbe4aed4095 (commit) via 2f77044f63e1d7faef3692a8533b2c56c2b723ab (commit) via 6bf6a53b86a688bead0b8b3b114c9dc509a661ae (commit) via 74949be55a268f588e3eeaeafc52a87538005743 (commit) from 9668331d4260928dbe91ec9710031e5ac63f5346 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dbd6ec62a40d4cb52da8911174f158288b498886 Author: Fridolin Somers Date: Fri Mar 24 16:07:16 2017 +0100 Bug 18329 - Batch record deletion broken Hie, Tools > Batch record deletion seems broken. Any deletion returns error : Bibliographic record YYY was not deleted. An error occurred. (The error was: {UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at /home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more information). Looks like it is because of Bug 18242 which added a transaction in C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do. The script batch_delete_records created a transaction with $dbh->{AutoCommit} = 0; This patch fixes by using also Koha::Schema in batch_delete_records to manage transaction. It also removes "$dbh->{RaiseError} = 1", this behavior is managed in Koha::Database. Test plan : - Go to Staff interface : Tools > Batch record deletion - Enter a few existing biblionumbers - Click on "Continue" - Click on "Delete selected records" => Without patch you get a DB error => With patch you get confirmation message - Try to get the biblios to confirm they are deleted : /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx - Test with and without Plack Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall (cherry picked from commit 0f32bd99997c82cf7b70eef32818dc817cbff64b) Signed-off-by: Katrin Fischer commit a59f056631e882ce166eed7eb6e366481449b148 Author: Jonathan Druart Date: Tue Mar 21 12:24:28 2017 -0300 Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. commit ad24c194bd0e44688805e394512a0fbe4aed4095 Author: Jonathan Druart Date: Mon Apr 3 10:07:28 2017 -0300 Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues commit 2f77044f63e1d7faef3692a8533b2c56c2b723ab Author: Jonathan Druart Date: Thu Mar 9 16:58:17 2017 -0300 Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit 7aa0808ff227850fc448b74dabed9b15ac0eb927) Signed-off-by: Katrin Fischer commit 6bf6a53b86a688bead0b8b3b114c9dc509a661ae Author: Jonathan Druart Date: Thu Mar 9 16:41:31 2017 -0300 Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit 48b1328ebeb7ed2337ba75a582705389767b691a) Signed-off-by: Katrin Fischer commit 74949be55a268f588e3eeaeafc52a87538005743 Author: Christopher Brannon Date: Fri Mar 10 19:54:05 2017 +0000 Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 9098a4d3fa7268bf11ab108693192070c44c9eaf) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 2 +- C4/Circulation.pm | 70 +++++++++++++++++++++------------- admin/columns_settings.yml | 4 -- t/db_dependent/Circulation/Returns.t | 28 +++++++++++++- tools/batch_delete_records.pl | 21 +++++----- 5 files changed, 82 insertions(+), 43 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:09:07 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:09:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-786-g2471dab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2471dab71dff052b546f45690d8a3bea6f1f3811 (commit) from 7d35bdf58a0bcebab20df47b50b249cafe12ddb6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2471dab71dff052b546f45690d8a3bea6f1f3811 Author: Marcel de Rooy Date: Tue Apr 11 14:15:54 2017 +0200 Bug 18413: Fix Letters.t (following bug 17866) SendAlert now needs a userenv to find branch email and the fallback of KohaAdminEmailAddress if the branch mail is not filled. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Letters.t | 5 +++++ 1 file changed, 5 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:14:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:14:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-791-g392641f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 392641ff1ec0cf2b6480af134fd676edf64f4df7 (commit) via b61f73c48832e0f10ca799aa49682da37f1f44a1 (commit) via d28d5a280d590bb19afbea23705802aa46af5e6d (commit) via 6b75e5b4783cff1d14816ce363e8095569d67718 (commit) via 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b (commit) from 2471dab71dff052b546f45690d8a3bea6f1f3811 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 392641ff1ec0cf2b6480af134fd676edf64f4df7 Author: Marcel de Rooy Date: Fri Apr 7 10:13:00 2017 +0200 Bug 18349: [QA Follow-up] Add four missing error messages The error codes come from CanBookBeIssued. The warnings speak for themselves. Note that the GNA message is similar to the one used in opac-user.tt (gonenoaddress is translated to the patron as contact information not up-to-date). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b61f73c48832e0f10ca799aa49682da37f1f44a1 Author: Jonathan Druart Date: Fri Mar 31 13:25:13 2017 -0300 Bug 18349: Remove useless info in alert message Empty tags should be removed, and message id Note that not all error codes are covered here. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit d28d5a280d590bb19afbea23705802aa46af5e6d Author: Jonathan Druart Date: Fri Mar 31 13:22:05 2017 -0300 Bug 18349: If a confirmation is required, consider as blocker Only RENEW_ISSUE should not be considered as blocker, others should. Note that this code is not robust and the whole script as well as the return of CanBookBeIssued should be rewrittent completely. We need a small patch to easy backport to stable releases Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 6b75e5b4783cff1d14816ce363e8095569d67718 Author: Jonathan Druart Date: Thu Mar 30 21:51:28 2017 -0300 Bug 18349: $borrower is a hashref I guess this code was never called before... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b Author: Jonathan Druart Date: Wed Mar 29 18:25:40 2017 -0300 Bug 18349: SCO - Do not trust the confirmed flag The "confirmed" flag is used to know if that user confirmed a situation that needs a confirmation. But if the issue/renew is impossible the CanBookBeIssued and the 'impossible flags' should be checked. Otherwise a patron can checkout and renew bypassing the circulation rules (Understand 'no limit' here...) Test plan: Want to renew? Checkin $barcode, then /cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout Want to bypass the checkin? Same url... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 32 +++++++++--------- opac/sco/sco-main.pl | 35 +++++++++++--------- 2 files changed, 35 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:24:41 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:24:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-792-g87d1d42 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 87d1d42f525e2430e9a5f574758495fc32947a9f (commit) from 392641ff1ec0cf2b6480af134fd676edf64f4df7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87d1d42f525e2430e9a5f574758495fc32947a9f Author: Jonathan Druart Date: Wed Feb 15 08:39:23 2017 +0000 Bug 18121: Replace opac_news.new with opac_news.content in notices templates Bug 17960 replaces opac_news.new with opac_news.content, we can replace the content of the notices' templates automatically. Test plan: Checkout a commit prior to bug 17960. Install a new DB with sample data. You should have notices with <> Switch to a branch with this patch, on top of master Execute the updatedatabase.pl sript => The notices with opac_news.new should have been replaced with opac_news.content Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:31:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:31:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-793-ga6c26f0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a6c26f009536e831461c1e91f8bafe07ca75d283 (commit) from 87d1d42f525e2430e9a5f574758495fc32947a9f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a6c26f009536e831461c1e91f8bafe07ca75d283 Author: Jonathan Druart Date: Tue Apr 4 22:30:19 2017 -0300 Bug 18395: (bug 14610 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Patrons.pm | 67 ------------------------------------------------------- 1 file changed, 67 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:32:25 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:32:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-795-g17f4b05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 17f4b05d23cb19cebeedb361005bf411a5f25c60 (commit) via 6940aa91a53371ba49528022954a9a349044ab63 (commit) from a6c26f009536e831461c1e91f8bafe07ca75d283 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17f4b05d23cb19cebeedb361005bf411a5f25c60 Author: Jonathan Druart Date: Tue Apr 11 10:31:49 2017 -0300 Bug 14932: Do not call can_edit_subscription with an empty value ref($sub) eq 'ARRAY' should always be true, what we want is to call can_edit_subscription if there is at least 1 serial for this subscription. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 6940aa91a53371ba49528022954a9a349044ab63 Author: Olli-Antti Kivilahti Date: Thu Oct 1 15:23:23 2015 +0300 Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. Signed-off-by: Paul POULAIN Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:34:42 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:34:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-796-g476179a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 476179a12311b32643087cc8ec10c31409bb1b99 (commit) from 17f4b05d23cb19cebeedb361005bf411a5f25c60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 476179a12311b32643087cc8ec10c31409bb1b99 Author: Marcel de Rooy Date: Tue Jan 10 10:03:36 2017 +0100 Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. t/Budgets.t returns green. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 2 +- admin/aqbudgetperiods.pl | 2 -- admin/aqbudgets.pl | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:36:42 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:36:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-797-g2be6625 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2be6625d1a8e537c2046f68990597c9e75e65d81 (commit) from 476179a12311b32643087cc8ec10c31409bb1b99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2be6625d1a8e537c2046f68990597c9e75e65d81 Author: Alex Arnaud Date: Wed Apr 5 15:01:53 2017 +0000 Bug 18388 - Standardize serials volume information displaying OPAC: Home > Details for (serial) Compared information in tab 'Holdings' col 'Vol info' with same information in staff client. With patch it's the same. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:49:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:49:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-801-g71f34c7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 71f34c7b34c355e0b8c0dead9f7ca49b4e1e1dc3 (commit) via b01fe1a666ee341c56a182ce34a39788d7e15224 (commit) via 3ca173fe405d9c786273fca0e372f4f9640224f3 (commit) via 95c96f823db485b4bdb1611bed303474444f7c99 (commit) from 2be6625d1a8e537c2046f68990597c9e75e65d81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 71f34c7b34c355e0b8c0dead9f7ca49b4e1e1dc3 Author: Marcel de Rooy Date: Fri Feb 3 11:49:30 2017 +0100 Bug 17737: [QA Follow-up] Remove unused reservedfor variable The changes in this patch set obsolete this variable. Remove confusing comment about reserve via host record. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b01fe1a666ee341c56a182ce34a39788d7e15224 Author: Jonathan Druart Date: Mon Jan 9 09:13:11 2017 +0100 Bug 17737: Rename holds_placed_before_today with current_holds Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 3ca173fe405d9c786273fca0e372f4f9640224f3 Author: Jonathan Druart Date: Wed Dec 7 14:04:17 2016 +0100 Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 95c96f823db485b4bdb1611bed303474444f7c99 Author: Jonathan Druart Date: Wed Dec 7 13:50:46 2016 +0100 Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 41 ----------------------------------------- Koha/Item.pm | 21 +++++++++++++++++++++ catalogue/detail.pl | 22 ++++++++++++---------- circ/transferstoreceive.pl | 8 +++++--- opac/opac-reserve.pl | 20 +++++++++----------- reserve/request.pl | 15 ++++++++------- t/db_dependent/Holds.t | 22 ++++++++++++++++------ t/db_dependent/Reserves.t | 25 ++++++++++++++----------- 8 files changed, 85 insertions(+), 89 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:51:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:51:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-803-gb038bb1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b038bb131082c7c165bc2a71a44e974e15ebd839 (commit) via b27b77307c24a60a0a49581396f01d19f87ebdb0 (commit) from 71f34c7b34c355e0b8c0dead9f7ca49b4e1e1dc3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b038bb131082c7c165bc2a71a44e974e15ebd839 Author: Marcel de Rooy Date: Fri Apr 7 11:56:52 2017 +0200 Bug 18208: [QA Follow-up] Get count from Koha::Items Removes the loop by moving the onloan test to the query. Test plan: Run the test again. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b27b77307c24a60a0a49581396f01d19f87ebdb0 Author: Tomas Cohen Arazi Date: Fri Mar 3 15:30:22 2017 -0300 Bug 18208: Add RecordProcessor filter to inject not onloan count to MARC records This patch adds a new filter for MARC records to be used with Koha::RecordProcessor. It's purpose is to inject the information about items not-onloan in a fixed subfield, 999$x. To test: - Apply the patch - Run: $ prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Followed test plan, test passes OK Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Filter/MARC/EmbedItemsAvailability.pm | 95 ++++++++++++++ .../Koha/Filter/EmbedItemsAvailability.t | 133 ++++++++++++++++++++ 2 files changed, 228 insertions(+) create mode 100644 Koha/Filter/MARC/EmbedItemsAvailability.pm create mode 100755 t/db_dependent/Koha/Filter/EmbedItemsAvailability.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:52:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:52:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-804-g5e185f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5e185f8036c7a0fb381462f3a716c8414278be1f (commit) from b038bb131082c7c165bc2a71a44e974e15ebd839 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5e185f8036c7a0fb381462f3a716c8414278be1f Author: Jonathan Druart Date: Wed Mar 15 13:10:16 2017 -0300 Bug 18274: C4::Items - Remove GetItemStatus This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemStatus should not return any used calls (only 1 occurrence in release notes) Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 92 ----------------------------------------------------------- 1 file changed, 92 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:52:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:52:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-805-gb09ac0a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b09ac0a5583afc30622af45af41c43078515b3ec (commit) from 5e185f8036c7a0fb381462f3a716c8414278be1f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b09ac0a5583afc30622af45af41c43078515b3ec Author: Marc V?ron Date: Tue Apr 4 13:03:04 2017 +0200 Bug 18375: Better readability of patron category table for zero ages and fees In patron category table, this patch displays zero / empty values for ages and fees with '-' for better readability To test: - Go to Home > Administration > Patron categories - Verify that you have 0 years and/or only years in Age required and Uper age limit colums - Verify that you have Enrollment and Hold fees of 0.00 - Apply patch - Verify that such values are replaced by - to enhance table readability Signed-off-by: Luke Honiss Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/categories.tt | 24 ++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:53:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:53:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-807-g6727a61 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6727a61578ec2b0ed3ebed182715a3f85c0b33d6 (commit) via 8d2517411774c82d665fd41446e4de082ff6f6fd (commit) from b09ac0a5583afc30622af45af41c43078515b3ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6727a61578ec2b0ed3ebed182715a3f85c0b33d6 Author: Julian Maurice Date: Wed Apr 5 15:37:35 2017 +0200 Bug 18394: Add an option to item search to export a barcodes file Test plan: 1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl) 2. Fill the form with whatever you want 3. Leave the 'Output' option to 'Screen' and click 'Search' 4. Verify that the search still works 5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search' 6. You should be able to download a 'barcodes.txt' file, open it and compare it to the previous search results 7. Now click on the 'Export results to barcodes file' button above the results, you should have the same result as in step 5 8. Verify that the CSV export still works Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8d2517411774c82d665fd41446e4de082ff6f6fd Author: Julian Maurice Date: Thu Apr 6 14:26:08 2017 +0200 Bug 18394: Remove useless code from item search The item search was originally designed to work even with JS disabled. Since bug 15111, the staff interface does not work at all without JS, so some parts of this code are useless and should be removed Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: catalogue/itemsearch.pl | 163 ++++++++++---------- .../prog/en/includes/catalogue/itemsearch_item.inc | 24 --- .../en/includes/catalogue/itemsearch_items.inc | 49 ------ .../prog/en/modules/catalogue/itemsearch.tt | 98 ++++++------ 4 files changed, 132 insertions(+), 202 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.inc delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 14:54:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 12:54:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-822-g0868b70 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0868b709811078405a834114e779e0a35184d54d (commit) via 630896330b0b5249c1a53342cdd1458e5677f7ee (commit) via dea93375dcc147280e93153b0a7e3b90ce66b4a0 (commit) via d49e8bd5e22a0b39e5628b24a033badc44a07bba (commit) via 7d536702792e2ff4d6a083b5ce5aa670fc88e0f9 (commit) via f953cc26e6e9569f6674e6186efc3e37b5c721b2 (commit) via 04263912c7e413c5dbf13fe61dcdfa4b4912ab56 (commit) via 06647d29a7c02b6483f27f6c46e9d0e639236d6e (commit) via 4c762ba69c0a85f3c5a3add40f8f4c16081965fe (commit) via 2bb870b3f0cadef851497ab1d4ad8783f47ac8f2 (commit) via 25c87a754203f38267eba219d34f86b5922be298 (commit) via 5cc310238558ceee83cb340c0246d47d880ccf57 (commit) via a26ec1b47f3834b529b75c79d3975be0d16f2ad4 (commit) via 7effc34cd251dd6e3841c365015ba8c9d4e68b46 (commit) via 7d762b1d8f1487a86c96e46e4fa03857ce0f3fa8 (commit) from 6727a61578ec2b0ed3ebed182715a3f85c0b33d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0868b709811078405a834114e779e0a35184d54d Author: Marcel de Rooy Date: Tue Apr 11 14:58:41 2017 +0200 Bug 9988: [QA Follow-up] Satisfy QA issues [1] See comment102. Moved sub reporting_tag_xml to MergeRequest.pm. Adjusted t/db_dependent/Koha/Authorities.t accordingly. This resolves the C3 inconsistent hierarchy errors. [2] Removed empty POD section Instance Methods from MergeRequests. This resolves the POD error in comment102 point 2. [3] Include a tag 100 for UNIMARC in reporting_tag_xml to resolve an error on encoding in MARC::File::XML. Subtest for oldmarc and subtest for reporting_tag_xml adjusted accordingly. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 630896330b0b5249c1a53342cdd1458e5677f7ee Author: Marcel de Rooy Date: Thu Feb 23 12:23:36 2017 +0100 Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit dea93375dcc147280e93153b0a7e3b90ce66b4a0 Author: Marcel de Rooy Date: Wed Feb 22 16:51:58 2017 +0100 Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit d49e8bd5e22a0b39e5628b24a033badc44a07bba Author: Marcel de Rooy Date: Thu Feb 23 12:46:52 2017 +0100 Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 7d536702792e2ff4d6a083b5ce5aa670fc88e0f9 Author: Marcel de Rooy Date: Thu Feb 23 12:46:52 2017 +0100 Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit f953cc26e6e9569f6674e6186efc3e37b5c721b2 Author: Marcel de Rooy Date: Wed Feb 22 10:53:03 2017 +0100 Bug 9988: Remove further references to dontmerge [1] The preference was sent to HEA. We can now send both AuthorityMergeMode as well as AuthorityMergeLimit. [2] A comment in authorities/merge.pl is removed. Note that a subsequent patch will modify and test the cron job. [3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge. This is equivalent to setting the mergelimit to zero. The function defnonull is no longer needed. (If the pref was NULL, we restore that value. Sub merge won't mind.) Test plan: [1] Run t/db_dependent/UsageStats.t [2] Run misc/batchRebuildItemsTables.pl -t This just ensures you it still compiles; the changes speak for itself. [3] Now git grep on dontmerge. You should only find hits in atomicupdate and misc/translator/po. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 04263912c7e413c5dbf13fe61dcdfa4b4912ab56 Author: Marcel de Rooy Date: Tue Feb 21 11:54:23 2017 +0100 Bug 9988: Check the merge limit in sub merge At this point, we are replacing dontmerge functionality by the new AuthorityMergeLimit logic. Instead of doing this check before calling merge, we just call merge and check it there. In order to let the cron job do the larger (postponed) merges, we add a parameter override_limit. A subtest is added in Merge.t to test the 'postponed merge' feature. Since merge now also calls get_usage_count, an additional mock is added. All references to dontmerge are removed. In merge two lines, initializing $dbh and $counteditbiblios, are moved. The dontmerge test in DelAuthority and ModAuthority is removed. Since this did not leave much in ModAuthority, I fixed the whitespace on the remaining lines rightaway (yes, I know). A minimal set of changes is applied to the cron script; it will get further attention on a next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Set AuthorityMergeLimit to 2. Modify an authority with two linked biblios. Check that the merge was done immediately. [3] Now modify an authority with more than 2 linked records. Verify that the merge was postponed; a record must be inserted in the need_merge_authorities table. [4] Testing of the merge cron job is *postponed* to a next patch. Note: I tested a modification, but the script just needs more attention. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 06647d29a7c02b6483f27f6c46e9d0e639236d6e Author: Marcel de Rooy Date: Tue Feb 21 09:22:59 2017 +0100 Bug 9988: Remove the Zebra code from sub merge Since we can now call linked_biblionumbers, we can now remove all Zebra related code from merge. We also add a parameter biblionumbers; we use it in the test now, but it may be handy too later in the maintenance script when we want to trigger a merge for specific biblionumber(s). See bug report 18071. All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the merge test can now be replaced by one mock for linked_biblionumbers. Note that we test the biblionumbers parameter in the last subtest without that mock. Remove unused vars $countunmodifiedbiblio, $counterrors from merge. Renamed zebrarecords to linkedrecords in the Merge test. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Modify an authority record. Check the linked biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 4c762ba69c0a85f3c5a3add40f8f4c16081965fe Author: Marcel de Rooy Date: Tue Feb 21 08:39:24 2017 +0100 Bug 9988: Merge should have a parameter hash We will need a few additional parameters for merge later on. This patch puts the original parameters in a parameter hash. For the same reason DelAuthority gets a parameter hash here. Note: We remove the second parameter from the DelAuthority call in authorities/authorities-home.pl here. It was not used and could have presented problems in the future. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t. [2] Run t/db_dependent/Authorities/Merge.t. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 2bb870b3f0cadef851497ab1d4ad8783f47ac8f2 Author: Marcel de Rooy Date: Wed Feb 15 15:48:17 2017 +0100 Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority When replacing the Zebra code in sub merge, we actually need CountUsage as well as the results it gets from SearchEngine. In order to get count and/or results, we now create: [1] instance methods get_usage_count and linked_biblionumbers in Koha::Authority, [2] class methods of the same name in Koha::Authorities. The instance method calls the class method. The class method can be used for deleted authority records, and in 'legacy calls' before refactoring. Note: On BZ 18149 we will replace all CountUsage calls. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 25c87a754203f38267eba219d34f86b5922be298 Author: Marcel de Rooy Date: Wed Feb 15 15:48:17 2017 +0100 Bug 9988: Add extract_biblionumber to Koha/SearchEngine When we will replace the Zebra code in sub merge, we will call SearchEngine to pass records and we need a routine to extract a biblionumber from a search result record. A record from Zebra still must be converted to MARC::Record. This is no longer needed for a ElasticSearch record. Test plan: Run t/db_dependent/Koha/SearchEngine/Search.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 5cc310238558ceee83cb340c0246d47d880ccf57 Author: Marcel de Rooy Date: Sun Jan 1 11:50:44 2017 +0100 Bug 9988: Add Koha objects for table need_merge_authorities This patch adds two Koha objects: MergeRequest(s). MergeRequest has a new method and an oldmarc method. A class method reporting_tag_xml is added to MergeRequests.pm. All new routines are tested in Authorities.t. Removes a few unneeded modules from Koha::Authority. Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit a26ec1b47f3834b529b75c79d3975be0d16f2ad4 Author: Marcel de Rooy Date: Tue Feb 14 09:07:27 2017 +0100 Bug 9988: DBIx schema changes for need_merge_authorities As generated by misc/devel/update_dbix_class_files.pl. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 7effc34cd251dd6e3841c365015ba8c9d4e68b46 Author: Marcel de Rooy Date: Tue Feb 14 08:42:04 2017 +0100 Bug 9988: Table revision for need_merge_authorities In order to let merge do exactly the same when called from the merge cron job, we need three additional fields in the table. The use of these fields will be explained in a follow-up. Test plan: Run the dbrev (updatestructure step in webinstaller). Signed-off-by: Marcel de Rooy Also tested running kohastructure.sql for this table. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 7d762b1d8f1487a86c96e46e4fa03857ce0f3fa8 Author: Marcel de Rooy Date: Tue Jan 10 11:39:31 2017 +0100 Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to zero and we will print a message about raising this value now. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 0 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. Signed-off-by: Marc V?ron Signed-off-by: Jacek Ablewicz Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 185 ++++++++++---------- C4/ImportBatch.pm | 2 +- C4/UsageStats.pm | 3 +- Koha/Authorities.pm | 57 ++++++ Koha/Authority.pm | 38 +++- Koha/Authority/MergeRequest.pm | 141 +++++++++++++++ Koha/Authority/MergeRequests.pm | 109 ++++++++++++ Koha/Schema/Result/NeedMergeAuthority.pm | 32 +++- Koha/SearchEngine/Elasticsearch/Search.pm | 16 ++ Koha/SearchEngine/Search.pm | 23 ++- Koha/SearchEngine/Zebra/Search.pm | 17 ++ authorities/authorities-home.pl | 2 +- authorities/authorities.pl | 2 +- authorities/merge.pl | 8 +- debian/koha-common.cron.daily | 1 + installer/data/mysql/atomicupdate/bug_9988a.perl | 19 ++ .../data/mysql/atomicupdate/bug_9988b_table.perl | 14 ++ .../data/mysql/atomicupdate/bug_9988c_cron.perl | 6 + installer/data/mysql/kohastructure.sql | 11 +- installer/data/mysql/sysprefs.sql | 2 +- .../en/modules/admin/preferences/authorities.pref | 10 +- misc/batchRebuildItemsTables.pl | 14 +- misc/cronjobs/crontab.example | 3 + misc/cronjobs/merge_authorities.pl | 89 ++++++++++ misc/migration_tools/merge_authority.pl | 103 ----------- misc/migration_tools/remove_unused_authorities.pl | 2 +- t/db_dependent/Authorities/Merge.t | 149 +++++++++++----- t/db_dependent/Authorities/MergeRequests.t | 44 +++++ t/db_dependent/AuthoritiesMarc.t | 2 +- t/db_dependent/Koha/Authorities.t | 169 +++++++++++++++++- t/db_dependent/Koha/SearchEngine/Search.t | 63 +++++++ t/db_dependent/UsageStats.t | 3 +- tools/batch_delete_records.pl | 2 +- 33 files changed, 1050 insertions(+), 291 deletions(-) create mode 100644 Koha/Authority/MergeRequest.pm create mode 100644 Koha/Authority/MergeRequests.pm create mode 100644 installer/data/mysql/atomicupdate/bug_9988a.perl create mode 100644 installer/data/mysql/atomicupdate/bug_9988b_table.perl create mode 100644 installer/data/mysql/atomicupdate/bug_9988c_cron.perl create mode 100755 misc/cronjobs/merge_authorities.pl delete mode 100755 misc/migration_tools/merge_authority.pl create mode 100644 t/db_dependent/Authorities/MergeRequests.t create mode 100644 t/db_dependent/Koha/SearchEngine/Search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 15:10:54 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 13:10:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-823-gb5fa491 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5fa49195557e23d027ed9f2db899e0b3970b760 (commit) from 0868b709811078405a834114e779e0a35184d54d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5fa49195557e23d027ed9f2db899e0b3970b760 Author: Kyle M Hall Date: Thu Apr 13 09:09:05 2017 -0400 Bug 9988 - DBRev 16.12.00.023 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/NeedMergeAuthority.pm | 20 ++++++------ installer/data/mysql/atomicupdate/bug_9988a.perl | 19 ------------ .../data/mysql/atomicupdate/bug_9988b_table.perl | 14 --------- .../data/mysql/atomicupdate/bug_9988c_cron.perl | 6 ---- installer/data/mysql/updatedatabase.pl | 32 ++++++++++++++++++++ 6 files changed, 43 insertions(+), 50 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_9988a.perl delete mode 100644 installer/data/mysql/atomicupdate/bug_9988b_table.perl delete mode 100644 installer/data/mysql/atomicupdate/bug_9988c_cron.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 15:12:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 13:12:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-825-gc1a460b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c1a460b5b2716b1fabd46b296117287c9935bbac (commit) via 98398a671544ec21cd099dc62336c1ca1cb81f18 (commit) from b5fa49195557e23d027ed9f2db899e0b3970b760 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c1a460b5b2716b1fabd46b296117287c9935bbac Author: Marcel de Rooy Date: Fri Apr 7 11:14:38 2017 +0200 Bug 14537: [QA Follow-up] Remove one overdues residue in pref description Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 98398a671544ec21cd099dc62336c1ca1cb81f18 Author: Aleisha Amohia Date: Wed Apr 5 04:19:18 2017 +0000 Bug 14537: Renaming OverdueNoticeBcc to NoticeBcc To test: 1) Apply patch and update database 2) Run 'git grep "OverdueNoticeBcc"' and confirm there are no other instances Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 2 +- .../atomicupdate/bug_14537_-_rename_OverdueNoticeBcc_syspref.sql | 1 + installer/data/mysql/sysprefs.sql | 2 +- .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_14537_-_rename_OverdueNoticeBcc_syspref.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 13 15:14:55 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Apr 2017 13:14:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-826-gd26b066 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d26b0668af62f0907a58108d4164ed27072317e9 (commit) from c1a460b5b2716b1fabd46b296117287c9935bbac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d26b0668af62f0907a58108d4164ed27072317e9 Author: Kyle M Hall Date: Thu Apr 13 09:14:24 2017 -0400 Bug 14537 - DBRev 16.12.00.024 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../bug_14537_-_rename_OverdueNoticeBcc_syspref.sql | 1 - installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_14537_-_rename_OverdueNoticeBcc_syspref.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 14 16:41:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Apr 2017 14:41:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-827-g508147d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 508147d24443498a2c12a7c55240e70941c49dd6 (commit) from d26b0668af62f0907a58108d4164ed27072317e9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 508147d24443498a2c12a7c55240e70941c49dd6 Author: Jonathan Druart Date: Mon Apr 3 12:50:27 2017 -0300 Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/UpgradeBackup.pm | 94 +++++++++++++++++++++++++++++++++++++++++ Makefile.PL | 2 +- 2 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 C4/Installer/UpgradeBackup.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 14 16:42:38 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Apr 2017 14:42:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-828-g87eb801 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 87eb80136d49451d0a9cc25e68db452a33f1771a (commit) from 508147d24443498a2c12a7c55240e70941c49dd6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87eb80136d49451d0a9cc25e68db452a33f1771a Author: Alex Buckley Date: Sat Apr 8 23:18:23 2017 +0000 Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/InstallAuth.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 14 16:43:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Apr 2017 14:43:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-829-g7df47b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7df47b48ba8a7241f062d14fb9f32770b80694d9 (commit) from 87eb80136d49451d0a9cc25e68db452a33f1771a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7df47b48ba8a7241f062d14fb9f32770b80694d9 Author: Fridolin Somers Date: Wed Dec 28 15:08:42 2016 +0100 Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 14 16:44:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Apr 2017 14:44:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-836-g36fd404 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 36fd40468950950c605b82fd918a5e932e2c6734 (commit) via 1a7a27a1c8d5e2960debd72381065cae86c3a715 (commit) via cb0e33f046547c919aff6684c47dcee282ab4d16 (commit) via 72dd80fae9acedab5bc9512bbbbfa79e0f57aa99 (commit) via 8d5b4306e07a594cd102fcce85f912ab3a5661e9 (commit) via 53ce807f6e6becc1e305d7743b8be9d5605a8c9a (commit) via 80018625cf03ccd00957035f99065ed5793b80e3 (commit) from 7df47b48ba8a7241f062d14fb9f32770b80694d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36fd40468950950c605b82fd918a5e932e2c6734 Author: Marcel de Rooy Date: Fri Apr 14 08:58:30 2017 +0200 Bug 17835: [QA Follow-up] Fix opac-search.pl Resolves: Global symbol "$itemtypes_nocategory" requires explicit package name. Signed-off-by: Marcel de Rooy Tested the added line with a debug statement. See itemtype facets in the search results. Signed-off-by: Kyle M Hall commit 1a7a27a1c8d5e2960debd72381065cae86c3a715 Author: Jonathan Druart Date: Thu Feb 9 09:15:29 2017 +0100 Bug 17835: Mock language pref value That way if prefs contain other languages, the test will still pass. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit cb0e33f046547c919aff6684c47dcee282ab4d16 Author: Jonathan Druart Date: Tue Jan 3 13:35:46 2017 +0100 Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. Bug 17835: follow-up Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 72dd80fae9acedab5bc9512bbbbfa79e0f57aa99 Author: Jonathan Druart Date: Tue Jan 3 11:36:25 2017 +0100 Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 8d5b4306e07a594cd102fcce85f912ab3a5661e9 Author: Jonathan Druart Date: Tue Jan 3 11:05:15 2017 +0100 Bug 17835: Replace GetItemTypes with Koha::ItemTypes Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 53ce807f6e6becc1e305d7743b8be9d5605a8c9a Author: Jonathan Druart Date: Tue Jan 3 09:22:48 2017 +0100 Bug 17835: Do not reselect translated_description if comes from search_with_localization If the Koha::ItemType object has been instanciated from a call to Koha::ItemTypes->search_with_localization, we already have the translated_description value. So there is no need to fetch it again from the DB. This is what this trick does: if the translated_description column exist in the DBIx::Class result source's column list, that means the value has already been retrieved. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 80018625cf03ccd00957035f99065ed5793b80e3 Author: Jonathan Druart Date: Mon Jan 2 17:29:32 2017 +0100 Bug 17835: Create a ItemtypeLocalization view To properly move C4::Koha::GetItemTypes to Koha::ItemTypes we need DBIx::Class to make a join on the localization table to retrieve the possible translated description of the item types. To do so there are 2 possibilities. The first one would have been to rename the localization table to something like itemtype_localization. That way we could have had a relationship between itemtype_localization.code and itemtypes.itemtype That would have meant to create one table per "entity" (here an entity is itemtype) we allow the translability. There are pros and cons for this choice, so I opt for another solution. The other solution is to create a view on top of this localization table. With this new view we can define the missing relationship. That sounds like a quite clean solution and easy to implement. Once we have this relationship, the Koha::ItemTypes->search_with_localization will join on this view an return the same result as GetItemTypes( style => 'array' ). To replace GetItemtypes( style => 'hash' ) which is the default behavior of this subroutine, we can do something like: my $itemtypes = Koha::ItemTypes->search_with_localization; my %itemtypes = map { $_->{itemtype} => $_ } @{ $itemtypes->unblessed }; This patchset must not introduce big changes but it changes certain behaviors (which were wrong) in some scripts. Indeed sometimes the descriptions of the item types were not the translated ones. Moreover it happens that the item types displayed in a dropdown list were not ordered by translated description, but by description of code (itemtypes.itemtype value). These 2 behaviors are what we expect. Test plan: Bugs will be hard to catch since these patches change a lot of file, it will be easier to read the diff and catch possible typos or logic errors. However signoffers can focus on modified files and the item types values. Signed-off-by: Josef Moravec Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 9 +- C4/Koha.pm | 86 +------------------- C4/Search.pm | 4 +- C4/XSLT.pm | 3 +- Koha/ItemType.pm | 8 ++ Koha/ItemTypes.pm | 25 +++++- Koha/Schema/Result/Itemtype.pm | 17 +++- Koha/Schema/Result/ItemtypeLocalization.pm | 32 ++++++++ Koha/Template/Plugin/ItemTypes.pm | 5 +- acqui/basketgroup.pl | 4 +- acqui/orderreceive.pl | 1 - admin/smart-rules.pl | 5 +- authorities/authorities.pl | 9 +- catalogue/detail.pl | 5 +- catalogue/moredetail.pl | 3 +- catalogue/search.pl | 7 +- cataloguing/addbiblio.pl | 9 +- cataloguing/additem.pl | 9 +- circ/view_holdsqueue.pl | 13 +-- course_reserves/add_items.pl | 5 +- .../prog/en/modules/reports/bor_issues_top.tt | 4 +- .../prog/en/modules/reports/cat_issues_top.tt | 4 +- .../prog/en/modules/reports/catalogue_out.tt | 4 +- .../prog/en/modules/reports/issues_stats.tt | 4 +- .../prog/en/modules/reports/itemslost.tt | 7 +- .../prog/en/modules/reports/reserves_stats.tt | 4 +- .../intranet-tmpl/prog/en/modules/tools/export.tt | 8 +- labels/label-item-search.pl | 13 +-- opac/opac-ISBDdetail.pl | 3 +- opac/opac-detail.pl | 5 +- opac/opac-readingrecord.pl | 4 +- opac/opac-reserve.pl | 13 +-- opac/opac-search.pl | 3 +- opac/opac-topissues.pl | 2 - opac/opac-user.pl | 3 +- reports/acquisitions_stats.pl | 6 +- reports/bor_issues_top.pl | 14 +--- reports/cat_issues_top.pl | 12 +-- reports/catalogue_out.pl | 19 +---- reports/catalogue_stats.pl | 3 +- reports/issues_avg_stats.pl | 3 +- reports/issues_stats.pl | 9 +- reports/itemslost.pl | 13 +-- reports/reserves_stats.pl | 13 +-- reserve/request.pl | 3 +- serials/subscription-add.pl | 4 +- serials/subscription-bib-search.pl | 5 +- suggestion/suggestion.pl | 2 +- svc/bib_profile | 3 +- t/db_dependent/Koha.t | 11 +-- t/db_dependent/Koha/ItemTypes.t | 52 +++++++++++- tools/batchMod.pl | 9 +- tools/export.pl | 14 +--- 53 files changed, 268 insertions(+), 267 deletions(-) create mode 100644 Koha/Schema/Result/ItemtypeLocalization.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Apr 16 15:24:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 16 Apr 2017 13:24:15 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-44-g5a5af02 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 5a5af02be9eda69c77146184fe8392ca9c4067f3 (commit) via 8c17314ef80cc54180446f7c3e85dbcf7125aebd (commit) via 0aff3c0231485e95dfe95556149d569b3818a674 (commit) via 3079f7a72515a22062bd9a65ec546cfcd6d9bb66 (commit) via 733d77520f92f9367fa0a100cdcda79d2a98232d (commit) via 061baca0884e27533ba8c37fb139644727fda7f5 (commit) via 042409941691b06db7e755247040781f867c0356 (commit) via fee024e18a0775c937671ca9c90e12a1992f1995 (commit) via 9062df67c8df0e6416ee69c01bf10e0acf111bf7 (commit) via 3ef6f12596d75ec2548e9081e89694df3536bb7e (commit) via dbee200409d738fcf7c4fdcfb2cd19f5d6d36c04 (commit) via 0a26e824ae3861fefb8a615c7e042fbfc83698f4 (commit) from dbd6ec62a40d4cb52da8911174f158288b498886 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5a5af02be9eda69c77146184fe8392ca9c4067f3 Author: Fridolin Somers Date: Wed Dec 28 15:08:42 2016 +0100 Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 7df47b48ba8a7241f062d14fb9f32770b80694d9) Signed-off-by: Katrin Fischer commit 8c17314ef80cc54180446f7c3e85dbcf7125aebd Author: Alex Buckley Date: Sat Apr 8 23:18:23 2017 +0000 Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 87eb80136d49451d0a9cc25e68db452a33f1771a) Signed-off-by: Katrin Fischer commit 0aff3c0231485e95dfe95556149d569b3818a674 Author: Jonathan Druart Date: Mon Apr 3 12:50:27 2017 -0300 Bug 18373: Re-add UpgradeBackup.pm Bug 18028 removed the install_misc directory but install_misc/UpgradeBackup.pm was still used by the 'upgrade' rule of make. Other files from install_misc were useless to it may be better not to reintroduce this directory with only 1 file. Test plan: `make` `sudo make install` `make upgrade` Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 508147d24443498a2c12a7c55240e70941c49dd6) Signed-off-by: Katrin Fischer commit 3079f7a72515a22062bd9a65ec546cfcd6d9bb66 Author: Marcel de Rooy Date: Tue Jan 10 10:03:36 2017 +0100 Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. t/Budgets.t returns green. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 476179a12311b32643087cc8ec10c31409bb1b99) Signed-off-by: Katrin Fischer commit 733d77520f92f9367fa0a100cdcda79d2a98232d Author: Jonathan Druart Date: Tue Apr 11 10:31:49 2017 -0300 Bug 14932: Do not call can_edit_subscription with an empty value ref($sub) eq 'ARRAY' should always be true, what we want is to call can_edit_subscription if there is at least 1 serial for this subscription. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 17f4b05d23cb19cebeedb361005bf411a5f25c60) Signed-off-by: Katrin Fischer commit 061baca0884e27533ba8c37fb139644727fda7f5 Author: Olli-Antti Kivilahti Date: Thu Oct 1 15:23:23 2015 +0300 Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. Signed-off-by: Paul POULAIN Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6940aa91a53371ba49528022954a9a349044ab63) Signed-off-by: Katrin Fischer commit 042409941691b06db7e755247040781f867c0356 Author: Marcel de Rooy Date: Fri Apr 7 10:13:00 2017 +0200 Bug 18349: [QA Follow-up] Add four missing error messages The error codes come from CanBookBeIssued. The warnings speak for themselves. Note that the GNA message is similar to the one used in opac-user.tt (gonenoaddress is translated to the patron as contact information not up-to-date). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 392641ff1ec0cf2b6480af134fd676edf64f4df7) Signed-off-by: Katrin Fischer commit fee024e18a0775c937671ca9c90e12a1992f1995 Author: Jonathan Druart Date: Fri Mar 31 13:25:13 2017 -0300 Bug 18349: Remove useless info in alert message Empty tags should be removed, and message id Note that not all error codes are covered here. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit b61f73c48832e0f10ca799aa49682da37f1f44a1) Signed-off-by: Katrin Fischer commit 9062df67c8df0e6416ee69c01bf10e0acf111bf7 Author: Jonathan Druart Date: Fri Mar 31 13:22:05 2017 -0300 Bug 18349: If a confirmation is required, consider as blocker Only RENEW_ISSUE should not be considered as blocker, others should. Note that this code is not robust and the whole script as well as the return of CanBookBeIssued should be rewrittent completely. We need a small patch to easy backport to stable releases Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit d28d5a280d590bb19afbea23705802aa46af5e6d) Signed-off-by: Katrin Fischer commit 3ef6f12596d75ec2548e9081e89694df3536bb7e Author: Jonathan Druart Date: Thu Mar 30 21:51:28 2017 -0300 Bug 18349: $borrower is a hashref I guess this code was never called before... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 6b75e5b4783cff1d14816ce363e8095569d67718) Signed-off-by: Katrin Fischer commit dbee200409d738fcf7c4fdcfb2cd19f5d6d36c04 Author: Jonathan Druart Date: Wed Mar 29 18:25:40 2017 -0300 Bug 18349: SCO - Do not trust the confirmed flag The "confirmed" flag is used to know if that user confirmed a situation that needs a confirmation. But if the issue/renew is impossible the CanBookBeIssued and the 'impossible flags' should be checked. Otherwise a patron can checkout and renew bypassing the circulation rules (Understand 'no limit' here...) Test plan: Want to renew? Checkin $barcode, then /cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout Want to bypass the checkin? Same url... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b) Signed-off-by: Katrin Fischer commit 0a26e824ae3861fefb8a615c7e042fbfc83698f4 Author: David Kuhn Date: Wed Dec 14 16:02:26 2016 -0800 Bug 17309 - Renewing and HomeOrHoldingBranch syspref The AddRenewal subroutine currently uses the circulation rules for the branch stored in the Issues table (which is the holding branch) when calculating the new due date. This patch replaces using the branch from the Issues table with the branch specified by the HomeOrHoldingBranch syspref. To test: 1. Set up 2 branches, Branch1 and Branch2 2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a 21 day renewal period. 3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a 14 day renewal period. 4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will receive the correct 21 day loan period. 5. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 14 day due date, rather than 21 days. 6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will receive the correct 14 day loan period. 7. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 21 day due date, rather than 14 days. 8. Apply the patch and repeat steps 4-7. The correct due date should be given when the item is renewed, regardless of where it is checked out or renewed. This update removes reassignment of $branch variable. Signed-off-by: C?dric Vita Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7d35bdf58a0bcebab20df47b50b249cafe12ddb6) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 2 +- C4/Circulation.pm | 2 +- C4/InstallAuth.pm | 4 + C4/Installer/UpgradeBackup.pm | 94 ++++++++++++++++++++ C4/Search.pm | 2 +- C4/Serials.pm | 6 +- Makefile.PL | 2 +- admin/aqbudgetperiods.pl | 2 - admin/aqbudgets.pl | 3 +- .../prog/en/modules/catalogue/results.tt | 3 +- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 32 +++---- opac/sco/sco-main.pl | 35 ++++---- 12 files changed, 144 insertions(+), 43 deletions(-) create mode 100644 C4/Installer/UpgradeBackup.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 17 19:59:26 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Apr 2017 17:59:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-838-gf04c5d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f04c5d5a2c549bed54036b726965ccda083def7b (commit) via 1c7d283aae0952877b871f486c31cd3f04529222 (commit) from 36fd40468950950c605b82fd918a5e932e2c6734 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f04c5d5a2c549bed54036b726965ccda083def7b Author: Jonathan Druart Date: Fri Mar 31 00:24:09 2017 -0300 Bug 18321: Correctly calculate switch_onsite_checkout Silly error here, the $switch_onsite_checkout is not correctly calculated, it should not only be set to the value of the syspref, but meet all the conditions. Test plan: Set a circ rule with number of on-site checkout = 2 and number of checkouts = 2. Switch on both ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts Do a regular checkout Do another regular checkout At this point you have reach the maximum number of checkouts allowed. Not try another one. => Without this patch you will not get the warning => With this patch you will see it Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 1c7d283aae0952877b871f486c31cd3f04529222 Author: Jonathan Druart Date: Fri Mar 31 00:23:19 2017 -0300 Bug 18321: Add tests Clean a bit existing tests by adding default values and add a test to highlight the issue. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 ++-- t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 25 +++++++++++++++++++- 2 files changed, 26 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 19 16:24:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Apr 2017 14:24:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-839-g8e5c9ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8e5c9bab4e791fdb6ac8cfc66078f206a169e2f7 (commit) from f04c5d5a2c549bed54036b726965ccda083def7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e5c9bab4e791fdb6ac8cfc66078f206a169e2f7 Author: Tomas Cohen Arazi Date: Wed Apr 19 11:19:26 2017 -0300 Bug 17835: (followup) Make TestBuilder skip views Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/TestBuilder.t | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 19 20:58:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Apr 2017 18:58:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-840-g07156cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 07156cf8fd0f11eb43a11ffa7f75d4c95f3766df (commit) from 8e5c9bab4e791fdb6ac8cfc66078f206a169e2f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 07156cf8fd0f11eb43a11ffa7f75d4c95f3766df Author: Owen Leonard Date: Tue Apr 11 16:45:40 2017 +0000 Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron Signed-off-by: Colin Campbell Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 20 15:03:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Apr 2017 13:03:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-841-g598ee32 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 598ee32db330bb8538147c8e162ea2e48ba26ecf (commit) from 07156cf8fd0f11eb43a11ffa7f75d4c95f3766df (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 598ee32db330bb8538147c8e162ea2e48ba26ecf Author: Jonathan Druart Date: Thu Apr 20 09:56:09 2017 -0300 Bug 17835: Re-add the use Koha in orderreceive It is still used for getitemtypeinfo, at least. ----------------------------------------------------------------------- Summary of changes: acqui/orderreceive.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 11:28:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 09:28:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-1-g2907d4b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2907d4bf907ec1d3f6a618f29bc5859837b559e4 (commit) from 2e9be0441c63603d1d48e5b4fb9272bef0dba071 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2907d4bf907ec1d3f6a618f29bc5859837b559e4 Author: Jonathan Druart Date: Tue Feb 14 14:39:48 2017 +0000 Bug 18058: Allow borrower_message_preferences to be truncated borrower_message_preferences cannot be truncated because of the foreign. DBMS fails with "Cannot truncate a table referenced in a foreign key constraint" To avoid that we should remove the FK check and truncate the other table as well. I am wondering if we really need a truncate here DELETE FROM borrower_message_preferences; should do the job, but leave it as it because of the param name. Test plan perl misc/maintenance/borrowers-force-messaging-defaults --doit --truncate Should no longer raise the error message Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit dd88c8f710e4915dac6437355c356f0632b776fb) Signed-off-by: Katrin Fischer (cherry picked from commit e2f860386dd811b2be3b2988b690c2d28d748336) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: misc/maintenance/borrowers-force-messaging-defaults | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 11:33:09 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 09:33:09 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-2-gc0e64cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c0e64cbc14750d61b853e1324827dcfb5eed3bc3 (commit) from 2907d4bf907ec1d3f6a618f29bc5859837b559e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0e64cbc14750d61b853e1324827dcfb5eed3bc3 Author: Jonathan Druart Date: Fri Feb 24 11:44:23 2017 +0100 Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable is reset but $borrower. In 16.11.x and before that causes the app to crash, because $borrower->{flags} is set to a hashref by GetMemberDetails, if $borrowernumber is set. This case is better handled in master (17.05) but side-effects could happen: if $borrowernumber is reset, $borrower should be reset too. The way to drive this behaviour is terrible and lot of things should be done to clean this area. This patch is a quick and easy fix to make it backportable easily. Test plan: On master, no change expected On 16.11 and before: 0. Set CircAutoPrintQuickSlip=clear screen 1. Create a new patron 2. Set permission for this patron to 'reservesforothers' (or something else). 3. Go on the circulation tab 4. Do not fill the barcode input and submit => Without this patch you will get an error Can't use string ("64") as a HASH ref while "strict refs".... => With this patch apply you will get a blank screen (expected behaviour). I would recommend to test this patch with the other value of CircAutoPrintQuickSlip as well (cherry picked from commit 34565e7f7d38298d37f449520dd5bc20cec833f8) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 11:39:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 09:39:27 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-3-g9573123 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 9573123fe233b638ea4c1329d56ea0a4fa8aab2b (commit) from c0e64cbc14750d61b853e1324827dcfb5eed3bc3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9573123fe233b638ea4c1329d56ea0a4fa8aab2b Author: Nick Clemens Date: Wed Jan 25 17:00:34 2017 +0000 Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit 3b794b1312d0cfac81b302d0e823e2c5683a1f0e) Signed-off-by: Katrin Fischer (cherry picked from commit 75ac2341774368975be08ee635851605f06a7b7d) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:05:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:05:21 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-5-ge7ba857 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via e7ba8570d3079290944dde285ec8c0be46d528c1 (commit) via d4ec1462ac9629df5d42200a7a6ceff1230d47d1 (commit) from 9573123fe233b638ea4c1329d56ea0a4fa8aab2b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e7ba8570d3079290944dde285ec8c0be46d528c1 Author: Marcel de Rooy Date: Tue Mar 28 16:39:25 2017 +0200 Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status The zero status should be added in @notforloans. It is a legitimate status for available books. The zero status description can be translated in the template. The 'Change item status' is confusing. We mean that we saw a notforloan status that we do not expect (read: does not exist in the table). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 664d6534171677455f3cf1467e8726146714133a) Signed-off-by: Katrin Fischer (cherry picked from commit dbb0b4a4b09233a7b68fc29deef8220f61fb5950) Signed-off-by: Julian Maurice commit d4ec1462ac9629df5d42200a7a6ceff1230d47d1 Author: Fridolin Somers Date: Fri Sep 12 15:21:18 2014 +0200 Bug 12913 - wrong inventory results when notforloan filter is not used In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status". The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem. Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Check the authorized value category has at least value '0' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9 - Delete new value created above, for example '9' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZZ' - Check 'Compare barcodes list to results' - Submit => without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0 => with patch, you get 1 result with 'Change item status' on item with notforloan=9 Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 358fb744c74cc63b7d2ae7d7e406ada205502ea8) Signed-off-by: Katrin Fischer (cherry picked from commit f75915336c072765a330ca7e39646326ef11212b) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/inventory.tt | 14 ++++++++---- tools/inventory.pl | 23 ++++++-------------- 2 files changed, 17 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:07:50 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:07:50 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-7-g2a552e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2a552e68a7478fb08e25762ceb801226357a8ba5 (commit) via ec356d7537f101eac874237f1fc136584db5f04b (commit) from e7ba8570d3079290944dde285ec8c0be46d528c1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a552e68a7478fb08e25762ceb801226357a8ba5 Author: Marcel de Rooy Date: Mon Feb 6 10:29:44 2017 +0100 Bug 14535: Update the supplier filter too The combobox on the left side of late orders is filled by sub GetBooksellersWithLateOrders. The same change as in the first patch must be made here to include suppliers with late orders without a price. Bonus: Sort the list. Test plan: [1] Run t/db_dependent/Bookseller.t. [2] Go to late orders. Use the filter on suppliers. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5) Signed-off-by: Katrin Fischer (cherry picked from commit 92ddd4bbc7f3f40241202ae19750e93d5ee2d30b) Signed-off-by: Julian Maurice commit ec356d7537f101eac874237f1fc136584db5f04b Author: Marcel de Rooy Date: Mon Feb 6 10:04:57 2017 +0100 Bug 14535: Late orders does not show orders with price = 0 This patch removes the filter of unitpricesupplier <> 0 and unitpricelib <> 0 from GetLateOrders as used in lateorders.pl. This allows you to claim late orders without a price entered. Test plan: [1] Run t/db_dependent/Acquisition.t [2] Check if you see an order with no price in lateorders.pl. (If needed, remove prices from a few orders.) Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 71f267fd3f3750510e3df5f2819d57ed45dcf919) Signed-off-by: Katrin Fischer (cherry picked from commit f305629f14ae925cf58dc62e39f871fd6ec1c8f5) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 6 +----- C4/Bookseller.pm | 2 -- acqui/lateorders.pl | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:10:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:10:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-8-gcccb867 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via cccb8672f529ac366614661d01ef94ee2eb82be7 (commit) from 2a552e68a7478fb08e25762ceb801226357a8ba5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cccb8672f529ac366614661d01ef94ee2eb82be7 Author: Marc V?ron Date: Fri Mar 10 11:22:24 2017 +0100 Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit a723de2ae0c393743fc111955ee81b5e6c5b7f4a) Signed-off-by: Katrin Fischer (cherry picked from commit da9371a1d6a257d6d598c9299a33aedff183fc4c) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Patroncards/Patroncard.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:15:58 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:15:58 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-10-g70fd259 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 70fd259dc8a22037f5af6ac12f2e0083aaf13ac4 (commit) via fd7d044cdb9858a146b40917bc11d8532378d9eb (commit) from cccb8672f529ac366614661d01ef94ee2eb82be7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70fd259dc8a22037f5af6ac12f2e0083aaf13ac4 Author: Marcel de Rooy Date: Fri Mar 17 13:24:41 2017 +0100 Bug 7728: [QA Follow-up] Fix POD whitespace Resolves complaints from qa tools. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 53f2b56fa15fac2f0d2ef0777e95f436d6914ec7) Signed-off-by: Katrin Fischer (cherry picked from commit b4ef4f4e3b1b6c2176d7faaa906d92b195dc4c55) Signed-off-by: Julian Maurice commit fd7d044cdb9858a146b40917bc11d8532378d9eb Author: Paul Poulain Date: Wed Dec 9 10:25:43 2015 +0000 Bug 7728: Fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 1843ee148b25a904d8baffbbe8f0ea504b539a64) Signed-off-by: Katrin Fischer (cherry picked from commit 30cfdb9096282175f4bf92b65021a8ef6e3fd052) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:19:28 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:19:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-11-g1453485 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 1453485a4c152b34c126f8218fd51348a48cd0fa (commit) from 70fd259dc8a22037f5af6ac12f2e0083aaf13ac4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1453485a4c152b34c126f8218fd51348a48cd0fa Author: Nick Clemens Date: Fri Mar 3 14:56:31 2017 +0000 Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f454013ec9beb8f6e4c382253b76bfac5ca65244) Signed-off-by: Katrin Fischer (cherry picked from commit 29526afcef6143ddafac8ffd00820ef9086ccaa0) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:22:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:22:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-13-g81438f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 81438f88341b43ca6dca8cf09cf96ccef1a18339 (commit) via 398ffb7aec7324db8515f3c3d13d58b3b9ab2cea (commit) from 1453485a4c152b34c126f8218fd51348a48cd0fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81438f88341b43ca6dca8cf09cf96ccef1a18339 Author: Jonathan Druart Date: Thu Mar 9 11:25:28 2017 -0300 Bug 18209: Add default, 'Actions' and fix case Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit f14de0007c47ae66d0276186df073c0375d37610) Signed-off-by: Katrin Fischer (cherry picked from commit 168a10de25ad64830ed0c448571e0607b64d4bd9) Signed-off-by: Julian Maurice commit 398ffb7aec7324db8515f3c3d13d58b3b9ab2cea Author: Blou Date: Fri Mar 3 16:13:40 2017 -0500 Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit bb1492e9f67439753bf428bd06fa710791e70c74) Signed-off-by: Katrin Fischer (cherry picked from commit 0a3b7777bbeb88e39903ceee35464d5eaec231e3) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/patroncards/manage.tt | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:29:54 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:29:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-14-g2e87e5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2e87e5eedf1873bde6eca96d0edbdea3f76e1961 (commit) from 81438f88341b43ca6dca8cf09cf96ccef1a18339 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2e87e5eedf1873bde6eca96d0edbdea3f76e1961 Author: Marc V?ron Date: Tue Mar 14 14:29:08 2017 +0100 Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat' To test: - Apply patch - Give a patron a high fine or credit (e.g. 12345.67) - Got to pages Home > Patrons > Accounts for... and Home > Patrons > Pay fines - Verify that amounts display following syspref 'CurrencyFormat' (e.g. 12'345.67 for syspref set to 360'000.00 (CH) Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit db467287d174827e52c322cb86d75b8628df52fe) Signed-off-by: Katrin Fischer (cherry picked from commit 3db9848f1acb904f67312c55a35fd262c46829aa) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 9 +++++---- koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 11 ++++++----- 2 files changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:42:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:42:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-15-g0d91438 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 0d914381e083efe36d9b0ae5e0f4ef67c1be2a6e (commit) from 2e87e5eedf1873bde6eca96d0edbdea3f76e1961 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d914381e083efe36d9b0ae5e0f4ef67c1be2a6e Author: Luke Honiss Date: Thu Jan 19 22:52:49 2017 +0000 Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl ==TEST PLAN== 1) Make a subscription with a record 2) Search and view the record in OPAC 3) Click on the subscription tab and click more details 4) The breadcrumb will say 'Detals for' without the record name 5) Apply patch 6) Refresh the page 7) The breadcrumb will display the name of the record (fixed small error) Signed-off-by: Sonia BOUIS Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 39bcba540a6c00fc374284dc025297a568befed6) Signed-off-by: Katrin Fischer (cherry picked from commit 9668331d4260928dbe91ec9710031e5ac63f5346) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: opac/opac-serial-issues.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:45:11 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:45:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-16-g6df6e15 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 6df6e1588b100a99ffe8f37a726f9cbf46b64362 (commit) from 0d914381e083efe36d9b0ae5e0f4ef67c1be2a6e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6df6e1588b100a99ffe8f37a726f9cbf46b64362 Author: Jonathan Druart Date: Tue Mar 21 12:24:28 2017 -0300 Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. (cherry picked from commit a59f056631e882ce166eed7eb6e366481449b148) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:51:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:51:04 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-17-g67610fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 67610fe524aa2eaba5b628751a4f16d019053c0c (commit) from 6df6e1588b100a99ffe8f37a726f9cbf46b64362 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67610fe524aa2eaba5b628751a4f16d019053c0c Author: David Kuhn Date: Wed Dec 14 16:02:26 2016 -0800 Bug 17309 - Renewing and HomeOrHoldingBranch syspref The AddRenewal subroutine currently uses the circulation rules for the branch stored in the Issues table (which is the holding branch) when calculating the new due date. This patch replaces using the branch from the Issues table with the branch specified by the HomeOrHoldingBranch syspref. To test: 1. Set up 2 branches, Branch1 and Branch2 2. Set up a loan rule in Branch1 for DVDs with a 21 day loan period and a 21 day renewal period. 3. Set up a loan rule in Branch2 for DVDs with a 14 day loan period and a 14 day renewal period. 4. Checkout a DVD belonging to Branch1 while logged into Branch2. It will receive the correct 21 day loan period. 5. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 14 day due date, rather than 21 days. 6. Checkout a DVD belonging to Branch2 while logged into Branch1. It will receive the correct 14 day loan period. 7. Renewing the same DVD while logged into either Branch1 or Branch2 will give a 21 day due date, rather than 14 days. 8. Apply the patch and repeat steps 4-7. The correct due date should be given when the item is renewed, regardless of where it is checked out or renewed. This update removes reassignment of $branch variable. Signed-off-by: C?dric Vita Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7d35bdf58a0bcebab20df47b50b249cafe12ddb6) Signed-off-by: Katrin Fischer (cherry picked from commit 0a26e824ae3861fefb8a615c7e042fbfc83698f4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 12:57:43 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 10:57:43 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-22-g841b717 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 841b7173344d17e4320e6eedec39836d6924c8b1 (commit) via fd9033f07732a01581741ea95a3420e5c828e4ce (commit) via 1d2da762873b5af1a2e57c108f6f4bfb7eeb9546 (commit) via bfffe0da9ee39661a92f127b6432cb229379938d (commit) via 9ac3ec0fd1a487859c35f2b61f2074b0c559ab50 (commit) from 67610fe524aa2eaba5b628751a4f16d019053c0c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 841b7173344d17e4320e6eedec39836d6924c8b1 Author: Marcel de Rooy Date: Fri Apr 7 10:13:00 2017 +0200 Bug 18349: [QA Follow-up] Add four missing error messages The error codes come from CanBookBeIssued. The warnings speak for themselves. Note that the GNA message is similar to the one used in opac-user.tt (gonenoaddress is translated to the patron as contact information not up-to-date). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 392641ff1ec0cf2b6480af134fd676edf64f4df7) Signed-off-by: Katrin Fischer (cherry picked from commit 042409941691b06db7e755247040781f867c0356) Signed-off-by: Julian Maurice commit fd9033f07732a01581741ea95a3420e5c828e4ce Author: Jonathan Druart Date: Fri Mar 31 13:25:13 2017 -0300 Bug 18349: Remove useless info in alert message Empty tags should be removed, and message id Note that not all error codes are covered here. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit b61f73c48832e0f10ca799aa49682da37f1f44a1) Signed-off-by: Katrin Fischer (cherry picked from commit fee024e18a0775c937671ca9c90e12a1992f1995) Signed-off-by: Julian Maurice commit 1d2da762873b5af1a2e57c108f6f4bfb7eeb9546 Author: Jonathan Druart Date: Fri Mar 31 13:22:05 2017 -0300 Bug 18349: If a confirmation is required, consider as blocker Only RENEW_ISSUE should not be considered as blocker, others should. Note that this code is not robust and the whole script as well as the return of CanBookBeIssued should be rewrittent completely. We need a small patch to easy backport to stable releases Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit d28d5a280d590bb19afbea23705802aa46af5e6d) Signed-off-by: Katrin Fischer (cherry picked from commit 9062df67c8df0e6416ee69c01bf10e0acf111bf7) Signed-off-by: Julian Maurice commit bfffe0da9ee39661a92f127b6432cb229379938d Author: Jonathan Druart Date: Thu Mar 30 21:51:28 2017 -0300 Bug 18349: $borrower is a hashref I guess this code was never called before... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 6b75e5b4783cff1d14816ce363e8095569d67718) Signed-off-by: Katrin Fischer (cherry picked from commit 3ef6f12596d75ec2548e9081e89694df3536bb7e) Signed-off-by: Julian Maurice commit 9ac3ec0fd1a487859c35f2b61f2074b0c559ab50 Author: Jonathan Druart Date: Wed Mar 29 18:25:40 2017 -0300 Bug 18349: SCO - Do not trust the confirmed flag The "confirmed" flag is used to know if that user confirmed a situation that needs a confirmation. But if the issue/renew is impossible the CanBookBeIssued and the 'impossible flags' should be checked. Otherwise a patron can checkout and renew bypassing the circulation rules (Understand 'no limit' here...) Test plan: Want to renew? Checkin $barcode, then /cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout Want to bypass the checkin? Same url... Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b) Signed-off-by: Katrin Fischer (cherry picked from commit dbee200409d738fcf7c4fdcfb2cd19f5d6d36c04) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 32 +++++++++--------- opac/sco/sco-main.pl | 35 +++++++++++--------- 2 files changed, 35 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:11:28 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:11:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-23-gcfe5a1b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via cfe5a1b29d24e050357ccb8998d5dd16fd5c4568 (commit) from 841b7173344d17e4320e6eedec39836d6924c8b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cfe5a1b29d24e050357ccb8998d5dd16fd5c4568 Author: Marcel de Rooy Date: Tue Jan 10 10:03:36 2017 +0100 Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. t/Budgets.t returns green. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 476179a12311b32643087cc8ec10c31409bb1b99) Signed-off-by: Katrin Fischer (cherry picked from commit 3079f7a72515a22062bd9a65ec546cfcd6d9bb66) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 2 +- admin/aqbudgetperiods.pl | 2 -- admin/aqbudgets.pl | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:13:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:13:31 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-24-g5104143 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 51041437ced506811b7b818ee4e14950efe7249c (commit) from cfe5a1b29d24e050357ccb8998d5dd16fd5c4568 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 51041437ced506811b7b818ee4e14950efe7249c Author: Alex Buckley Date: Sat Apr 8 23:18:23 2017 +0000 Bug 12930: Web installer does not show login errors Implemented invalid_username_or_password template variable being handed to Auth.tt. Removed indentation changes and modification to return value of checkpw Test plan: See comment #2 Alternative test plan: - Clear session cookies or close / open your browser - Go to [MY SERVER]/cgi-bin/koha/installer/install.pl - Verify that message appears if wrong username/pw provided - Verify that you can log in with databas administrator account Tested with alternative test plan, works as expected. Title and description in commit message adapted. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 87eb80136d49451d0a9cc25e68db452a33f1771a) Signed-off-by: Katrin Fischer (cherry picked from commit 8c17314ef80cc54180446f7c3e85dbcf7125aebd) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/InstallAuth.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:17:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:17:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-843-g2a8f748 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2a8f748f25e305deca7fce41451fbd78056ba26d (commit) via aa68e40005928150ac4aa1db8ce00716d7b7fe3f (commit) from 598ee32db330bb8538147c8e162ea2e48ba26ecf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a8f748f25e305deca7fce41451fbd78056ba26d Author: Kyle M Hall Date: Thu Jan 26 14:31:35 2017 +0000 Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall Signed-off-by: Joel Sasse Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit aa68e40005928150ac4aa1db8ce00716d7b7fe3f Author: Kyle M Hall Date: Tue Apr 18 07:38:42 2017 -0400 Bug 18001 - Unit Test Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/HoldsQueue.pm | 7 ++++++- t/db_dependent/HoldsQueue.t | 36 +++++++++++++++++++++++++++++++++++- 2 files changed, 41 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:33:03 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:33:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-844-gea04798 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ea04798a16ad8c8400030440e21825fc20b03808 (commit) from 2a8f748f25e305deca7fce41451fbd78056ba26d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea04798a16ad8c8400030440e21825fc20b03808 Author: Nick Clemens Date: Mon Apr 17 13:22:24 2017 -0400 Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Lari Taskula Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:35:45 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:35:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-846-gd51538c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d51538cb824387230b3e2cab955d3c16475bedde (commit) via b40456f7dd4b8a988f9c6a5718452936101cb8ff (commit) from ea04798a16ad8c8400030440e21825fc20b03808 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d51538cb824387230b3e2cab955d3c16475bedde Author: Marcel de Rooy Date: Thu Apr 20 12:52:47 2017 +0200 Bug 18364: [Follow-up] Also add an environment variable to prevent locking The test in SendCirculationAlert is extended by adding an env var called KOHA_NO_TABLE_LOCKS. If this var is set to a true value, the table locking is skipped too. This is useful when running a test without prove. The variable could be set in a shell profile. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b40456f7dd4b8a988f9c6a5718452936101cb8ff Author: Jonathan Druart Date: Fri Mar 31 13:43:38 2017 -0300 Bug 18364: Do not LOCK/UNLOCK tables from tests From the MySQL doc: "LOCK TABLES is not transaction-safe and implicitly commits any active transaction before attempting to lock the tables." If the LOCK/UNLOCK statements are executed from tests, the current transaction will be committed. To avoid that we need to guess if this code is execute from testsa or not (yes it is a bit hacky) Better ideas are welcome! Another fix would have been to revert commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad Bug 15854: Use a READ and WRITE LOCK on message_queue but theorically a race is still possible. Existing tests seem to be safe, to test this patch you will need new tests from bug 17964. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t twice, and notice that changes have been comitted. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:37:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:37:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-849-gea2196c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ea2196c6527c643873fb3161d3e07d23e0202f1d (commit) via de699909c29bf877b6bf37f15127804c1a2abc62 (commit) via f14d03b5a3d1e953da700c9379c1bd5c9ab79334 (commit) from d51538cb824387230b3e2cab955d3c16475bedde (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea2196c6527c643873fb3161d3e07d23e0202f1d Author: Jonathan Druart Date: Wed Apr 19 15:34:17 2017 -0300 Bug 17502: Add info when throwing the exception Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit de699909c29bf877b6bf37f15127804c1a2abc62 Author: Marcel de Rooy Date: Thu Mar 23 09:35:57 2017 +0100 Bug 17502: Throw some exceptions in output_pref Test plan: Run the adjusted t/DateUtils.t Signed-off-by: Josef Moravec NOTE: This patch is amended in QA. The exceptions are moved from a separate module to the general section of Exceptions.pm. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f14d03b5a3d1e953da700c9379c1bd5c9ab79334 Author: Marcel de Rooy Date: Thu Oct 27 09:11:03 2016 +0200 Bug 17502: Add type check to output_pref This patch makes the following changes: [1] In Koha/DateUtils.pm, sub output_pref: Add a test if $dt is really a DateTime before calling method ymd. Preventing a crash like: Can't locate object method "ymd" via package "dateonly". See also BZ 17502/15822. [2] Adds a few unit tests in t/DateUtils.t. Test plan: [1] Run the adjusted unit test t/DateUtils.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/DateUtils.pm | 11 +++++------ Koha/Exceptions.pm | 4 ++++ t/DateUtils.t | 46 ++++++++++++++++++++++++++++++++++++++-------- 3 files changed, 47 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:38:50 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:38:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-850-gafb62d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e (commit) from ea2196c6527c643873fb3161d3e07d23e0202f1d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e Author: pongtawat Date: Mon Dec 26 17:50:50 2016 +0700 Bug 17814: koha-plack --stop should make sure that Plack really stop koha-plack --stop doesn't ensure that Plack was really stopped before returning So in case that koha-plack --stop was quickly follows by koha-plack --start (e.g. logrotate), it could leave Plack in stop state. This is due to koha-plack --start think that Plack was already started, while it actually is being stopped. For me I think this is the cause why I got random Plack stop when logrotate is run. It should be similar to the case of Zebra in Bug #16885, and the solution might be the same: adding "--retry=TERM/30/KILL/5;" to start-stop-daemon command. TEST PLAN --------- 1) Login to staff client and do something that will hold connection for a long time, e.g. a batch import or a slow report. 2) sudo koha-plack --stop mykoha 3) ps aux | grep plack <-- a Plack process will still running work in 1) 4) wait for 1) to finish and all Plack processes exit 5) sudo koha-plack --start mykoha 6) apply the patch 7) repeat step 1)-2) 8) ps aux | grep plack <-- There should be no Plack process running now 9) Note that work in step 1) might get terminated midway. Since we force Plack to stop after some wait. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-plack | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:39:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:39:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-851-g46d0be3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 46d0be3114785c17e48df8bc31b515599d394789 (commit) from afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46d0be3114785c17e48df8bc31b515599d394789 Author: Mark Tompsett Date: Sun Jan 15 23:26:33 2017 -0500 Bug 17911: Message and timeout mismatch The installation step 3 has a meta refresh of 10 seconds, but the message says 5 seconds. People could get impatient. TEST PLAN --------- 1) Fresh install -- notice the discrepancy on the web installation. 2) drop and create the DB 3) apply the patch 4) run the web install -- notice it refreshes faster (5 seconds vs 10 seconds) 5) run koha qa test tools Works as intended and passes qa test tool OK koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 13:43:38 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 11:43:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-856-g185dc7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 185dc7f45af17bf70ec36125be736286a1f8b86e (commit) via b81a18ea39e1f360dc0dc4b7a874b614dc67d725 (commit) via b689c6f9fe31dea49657b65af4f6830af1b17433 (commit) via d18f30eb3f794a144989970893ef87d673cef8ec (commit) via e28f19f0a88e334c99a45fadf96ae504bbb17ebe (commit) from 46d0be3114785c17e48df8bc31b515599d394789 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 185dc7f45af17bf70ec36125be736286a1f8b86e Author: Nick Clemens Date: Tue Apr 18 14:03:37 2017 -0400 Bug 18423 - Followup - enable Add child button for institutional borrowers If they can have guarantors and we shwo the button on one page I think we should in fact show it on all. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b81a18ea39e1f360dc0dc4b7a874b614dc67d725 Author: Nick Clemens Date: Tue Apr 18 13:53:54 2017 -0400 Bug 18423 - Add 'Add child' button to files, housebound, and deletemem pages Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b689c6f9fe31dea49657b65af4f6830af1b17433 Author: Nick Clemens Date: Mon Apr 17 12:32:56 2017 -0400 Bug 18423 Follow-up - Add 'Add child' button to statistics tab Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit d18f30eb3f794a144989970893ef87d673cef8ec Author: Nick Clemens Date: Wed Apr 12 11:32:11 2017 -0400 Bug 18423 follow up - fix display off add child on members/notices.pl Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit e28f19f0a88e334c99a45fadf96ae504bbb17ebe Author: Nick Clemens Date: Wed Apr 12 10:23:56 2017 -0400 Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages. Tested 3 pateches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 1 - koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 2 +- members/boraccount.pl | 3 +-- members/deletemem.pl | 3 ++- members/files.pl | 1 + members/housebound.pl | 1 + members/mancredit.pl | 3 +-- members/maninvoice.pl | 3 +-- members/member-flags.pl | 3 +-- members/member-password.pl | 3 +-- members/moremember.pl | 1 - members/notices.pl | 3 +-- members/pay.pl | 3 +-- members/paycollect.pl | 3 +-- members/printfeercpt.pl | 2 +- members/printinvoice.pl | 2 +- members/readingrec.pl | 4 +--- members/routing-lists.pl | 2 +- members/statistics.pl | 2 ++ 19 files changed, 19 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:30:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:30:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-857-g3783695 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 37836951d38ed57c7ed5ed702aab1433729ffe0d (commit) from 185dc7f45af17bf70ec36125be736286a1f8b86e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 37836951d38ed57c7ed5ed702aab1433729ffe0d Author: Benjamin Rokseth Date: Tue Apr 1 14:07:59 2014 +0200 Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Checkin.pm | 8 ++++---- C4/SIP/Sip/MsgType.pm | 8 -------- 2 files changed, 4 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:31:56 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:31:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-858-geab4d43 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eab4d43a479c20c3708eb0765c9e92ee6f58e7d9 (commit) from 37836951d38ed57c7ed5ed702aab1433729ffe0d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eab4d43a479c20c3708eb0765c9e92ee6f58e7d9 Author: Tomas Cohen Arazi Date: Wed Apr 19 12:15:46 2017 -0300 Bug 18460: Fix undefined itemtype warning in Serials.t This patch makes the test create an itemtype, and use it for the created item so there's no warning. To test: - Run: $ prove t/db_dependent/Serials.t => FAIL: item-level_itypes set but no itemtype set... warning raised - Apply the patch - Run: $ prove t/db_dependent/Serials.t => SUCCESS: Tests pass and no warning is raised - Sign off :-D Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Serials.t | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:35:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:35:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-859-g8b0bed3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8b0bed34c20b21865d76992b7822bc3874867cbc (commit) from eab4d43a479c20c3708eb0765c9e92ee6f58e7d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8b0bed34c20b21865d76992b7822bc3874867cbc Author: Marc V?ron Date: Sun Mar 26 17:26:22 2017 +0200 Bug 18335 - Check in: Make patron info in hold messages obey syspref AddressFormat When checking in, information about patrons with a hold always display in an US style. Address information should opey the system preference AddressFormat To reproduce: - Set syspref AddressFormat to German style - Check out an item to a patron A - Put a hold on this item for patron B - Check in item using the Check in field in page header - Result: In message 'Hold found', address does not display in German style To test: - Apply patch - Repeat steps above - Verify that address displays as expected Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 28 +++++++----- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 45 ++++++++------------ 2 files changed, 35 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:50:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:50:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-866-g1a688ae Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1a688ae9e02f36a22890de44fb2ce7cdd0599c2d (commit) via eedb9d92336bfe9c0ea276bb41ceb52d8afbcf65 (commit) via acd91afd0c623e75ea9f9d7fb3b57a39bdfb1890 (commit) via 7ad1a5280c76bf955ce29f3610f7a7a8e4b1fb9f (commit) via 1a118ff85456b4b1a82cab28005d435650498ba6 (commit) via b7a4a64658b3a416c4c51cd1d3deeadb9719e053 (commit) via 8d749c133998d8c2ebda4a2db8d622085a658331 (commit) from 8b0bed34c20b21865d76992b7822bc3874867cbc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a688ae9e02f36a22890de44fb2ce7cdd0599c2d Author: Marcel de Rooy Date: Fri Apr 14 12:46:13 2017 +0200 Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit eedb9d92336bfe9c0ea276bb41ceb52d8afbcf65 Author: Marcel de Rooy Date: Thu Apr 13 09:02:55 2017 +0200 Bug 18420: Replace hardcoded EUR in OrderUsers.t Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit acd91afd0c623e75ea9f9d7fb3b57a39bdfb1890 Author: Jonathan Druart Date: Tue Apr 11 07:48:54 2017 -0300 Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 7ad1a5280c76bf955ce29f3610f7a7a8e4b1fb9f Author: Jonathan Druart Date: Tue Apr 11 07:33:32 2017 -0300 Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 1a118ff85456b4b1a82cab28005d435650498ba6 Author: Jonathan Druart Date: Wed Apr 12 11:10:57 2017 -0300 Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b7a4a64658b3a416c4c51cd1d3deeadb9719e053 Author: Jonathan Druart Date: Wed Apr 12 11:06:43 2017 -0300 Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 8d749c133998d8c2ebda4a2db8d622085a658331 Author: Jonathan Druart Date: Wed Apr 12 11:03:10 2017 -0300 Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Acquisition/OrderUsers.t | 6 +++-- t/db_dependent/Budgets.t | 6 ++--- t/db_dependent/Circulation.t | 27 ++++++++++---------- t/db_dependent/Circulation/IsItemIssued.t | 3 ++- .../Circulation/IssuingRules/maxsuspensiondays.t | 3 ++- t/db_dependent/Holds/HoldFulfillmentPolicy.t | 3 +-- t/db_dependent/Holds/HoldItemtypeLimit.t | 2 +- t/db_dependent/Holds/LocalHoldsPriority.t | 3 ++- t/db_dependent/Holds/RevertWaitingStatus.t | 3 ++- t/db_dependent/Members.t | 12 ++++----- t/db_dependent/Members/Attributes.t | 2 -- t/db_dependent/Passwordrecovery.t | 19 +++++++------- t/db_dependent/Patron/Borrower_Debarments.t | 3 ++- t/db_dependent/Patron/Borrower_Files.t | 3 ++- t/db_dependent/Serials_2.t | 3 ++- t/db_dependent/Suggestions.t | 19 ++++---------- 16 files changed, 58 insertions(+), 59 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:56:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:56:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-867-g4cb7119 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4cb7119e933009374fad8f192e1f30f819a74f88 (commit) from 1a688ae9e02f36a22890de44fb2ce7cdd0599c2d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4cb7119e933009374fad8f192e1f30f819a74f88 Author: Nick Clemens Date: Thu Apr 13 09:55:15 2017 -0400 Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc V?ron Works as expected. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/finishreceive.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:57:23 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:57:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-870-g9190300 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 919030069400a94c89276c0ebc17b9693369e679 (commit) via da172a560f7c4c2ba3eab69144ddcac9043b2c3b (commit) via 553ce38225b7334ef9354e7789b5a10e5a569bbf (commit) from 4cb7119e933009374fad8f192e1f30f819a74f88 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 919030069400a94c89276c0ebc17b9693369e679 Author: Jonathan Druart Date: Thu Apr 20 13:00:00 2017 -0300 Bug 18432: Replace 2 'he or she' with 'they' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit da172a560f7c4c2ba3eab69144ddcac9043b2c3b Author: Chris Cormack Date: Wed Apr 19 09:32:59 2017 +1200 Bug 18432 : Follow up - Updating to use they/them Updating to use they/them and skipping the ones changed to it Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 553ce38225b7334ef9354e7789b5a10e5a569bbf Author: phette23 Date: Thu Apr 13 14:26:07 2017 -0700 Bug 18432: code comments assume male gender Comments throughout the Koha codebase assume that all librarians or borrowers are male by using the pronoun 'he' universally. This patch changes to 'he or she' / 'him or hers'. Testing plan: - ensuring modifying tests still pass: + C4/SIP/t/06patron_enable.t + t/db_dependent/Circulation.t + t/db_dependent/Koha/Patrons.t + t/db_dependent/Reserves.t Sponsored-By: California College of the Arts No code changes detected. Signed-off-by: Marc V?ron Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 +- C4/Charset.pm | 2 +- C4/Circulation.pm | 4 ++-- C4/Overdues.pm | 2 +- C4/SIP/t/06patron_enable.t | 4 ++-- C4/Suggestions.pm | 4 ++-- acqui/addorderiso2709.pl | 2 +- acqui/neworderempty.pl | 8 ++++---- acqui/parcel.pl | 2 +- acqui/parcels.pl | 2 +- cataloguing/additem.pl | 2 +- installer/install.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/basketgroup.js | 3 ++- mainpage.pl | 2 +- misc/export_borrowers.pl | 2 +- misc/migration_tools/bulkmarcimport.pl | 2 +- opac/opac-discharge.pl | 2 +- opac/opac-user.pl | 2 +- reserve/request.pl | 2 +- t/db_dependent/Circulation.t | 6 +++--- t/db_dependent/Koha/Patrons.t | 4 ++-- t/db_dependent/Reserves.t | 4 ++-- 23 files changed, 34 insertions(+), 33 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:58:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:58:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-871-g7cbd956 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7cbd9561271c1ac9ca3ccfd8ef257259a341f464 (commit) from 919030069400a94c89276c0ebc17b9693369e679 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7cbd9561271c1ac9ca3ccfd8ef257259a341f464 Author: Marc V?ron Date: Tue Apr 18 09:21:45 2017 +0200 Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 16:59:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 14:59:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-873-g039bb20 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 039bb200de2507f81cafb88dfe826e74160d2fa2 (commit) via 925734ee781c3d64b8e360c34f7036d335fce67d (commit) from 7cbd9561271c1ac9ca3ccfd8ef257259a341f464 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 039bb200de2507f81cafb88dfe826e74160d2fa2 Author: Jonathan Druart Date: Tue Apr 18 15:13:18 2017 -0300 Bug 10357: Do not change the alerttype Previous patch modified the alerttype from "issue" to "issue_det" or "issue_ser". This is wrong, we do not want to modify this value, especially because it's used in C4::Letters::SendAlerts This patch uses a $referer variable instead, like it is already used in other scripts for redirection. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 925734ee781c3d64b8e360c34f7036d335fce67d Author: Aleisha Amohia Date: Mon Feb 6 21:26:54 2017 +0000 Bug 10357: Adding link for email notification for new subscription issues to opac-detail This patch adds the link to the opac-detail.pl page so it is less hard to find. Update: Fixing link to look like button, adding span ID around element Update: Changing ID to Class Update: Comment 14 fixes To test: 1) Add a subscription, attach it to a record and select a notice under 'Patron notification'. Hit Next, fill in some fields and save the subscription 2) Go to that record detail page in the OPAC. Go to the subscriptions tab, click 'More details'. Notice how many clicks it takes to see the 'Subscribe' button 3) Apply patch and go back to the details page for the record 4) Notice now there is a 'subscribe' button 5) Confirm this button works as expected and you are redirected to the detail page 6) Confirm 'Cancel' works and redirect works too 7) Go down to 'More details' and confirm the buttons work and you are redirected back to the serial-issues plage from here Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Followed test plan, works as expected. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-alert-subscribe.tt | 6 ++++-- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 11 ++++++++++ .../bootstrap/en/modules/opac-serial-issues.tt | 4 ++-- opac/opac-alert-subscribe.pl | 21 ++++++++++++++------ opac/opac-detail.pl | 10 +++++++++- opac/opac-serial-issues.pl | 3 ++- 6 files changed, 43 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 17:00:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 15:00:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-876-g1f45548 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1f45548c91366d04a115c02c0f8d4b40c93f78fc (commit) via 8b528ab09d08eb2c8162d89cb511857520f20c68 (commit) via 7e629641070e04dfb480886dc20582974363c0e8 (commit) from 039bb200de2507f81cafb88dfe826e74160d2fa2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1f45548c91366d04a115c02c0f8d4b40c93f78fc Author: Marcel de Rooy Date: Wed Apr 19 16:25:17 2017 +0200 Bug 16895: [QA Follow-up] Resolve warning on $payment_type_writeoff Resolves: Use of uninitialized value $payment_type_writeoff in string eq at C4/SIP/Sip/MsgType.pm line 1072, line 2. Would be raised if this parameter is not found in SIPconfig.xml. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 8b528ab09d08eb2c8162d89cb511857520f20c68 Author: Kyle M Hall Date: Wed Apr 19 09:29:13 2017 -0400 Bug 16895 [QA Followup] - Don't require fee payment to be exact full payment Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 7e629641070e04dfb480886dc20582974363c0e8 Author: Kyle M Hall Date: Mon Jul 11 13:55:50 2016 +0000 Bug 16895 - Allow writeoffs via SIP2 Many SIP2 services such as those by Comprise Technologies are able to or require that an ILS be able to accept writeoffs via SIP2. The SIP2 protocol specifies that payment type be a two digit number, but does not specify a code for writeoffs. To this end we should allow the write-off code to be specified in the SIP2 config on a per-account basis so that if different vendors use different fixed codes for write-offs we can handle that gracefully. Test Plan: 1) Apply this patch 2) Modify your SIP2 config to include payment_type_writeoff="06" in the login portion of the account you will be using for the test. 3) Restart your SIP2 server 4) Create a fee for a patron 5) Send a SIP2 fee paid message specifying the payment type code we defined earlier, with a payment amount that is *not* equal to the amount outstanding for the fee. 6) Note the fee paid response indicates the payment failed 7) Repeat step 5, but this time send the amount outstanding as the payment amount 8) Note that the fee paid response indicates a successful payment 9) Note in Koha that the fee has been written off! Signed-off-by: Rhonda Kuiper Signed-off-by: Marcel de Rooy ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 7 +++---- C4/SIP/ILS/Transaction/FeePayment.pm | 24 ++++++++++++++++++++---- C4/SIP/Sip/MsgType.pm | 5 ++++- etc/SIPconfig.xml | 2 +- 4 files changed, 28 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 17:02:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 15:02:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-877-g1d7afd3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1d7afd30bea01902efa87e68121ef3bfa933be9a (commit) from 1f45548c91366d04a115c02c0f8d4b40c93f78fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d7afd30bea01902efa87e68121ef3bfa933be9a Author: Kyle M Hall Date: Fri Apr 21 11:01:30 2017 -0400 Bug 16895 [QA Followup] - Use q{} for empty string as per PBP Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 17:16:42 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 15:16:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-882-g5f3e93c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5f3e93c6f5cd7818f53296cf9c4a37c860119970 (commit) via 9a8394866fbc76396fcc29086f2a34def47d9b45 (commit) via 30bdf6edec8176c68d2ced15cd14cdf0f1e767fd (commit) via b2b4be996aba9356662b05e4427d00e33dda9081 (commit) via 580b8febe32b273471a78917c836d0847ea8fa43 (commit) from 1d7afd30bea01902efa87e68121ef3bfa933be9a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f3e93c6f5cd7818f53296cf9c4a37c860119970 Author: Jonathan Druart Date: Thu Mar 23 22:13:17 2017 -0300 Bug 17964: Replace next with last We certainly always want to retrieve the last row of a given search. If it not sufficient we will need to rethink this code. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 9a8394866fbc76396fcc29086f2a34def47d9b45 Author: Marcel de Rooy Date: Fri Mar 24 09:05:44 2017 +0100 Bug 17964: [QA Follow-up] Test descriptions, typo Typo: have been checkin => checked. And five test descriptions ;) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 30bdf6edec8176c68d2ced15cd14cdf0f1e767fd Author: Jonathan Druart Date: Sat Jan 21 16:02:50 2017 +0100 Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b2b4be996aba9356662b05e4427d00e33dda9081 Author: Jonathan Druart Date: Sat Jan 21 15:48:57 2017 +0100 Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 580b8febe32b273471a78917c836d0847ea8fa43 Author: Jonathan Druart Date: Mon Jan 16 16:35:18 2017 +0100 Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 14 ++- t/db_dependent/Letters/TemplateToolkit.t | 173 +++++++++++++++++++++++------- 2 files changed, 145 insertions(+), 42 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:00:56 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:00:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-893-gccd42ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ccd42eee5b109cb7c935b0779a8321a5a8a872e0 (commit) via 8e99f884cc2eaecc810599fda9ef705f98efc10f (commit) via aee0682d60ddf1f21c5802001d8af91b43102e51 (commit) via 05e25dbc188d9d6340d03750a47cb1cce130715f (commit) via 8e7f1dddebb90d30be328d15ed8150517c2df664 (commit) via bab3a204be028cae30d26ad7b05dde4de1e58b76 (commit) via 8042267a7872bebecbb99c4638467c4d1225a06c (commit) via 4655cee3664da58a1812c8338130a35ba9d7da60 (commit) via 53f5d55ab4938cf827108bef98609ca165ef6cb7 (commit) via 686b7d6a827741da85224b6895d9b1c94cbbdf3c (commit) via fe9a8bf9735c7ea54d39aa1c19f667bf999a902d (commit) from 5f3e93c6f5cd7818f53296cf9c4a37c860119970 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ccd42eee5b109cb7c935b0779a8321a5a8a872e0 Author: Kyle M Hall Date: Fri Apr 21 13:59:52 2017 -0400 Bug 17669 - DBRev 16.12.00.025 Signed-off-by: Kyle M Hall commit 8e99f884cc2eaecc810599fda9ef705f98efc10f Author: Jonathan Druart Date: Thu Apr 20 01:10:14 2017 -0300 Bug 17669: Remove warning 'variable $kohaobj masks earlier declaration in same scope' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit aee0682d60ddf1f21c5802001d8af91b43102e51 Author: Marcel de Rooy Date: Mon Apr 3 19:14:52 2017 +0200 Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla comment36 (QA request). Koha::UploadedFile->delete Returns 1, 0E0 or -1 (unknown). Koha::UploadedFiles->delete and delete_temporary Returns number of deleted records, 0E0 or -1. POD lines are corrected accordingly. Unit tests adjusted too. Signed-off-by: Marcel de Rooy Added a note that Koha::Object->delete itself is not completely consistent with Koha::Objects->delete (DBIx). The singular may return 1 when it gets 0E0 from DBIx, while the plural one may return 0E0. But should be handled somewhere else. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 05e25dbc188d9d6340d03750a47cb1cce130715f Author: Marcel de Rooy Date: Fri Mar 31 08:31:10 2017 +0200 Bug 17669: [QA Follow-up] Allow zero in temp-uploads-days As requested by QA on comment33. If the pref is 0 or the overriding command line parameter is 0, all temporary files will be deleted. But if the pref is NULL or empty string, we will not delete files. Also adjusted the description of the preference in this regard. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8e7f1dddebb90d30be328d15ed8150517c2df664 Author: Marcel de Rooy Date: Thu Mar 30 08:51:17 2017 +0200 Bug 17669: [QA Follow-up] Rename --temp-uploads-override parameter As requested by QA on comment25. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bab3a204be028cae30d26ad7b05dde4de1e58b76 Author: Marcel de Rooy Date: Thu Mar 30 08:42:38 2017 +0200 Bug 17669: [QA Follow-up] Rename preference by removing underscores Requested by QA on comment25. Result of: git grep -l Upload_PurgeTemporaryFiles_Days | xargs sed -i -e "s/Upload_PurgeTemporaryFiles_Days/UploadPurgeTemporaryFilesDays/g" Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8042267a7872bebecbb99c4638467c4d1225a06c Author: Marcel de Rooy Date: Wed Dec 14 13:46:06 2016 +0100 Bug 17669: Add new switch to crontab example and debian daily cron file The new switch for deleting temporary uploads in cleanup_database can be added to cron. Note: Since the option --temp-uploads does only purge temporary uploads when triggered by the preference Upload_PurgeTemporaryFiles_Days, it can be safely added here. Test plan: There is actually nothing to test here if you followed the preceding test plans. Just verify that the switch is inserted ocrrectly. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4655cee3664da58a1812c8338130a35ba9d7da60 Author: Marcel de Rooy Date: Tue Dec 13 16:44:26 2016 +0100 Bug 17669: Incorporate the changes in cleanup_database Two command line options are added: [1] -temp-uploads to indicate that you want to purge these uploads, [2] -temp-uploads-override DAYS to (optionally) tell that you want to override the corresponding pref value. Test plan: [1] Check the modified usage statement. [2] If needed, backup your temporary uploads :) In case you do not have one, add a temporary one with Tools/Upload. Note: Do not choose an upload category. [3] Set pref to 0, and run cleanup_database with only --temp-uploads. No files should be deleted. [4] Check number of "old" temp uploads. Set pref to nonzero value. Verify that the oldest are gone (depending on the value chosen). [5] Set pref to 0 again. If all uploads are gone now, add a new one with Tools/Upload. Run cleanup_database with --temp-uploads --temp-uploads-override -1 All temporary files are gone. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 53f5d55ab4938cf827108bef98609ca165ef6cb7 Author: Marcel de Rooy Date: Tue Dec 13 14:04:29 2016 +0100 Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 686b7d6a827741da85224b6895d9b1c94cbbdf3c Author: Marcel de Rooy Date: Mon Mar 20 08:43:32 2017 +0100 Bug 17669: Small change to sub delete Instead of looping through _resultset here and wrapping the results, we should use a Koha::Objects instance. Since the method may be called as a class method, we create an instance if needed. Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit fe9a8bf9735c7ea54d39aa1c19f667bf999a902d Author: Marcel de Rooy Date: Tue Dec 13 14:03:27 2016 +0100 Bug 17669: Introduce new preference for purging temp uploads The new preference is: Upload_PurgeTemporaryFiles_Days. It controls if the cron job will delete temporary uploaded files and if so, how many days should have passed before doing so. Since the default value is empty, it will not start deleting these uploads until you change the pref. No behavior change. But the dbrev will print a message if you already have temporary uploads. Test plan: [1] Check Administration, Preferences, Tools for the new pref. [2] Run the db rev. If you have temporary uploads, check the reported count. [3] Bonus: Run sysprefs.sql in a safe environment. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/UploadedFile.pm | 13 +++- Koha/UploadedFiles.pm | 45 +++++++++++-- debian/koha-common.cron.daily | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 16 +++++ .../prog/en/modules/admin/preferences/tools.pref | 6 ++ misc/cronjobs/cleanup_database.pl | 21 +++++- misc/cronjobs/crontab.example | 2 +- t/db_dependent/Upload.t | 67 ++++++++++++++++++-- 10 files changed, 158 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:02:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:02:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-895-g0e0f3e4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0e0f3e49460611c74184ee48d3b66762c55ac181 (commit) via cb5d44e2f14dd0f74557999987c6942841d2503c (commit) from ccd42eee5b109cb7c935b0779a8321a5a8a872e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0e0f3e49460611c74184ee48d3b66762c55ac181 Author: Marcel de Rooy Date: Thu Apr 13 13:34:36 2017 +0200 Bug 18427: Add a primary key to serialitems We drop the unique index serialitemsidx and add a primary key consisting of itemnumber just as the unique key did. Test plan: Run the db revision. Apply bug 18182. The TestBuilder.t should no longer fail on serialitems. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit cb5d44e2f14dd0f74557999987c6942841d2503c Author: Marcel de Rooy Date: Thu Apr 13 13:53:37 2017 +0200 Bug 18427: DBIx schema changes Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Serialitem.pm | 10 ++++------ installer/data/mysql/atomicupdate/bug18427.perl | 17 +++++++++++++++++ installer/data/mysql/kohastructure.sql | 2 +- 3 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug18427.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:04:25 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:04:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-896-gd0a37bb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d0a37bb8bfdb8f426f83920314179b207be496fd (commit) from 0e0f3e49460611c74184ee48d3b66762c55ac181 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d0a37bb8bfdb8f426f83920314179b207be496fd Author: Kyle M Hall Date: Fri Apr 21 14:03:42 2017 -0400 Bug 18427 - DBRev 16.12.00.026 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug18427.perl | 17 ----------------- installer/data/mysql/updatedatabase.pl | 18 ++++++++++++++++++ 3 files changed, 19 insertions(+), 18 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug18427.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:11:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:11:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-897-g2ba4a66 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2ba4a661d38c856ff10c9bcf1680f6619bdab2cd (commit) from d0a37bb8bfdb8f426f83920314179b207be496fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ba4a661d38c856ff10c9bcf1680f6619bdab2cd Author: Marcel de Rooy Date: Sun Apr 16 18:50:58 2017 +0200 Bug 18448: Fix a few db_dependent tests Tests in db_dependent may expect a Koha database, but should not rely on hardcoded categories, currencies, branch codes, etc. This patch fixes a bunch of those. But this is a continuous project. We also need QA to closely watch new edits. Accounts.t: hardcoded category PT replaced Acquisition/OrderFromSubscription.t: hardcoded USD Acquisition/StandingOrders.t: same ArticleRequests.t: create itemtype, branch and category for testing AuthorisedValues.t: remove $dbh, add two test branches AuthoritiesMarc.t: add hardcoded GEOGR_NAME authtype Bookseller.t: add test currency Koha.t: add test itemtype instead of hardcoded BK UsageStats.t: add test branch and category Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy All tests successful (see comment #9) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Accounts.t | 4 ++-- t/db_dependent/Acquisition/OrderFromSubscription.t | 7 +++++- t/db_dependent/Acquisition/StandingOrders.t | 3 ++- t/db_dependent/ArticleRequests.t | 16 ++++++++----- t/db_dependent/AuthorisedValues.t | 22 ++++++++++-------- t/db_dependent/AuthoritiesMarc.t | 8 +++++++ t/db_dependent/Bookseller.t | 15 ++++++++---- t/db_dependent/Koha.t | 24 ++++++++++++-------- t/db_dependent/UsageStats.t | 12 ++++++---- 9 files changed, 72 insertions(+), 39 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:11:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:11:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-898-g6527b3b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6527b3b67506db0289997eb9bb98647fa1967a55 (commit) from 2ba4a661d38c856ff10c9bcf1680f6619bdab2cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6527b3b67506db0289997eb9bb98647fa1967a55 Author: Julian Maurice Date: Wed Apr 19 17:01:54 2017 +0200 Bug 18459: Add the Koha::Item->biblioitem method Test plan: prove t/db_dependent/Koha/Items.t Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Item.pm | 14 ++++++++++++++ t/db_dependent/Koha/Items.t | 12 ++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:12:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:12:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-902-g1183cff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1183cfff75773c4ac2acf8fb3386f2fd7f97d4ff (commit) via f762ee4a1bcdd50ab3d4ec908cda7dede4ca6622 (commit) via 5841aeb8f20098fd54db6dfee12cc13b8a994851 (commit) via e2d14666d9762a6742a326b67f4296f6269c4d4c (commit) from 6527b3b67506db0289997eb9bb98647fa1967a55 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1183cfff75773c4ac2acf8fb3386f2fd7f97d4ff Author: Jonathan Druart Date: Wed Apr 12 15:20:10 2017 -0300 Bug 18182: Fix Koha::RefundLostItemFeeRules Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f762ee4a1bcdd50ab3d4ec908cda7dede4ca6622 Author: Jonathan Druart Date: Wed Apr 12 15:19:33 2017 -0300 Bug 18182: Tests all Koha::Objects-based modules Signed-off-by: Marcel de Rooy Added test description on line 387. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5841aeb8f20098fd54db6dfee12cc13b8a994851 Author: Marcel de Rooy Date: Fri Mar 31 13:32:55 2017 +0200 Bug 18182: [QA Follow-up] Fix a few typos, consistent rollback Since we here only use one rollback and this test does not care, it is more consistent to keep that pattern. Additionally, promoting two globals to our. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit e2d14666d9762a6742a326b67f4296f6269c4d4c Author: Tomas Cohen Arazi Date: Tue Feb 28 09:08:38 2017 -0300 Bug 18182: Make TestBuilder capable of returning Koha::Object This patch adds a new method to t::lib::TestBuilder so it can return Koha::Object-derived objects. The new method is called ->build_object and requires the plural of the target class to be passed. 'class' is a mandatory param, and a warning is raised and undef is returned if absent. It accepts 'value' as the original ->build() method, and that is passed as-is to ->build(). To test: - Apply the patches - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/RefundLostItemFeeRules.pm | 2 ++ t/db_dependent/TestBuilder.t | 58 +++++++++++++++++++++++++++++++++++----- t/lib/TestBuilder.pm | 38 ++++++++++++++++++++++++++ 3 files changed, 92 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 21 20:13:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 18:13:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-904-g4eb53ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe (commit) via 8c80c9b8e127145e638963eb0eaa8fdb420ff4cd (commit) from 1183cfff75773c4ac2acf8fb3386f2fd7f97d4ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe Author: Marcel de Rooy Date: Mon Apr 3 21:43:48 2017 +0200 Bug 18300: [QA Follow-up] Fix return value inconsistency As noted on bug report 17669, the return values of delete (both singular and plural), delete_missing and delete_temporary should be consistent. Removed the if-construction around full_path. We do not need it; in the very exceptional case that full_path would be empty, we should delete the record since the file is missing. Adjusted POD and unit tests accordingly. Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8c80c9b8e127145e638963eb0eaa8fdb420ff4cd Author: Marcel de Rooy Date: Sun Mar 19 17:25:01 2017 +0100 Bug 18300: Delete missing upload records If you deleted files from the upload directories manually, or you rebooted with files in the temporary upload folder, or for some other reason have records without a file, you may want to cleanup your records in the uploaded_files table. This patch adds the method delete_missing to Koha::UploadedFiles. It also supports a keep_record parameter to do a dry run (count the missing files first). Also, we add an option --uploads-missing to cleanup_database. If you add the flag 1 after this option, you will delete missing files. If you add the flag 0 or only use the option, you will count missing files. A subtest is added to Upload.t for delete_missing tests. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file and delete the file manually. [3] Run cleanup_database.pl --uploads-missing It should report at least one missing file now. Check that the record has not been deleted. [4] Run cleanup_database.pl --uploads-missing 1 It should report that it removed at least one file. Check that the record is gone. Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/UploadedFiles.pm | 36 ++++++++++++++++++++++++++++++++++++ misc/cronjobs/cleanup_database.pl | 17 ++++++++++++++++- t/db_dependent/Upload.t | 24 ++++++++++++++++++++++-- 3 files changed, 74 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 22 01:23:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Apr 2017 23:23:08 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-64-gf41f4bb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via f41f4bb90c8e6af6b86a6c56e6311e6cf69cbfad (commit) via 73a57f5073c757da9f82cacd078526c784e50636 (commit) via 01edde4d2f8dc524ac504185fdac0c5ad65d8f16 (commit) via af8a39d73f0f716a486b6c5aa6972977a67d10cf (commit) via 35c68e61b6e690e489f806c35af42be84232184f (commit) via 7d286ab1021f8d403a99bbe92c8e46898bdbb2a0 (commit) via 1485d09cbfbff8038216bce9029de517c25ad6d9 (commit) via fe530a88cef5f83e295cb4897267d363f7137779 (commit) via abc7ab14a2e878dcdd15d5431f367a886a4531e8 (commit) via 7700f30f19ccff98448b8ea4a45a41f43fbd2180 (commit) via 6ff2ff088f8d6bf16ceb1bff966a322ae782ba67 (commit) via c3891904b3ad453b3ddb8ad12e40e486c0116075 (commit) via 46b688991b86a66b3bfd66c894f5ced14519c36a (commit) via fd4b3555d83c44e8026f3899faa879ba25c7a598 (commit) via c8fbbecf789773bc6e4972361788499ab77470d8 (commit) via af89b3be02b0184c5e0b6799ae880a074fff3813 (commit) via fd742f664e3453def5005637110e9e3c2563b96c (commit) via a852349be17183b56eea9bc8f3067b75fa778781 (commit) via 77aaf0dabfc19fcc6569f1b730154823ada94b5f (commit) via 302b66badafe5112f738ffd35f809b4b62e8fba5 (commit) from 5a5af02be9eda69c77146184fe8392ca9c4067f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f41f4bb90c8e6af6b86a6c56e6311e6cf69cbfad Author: Marc V?ron Date: Tue Apr 18 09:21:45 2017 +0200 Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7cbd9561271c1ac9ca3ccfd8ef257259a341f464) Signed-off-by: Katrin Fischer commit 73a57f5073c757da9f82cacd078526c784e50636 Author: Nick Clemens Date: Thu Apr 13 09:55:15 2017 -0400 Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc V?ron Works as expected. Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 4cb7119e933009374fad8f192e1f30f819a74f88) Signed-off-by: Katrin Fischer commit 01edde4d2f8dc524ac504185fdac0c5ad65d8f16 Author: Marc V?ron Date: Sun Mar 26 17:26:22 2017 +0200 Bug 18335 - Check in: Make patron info in hold messages obey syspref AddressFormat When checking in, information about patrons with a hold always display in an US style. Address information should opey the system preference AddressFormat To reproduce: - Set syspref AddressFormat to German style - Check out an item to a patron A - Put a hold on this item for patron B - Check in item using the Check in field in page header - Result: In message 'Hold found', address does not display in German style To test: - Apply patch - Repeat steps above - Verify that address displays as expected Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 8b0bed34c20b21865d76992b7822bc3874867cbc) Signed-off-by: Katrin Fischer commit af8a39d73f0f716a486b6c5aa6972977a67d10cf Author: Tomas Cohen Arazi Date: Wed Apr 19 12:15:46 2017 -0300 Bug 18460: Fix undefined itemtype warning in Serials.t This patch makes the test create an itemtype, and use it for the created item so there's no warning. To test: - Run: $ prove t/db_dependent/Serials.t => FAIL: item-level_itypes set but no itemtype set... warning raised - Apply the patch - Run: $ prove t/db_dependent/Serials.t => SUCCESS: Tests pass and no warning is raised - Sign off :-D Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit eab4d43a479c20c3708eb0765c9e92ee6f58e7d9) Signed-off-by: Katrin Fischer commit 35c68e61b6e690e489f806c35af42be84232184f Author: Benjamin Rokseth Date: Tue Apr 1 14:07:59 2014 +0200 Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch This small patch corrects the SIP2 checkin response if branch transfer is needed. It depends on bug 7981 and also removes an obsolete alert check in SIP2. Test plan: - apply bug 7981 - make sure syspref AutomaticItemReturn is false - check 'Return policy' in 'Default checkout, hold and return policy' - make a SIP2 checkout and checkin from a branch different than item's home branch. - verify that SIP2 response gives alert CV04 (=send to different branch) - also verify that response field CT gives correct branch according to 'Return policy' Signed-off-by: Kyle M Hall Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 37836951d38ed57c7ed5ed702aab1433729ffe0d) Signed-off-by: Katrin Fischer commit 7d286ab1021f8d403a99bbe92c8e46898bdbb2a0 Author: Nick Clemens Date: Tue Apr 18 14:03:37 2017 -0400 Bug 18423 - Followup - enable Add child button for institutional borrowers If they can have guarantors and we shwo the button on one page I think we should in fact show it on all. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 185dc7f45af17bf70ec36125be736286a1f8b86e) Signed-off-by: Katrin Fischer commit 1485d09cbfbff8038216bce9029de517c25ad6d9 Author: Nick Clemens Date: Tue Apr 18 13:53:54 2017 -0400 Bug 18423 - Add 'Add child' button to files, housebound, and deletemem pages Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b81a18ea39e1f360dc0dc4b7a874b614dc67d725) Signed-off-by: Katrin Fischer commit fe530a88cef5f83e295cb4897267d363f7137779 Author: Nick Clemens Date: Mon Apr 17 12:32:56 2017 -0400 Bug 18423 Follow-up - Add 'Add child' button to statistics tab Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b689c6f9fe31dea49657b65af4f6830af1b17433) Signed-off-by: Katrin Fischer commit abc7ab14a2e878dcdd15d5431f367a886a4531e8 Author: Nick Clemens Date: Wed Apr 12 11:32:11 2017 -0400 Bug 18423 follow up - fix display off add child on members/notices.pl Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit d18f30eb3f794a144989970893ef87d673cef8ec) Signed-off-by: Katrin Fischer commit 7700f30f19ccff98448b8ea4a45a41f43fbd2180 Author: Nick Clemens Date: Wed Apr 12 10:23:56 2017 -0400 Bug 18423 - Add child button not always appearing - problem in template variable This patch removes the retrieval of the syspref borrowerRelationship from the scripts and moves it to a check using the Template Toolkit plugin To test: 1 - Apply patch 2 - Ensure 'Add child' button displays appropriately on all member pages. Tested 3 pateches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e28f19f0a88e334c99a45fadf96ae504bbb17ebe) Signed-off-by: Katrin Fischer commit 6ff2ff088f8d6bf16ceb1bff966a322ae782ba67 Author: Mark Tompsett Date: Sun Jan 15 23:26:33 2017 -0500 Bug 17911: Message and timeout mismatch The installation step 3 has a meta refresh of 10 seconds, but the message says 5 seconds. People could get impatient. TEST PLAN --------- 1) Fresh install -- notice the discrepancy on the web installation. 2) drop and create the DB 3) apply the patch 4) run the web install -- notice it refreshes faster (5 seconds vs 10 seconds) 5) run koha qa test tools Works as intended and passes qa test tool OK koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 46d0be3114785c17e48df8bc31b515599d394789) Signed-off-by: Katrin Fischer commit c3891904b3ad453b3ddb8ad12e40e486c0116075 Author: pongtawat Date: Mon Dec 26 17:50:50 2016 +0700 Bug 17814: koha-plack --stop should make sure that Plack really stop koha-plack --stop doesn't ensure that Plack was really stopped before returning So in case that koha-plack --stop was quickly follows by koha-plack --start (e.g. logrotate), it could leave Plack in stop state. This is due to koha-plack --start think that Plack was already started, while it actually is being stopped. For me I think this is the cause why I got random Plack stop when logrotate is run. It should be similar to the case of Zebra in Bug #16885, and the solution might be the same: adding "--retry=TERM/30/KILL/5;" to start-stop-daemon command. TEST PLAN --------- 1) Login to staff client and do something that will hold connection for a long time, e.g. a batch import or a slow report. 2) sudo koha-plack --stop mykoha 3) ps aux | grep plack <-- a Plack process will still running work in 1) 4) wait for 1) to finish and all Plack processes exit 5) sudo koha-plack --start mykoha 6) apply the patch 7) repeat step 1)-2) 8) ps aux | grep plack <-- There should be no Plack process running now 9) Note that work in step 1) might get terminated midway. Since we force Plack to stop after some wait. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e) Signed-off-by: Katrin Fischer commit 46b688991b86a66b3bfd66c894f5ced14519c36a Author: Marcel de Rooy Date: Thu Apr 20 12:52:47 2017 +0200 Bug 18364: [Follow-up] Also add an environment variable to prevent locking The test in SendCirculationAlert is extended by adding an env var called KOHA_NO_TABLE_LOCKS. If this var is set to a true value, the table locking is skipped too. This is useful when running a test without prove. The variable could be set in a shell profile. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit d51538cb824387230b3e2cab955d3c16475bedde) Signed-off-by: Katrin Fischer commit fd4b3555d83c44e8026f3899faa879ba25c7a598 Author: Jonathan Druart Date: Fri Mar 31 13:43:38 2017 -0300 Bug 18364: Do not LOCK/UNLOCK tables from tests From the MySQL doc: "LOCK TABLES is not transaction-safe and implicitly commits any active transaction before attempting to lock the tables." If the LOCK/UNLOCK statements are executed from tests, the current transaction will be committed. To avoid that we need to guess if this code is execute from testsa or not (yes it is a bit hacky) Better ideas are welcome! Another fix would have been to revert commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad Bug 15854: Use a READ and WRITE LOCK on message_queue but theorically a race is still possible. Existing tests seem to be safe, to test this patch you will need new tests from bug 17964. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t twice, and notice that changes have been comitted. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit b40456f7dd4b8a988f9c6a5718452936101cb8ff) Signed-off-by: Katrin Fischer commit c8fbbecf789773bc6e4972361788499ab77470d8 Author: Nick Clemens Date: Mon Apr 17 13:22:24 2017 -0400 Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Current jQuery is not unhiding resend button, this patch adds an id and a toggle command To test: 1 - Enable EnhancedMessagingPreferences 2 - Find a patron with sent or failed messages 3 - Note you can expand message, but not resend 4 - Apply patch 5 - Note that on expanding message a 'Resend' button appears 6 - Ensure resend button operates as expected Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Lari Taskula Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit ea04798a16ad8c8400030440e21825fc20b03808) Signed-off-by: Katrin Fischer commit af89b3be02b0184c5e0b6799ae880a074fff3813 Author: Kyle M Hall Date: Thu Jan 26 14:31:35 2017 +0000 Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall Signed-off-by: Joel Sasse Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 2a8f748f25e305deca7fce41451fbd78056ba26d) Signed-off-by: Katrin Fischer commit fd742f664e3453def5005637110e9e3c2563b96c Author: Kyle M Hall Date: Tue Apr 18 07:38:42 2017 -0400 Bug 18001 - Unit Test Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit aa68e40005928150ac4aa1db8ce00716d7b7fe3f) Signed-off-by: Katrin Fischer commit a852349be17183b56eea9bc8f3067b75fa778781 Author: Owen Leonard Date: Tue Apr 11 16:45:40 2017 +0000 Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron Signed-off-by: Colin Campbell Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 07156cf8fd0f11eb43a11ffa7f75d4c95f3766df) Signed-off-by: Katrin Fischer commit 77aaf0dabfc19fcc6569f1b730154823ada94b5f Author: Jonathan Druart Date: Fri Mar 31 00:24:09 2017 -0300 Bug 18321: Correctly calculate switch_onsite_checkout Silly error here, the $switch_onsite_checkout is not correctly calculated, it should not only be set to the value of the syspref, but meet all the conditions. Test plan: Set a circ rule with number of on-site checkout = 2 and number of checkouts = 2. Switch on both ConsiderOnSiteCheckoutsAsNormalCheckouts and SwitchOnSiteCheckouts Do a regular checkout Do another regular checkout At this point you have reach the maximum number of checkouts allowed. Not try another one. => Without this patch you will not get the warning => With this patch you will see it Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit f04c5d5a2c549bed54036b726965ccda083def7b) Signed-off-by: Katrin Fischer commit 302b66badafe5112f738ffd35f809b4b62e8fba5 Author: Jonathan Druart Date: Fri Mar 31 00:23:19 2017 -0300 Bug 18321: Add tests Clean a bit existing tests by adding default values and add a test to highlight the issue. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 1c7d283aae0952877b871f486c31cd3f04529222) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 +- C4/Circulation.pm | 19 ++++--- C4/HoldsQueue.pm | 7 ++- C4/SIP/ILS/Transaction/Checkin.pm | 8 +-- C4/SIP/Sip/MsgType.pm | 8 --- acqui/finishreceive.pl | 1 + circ/circulation.pl | 1 - circ/returns.pl | 28 ++++++----- debian/scripts/koha-plack | 2 +- .../prog/en/includes/members-toolbar.inc | 4 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 52 ++++++++------------ .../prog/en/modules/installer/step3.tt | 2 +- .../prog/en/modules/members/notices.tt | 3 +- members/boraccount.pl | 3 +- members/deletemem.pl | 3 +- members/files.pl | 1 + members/housebound.pl | 1 + members/mancredit.pl | 3 +- members/maninvoice.pl | 3 +- members/member-flags.pl | 3 +- members/member-password.pl | 3 +- members/moremember.pl | 1 - members/notices.pl | 3 +- members/pay.pl | 3 +- members/paycollect.pl | 3 +- members/printfeercpt.pl | 2 +- members/printinvoice.pl | 2 +- members/readingrec.pl | 4 +- members/routing-lists.pl | 2 +- members/statistics.pl | 2 + t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 25 +++++++++- t/db_dependent/HoldsQueue.t | 36 +++++++++++++- t/db_dependent/Serials.t | 27 ++++++++-- 33 files changed, 169 insertions(+), 98 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 22 07:48:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Apr 2017 05:48:16 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via cb487cbcaf3489bd8ff28e656af52ca8316fa63d (commit) via 03804c71ffabcadb4ea41f25c163e6532bc1ce05 (commit) via 4599dcfd64d28a4e88a1f99d1892a0662b905b82 (commit) from f41f4bb90c8e6af6b86a6c56e6311e6cf69cbfad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb487cbcaf3489bd8ff28e656af52ca8316fa63d Author: Katrin Fischer Date: Sat Apr 22 07:38:01 2017 +0200 Add release notes to 16.11.07 release commit 03804c71ffabcadb4ea41f25c163e6532bc1ce05 Author: Katrin Fischer Date: Sat Apr 22 07:26:12 2017 +0200 Increment version for 16.11.07 release commit 4599dcfd64d28a4e88a1f99d1892a0662b905b82 Author: root Date: Sat Apr 22 02:14:08 2017 -0300 Translation updates for Koha 16.11.07 ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...s_16_11_02.html => release_notes_16_11_07.html} | 282 +++--- misc/release_notes/release_notes_16_11_07.md | 351 +++++++ misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 183 +--- misc/translator/po/am-Ethi-staff-help.po | 51 +- misc/translator/po/am-Ethi-staff-prog.po | 432 +++++---- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 194 +--- misc/translator/po/ar-Arab-staff-help.po | 113 ++- misc/translator/po/ar-Arab-staff-prog.po | 458 ++++----- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 183 +--- misc/translator/po/as-IN-staff-help.po | 51 +- misc/translator/po/as-IN-staff-prog.po | 428 +++++---- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 183 +--- misc/translator/po/az-AZ-staff-help.po | 53 +- misc/translator/po/az-AZ-staff-prog.po | 432 +++++---- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 186 +--- misc/translator/po/be-BY-staff-help.po | 67 +- misc/translator/po/be-BY-staff-prog.po | 446 +++++---- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 183 +--- misc/translator/po/bg-Cyrl-staff-help.po | 51 +- misc/translator/po/bg-Cyrl-staff-prog.po | 432 +++++---- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 183 +--- misc/translator/po/bn-IN-staff-help.po | 51 +- misc/translator/po/bn-IN-staff-prog.po | 432 +++++---- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 183 +--- misc/translator/po/ca-ES-staff-help.po | 51 +- misc/translator/po/ca-ES-staff-prog.po | 432 +++++---- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 200 +--- misc/translator/po/cs-CZ-pref.po | 34 +- misc/translator/po/cs-CZ-staff-help.po | 85 +- misc/translator/po/cs-CZ-staff-prog.po | 485 +++++----- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 183 +--- misc/translator/po/cy-GB-staff-help.po | 51 +- misc/translator/po/cy-GB-staff-prog.po | 428 +++++---- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 183 +--- misc/translator/po/da-DK-staff-help.po | 81 +- misc/translator/po/da-DK-staff-prog.po | 446 +++++---- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 205 +--- misc/translator/po/de-CH-pref.po | 8 +- misc/translator/po/de-CH-staff-help.po | 65 +- misc/translator/po/de-CH-staff-prog.po | 432 +++++---- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 209 +--- misc/translator/po/de-DE-pref.po | 46 +- misc/translator/po/de-DE-staff-help.po | 67 +- misc/translator/po/de-DE-staff-prog.po | 446 +++++---- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 186 +--- misc/translator/po/el-GR-staff-help.po | 85 +- misc/translator/po/el-GR-staff-prog.po | 446 +++++---- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 183 +--- misc/translator/po/en-GB-staff-help.po | 85 +- misc/translator/po/en-GB-staff-prog.po | 446 +++++---- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 183 +--- misc/translator/po/en-NZ-staff-help.po | 85 +- misc/translator/po/en-NZ-staff-prog.po | 446 +++++---- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 312 ++---- misc/translator/po/eo-staff-help.po | 51 +- misc/translator/po/eo-staff-prog.po | 432 +++++---- misc/translator/po/es-ES-marc-MARC21.po | 10 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 203 +--- misc/translator/po/es-ES-staff-help.po | 124 +-- misc/translator/po/es-ES-staff-prog.po | 465 ++++----- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 186 +--- misc/translator/po/eu-staff-help.po | 51 +- misc/translator/po/eu-staff-prog.po | 432 +++++---- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 185 +--- misc/translator/po/fa-Arab-staff-help.po | 81 +- misc/translator/po/fa-Arab-staff-prog.po | 446 +++++---- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 186 +--- misc/translator/po/fi-FI-staff-help.po | 85 +- misc/translator/po/fi-FI-staff-prog.po | 454 ++++----- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 184 +--- misc/translator/po/fo-FO-staff-help.po | 51 +- misc/translator/po/fo-FO-staff-prog.po | 428 +++++---- misc/translator/po/fr-CA-marc-MARC21.po | 24 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 214 ++--- misc/translator/po/fr-CA-pref.po | 739 ++++++--------- misc/translator/po/fr-CA-staff-help.po | 426 +++++---- misc/translator/po/fr-CA-staff-prog.po | 609 ++++++------ misc/translator/po/fr-FR-marc-MARC21.po | 16 +- misc/translator/po/fr-FR-marc-NORMARC.po | 12 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 16 +- misc/translator/po/fr-FR-opac-bootstrap.po | 196 +--- misc/translator/po/fr-FR-pref.po | 65 +- misc/translator/po/fr-FR-staff-help.po | 97 +- misc/translator/po/fr-FR-staff-prog.po | 554 +++++------ misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 183 +--- misc/translator/po/gl-staff-help.po | 51 +- misc/translator/po/gl-staff-prog.po | 432 +++++---- misc/translator/po/he-Hebr-marc-MARC21.po | 4 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 183 +--- misc/translator/po/he-Hebr-staff-help.po | 51 +- misc/translator/po/he-Hebr-staff-prog.po | 432 +++++---- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 183 +--- misc/translator/po/hi-staff-help.po | 85 +- misc/translator/po/hi-staff-prog.po | 446 +++++---- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 184 +--- misc/translator/po/hr-HR-staff-help.po | 75 +- misc/translator/po/hr-HR-staff-prog.po | 452 ++++----- misc/translator/po/hu-HU-marc-MARC21.po | 127 ++- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 762 +++++++-------- misc/translator/po/hu-HU-staff-help.po | 63 +- misc/translator/po/hu-HU-staff-prog.po | 432 +++++---- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 183 +--- misc/translator/po/hy-Armn-staff-help.po | 85 +- misc/translator/po/hy-Armn-staff-prog.po | 446 +++++---- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 183 +--- misc/translator/po/ia-staff-help.po | 51 +- misc/translator/po/ia-staff-prog.po | 428 +++++---- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 185 +--- misc/translator/po/id-ID-staff-help.po | 51 +- misc/translator/po/id-ID-staff-prog.po | 432 +++++---- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 183 +--- misc/translator/po/iq-CA-staff-help.po | 51 +- misc/translator/po/iq-CA-staff-prog.po | 428 +++++---- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 187 +--- misc/translator/po/is-IS-staff-help.po | 51 +- misc/translator/po/is-IS-staff-prog.po | 432 +++++---- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 206 +--- misc/translator/po/it-IT-pref.po | 20 +- misc/translator/po/it-IT-staff-help.po | 71 +- misc/translator/po/it-IT-staff-prog.po | 442 +++++---- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 183 +--- misc/translator/po/iu-CA-staff-help.po | 51 +- misc/translator/po/iu-CA-staff-prog.po | 428 +++++---- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 183 +--- misc/translator/po/ja-Jpan-JP-staff-help.po | 51 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 432 +++++---- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 183 +--- misc/translator/po/ka-staff-help.po | 51 +- misc/translator/po/ka-staff-prog.po | 432 +++++---- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 183 +--- misc/translator/po/km-KH-staff-help.po | 51 +- misc/translator/po/km-KH-staff-prog.po | 432 +++++---- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 183 +--- misc/translator/po/kn-Knda-staff-help.po | 51 +- misc/translator/po/kn-Knda-staff-prog.po | 432 +++++---- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 185 +--- misc/translator/po/ko-Kore-KP-staff-help.po | 87 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 446 +++++---- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 183 +--- misc/translator/po/ku-Arab-staff-help.po | 79 +- misc/translator/po/ku-Arab-staff-prog.po | 438 +++++---- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 183 +--- misc/translator/po/lo-Laoo-staff-help.po | 51 +- misc/translator/po/lo-Laoo-staff-prog.po | 432 +++++---- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 183 +--- misc/translator/po/mi-NZ-staff-help.po | 51 +- misc/translator/po/mi-NZ-staff-prog.po | 432 +++++---- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 183 +--- misc/translator/po/ml-staff-help.po | 51 +- misc/translator/po/ml-staff-prog.po | 428 +++++---- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 183 +--- misc/translator/po/mon-staff-help.po | 79 +- misc/translator/po/mon-staff-prog.po | 444 +++++---- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 183 +--- misc/translator/po/mr-staff-help.po | 51 +- misc/translator/po/mr-staff-prog.po | 432 +++++---- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 187 +--- misc/translator/po/ms-MY-staff-help.po | 51 +- misc/translator/po/ms-MY-staff-prog.po | 438 +++++---- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 183 +--- misc/translator/po/my-staff-help.po | 51 +- misc/translator/po/my-staff-prog.po | 428 +++++---- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 183 +--- misc/translator/po/nb-NO-staff-help.po | 69 +- misc/translator/po/nb-NO-staff-prog.po | 446 +++++---- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 183 +--- misc/translator/po/ne-NE-staff-help.po | 51 +- misc/translator/po/ne-NE-staff-prog.po | 432 +++++---- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 183 +--- misc/translator/po/nl-BE-staff-help.po | 51 +- misc/translator/po/nl-BE-staff-prog.po | 432 +++++---- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 183 +--- misc/translator/po/nl-NL-staff-help.po | 51 +- misc/translator/po/nl-NL-staff-prog.po | 432 +++++---- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 183 +--- misc/translator/po/nn-NO-staff-help.po | 53 +- misc/translator/po/nn-NO-staff-prog.po | 432 +++++---- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 183 +--- misc/translator/po/oc-staff-help.po | 81 +- misc/translator/po/oc-staff-prog.po | 446 +++++---- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 183 +--- misc/translator/po/pbr-staff-help.po | 51 +- misc/translator/po/pbr-staff-prog.po | 432 +++++---- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 197 +--- misc/translator/po/pl-PL-staff-help.po | 55 +- misc/translator/po/pl-PL-staff-prog.po | 441 +++++---- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 183 +--- misc/translator/po/prs-staff-help.po | 51 +- misc/translator/po/prs-staff-prog.po | 432 +++++---- misc/translator/po/pt-BR-marc-MARC21.po | 14 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 44 +- misc/translator/po/pt-BR-opac-bootstrap.po | 271 ++---- misc/translator/po/pt-BR-pref.po | 40 +- misc/translator/po/pt-BR-staff-help.po | 85 +- misc/translator/po/pt-BR-staff-prog.po | 446 +++++---- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 183 +--- misc/translator/po/pt-PT-pref.po | 41 +- misc/translator/po/pt-PT-staff-help.po | 85 +- misc/translator/po/pt-PT-staff-prog.po | 462 ++++----- misc/translator/po/ro-RO-marc-MARC21.po | 4 +- misc/translator/po/ro-RO-marc-NORMARC.po | 10 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 201 +--- misc/translator/po/ro-RO-pref.po | 51 +- misc/translator/po/ro-RO-staff-help.po | 51 +- misc/translator/po/ro-RO-staff-prog.po | 478 +++++----- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 196 +--- misc/translator/po/ru-RU-staff-help.po | 67 +- misc/translator/po/ru-RU-staff-prog.po | 446 +++++---- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 183 +--- misc/translator/po/rw-RW-staff-help.po | 51 +- misc/translator/po/rw-RW-staff-prog.po | 428 +++++---- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 183 +--- misc/translator/po/sd-PK-staff-help.po | 51 +- misc/translator/po/sd-PK-staff-prog.po | 432 +++++---- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 183 +--- misc/translator/po/sk-SK-staff-help.po | 85 +- misc/translator/po/sk-SK-staff-prog.po | 446 +++++---- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 183 +--- misc/translator/po/sl-SI-staff-help.po | 51 +- misc/translator/po/sl-SI-staff-prog.po | 428 +++++---- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 185 +--- misc/translator/po/sq-AL-staff-help.po | 51 +- misc/translator/po/sq-AL-staff-prog.po | 432 +++++---- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 183 +--- misc/translator/po/sr-Cyrl-staff-help.po | 51 +- misc/translator/po/sr-Cyrl-staff-prog.po | 432 +++++---- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 183 +--- misc/translator/po/sv-SE-staff-help.po | 85 +- misc/translator/po/sv-SE-staff-prog.po | 446 +++++---- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 183 +--- misc/translator/po/sw-KE-staff-help.po | 51 +- misc/translator/po/sw-KE-staff-prog.po | 428 +++++---- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 183 +--- misc/translator/po/ta-LK-staff-help.po | 51 +- misc/translator/po/ta-LK-staff-prog.po | 432 +++++---- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 183 +--- misc/translator/po/ta-staff-help.po | 51 +- misc/translator/po/ta-staff-prog.po | 432 +++++---- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 12 +- misc/translator/po/tet-marc-UNIMARC.po | 74 +- misc/translator/po/tet-opac-bootstrap.po | 183 +--- misc/translator/po/tet-staff-help.po | 634 +++++++------ misc/translator/po/tet-staff-prog.po | 1002 ++++++++++---------- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 183 +--- misc/translator/po/th-TH-staff-help.po | 51 +- misc/translator/po/th-TH-staff-prog.po | 432 +++++---- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 183 +--- misc/translator/po/tl-PH-staff-help.po | 51 +- misc/translator/po/tl-PH-staff-prog.po | 434 +++++---- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 229 ++--- misc/translator/po/tr-TR-staff-help.po | 446 ++++----- misc/translator/po/tr-TR-staff-prog.po | 581 ++++++------ misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 189 +--- misc/translator/po/uk-UA-pref.po | 14 +- misc/translator/po/uk-UA-staff-help.po | 67 +- misc/translator/po/uk-UA-staff-prog.po | 446 +++++---- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 183 +--- misc/translator/po/ur-Arab-staff-help.po | 51 +- misc/translator/po/ur-Arab-staff-prog.po | 432 +++++---- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 183 +--- misc/translator/po/vi-VN-staff-help.po | 85 +- misc/translator/po/vi-VN-staff-prog.po | 446 +++++---- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 183 +--- misc/translator/po/zh-Hans-CN-staff-help.po | 85 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 446 +++++---- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 190 +--- misc/translator/po/zh-Hans-TW-staff-help.po | 81 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 440 +++++---- 500 files changed, 27272 insertions(+), 34164 deletions(-) copy misc/release_notes/{release_notes_16_11_02.html => release_notes_16_11_07.html} (60%) create mode 100644 misc/release_notes/release_notes_16_11_07.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 22 07:48:47 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 22 Apr 2017 05:48:47 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.11.07 created. v16.11.07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.11.07 has been created at 7b931d8a020fb61e9726deef965307630822b741 (tag) tagging cb487cbcaf3489bd8ff28e656af52ca8316fa63d (commit) replaces v16.11.06 tagged by Katrin Fischer on Sat Apr 22 07:44:52 2017 +0200 - Log ----------------------------------------------------------------- Koha release 16.11.07 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJY+u3UAAoJEB+uyDM6ADoAETQQALhyZfq+3aZTHEmFYCXgjjW0 Es5EYubtD8Q+LrrOs4YL3KrFUjDzZqLGHpFk7YR0pj2hB1tf4woLPG+n5A9ZhC9I nkXJ6WengBvZvUDrN0Z+rr4TXrZxqh4+mTKUtWu8aDA7APWqN3CYLOkqFTqa6nOY 3pfvXm7cUXhKN/MLcCdUvoBcmGsllaYPSGuMpiBVVtS6hxveND11ajG3l7eE8MzE Tsoduc52tOq8ApMq6K3Q2qkdKckvATm8QsVNapQYJ+ggqB3cGmHe8aokqMIQuUXu RvWWgwSdh9F+0moe9TgaHcvxFSBHllkopB9C51Anw6B/dGrGxRc6g2T8oal2IIhw 9dp0AfSL2HtoTG6hhjmLUgkH8zJ4PdWygWD6oncGizthlZ0nwA8vcEGno0UhdVBs omxMfX+Z+dX2yjuo95ilHg1TO+tovQ+wO00Lff6ib0CC6EZod4V8ihRJyLGkyFw5 PC+Ahoo4h6Ff1XYHuxnDaKs1bRi7vKPaew83xPrHbriYuIZ27jH0KpVW5rJWZosH hliHVtuydhhCay8rYKVJcM+o315bsTsLfG9z9MMW8Ia0uBn6VA0/hu2NxUm5WnGK T7BAyFyhfq7FBVIZTW86eEYQX5p4JNXG5CXFHwRsmEF2ByjWJs1V3+3rVACfV/KR 6boClNU7u/iXmFaxK2Rx =V70r -----END PGP SIGNATURE----- Alex Buckley (1): Bug 12930: Web installer does not show login errors Benjamin Rokseth (2): Bug 17758 - SIP checkin does not handle holds correctly Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch Blou (1): Bug 18209 - Patron's card manage.pl page is not fully translatable Christopher Brannon (1): Bug 17346: Make checkin column hidable David Kuhn (1): Bug 17309 - Renewing and HomeOrHoldingBranch syspref Fridolin Somers (3): Bug 12913 - wrong inventory results when notforloan filter is not used Bug 18329 - Batch record deletion broken Bug 17821 - due date in intranet search results should use TT date plugin Grace McKenzie (1): Bug 17290 - Standardize on "Patron Categories" Jonathan Druart (19): Bug 18312: Fix export unless a file is supplied Bug 18124: Restrict CSRF token to user's session Bug 18124: Change the calls to generate and check CSRF tokens Bug 18058: Allow borrower_message_preferences to be truncated Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen Bug 18209: Add default, 'Actions' and fix case Bug 18242: [SOLUTION 2]Add tests Bug 18242: [SOLUTION 2]Handle correctly move to old_issues Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues Bug 18266: Fix internal error when paying fine for lost item without.. item Bug 18349: SCO - Do not trust the confirmed flag Bug 18349: $borrower is a hashref Bug 18349: If a confirmation is required, consider as blocker Bug 18349: Remove useless info in alert message Bug 14932: Do not call can_edit_subscription with an empty value Bug 18373: Re-add UpgradeBackup.pm Bug 18321: Add tests Bug 18321: Correctly calculate switch_onsite_checkout Bug 18364: Do not LOCK/UNLOCK tables from tests Julian Maurice (1): Bug 7728: QA fixes Katrin Fischer (2): Increment version for 16.11.07 release Add release notes to 16.11.07 release Kyle M Hall (2): Bug 18001 - Unit Test Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request Luke Honiss (1): Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl Marc V?ron (5): Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Bug 18307 - Branchname is no longer displayed in subscription tab view Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables Bug 18335 - Check in: Make patron info in hold messages obey syspref AddressFormat Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm Marcel de Rooy (10): Bug 18124: [Follow-up] Handle default parameters in a sub Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status Bug 14535: Late orders does not show orders with price = 0 Bug 14535: Update the supplier filter too Bug 7728: [QA Follow-up] Fix POD whitespace Bug 18019: Add CSRF protection to authorities-home.pl (op==delete) Bug 18019: [QA Follow-up] Also catch the delete from authorities detail Bug 18349: [QA Follow-up] Add four missing error messages Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls Bug 18364: [Follow-up] Also add an environment variable to prevent locking Mark Tompsett (1): Bug 17911: Message and timeout mismatch Nick Clemens (9): Bug 17995 - HOLDPLACED notice should have access to the reserves table Bug 12972 - Transfer slip and transfer message (blue box) can conflict Bug 18439 - Resend button for notices being hidden by CSS and never unhidden Bug 18423 - Add child button not always appearing - problem in template variable Bug 18423 follow up - fix display off add child on members/notices.pl Bug 18423 Follow-up - Add 'Add child' button to statistics tab Bug 18423 - Add 'Add child' button to files, housebound, and deletemem pages Bug 18423 - Followup - enable Add child button for institutional borrowers Bug 18429 - Receiving an item should update the datelastseen Olli-Antti Kivilahti (1): Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Owen Leonard (1): Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt Paul Poulain (2): Bug 7728: Fix subs history end date consistency Bug 7728: Adding unit test ReNewSubscription.t Tomas Cohen Arazi (1): Bug 18460: Fix undefined itemtype warning in Serials.t pongtawat (1): Bug 17814: koha-plack --stop should make sure that Plack really stop root (1): Translation updates for Koha 16.11.07 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 09:36:03 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 07:36:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19-27-gc4d5cc0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via c4d5cc0f297c384bf379efd5764a16e15f54bf07 (commit) via 94132d2fafff600a64d57ff88dffc170a185c158 (commit) via f4ab009df9893e2d9755d440123efffd69413df0 (commit) from 51041437ced506811b7b818ee4e14950efe7249c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c4d5cc0f297c384bf379efd5764a16e15f54bf07 Author: Julian Maurice Date: Mon Apr 24 09:29:18 2017 +0200 Increment version for 3.22.20 commit 94132d2fafff600a64d57ff88dffc170a185c158 Author: Julian Maurice Date: Mon Apr 24 09:28:23 2017 +0200 Update release notes for 3.22.20 commit f4ab009df9893e2d9755d440123efffd69413df0 Author: root Date: Mon Apr 24 04:19:10 2017 -0300 Translation updates for Koha 3.22.20 Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...e_notes_3_22_19.md => release_notes_3_22_20.md} | 123 +++++++++---- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 4 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 4 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 4 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 4 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 4 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 4 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 4 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 4 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 4 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 4 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 4 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 160 ++++++++--------- misc/translator/po/de-DE-pref.po | 45 ++--- misc/translator/po/de-DE-staff-help.po | 6 +- misc/translator/po/de-DE-staff-prog.po | 20 +-- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 28 +-- misc/translator/po/el-GR-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 4 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 4 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 4 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 4 +- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 156 ++++++++--------- misc/translator/po/es-ES-pref.po | 12 +- misc/translator/po/es-ES-staff-help.po | 25 +-- misc/translator/po/es-ES-staff-prog.po | 32 ++-- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 4 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 4 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 4 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 4 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 4 +- misc/translator/po/fr-FR-marc-MARC21.po | 6 +- misc/translator/po/fr-FR-marc-NORMARC.po | 6 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/fr-FR-pref.po | 62 ++----- misc/translator/po/fr-FR-staff-help.po | 20 +-- misc/translator/po/fr-FR-staff-prog.po | 13 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 4 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 4 +- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 4 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 4 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 4 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 4 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 4 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 4 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 4 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 4 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 156 ++++++++--------- misc/translator/po/it-IT-pref.po | 38 +--- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 14 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 4 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 4 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 4 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 4 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 4 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 4 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 4 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 4 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 4 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 4 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 4 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 4 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 4 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 4 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 4 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 4 +- misc/translator/po/nl-BE-marc-MARC21.po | 32 ++-- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/nl-BE-staff-help.po | 6 +- misc/translator/po/nl-BE-staff-prog.po | 8 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 4 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 4 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 4 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 150 ++++++++-------- misc/translator/po/pl-PL-pref.po | 39 +---- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 14 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 4 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 4 +- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/pt-PT-pref.po | 36 +--- misc/translator/po/pt-PT-staff-help.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 10 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 4 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 4 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 4 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 4 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 4 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 4 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 4 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 4 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 4 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 4 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 4 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 4 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 154 +++++++++-------- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 4 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 4 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 4 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 182 ++++++++++---------- misc/translator/po/tr-TR-pref.po | 22 +-- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 110 ++++++------ misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 4 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 4 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 146 ++++++++-------- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 4 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 4 +- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 148 ++++++++-------- misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 4 +- 485 files changed, 6624 insertions(+), 6679 deletions(-) copy misc/release_notes/{release_notes_3_22_19.md => release_notes_3_22_20.md} (57%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 09:37:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 07:37:35 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.22.20 created. v3.22.20 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.22.20 has been created at f3689081977472358c1d96f5c6f8a37abdb1f1cf (tag) tagging c4d5cc0f297c384bf379efd5764a16e15f54bf07 (commit) replaces v3.22.19 tagged by Julian Maurice on Mon Apr 24 09:29:46 2017 +0200 - Log ----------------------------------------------------------------- Koha release 3.22.20 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJY/alqAAoJELCH1RJUPDmpLr0P/ROlNtnkdLwxsJVm6mG0MKk5 6RjdiHBsve4UakzKnuGk5BblvyNuLGUdSAEAGVlbO6UQv/6DskZ3gr4/qIFqWp+3 191v8VwBRR9AiK0XQqwe31SBUf3HRU5+8di/qqWk83FPKMq5NAGDiDpKdJhTb5Dk Flh+GuooOHzKVV7r2AZhlvBWgAuUvNO0Rb+jNyOTi6FwFG47neJdcQVddVV38FFr fju/0sYdtuF6sL8zHlNmkEx9e5oOdsxagRdb/DnlfXpGk5e5uE6g3dgyrjuQAg7A 5xCUDXSu/GtIHcY/x/VjiHX4OPrwglf9NafsDO0KtKU16f6f6MaYviRZZjKdi5ym WUdEKcfZAELzv7+FBH29GggnPjtq68/Ro8CDrrNkAcv1qJVx+G0TeyuOld13VLae bZO1Lr9ynFPIBSJJyuJXpBXtJcmaDmHpaomucoHrtzP9MnodfPM2FS7GU6UjEHAX 1rEVeHx+eBsK5O0K26ZkMzC2qb2Q6y0drPJox1McTZJp645RXMr28FusTWSykK14 ghKn80s2QL+DpHX8GaeSsdtEA4LPiGpXfQzudO4+K/PA2WTY7Lf902JLv9+a1lSJ prNOKp1pcQiY0YqT4X9imfBwKoXxOvJpOF8rjRUorKqc4gQkkOyp2+vmXYLrBUnw kD8BAxHg6Fht463LbDNf =zh8i -----END PGP SIGNATURE----- Alex Buckley (1): Bug 12930: Web installer does not show login errors Blou (1): Bug 18209 - Patron's card manage.pl page is not fully translatable David Kuhn (1): Bug 17309 - Renewing and HomeOrHoldingBranch syspref Fridolin Somers (1): Bug 12913 - wrong inventory results when notforloan filter is not used Jonathan Druart (8): Bug 18058: Allow borrower_message_preferences to be truncated Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen Bug 18209: Add default, 'Actions' and fix case Bug 18266: Fix internal error when paying fine for lost item without.. item Bug 18349: SCO - Do not trust the confirmed flag Bug 18349: $borrower is a hashref Bug 18349: If a confirmation is required, consider as blocker Bug 18349: Remove useless info in alert message Julian Maurice (2): Update release notes for 3.22.20 Increment version for 3.22.20 Luke Honiss (1): Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl Marc V?ron (2): Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables Marcel de Rooy (6): Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status Bug 14535: Late orders does not show orders with price = 0 Bug 14535: Update the supplier filter too Bug 7728: [QA Follow-up] Fix POD whitespace Bug 18349: [QA Follow-up] Add four missing error messages Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls Nick Clemens (2): Bug 17995 - HOLDPLACED notice should have access to the reserves table Bug 12972 - Transfer slip and transfer message (blue box) can conflict Paul Poulain (1): Bug 7728: Fix subs history end date consistency root (1): Translation updates for Koha 3.22.20 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 15:44:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 13:44:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-905-g694c09a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 694c09aa873973c4f55b5d90948b1027adc0f1c1 (commit) from 4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 694c09aa873973c4f55b5d90948b1027adc0f1c1 Author: Tomas Cohen Arazi Date: Fri Apr 21 20:34:00 2017 -0300 Bug 18409: Make the controller for holds use Koha::Holds Recently, there's been a major fix on the REST api swagger spec, which involved fixing boolean values so they are actually booleans and Koha::Object was extended to handle that. While the swagger spec for this endpoint got fixed, such is not the case with the implementation (the controller class). This patch fixes this situation by: - Specifying boolean properties as boolean in the schema file - Fixes the controller so it returns Koha::Hold objects instead of the hashref returned by GetReserve, which is wrong. - Better (than empty) descriptions are added to 'suspend', 'suspend_until' and 'lowestPriority' on the spec. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, mostly due to error 500 results. - Apply this patch - Run: k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D This can also be tested using any interface for REST apis. Note: This endpoint lacks several of the new guidelines and is not complete (there's no GET for single holds, etc). It is also missing exception handling. There are probably other bug reports for that, just thought it was worth mentioning. Followed test plan and this patch worked as intended Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Hold.pm | 7 ++++--- Koha/Schema/Result/Reserve.pm | 5 +++++ api/v1/swagger/definitions/hold.json | 6 +++--- 3 files changed, 12 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:17:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:17:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-906-gc026d9f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c026d9f4e130d0585def4b1deb98e802ad35d258 (commit) from 694c09aa873973c4f55b5d90948b1027adc0f1c1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c026d9f4e130d0585def4b1deb98e802ad35d258 Author: Nick Clemens Date: Thu Apr 20 21:36:44 2017 -0400 Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/addorderiso2709.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:18:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:18:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-907-g330ecff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 330ecff1de417c40e5a48040a6f7df6436097bc4 (commit) from c026d9f4e130d0585def4b1deb98e802ad35d258 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 330ecff1de417c40e5a48040a6f7df6436097bc4 Author: Nick Clemens Date: Fri Apr 14 13:07:39 2017 -0400 Bug 18435 - Language entered in Materials Specified does not display when items are checked out and checked in This problem stems from bug 17642, if items.materials is not linked to an authorized value the contents are being tossed out. We shuold display them instead To test: 1 - Ensure items.materials 952$3 is not mapped to an authorized value 2 - Add a value to an item 3 - Check the item out, note the materials does not display 4 - Check the item in, note the materials does not display 5 - Apply patch 6 - Check the item out, note the materials does display 7 - Check the item in, note the materials does display Followed test plan, message about material displays as expected whil checking out and in. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 2 +- circ/returns.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:20:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:20:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-909-g41669b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 41669b45a808550088146380d534e4f3629590d9 (commit) via c7541091741878d28f648df8681a691cf787334c (commit) from 330ecff1de417c40e5a48040a6f7df6436097bc4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41669b45a808550088146380d534e4f3629590d9 Author: Jonathan Druart Date: Mon Apr 24 14:16:34 2017 -0300 Bug 18457: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c7541091741878d28f648df8681a691cf787334c Author: Kyle M Hall Date: Wed Apr 19 09:52:38 2017 -0400 Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055. This will cause all messages that come after the error to not be sent! Test Plan: 1) Enable SMS via Email 2) Enable SMS for a patron, but don't set a provider 3) Perform an action that will trigger an sms message to go into the holds queue ( item due, item checkout, etc ) 4) Run process_message_queue.pl, note the error 5) Apply the patch 4) Run process_message_queue.pl, no error this time! Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 4 ++++ t/db_dependent/Letters.t | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:22:11 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:22:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-911-g7fd248f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7fd248f3e9c80b36fb451eb90d2c34242c0cbb61 (commit) via 31378adbe1add83afd2ac77520a295c18ba70b72 (commit) from 41669b45a808550088146380d534e4f3629590d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7fd248f3e9c80b36fb451eb90d2c34242c0cbb61 Author: Mark Tompsett Date: Thu Jan 19 21:13:47 2017 -0500 Bug 15702: Recommended Counter-patch As per comment #7, this patch affects AddMember and ModMember. The test plan should be the same as comment #6. Secondary patch with tests still to come. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 31378adbe1add83afd2ac77520a295c18ba70b72 Author: Mark Tompsett Date: Fri Apr 21 08:58:03 2017 -0400 Bug 15702: Add test cases for modified code Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 15 +++++++++++++++ t/db_dependent/Members.t | 4 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:25:43 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:25:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-912-g736afd6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 736afd6d0119304df3ec61e01e275aea1645e7ac (commit) from 7fd248f3e9c80b36fb451eb90d2c34242c0cbb61 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 736afd6d0119304df3ec61e01e275aea1645e7ac Author: phette23 Date: Thu Apr 20 17:15:57 2017 -0700 Bug 18466: article requests box outline in opac To test: 1) apply patch 2) ensure ArticleRequests is set to Enable 3) sign in as a user with no article requests on the OPAC side 4) click the 'article requests' tab & see the box & message Sponsored-By: California College of the Arts Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 166 ++++++++++---------- 1 file changed, 86 insertions(+), 80 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:26:24 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:26:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-913-g4ac0aab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4ac0aab9bb8418a355e1f692e6b505500c96e0dd (commit) from 736afd6d0119304df3ec61e01e275aea1645e7ac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4ac0aab9bb8418a355e1f692e6b505500c96e0dd Author: Aleisha Amohia Date: Tue Apr 18 23:18:31 2017 +0000 Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 19:26:55 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 17:26:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-914-g82943de Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 82943de12ca5170b9504044c20462542ae0e5397 (commit) from 4ac0aab9bb8418a355e1f692e6b505500c96e0dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 82943de12ca5170b9504044c20462542ae0e5397 Author: Aleisha Amohia Date: Wed Apr 19 01:03:15 2017 +0000 Bug 18452: Correcting 'url' to say 'URL' in catalog detail To test: 1) Edit a record, put a URL in 856u and hit save 2) Confirm that url shows as URL in OPAC and staff client Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 24 21:30:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Apr 2017 19:30:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-915-gbcc0465 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bcc04652762ff097623630432946ca9203f7519f (commit) from 82943de12ca5170b9504044c20462542ae0e5397 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bcc04652762ff097623630432946ca9203f7519f Author: Jonathan Druart Date: Mon Apr 24 16:26:31 2017 -0300 Bug 18066: Remove warnings from translate script This patch removes the following warnings: Use of uninitialized value $pref_name in concatenation (.) or string at LangInstaller.pm ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:25:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:25:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-917-g475c294 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 475c294b292eadcc7e8d20307c16591fdf8b9b71 (commit) via 11d4ad19aa765fdc22488a07eaca48cb4c965e4e (commit) from bcc04652762ff097623630432946ca9203f7519f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 475c294b292eadcc7e8d20307c16591fdf8b9b71 Author: Jonathan Druart Date: Mon Apr 24 13:53:00 2017 -0300 Bug 18461: (bug 13757 follow-up) Do not mix decode_json and to_json Internal server error while approving OPAC-edited patron attributes containing umlauts (???) If a OPAC user enters text containing umlauts (???) in a patron atribute and saves it, the Staff client will get an inernal server error in members-update.pl (approving). E.g. a text like 111?222 leads to the following in plack error log: malformed UTF-8 character in JSON string, at character offset 14 To test: - Reproduce problem above - Apply patch - Verify that Home > Patron > Update records displays without error and 'New value' displays properly - Approve! Also, run the tests: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: Tests explode due to encoding problems in JSON handling - Apply the patch - Run the tests again: k$ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 11d4ad19aa765fdc22488a07eaca48cb4c965e4e Author: Tomas Cohen Arazi Date: Mon Apr 24 15:45:17 2017 -0300 Bug 18461: Make tests break on wrong UTF8 data handilng This patch makes the tests fail if extended attributes handling fails due to wrong UTF-8 data handling. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: Tests explode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Patron/Modification.pm | 2 +- Koha/Patron/Modifications.pm | 2 +- t/db_dependent/Koha/Patron/Modifications.t | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:28:41 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:28:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-918-g21992c7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 21992c7eca3442e868b14cbbd55a5c8b5d59c102 (commit) from 475c294b292eadcc7e8d20307c16591fdf8b9b71 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 21992c7eca3442e868b14cbbd55a5c8b5d59c102 Author: Kyle M Hall Date: Fri Apr 21 10:10:37 2017 -0400 Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total Test Plan: 1. Open a basket 2. Place an order for an item with price > 1000, $4367.00 for example 3. Close basket 4. Receive order 5. Note on orderreceive.pl the price is populate as "4,367.00" 6. Receive/Save 7. Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8. Cancel receipt 9. Receive again, this time enter price as "4367" 10. Receive/save 11. Note actual cost is correct 12. Finish receiving 13. Note invoice reads total as $4.00 14. Check db. price in aqorders is correct but displaying incorrectly 15. Apply this patch 16. Repeat step2 1. 14, note errors are fixed Signed-off-by: Nicolas Legrand Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/finishreceive.pl | 3 +++ acqui/invoice.pl | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:44:55 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:44:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-919-g21bddb3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 21bddb399d7f88a33c6dff474d07190a09e627dc (commit) from 21992c7eca3442e868b14cbbd55a5c8b5d59c102 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 21bddb399d7f88a33c6dff474d07190a09e627dc Author: Jonathan Druart Date: Fri Apr 21 13:05:47 2017 -0300 Bug 18467: Handle orders with deleted biblio when viewing a basket If the bibliographic record of an order has been removed, $order->{bibionumber} is undefined. We need to handle this specific case correctly. To test: 1 - Create a basket 2 - Order a bib 3 - Cancel order and delete record 4 - You cannot view basket 5 - Apply patch 6 - View basket 7 - There should not be an error r calling count on undefined bib in basket.pl if order cancelled and record deleted Followed test plan, works as intended Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 44 +++++++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:49:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:49:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-921-g2a2b973 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2a2b9739117e74232c9a7abde516b1c436d4bad3 (commit) via a1fcf1818c8d9f23d9c870e93c41c67a27faf603 (commit) from 21bddb399d7f88a33c6dff474d07190a09e627dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2a2b9739117e74232c9a7abde516b1c436d4bad3 Author: Jonathan Druart Date: Tue Apr 18 13:50:36 2017 -0300 Bug 18179: Update existing calls This patch updates the existing occurrences of ->find called in a list context. There are certainly others that are not easy to catch with git grep. Test plan: Confirm that the 4 modified scripts still works as expected. We need this one ASAP in master to make sure we will not get other side-effects of this kind and to catch possible uncaught occurrences before the release. Tested scripts changed by this patch, they work as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit a1fcf1818c8d9f23d9c870e93c41c67a27faf603 Author: Jonathan Druart Date: Tue Apr 18 13:49:18 2017 -0300 Bug 18179: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 2 ++ members/memberentry.pl | 2 +- members/moremember.pl | 2 +- members/pay.pl | 4 ++-- opac/opac-user.pl | 2 +- t/db_dependent/Koha/Objects.t | 12 +++++++++++- 6 files changed, 18 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:51:11 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:51:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-922-g2ca5866 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2ca5866866576f0e84041704b0156bc8288334bc (commit) from 2a2b9739117e74232c9a7abde516b1c436d4bad3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ca5866866576f0e84041704b0156bc8288334bc Author: Olivier Crouzet Date: Sat Apr 22 18:20:48 2017 +0200 Bug 18482 False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/addorderiso2709.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:54:48 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:54:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-923-gac2e6b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ac2e6b1b2658405db63a17527895d3d7d46ec811 (commit) from 2ca5866866576f0e84041704b0156bc8288334bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ac2e6b1b2658405db63a17527895d3d7d46ec811 Author: Aleisha Amohia Date: Thu Jan 5 02:01:57 2017 +0000 Bug 15738: Show rental fees on OPAC summary page This patch adds a few lines that check for a rental fee on an item. If yes, it will show in brackets as a rental fee on the OPAC summary page. To test: 1) Have a borrower with an overdue item accruing fines, a lost item and an item with a rental fee. Confirm the Fines column on the OPAC summary page now shows you what you may expect to see for each item. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- opac/opac-user.pl | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 12:57:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 10:57:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-924-gdddd269 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dddd2691e704654fd656c5d519e029c5dfc3ecc9 (commit) from ac2e6b1b2658405db63a17527895d3d7d46ec811 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dddd2691e704654fd656c5d519e029c5dfc3ecc9 Author: Owen Leonard Date: Tue Apr 25 16:16:49 2017 +0000 Bug 18419 - Broken patron-blank image in viewlog.tt Because of a variable name collision the blank patron image doesn't display in viewlog.tt. This patch moves the image from the template to the stylesheet to avoid this problem. This patch also replaces the blank patron image PNG file with an SVG file. SVG support is wide enough to begin using whereever possible. This patch also removes some inline CSS from circ-menu.inc and puts it in the global stylesheet. To test, apply the patch and clear your browser cache if necessary. - Enable the patronimages system preference. - View a patron account which lacks a patron image. All views (details, fines, notices, etc) should show the "blank" patron image, including the modification log view. - View a patron account which has a patron image and check that it still displays correctly in all views. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 18 ++++++++++++++++++ .../intranet-tmpl/prog/en/includes/circ-menu.inc | 8 ++++++-- .../intranet-tmpl/prog/img/patron-blank.min.svg | 1 + koha-tmpl/intranet-tmpl/prog/img/patron-blank.png | Bin 1559 -> 0 bytes 4 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/img/patron-blank.min.svg delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/patron-blank.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 13:03:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 11:03:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-925-g3fddc0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3fddc0d73724c6c5f1aafe6842c488304b79f306 (commit) from dddd2691e704654fd656c5d519e029c5dfc3ecc9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3fddc0d73724c6c5f1aafe6842c488304b79f306 Author: Owen Leonard Date: Tue Apr 25 13:15:13 2017 +0000 Bug 17916 - "Delete MARC modification template" fails to actually delete it The MARC modification templates' 'Delete' button fails because the event handler has a "preventDefault" but the outcome of the confirmation function must return true or false. This patch removes the "preventDefault" from the .delete_template click handler as well as a redundant onclick attribute from the delete link itself. To test, apply the patch and go to Tools -> MARC modification templates. Clicking the delete button for any existing template should work correctly. Followed test plan, worked as intended Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/marc_modification_templates.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:33:49 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:33:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-927-g15ccc7b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15ccc7b1e60241ed25bb43bb070a7e6154f2be1c (commit) via 5de92c26a4239b41a9e495ec060b205f19d97523 (commit) from 3fddc0d73724c6c5f1aafe6842c488304b79f306 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15ccc7b1e60241ed25bb43bb070a7e6154f2be1c Author: Jonathan Druart Date: Wed Apr 19 12:32:06 2017 -0300 Bug 18453: Remove exports_enabled in circulation_batch_checkouts.tt This is a c/p from circulation.tt, this variable is not needed in this template Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 5de92c26a4239b41a9e495ec060b205f19d97523 Author: Jonathan Druart Date: Wed Apr 19 12:29:26 2017 -0300 Bug 18453: Hide the export column when needed If exports_enabled is equal to "0" it will be evaluated to true. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/circ/circulation_batch_checkouts.tt | 3 --- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:34:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:34:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-928-gfdc6b03 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fdc6b033a55e917647f8f099902f2750e79cc740 (commit) from 15ccc7b1e60241ed25bb43bb070a7e6154f2be1c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fdc6b033a55e917647f8f099902f2750e79cc740 Author: Owen Leonard Date: Mon Apr 24 12:36:58 2017 +0000 Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly Two columns in the user's holds table in the OPAC do not sort correctly because they are not marked up correctly to enable date sorting: 'Placed on' and 'Expires on.' This patch corrects it. This patch also removes a stray which was causing validation errors. To test, apply the patch and log into the OPAC with an account which has multiple holds with differnt hold dates and expiration dates. Confirm that sorting on these columns works correctly. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:35:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:35:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-929-g0677f26 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0677f26772029066f0e4e5a5b0273556f44c72c3 (commit) from fdc6b033a55e917647f8f099902f2750e79cc740 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0677f26772029066f0e4e5a5b0273556f44c72c3 Author: Zeno Tajoli Date: Wed Apr 19 14:51:19 2017 +0200 Update Italian installer sample files for 17.05 Update and translate sample SQL file of the Italian installer. To test: - Start with an empty database - Install it-IT - Run the web installer in it-IT/Italian - Verify all files, especially sample notices, sample_frequencies, sample_numberpatterns load without any problems. https://bugs.koha-community.org/show_bug.cgi?id=18456 While applying I got a 3-way-merge. Verified in staff client places mentioned above, notices, frequencies, sample_numberpatterns, HSBND_FREQ Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/it-IT/necessari/auth_val.sql | 2 +- installer/data/mysql/it-IT/necessari/csv_profiles.sql | 2 +- installer/data/mysql/it-IT/necessari/notices.sql | 14 +++++++------- 3 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:36:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:36:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-930-g9a9b0aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a9b0aab879d1decbdeb9bac02ae198a21a46afb (commit) from 0677f26772029066f0e4e5a5b0273556f44c72c3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a9b0aab879d1decbdeb9bac02ae198a21a46afb Author: Marc V?ron Date: Fri Apr 21 21:22:44 2017 +0200 Bug 13835: Popup with searches: results hidden by language menu in footer Language menus in pop up windows are not necessary and can hide the contents (especially search results) on a narrow screen. For an example, see screenshot in comment #3 This patch allows to mark pop p menus not to display the language footer. To test: - Reproduce issue from comment #3 - Apply patch - Try to reproduce issue from comment #3 -> language menu should no longer display - Verify that language menu is suppresed in 'Add to ist' as well (from catalog search results, select an item, Add to:...) Note: There will be more pop-ups with unwnated language selector. That can be resolved in follow up bugs. Followed test plan which worked as intended Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt | 1 + .../prog/en/modules/virtualshelves/addbybiblionumber.tt | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:37:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:37:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-938-g45a35f1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 45a35f1ecc7c41073c3cb3f3ea56f496dcd0171c (commit) via 02b3816656c779e803b7e91bdeb1aedbfdb7ac67 (commit) via 2e7832782966a9c4b673fb23097ffce46fa19c55 (commit) via 883a7d21e1c3477fa547b02b1a32936a673ddef4 (commit) via 262f2dd48b6fee61cbe6e04e4781833d291ea4c6 (commit) via a8935fdea2c72c89e7064c123a0782d9ecb8e44e (commit) via 3d80ca1758c135042b0ca4d261d1198a40a35197 (commit) via 0492fcf87f170846d1e6c8683916a56cb67ce9a7 (commit) from 9a9b0aab879d1decbdeb9bac02ae198a21a46afb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45a35f1ecc7c41073c3cb3f3ea56f496dcd0171c Author: Jonathan Druart Date: Mon Apr 17 15:42:35 2017 -0300 Bug 17855: Simplify the onboarding tool This patch should not modify a lot the behaviours of the onboarding tool. Its goal is mainly to remove duplicated as well as useless (because copy/pasted from existing script files) code. It assumes that the onboarding tool will be done on an empty database and will skip steps that are not needed. For instance if a library already exists, the first step will be skipped. One of the main problem was the lack of feedback messages sent to the user when something wrong/ok happened. Explanation on main changes: 1. Use checkauth first, then get_template_and_user => As we do not know the template to use, it's better to use checkauth first to know if the user is logged in, then retrieve the template we need, depending on the success or the failure of the action 2. Create a @messages variables Pushing messages to this variable and handling the messages via an include files (onboarding_messages.inc) simplify error handling. Note that we could remove this include file if we merge all the onboardingstepX.tt files altogether 3. Simplify creation of the admnistrator user This patch removes some unecessary checks done on the user's info (passwd to short, mandatory fields Todo (minor): Add style to feedback messages Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 02b3816656c779e803b7e91bdeb1aedbfdb7ac67 Author: Jonathan Druart Date: Mon Apr 17 12:18:31 2017 -0300 Bug 17855: No need to resend the library list to the template This has been done at the beginning of the script Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2e7832782966a9c4b673fb23097ffce46fa19c55 Author: Jonathan Druart Date: Mon Apr 17 12:16:17 2017 -0300 Bug 17855: Redirect to the installer if installation process is not done yet Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 883a7d21e1c3477fa547b02b1a32936a673ddef4 Author: Jonathan Druart Date: Mon Apr 17 12:13:45 2017 -0300 Bug 17855: Do not create a new dbh, get it from C4::Context->dbh Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 262f2dd48b6fee61cbe6e04e4781833d291ea4c6 Author: Jonathan Druart Date: Mon Apr 17 12:05:21 2017 -0300 Bug 17855: perltidy onboarding.pl Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a8935fdea2c72c89e7064c123a0782d9ecb8e44e Author: Alex Buckley Date: Sun Apr 9 05:30:05 2017 +0000 Bug 17855 - Followup patch following requests in comments 176 and 177 Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3d80ca1758c135042b0ca4d261d1198a40a35197 Author: Alex Buckley Date: Sat Mar 18 18:19:17 2017 +0000 Bug 17855 - Reverted back to original step 3 in the web installer so there is no basic and advanced setup mode and consequently no need for SQL files to be moved to a 'default' directory for all languages. Onboarding tool and the rest of the web installer still exists in this commit How I tested in my VM (Current master): - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Author: Alex Buckley Date: Thu Feb 9 17:32:29 2017 +0100 Bug 17855: Onboarding tool Tested 3 patches together on current master - Dropped database - Recreated database - Went through installer - Language en, Marc21 - Installed mandatory data only - Went through Onboarding tool - After finishing, logged in as superlibrarian that was created by onboarding tool Everything worked fine. Signed-off-by: Marc V?ron Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../data/mysql/en/optional/patron_categories.sql | 2 +- .../data/mysql/en/optional/patron_categories.txt | 6 +- .../data/mysql/en/optional/sample_holidays.txt | 5 +- .../data/mysql/en/optional/sample_libraries.txt | 2 +- .../mysql/en/optional/sample_z3950_servers.txt | 1 + installer/install.pl | 352 ++++++++++++-------- installer/onboarding.pl | 329 ++++++++++++++++++ .../intranet-tmpl/prog/en/includes/calendar.inc | 2 +- .../prog/en/includes/installer-doc-head-close.inc | 15 + .../prog/en/includes/onboarding_messages.inc | 20 ++ .../prog/en/modules/admin/categories.tt | 2 +- .../prog/en/modules/installer/step3.tt | 243 +++++++------- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 - .../prog/en/modules/onboarding/onboardingstep1.tt | 38 +++ .../prog/en/modules/onboarding/onboardingstep2.tt | 123 +++++++ .../prog/en/modules/onboarding/onboardingstep3.tt | 152 +++++++++ .../prog/en/modules/onboarding/onboardingstep4.tt | 41 +++ .../prog/en/modules/onboarding/onboardingstep5.tt | 114 +++++++ xt/sample_notices.t | 2 +- 19 files changed, 1171 insertions(+), 280 deletions(-) create mode 100755 installer/onboarding.pl create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/onboarding_messages.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:49:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:49:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-943-g368670c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 368670cda7c7456d6701c3602846a6b5d4c605ec (commit) via 6b5c632d9e254aac419b0576508ea6296b7b03a2 (commit) via 709358e0c98a583b48f0fee13adb45c00f51b5ff (commit) via 589aa069915c001792a71d900e26a20526d6b9d0 (commit) via 95429af6855e8ed37945b681dc466bf360deffb2 (commit) from 45a35f1ecc7c41073c3cb3f3ea56f496dcd0171c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 368670cda7c7456d6701c3602846a6b5d4c605ec Author: Kyle M Hall Date: Fri Apr 28 08:46:59 2017 -0400 Bug 12461 - DBRev 16.12.00.027 Signed-off-by: Kyle M Hall commit 6b5c632d9e254aac419b0576508ea6296b7b03a2 Author: Marc V?ron Date: Mon May 4 23:29:29 2015 +0200 Bug 14143 - Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields) To reproduce: Go to Home > Tools > Patron card creator Click on 'Manage profiles' Result: Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/kohaclone/C4/Creators/Lib.pm line 564. Reason: Select statment to get field 'template code' from table 'club_template_enrollment_fields' (!) instead of 'table creator_templates'. To test: Apply patch Try to reproduce issue. Amended because of typo (_ instead of -) Signed-off-by: Kyle M Hall commit 709358e0c98a583b48f0fee13adb45c00f51b5ff Author: Nick Clemens Date: Fri Apr 28 06:43:44 2017 -0400 Bug 12461 - (QA Followup) Club enrollments should only list active enrollments Confirms should warn of cascading delete Branch limited clubs should only be available to members of that branch Fix breadcrumbs Signed-off-by: Kyle M Hall commit 589aa069915c001792a71d900e26a20526d6b9d0 Author: Kyle M Hall Date: Thu Apr 27 08:24:29 2017 -0400 Bug 12461 [QA Followup] Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 95429af6855e8ed37945b681dc466bf360deffb2 Author: Kyle M Hall Date: Fri May 23 11:54:26 2014 -0400 Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 5 +- C4/Creators/Lib.pm | 2 +- C4/Members.pm | 16 +- Koha.pm | 2 +- Koha/Club.pm | 104 ++++++++ Koha/Club/Enrollment.pm | 88 +++++++ Koha/Club/Enrollment/Field.pm | 56 ++++ Koha/Club/Enrollment/Fields.pm | 60 +++++ Koha/Club/Enrollments.pm | 60 +++++ Koha/Club/Field.pm | 66 +++++ Koha/Club/Fields.pm | 60 +++++ Koha/Club/Template.pm | 75 ++++++ Koha/Club/Template/EnrollmentField.pm | 54 ++++ Koha/Club/Template/EnrollmentFields.pm | 60 +++++ Koha/Club/Template/Field.pm | 54 ++++ Koha/Club/Template/Fields.pm | 60 +++++ Koha/Club/Templates.pm | 60 +++++ Koha/Clubs.pm | 98 +++++++ Koha/Patron.pm | 46 ++++ Koha/Schema/Result/AuthorisedValue.pm | 6 +- Koha/Schema/Result/Borrower.pm | 19 +- Koha/Schema/Result/Branch.pm | 49 +++- Koha/Schema/Result/Club.pm | 197 ++++++++++++++ Koha/Schema/Result/ClubEnrollment.pm | 201 ++++++++++++++ Koha/Schema/Result/ClubEnrollmentField.pm | 112 ++++++++ Koha/Schema/Result/ClubField.pm | 112 ++++++++ Koha/Schema/Result/ClubTemplate.pm | 195 ++++++++++++++ Koha/Schema/Result/ClubTemplateEnrollmentField.pm | 119 +++++++++ Koha/Schema/Result/ClubTemplateField.pm | 119 +++++++++ Koha/Template/Plugin/AuthorisedValues.pm | 4 +- Koha/Template/Plugin/Borrowers.pm | 1 - clubs/club-enrollments.pl | 47 ++++ clubs/clubs-add-modify.pl | 113 ++++++++ clubs/clubs.pl | 60 +++++ clubs/patron-clubs-tab.pl | 55 ++++ clubs/patron-enroll.pl | 50 ++++ clubs/templates-add-modify.pl | 152 +++++++++++ installer/data/mysql/kohastructure.sql | 124 +++++++++ installer/data/mysql/updatedatabase.pl | 129 +++++++++ installer/data/mysql/userflags.sql | 3 +- installer/data/mysql/userpermissions.sql | 5 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 4 + .../intranet-tmpl/prog/en/includes/tools-menu.inc | 3 + .../prog/en/modules/circ/circulation.tt | 25 +- .../prog/en/modules/clubs/club-enrollments.tt | 74 ++++++ .../prog/en/modules/clubs/clubs-add-modify.tt | 115 ++++++++ .../intranet-tmpl/prog/en/modules/clubs/clubs.tt | 276 ++++++++++++++++++++ .../prog/en/modules/clubs/patron-clubs-tab.tt | 102 ++++++++ .../prog/en/modules/clubs/patron-enroll.tt | 66 +++++ .../prog/en/modules/clubs/templates-add-modify.tt | 216 +++++++++++++++ .../prog/en/modules/members/moremember.tt | 23 ++ .../prog/en/modules/tools/tools-home.tt | 5 + .../bootstrap/en/modules/clubs/clubs-tab.tt | 102 ++++++++ .../opac-tmpl/bootstrap/en/modules/clubs/enroll.tt | 66 +++++ .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 27 +- members/moremember.pl | 2 + opac/clubs/clubs-tab.pl | 52 ++++ opac/clubs/enroll.pl | 49 ++++ opac/svc/club/cancel_enrollment | 47 ++++ opac/svc/club/enroll | 77 ++++++ svc/club/cancel_enrollment | 46 ++++ svc/club/delete | 48 ++++ svc/club/enroll | 74 ++++++ svc/club/template/delete | 49 ++++ t/db_dependent/Clubs.t | 224 ++++++++++++++++ 65 files changed, 4639 insertions(+), 31 deletions(-) create mode 100644 Koha/Club.pm create mode 100644 Koha/Club/Enrollment.pm create mode 100644 Koha/Club/Enrollment/Field.pm create mode 100644 Koha/Club/Enrollment/Fields.pm create mode 100644 Koha/Club/Enrollments.pm create mode 100644 Koha/Club/Field.pm create mode 100644 Koha/Club/Fields.pm create mode 100644 Koha/Club/Template.pm create mode 100644 Koha/Club/Template/EnrollmentField.pm create mode 100644 Koha/Club/Template/EnrollmentFields.pm create mode 100644 Koha/Club/Template/Field.pm create mode 100644 Koha/Club/Template/Fields.pm create mode 100644 Koha/Club/Templates.pm create mode 100644 Koha/Clubs.pm create mode 100644 Koha/Schema/Result/Club.pm create mode 100644 Koha/Schema/Result/ClubEnrollment.pm create mode 100644 Koha/Schema/Result/ClubEnrollmentField.pm create mode 100644 Koha/Schema/Result/ClubField.pm create mode 100644 Koha/Schema/Result/ClubTemplate.pm create mode 100644 Koha/Schema/Result/ClubTemplateEnrollmentField.pm create mode 100644 Koha/Schema/Result/ClubTemplateField.pm create mode 100755 clubs/club-enrollments.pl create mode 100755 clubs/clubs-add-modify.pl create mode 100755 clubs/clubs.pl create mode 100755 clubs/patron-clubs-tab.pl create mode 100755 clubs/patron-enroll.pl create mode 100755 clubs/templates-add-modify.pl create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt create mode 100755 opac/clubs/clubs-tab.pl create mode 100755 opac/clubs/enroll.pl create mode 100755 opac/svc/club/cancel_enrollment create mode 100755 opac/svc/club/enroll create mode 100755 svc/club/cancel_enrollment create mode 100755 svc/club/delete create mode 100755 svc/club/enroll create mode 100755 svc/club/template/delete create mode 100755 t/db_dependent/Clubs.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:51:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:51:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-949-gfbcb0e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fbcb0e6505bb74abc131b6e1626ad6976fb40239 (commit) via 892527495ad57e98a725d946e182538515cfab2d (commit) via 4ed61b56f50b7dd4d3cc29a5ada93c25212a7e39 (commit) via 4c8580b1bbfa01e1fd0c7980ceafc0ffc8ad3148 (commit) via 54bb284a60dab066d7ad0b08005ada576d0f31f1 (commit) via 62b2e505d4c6f967f72cb4d8969f0cde8e678722 (commit) from 368670cda7c7456d6701c3602846a6b5d4c605ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbcb0e6505bb74abc131b6e1626ad6976fb40239 Author: Jonathan Druart Date: Wed Apr 26 15:41:35 2017 -0300 Bug 18110: Do not update value for existing installs Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 892527495ad57e98a725d946e182538515cfab2d Author: Baptiste Wojtkowski Date: Mon Apr 3 13:40:44 2017 +0000 Bug 18110: Update addressFormat in atomicupdate Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4ed61b56f50b7dd4d3cc29a5ada93c25212a7e39 Author: Marc V?ron Date: Tue Mar 28 09:20:47 2017 +0200 Bug 18110: Folllowup to fix alternative address and add missing class This patch fixes the display of alternative address (streetnumber, streettype and address on same line, see comment #22, and it adds missing class patronaddress1 to main address display. To test: - Create / edit a customer to have streetnumber, streettype and address in both main address and alternate address - Switch syspref addressformat ot French style - Verify that both main address and alternate address display as expected on patron's detail page (street number, street type and address on same line) Signed-off-by: Baptiste Wojtkowski Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4c8580b1bbfa01e1fd0c7980ceafc0ffc8ad3148 Author: Baptiste Wojtkowski Date: Mon Mar 27 07:32:06 2017 +0000 Bug 18110: Removed unwanted spaces Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 54bb284a60dab066d7ad0b08005ada576d0f31f1 Author: Baptiste Wojtkowski Date: Fri Mar 24 12:47:42 2017 +0000 Bug 18110: Corrected display address format - minor changes on address format - corrected member-password so that steetnumber is given to the template Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 62b2e505d4c6f967f72cb4d8969f0cde8e678722 Author: Baptiste Wojtkowski Date: Mon Feb 27 09:32:24 2017 +0000 Bug 18110: Add a field FR to the syspref AddressFormat Add a field FR to the syspref AddressFormat Testplan 1 - Apply patch 2 - Check if there is a field FR in the syspref AddressFormat, enable it 3 - Create a new borrower and check the order of the fields for the address 4 - Check if it's address appears in a propper manner 27/02/17 : Fixed the display Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../bug18110_updated_AddressFormat.sql | 1 + installer/data/mysql/sysprefs.sql | 2 +- .../en/includes/member-alt-address-style-fr.inc | 148 ++++++++++++++++++++ .../en/includes/member-alt-contact-style-fr.inc | 112 +++++++++++++++ ...-de.inc => member-display-address-style-fr.inc} | 9 +- ...inc => member-display-alt-address-style-fr.inc} | 11 +- .../en/includes/member-main-address-style-fr.inc | 124 ++++++++++++++++ .../en/modules/admin/preferences/i18n_l10n.pref | 1 + members/member-password.pl | 1 + 9 files changed, 402 insertions(+), 7 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug18110_updated_AddressFormat.sql create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-fr.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style-fr.inc copy koha-tmpl/intranet-tmpl/prog/en/includes/{member-display-address-style-de.inc => member-display-address-style-fr.inc} (56%) copy koha-tmpl/intranet-tmpl/prog/en/includes/{member-display-alt-address-style-de.inc => member-display-alt-address-style-fr.inc} (55%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:54:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:54:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-950-ge3d8fb0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e3d8fb0b845f50f6debc9a246a09a22f3f88c406 (commit) from fbcb0e6505bb74abc131b6e1626ad6976fb40239 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e3d8fb0b845f50f6debc9a246a09a22f3f88c406 Author: Kyle M Hall Date: Fri Apr 28 08:53:00 2017 -0400 Bug 18110 - DBRev 16.12.00.028 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../mysql/atomicupdate/bug18110_updated_AddressFormat.sql | 1 - installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug18110_updated_AddressFormat.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 14:59:37 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 12:59:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-951-g02dffe1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 02dffe16081fdcf35b50824d963d2420546a95eb (commit) from e3d8fb0b845f50f6debc9a246a09a22f3f88c406 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 02dffe16081fdcf35b50824d963d2420546a95eb Author: Jonathan Druart Date: Wed Apr 5 16:42:26 2017 -0300 Bug 18401: Add new method Koha::Checkout->patron Return the patron related to a given checkout Test plan: prove t/db_dependent/Koha/Checkouts.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Checkout.pm | 14 ++++++++++++++ t/db_dependent/Koha/Checkouts.t | 9 ++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 15:02:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 13:02:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-952-ga067af7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a067af7fe2e1a1f0beefadbb319a2bf2e9b9884f (commit) from 02dffe16081fdcf35b50824d963d2420546a95eb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a067af7fe2e1a1f0beefadbb319a2bf2e9b9884f Author: Jonathan Druart Date: Wed Apr 5 16:42:35 2017 -0300 Bug 18402: Add the Koha::Item->checkout method Return the current checkout for a given item. Note it may not exist. Test plan: prove t/db_dependent/Koha/Items.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Item.pm | 16 ++++++++++++++++ t/db_dependent/Koha/Items.t | 30 +++++++++++++++++++++++++++++- 2 files changed, 45 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 15:03:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 13:03:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-953-g6f334aa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6f334aab06fd6e07f2ab8b399fbe50168d5818f4 (commit) from a067af7fe2e1a1f0beefadbb319a2bf2e9b9884f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f334aab06fd6e07f2ab8b399fbe50168d5818f4 Author: Owen Leonard Date: Mon Apr 24 14:21:00 2017 +0000 Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid This patch corrects HTML validation errors by adding back a missing which was removed accidentally by Bug 9043 (2014!). This patch also removes "border" attributes from tags because the attribute is obsolete. To test, apply the patch and test the validity of the OPAC's advanced search page. The only error should be one about 'Bad value "api-server,"' which isn't really resolvable. Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-advsearch.tt | 27 ++++++++++---------- 1 file changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 15:13:07 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 13:13:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-966-gb492182 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b492182b69e353f4f08d227b1ec7525a23bd6fe0 (commit) via 6dd7fb7b19ba9417ff8939ed01618ef3d328d825 (commit) via f5b1154e704d97b63edf6fc9e699ca114c8603ba (commit) via 0fa07cce329e52abea601c75b1d05f9ee915b530 (commit) via e54152a90b0770c240232bc27363f77fed910a8d (commit) via ba658d5919b898c71d21380c9b302818a636c090 (commit) via c4dd097d20040cc2786ca062d306b8eee1f005e2 (commit) via 88852ffbb0de4a3b06df50921d555cec9b525957 (commit) via a7df1afe60e10f991a017559c9057c40ae20eadb (commit) via 8c0ff71ff0f08f6700ca87a75bb8a7c9a046ab88 (commit) via 93e04a9925aa90cfeb5c0ede5b2528dc28848844 (commit) via a56690d3a441abb9e911598865cc68e07e598487 (commit) via 0159908ca144bca599ed9a0ff51fd3f0ab2ad0ab (commit) from 6f334aab06fd6e07f2ab8b399fbe50168d5818f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b492182b69e353f4f08d227b1ec7525a23bd6fe0 Author: Kyle M Hall Date: Thu Apr 27 19:10:47 2017 +0000 Bug 14224 - DBRev 16.12.00.029 Signed-off-by: Kyle M Hall commit 6dd7fb7b19ba9417ff8939ed01618ef3d328d825 Author: Jonathan Druart Date: Thu Apr 20 13:46:35 2017 -0300 Bug 14424: DBIC Schema changes https://bugs.koha-community.org/show_bug.cgi?id=14224 Signed-off-by: Kyle M Hall commit f5b1154e704d97b63edf6fc9e699ca114c8603ba Author: Jonathan Druart Date: Thu Apr 20 13:42:02 2017 -0300 Bug 14224: Use encode_json instead of to_json To handle unicode characters properly Signed-off-by: Kyle M Hall commit 0fa07cce329e52abea601c75b1d05f9ee915b530 Author: Jonathan Druart Date: Wed Feb 1 15:53:06 2017 +0100 Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit e54152a90b0770c240232bc27363f77fed910a8d Author: Jonathan Druart Date: Wed Feb 1 17:01:00 2017 +0100 Bug 14224: Improve escaped characters To recreate the problem, submit a note like doh"doh Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit ba658d5919b898c71d21380c9b302818a636c090 Author: Jonathan Druart Date: Wed Feb 1 16:56:46 2017 +0100 Bug 14224: Update Copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit c4dd097d20040cc2786ca062d306b8eee1f005e2 Author: Jonathan Druart Date: Thu Feb 2 11:37:54 2017 +0100 Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit 88852ffbb0de4a3b06df50921d555cec9b525957 Author: Jonathan Druart Date: Wed Feb 1 16:38:37 2017 +0100 Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit a7df1afe60e10f991a017559c9057c40ae20eadb Author: Jonathan Druart Date: Thu Feb 2 11:10:30 2017 +0100 Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit 8c0ff71ff0f08f6700ca87a75bb8a7c9a046ab88 Author: Jonathan Druart Date: Thu Feb 2 11:10:28 2017 +0100 Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit 93e04a9925aa90cfeb5c0ede5b2528dc28848844 Author: Jonathan Druart Date: Thu Feb 2 10:49:18 2017 +0100 Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit a56690d3a441abb9e911598865cc68e07e598487 Author: Jonathan Druart Date: Wed Feb 1 15:56:34 2017 +0100 Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall commit 0159908ca144bca599ed9a0ff51fd3f0ab2ad0ab Author: Aleisha Amohia Date: Sun Aug 23 18:22:50 2015 +0200 Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Marc V?ron ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Issue.pm | 23 ++++- Koha/Schema/Result/OldIssue.pm | 23 ++++- circ/returns.pl | 3 + installer/data/mysql/kohastructure.sql | 4 + installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 29 ++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++ .../intranet-tmpl/prog/en/modules/circ/returns.tt | 10 ++ koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 19 +++- .../bootstrap/en/modules/opac-issue-note.tt | 54 ++++++++++ .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 94 ++++++++++++++++++ opac/opac-issue-note.pl | 88 +++++++++++++++++ opac/opac-user.pl | 2 + opac/svc/patron_notes | 104 ++++++++++++++++++++ svc/checkin | 5 + 16 files changed, 458 insertions(+), 9 deletions(-) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt create mode 100755 opac/opac-issue-note.pl create mode 100755 opac/svc/patron_notes hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 15:29:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 13:29:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-970-g8c1b551 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8c1b551b38f1fb26ce4c946d59c8a3cfa83f7a69 (commit) via 868ecdbbb33136bad96857da288d9bc060360444 (commit) via 09fe525003e9412b10bb74dfc5b2f386e1389ebf (commit) via d3e459289f9e9b2ee4a138693d855e829a9b0a82 (commit) from b492182b69e353f4f08d227b1ec7525a23bd6fe0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c1b551b38f1fb26ce4c946d59c8a3cfa83f7a69 Author: Kyle M Hall Date: Fri Apr 28 09:28:33 2017 -0400 Bug 16344 - DBRev 16.12.00.030 Signed-off-by: Kyle M Hall commit 868ecdbbb33136bad96857da288d9bc060360444 Author: Kyle M Hall Date: Thu Apr 27 19:21:11 2017 +0000 Bug 16344 - Update Schema Signed-off-by: Kyle M Hall commit 09fe525003e9412b10bb74dfc5b2f386e1389ebf Author: Jonathan Druart Date: Tue Apr 26 16:58:49 2016 +0100 Bug 16344: Fix alignment between top and bottom columns Signed-off-by: Jonathan Field Signed-off-by: Janet McGowan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit d3e459289f9e9b2ee4a138693d855e829a9b0a82 Author: Jonathan Druart Date: Mon Apr 25 21:52:27 2016 +0100 Bug 16344: Add a circ rule to limit the auto renewals given a specific This patch adds a new circulation rule (no_auto_renewal_after_hard_limit) to block/allow auto renewals after a given date. The idea is to stop renewals at a given date. That way the library will have time to send overdues and get the books back before the students do on holiday. Test plan: 0/ Execute the update DB entry 1/ Define a rule with no_auto_renewal_after_hard_limit set to tomorrow 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 4/ Modify the no_auto_renewal_after_hard_limit and set it to yesterday 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed Signed-off-by: Jonathan Field Signed-off-by: Janet McGowan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 59 +++++++++++++------- Koha.pm | 2 +- Koha/Schema/Result/Issuingrule.pm | 12 +++- admin/smart-rules.pl | 9 +++ installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 12 ++++ .../prog/en/modules/admin/smart-rules.tt | 7 +++ t/db_dependent/Circulation.t | 44 +++++++++++++-- 8 files changed, 116 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 28 18:50:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Apr 2017 16:50:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-972-g1f007ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1f007ca2e93aa05abdeb8ae78a59b313074abaf0 (commit) via c1d9a7dab7d57cca9059e4ccf72b3bfc41bfad5a (commit) from 8c1b551b38f1fb26ce4c946d59c8a3cfa83f7a69 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1f007ca2e93aa05abdeb8ae78a59b313074abaf0 Author: Kyle M Hall Date: Fri Apr 28 12:49:05 2017 -0400 Revert "Bug 18179: Forbid list context calls for Koha::Objects->find" This reverts commit a1fcf1818c8d9f23d9c870e93c41c67a27faf603. Signed-off-by: Kyle M Hall commit c1d9a7dab7d57cca9059e4ccf72b3bfc41bfad5a Author: Kyle M Hall Date: Fri Apr 28 12:48:56 2017 -0400 Revert "Bug 18179: Update existing calls" This reverts commit 2a2b9739117e74232c9a7abde516b1c436d4bad3. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 2 -- members/memberentry.pl | 2 +- members/moremember.pl | 2 +- members/pay.pl | 4 ++-- opac/opac-user.pl | 2 +- t/db_dependent/Koha/Objects.t | 12 +----------- 6 files changed, 6 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository