[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06-32-gdbd6ec6

Mon Apr 10 23:56:35 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  dbd6ec62a40d4cb52da8911174f158288b498886 (commit)
       via  a59f056631e882ce166eed7eb6e366481449b148 (commit)
       via  ad24c194bd0e44688805e394512a0fbe4aed4095 (commit)
       via  2f77044f63e1d7faef3692a8533b2c56c2b723ab (commit)
       via  6bf6a53b86a688bead0b8b3b114c9dc509a661ae (commit)
       via  74949be55a268f588e3eeaeafc52a87538005743 (commit)
      from  9668331d4260928dbe91ec9710031e5ac63f5346 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dbd6ec62a40d4cb52da8911174f158288b498886
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Mar 24 16:07:16 2017 +0100

    Bug 18329 - Batch record deletion broken

    Hie, Tools > Batch record deletion seems broken.
    Any deletion returns error :
    Bibliographic record YYY was not deleted. An error occurred. (The error was: {UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at /home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more information).

    Looks like it is because of Bug 18242 which added a transaction  in C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
    The script batch_delete_records created a transaction with $dbh->{AutoCommit} = 0;

    This patch fixes by using also Koha::Schema in batch_delete_records to manage transaction.
    It also removes "$dbh->{RaiseError} = 1", this behavior is managed in Koha::Database.

    Test plan :
     - Go to Staff interface : Tools > Batch record deletion
     - Enter a few existing biblionumbers
     - Click on "Continue"
     - Click on "Delete selected records"
    => Without patch you get a DB error
    => With patch you get confirmation message
     - Try to get the biblios to confirm they are deleted : /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
     - Test with and without Plack

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 0f32bd99997c82cf7b70eef32818dc817cbff64b)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit a59f056631e882ce166eed7eb6e366481449b148
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 21 12:24:28 2017 -0300

    Bug 18266: Fix internal error when paying fine for lost item without.. item

    If a fine is created for a lost item but the itemnumber is not supplied,
    the system will return it.
    The item should not be mark as returned if there is no item linked to
    the fine.

    Test plan:
    1. Turn StoreLastBorrower on
    2. Create a manual invoice for a lost item, do not supply a barcode
    3. Pay the fines 'Pay fines > Pay'

    => Without this patch applied you get
    Can't call method "last_returned_by" on an undefined value at
    /home/marc/koha/C4/Circulation.pm line 2188.

    => With this patch applied, you must not get the error.

commit ad24c194bd0e44688805e394512a0fbe4aed4095
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 3 10:07:28 2017 -0300

    Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues

commit 2f77044f63e1d7faef3692a8533b2c56c2b723ab
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 9 16:58:17 2017 -0300

    Bug 18242: [SOLUTION 2]Handle correctly move to old_issues

    The table old_issues has a primary key defined on the issue_id column.
    This issue_id comes from the issues table when an item is checked in.

    In some case the value of issue_id already exists in the table

    Basically this happens when an item is returned and mysqld is restarted:
    The auto increment value for issues.issue_id will be reset to
    MAX(issue_id)+1 (which is the value of the last entry of old_issues).
    See also the description of bug 18003 for more informations.

    In this solution the change is done at code level instead of DB
    structure: If old_issues.issue_id already exists before moving from
    the issues table, the issue_id is updated (not on cascade for
    accountlines.issue_id, should it?) before the move.

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
    (cherry picked from commit 7aa0808ff227850fc448b74dabed9b15ac0eb927)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 6bf6a53b86a688bead0b8b3b114c9dc509a661ae
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 9 16:41:31 2017 -0300

    Bug 18242: [SOLUTION 2]Add tests

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
    (cherry picked from commit 48b1328ebeb7ed2337ba75a582705389767b691a)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 74949be55a268f588e3eeaeafc52a87538005743
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Fri Mar 10 19:54:05 2017 +0000

    Bug 17346: Make checkin column hidable

    To test:
    1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin.
    2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin.
    3) Apply the patch.
    4) Go to both tables again and note that you can now change the settings.

    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 9098a4d3fa7268bf11ab108693192070c44c9eaf)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                       |    2 +-
 C4/Circulation.pm                    |   70 +++++++++++++++++++++-------------
 admin/columns_settings.yml           |    4 --
 t/db_dependent/Circulation/Returns.t |   28 +++++++++++++-
 tools/batch_delete_records.pl        |   21 +++++-----
 5 files changed, 82 insertions(+), 43 deletions(-)

hooks/post-receive
-- 
main Koha release repository