[koha-commits] main Koha release repository branch master updated. v16.11.00-846-gd51538c

Git repo owner gitmaster at git.koha-community.org
Fri Apr 21 13:35:45 CEST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d51538cb824387230b3e2cab955d3c16475bedde (commit)
       via  b40456f7dd4b8a988f9c6a5718452936101cb8ff (commit)
      from  ea04798a16ad8c8400030440e21825fc20b03808 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d51538cb824387230b3e2cab955d3c16475bedde
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Apr 20 12:52:47 2017 +0200

    Bug 18364: [Follow-up] Also add an environment variable to prevent locking
    
    The test in SendCirculationAlert is extended by adding an env var
    called KOHA_NO_TABLE_LOCKS. If this var is set to a true value,
    the table locking is skipped too.
    
    This is useful when running a test without prove. The variable could be
    set in a shell profile.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit b40456f7dd4b8a988f9c6a5718452936101cb8ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Mar 31 13:43:38 2017 -0300

    Bug 18364: Do not LOCK/UNLOCK tables from tests
    
    From the MySQL doc:
    "LOCK TABLES is not transaction-safe and implicitly commits any active transaction before attempting to lock the tables."
    If the LOCK/UNLOCK statements are executed from tests, the current transaction will be committed.
    To avoid that we need to guess if this code is execute from testsa or not (yes it is a bit hacky)
    
    Better ideas are welcome!
    
    Another fix would have been to revert
      commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad
      Bug 15854: Use a READ and WRITE LOCK on message_queue
    but theorically a race is still possible.
    
    Existing tests seem to be safe, to test this patch you will need new
    tests from bug 17964.
    Test plan:
      prove t/db_dependent/Letters/TemplateToolkit.t
    twice, and notice that changes have been comitted.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list