[koha-commits] main Koha release repository branch master updated. v16.11.00-850-gafb62d9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e (commit)
      from  ea2196c6527c643873fb3161d3e07d23e0202f1d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit afb62d9a6c6cbb65b5149220c5c25bc29adf2d7e
Author: pongtawat <pongtawat at punsarn.asia>
Date:   Mon Dec 26 17:50:50 2016 +0700

    Bug 17814: koha-plack --stop should make sure that Plack really stop
    
    koha-plack --stop doesn't ensure that Plack was really stopped before
    returning
    
    So in case that koha-plack --stop was quickly follows by koha-plack
    --start (e.g. logrotate), it could leave Plack in stop state. This is
    due to koha-plack --start think that Plack was already started, while it
    actually is being stopped.
    
    For me I think this is the cause why I got random Plack stop when
    logrotate is run.
    
    It should be similar to the case of Zebra in Bug #16885, and the
    solution might be the same: adding "--retry=TERM/30/KILL/5;" to
    start-stop-daemon command.
    
    TEST PLAN
    ---------
    1) Login to staff client and do something that will hold connection for
    a long time, e.g. a batch import or a slow report.
    2) sudo koha-plack --stop mykoha
    3) ps aux | grep plack   <-- a Plack process will still running work in
    1)
    4) wait for 1) to finish and all Plack processes exit
    5) sudo koha-plack --start mykoha
    6) apply the patch
    7) repeat step 1)-2)
    8) ps aux | grep plack   <-- There should be no Plack process running
    now
    9) Note that work in step 1) might get terminated midway. Since we force
    Plack to stop after some wait.
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 debian/scripts/koha-plack |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository