[koha-commits] main Koha release repository branch master updated. v16.11.00-876-g1f45548

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1f45548c91366d04a115c02c0f8d4b40c93f78fc (commit)
       via  8b528ab09d08eb2c8162d89cb511857520f20c68 (commit)
       via  7e629641070e04dfb480886dc20582974363c0e8 (commit)
      from  039bb200de2507f81cafb88dfe826e74160d2fa2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1f45548c91366d04a115c02c0f8d4b40c93f78fc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Apr 19 16:25:17 2017 +0200

    Bug 16895: [QA Follow-up] Resolve warning on $payment_type_writeoff
    
    Resolves:
      Use of uninitialized value $payment_type_writeoff in string eq at C4/SIP/Sip/MsgType.pm line 1072, <STDIN> line 2.
    Would be raised if this parameter is not found in SIPconfig.xml.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 8b528ab09d08eb2c8162d89cb511857520f20c68
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 19 09:29:13 2017 -0400

    Bug 16895 [QA Followup] - Don't require fee payment to be exact full payment
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 7e629641070e04dfb480886dc20582974363c0e8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Jul 11 13:55:50 2016 +0000

    Bug 16895 - Allow writeoffs via SIP2
    
    Many SIP2 services such as those by Comprise Technologies are able to or
    require that an ILS be able to accept writeoffs via SIP2. The SIP2
    protocol specifies that payment type be a two digit number, but does not
    specify a code for writeoffs. To this end we should allow the write-off
    code to be specified in the SIP2 config on a per-account basis so that
    if different vendors use different fixed codes for write-offs we can
    handle that gracefully.
    
    Test Plan:
    1) Apply this patch
    2) Modify your SIP2 config to include
          payment_type_writeoff="06"
      in the login portion of the account you will be using for the test.
    3) Restart your SIP2 server
    4) Create a fee for a patron
    5) Send a SIP2 fee paid message specifying the payment type code we
       defined earlier, with a payment amount that is *not* equal to the
       amount outstanding for the fee.
    6) Note the fee paid response indicates the payment failed
    7) Repeat step 5, but this time send the amount outstanding as the
       payment amount
    8) Note that the fee paid response indicates a successful payment
    9) Note in Koha that the fee has been written off!
    
    Signed-off-by: Rhonda Kuiper <kuiper at roundrocktexas.gov>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS.pm                        |    7 +++----
 C4/SIP/ILS/Transaction/FeePayment.pm |   24 ++++++++++++++++++++----
 C4/SIP/Sip/MsgType.pm                |    5 ++++-
 etc/SIPconfig.xml                    |    2 +-
 4 files changed, 28 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository