[koha-commits] main Koha release repository branch master updated. v16.11.00-904-g4eb53ee

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe (commit)
       via  8c80c9b8e127145e638963eb0eaa8fdb420ff4cd (commit)
      from  1183cfff75773c4ac2acf8fb3386f2fd7f97d4ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4eb53eeee9dbf1c4c3a4c6da48148e0a0d27f0fe
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Apr 3 21:43:48 2017 +0200

    Bug 18300: [QA Follow-up] Fix return value inconsistency
    
    As noted on bug report 17669, the return values of delete (both singular
    and plural), delete_missing and delete_temporary should be consistent.
    
    Removed the if-construction around full_path. We do not need it; in the
    very exceptional case that full_path would be empty, we should delete
    the record since the file is missing.
    
    Adjusted POD and unit tests accordingly.
    
    Test plan:
    Run t/db_dependent/Upload.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 8c80c9b8e127145e638963eb0eaa8fdb420ff4cd
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Sun Mar 19 17:25:01 2017 +0100

    Bug 18300: Delete missing upload records
    
    If you deleted files from the upload directories manually, or you rebooted
    with files in the temporary upload folder, or for some other reason have
    records without a file, you may want to cleanup your records in the
    uploaded_files table.
    
    This patch adds the method delete_missing to Koha::UploadedFiles. It also
    supports a keep_record parameter to do a dry run (count the missing files
    first).
    
    Also, we add an option --uploads-missing to cleanup_database. If you add
    the flag 1 after this option, you will delete missing files. If you add the
    flag 0 or only use the option, you will count missing files.
    
    A subtest is added to Upload.t for delete_missing tests.
    
    Test plan:
    [1] Run t/db_dependent/Upload.t
    [2] Upload a file and delete the file manually.
    [3] Run cleanup_database.pl --uploads-missing
        It should report at least one missing file now.
        Check that the record has not been deleted.
    [4] Run cleanup_database.pl --uploads-missing 1
        It should report that it removed at least one file.
        Check that the record is gone.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/UploadedFiles.pm             |   36 ++++++++++++++++++++++++++++++++++++
 misc/cronjobs/cleanup_database.pl |   17 ++++++++++++++++-
 t/db_dependent/Upload.t           |   24 ++++++++++++++++++++++--
 3 files changed, 74 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository