[koha-commits] main Koha release repository branch master updated. v16.11.00-909-g41669b4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  41669b45a808550088146380d534e4f3629590d9 (commit)
       via  c7541091741878d28f648df8681a691cf787334c (commit)
      from  330ecff1de417c40e5a48040a6f7df6436097bc4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 41669b45a808550088146380d534e4f3629590d9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 24 14:16:34 2017 -0300

    Bug 18457: Add tests
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit c7541091741878d28f648df8681a691cf787334c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Apr 19 09:52:38 2017 -0400

    Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron
    
    If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error
    Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055.
    This will cause all messages that come after the error to not be sent!
    
    Test Plan:
    1) Enable SMS via Email
    2) Enable SMS for a patron, but don't set a provider
    3) Perform an action that will trigger an sms message to go into
       the holds queue ( item due, item checkout, etc )
    4) Run process_message_queue.pl, note the error
    5) Apply the patch
    4) Run process_message_queue.pl, no error this time!
    
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm            |    4 ++++
 t/db_dependent/Letters.t |   15 ++++++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository