[koha-commits] main Koha release repository branch master updated. v16.11.00-938-g45a35f1

Fri Apr 28 14:37:30 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  45a35f1ecc7c41073c3cb3f3ea56f496dcd0171c (commit)
       via  02b3816656c779e803b7e91bdeb1aedbfdb7ac67 (commit)
       via  2e7832782966a9c4b673fb23097ffce46fa19c55 (commit)
       via  883a7d21e1c3477fa547b02b1a32936a673ddef4 (commit)
       via  262f2dd48b6fee61cbe6e04e4781833d291ea4c6 (commit)
       via  a8935fdea2c72c89e7064c123a0782d9ecb8e44e (commit)
       via  3d80ca1758c135042b0ca4d261d1198a40a35197 (commit)
       via  0492fcf87f170846d1e6c8683916a56cb67ce9a7 (commit)
      from  9a9b0aab879d1decbdeb9bac02ae198a21a46afb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 45a35f1ecc7c41073c3cb3f3ea56f496dcd0171c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 17 15:42:35 2017 -0300

    Bug 17855: Simplify the onboarding tool

    This patch should not modify a lot the behaviours of the onboarding
    tool.
    Its goal is mainly to remove duplicated as well as useless (because
    copy/pasted from existing script files) code.

    It assumes that the onboarding tool will be done on an empty database
    and will skip steps that are not needed. For instance if a library
    already exists, the first step will be skipped.

    One of the main problem was the lack of feedback messages sent to the
    user when something wrong/ok happened.

    Explanation on main changes:
    1. Use checkauth first, then get_template_and_user
    => As we do not know the template to use, it's better to use checkauth
    first to know if the user is logged in, then retrieve the template we
    need, depending on the success or the failure of the action
    2. Create a @messages variables
    Pushing messages to this variable and handling the messages via an
    include files (onboarding_messages.inc) simplify error handling. Note
    that we could remove this include file if we merge all the
    onboardingstepX.tt files altogether
    3. Simplify creation of the admnistrator user
    This patch removes some unecessary checks done on the user's info
    (passwd to short, mandatory fields

    Todo (minor): Add style to feedback messages

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 02b3816656c779e803b7e91bdeb1aedbfdb7ac67
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 17 12:18:31 2017 -0300

    Bug 17855: No need to resend the library list to the template

    This has been done at the beginning of the script

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 2e7832782966a9c4b673fb23097ffce46fa19c55
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 17 12:16:17 2017 -0300

    Bug 17855: Redirect to the installer if installation process is not done yet

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 883a7d21e1c3477fa547b02b1a32936a673ddef4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 17 12:13:45 2017 -0300

    Bug 17855: Do not create a new dbh, get it from C4::Context->dbh

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 262f2dd48b6fee61cbe6e04e4781833d291ea4c6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 17 12:05:21 2017 -0300

    Bug 17855: perltidy onboarding.pl

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a8935fdea2c72c89e7064c123a0782d9ecb8e44e
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Sun Apr 9 05:30:05 2017 +0000

    Bug 17855 - Followup patch following requests in comments 176 and 177

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 3d80ca1758c135042b0ca4d261d1198a40a35197
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Sat Mar 18 18:19:17 2017 +0000

    Bug 17855 - Reverted back to original step 3 in the web installer so there is no basic and advanced setup mode and consequently no need for SQL files to be moved to a 'default' directory for all languages.

    Onboarding tool and the rest of the web installer still exists in this
    commit

    How I tested in my VM (Current master):
    - Dropped database
    - Recreated database
    - Went through installer
    - Language en, Marc21
    - Installed mandatory data only
    - Went through Onboarding tool
    - After finishing, logged in as superlibrarian
      that was created by onboarding tool
    Everything worked fine.

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Thu Feb 9 17:32:29 2017 +0100

    Bug 17855: Onboarding tool

    Tested 3 patches together on current master
    - Dropped database
    - Recreated database
    - Went through installer
    - Language en, Marc21
    - Installed mandatory data only
    - Went through Onboarding tool
    - After finishing, logged in as superlibrarian
      that was created by onboarding tool
    Everything worked fine.

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../data/mysql/en/optional/patron_categories.sql   |    2 +-
 .../data/mysql/en/optional/patron_categories.txt   |    6 +-
 .../data/mysql/en/optional/sample_holidays.txt     |    5 +-
 .../data/mysql/en/optional/sample_libraries.txt    |    2 +-
 .../mysql/en/optional/sample_z3950_servers.txt     |    1 +
 installer/install.pl                               |  352 ++++++++++++--------
 installer/onboarding.pl                            |  329 ++++++++++++++++++
 .../intranet-tmpl/prog/en/includes/calendar.inc    |    2 +-
 .../prog/en/includes/installer-doc-head-close.inc  |   15 +
 .../prog/en/includes/onboarding_messages.inc       |   20 ++
 .../prog/en/modules/admin/categories.tt            |    2 +-
 .../prog/en/modules/installer/step3.tt             |  243 +++++++-------
 .../intranet-tmpl/prog/en/modules/intranet-main.tt |    2 -
 .../prog/en/modules/onboarding/onboardingstep1.tt  |   38 +++
 .../prog/en/modules/onboarding/onboardingstep2.tt  |  123 +++++++
 .../prog/en/modules/onboarding/onboardingstep3.tt  |  152 +++++++++
 .../prog/en/modules/onboarding/onboardingstep4.tt  |   41 +++
 .../prog/en/modules/onboarding/onboardingstep5.tt  |  114 +++++++
 xt/sample_notices.t                                |    2 +-
 19 files changed, 1171 insertions(+), 280 deletions(-)
 create mode 100755 installer/onboarding.pl
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/onboarding_messages.inc
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt

hooks/post-receive
-- 
main Koha release repository