From gitmaster at git.koha-community.org Tue Aug 1 08:00:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Aug 2017 06:00:16 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.10-20-g9793ba8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 9793ba80e7879d06d0231c787b12fd3d1f9c8ef5 (commit) via 3ddac60248fbf7d18b6fda98648192cc73d696d7 (commit) via 489794bbe9306fc2f6af59676d605624b4edd5a4 (commit) via 18d8784cf022312dc536c3d336ee4f3f1613e386 (commit) via 22422d982e7d46d52090e6189ce89856c493b8da (commit) via e1f0fa8eac9135f6b303b1404c741f1bc8302811 (commit) via d3d68c2a0fa272d5a4e9ba144b4d93730a2ad691 (commit) via 1fdcd9769f75b3c6b9148addfdf96e814f703f24 (commit) via 9aa31608ab00841dd62933df27e50a62c07e177e (commit) via 07014d47d09827f9b2b54798fe57a1cc2197a5cd (commit) via be80afb95b9e698bd127caed3605b17cccd4b744 (commit) via 1abd587592b89376796b012756fce81cd1f8c48f (commit) via 653be0d9271fb332cb4a50ffee0b9bc4661d928b (commit) via 7c9dfb157181d43d7c67f7a2ce0b8c4496e120ae (commit) via cbbb54fd9aee64f89cc25bb9a88ded21a49c8f13 (commit) via 87db7d92ac777c5d9c369efebfd9e6c6d6ae07de (commit) via 656081fb33ed58a9e7188fa7c3a83d43e32f506a (commit) via a7817b76bcab48ee2aee14159b7813c81d7e95e1 (commit) via cf82a24b96bee57d3cf19e3c1fd55673b3a6ebee (commit) via 6afabe33596f3558c115ec4254c41a3931509b7c (commit) from 0d345348ed7d024427cbd8d6bb81107cba81da9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9793ba80e7879d06d0231c787b12fd3d1f9c8ef5 Author: Nick Clemens Date: Fri Jul 28 11:38:33 2017 +0000 Bug 18367 - (QA Followup) Only warn if doing a lookup and not having an item Signed-off-by: Jonathan Druart (cherry picked from commit 1b73cae6eb4ce7e7ca675d6db84fe8ce0cd2f499) Signed-off-by: Fridolin Somers (cherry picked from commit 1da77ea584bcc2a2878106b6bc174b21bb0837ff) Signed-off-by: Katrin Fischer commit 3ddac60248fbf7d18b6fda98648192cc73d696d7 Author: Nick Clemens Date: Tue Apr 11 16:09:27 2017 -0400 Bug 18367 - Fix untranslatable string from Bug 18264 Restore display of message when no barcode found To test: 1 - Go to course reserves 2 - Add an item to a course 3 - Try adding an invalid barcode - should get an alert 4 - Try force adding an item with itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546 5 - Should recieve an error Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart (cherry picked from commit 1fc3751804146e92c0d8d85517ffcd6ec338808e) Signed-off-by: Fridolin Somers (cherry picked from commit 456e849ec29e9a5b1499ea8e492dc157b381f8d5) Signed-off-by: Katrin Fischer commit 489794bbe9306fc2f6af59676d605624b4edd5a4 Author: Marcel de Rooy Date: Fri Jul 28 11:58:24 2017 +0200 Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback We also need just one rollback at the end here. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit e5e5402f36c923775b341bd1900aa6468d42aa9a) Signed-off-by: Fridolin Somers (cherry picked from commit 9908a18e927c8b6f1d8c8959d070605f0680afa1) Signed-off-by: Katrin Fischer commit 18d8784cf022312dc536c3d336ee4f3f1613e386 Author: Lari Taskula Date: Thu Jul 27 14:56:18 2017 +0000 Bug 18991: Fix cleanup in t/db_dependent/Log.t There is an action_logs entry via logaction() without transaction to be rolled back in t/db_dependent/Log.t. This leaves an entry in action_logs after the test is over. To replicate: 1. prove t/db_dependent/Log.t 2. Observe a new entry in action_logs table To test: 1. Apply patch 2. prove t/db_dependent/Log.t 3. Observe there are no new entries in action_logs Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit f49f5a67d3512ea75d92cb551ebd79a9de7e53d7) Signed-off-by: Fridolin Somers (cherry picked from commit 2af6365fc66a0dcb6246d90432c3998bac8bf43f) Signed-off-by: Katrin Fischer commit 22422d982e7d46d52090e6189ce89856c493b8da Author: Marcel de Rooy Date: Fri Jul 28 07:56:21 2017 +0200 Bug 19000: Fix typo in closing p tag for items Close the p tag and add a br tag to visually divide the two sections Data problems and Warnings regarding system configuration. Signed-off-by: Marcel de Rooy Discovered the problem when testing a duplicate key in deleteditems. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 3c87b6f387831053e01ecc86b91d61669af9696b) Signed-off-by: Fridolin Somers (cherry picked from commit 37097ee7f6f462193eefd4d51d4142b6ce59a8a9) Signed-off-by: Katrin Fischer commit e1f0fa8eac9135f6b303b1404c741f1bc8302811 Author: Jonathan Druart Date: Mon Jul 24 14:25:21 2017 -0300 Bug 18545: Re-add call to enableCheckboxActions This call is used to refresh the page correctly Signed-off-by: Jonathan Druart (cherry picked from commit 37fc0d817d46d21897015a8e1df754b59ba477a6) Signed-off-by: Fridolin Somers (cherry picked from commit 2586f7f8462a28dc7f3078576ac2b9faa40e426c) Signed-off-by: Katrin Fischer commit d3d68c2a0fa272d5a4e9ba144b4d93730a2ad691 Author: Owen Leonard Date: Fri Jun 9 15:50:41 2017 +0000 Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart This patch makes a few corrections: - Use 'e.preventDefault()' instead of 'return false' in changed sections. - Modify the event handler on checkboxes to successfully handle the un-check action as well as the check action. (QA comment 5). To test, follow the original test plan. Signed-off-by: Aleisha Amohia Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 04a601ef659c64446790758ebbe369a2ce090875) Signed-off-by: Fridolin Somers (cherry picked from commit 970442bc39583a0491120fa60816ec4d819a7653) Signed-off-by: Katrin Fischer commit 1fdcd9769f75b3c6b9148addfdf96e814f703f24 Author: Aleisha Amohia Date: Fri May 5 03:58:49 2017 +0000 Bug 18545: Remove use of onclick from OPAC cart To test: 1) Apply patch and add one or more items to your cart 2) Confirm that clicking the following things still works as expected: - more details - brief display - send - download - print - select all - clear all - selecting by clicking checkbox - remove title - add title to list - place hold - add tag - empty and close Sponsored-by: Catalyst IT Followed test plan, works as expected. Resolves issue with two print dialogues from Bug 18544. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 1b4d4f989b1d6c589a08f21ce19a48dca9072ec7) Signed-off-by: Fridolin Somers (cherry picked from commit 38597cee18757669e450b8ce2d0941ee7a97173b) Signed-off-by: Katrin Fischer commit 9aa31608ab00841dd62933df27e50a62c07e177e Author: Marcel de Rooy Date: Mon May 15 10:38:43 2017 +0200 Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't need to do that here. (Would complicate testing it too.) Fixes typo disablig. Add a simple test to HoldsQueue.t. Test plan: Run t/db_dependent/HoldsQueue.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit db64c94953be772fb316d508fdfffd374ea1d835) Signed-off-by: Fridolin Somers (cherry picked from commit bede0cc328f6acff69489fe3139d64c35eb7b589) Signed-off-by: Katrin Fischer commit 07014d47d09827f9b2b54798fe57a1cc2197a5cd Author: Fridolin Somers Date: Thu Jul 20 16:08:59 2017 +0200 Bug 18965 - branch transfer limits pagination save bug In branch transfer limits, tables are paginated with 20 rows by default. The bug is that datatable not only hides rows, they are not in form. So when submitting form, rows not visible are erased. Test plan : Wihout patch : - Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx - Go to Administration > Library transfer limits - You see table first page : only 20 first rows are shown - You see all checkboxes are checked - Go to second page of this table - Save => You see table first page with all checkboxes unchecked With patch the is no pagination, all checkboxes are shown when you save Signed-off-by: Axelle Clarisse Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7a306d72ab98f2abf2266716761820f1098ede9b) Signed-off-by: Fridolin Somers (cherry picked from commit ca7f2f5aa48d8d5136029d10d8c15ffacf010103) Signed-off-by: Katrin Fischer commit be80afb95b9e698bd127caed3605b17cccd4b744 Author: Lari Taskula Date: Mon Jul 24 18:30:10 2017 +0300 Bug 18977: Rollback branch in t/db_dependent/SIP/Message.t To test: 1. Before applying patch, check the amount of branches in database 2. prove t/db_dependent/SIP/Message.t 3. See that a new branch is stored 4. Apply patch 5. prove t/db_dependent/SIP/Message.t 6. See that a new branch is no longer stored Signed-off-by: Jonathan Druart (cherry picked from commit 139b66f65611cff0a2551662e0fd5c2e50b4c10f) Signed-off-by: Fridolin Somers (cherry picked from commit 5b71a4150571b0d9013341b6f64e41f12a7f1f29) Signed-off-by: Katrin Fischer commit 1abd587592b89376796b012756fce81cd1f8c48f Author: Marc V?ron Date: Wed Jun 21 09:47:13 2017 +0200 Bug 18832: Missing space between icon and label in button 'Patron lists' On page Home > Patrons the button 'Patron lists' misses a space between icon and text. This patch adds it to make the button display like the other ones. To test, apply patch and verify that the button displays as expected. Signed-off-by: fcouffignal Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 85b895c2dfdf9499fdb12bd108c740144597c89e) Signed-off-by: Fridolin Somers (cherry picked from commit 7a9bd6247b2bb079837f170179e12d731222fb65) Signed-off-by: Katrin Fischer commit 653be0d9271fb332cb4a50ffee0b9bc4661d928b Author: Chris Kirby Date: Wed Jun 21 18:27:21 2017 +0000 Bug 18839: Suggestion.pl spelling mistake On the suggestion management page, 'unknown' is spelled 'unkown' This patch corrects this spelling mistake in suggestion/suggestion.pl koha-tmpl/intranet-tmpl/prog/en/include/strings.inc koha-tmpl/intranet-tmpl/prog/en/include/search_indexes.inc Signed-off-by: Lee Jamison Signed-off-by: sonia BOUIS Signed-off-by: Jonathan Druart (cherry picked from commit afddf4145fbbfd978e4c5cd22f0ae2cbbef70560) Signed-off-by: Fridolin Somers (cherry picked from commit 831abee885ece915355426c8c13e756754d3e942) Signed-off-by: Katrin Fischer commit 7c9dfb157181d43d7c67f7a2ce0b8c4496e120ae Author: Aleisha Amohia Date: Mon Jul 10 02:31:22 2017 +0000 Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart (cherry picked from commit 7723ffdd130996ec946d5b9149f90cb0cdc447fc) Signed-off-by: Fridolin Somers (cherry picked from commit ae341f962c0f57dd59d9807417cbd571e3f2e5b5) Signed-off-by: Katrin Fischer commit cbbb54fd9aee64f89cc25bb9a88ded21a49c8f13 Author: Jonathan Druart Date: Wed Jul 26 13:50:14 2017 -0300 Bug 18982: Remove data in the correct order To respect FK Signed-off-by: Jonathan Druart (cherry picked from commit 6cb3abcbd95fe673d5b0426f5f8c23a0c7683e65) Signed-off-by: Fridolin Somers (cherry picked from commit 806357a8fc8b124e42ca877a209493d523dbd52e) Signed-off-by: Katrin Fischer commit 87db7d92ac777c5d9c369efebfd9e6c6d6ae07de Author: Jonathan Druart Date: Tue Jul 25 16:49:38 2017 -0300 Bug 18982: Create a circ rule for the data we created No need to have a default circ cule, we create one for the categorycode and itemtype we are going to use. The 3 checkouts will not be rejected (5 are allowed) Signed-off-by: Jonathan Druart (cherry picked from commit 5b84987f28b43f0c92eeff9ed1067ed61f822a4b) Signed-off-by: Fridolin Somers (cherry picked from commit 0f654af1816bffc4bada443ac0b5fa1784e5a8e9) Signed-off-by: Katrin Fischer commit 656081fb33ed58a9e7188fa7c3a83d43e32f506a Author: Jonathan Druart Date: Tue Jul 25 16:48:06 2017 -0300 Bug 18982: Create a specific itemtype for these tests No need to require rentalcharge=0 for all itemtypes, we create our own. Signed-off-by: Jonathan Druart (cherry picked from commit ca0568f58393cff3fce6b362e59e90daa1b1524a) Signed-off-by: Fridolin Somers (cherry picked from commit b1664900f37ae110c629bea2c4f6307dba839dc9) Signed-off-by: Katrin Fischer commit a7817b76bcab48ee2aee14159b7813c81d7e95e1 Author: Jonathan Druart Date: Tue Jul 25 16:46:08 2017 -0300 Bug 18982: category.categorycode must be uppercase Otherwise it is not selected in the dropdown list and the patron created does not belong to this category Signed-off-by: Jonathan Druart (cherry picked from commit 60478e6544ddfd37dc82829f684c3837b534d146) Signed-off-by: Fridolin Somers (cherry picked from commit 6eff76990977366704facaa26da07c250f181296) Signed-off-by: Katrin Fischer commit cf82a24b96bee57d3cf19e3c1fd55673b3a6ebee Author: Jonathan Druart Date: Tue Jul 25 14:37:27 2017 -0300 Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL That way we do not need to set the syspref, we can define it setting an env var, like other tests. Signed-off-by: Jonathan Druart (cherry picked from commit 78d77163af407dc639764cdf1b8936b8f0f715d6) Signed-off-by: Fridolin Somers (cherry picked from commit 0ec81e6248627ecbcdfc6fe1200b8e2333ec89a3) Signed-off-by: Katrin Fischer commit 6afabe33596f3558c115ec4254c41a3931509b7c Author: Marc V?ron Date: Sun May 21 18:28:48 2017 +0200 Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same mail address To reproduce: - Create 3 Accounts, login names are test01, test02, test03, Email is the same for all. - Go to OPAC -> Password recovery and indicate E-Mail only - You will get an email for only one of the accounts above. To test: - Apply patch, restart memcached and plack - Go to db, delete from borrower_password_recovery; - Try steps above to reproduce. You will get an error message: Account identification with this email address only is ambiguous. Please use the field 'Login' as well. - Verify that other cases work as before (provide valid / invalid login only, provide valid email for an existing account, provide unknown email, provide both login and email with all combinations of valid / invalid) Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Bug 16711: (QA-followup) Use count directly See comment # 13 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 3829020c2664ec531354f78f0c04d00f5dd6795d) Signed-off-by: Fridolin Somers (cherry picked from commit 739a0f4b9b6bfba236d297608001180f4cb38af3) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/HoldsQueue.pm | 4 +- course_reserves/add_items.pl | 8 +- .../prog/en/includes/patron-toolbar.inc | 2 +- .../prog/en/includes/search_indexes.inc | 2 +- .../intranet-tmpl/prog/en/includes/strings.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +- .../en/modules/admin/branch_transfer_limits.tt | 2 +- .../en/modules/course_reserves/add_items-step1.tt | 9 +- .../intranet-tmpl/prog/en/modules/tools/export.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 92 ++++++++++++++++---- .../bootstrap/en/modules/opac-password-recovery.tt | 5 +- opac/opac-password-recovery.pl | 21 +++-- suggestion/suggestion.pl | 4 +- t/db_dependent/HoldsQueue.t | 12 ++- t/db_dependent/Log.t | 18 ++-- t/db_dependent/SIP/Message.t | 6 +- t/db_dependent/selenium/basic_workflow.t | 47 ++++++---- 17 files changed, 176 insertions(+), 67 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Aug 3 09:50:58 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Aug 2017 07:50:58 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.02-28-g9f0b5cd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 9f0b5cd73cbaefdb4f46cae6f5e7f7f07607a51f (commit) via c4eb6e260b5bdd9c9ab48caa370de10bf68b40ea (commit) via 5a137e3c6c176ee4a04802049e205aa09807370c (commit) via 90ef2aedffedf15bdacb1d6ddbbe81bff72036ac (commit) via 6e26bd0567c29b990eb8c786c2dc530afdd8b598 (commit) via 5a2604144f114d242d7e4860603fd4811937f44c (commit) from 1da77ea584bcc2a2878106b6bc174b21bb0837ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9f0b5cd73cbaefdb4f46cae6f5e7f7f07607a51f Author: Marcel de Rooy Date: Fri Jun 16 07:57:14 2017 +0200 Bug 18361: [QA Follow-up] Resolve warning on undef values supplied The following warning was raised in Letters.t: DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): NULL/undef values supplied for requested unique constraint 'primary' (NULL values in column(s): 'id'). This is almost certainly not what you wanted, though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning. This warning is triggered by this line in C4/Letters.pm: Koha::SMS::Providers->find( $member->{'sms_provider_id'} ); As you already guessed, the sms_provider_id returns undef. Resolved in sub find by testing if there are parameters and if so, they should not be all undefined. (In most cases there will be only one parameter; but this report is about composite keys.) Added a trivial test case in Objects.t too. Test plan: Run t/db_dependent/Koha/Object.t Run t/db_dependent/Koha/Objects.t Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy (cherry picked from commit e1afa469f8313144c70ae91d7efa356beb8168b8) Signed-off-by: Fridolin Somers commit c4eb6e260b5bdd9c9ab48caa370de10bf68b40ea Author: Tomas Cohen Arazi Date: Wed Apr 19 11:57:33 2017 -0300 Bug 18361: (QA followup) Add tests for the no params case This patch adds a test for the trivial case in which no param is passed and the ->find method returns undef. For completeness purposes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit e1f943b9992ea1a3c5d4659ca6fa787834d66376) Signed-off-by: Fridolin Somers commit 5a137e3c6c176ee4a04802049e205aa09807370c Author: Marcel de Rooy Date: Thu Apr 13 13:15:30 2017 +0200 Bug 18361: Additional tests for Koha::Objects->find Adding a subtest find in t/db_dependent/Koha/Objects.t. Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit de74a4e5a0ec0fcf85a42b637d07c2bcd81d63f0) Signed-off-by: Fridolin Somers commit 90ef2aedffedf15bdacb1d6ddbbe81bff72036ac Author: Marcel de Rooy Date: Fri Mar 31 13:52:15 2017 +0200 Bug 18361: Koha::Objects->find should accept composite primary keys Changes the $id parameter to an array. (IssuingRule has three keys.) The build_object method in TestBuilder.pm has been adjusted to pass multiple primary key values to find. Also adjusted the POD section to show more clearly that we accept the same parameters as DBIx ResultSet does. Test plan: Run t/db_dependent/Koha/Object.t Run t/db_dependent/Koha/Objects.t Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit ec288a50def5c4fdcd7b001087fed0b120e4a211) Signed-off-by: Fridolin Somers commit 6e26bd0567c29b990eb8c786c2dc530afdd8b598 Author: Jonathan Druart Date: Thu Jun 15 15:46:17 2017 -0300 Bug 18539: remove occurrence in ReNewSubscription.t Signed-off-by: Jonathan Druart (cherry picked from commit ad7ff09b995e5275f2c6d664b31351321b1674af) Signed-off-by: Fridolin Somers commit 5a2604144f114d242d7e4860603fd4811937f44c Author: Jonathan Druart Date: Tue Apr 18 13:49:18 2017 -0300 Bug 18539: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 15cbf14f4d4f8039ad7820ce37da202b19e0075d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 19 ++++++++--- t/db_dependent/Koha/Objects.t | 47 +++++++++++++++++++++++++++- t/db_dependent/Serials/ReNewSubscription.t | 4 +-- t/lib/TestBuilder.pm | 2 +- 4 files changed, 63 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Aug 3 09:53:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Aug 2017 07:53:00 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.02-31-gce8ddbf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via ce8ddbf8ea7d463a822a70f474310b8b618d6347 (commit) via 36c3bbedfe80a1a55f34aedb6931784da1043c84 (commit) via 216b13e51fbdaa0ede2eb3218338f955c6c2aa48 (commit) from 9f0b5cd73cbaefdb4f46cae6f5e7f7f07607a51f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce8ddbf8ea7d463a822a70f474310b8b618d6347 Author: Marcel de Rooy Date: Wed Jul 19 13:59:45 2017 +0200 Bug 18951: Adjust Isbd.t Add schema calls. Remove an unneeded AddBiblio call. Test plan: Run t/db_dependent/Biblio/Isbd.t Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 40c719a5248877d200920c2c9a028e273a5f1370) Signed-off-by: Fridolin Somers commit 36c3bbedfe80a1a55f34aedb6931784da1043c84 Author: Marcel de Rooy Date: Wed Jul 19 13:48:55 2017 +0200 Bug 18951: Create data for TransformKohaToMarc.t Adding schema and caching statements. Adjust it so that the Koha to MARC mappings are not assumed to be present, but are created as needed. Remove the mock on marcflavour. It is no longer needed. Resolving a small typo. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit f839955db707415368d23ae81bdb14505dd058ee) Signed-off-by: Fridolin Somers commit 216b13e51fbdaa0ede2eb3218338f955c6c2aa48 Author: Marcel de Rooy Date: Wed Jul 19 13:33:34 2017 +0200 Bug 18951: Some t/Biblio tests are database dependent (git mv) Move Isbd.t and TransformKohaToMarc.t to db_dependent. Next patch will add a few adjustments too. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 50bc4170cec172de04db2033d464c96348d5a508) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: t/Biblio/TransformKohaToMarc.t | 31 -------------------- t/{ => db_dependent}/Biblio/Isbd.t | 11 +++---- t/db_dependent/Biblio/TransformKohaToMarc.t | 42 +++++++++++++++++++++++++++ 3 files changed, 48 insertions(+), 36 deletions(-) delete mode 100644 t/Biblio/TransformKohaToMarc.t rename t/{ => db_dependent}/Biblio/Isbd.t (90%) create mode 100644 t/db_dependent/Biblio/TransformKohaToMarc.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Aug 8 14:47:46 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 08 Aug 2017 12:47:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-323-g5bb56bf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5bb56bf336187cde38e1a3b89c792ee6dc231acf (commit) via 0853c4e2b4366a235077a24a873fc81a754afecb (commit) via ec9b691de934f82c50057c15fb7d3a1b32717b72 (commit) via 24b4006ecbc0a258b09500bdd8f639c7018067c0 (commit) via 9512b015662f8ec56d8b8884b4e4bb14d5e563f1 (commit) via 4bbec5c382590f881e6d2af62b2608fe9cf9e051 (commit) via ae5f5c479929cbfad3193c6ce9471a406a2a41f3 (commit) via 0bcf6a79427297c332588317dde749e923c7bbdc (commit) via b7d291a1ee692d6de71503683a3e61c9311c33d8 (commit) via b94eb77d1ba2f407f79c12c3fff44312ea964d77 (commit) via 1917e0c89fc275bf402b79ddad924b51731f47bf (commit) via c1185533c61e8266f9d89136e8e0debddf71d497 (commit) via 972281c77d1315dde2a988510a8c4102de16d7d2 (commit) via 31f5c43d54a2bb6d61402889cb6dcff630683015 (commit) via f79beb52708ed211f4ef6386ed358b21ed511efb (commit) via 64a0aa541ed96b45bdc5525f35bf7dfea9c25104 (commit) via fbfb6dca269acdc417e51e84e0c0b88e57f095ba (commit) from 1b73cae6eb4ce7e7ca675d6db84fe8ce0cd2f499 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bb56bf336187cde38e1a3b89c792ee6dc231acf Author: Marcel de Rooy Date: Sat Jul 29 17:06:52 2017 +0200 Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 0853c4e2b4366a235077a24a873fc81a754afecb Author: Jonathan Druart Date: Tue Aug 1 11:44:29 2017 -0300 Bug 17699: Reset time simulation Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ec9b691de934f82c50057c15fb7d3a1b32717b72 Author: Jonathan Druart Date: Mon Jul 31 11:30:00 2017 -0300 Bug 17699: Add test descriptions Test plan: prove -v t/db_dependent/Koha/Patrons.t Subtest: renew_account 1..30 ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 4 - today + 12 months must be 2017-03-31T00:00:00 ok 5 - today + 12 months must be 2017-03-31T00:00:00 ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 7 - today + 12 months must be 2017-03-31T00:00:00 ok 8 - today + 12 months must be 2017-03-31T00:00:00 ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 14 - today + 12 months must be 2017-11-30T00:00:00 ok 15 - today + 12 months must be 2017-11-30T00:00:00 ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 17 - today + 12 months must be 2017-11-30T00:00:00 ok 18 - today + 12 months must be 2017-11-30T00:00:00 ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 24 - today + 12 months must be 2018-07-31T00:00:00 ok 25 - today + 12 months must be 2018-07-31T00:00:00 ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 27 - today + 12 months must be 2018-07-31T00:00:00 ok 28 - today + 12 months must be 2018-07-31T00:00:00 ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 24b4006ecbc0a258b09500bdd8f639c7018067c0 Author: Jonathan Druart Date: Mon Jul 31 11:03:37 2017 -0300 Bug 17699: Use limit as end_of_month From DateTime::Duration pod: "" For positive durations, the "end_of_month" parameter defaults to wrap. For negative durations, the default is "limit". This should match how most people "intuitively" expect datetime math to work. """" We need end_of_month => limit for positive durations as well. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 9512b015662f8ec56d8b8884b4e4bb14d5e563f1 Author: Jonathan Druart Date: Mon Jul 31 11:02:42 2017 -0300 Bug 17699: Add more tests to highlight the problem Add problematic cases to highlight the problem. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 4bbec5c382590f881e6d2af62b2608fe9cf9e051 Author: Jonathan Druart Date: Mon Jul 31 11:18:23 2017 -0300 Bug 19009: Fix random failures from Circulation.t From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ae5f5c479929cbfad3193c6ce9471a406a2a41f3 Author: Jonathan Druart Date: Wed Jun 14 11:32:30 2017 -0300 Bug 18802: Fix Circulation.t if finesMode ne 'production' If finesMode is not set to production, only 1 fine will be created (the renewal one will not). This is what assumes the tests. If set to 'production', the tests will fail because the fines will not be deleted (because of the DBIx::Class) warning. Now we mock the value before charging. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. Test plan: prove t/db_dependent/Circulation.t should return green whatever the value of finesMode Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0bcf6a79427297c332588317dde749e923c7bbdc Author: Tomas Cohen Arazi Date: Mon Aug 7 11:04:51 2017 -0300 Bug 19013: (QA followup) Set guarantorid to NULL patron sample data Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b7d291a1ee692d6de71503683a3e61c9311c33d8 Author: Jonathan Druart Date: Mon Jul 31 16:12:16 2017 -0300 Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql That breaks randomly tests on Jenkins (Koha/Patrons.t) It certainly affects data in other languages but I did not find a quick and easy way to modify this file (replace all guarantorid values with NULL) Signed-off-by: Tomas Cohen Arazi Easy fix Signed-off-by: Jonathan Druart commit b94eb77d1ba2f407f79c12c3fff44312ea964d77 Author: Tomas Cohen Arazi Date: Mon Aug 7 12:33:50 2017 -0300 Bug 18851: (QA followup) Test doesn't need sessions on DB As the DB structure is not initialized for sessions, running this tests raise an irrelevant warning. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1917e0c89fc275bf402b79ddad924b51731f47bf Author: Jonathan Druart Date: Mon Jul 10 16:11:44 2017 -0300 Bug 18851: Fix few other tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c1185533c61e8266f9d89136e8e0debddf71d497 Author: Jonathan Druart Date: Mon Jul 24 12:44:30 2017 -0300 Bug 18851: Make OverDrive.T pass if dbms is not running Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 972281c77d1315dde2a988510a8c4102de16d7d2 Author: Jonathan Druart Date: Wed Jul 5 17:38:41 2017 -0300 Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 31f5c43d54a2bb6d61402889cb6dcff630683015 Author: Jonathan Druart Date: Wed Jul 5 17:38:22 2017 -0300 Bug 18851: Test::DBIx::Class is not needed in 00-load.t Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit f79beb52708ed211f4ef6386ed358b21ed511efb Author: Jonathan Druart Date: Wed Jul 5 17:37:41 2017 -0300 Bug 18851: Database handler must not be created at runtime Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 64a0aa541ed96b45bdc5525f35bf7dfea9c25104 Author: Jonathan Druart Date: Mon Aug 7 09:54:27 2017 -0300 Bug 19048: (bug 17829 follow-up) Fix regression in self checkout $patronid is not necessarily set or does not match a valid cardnumber. These cases must be taken into account to avoid the script to crash and raise the following error: Can't call method "unblessed" on an undefined value at (...)/koha/opac/sco/sco-main.pl line 117 Test plan: Hit sco/sco-main.pl and confirm that the error is gone with this patch applied Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit fbfb6dca269acdc417e51e84e0c0b88e57f095ba Author: Jonathan Druart Date: Mon Aug 7 10:01:40 2017 -0300 Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058 From commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7 Bug 17855: Onboarding tool +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -1,5 +1,3 @@ -[% USE Koha %] -[% SET footerjs = 1 %] +[% USE Koha %] has been re-added by commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e Bug 18673: News author does not display on staff client home page But not the footerjs = 1 Test plan: From the main page of the staff interface, delete a news item Without this patch applied you will not get a JS confirmation message Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Trivial fix. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/Patron/Category.pm | 2 +- Koha/Patron/Discharge.pm | 7 +- .../data/mysql/de-DE/optional/sample_patrons.sql | 24 ++-- .../data/mysql/en/optional/sample_patrons.sql | 24 ++-- .../data/mysql/es-ES/optional/sample_patrons.sql | 24 ++-- .../mysql/nb-NO/2-Valgfritt/sample_patrons.sql | 24 ++-- .../data/mysql/pl-PL/optional/sample_patrons.sql | 24 ++-- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 1 + opac/sco/sco-main.pl | 13 +- t/00-load.t | 3 - t/Koha_ExternalContent_OverDrive.t | 24 +++- t/Members/cardnumber.t | 15 +- t/Patron.t | 14 +- t/Search.t | 12 +- t/SuggestionEngine_AuthorityFile.t | 14 +- t/XSLT.t | 2 + t/db_dependent/Circulation.t | 32 +++-- t/db_dependent/Koha/Patrons.t | 149 ++++++++++---------- t/lib/TestBuilder.pm | 3 + 19 files changed, 247 insertions(+), 164 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Aug 9 21:56:43 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 Aug 2017 19:56:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-327-g1da4721 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1da47215516206d51545e5bc662a34e335127ff6 (commit) via 95f1844e6c46ff51de9f95f99fcdf3369c756fd4 (commit) via 2fdfbaf0ddbf214c0efb9a3a3c2595a54517f795 (commit) via 19a7b498e1f4355ab1e4ee0adb5db299613f3f5c (commit) from 5bb56bf336187cde38e1a3b89c792ee6dc231acf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1da47215516206d51545e5bc662a34e335127ff6 Author: Jonathan Druart Date: Wed Aug 9 16:52:21 2017 -0300 Bug 17829: (follow-up) Move GetMember to Koha::Patron - routing-lists.pl Signed-off-by: Jonathan Druart commit 95f1844e6c46ff51de9f95f99fcdf3369c756fd4 Author: Fridolin Somers Date: Wed Aug 2 11:21:58 2017 +0200 Bug 19023 - inventory tool performance Inventory tool performance seems to be worst since 16.11. I think it is because of authorized values computing changed by Bug 17249. For each subfield of each item, we try to get the authorized value description with Koha::AuthorisedValues->search_by_marc_field. But this method does not use cache like Koha::AuthorisedValues->get_description_by_koha_field. I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also to look for authorized value description only for item fields used in TT : location, notforloan, itemlost, damaged, withdrawn. I have experimented inventory time on 100 items from 5s to 1s. Test plan : - Without patch - Perform inventory with barcode file - Check results and mesure execution time - Apply patch - Reperform inventory with same barcode file - Check results is the same - Compare execution time - Run prove t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 2fdfbaf0ddbf214c0efb9a3a3c2595a54517f795 Author: David Cook Date: Thu Jul 27 11:58:28 2017 +1000 Bug 18898 - Some permissions for Reports can be bypassed If you manually visit the following links when you only have permission to run reports, you'll still be able to access the ability to create and edit reports: /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Edit%20SQL This patch ties these 2 unaccounted for phases to the create_reports permission. With patch, issue no longer can be reproduced. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 19a7b498e1f4355ab1e4ee0adb5db299613f3f5c Author: Jonathan Druart Date: Thu Jul 6 18:10:10 2017 -0300 Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: admin/aqbudgets.pl | 3 ++- members/routing-lists.pl | 2 +- reports/guided_reports.pl | 2 +- tools/inventory.pl | 24 +++++++++--------------- 4 files changed, 13 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Aug 10 18:55:45 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Aug 2017 16:55:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-339-ge359035 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e35903574ce666bca32eb4676f311b99bb268ec2 (commit) via 61f2ec769073709be3b688654ec355b3f4fbe522 (commit) via 91dee226cdd089353dc71e559aa9e0b34fddf72e (commit) via 04966a6203646cae79a48a00ef0873c1f6c64b06 (commit) via ee6f8e186bc93df9d7943ea38f05615b2e8a813f (commit) via 4a302b17afee055c5d123d78328d50bdc7531259 (commit) via efc4caec968dd0394c6d1ee8a2c4be66cc697afb (commit) via 93366e10fbe2b018caa9d6b388b74cc3ef302a86 (commit) via 3e5cad0f03d5d90eff2d6cedfb4ff6014c0610c0 (commit) via ffe659e92ac023d59ebe6dca40a79056d15fae87 (commit) via 19eb17c7894c4d2d53ecfc1ad4e417aa86ab9410 (commit) via e57b3a6c4d9bb6319f038909832281dd4a9e39e5 (commit) from 1da47215516206d51545e5bc662a34e335127ff6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e35903574ce666bca32eb4676f311b99bb268ec2 Author: Fridolin Somers Date: Thu Jul 6 08:48:18 2017 +0200 Bug 18900: wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 61f2ec769073709be3b688654ec355b3f4fbe522 Author: Tomas Cohen Arazi Date: Wed Aug 9 12:01:17 2017 -0300 Bug 18900: (QA followup) Make tests conditional to locale existence It is important to highlight that tests have been skipped instead of having them pass on the absence of the required fr_FR.UTF-8 locale installed on the system. This patch does that check and effectively skips them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 91dee226cdd089353dc71e559aa9e0b34fddf72e Author: Fridolin Somers Date: Thu Jul 6 08:44:51 2017 +0200 Bug 18900: add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 04966a6203646cae79a48a00ef0873c1f6c64b06 Author: Jonathan Druart Date: Thu Aug 10 13:15:27 2017 -0300 Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit ee6f8e186bc93df9d7943ea38f05615b2e8a813f Author: Owen Leonard Date: Fri Jun 9 12:29:58 2017 +0000 Bug 5471 - Quotes in tags fail This patch makes changes to the tag moderation template and JavaScript to fix handling of tags with double or single quotes. This patch also moves the tags moderation JavaScript out of the template and into a separate JS file. To test you should have multiple tags awaiting moderation, including tags which contain double and single quotes. - Go to Tools -> Tags. - In the list of tags pending approval, test approving and rejecting tags, including those containing single or double quotes. - The state of the "Approve" or "Reject" buttons should correctly change according to the action you chose. - The label in the status column should update correctly. - In the "Check lists" form, submitting approved, rejected, and unclassified terms should result in the correct message. Signed-off-by: Lee Jamison Works correctly based on test plan. Tested using single- and double-quoted tags. Passes QA Tools. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 4a302b17afee055c5d123d78328d50bdc7531259 Author: Marcel de Rooy Date: Thu Jun 22 10:14:29 2017 +0200 Bug 18980: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit efc4caec968dd0394c6d1ee8a2c4be66cc697afb Author: Marcel de Rooy Date: Wed Jun 21 16:53:56 2017 +0200 Bug 18980: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 93366e10fbe2b018caa9d6b388b74cc3ef302a86 Author: Marcel de Rooy Date: Wed Jun 21 16:24:57 2017 +0200 Bug 18980: Add js to dynamically show/hide the Anyone remark If we we move from Private to Public or vice versa, this should reflect on the Anyone remark from the first patch. If we go back to a private list without shares, we should show it. Handled in a js sub AdjustRemark, triggered by onchange of the category combo or the permission combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category and/or permissions. Is the remark shown or hidden accordingly? Note: Include a test with OpacAllowPublicListCreation enabled. [2] Edit a shared list or public list in staff. Toggle category/permissions. You should never see the remark. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 3e5cad0f03d5d90eff2d6cedfb4ff6014c0610c0 Author: Marcel de Rooy Date: Wed Jun 21 13:13:17 2017 +0200 Bug 18980: Add remark next to "Anyone seeing this list" permission This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit ffe659e92ac023d59ebe6dca40a79056d15fae87 Author: Liz Rea Date: Tue Jun 27 11:42:44 2017 +1200 Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 19eb17c7894c4d2d53ecfc1ad4e417aa86ab9410 Author: Jonathan Druart Date: Wed Aug 9 12:59:20 2017 -0300 Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit e57b3a6c4d9bb6319f038909832281dd4a9e39e5 Author: Tomas Cohen Arazi Date: Wed Aug 9 12:27:00 2017 -0300 Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/VirtualShelves.pm | 1 + Koha/Number/Price.pm | 3 + Makefile.PL | 1 + .../prog/en/modules/admin/smart-rules.tt | 17 +- .../intranet-tmpl/prog/en/modules/tags/review.tt | 216 ++++---------------- .../prog/en/modules/virtualshelves/shelves.tt | 59 +++++- .../virtualshelves/tables/shelves_results.tt | 2 + .../intranet-tmpl/prog/js/pages/tags-review.js | 162 +++++++++++++++ .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 59 ++++-- .../opac-article-request-cancel.pl => t/Makefile.t | 49 +++-- t/Number/Price.t | 22 +- tags/review.pl | 9 +- 12 files changed, 356 insertions(+), 244 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js copy opac/opac-article-request-cancel.pl => t/Makefile.t (53%) mode change 100755 => 100644 hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Aug 10 21:33:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 Aug 2017 19:33:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-357-gc140b91 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c140b9129124262db27c9ba17f47134ec3232ada (commit) via 3304c7c4ca49db1b95aa564b3550bacf260b9b4f (commit) via 0e2c823e8806c35673505d0e2a03081cac00190a (commit) via 22944fb61241239124b4db218d098b8510327276 (commit) via 28a979487f3d8c4a5887c484ae71c7c63e7ee03d (commit) via b2a8e726fe32d4aae3f279f4142af240c60d7fe5 (commit) via 8651016ce8e959b5b6ca19ccddbb3f5342b5d456 (commit) via b80704aa1b763c7a29c3b95c162dfb12ded8faa2 (commit) via d2cceb95b47983b28242819c95e57439958b0da5 (commit) via 8a328a20bf3a74268346104281688b2a81be80e6 (commit) via be0bf8731a2361f4fabbfff8059fef60dd364d88 (commit) via ad1182411220d74cd13ea5cd1525b71cf7fef981 (commit) via 1b63d3e041602318b16a51a4b1798fbdc25f34bb (commit) via 3b87ec988dd786ca1286a7baa9f14fabdcb1c6c2 (commit) via b4ce1feb1bc6b4f20cf71bd545e018917cf518db (commit) via c6f8cf69d3943599fa6a0c250ae0e8221ead44ff (commit) via e3dafbfccd06af8fca45fada449e93e3d0616cd6 (commit) via d01ce104a7711814152e4f8228064f79c8a7f68c (commit) from e35903574ce666bca32eb4676f311b99bb268ec2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c140b9129124262db27c9ba17f47134ec3232ada Author: Marc V?ron Date: Wed Aug 2 18:01:06 2017 +0200 Bug 19027 - Circulation rules: Better wording for standard rules for all libraries In Home > Administration > Circulation and fine rules, the standard value for "Select a library: All libraries" is confusing and leads to support cases. Change wording to "Standard rules for all libraries". To test: - Apply patch - Go to Home > Administration > Circulation and fine rules - Verfiy that text in drop down 'Select a library' makes sense. Followed test plan which works as intended. I agree with the wording it is significantly clearer than previously Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart commit 3304c7c4ca49db1b95aa564b3550bacf260b9b4f Author: Owen Leonard Date: Tue Aug 1 17:07:33 2017 +0000 Bug 18985 - SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically This patch alters the DataTables configuration of the SQL reports list so that date columns are identified via class rather than position. To test, apply the patch and go to Reports -> Use saved. Test the re-ordering of the creation date, last edit, and last run columns. Each should sort correctly based on the date. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 0e2c823e8806c35673505d0e2a03081cac00190a Author: Nick Clemens Date: Fri Jul 14 11:25:42 2017 +0000 Bug 18941 - C4::Budgets GetBudgetByCode should return active budgets over inactive budgets To test: 1 - Create an active budget 2 - Create an inactive budget 3 - Ensure they each have a fund with the same code 4 - Set MarcFieldsToOrder to get the budget_code from a marc field 5 - Stage a file using the duplicated code 6 - Add to a basket from the staged file 7 - Add the items 8 - Note funds are encumbered from the inactive budget 9 - Apply patch 10 - Repeat 5-8 with a new basket 11 - Note the active budget is now used Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 22944fb61241239124b4db218d098b8510327276 Author: Nick Clemens Date: Fri Jul 14 11:06:16 2017 +0000 Bug 18941 - Unit tests Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 28a979487f3d8c4a5887c484ae71c7c63e7ee03d Author: Jonathan Druart Date: Thu Aug 10 15:52:35 2017 -0300 Bug 13012: Add more tests Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit b2a8e726fe32d4aae3f279f4142af240c60d7fe5 Author: Kyle M Hall Date: Wed Jul 19 14:57:26 2017 -0400 Bug 13012 - suggestion.suggesteddate should be set to NOW if not defined Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Suggestions.t Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 8651016ce8e959b5b6ca19ccddbb3f5342b5d456 Author: Marcel de Rooy Date: Thu Aug 10 09:24:08 2017 +0200 Bug 19071: Fix Members/IssueSlip.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Members/IssueSlip.t line 44. We do not need to delete all branches here. Note: The test still needs attention for noisy userenv warns, but it should pass now. Test plan: Run t/db_dependent/Members/IssueSlip.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit b80704aa1b763c7a29c3b95c162dfb12ded8faa2 Author: Marcel de Rooy Date: Thu Aug 10 09:13:44 2017 +0200 Bug 19071: Fix Circulation/issue.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/issue.t line 65. Cause: See also bug 19070. We do not need to delete all branches here. Test plan: Run t/db_dependent/Circulation/issue.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit d2cceb95b47983b28242819c95e57439958b0da5 Author: Marcel de Rooy Date: Thu Aug 10 09:04:16 2017 +0200 Bug 19070: Fix Circulation/Branch.t Resolve: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/Branch.t line 49. Resolve: not ok 14 - AddReturn respects branch item return policy - noreturn Failed test 'AddReturn respects branch item return policy - noreturn' at t/db_dependent/Circulation/Branch.t line 279. got: 'yqiKrIkX' expected: undef Cause: There is a record in clubs. The constraint in clubs on branchcode does not include a cascaded delete. The test deletes all branches. Test 14 depends on item-level_itypes==1. When you set it to Biblio, it fails. Test plan: Run t/db_dependent/Circulation/Branch.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 8a328a20bf3a74268346104281688b2a81be80e6 Author: Alex Sassmannshausen Date: Thu Aug 10 13:00:19 2017 +0200 Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit be0bf8731a2361f4fabbfff8059fef60dd364d88 Author: Jonathan Druart Date: Thu Aug 10 15:20:43 2017 -0300 Bug 19074: Do not crash if cardnumber does not exist If a cardnumber does not exist, $borrower will be undef and the ->category call will explode Can't call method "category" on an undefined value at /home/vagrant/kohaclone/tools/modborrowers.pl line 370. This patch makes sure the patron exists before calling any methods. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit ad1182411220d74cd13ea5cd1525b71cf7fef981 Author: Alex Sassmannshausen Date: Thu Aug 10 13:33:36 2017 +0200 Bug 19074: Fix category display in Batch patron modification. * tools/modborrowers.pl (GetBorrowerInfos): Fix setting of patron category description. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt: Use it. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 1b63d3e041602318b16a51a4b1798fbdc25f34bb Author: Marc V?ron Date: Tue Aug 8 10:05:44 2017 +0200 Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 Signed-off-by: Jonathan Druart commit 3b87ec988dd786ca1286a7baa9f14fabdcb1c6c2 Author: Marc V?ron Date: Mon May 8 16:18:41 2017 +0200 Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit b4ce1feb1bc6b4f20cf71bd545e018917cf518db Author: Jonathan Druart Date: Thu Aug 10 15:06:39 2017 -0300 Bug 19047: Fix AddBiblio call in ShelfBrowser.t Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit c6f8cf69d3943599fa6a0c250ae0e8221ead44ff Author: Marcel de Rooy Date: Mon Aug 7 08:44:43 2017 +0200 Bug 19047: Fix AddBiblio call in Reserves.t AddBiblio does not return a title; the biblioitemnumber is stored in the title variable. The variables for biblioitemnumber are not used and can be removed. Test plan: Run t/db_dependent/Reserves.t Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit e3dafbfccd06af8fca45fada449e93e3d0616cd6 Author: Jonathan Druart Date: Thu Aug 10 15:02:23 2017 -0300 Bug 19042: Add mock IndependentBranches=0 for the other test These tests do not cover correctly getletter, but it is not the goal of this patch. Superlibrarian behaviour must be tested as well. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit d01ce104a7711814152e4f8228064f79c8a7f68c Author: Mark Tompsett Date: Fri Aug 4 14:24:38 2017 -0400 Bug 19042: Silence warnings t/db_dependent/Letters.t TEST PLAN --------- prove t/db_dependent/Letters.t -- there will be a message: "C4::Context->userenv not defined!" apply this patch prove t/db_dependent/Letters.t -- there will no longer be that message. run qa test tools Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 5 ++-- Koha/Suggestion.pm | 18 +++++++++++++++ .../prog/en/modules/admin/smart-rules.tt | 2 +- .../en/modules/reports/guided_reports_start.tt | 12 ++++------ .../prog/en/modules/tools/import_borrowers.tt | 9 ++++++++ .../prog/en/modules/tools/modborrowers.tt | 2 +- t/db_dependent/Budgets.t | 24 +++++++++++++++++--- t/db_dependent/Circulation/Branch.t | 3 +++ t/db_dependent/Circulation/issue.t | 1 - t/db_dependent/Koha/Suggestions.t | 23 ++++++++++++++++++- t/db_dependent/Letters.t | 5 +++- t/db_dependent/Members/IssueSlip.t | 1 - t/db_dependent/Reserves.t | 5 ++-- t/db_dependent/ShelfBrowser.t | 2 +- tools/import_borrowers.pl | 17 ++++++++++++++ tools/modborrowers.pl | 11 +++++---- 16 files changed, 113 insertions(+), 27 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Aug 15 12:21:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Aug 2017 10:21:06 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.10-22-g12d8885 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 12d8885eefd20b0f4b3bba9425a16aadfefeb74e (commit) via c5b576135a3a29ab482445afaaecadf12566db3c (commit) from 9793ba80e7879d06d0231c787b12fd3d1f9c8ef5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12d8885eefd20b0f4b3bba9425a16aadfefeb74e Author: Jonathan Druart Date: Thu Jun 15 15:46:17 2017 -0300 Bug 18539: remove occurrence in ReNewSubscription.t Signed-off-by: Jonathan Druart (cherry picked from commit ad7ff09b995e5275f2c6d664b31351321b1674af) Signed-off-by: Fridolin Somers (cherry picked from commit 6e26bd0567c29b990eb8c786c2dc530afdd8b598) Signed-off-by: Katrin Fischer commit c5b576135a3a29ab482445afaaecadf12566db3c Author: Jonathan Druart Date: Tue Apr 18 13:49:18 2017 -0300 Bug 18539: Forbid list context calls for Koha::Objects->find Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. Considering: $template->param( stuff => Koha::Stuffs->find( $id ), foo => 1, ); without this patch, if the $id does not represent any rows in the DB, stuff will be assigned to 'foo' and $foo will be undef in the template. That can lead to very bad side-effects. With this patch we make sure that it will never happen again. Test plan: prove t/db_dependent/Koha/Objects.t should return green Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 15cbf14f4d4f8039ad7820ce37da202b19e0075d) Signed-off-by: Fridolin Somers (cherry picked from commit 5a2604144f114d242d7e4860603fd4811937f44c) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 2 ++ t/db_dependent/Koha/Objects.t | 14 ++++++++++++++ t/db_dependent/Serials/ReNewSubscription.t | 4 ++-- 3 files changed, 18 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Aug 15 17:27:49 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 15 Aug 2017 15:27:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-389-g7b5457c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7b5457cd0f17173ae9ebca2e71696cc09709a910 (commit) via d934e72f5d7ee919b7a1e2e013a317371c20d37f (commit) via a43a8cb1be575fce59f7327c2f906fff36bce48d (commit) via 34587fafecf8e274586715dce2c04b0f557ce313 (commit) via 73aa4e65c0a45c230479de93cdee3dc55f93c3f9 (commit) via 7efb871fa31869044045ccef0b37be438ba704ff (commit) via e4573d709936bbd7f454a26f073e2131aa9c8df3 (commit) via a66c0b1dd76a2fe08ed7ac189ad8a564372ab3a9 (commit) via a58745d9dbbf98c79f4c1a3e7cd40fb45425fc91 (commit) via 0936f642d558d2866d675d0120f047ad02ecbb1f (commit) via 1c2ee5903cfe19379d20a847558fb0c176580cc0 (commit) via e03f590fa1080b1c3fbe25c91af08094620609d6 (commit) via b1ba7fac2c246c2dd52aa4d35884a03d542a26f4 (commit) via b57d682edd5040eb342047aefa95b84402f4c3ae (commit) via a423fcff42da05e9ebf9f2b4a2f192023346e93e (commit) via d8f6315b6d9b1c7145f6036b55b7927f6d6e6e48 (commit) via 0987b135ea0bb8fbd4fc39643b19715dc6e3a1c8 (commit) via 83f60adbab8e96f0f14ec547029582623ac3a068 (commit) via d24568b67256fab79b42ead54302c76d1c9653d7 (commit) via 3c6168d37436b7312e130f796d47271ff2de77cf (commit) via 14484ba4234fd1cbb925b5f3a4844da863c65d5a (commit) via 2ee4e0ac381ed23fa23b1117725b2f6a0e0db4de (commit) via a10e5383016a5cb4117719ac858cbe02a53e457b (commit) via 8403799c7212349bee70090249e3425afd62423b (commit) via 07c0d968b70421852ac4915633fa7f3cbd0d18cd (commit) via 9c8a04acb05466356fec8e9d6d13183295719c7d (commit) via 3808dbc1d22b3adc43a09ba7ce00aaca01f95f5a (commit) via 03c5eb0babc3fd7b0ecf45a8a5db91a67718d3b4 (commit) via 9d7d524f21fbf83ef7e1031e36c9772ffe21db90 (commit) via cfb52579ec2f8859226e0e40f66d5a6d7a2ed73f (commit) via b308b0814bcd149e3f899058e693938d982bb425 (commit) via ff41b87302c1b242f9edd7b2e8c253bd18b57ac1 (commit) from c140b9129124262db27c9ba17f47134ec3232ada (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b5457cd0f17173ae9ebca2e71696cc09709a910 Author: Baptiste Wojtkowski Date: Mon Jul 10 08:11:33 2017 +0000 Bug 18919: Repair "Transaction branch" in cash_register_stats.pl - values of the option fields are now correctly loaded TEST PLAN: go to domain/cgi-bin/koha/reports/cash_register_stats.pl 1 - Make a report for all branches => it works 2 - Make a report for any branch => you will get the same or no result 3 - apply patch 4 - Repeat 2 => it should work Followed test plan worked as intended Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit d934e72f5d7ee919b7a1e2e013a317371c20d37f Author: Owen Leonard Date: Thu May 25 12:40:43 2017 +0000 Bug 12644 - Add subtitles to staff client cart This patch adds display of subtitles to the staff client cart. To test you should have some values mapped to subtitle in Administration -> Keyword to MARC Mapping. 1. Apply the patch. 2. Add some records to the staff client cart which have subtitles. 3. Open the cart and onfirm that subtitles display correctly in both the brief and "More details" view. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit a43a8cb1be575fce59f7327c2f906fff36bce48d Author: Mark Tompsett Date: Wed Jun 28 23:31:12 2017 +0000 Bug 18877: Add documentation on dbhost for koha-create help TEST PLAN --------- apply bugs 9409 and 14533 (order is irrelevant) trigger message about missing database name -- notice it fails to mention dbhost apply this patch trigger message again -- notice it mentions dbhost Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 34587fafecf8e274586715dce2c04b0f557ce313 Author: Mark Tompsett Date: Thu Jun 22 19:26:33 2017 +0000 Bug 14533: Make --use-db display a message if no DB defined Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 73aa4e65c0a45c230479de93cdee3dc55f93c3f9 Author: Yarik Dot Date: Thu Jun 22 17:53:00 2017 +0000 Bug 14533: remove CREATE USER when koha-create --use-db Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7efb871fa31869044045ccef0b37be438ba704ff Author: Tomas Cohen Arazi Date: Fri Aug 11 15:09:00 2017 -0300 Bug 9409: (QA followup) Add --dbhost help to koha-create man page Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e4573d709936bbd7f454a26f073e2131aa9c8df3 Author: Mark Tompsett Date: Fri Jun 23 01:46:50 2017 +0000 Bug 9409: Add --dbhost parameter and dbhost field This allows setting the remote db host correctly for request-db either with a command-line or passwd file. Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit a66c0b1dd76a2fe08ed7ac189ad8a564372ab3a9 Author: Nick Clemens Date: Fri Jul 7 11:25:24 2017 +0000 Bug 18469: QA Follow-up Restore datepicker class Use Koha.Preference Copy changes to moremember Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit a58745d9dbbf98c79f4c1a3e7cd40fb45425fc91 Author: Nick Clemens Date: Fri Apr 21 10:08:27 2017 -0400 Bug 18469: Suspend all holds when specifying a date to resume hold does not keep date Name of field had 'datepicker' embedded, this caused variable issue To test: 1 - Place several holds for a patron 2 - Go to holds tab in circulation 3 - Select a date for suspend all holds until 4 - Suspend all holds 5 - Note date is not used, suspended indefinitely 6 - Apply patch 7 - Resume all suspended holds 8 - Select a date for suspend all holds until 9 - Suspend all holds 10 - Note date is used Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0936f642d558d2866d675d0120f047ad02ecbb1f Author: Marcel de Rooy Date: Fri Aug 11 08:11:20 2017 +0200 Bug 19061: [QA Follow-up] Wrong interpolation Interpolating "$object->method" does not work. Unable to execute query [Object class]=HASH(0x3c21cc8)->method. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 1c2ee5903cfe19379d20a847558fb0c176580cc0 Author: Colin Campbell Date: Tue Aug 8 11:47:40 2017 +0100 Bug 19061: Avoid SQL Injection vulnerability Embedding values in the SQL statement allows the passing of values that would normally be rejected resulting in mysql errors variables should always be passed via placeholders and the execute call Signed-off-by: Katrin Fischer