[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.02-28-g9f0b5cd

Thu Aug 3 09:50:58 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  9f0b5cd73cbaefdb4f46cae6f5e7f7f07607a51f (commit)
       via  c4eb6e260b5bdd9c9ab48caa370de10bf68b40ea (commit)
       via  5a137e3c6c176ee4a04802049e205aa09807370c (commit)
       via  90ef2aedffedf15bdacb1d6ddbbe81bff72036ac (commit)
       via  6e26bd0567c29b990eb8c786c2dc530afdd8b598 (commit)
       via  5a2604144f114d242d7e4860603fd4811937f44c (commit)
      from  1da77ea584bcc2a2878106b6bc174b21bb0837ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f0b5cd73cbaefdb4f46cae6f5e7f7f07607a51f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 16 07:57:14 2017 +0200

    Bug 18361: [QA Follow-up] Resolve warning on undef values supplied

    The following warning was raised in Letters.t:
    DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint():
    NULL/undef values supplied for requested unique constraint 'primary' (NULL
    values in column(s): 'id'). This is almost certainly not what you wanted,
    though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning.

    This warning is triggered by this line in C4/Letters.pm:
        Koha::SMS::Providers->find( $member->{'sms_provider_id'} );
    As you already guessed, the sms_provider_id returns undef.

    Resolved in sub find by testing if there are parameters and if so, they
    should not be all undefined. (In most cases there will be only one
    parameter; but this report is about composite keys.)

    Added a trivial test case in Objects.t too.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/Letters.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    (cherry picked from commit e1afa469f8313144c70ae91d7efa356beb8168b8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit c4eb6e260b5bdd9c9ab48caa370de10bf68b40ea
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 19 11:57:33 2017 -0300

    Bug 18361: (QA followup) Add tests for the no params case

    This patch adds a test for the trivial case in which no param is passed
    and the ->find method returns undef.

    For completeness purposes.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit e1f943b9992ea1a3c5d4659ca6fa787834d66376)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5a137e3c6c176ee4a04802049e205aa09807370c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Apr 13 13:15:30 2017 +0200

    Bug 18361: Additional tests for Koha::Objects->find

    Adding a subtest find in t/db_dependent/Koha/Objects.t.

    Test plan:
    Run t/db_dependent/Koha/Objects.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit de74a4e5a0ec0fcf85a42b637d07c2bcd81d63f0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 90ef2aedffedf15bdacb1d6ddbbe81bff72036ac
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Mar 31 13:52:15 2017 +0200

    Bug 18361: Koha::Objects->find should accept composite primary keys

    Changes the $id parameter to an array. (IssuingRule has three keys.)
    The build_object method in TestBuilder.pm has been adjusted to pass
    multiple primary key values to find.

    Also adjusted the POD section to show more clearly that we accept
    the same parameters as DBIx ResultSet does.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/TestBuilder.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ec288a50def5c4fdcd7b001087fed0b120e4a211)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6e26bd0567c29b990eb8c786c2dc530afdd8b598
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 15 15:46:17 2017 -0300

    Bug 18539: remove occurrence in ReNewSubscription.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ad7ff09b995e5275f2c6d664b31351321b1674af)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5a2604144f114d242d7e4860603fd4811937f44c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 18 13:49:18 2017 -0300

    Bug 18539: Forbid list context calls for Koha::Objects->find

    Reading https://perlmaven.com/how-to-return-undef-from-a-function
    this sound like the more correct behaviour.

    Considering:
    $template->param(
        stuff => Koha::Stuffs->find( $id ),
        foo   => 1,
    );
    without this patch, if the $id does not represent any rows in the DB,
    stuff will be assigned to 'foo' and $foo will be undef in the template.
    That can lead to very bad side-effects.

    With this patch we make sure that it will never happen again.

    Test plan:
      prove t/db_dependent/Koha/Objects.t
    should return green

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 15cbf14f4d4f8039ad7820ce37da202b19e0075d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                            |   19 ++++++++---
 t/db_dependent/Koha/Objects.t              |   47 +++++++++++++++++++++++++++-
 t/db_dependent/Serials/ReNewSubscription.t |    4 +--
 t/lib/TestBuilder.pm                       |    2 +-
 4 files changed, 63 insertions(+), 9 deletions(-)

hooks/post-receive
-- 
main Koha release repository