[koha-commits] main Koha release repository branch master updated. v17.05.00-323-g5bb56bf
Git repo owner
gitmaster at git.koha-community.org
Tue Aug 8 14:47:46 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5bb56bf336187cde38e1a3b89c792ee6dc231acf (commit)
via 0853c4e2b4366a235077a24a873fc81a754afecb (commit)
via ec9b691de934f82c50057c15fb7d3a1b32717b72 (commit)
via 24b4006ecbc0a258b09500bdd8f639c7018067c0 (commit)
via 9512b015662f8ec56d8b8884b4e4bb14d5e563f1 (commit)
via 4bbec5c382590f881e6d2af62b2608fe9cf9e051 (commit)
via ae5f5c479929cbfad3193c6ce9471a406a2a41f3 (commit)
via 0bcf6a79427297c332588317dde749e923c7bbdc (commit)
via b7d291a1ee692d6de71503683a3e61c9311c33d8 (commit)
via b94eb77d1ba2f407f79c12c3fff44312ea964d77 (commit)
via 1917e0c89fc275bf402b79ddad924b51731f47bf (commit)
via c1185533c61e8266f9d89136e8e0debddf71d497 (commit)
via 972281c77d1315dde2a988510a8c4102de16d7d2 (commit)
via 31f5c43d54a2bb6d61402889cb6dcff630683015 (commit)
via f79beb52708ed211f4ef6386ed358b21ed511efb (commit)
via 64a0aa541ed96b45bdc5525f35bf7dfea9c25104 (commit)
via fbfb6dca269acdc417e51e84e0c0b88e57f095ba (commit)
from 1b73cae6eb4ce7e7ca675d6db84fe8ce0cd2f499 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5bb56bf336187cde38e1a3b89c792ee6dc231acf
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Sat Jul 29 17:06:52 2017 +0200
Bug 19003: Add a TestBuilder default for borrowers.login_attempts
Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since
TestBuilder fills login_attempts with a random number. (Note: Only
when FailedLoginAttempts is non-zero.)
Trivial fix: TestBuilder should have a zero default for login_attempts.
Test plan:
Do not yet apply this patch.
Set pref FailedLoginAttempts to say 3.
Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ).
Apply this patch.
Run t/db_dependent/SIP/Message.t again. Does not fail anymore.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0853c4e2b4366a235077a24a873fc81a754afecb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 1 11:44:29 2017 -0300
Bug 17699: Reset time simulation
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ec9b691de934f82c50057c15fb7d3a1b32717b72
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 11:30:00 2017 -0300
Bug 17699: Add test descriptions
Test plan:
prove -v t/db_dependent/Koha/Patrons.t
Subtest: renew_account
1..30
ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00
ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00
ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 4 - today + 12 months must be 2017-03-31T00:00:00
ok 5 - today + 12 months must be 2017-03-31T00:00:00
ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged
ok 7 - today + 12 months must be 2017-03-31T00:00:00
ok 8 - today + 12 months must be 2017-03-31T00:00:00
ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00
ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00
ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00
ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00
ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 14 - today + 12 months must be 2017-11-30T00:00:00
ok 15 - today + 12 months must be 2017-11-30T00:00:00
ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged
ok 17 - today + 12 months must be 2017-11-30T00:00:00
ok 18 - today + 12 months must be 2017-11-30T00:00:00
ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00
ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00
ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00
ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00
ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 24 - today + 12 months must be 2018-07-31T00:00:00
ok 25 - today + 12 months must be 2018-07-31T00:00:00
ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged
ok 27 - today + 12 months must be 2018-07-31T00:00:00
ok 28 - today + 12 months must be 2018-07-31T00:00:00
ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00
ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 24b4006ecbc0a258b09500bdd8f639c7018067c0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 11:03:37 2017 -0300
Bug 17699: Use limit as end_of_month
From DateTime::Duration pod:
""
For positive durations, the "end_of_month" parameter defaults to wrap.
For negative durations, the default is "limit". This should match how
most people "intuitively" expect datetime math to work.
""""
We need end_of_month => limit for positive durations as well.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9512b015662f8ec56d8b8884b4e4bb14d5e563f1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 11:02:42 2017 -0300
Bug 17699: Add more tests to highlight the problem
Add problematic cases to highlight the problem.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4bbec5c382590f881e6d2af62b2608fe9cf9e051
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 11:18:23 2017 -0300
Bug 19009: Fix random failures from Circulation.t
From jenkins output:
Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues
1..8
not ok 1
[SKIP]
I executed it several times and display the different $error, $alerts and question keys.
GNA and RESTRICTED were sometimes set, which block the issue.
Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection.
Test plan:
Execute the tests several times and notice that it fails randomly
With this patch they should always pass.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ae5f5c479929cbfad3193c6ce9471a406a2a41f3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 14 11:32:30 2017 -0300
Bug 18802: Fix Circulation.t if finesMode ne 'production'
If finesMode is not set to production, only 1 fine will be created (the renewal
one will not). This is what assumes the tests.
If set to 'production', the tests will fail because the fines will not
be deleted (because of the DBIx::Class) warning.
Now we mock the value before charging.
prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491
t/db_dependent/Circulation.t .. 56/95
# Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10'
# at t/db_dependent/Circulation.t line 670.
# got: 'auto_too_much_oweing'
# expected: 'auto_renew'
# Looks like you failed 1 test of 6.
Test plan:
prove t/db_dependent/Circulation.t
should return green whatever the value of finesMode
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0bcf6a79427297c332588317dde749e923c7bbdc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 7 11:04:51 2017 -0300
Bug 19013: (QA followup) Set guarantorid to NULL patron sample data
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b7d291a1ee692d6de71503683a3e61c9311c33d8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 16:12:16 2017 -0300
Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql
That breaks randomly tests on Jenkins (Koha/Patrons.t)
It certainly affects data in other languages but I did not find a quick
and easy way to modify this file (replace all guarantorid values with
NULL)
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Easy fix
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b94eb77d1ba2f407f79c12c3fff44312ea964d77
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 7 12:33:50 2017 -0300
Bug 18851: (QA followup) Test doesn't need sessions on DB
As the DB structure is not initialized for sessions, running this tests raise an irrelevant warning.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1917e0c89fc275bf402b79ddad924b51731f47bf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 10 16:11:44 2017 -0300
Bug 18851: Fix few other tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1185533c61e8266f9d89136e8e0debddf71d497
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 24 12:44:30 2017 -0300
Bug 18851: Make OverDrive.T pass if dbms is not running
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 972281c77d1315dde2a988510a8c4102de16d7d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 5 17:38:41 2017 -0300
Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 31f5c43d54a2bb6d61402889cb6dcff630683015
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 5 17:38:22 2017 -0300
Bug 18851: Test::DBIx::Class is not needed in 00-load.t
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f79beb52708ed211f4ef6386ed358b21ed511efb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 5 17:37:41 2017 -0300
Bug 18851: Database handler must not be created at runtime
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 64a0aa541ed96b45bdc5525f35bf7dfea9c25104
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 7 09:54:27 2017 -0300
Bug 19048: (bug 17829 follow-up) Fix regression in self checkout
$patronid is not necessarily set or does not match a valid cardnumber.
These cases must be taken into account to avoid the script to crash and
raise the following error:
Can't call method "unblessed" on an undefined value at
(...)/koha/opac/sco/sco-main.pl line 117
Test plan:
Hit sco/sco-main.pl and confirm that the error is gone with this patch
applied
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fbfb6dca269acdc417e51e84e0c0b88e57f095ba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 7 10:01:40 2017 -0300
Bug 19041: (bug 17855 follow-up) Fix regression on bug 16058
From
commit 0492fcf87f170846d1e6c8683916a56cb67ce9a7
Bug 17855: Onboarding tool
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
@@ -1,5 +1,3 @@
-[% USE Koha %]
-[% SET footerjs = 1 %]
+[% USE Koha %] has been re-added by
commit 151cdcd133d8618a3faf9b47723d66ac3dc71b4e
Bug 18673: News author does not display on staff client home page
But not the footerjs = 1
Test plan:
From the main page of the staff interface, delete a news item
Without this patch applied you will not get a JS confirmation message
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Trivial fix.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
Koha/Patron/Category.pm | 2 +-
Koha/Patron/Discharge.pm | 7 +-
.../data/mysql/de-DE/optional/sample_patrons.sql | 24 ++--
.../data/mysql/en/optional/sample_patrons.sql | 24 ++--
.../data/mysql/es-ES/optional/sample_patrons.sql | 24 ++--
.../mysql/nb-NO/2-Valgfritt/sample_patrons.sql | 24 ++--
.../data/mysql/pl-PL/optional/sample_patrons.sql | 24 ++--
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 1 +
opac/sco/sco-main.pl | 13 +-
t/00-load.t | 3 -
t/Koha_ExternalContent_OverDrive.t | 24 +++-
t/Members/cardnumber.t | 15 +-
t/Patron.t | 14 +-
t/Search.t | 12 +-
t/SuggestionEngine_AuthorityFile.t | 14 +-
t/XSLT.t | 2 +
t/db_dependent/Circulation.t | 32 +++--
t/db_dependent/Koha/Patrons.t | 149 ++++++++++----------
t/lib/TestBuilder.pm | 3 +
19 files changed, 247 insertions(+), 164 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list