[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.10-22-g12d8885

Git repo owner gitmaster at git.koha-community.org
Tue Aug 15 12:21:06 CEST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  12d8885eefd20b0f4b3bba9425a16aadfefeb74e (commit)
       via  c5b576135a3a29ab482445afaaecadf12566db3c (commit)
      from  9793ba80e7879d06d0231c787b12fd3d1f9c8ef5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 12d8885eefd20b0f4b3bba9425a16aadfefeb74e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 15 15:46:17 2017 -0300

    Bug 18539: remove occurrence in ReNewSubscription.t
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ad7ff09b995e5275f2c6d664b31351321b1674af)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 6e26bd0567c29b990eb8c786c2dc530afdd8b598)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit c5b576135a3a29ab482445afaaecadf12566db3c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 18 13:49:18 2017 -0300

    Bug 18539: Forbid list context calls for Koha::Objects->find
    
    Reading https://perlmaven.com/how-to-return-undef-from-a-function
    this sound like the more correct behaviour.
    
    Considering:
    $template->param(
        stuff => Koha::Stuffs->find( $id ),
        foo   => 1,
    );
    without this patch, if the $id does not represent any rows in the DB,
    stuff will be assigned to 'foo' and $foo will be undef in the template.
    That can lead to very bad side-effects.
    
    With this patch we make sure that it will never happen again.
    
    Test plan:
      prove t/db_dependent/Koha/Objects.t
    should return green
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 15cbf14f4d4f8039ad7820ce37da202b19e0075d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 5a2604144f114d242d7e4860603fd4811937f44c)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                            |    2 ++
 t/db_dependent/Koha/Objects.t              |   14 ++++++++++++++
 t/db_dependent/Serials/ReNewSubscription.t |    4 ++--
 3 files changed, 18 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list