[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.10-33-g7ffc92c

Thu Aug 17 00:09:35 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  7ffc92ca2dc07e56f13a8d18f86ac373a90a2c84 (commit)
       via  91b6b514a7cf77f0513ce598751794265342f73e (commit)
       via  2bf7a97e18ebe9eea113424d66036bb7ec6f3f9a (commit)
       via  0982a6d018d97c1239841e2fe334b16922bd355c (commit)
       via  65cd0129a4dca45452b67600955ff19e5fe23708 (commit)
       via  0fcbcd8675e6fe40f5984d3c525a570eeb10f88b (commit)
       via  067c45ed30957f7aadf74a4be00b9933ccfa3dd3 (commit)
       via  7f8b4e60abf263514e06ad7d5799ee992f93fa79 (commit)
       via  82ec039de85165c4dcecd32a86c7d041b893b628 (commit)
       via  89bf4555292719f44f183a187c6ef69475fec6a3 (commit)
       via  c2d2e915c930227ff842b699e6bc1673ef5a809a (commit)
      from  12d8885eefd20b0f4b3bba9425a16aadfefeb74e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7ffc92ca2dc07e56f13a8d18f86ac373a90a2c84
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 1 08:30:20 2017 -0300

    Bug 18976: [16.11] Add missing use statement

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 91b6b514a7cf77f0513ce598751794265342f73e
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Mon Jul 24 18:16:25 2017 +0300

    Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup

    Same problem in t/db_dependent/Search/History.t.

    To replicate:
    1. Check the row count of borrowers, branches, categories, sessions, sms_providers
       tables
    2. prove t/db_dependent/Search/History.t
    3. Repeat step 1
    4. Observe borrowers the following tables have increased in row count:
       - borrowers
       - branches
       - categories
       - sessions
       - sms_providers

    To test:
    1. Before applying the patch, go through steps at "To replicate" plan
    2. Apply patch
    3. Go through steps at "To replicate" plan
    4. Observe step 4 no longer applies and those tables have the same number of
       rows as before executing the test.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2bf7a97e18ebe9eea113424d66036bb7ec6f3f9a
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Mon Jul 24 16:43:18 2017 +0300

    Bug 18976: Fix t/db_dependent/Auth.t cleanup

    Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup.
    Data generated by TestBuilder is left in borrowers, branches, categories,
    sms_providers and sessions tables after the test.

    To replicate:
    1. Check the row count of borrowers, branches and categories tables
    2. prove t/db_dependent/Auth.t
    3. Repeat step 1
    4. Observe borrowers the following tables have increased in row count:
       - borrowers
       - branches
       - categories
       - sessions
       - sms_providers

    To test:
    1. Before applying the patch, go through steps at "To replicate" plan
    2. Apply patch
    3. Go through steps at "To replicate" plan
    4. Observe step 4 no longer applies and those tables have the same number of
       rows as before executing the test.

    This issue has been happening in REST tests as well, and this solution is
    directly copy-pasted from t/db_dependent/api/v1/cities.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0982a6d018d97c1239841e2fe334b16922bd355c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 18 17:42:02 2017 -0300

    Bug 18632: Remove 'CGI::param called in list context' warnings

    Once again, after bug 16154 and bug 16259 we need to remove more
    occurrence of CGi->param called in list context.
    Refer to bug 15809 for more information.

    Test plan:
    Make sure you do not see the error on the modified scripts.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 65cd0129a4dca45452b67600955ff19e5fe23708
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 12 11:38:59 2017 -0300

    Bug 18685: (bug 18551 follow-up) Fix patron toolbar

    Bug 18551 moves the way the filters are displayed and so the position of
    the patron toolbar must be recalculated.

    Test plan:
    Edit patron's detail
    open the filters, scrolldown
    close the filters, scrolldown
    => The toolbar must be correctly placed

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    (cherry picked from commit 6ae6d4bcb5238b1ffc0a22cc1d83ac05ba982b92)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit a0043ec80d11d718b8ea13e69879e7d4309d011e)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 0fcbcd8675e6fe40f5984d3c525a570eeb10f88b
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue May 9 13:33:52 2017 +0000

    Bug 18551: [16.11.x] followup - hide advanced filters in header, move hidding to css file

    Test plan:
    The same as first patch, but also with advanced search form in header hidden
    on page load - see comment 4

    Issue with advanced search form is gone.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Philippe <philippe.audet-fortin at inlibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 067c45ed30957f7aadf74a4be00b9933ccfa3dd3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:59:45 2017 +0200

    Bug 18951: Adjust Isbd.t

    Add schema calls.
    Remove an unneeded AddBiblio call.

    Test plan:
    Run t/db_dependent/Biblio/Isbd.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 40c719a5248877d200920c2c9a028e273a5f1370)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit ce8ddbf8ea7d463a822a70f474310b8b618d6347)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 7f8b4e60abf263514e06ad7d5799ee992f93fa79
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:48:55 2017 +0200

    Bug 18951: Create data for TransformKohaToMarc.t

    Adding schema and caching statements.
    Adjust it so that the Koha to MARC mappings are not assumed to be present,
    but are created as needed.
    Remove the mock on marcflavour. It is no longer needed.
    Resolving a small typo.

    Test plan:
    Run t/db_dependent/Biblio/TransformKohaToMarc.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit f839955db707415368d23ae81bdb14505dd058ee)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 36c3bbedfe80a1a55f34aedb6931784da1043c84)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 82ec039de85165c4dcecd32a86c7d041b893b628
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:33:34 2017 +0200

    Bug 18951: Some t/Biblio tests are database dependent (git mv)

    Move Isbd.t and TransformKohaToMarc.t to db_dependent.
    Next patch will add a few adjustments too.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 50bc4170cec172de04db2033d464c96348d5a508)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 216b13e51fbdaa0ede2eb3218338f955c6c2aa48)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 89bf4555292719f44f183a187c6ef69475fec6a3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Mar 31 13:52:15 2017 +0200

    Bug 18361: [SQUASHED FOR 16.11] Koha::Objects->find should accept composite primary keys

    Changes the $id parameter to an array. (IssuingRule has three keys.)
    The build_object method in TestBuilder.pm has been adjusted to pass
    multiple primary key values to find.

    Also adjusted the POD section to show more clearly that we accept
    the same parameters as DBIx ResultSet does.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/TestBuilder.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Bug 18361: Additional tests for Koha::Objects->find

    Adding a subtest find in t/db_dependent/Koha/Objects.t.

    Test plan:
    Run t/db_dependent/Koha/Objects.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Bug 18361: (QA followup) Add tests for the no params case

    This patch adds a test for the trivial case in which no param is passed
    and the ->find method returns undef.

    For completeness purposes.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Bug 18361: [QA Follow-up] Resolve warning on undef values supplied

    The following warning was raised in Letters.t:
    DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint():
    NULL/undef values supplied for requested unique constraint 'primary' (NULL
    values in column(s): 'id'). This is almost certainly not what you wanted,
    though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning.

    This warning is triggered by this line in C4/Letters.pm:
        Koha::SMS::Providers->find( $member->{'sms_provider_id'} );
    As you already guessed, the sms_provider_id returns undef.

    Resolved in sub find by testing if there are parameters and if so, they
    should not be all undefined. (In most cases there will be only one
    parameter; but this report is about composite keys.)

    Added a trivial test case in Objects.t too.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/Letters.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit c2d2e915c930227ff842b699e6bc1673ef5a809a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Aug 16 22:38:57 2017 +0200

    Bug 18539 - Follow-up - RMaint missed a merge marker...

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                                    |   17 +++++---
 admin/authorised_values.pl                         |    6 +--
 admin/classsources.pl                              |   21 +++++-----
 admin/edi_accounts.pl                              |   24 +++++------
 admin/import_export_framework.pl                   |    2 +-
 admin/patron-attr-types.pl                         |    2 +-
 installer/install.pl                               |    2 +-
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    6 +++
 .../prog/en/includes/patron-search.inc             |    9 ++--
 .../prog/en/modules/members/memberentrygen.tt      |   10 ++---
 members/housebound.pl                              |   44 ++++++++++----------
 t/Biblio/TransformKohaToMarc.t                     |   31 --------------
 t/db_dependent/Auth.t                              |    4 ++
 t/{ => db_dependent}/Biblio/Isbd.t                 |   11 ++---
 t/db_dependent/Biblio/TransformKohaToMarc.t        |   42 +++++++++++++++++++
 t/db_dependent/Koha/Objects.t                      |   43 ++++++++++++++++---
 t/db_dependent/Search/History.t                    |    6 +++
 17 files changed, 175 insertions(+), 105 deletions(-)
 delete mode 100644 t/Biblio/TransformKohaToMarc.t
 rename t/{ => db_dependent}/Biblio/Isbd.t (90%)
 create mode 100644 t/db_dependent/Biblio/TransformKohaToMarc.t

hooks/post-receive
-- 
main Koha release repository