[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.15-23-g7bf90ba
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 23 12:37:07 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via 7bf90ba511ca715e3aa35f959e5db86a34779368 (commit)
via ae4719be08b839fa602c3f1c25628d5a72253a30 (commit)
via 13c3f47a362bee89ddff6cc542cdd0bf5e98d455 (commit)
via a92f955f4345f0250ba7bfca349a228590d5169c (commit)
via 98b7fa8a060492fea6ed5161f9c1791f4b012e1a (commit)
via a2d5326c67ed81ca6232b3451b5e1b4b8e2c5556 (commit)
via bf74214944a42851e55e8bd6107c598ee5e48834 (commit)
via ce2e8878eb603f0da1d16ec188760ab11f150247 (commit)
via dac5f4bcb85953be5b529796e0596c331a6cf882 (commit)
via 8dcb539dfa78f4edc1f420e978e2cf98577a6e81 (commit)
via e998895da5c0f9e5d53b4c04384dc39b10e5a2da (commit)
via 372117c271ed22e77c67a72ec3956adc6bba32f3 (commit)
via 596f6c0fca3d894c7f1e0c6d25c513c3df9caf12 (commit)
via 955a7997b9758a1b2596579c5837149f6855b8ab (commit)
via 001c98b585eb1a9f32cda371e3e250b00e24fe9d (commit)
via de6a7350960d27850b1ea667f628aab6be3bdef7 (commit)
via 53fb660d4bbf89dd6e5daba2ce784514976ad150 (commit)
via c97e0106036a347e8aa4e190960a2de8204c2645 (commit)
via 345798998557abf14f06648ca3809a9eb5818dae (commit)
via cfd9e603c37d69fcdb2c342bb1a358609efbf1ed (commit)
via dea2bb8a6e9bcbd3bf28ebd13f312fbd49fcfc0b (commit)
via 79fb9821ccf36500fd0636fa393a2f44e5988ac1 (commit)
via a9f4dc38c6794e77b854653ca2f358fef125c280 (commit)
from bae0c9c644a55011c5dd69c5fac7d822ff131083 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7bf90ba511ca715e3aa35f959e5db86a34779368
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 1 08:30:20 2017 -0300
Bug 18976: [16.11] Add missing use statement
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ae4719be08b839fa602c3f1c25628d5a72253a30
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Mon Jul 24 18:16:25 2017 +0300
Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup
Same problem in t/db_dependent/Search/History.t.
To replicate:
1. Check the row count of borrowers, branches, categories, sessions, sms_providers
tables
2. prove t/db_dependent/Search/History.t
3. Repeat step 1
4. Observe borrowers the following tables have increased in row count:
- borrowers
- branches
- categories
- sessions
- sms_providers
To test:
1. Before applying the patch, go through steps at "To replicate" plan
2. Apply patch
3. Go through steps at "To replicate" plan
4. Observe step 4 no longer applies and those tables have the same number of
rows as before executing the test.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 13c3f47a362bee89ddff6cc542cdd0bf5e98d455
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Mon Jul 24 16:43:18 2017 +0300
Bug 18976: Fix t/db_dependent/Auth.t cleanup
Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup.
Data generated by TestBuilder is left in borrowers, branches, categories,
sms_providers and sessions tables after the test.
To replicate:
1. Check the row count of borrowers, branches and categories tables
2. prove t/db_dependent/Auth.t
3. Repeat step 1
4. Observe borrowers the following tables have increased in row count:
- borrowers
- branches
- categories
- sessions
- sms_providers
To test:
1. Before applying the patch, go through steps at "To replicate" plan
2. Apply patch
3. Go through steps at "To replicate" plan
4. Observe step 4 no longer applies and those tables have the same number of
rows as before executing the test.
This issue has been happening in REST tests as well, and this solution is
directly copy-pasted from t/db_dependent/api/v1/cities.t
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a92f955f4345f0250ba7bfca349a228590d5169c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 18 17:42:02 2017 -0300
Bug 18632: Remove 'CGI::param called in list context' warnings
Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.
Test plan:
Make sure you do not see the error on the modified scripts.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 98b7fa8a060492fea6ed5161f9c1791f4b012e1a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 12 11:38:59 2017 -0300
Bug 18685: (bug 18551 follow-up) Fix patron toolbar
Bug 18551 moves the way the filters are displayed and so the position of
the patron toolbar must be recalculated.
Test plan:
Edit patron's detail
open the filters, scrolldown
close the filters, scrolldown
=> The toolbar must be correctly placed
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a2d5326c67ed81ca6232b3451b5e1b4b8e2c5556
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jul 19 13:59:45 2017 +0200
Bug 18951: Adjust Isbd.t
Add schema calls.
Remove an unneeded AddBiblio call.
Test plan:
Run t/db_dependent/Biblio/Isbd.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit bf74214944a42851e55e8bd6107c598ee5e48834
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jul 19 13:48:55 2017 +0200
Bug 18951: Create data for TransformKohaToMarc.t
Adding schema and caching statements.
Adjust it so that the Koha to MARC mappings are not assumed to be present,
but are created as needed.
Remove the mock on marcflavour. It is no longer needed.
Resolving a small typo.
Test plan:
Run t/db_dependent/Biblio/TransformKohaToMarc.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ce2e8878eb603f0da1d16ec188760ab11f150247
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jul 19 13:33:34 2017 +0200
Bug 18951: Some t/Biblio tests are database dependent (git mv)
Move Isbd.t and TransformKohaToMarc.t to db_dependent.
Next patch will add a few adjustments too.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit dac5f4bcb85953be5b529796e0596c331a6cf882
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Thu Jul 27 14:56:18 2017 +0000
Bug 18991: Fix cleanup in t/db_dependent/Log.t
There is an action_logs entry via logaction() without transaction to be rolled
back in t/db_dependent/Log.t. This leaves an entry in action_logs after
the test is over.
To replicate:
1. prove t/db_dependent/Log.t
2. Observe a new entry in action_logs table
To test:
1. Apply patch
2. prove t/db_dependent/Log.t
3. Observe there are no new entries in action_logs
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8dcb539dfa78f4edc1f420e978e2cf98577a6e81
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 28 07:56:21 2017 +0200
Bug 19000: Fix typo in closing p tag for items
Close the p tag and add a br tag to visually divide the two sections
Data problems and Warnings regarding system configuration.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Discovered the problem when testing a duplicate key in deleteditems.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 3c87b6f387831053e01ecc86b91d61669af9696b)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 37097ee7f6f462193eefd4d51d4142b6ce59a8a9)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit e998895da5c0f9e5d53b4c04384dc39b10e5a2da
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 24 14:25:21 2017 -0300
Bug 18545: Re-add call to enableCheckboxActions
This call is used to refresh the page correctly
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 372117c271ed22e77c67a72ec3956adc6bba32f3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jun 9 15:50:41 2017 +0000
Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart
This patch makes a few corrections:
- Use 'e.preventDefault()' instead of 'return false' in changed
sections.
- Modify the event handler on checkboxes to successfully handle the
un-check action as well as the check action. (QA comment 5).
To test, follow the original test plan.
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 596f6c0fca3d894c7f1e0c6d25c513c3df9caf12
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Fri May 5 03:58:49 2017 +0000
Bug 18545: Remove use of onclick from OPAC cart
To test:
1) Apply patch and add one or more items to your cart
2) Confirm that clicking the following things still works as expected:
- more details
- brief display
- send
- download
- print
- select all
- clear all
- selecting by clicking checkbox
- remove title
- add title to list
- place hold
- add tag
- empty and close
Sponsored-by: Catalyst IT
Followed test plan, works as expected. Resolves issue with two
print dialogues from Bug 18544.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 955a7997b9758a1b2596579c5837149f6855b8ab
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon May 15 10:38:43 2017 +0200
Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm
Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't
need to do that here. (Would complicate testing it too.)
Fixes typo disablig.
Add a simple test to HoldsQueue.t.
Test plan:
Run t/db_dependent/HoldsQueue.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit db64c94953be772fb316d508fdfffd374ea1d835)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit bede0cc328f6acff69489fe3139d64c35eb7b589)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 001c98b585eb1a9f32cda371e3e250b00e24fe9d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Jul 20 16:08:59 2017 +0200
Bug 18965 - branch transfer limits pagination save bug
In branch transfer limits, tables are paginated with 20 rows by default.
The bug is that datatable not only hides rows, they are not in form.
So when submitting form, rows not visible are erased.
Test plan :
Wihout patch :
- Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx
- Go to Administration > Library transfer limits
- You see table first page : only 20 first rows are shown
- You see all checkboxes are checked
- Go to second page of this table
- Save
=> You see table first page with all checkboxes unchecked
With patch the is no pagination, all checkboxes are shown when you save
Signed-off-by: Axelle Clarisse <axelle.clarisse at univ-amu.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 7a306d72ab98f2abf2266716761820f1098ede9b)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ca7f2f5aa48d8d5136029d10d8c15ffacf010103)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit de6a7350960d27850b1ea667f628aab6be3bdef7
Author: Marc Véron <veron at veron.ch>
Date: Wed Jun 21 09:47:13 2017 +0200
Bug 18832: Missing space between icon and label in button 'Patron lists'
On page Home > Patrons the button 'Patron lists' misses a space between
icon and text. This patch adds it to make the button display like the other
ones.
To test, apply patch and verify that the button displays as expected.
Signed-off-by: fcouffignal <fcouffignal at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 53fb660d4bbf89dd6e5daba2ce784514976ad150
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Jul 10 02:31:22 2017 +0000
Bug 18918: Disable CSV option if no CSV profiles exist
To test:
1) Confirm you have no MARC CSV profiles (tools -> csv profiles)
2) Go to Tools -> Export data
3) Select the CSV file format for biblios
4) Notice the CSV profile dropdown shows up but the dropdown is empty
5) Click the Export button, notice Koha breaks
6) Go back and apply the patch, refresh
7) Notice the CSV option is now disabled in the file format menu
8) If you hover over CSV, an appropriate message should show explaining
why it is disabled
9) Create a CSV profile for MARC
10) Go back to Export and you should be able to use CSV now without
problem
Sponsored-by: Catalyst IT
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c97e0106036a347e8aa4e190960a2de8204c2645
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 26 13:50:14 2017 -0300
Bug 18982: Remove data in the correct order
To respect FK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 345798998557abf14f06648ca3809a9eb5818dae
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 25 16:49:38 2017 -0300
Bug 18982: Create a circ rule for the data we created
No need to have a default circ cule, we create one for the categorycode
and itemtype we are going to use.
The 3 checkouts will not be rejected (5 are allowed)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Andrei <acovaliov at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cfd9e603c37d69fcdb2c342bb1a358609efbf1ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 25 16:48:06 2017 -0300
Bug 18982: Create a specific itemtype for these tests
No need to require rentalcharge=0 for all itemtypes, we create our own.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Andrei <acovaliov at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit dea2bb8a6e9bcbd3bf28ebd13f312fbd49fcfc0b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 25 16:46:08 2017 -0300
Bug 18982: category.categorycode must be uppercase
Otherwise it is not selected in the dropdown list and the patron created
does not belong to this category
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Andrei <acovaliov at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 79fb9821ccf36500fd0636fa393a2f44e5988ac1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 25 14:37:27 2017 -0300
Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL
That way we do not need to set the syspref, we can define it setting an
env var, like other tests.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Andrei <acovaliov at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a9f4dc38c6794e77b854653ca2f358fef125c280
Author: Marc Véron <veron at veron.ch>
Date: Sun May 21 18:28:48 2017 +0200
Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same mail address
To reproduce:
- Create 3 Accounts, login names are test01, test02, test03, Email is the same
for all.
- Go to OPAC -> Password recovery and indicate E-Mail only
- You will get an email for only one of the accounts above.
To test:
- Apply patch, restart memcached and plack
- Go to db, delete from borrower_password_recovery;
- Try steps above to reproduce. You will get an error message:
Account identification with this email address only is ambiguous.
Please use the field 'Login' as well.
- Verify that other cases work as before (provide valid / invalid login only,
provide valid email for an existing account, provide unknown email, provide
both login and email with all combinations of valid / invalid)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Bug 16711: (QA-followup) Use count directly
See comment # 13
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 3829020c2664ec531354f78f0c04d00f5dd6795d)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 739a0f4b9b6bfba236d297608001180f4cb38af3)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
-----------------------------------------------------------------------
Summary of changes:
C4/HoldsQueue.pm | 4 +-
admin/authorised_values.pl | 6 +-
admin/classsources.pl | 21 ++---
admin/edi_accounts.pl | 24 ++---
admin/import_export_framework.pl | 2 +-
admin/patron-attr-types.pl | 1 +
installer/install.pl | 2 +-
.../prog/en/includes/patron-toolbar.inc | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +-
.../en/modules/admin/branch_transfer_limits.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 10 +--
.../intranet-tmpl/prog/en/modules/tools/export.tt | 6 +-
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 92 ++++++++++++++++----
.../bootstrap/en/modules/opac-password-recovery.tt | 5 +-
opac/opac-password-recovery.pl | 21 +++--
t/Biblio/TransformKohaToMarc.t | 31 -------
t/db_dependent/Auth.t | 4 +
t/{ => db_dependent}/Biblio/Isbd.t | 11 +--
t/db_dependent/Biblio/TransformKohaToMarc.t | 42 +++++++++
t/db_dependent/HoldsQueue.t | 12 ++-
t/db_dependent/Log.t | 11 ++-
t/db_dependent/Search/History.t | 6 ++
t/db_dependent/selenium/basic_workflow.t | 47 ++++++----
23 files changed, 248 insertions(+), 117 deletions(-)
delete mode 100644 t/Biblio/TransformKohaToMarc.t
rename t/{ => db_dependent}/Biblio/Isbd.t (90%)
create mode 100644 t/db_dependent/Biblio/TransformKohaToMarc.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list