[koha-commits] main Koha release repository branch master updated. v17.05.00-430-gea88688
Git repo owner
gitmaster at git.koha-community.org
Fri Aug 25 17:29:14 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ea886885d0efa0200cfa166453a4495692afc4d4 (commit)
via 44a8fc5b9363eb27223f32e1150fb8fff6f55d08 (commit)
via b5d6a1885ed4dcb650e7f9f23733b4ff9ad2b37b (commit)
via bf630b19745df8caea47669a9a76de26eddbfeee (commit)
via 3481b7b9dac8935befe631131570591ec2c84cce (commit)
via 7e4ce56b27025b05ee572100529eaa4f28e0933c (commit)
from 249e721ba4b5f60c1d6f4567efd71a4609e60a98 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ea886885d0efa0200cfa166453a4495692afc4d4
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Tue Aug 15 22:21:37 2017 +0530
Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar
Test
1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx
xx is a booksellerid
2. Apply the patch and reload the page.
3. You can see vendor name in browser title bar.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 44a8fc5b9363eb27223f32e1150fb8fff6f55d08
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Aug 16 13:15:19 2017 +0200
Bug 19126: Fix Members.t with IndependentBranches set
If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.
The first one is:
t/db_dependent/Members.t .. 32/63
Failed test 'Staff patron not deleted from list'
at t/db_dependent/Members.t line 304.
Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.
Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b5d6a1885ed4dcb650e7f9f23733b4ff9ad2b37b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 22 13:11:56 2017 -0300
Bug 19130: (followup) Controller scripts should preserve behaviour
This patch is a followup to making
Koha::Acquisition::Booksellers->search work as any other Koha::Objects
(DBIC) query instead of having a different behaviour hardcoded.
To achieve it, this patch makes the controller scripts add
wildcard/truncation chars as prefix and sufix for searches, and make the
default sorting for results be by 'name', ascending.
To test:
- Just verify the behaviour remains unchanged by this patchset on the
controller scripts (re. searching).
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bf630b19745df8caea47669a9a76de26eddbfeee
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 22 12:13:19 2017 -0300
Bug 19130: (followup) Add POD
This patch adds POD to the following files:
- Koha/Acquisition/Bookseller.pm
- Koha/Acquisition/Booksellers.pm
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3481b7b9dac8935befe631131570591ec2c84cce
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 22 12:03:37 2017 -0300
Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t
This followup patch adds a proper file in which add tests for
Koha::Acquisition::Bookseller(s) methods.
All current methods are covered.
To test:
- Run:
$ sudo koha-shell kohadev
k$ cd kohaclone
k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t
=> SUCCESS: Test pass!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7e4ce56b27025b05ee572100529eaa4f28e0933c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 22 12:01:24 2017 -0300
Bug 19130: Remove ->search() overloading and adjust tests
This patch removes the custom ->search() function. Tests are adjusted
so the results from ->search() calls are not expected to return in the
previously hardcoded order.
To test:
- Apply this patch
- Run:
$ sudo koha-shell kohadev
k$ cd kohaclone
k$ prove t/db_dependent/Bookseller.t
=> SUCCESS: Tests pass
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
Koha/Acquisition/Bookseller.pm | 61 ++++++-
Koha/Acquisition/Booksellers.pm | 41 +++--
acqui/basketheader.pl | 5 +-
acqui/booksellers.pl | 4 +-
acqui/invoices.pl | 2 +-
acqui/transferorder.pl | 4 +-
.../prog/en/modules/acqui/supplier.tt | 2 +-
serials/acqui-search-result.pl | 4 +-
t/db_dependent/Bookseller.t | 2 +-
t/db_dependent/Koha/Acquisition/Booksellers.t | 186 ++++++++++++++++++++
t/db_dependent/Members.t | 4 +
11 files changed, 289 insertions(+), 26 deletions(-)
create mode 100644 t/db_dependent/Koha/Acquisition/Booksellers.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list