[koha-commits] main Koha release repository branch master updated. v17.11.00-15-g7db41b3
Git repo owner
gitmaster at git.koha-community.org
Thu Dec 7 13:43:33 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 7db41b379ff2fbf9827a8b752897bf6ee4409026 (commit)
via f8a25307c4d748ee3646cec8753d91d73f1cd58d (commit)
via e46ab82e2855597274fb927f2eea7265eb4b7565 (commit)
via 7d5488ee280137ee216d53df9f82bd27ee8ff663 (commit)
via 916b057e91f69c86b92bd416011b87cc614632f2 (commit)
via 67741fb69efc071e7dbfea151c919123318089cc (commit)
via 68a6b6bba4058f0c9dda79f3789ce3d8a76bcb56 (commit)
via 4eebaabc2efe3a57e748c053e933d9632fa91efc (commit)
via ebd7c422b48c53fa037b69a9150f8e0460d24418 (commit)
via 1beb65ed4f48af9314ce63ea28054425c1139360 (commit)
via 42e6716546adfaf5ec9bbc6e01e58f19f6473254 (commit)
via 5f7d644001ed0f206d247866e2a461de9a995976 (commit)
via a03e9249f09f9580cb225200544314a709685845 (commit)
via d5a61798522862cb0d230c7a655d5d6999c6940b (commit)
from af7d618d2b12655631e9febae74c222367495900 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7db41b379ff2fbf9827a8b752897bf6ee4409026
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Oct 23 14:00:53 2017 +0000
Bug 10222: Correct and expand to other languages
This added column names, and reformated to be a bit more readable.
This also adds this change to de-DE, es-ES, fr-CA, and nb-NO.
While there was printer_profiles for it-IT, the Italian file seems
to not use the same numbers, and does not visibly look like it needs
these changes.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f8a25307c4d748ee3646cec8753d91d73f1cd58d
Author: Chris Nighswonger <chris.nighswonger at gmail.com>
Date: Thu Apr 16 12:07:29 2015 -0400
Bug 10222: Error when saving Demco label templates
This patch fixes a bug whereby if you open either of the
Demco label templates (loaded by the sample data) and
click "save" without making any changes you will get an
error:
Can't bless non-reference value at C4/Creators/Profile.pm
line 92.
It also fixes another minor bug in the creator sample data.
To test:
1. Install all sample data in a clean database.
2. In the label tool, edit either of the Demco label templates.
3. Save the template and observe the error mentioned above.
4. Drop and recreate the database.
5. Apply the patch.
6. Repeate steps 1-3 and note the successful save.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e46ab82e2855597274fb927f2eea7265eb4b7565
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 28 11:58:46 2017 +0000
Bug 18990: Overdue Notices are not sending through SMS correctly
Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.
It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue
To test:
1 - Define a messaging prefs for a patron to recieve hold notices via
SMS
2 - Ensure you have defined an SMS message for an overdue letter
3 - Set an SMS alert number for patron
4 - Set the SMS::Send driver to 'Email'
5 - Checkout an item as overdue to trigger notice above
6 - Run overdue_notices.pl
6 - Check the db and note the address is email
7 - run process_message_queue.pl
8 - Check db - address is email followed by service provider
9 - Apply patch
10 - repeat
11 - Message to_address should be populated with smsalertnumber
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7d5488ee280137ee216d53df9f82bd27ee8ff663
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 16 19:19:33 2017 +0000
Bug 19643: Pagination buttons on staged marc management are stacking instead of inline
This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.
To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 916b057e91f69c86b92bd416011b87cc614632f2
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Nov 22 13:58:21 2017 -0500
Bug 19681: Correct result count formatting
This simply passes the missing information to the template.
Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 67741fb69efc071e7dbfea151c919123318089cc
Author: Simon Pouchol <simon.pouchol at biblibre.com>
Date: Fri Nov 24 16:53:49 2017 +0100
Bug 19692: fix unclosed div in opac-shelves.tt
Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page
Signed-off-by: Dominic Pichette <dominic at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 68a6b6bba4058f0c9dda79f3789ce3d8a76bcb56
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Oct 26 07:35:53 2017 -0400
Bug 19533: Hold pulldown for itemtype is empty if hold placement needs override
Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4eebaabc2efe3a57e748c053e933d9632fa91efc
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Jun 21 13:05:40 2017 +0200
Bug 18833: Plugin unimarc_field_210c pagination error
In plugin unimarc_field_210c, the editors search results have pagination.
First page works but not other pages.
The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number.
This patch corrects by using a $offset var.
Also removes dead code, obsoleted by using C4::Output::pagination_bar.
Also changes hardcoded results per page from 19 to 20.
Test plan :
- Use UNIMARC catalogue
- Define in framework value builder unimarc_field_210c on 210$c
- Create autority type EDITORS with heading 200$b
- Create 22 authorities of that type
- Index those new authorities
- Create a new biblio record
- Click on 210$c plugin
- Click on "Search"
- You see 20 results
- Click on page 2
=> Without patch you get empty table
=> With patch you get 2 results
- Check that you see "Results 21 to 22 of 22"
- Delete 2 autorities and retest
Works as intended.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebd7c422b48c53fa037b69a9150f8e0460d24418
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Oct 13 06:44:55 2017 +0000
Bug 19456: Make patron-title ability to be generated with or without html tags
Modified pages:
circ/circulation.pl
circ/circulation_batch_checkouts.pl
members/boraccount.pl
members/files.pl
members/holdshistory.pl
members/housebound.pl
members/moremember.pl
members/notices.pl
members/purchase-suggestions.pl
members/readingrec.pl
members/routing-lists.pl
members/statistics.pl
Test plan:
0) Do not apply the patch
1) Have a patron with title/salution filled in
2) Confirm bug, go for example to circ/circulation page and see there is
html in <title> tag (you can see it in your browser page/window title)
3) Apply the patch
4) Go through circulation/patron pages (see modified page above) and
confirm there is no html in <title> tag, but on the page itself the
salutation should be in <span class="patron-title">
Signed-off-by: David Bourgalt <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1beb65ed4f48af9314ce63ea28054425c1139360
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Nov 16 15:22:48 2017 +0100
Bug 19640: fix OPAC IdRef webservice display
The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.
This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio
Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: removed unused @unimarc3 (not to be confused with $unimarc3).
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 42e6716546adfaf5ec9bbc6e01e58f19f6473254
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 24 09:27:14 2017 +0100
Bug 19646: (QA follow-up) Fix tab character
Resolve qa tools warning:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
FAIL forbidden patterns
forbidden pattern: tab char (line 172)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5f7d644001ed0f206d247866e2a461de9a995976
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Nov 17 13:38:06 2017 +0100
Bug 19646: fix value_builder marc21_linking_section template
When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.
It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.
This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="
Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a03e9249f09f9580cb225200544314a709685845
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Nov 22 14:35:27 2017 -0500
Bug 19683: Fix authority types in tools/export template
Fixes the bug by correcting the variable names in the template.
To test:
1) Tools > Export > Export authority records
2) Authority Types dropdown is not empty
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Changing the export script and unblessing is not needed.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d5a61798522862cb0d230c7a655d5d6999c6940b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 6 16:33:56 2017 -0300
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip
This patch fixes the following errors:
The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871.
This is caused by
commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
We are calling ->reserve_id on a Koha::Holds set.
Test plan:
- Serials -> Find subscription -> "Edit routing list" in the sidebar
- Add 1+ recipients
- Save -> "Save and preview routing slip"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 4 +-
C4/Reserves.pm | 5 +-
cataloguing/value_builder/unimarc_field_210c.pl | 52 ++++----------------
.../mysql/de-DE/optional/sample_creator_data.sql | 7 ++-
.../data/mysql/en/optional/sample_creator_data.sql | 7 ++-
.../mysql/es-ES/optional/sample_creator_data.sql | 7 ++-
.../mysql/fr-CA/facultatif/sample_creator_data.sql | 10 ++--
.../nb-NO/2-Valgfritt/sample_creator_data.sql | 7 ++-
.../prog/en/includes/patron-title.inc | 16 ++++--
.../value_builder/marc21_linking_section.tt | 15 +++---
.../prog/en/modules/circ/circulation.tt | 2 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 2 +-
.../prog/en/modules/members/boraccount.tt | 2 +-
.../intranet-tmpl/prog/en/modules/members/files.tt | 2 +-
.../prog/en/modules/members/holdshistory.tt | 2 +-
.../prog/en/modules/members/housebound.tt | 2 +-
.../prog/en/modules/members/moremember.tt | 2 +-
.../prog/en/modules/members/notices.tt | 2 +-
.../en/modules/members/purchase-suggestions.tt | 2 +-
.../prog/en/modules/members/readingrec.tt | 2 +-
.../prog/en/modules/members/routing-lists.tt | 2 +-
.../prog/en/modules/members/statistics.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/export.tt | 2 +-
.../prog/en/modules/tools/manage-marc-import.tt | 6 +--
.../opac-tmpl/bootstrap/en/modules/opac-idref.tt | 8 +--
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
labels/label-item-search.pl | 2 +
opac/opac-idref.pl | 43 +++++++---------
reserve/request.pl | 2 +
t/db_dependent/Holds.t | 11 ++++-
t/db_dependent/Letters.t | 14 +++++-
31 files changed, 126 insertions(+), 118 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list