[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.00-26-g7e691bc
Git repo owner
gitmaster at git.koha-community.org
Thu Dec 14 13:30:36 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 7e691bc6d8695377e12896be085039c81115e4d0 (commit)
via d8a16dd89a2853837e87eec1b1ec0d419ede1b55 (commit)
via b90824527b47e78e56e2f602199481325beeec15 (commit)
via adb37ce8cf10fee1c81ee35d703ec3a81c82697d (commit)
via ca95a10d90ebfec7a82b6224569f29df6059fd5b (commit)
via 9d79d463250c430678f724f265500776f541cd42 (commit)
via 18897829e4bd585d5adb16681ce6dd648b368c66 (commit)
via 8aea1ca0f62acf00b8ffdb881b7293f7c598acd3 (commit)
via f2a74a7f13f236ade27d62275a0dfe51c5aa97e1 (commit)
via 4db611b5dc83e2d865aaba4afe04cd5aaa89904e (commit)
via fff0065785b0cd7e664eac3285a5f051cb94871a (commit)
via 5c58ba6bcc13e7592d8599ab90d3068dc2c127b2 (commit)
via fdde85a52164168d998d995ce41b4421b4a3ffbb (commit)
via d3eef921f501634d3656b9d08abafa55b3ed6c07 (commit)
via a7aab6d30b0a14c58bc0ab355ff284bd60750103 (commit)
via e0c3780634ef35ad937f69721aaeafa7bf9a4fee (commit)
via ef8c92ce21e1ea983da3445045236939b1de90fe (commit)
via 30f2b40f3c408a1f81eae57c5012e6283eccb3d0 (commit)
via e2d05f3fdfde20977ca5525510e8f4c0daa964f1 (commit)
via 455d94eec9c41f7bad718ac62c2367bea6202452 (commit)
via 20b5caa20b06b548b1a521c1a0762f7104427fec (commit)
via 803c70cef8e88dae25394ca7d2fc645f1b514ad8 (commit)
via 58b6f1cd9e466c375526b01b801bb5de61e37706 (commit)
via 5a852cadaf9fddc38618e22d4fad1e1b7a3f9120 (commit)
via 47f65da22e63a35fdecf6857016983869d6855cb (commit)
from 5a458a6e771f4d4675f3c99cd04dae0a387e1fd8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7e691bc6d8695377e12896be085039c81115e4d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 7 10:26:32 2017 -0300
Bug 19724: DBIC Schema changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d8a16dd89a2853837e87eec1b1ec0d419ede1b55
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Jul 6 15:42:43 2017 +0000
Bug 18907: Build has deprecating message
Following the instructions at:
https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way
Receiving the following message in the build:
dpkg-source: warning: relation < is deprecated: use << or <=
This patch tweaks the list-deps.
git diff origin/master -- debian/list-deps shows just the one line
changed from < to << as per the messages suggestion and eythian's
suggestion on IRC:
http://irc.koha-community.org/koha/2017-07-06#i_1950698
The control file can be regenerated from the command-line:
./debian/update-control
However, it will be attached separately.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b90824527b47e78e56e2f602199481325beeec15
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Fri Nov 24 12:02:47 2017 +0100
Bug 12497: Fix OPAC search history reachable by URL even when disabled
Test plan:
1. Set EnableOpacSearchHistory syspref to "Keep"
2. Make a search in the OPAC
3. Go to /cgi-bin/koha/opac-search-history.pl
4. Set the EnableOpacSearchHistory syspref to "Don't keep"
5. Refresh the OPAC page to show that history is still accessible
6. Apply the patch
7. Refresh the OPAC page, you should end on the 404 page
8. Set EnableOpacSearchHistory syspref to "Keep"
9. Go to /cgi-bin/koha/opac-search-history.pl which should be reachable
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit adb37ce8cf10fee1c81ee35d703ec3a81c82697d
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Thu Nov 23 16:03:14 2017 +0100
Bug 12497: Fix search history non-accessible when OPAC was private
(when the user didn't have the "borrowers" permission)
Test plan:
1. Set syspref "OpacPublic" to false (Disable)
2. Log in as a user without any permission
3. Try to access the search history. The link is next to "Log out"
4. Then you should see "Access denied"
5. Apply this patch
6. Refresh the page
7. Then you should see the search history
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ca95a10d90ebfec7a82b6224569f29df6059fd5b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Nov 21 16:17:32 2017 +0000
Bug 19674: Broken indicators of changed fields in manage staged MARC records template
This patch returns some CSS to the manage staged MARC records template
which was incorrectly removed by Gug 16538.
To test, apply the patch and go to Tools -> Staged MARC management.
Choose a staged MARC file.
Changing any of the <select> fields in the first section should cause a
label to appear showing that the selection has changed, along with a
link to reset the option to its original state. Clicking 'Reset' should
make the label and the link disappear.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9d79d463250c430678f724f265500776f541cd42
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 9 16:47:42 2017 +0000
Bug 19602: Add usage statistics link to administration sidebar menu
This patch adds a link to the new usage statistics page in the
administration sidebar menu.
To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.
Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 18897829e4bd585d5adb16681ce6dd648b368c66
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Nov 10 12:59:58 2017 +0000
Bug 19595: Clicking plugin link does not fill item's date acquired field
This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.
To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.
Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Added a comment line in set_to_today.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8aea1ca0f62acf00b8ffdb881b7293f7c598acd3
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Oct 31 13:17:26 2017 +0000
Bug 19551: Fix wrong order of operations in cash register report
To test:
1 - Find or create a fine for a patron
2 - Write it off
3 - Home -> Reports -> Cash register
4 - Fill in current date and transaction type 'Write off'
5 - Click Submit
-- see your write off
6 - Fill in previous dates and transaction type 'Write off'
7 - Click Submit
-- see your write off (bad)
8 - Apply patch
9 - Rerun steps 3-7
-- write only visible for current date.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f2a74a7f13f236ade27d62275a0dfe51c5aa97e1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 14 12:03:10 2017 +0000
Bug 19724: DBRev 17.11.00.001
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4db611b5dc83e2d865aaba4afe04cd5aaa89904e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 14 12:01:38 2017 +0000
Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata
Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)
This patch only adds the missing column in biblio_metadata and
deletedbiblio_metadata
Test plan:
1. Run updatedatabase.pl
2. Verify that both tables have the new column, its value should be the
greatest timestamp value from the corresponding biblio and
biblioitems table entries
You can verify with the following SQL query:
SELECT b.biblionumber, b.timestamp as biblio_ts,
bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts
FROM biblio_metadata m
LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber)
LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druat <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fff0065785b0cd7e664eac3285a5f051cb94871a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 4 15:39:48 2017 -0300
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)
Bug 17898 tries to help users identify reports affected by the move of marcxml to the biblio_metadata table, however, the auth_header table still uses the column name 'marcxml' and so reports as needing updated though it doesn't.
C4::Reports::Guided::convert_sql only converts if the sql query contain biblioitems and marcxml.
We should use the same regexp in the controler script.
Test plan:
Use a sql report that use auth_header.marcxml (see https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the report list view
Replicated bug with the following SQL:
select marcxml from auth_header;
Patch applied correctly and functioned as expected.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5c58ba6bcc13e7592d8599ab90d3068dc2c127b2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 7 09:47:28 2017 -0300
Bug 7143: Update about page for new dev - Simon Pouchol
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fdde85a52164168d998d995ce41b4421b4a3ffbb
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Oct 23 14:00:53 2017 +0000
Bug 10222: Correct and expand to other languages
This added column names, and reformated to be a bit more readable.
This also adds this change to de-DE, es-ES, fr-CA, and nb-NO.
While there was printer_profiles for it-IT, the Italian file seems
to not use the same numbers, and does not visibly look like it needs
these changes.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d3eef921f501634d3656b9d08abafa55b3ed6c07
Author: Chris Nighswonger <chris.nighswonger at gmail.com>
Date: Thu Apr 16 12:07:29 2015 -0400
Bug 10222: Error when saving Demco label templates
This patch fixes a bug whereby if you open either of the
Demco label templates (loaded by the sample data) and
click "save" without making any changes you will get an
error:
Can't bless non-reference value at C4/Creators/Profile.pm
line 92.
It also fixes another minor bug in the creator sample data.
To test:
1. Install all sample data in a clean database.
2. In the label tool, edit either of the Demco label templates.
3. Save the template and observe the error mentioned above.
4. Drop and recreate the database.
5. Apply the patch.
6. Repeate steps 1-3 and note the successful save.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a7aab6d30b0a14c58bc0ab355ff284bd60750103
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 28 11:58:46 2017 +0000
Bug 18990: Overdue Notices are not sending through SMS correctly
Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.
It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue
To test:
1 - Define a messaging prefs for a patron to recieve hold notices via
SMS
2 - Ensure you have defined an SMS message for an overdue letter
3 - Set an SMS alert number for patron
4 - Set the SMS::Send driver to 'Email'
5 - Checkout an item as overdue to trigger notice above
6 - Run overdue_notices.pl
6 - Check the db and note the address is email
7 - run process_message_queue.pl
8 - Check db - address is email followed by service provider
9 - Apply patch
10 - repeat
11 - Message to_address should be populated with smsalertnumber
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e0c3780634ef35ad937f69721aaeafa7bf9a4fee
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 16 19:19:33 2017 +0000
Bug 19643: Pagination buttons on staged marc management are stacking instead of inline
This patch modifies the template for staged MARC import management to
correct a problem with the style of pagination links.
To test you must have more than 25 staged imports. Go to Tools -> Staged
MARC management. The pagination links, both at the top and the bottom,
should look correct (use multi-page SQL report results for reference).
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ef8c92ce21e1ea983da3445045236939b1de90fe
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Nov 22 13:58:21 2017 -0500
Bug 19681: Correct result count formatting
This simply passes the missing information to the template.
Test plan:
0) Apply patch
1) Go to Tools > Label creator > New > Label batch
2) Press 'Add items'
3) Do a search that will return few items
4) The result count will read "Results 1 through X of X"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 30f2b40f3c408a1f81eae57c5012e6283eccb3d0
Author: Simon Pouchol <simon.pouchol at biblibre.com>
Date: Fri Nov 24 16:53:49 2017 +0100
Bug 19692: fix unclosed div in opac-shelves.tt
Test plan:
1. set syspref OpacKohaUrl to "Show"
2. Log into the OPAC
3. /cgi-bin/koha/opac-shelves.pl
4. Notice that "Powered by Koha" is not in the footer in this page.
When on the other tabs it's in the footer (out of .main)
5. Apply this patch
6. Notice that "Powered by Koha" now in the footer in the "your lists" page
Signed-off-by: Dominic Pichette <dominic at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e2d05f3fdfde20977ca5525510e8f4c0daa964f1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Oct 26 07:35:53 2017 -0400
Bug 19533: Hold pulldown for itemtype is empty if hold placement needs override
Test Plan:
1) Enable AllowHoldPolicyOverride
2) Enable AllowHoldItemTypeSelection
3) Create a situation where adding a hold for a patron would trigger a tooManyReserves
warning.
4) Note the itemtype pulldown is empty
5) Apply this patch
6) Reload the page
7) Itemtype pulldown should have values
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 455d94eec9c41f7bad718ac62c2367bea6202452
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Jun 21 13:05:40 2017 +0200
Bug 18833: Plugin unimarc_field_210c pagination error
In plugin unimarc_field_210c, the editors search results have pagination.
First page works but not other pages.
The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number.
This patch corrects by using a $offset var.
Also removes dead code, obsoleted by using C4::Output::pagination_bar.
Also changes hardcoded results per page from 19 to 20.
Test plan :
- Use UNIMARC catalogue
- Define in framework value builder unimarc_field_210c on 210$c
- Create autority type EDITORS with heading 200$b
- Create 22 authorities of that type
- Index those new authorities
- Create a new biblio record
- Click on 210$c plugin
- Click on "Search"
- You see 20 results
- Click on page 2
=> Without patch you get empty table
=> With patch you get 2 results
- Check that you see "Results 21 to 22 of 22"
- Delete 2 autorities and retest
Works as intended.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 20b5caa20b06b548b1a521c1a0762f7104427fec
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Oct 13 06:44:55 2017 +0000
Bug 19456: Make patron-title ability to be generated with or without html tags
Modified pages:
circ/circulation.pl
circ/circulation_batch_checkouts.pl
members/boraccount.pl
members/files.pl
members/holdshistory.pl
members/housebound.pl
members/moremember.pl
members/notices.pl
members/purchase-suggestions.pl
members/readingrec.pl
members/routing-lists.pl
members/statistics.pl
Test plan:
0) Do not apply the patch
1) Have a patron with title/salution filled in
2) Confirm bug, go for example to circ/circulation page and see there is
html in <title> tag (you can see it in your browser page/window title)
3) Apply the patch
4) Go through circulation/patron pages (see modified page above) and
confirm there is no html in <title> tag, but on the page itself the
salutation should be in <span class="patron-title">
Signed-off-by: David Bourgalt <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 803c70cef8e88dae25394ca7d2fc645f1b514ad8
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Nov 16 15:22:48 2017 +0100
Bug 19640: fix OPAC IdRef webservice display
The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.
This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio
Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: removed unused @unimarc3 (not to be confused with $unimarc3).
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 58b6f1cd9e466c375526b01b801bb5de61e37706
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 24 09:27:14 2017 +0100
Bug 19646: (QA follow-up) Fix tab character
Resolve qa tools warning:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
FAIL forbidden patterns
forbidden pattern: tab char (line 172)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5a852cadaf9fddc38618e22d4fad1e1b7a3f9120
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Nov 17 13:38:06 2017 +0100
Bug 19646: fix value_builder marc21_linking_section template
When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.
It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.
This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="
Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 47f65da22e63a35fdecf6857016983869d6855cb
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Nov 22 14:35:27 2017 -0500
Bug 19683: Fix authority types in tools/export template
Fixes the bug by correcting the variable names in the template.
To test:
1) Tools > Export > Export authority records
2) Authority Types dropdown is not empty
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Changing the export script and unblessing is not needed.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 4 +-
Koha/Schema/Result/BiblioMetadata.pm | 18 ++++++-
Koha/Schema/Result/DeletedbiblioMetadata.pm | 18 ++++++-
cataloguing/value_builder/dateaccessioned.pl | 7 +--
cataloguing/value_builder/unimarc_field_210c.pl | 52 ++++----------------
debian/list-deps | 2 +-
docs/history.txt | 2 +
.../mysql/de-DE/optional/sample_creator_data.sql | 7 ++-
.../data/mysql/en/optional/sample_creator_data.sql | 7 ++-
.../mysql/es-ES/optional/sample_creator_data.sql | 7 ++-
.../mysql/fr-CA/facultatif/sample_creator_data.sql | 10 ++--
installer/data/mysql/kohastructure.sql | 8 ++-
.../nb-NO/2-Valgfritt/sample_creator_data.sql | 7 ++-
installer/data/mysql/updatedatabase.pl | 22 +++++++++
.../intranet-tmpl/prog/en/includes/admin-menu.inc | 1 +
.../prog/en/includes/patron-title.inc | 16 ++++--
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +-
.../value_builder/marc21_linking_section.tt | 15 +++---
.../prog/en/modules/circ/circulation.tt | 2 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 2 +-
.../prog/en/modules/members/boraccount.tt | 2 +-
.../intranet-tmpl/prog/en/modules/members/files.tt | 2 +-
.../prog/en/modules/members/holdshistory.tt | 2 +-
.../prog/en/modules/members/housebound.tt | 2 +-
.../prog/en/modules/members/moremember.tt | 2 +-
.../prog/en/modules/members/notices.tt | 2 +-
.../en/modules/members/purchase-suggestions.tt | 2 +-
.../prog/en/modules/members/readingrec.tt | 2 +-
.../prog/en/modules/members/routing-lists.tt | 2 +-
.../prog/en/modules/members/statistics.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/export.tt | 2 +-
.../prog/en/modules/tools/manage-marc-import.tt | 7 ++-
.../opac-tmpl/bootstrap/en/modules/opac-idref.tt | 8 +--
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
labels/label-item-search.pl | 2 +
opac/opac-idref.pl | 43 +++++++---------
opac/opac-search-history.pl | 6 ++-
reports/cash_register_stats.pl | 2 +-
reports/guided_reports.pl | 2 +-
reserve/request.pl | 2 +
t/db_dependent/Letters.t | 14 +++++-
41 files changed, 191 insertions(+), 129 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list