[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.06-9-g6423550

Wed Dec 20 09:20:10 CET 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  642355033e38bfb60144c4384f08e7a4b01b3e23 (commit)
       via  aa3d1a469d4af69bdd5676cfc963905572574ae6 (commit)
       via  6187322aa265345199b086b62401c9d1ea7c3f6b (commit)
       via  db0e8e6e8f38189ba29465dc20f4a0514d082c14 (commit)
       via  aca184c05391d3502d8b898a022a84e295f8956d (commit)
      from  24a6ef2ba16f18923a5fd9d9439cfe7c84d9ca20 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 642355033e38bfb60144c4384f08e7a4b01b3e23
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jun 21 13:05:40 2017 +0200

    Bug 18833: Plugin unimarc_field_210c pagination error

    In plugin unimarc_field_210c, the editors search results have pagination.
    First page works but not other pages.

    The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number.
    This patch corrects by using a $offset var.
    Also removes dead code, obsoleted by using C4::Output::pagination_bar.
    Also changes hardcoded results per page from 19 to 20.

    Test plan :
    - Use UNIMARC catalogue
    - Define in framework value builder unimarc_field_210c on 210$c
    - Create autority type EDITORS with heading 200$b
    - Create 22 authorities of that type
    - Index those new authorities
    - Create a new biblio record
    - Click on 210$c plugin
    - Click on "Search"
    - You see 20 results
    - Click on page 2
    => Without patch you get empty table
    => With patch you get 2 results
    - Check that you see "Results 21 to 22 of 22"
    - Delete 2 autorities and retest

    Works as intended.

    Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 455d94eec9c41f7bad718ac62c2367bea6202452)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aa3d1a469d4af69bdd5676cfc963905572574ae6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Nov 16 15:22:48 2017 +0100

    Bug 19640: fix OPAC IdRef webservice display

    The OPAC webservice IdRef display was broken.
    The call returns results but citations where empty.
    Maybe the webservice has changed.

    This patch corrects the fetch of datas in result.
    Also fixes a small HTML missing tag tr.
    Also adds a comment with link to official doc :
    http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

    Test plan :
    1) Enable system preference IdRef
    2) Choose an existing PPN like 032581270
    3) Look result on : https://www.idref.fr/services/biblio/032581270.json
    4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
    5) Without patch you see only one role containing empty rows
    6) With patch you see all roles with correct rows

    Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended: removed unused @unimarc3 (not to be confused with $unimarc3).

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 803c70cef8e88dae25394ca7d2fc645f1b514ad8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6187322aa265345199b086b62401c9d1ea7c3f6b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 24 09:27:14 2017 +0100

    Bug 19646: (QA follow-up) Fix tab character

    Resolve qa tools warning:
     FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
       FAIL   forbidden patterns
                    forbidden pattern: tab char (line 172)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 58b6f1cd9e466c375526b01b801bb5de61e37706)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit db0e8e6e8f38189ba29465dc20f4a0514d082c14
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Nov 17 13:38:06 2017 +0100

    Bug 19646: fix value_builder marc21_linking_section template

    When using marc21_linking_section cataloging plugin, you get the error :
    Template process failed: undef error - The method selected is not
    covered by tests! at /home/koha/src/C4/Templates.pm line 122.

    It commes from [% IF ( itypeloo.selected ) %], selected is not defined
    in itypeloo.

    This patch removes this condition because all item types are fetched
    from database, there is not one selected. It sets "All item types" as
    selected. Also correctes two errors in HTML : ending form and div,
    "<a_class=" instead of "<a class="

    Test plan :
    1) Use a MARC21 database
    2) Define marc21_linking_section cataloging plugin in framework, on
       773$t for example
    3) Create a new biblio record
    4) Click on icon in 773$t
    5) Check plugin works fine

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5a852cadaf9fddc38618e22d4fad1e1b7a3f9120)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aca184c05391d3502d8b898a022a84e295f8956d
Author: David Bourgault <david.bourgault at inlibro.com>
Date:   Wed Nov 22 14:35:27 2017 -0500

    Bug 19683: Fix authority types in tools/export template

    Fixes the bug by correcting the variable names in the template.

    To test:
    1) Tools > Export > Export authority records
    2) Authority Types dropdown is not empty

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended: Changing the export script and unblessing is not needed.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 47f65da22e63a35fdecf6857016983869d6855cb)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 cataloguing/value_builder/unimarc_field_210c.pl    |   52 ++++----------------
 .../value_builder/marc21_linking_section.tt        |   15 +++---
 .../intranet-tmpl/prog/en/modules/tools/export.tt  |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-idref.tt   |    8 +--
 opac/opac-idref.pl                                 |   43 +++++++---------
 5 files changed, 38 insertions(+), 82 deletions(-)

hooks/post-receive
-- 
main Koha release repository