[koha-commits] main Koha release repository branch master updated. v16.11.00-390-gac99f64

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ac99f64010c6bdbe40abc2b823c2180b9b223425 (commit)
      from  95873bfa88d3f18350acdd3fea3d421083a59950 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ac99f64010c6bdbe40abc2b823c2180b9b223425
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 8 12:41:37 2017 +0100

    Bug 18076: Replace holds_to_place_count with an input type=text
    
    From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE
    
    """
    The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops which
     would otherwise never terminate. If the loop exceeds 1000 iterations then an undef
    exception will be thrown, reporting the error:
    
    WHILE loop terminated (> 1000 iterations)
    
    The $Template::Directive::WHILE_MAX variable controls this behaviour and can be set
    to a higher value if necessary.
    """
    
    I do not think we want to increase this value, and I do not think we want to display a
    dropdown list with 1000 entries.
    
    This patch replaces the dropdown list with an input text.
    
    Test plan:
    - Set circulation conditions - holds per record = 999
    - Search for record with items
    - Go to the holds tab
    - Search for a patron
    - Verify that when you send your search, the 'internal server error' is not shown
    and you see the input text.
    You should be able to enter a value > than 999 and < 1
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository