[koha-commits] main Koha release repository branch master updated. v16.11.00-403-gbcd566c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  bcd566c5f6a847d7b3f359af119bb8218f23bf77 (commit)
       via  ad38b24308df1cd3d451302d2ada3a4e59c45b62 (commit)
       via  24ac8392b39ac82b528cb931e97c19c0e582fbf8 (commit)
       via  ac004aa63ec4dfbb73329d150ef6b32ac8ea5e87 (commit)
      from  dbada67196818834f158890c0c348c0259085f7e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bcd566c5f6a847d7b3f359af119bb8218f23bf77
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Feb 3 13:31:56 2017 +0100

    Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison
    
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit ad38b24308df1cd3d451302d2ada3a4e59c45b62
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Jan 30 15:19:35 2017 +0100

    Bug 18014: AddAuthority should respect AUTO_INCREMENT
    
    Instead of using the MAX(authid)+1 logic, AddAuthority should just save
    the record and get the new id. The authid column is an autoincrement.
    
    This eliminates problems where a newly assigned authid also refers to a
    previously deleted record. (And it will not cause problems when refining
    the dontmerge functionality on report 9988.)
    
    Note: ModAuthority also calls AddAuthority to update an existing record; in
    that case we should not create a new record even if the record should not
    be found any more (which should be exceptional).
    
    This patch also simplifies handling of 001 in the authority record: in all
    cases this field is updated now; no need to check its contents.
    
    Test plan:
    [1] Run t/db_dependent/AuthoritiesMarc.t
    [2] Add a new authority record via the interface
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 24ac8392b39ac82b528cb931e97c19c0e582fbf8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Jan 31 09:11:05 2017 +0100

    Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority
    
    Since AddAuthority uses max(id)+1 logic to produce the next authid,
    authority id's will be reused when you delete the last record. This may
    be a source of problems and will be addressed on the next patch.
    
    This patch add a test to expose the problem.
    
    Test plan:
    [1] Run t/db_dependent/AuthoritiesMarc.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit ac004aa63ec4dfbb73329d150ef6b32ac8ea5e87
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Jan 31 08:59:45 2017 +0100

    Bug 18014: General update of AuthoritiesMarc.t
    
    Modern::Perl, Koha::Database, etc.
    
    Test plan:
    Run t/db_dependent/AuthoritiesMarc.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm            |   45 ++++++++++++--------------------------
 t/db_dependent/AuthoritiesMarc.t |   28 +++++++++++++++++++-----
 2 files changed, 36 insertions(+), 37 deletions(-)


hooks/post-receive
-- 
main Koha release repository