[koha-commits] main Koha release repository branch master updated. v16.11.00-409-g5c1daf0

Git repo owner gitmaster at git.koha-community.org
Tue Feb 14 15:16:28 CET 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  5c1daf010ec97ed405bf7825eaa8143c225252b1 (commit)
       via  460c9b1b1594b8beebedbc28809fe47bc8d3313c (commit)
      from  2e315c0cc6f31991868b17276807f28cdcce4306 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5c1daf010ec97ed405bf7825eaa8143c225252b1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Jan 24 16:39:28 2017 +0100

    Bug 17982: Fix the use of uniq in sub themelanguage
    
    Doing uniq( \@themes ) is useless. It will just return to you the only
    reference you gave it.
    List::MoreUtils::uniq requires a list instead of an arrayref.
    So it is a trivial fix that makes sub themelanguage return one theme instead
    of three themes like [ 'prog', 'prog',  'prog' ].
    Note that Template->new inserts one or two include paths to TT for each of
    these three identical themes.
    
    Test plan:
    [1] Run t/db_dependent/Templates.t (should no longer fail)
    [2] Run t/db_dependent/Auth.t (triggering themelanguage)
    [3] Open a page on OPAC or intranet. (Did you restart Plack?)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    EDIT (Marcel): Amended test plan for additional unit test.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 460c9b1b1594b8beebedbc28809fe47bc8d3313c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Feb 2 08:40:58 2017 +0100

    Bug 17982: Expose wrong use of uniq
    
    This test should fail without the patch fixing the uniq calls.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Templates.pm            |    6 +++---
 t/db_dependent/Templates.t |   15 ++++++++++++++-
 2 files changed, 17 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list