[koha-commits] main Koha release repository branch master updated. v16.11.00-181-g5a08969

Git repo owner gitmaster at git.koha-community.org
Fri Jan 13 12:35:34 CET 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  5a08969a71dc27562a1a22af809673a8727f5c82 (commit)
      from  14c34c0c687ddece0708baf3dfc0cc43f1c5b8be (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5a08969a71dc27562a1a22af809673a8727f5c82
Author: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Date:   Tue Dec 13 14:57:52 2016 +0100

    Bug 17766 - Patron notification does not work with multi item holds
    
    This patch fixes notification when same biblio has multiple reserves with same borrower,
    introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method
    _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id.
    
    To test:
    Prerequisites:
    - One biblio with two items attached
    - A patron with hold_filled notification activated
    - A letter for HOLD with <<reserves.reserve_id>> in it
    1) Place two reservations on same biblio
    2) checkin item x on pickup branch, observe patron message generated
    3) checkin item y on pickup branch, observe patron message generated
    4) note that reserve_id is the same on both messages, which is wrong
    5) apply this patch and repeat 1-3
    6) now observe notifications have correct (different) reserve_id
    
    Signed-off-by: Hugo Agud <hagud at orex.es>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                              |   39 +++++++++++----------------
 t/db_dependent/Reserves/MultiplePerRecord.t |    3 +++
 2 files changed, 19 insertions(+), 23 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list