[koha-commits] main Koha release repository branch master updated. v16.11.00-195-g6caac44

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6caac44a94b6eeac489aeea1fa66472022d4e72a (commit)
       via  141d29358f15eed2659de041ee5c4295c24e0fb5 (commit)
      from  d3752c85dc2f5af974ec2fe4585efa8510302968 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6caac44a94b6eeac489aeea1fa66472022d4e72a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Dec 30 18:42:37 2016 +0000

    Bug 6782 [QA Followup] - Remove unused param and limit calls to Koha.Preference
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 141d29358f15eed2659de041ee5c4295c24e0fb5
Author: Meenakshi.R <meenakshi.r at osslabs.biz>
Date:   Wed Jun 6 16:46:15 2012 +0530

    Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions).
    
    Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur.
    
    This change moves the card number generation to occur after the "Save" button is pressed.
    
    Changes:
    -C4/Members.pm:
    Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON.
    -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
    Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON.
    -members/memberentry.pl:
    Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation.
    
    Test cases:
    -If "autoMemberNum" ON:
    ->In blank case, must generate auto card number in simulataneous users.
    ->If user entered, check for unique card number.
    
    -If "autoMemberNum" OFF:
    Must work normal.
    
    Followed test plan, works as expected.
    Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise
          you can not save. Maybe that should be mentioned in the comment for
          syspref autoMemberNum.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                         |    6 ++++++
 .../prog/en/modules/members/memberentrygen.tt         |   17 +++++++++++------
 members/memberentry.pl                                |    1 -
 3 files changed, 17 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository